Am 20.07.2011 15:56, schrieb Frediano Ziglio:
> These patches mostly cleanup some AIO code using coroutines.
> These patches apply to Kevin's repository, branch coroutine-block.
> Mostly they use stack instead of allocated AIO structure.
>
> Frediano Ziglio (5):
> qcow: allocate QCowAIOCB struct
On 07/21/2011 10:55 PM, Blue Swirl wrote:
On Wed, Jul 20, 2011 at 7:49 PM, Avi Kivity wrote:
> As with the rest of the memory API, the caller associates an eventfd
> with an address, and the memory API takes care of registering or
> unregistering when the address is made visible or invisible
Am 21.07.2011 17:01, schrieb Stefan Hajnoczi:
> On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake wrote:
>> Thank you for persisting - you've found another hole that needs to be
>> plugged. It sounds like you are proposing that after a qemu process dies,
>> that libvirt re-reads the qcow2 metadata head
On 07/20/2011 04:51 PM, Kevin Wolf wrote:
>
> The problem is that QEMU will find backing file file names inside the
> images which it will be unable to open. How do you suggest we get around
> that?
This is the part with allowing libvirt to override the backing file. Of
course, this is not so
Am 21.07.2011 18:32, schrieb Anthony Liguori:
> Just as we're now realizing that we need to do dramatic things in the
> block layer to make -blockdev work, I'm sure we're going to realize that
> we want to do PCI hotplug of virtio-serial and therefore we need to do
> dynamic creation/destruction
Am 21.07.2011 18:17, schrieb Frediano Ziglio:
> Hi,
> after a snapshot is taken currently many write operations are quite
> slow due to
> - refcount updates (decrement old and increment new )
> - cluster allocation and file expansion
> - read-modify-write on partial clusters
>
> I found 2 way to
Am 22.07.2011 09:36, schrieb Avi Kivity:
> On 07/20/2011 04:51 PM, Kevin Wolf wrote:
>>>
>>> The problem is that QEMU will find backing file file names inside the
>>> images which it will be unable to open. How do you suggest we get around
>>> that?
>>
>> This is the part with allowing libvirt t
At Fri, 22 Jul 2011 07:44:27 +0200,
Stefan Weil wrote:
> This change is needed because commit 06e12b65
> now uses an unsigned long long value
> (uint64_t && unsigned long long => unsigned long long).
>
> Cc: Tsuneo Saito
> Cc: Blue Swirl
> Signed-off-by: Stefan Weil
I'm sorry, my patch has br
These patches mostly cleanup some AIO code using coroutines.
These patches apply to Kevin's repository, branch coroutine-block.
Mostly they use stack instead of allocated AIO structure.
Frediano Ziglio (5):
qcow: allocate QCowAIOCB structure using stack
qcow: QCowAIOCB field cleanup
qcow: mo
instead of calling qemi_aio_get use stack
Signed-off-by: Frediano Ziglio
---
block/qcow.c | 52
block/qcow2.c | 38 +++---
2 files changed, 27 insertions(+), 63 deletions(-)
diff --git a/block/qcow.c b/blo
remove unused field from this structure and put some of them in
qcow_aio_read_cb and qcow_aio_write_cb
Signed-off-by: Frediano Ziglio
---
block/qcow.c | 135 +++---
1 files changed, 63 insertions(+), 72 deletions(-)
diff --git a/block/qcow.c
Signed-off-by: Frediano Ziglio
---
block/qcow.c | 287 -
1 files changed, 121 insertions(+), 166 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 015a472..2feb7d7 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -486,221 +486,17
Define a state callback and make that generate chardev open/close events when
called by the spice-server. Note the code ignores these events for a spicevmc
with a subtypem of vdagent, this subtype specific knowledge is undesirable,
but unavoidable, see:
http://lists.freedesktop.org/archives/spice-d
Signed-off-by: Frediano Ziglio
---
block/qcow.c | 63 --
1 files changed, 0 insertions(+), 63 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 2feb7d7..42331c7 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -190,24 +190,6 @@
On 2011-07-22 07:32, Michael S. Tsirkin wrote:
>> diff --git a/hw/pcie_host.c b/hw/pcie_host.c
>> index b749865..ed6656b 100644
>> --- a/hw/pcie_host.c
>> +++ b/hw/pcie_host.c
>> @@ -57,22 +57,22 @@ static void pcie_mmcfg_data_write(PCIBus *s,
>> {
>> PCIDevice *pci_dev = pcie_dev_find_by_mmc
Signed-off-by: Frediano Ziglio
---
block/qcow.c | 53 ++---
1 files changed, 26 insertions(+), 27 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index e52df91..015a472 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -520,35 +520,18 @@ sta
On Fri, Jul 22, 2011 at 8:22 AM, Kevin Wolf wrote:
> Am 21.07.2011 17:01, schrieb Stefan Hajnoczi:
>> On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake wrote:
>>> Thank you for persisting - you've found another hole that needs to be
>>> plugged. It sounds like you are proposing that after a qemu proce
2011/7/22 Kevin Wolf :
> Am 21.07.2011 18:17, schrieb Frediano Ziglio:
>> Hi,
>> after a snapshot is taken currently many write operations are quite
>> slow due to
>> - refcount updates (decrement old and increment new )
>> - cluster allocation and file expansion
>> - read-modify-write on partial
On Fri, Jul 22, 2011 at 7:48 AM, Kevin Wolf wrote:
> Am 21.07.2011 17:23, schrieb Stefan Hajnoczi:
>> On Fri, Jul 15, 2011 at 06:47:39PM +0200, Kevin Wolf wrote:
>>> If we're already in a coroutine, there is no reason to use the synchronous
>>> version of block layer functions when a coroutine one
Signed-off-by: Zhi Yong Wu
---
Makefile.objs |2 +-
block.c | 248 +
block.h |1 -
block/blk-queue.c | 99 +
block/blk-queue.h | 73
block_int.h | 21 +
blockd
The main goal of the patch is to effectively cap the disk I/O speed or counts
of one single VM.
It is only one draft, so it unavoidably has some drawbacks, if you catch them,
please let me know.
The patch will mainly introduce one global timer and one block queue for each
I/O limits enabled dri
2011/7/22 Kevin Wolf :
> Am 20.07.2011 15:56, schrieb Frediano Ziglio:
>> These patches mostly cleanup some AIO code using coroutines.
>> These patches apply to Kevin's repository, branch coroutine-block.
>> Mostly they use stack instead of allocated AIO structure.
>>
>> Frediano Ziglio (5):
>> q
Am 22.07.2011 11:13, schrieb Frediano Ziglio:
> 2011/7/22 Kevin Wolf :
>> Am 21.07.2011 18:17, schrieb Frediano Ziglio:
>>> Hi,
>>> after a snapshot is taken currently many write operations are quite
>>> slow due to
>>> - refcount updates (decrement old and increment new )
>>> - cluster allocatio
On Fri, Jul 22, 2011 at 10:13 AM, Frediano Ziglio wrote:
> 2011/7/22 Kevin Wolf :
>> Am 21.07.2011 18:17, schrieb Frediano Ziglio:
>>> Hi,
>>> after a snapshot is taken currently many write operations are quite
>>> slow due to
>>> - refcount updates (decrement old and increment new )
>>> - clust
2011/7/22 Kevin Wolf :
> Am 20.07.2011 15:56, schrieb Frediano Ziglio:
>> Signed-off-by: Frediano Ziglio
>> ---
>> block/qcow.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> Subject needs a "qcow: ..."
>
> Kevin
>
Yes, now I removed that patch as with argument on stack it ju
On 07/22/11 10:52, Hans de Goede wrote:
Define a state callback and make that generate chardev open/close events when
called by the spice-server. Note the code ignores these events for a spicevmc
with a subtypem of vdagent, this subtype specific knowledge is undesirable,
but unavoidable, see:
htt
Define a state callback and make that generate chardev open/close events when
called by the spice-server. Note the code ignores these events for a spicevmc
with a subtypem of vdagent, this subtype specific knowledge is undesirable,
but unavoidable, see:
http://lists.freedesktop.org/archives/spice-d
Hi,
On 07/22/2011 11:32 AM, Gerd Hoffmann wrote:
On 07/22/11 10:52, Hans de Goede wrote:
Define a state callback and make that generate chardev open/close events when
called by the spice-server. Note the code ignores these events for a spicevmc
with a subtypem of vdagent, this subtype specific
Am 22.07.2011 11:17, schrieb Stefan Hajnoczi:
> On Fri, Jul 22, 2011 at 7:48 AM, Kevin Wolf wrote:
>> Am 21.07.2011 17:23, schrieb Stefan Hajnoczi:
>>> On Fri, Jul 15, 2011 at 06:47:39PM +0200, Kevin Wolf wrote:
If we're already in a coroutine, there is no reason to use the synchronous
v
Am 22.07.2011 11:26, schrieb Frediano Ziglio:
> 2011/7/22 Kevin Wolf :
>> Am 20.07.2011 15:56, schrieb Frediano Ziglio:
>>> These patches mostly cleanup some AIO code using coroutines.
>>> These patches apply to Kevin's repository, branch coroutine-block.
>>> Mostly they use stack instead of alloca
Am 20.07.2011 12:34, schrieb Kevin Wolf:
> (Reposting only changed or new patches)
>
> The following changes since commit 89b9ba661bd2d6155308f895ec075d813f0e129b:
>
> Fix signal handling of SIG_IPI when io-thread is enabled (2011-07-16
> 19:43:00 +)
>
> are available in the git repositor
This patchset is a final chunk of fixes to UNDEF and UNPREDICTABLE
cases; this lot were flushed out by doing a brute-force exercising
of the decoder on all possible input instruction values. (There
are some remaining issues I identified with that check, but they are
all of the form "complains about
Handle the UNDEF and UNPREDICTABLE cases for VLDM and VSTM. In
particular, we now generate an undef exception for overlarge imm8
values rather than generating 1000+ TCG ops and hitting an assertion.
Signed-off-by: Peter Maydell
---
target-arm/translate.c | 38 +++---
Remove some stray printfs for cases which don't generally happen
(some VFP UNDEF cases, reads and writes to unknown cp14 registers);
we should simply generate an UNDEF when the instruction is executed.
Signed-off-by: Peter Maydell
---
target-arm/translate.c |6 --
1 files changed, 0 inse
VCVTT/VCVTB with bit 8 set is UNPREDICTABLE; we choose to UNDEF.
This avoids a TCG assert later when the VCVTT/VCVTB code tries to
use a source register that wasn't ever set up.
We pull the check for the presence of the half-precision extension
up in to this common code as well.
Signed-off-by: Pe
On 2011-07-21 20:19, Sinha, Ani wrote:
> Hi Folks :
>
> I am trying to assinga bcm netextreme II 10 G eth device to a guest using
> PCI passthrough in QEMU.
>
> 01:00.0 Ethernet controller: Broadcom Corporation NetXtreme II BCM57711
> 10-Gigabit PCIe
> 01:00.1 Ethernet controller: Broadcom Corpo
On Fri, Jul 22, 2011 at 10:20 AM, Zhi Yong Wu wrote:
> +static void bdrv_block_timer(void *opaque)
> +{
> + BlockDriverState *bs = opaque;
> + BlockQueue *queue = bs->block_queue;
> + uint64_t intval = 1;
> +
> + while (!QTAILQ_EMPTY(&queue->requests)) {
> + BlockIORequest *requ
On Fri, Jul 22, 2011 at 11:10 AM, Kevin Wolf wrote:
> Am 22.07.2011 11:26, schrieb Frediano Ziglio:
>> - you can use scripts/checkpatch.pl to check your patches before send
I updated the SubmitAPatch wiki earlier this week.
Stefan
We can express the VCPU thread wakeup with the stop mechanism, saving
both qemu_system_ready and the qemu_system_cond. For KVM threads, we can
just enter the main loop as long as the thread is stopped. The central
TCG thread is better held back before the loop as there can be side
effects of the se
Ping?
On Mon, Jul 04, 2011 at 06:10:43PM +0200, Christophe Fergeau wrote:
> vcard_emul_mirror_card and vcard_emul_init use
> vcard_emul_alloc_arrays to allocate memory for temporary arrays
> which will contain elements that in the end will be used one by
> one in cac_card_init. The arrays themselv
Hi,
This is a resend of my series of libcacard fixes, no change since last
version apart from the added "Reviewed-by" tag.
Changes since v2:
- added Reviewed-by: Alon Levy to the 4 patches
Changes since v1:
- split first patch into 3 patches, v1 2/2 is unchanged
Christophe Fergeau (4):
libca
vcard_emul_options now has repetitive code to read the current
token and advance to the next. After the previous changes,
this repetitive code can be moved in a NEXT_TOKEN macro to
avoid having this code duplicated.
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard/vcard_em
copy_string reimplements strndup, this commit removes it and
replaces all copy_string uses with strndup.
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard/vcard_emul_nss.c | 23 ++-
1 files changed, 6 insertions(+), 17 deletions(-)
diff --git a/libcac
The previous parser had copy and paste errors when computing
vname_length and type_params_length, "name" was used instead
of respectively vname and type_params. This led to length that could
be bigger than the input string, and to access out of the array
bounds when trying to copy these strings. va
vcard_emul_mirror_card and vcard_emul_init use
vcard_emul_alloc_arrays to allocate memory for temporary arrays
which will contain elements that in the end will be used one by
one in cac_card_init. The arrays themselves are never stored
anywhere, they are only used as temporary containers. Hence
the
Hi,
This is a resend of my series of libcacard fixes, with the correct patches this
time.
Changes since v3:
- the series now includes the intended patches
Changes since v2:
- added Reviewed-by: Alon Levy to the 4 patches
Changes since v1:
- split first patch into 3 patches, v1 2/2 is unchanged
vcard_emul_options now has repetitive code to read the current
token and advance to the next. After the previous changes,
this repetitive code can be moved in a NEXT_TOKEN macro to
avoid having this code duplicated.
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard/vcard_em
copy_string reimplements strndup, this commit removes it and
replaces all copy_string uses with strndup.
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard/vcard_emul_nss.c | 23 ++-
1 files changed, 6 insertions(+), 17 deletions(-)
diff --git a/libcac
The previous parser had copy and paste errors when computing
vname_length and type_params_length, "name" was used instead
of respectively vname and type_params. This led to length that could
be bigger than the input string, and to access out of the array
bounds when trying to copy these strings. va
vcard_emul_options used args = strip(args++) a few times, which
was not returning the expected result since the rest of the code
expected args to be increased by at least 1, which is not the case
if *args is not a blank space when this function is called.
Replace these calls by "strip(args+1)" whic
On Fri, Jul 22, 2011 at 01:33:26PM +0200, Christophe Fergeau wrote:
> This is a resend of my series of libcacard fixes, no change since last
> version apart from the added "Reviewed-by" tag.
Scratch that, I put the wrong patches in the series (which strongly
indicates that I should merge libcacard
On Fri, Jul 22, 2011 at 01:30:49PM +0200, Christophe Fergeau wrote:
> Ping?
>
I'll pick it up in my pull request.
> On Mon, Jul 04, 2011 at 06:10:43PM +0200, Christophe Fergeau wrote:
> > vcard_emul_mirror_card and vcard_emul_init use
> > vcard_emul_alloc_arrays to allocate memory for temporary
Remove leftover calls to usb_hid_changed().
Take care to update the changed flag after delivering a event via
GET_REPORT like we do when sending events via interrupt endpoint.
Signed-off-by: Gerd Hoffmann
---
hw/usb-hid.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff
"next" is reserved in systemtap thus using this as a
trace parameter name causes trouble when trying to trace
with systemtap.
Signed-off-by: Gerd Hoffmann
---
trace-events |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/trace-events b/trace-events
index 99a4a2b..713
On Fri, Jul 22, 2011 at 01:42:16PM +0200, Christophe Fergeau wrote:
> Hi,
>
I'll add all of these to the pull request, thanks.
> This is a resend of my series of libcacard fixes, with the correct patches
> this
> time.
>
> Changes since v3:
> - the series now includes the intended patches
>
Spec on UHCI_STS_USBERR: "If the TD on which the error interrupt
occurred also had its IOC bit set, both this bit and Bit 0 are set."
Make UHCI emulation do that.
Signed-off-by: Gerd Hoffmann
---
hw/usb-uhci.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/usb-
Hi,
Here comes the updated usb patch queue for 0.15. It is rebased to
latest master, gained one more bugfix and usb network redirection
support, so it is now four patches instead of two.
Adding usb network redirection support doesn't fall into bugfixing,
but as it just adds a new driver and th
On Fri, Jul 22, 2011 at 11:40:55AM +0200, Hans de Goede wrote:
> Define a state callback and make that generate chardev open/close events when
> called by the spice-server. Note the code ignores these events for a spicevmc
> with a subtypem of vdagent, this subtype specific knowledge is undesirable
From: Hans de Goede
This patch adds support for a usb-redir device, which takes a chardev
as a communication channel to an actual usbdevice using the usbredir protocol.
Compiling the usb-redir device requires usbredir-0.3 to be installed for
the usbredir protocol parser, usbredir-0.3 also contai
Markus Armbruster pointed out that not every SCSI command is supported
for a given device type. Based on his patch this series cleans up the
SCSI device type and adds a check for supported commands.
Hannes Reinecke (3):
scsi: Sanitize command definitions
scsi-disk: Remove drive_kind
scsi-dis
Adding some missing command definitions and update the existing ones.
No functional change.
Signed-off-by: Hannes Reinecke
---
hw/scsi-bus.c | 71 ++--
hw/scsi-defs.h| 60
hw/scsi-disk.c|
Instead of using our own type structure we can be using the
SCSI type from the parent device.
Signed-off-by: Hannes Reinecke
---
hw/scsi-disk.c | 156 ++--
1 files changed, 129 insertions(+), 27 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/s
Not every command is support for any device type. This patch adds
a check for rejecting unsupported commands.
Signed-off-by: Hannes Reinecke
---
hw/scsi-disk.c | 102
1 files changed, 0 insertions(+), 102 deletions(-)
diff --git a/hw/scs
ACK.
Another option would be to not call the state callback for the vdagent
subtype from spice-server, because like you say it ignores the continued
communication between the agent and the server. Then you could remove
the subtype check.
We can even #ifdef the check using SPICE_SERVER_VERSION o
On 07/22/2011 02:46 AM, Kevin Wolf wrote:
Am 21.07.2011 18:32, schrieb Anthony Liguori:
Just as we're now realizing that we need to do dramatic things in the
block layer to make -blockdev work, I'm sure we're going to realize that
we want to do PCI hotplug of virtio-serial and therefore we need
Am 22.07.2011 14:40, schrieb Anthony Liguori:
> On 07/22/2011 02:46 AM, Kevin Wolf wrote:
>> Am 21.07.2011 18:32, schrieb Anthony Liguori:
>>> Just as we're now realizing that we need to do dramatic things in the
>>> block layer to make -blockdev work, I'm sure we're going to realize that
>>> we wa
2011/7/22 Stefan Hajnoczi :
> On Fri, Jul 22, 2011 at 11:10 AM, Kevin Wolf wrote:
>> Am 22.07.2011 11:26, schrieb Frediano Ziglio:
>>> - you can use scripts/checkpatch.pl to check your patches before send
>
> I updated the SubmitAPatch wiki earlier this week.
>
> Stefan
>
Good, now wiki is workin
Am 22.07.2011 15:24, schrieb Frediano Ziglio:
> 2011/7/22 Stefan Hajnoczi :
>> On Fri, Jul 22, 2011 at 11:10 AM, Kevin Wolf wrote:
>>> Am 22.07.2011 11:26, schrieb Frediano Ziglio:
- you can use scripts/checkpatch.pl to check your patches before send
>>
>> I updated the SubmitAPatch wiki earl
On Tue, Jul 19, 2011 at 14:41, Juan Quintela wrote:
> Anthony PERARD wrote:
>> This patch introduces the two IOPorts on e1000, IOADDR and IODATA. The
>> IOADDR is used to specify which register we want to access when we read
>> or write on IODATA.
>>
>> This patch fixes some weird behavior that I
Hi,
git send-email --to='maintainer@domain' --cc='qemu-devel@nongnu.org'
outgoing/*
It is a good idea to make the last argument "outgoing/0*.patch",
otherwise you risk to send out the "-cover-letter.patch~" editor
backup file ...
Otherwise the procedure looks fine.
cheers,
Gerd
On 07/22/2011 08:15 AM, Kevin Wolf wrote:
Am 22.07.2011 14:40, schrieb Anthony Liguori:
On 07/22/2011 02:46 AM, Kevin Wolf wrote:
Am 21.07.2011 18:32, schrieb Anthony Liguori:
Just as we're now realizing that we need to do dramatic things in the
block layer to make -blockdev work, I'm sure we'
Hannes Reinecke writes:
> Adding some missing command definitions and update the existing ones.
> No functional change.
Add: LOCATE_10, UNMAP, VARLENGTH_CDB, WRITE_FILEMARKS_16, EXTENDED_COPY,
ATA_PASSTHROUGH, ACCESS_CONTROL_IN, ACCESS_CONTROL_OUT,
COMPARE_AND_WRITE, VERIFY_16, SYNCHRONIZE_CACHE
Hello.
I have been working on SMP support for the MPC8641D processor, so I have also
worked on completing the SMP implementation of MPIC. I've been meaning to post a
patch, but you beat me to it :)
I compared your implementation to mine, and it boils down to the same, except
that I had overloo
Hannes Reinecke writes:
> Not every command is support for any device type. This patch adds
> a check for rejecting unsupported commands.
>
> Signed-off-by: Hannes Reinecke
Commit message says "patch adds", patch only deletes.
Looks like something wrent wrong with 2/3 and 3/3.
On 07/21/2011 03:27 AM, Alexander Graf wrote:
@@ -1288,7 +1288,7 @@ static void mpic_reset (void *opaque)
mpp->glbc = 0x8000;
/* Initialise controller registers */
-mpp->frep = 0x004f0002;
+mpp->frep = 0x004f0002 | ((MAX_CPU - 1)<< 8);
Should we really report the maxi
On 07/22/2011 04:07 PM, Markus Armbruster wrote:
Hannes Reinecke writes:
Adding some missing command definitions and update the existing ones.
No functional change.
Add: LOCATE_10, UNMAP, VARLENGTH_CDB, WRITE_FILEMARKS_16, EXTENDED_COPY,
ATA_PASSTHROUGH, ACCESS_CONTROL_IN, ACCESS_CONTROL_OUT
On 07/22/2011 04:09 PM, Markus Armbruster wrote:
Hannes Reinecke writes:
Not every command is support for any device type. This patch adds
a check for rejecting unsupported commands.
Signed-off-by: Hannes Reinecke
Commit message says "patch adds", patch only deletes.
Looks like something w
2011/7/22 Stefan Hajnoczi :
> On Fri, Jul 22, 2011 at 10:13 AM, Frediano Ziglio wrote:
>> 2011/7/22 Kevin Wolf :
>>> Am 21.07.2011 18:17, schrieb Frediano Ziglio:
Hi,
after a snapshot is taken currently many write operations are quite
slow due to
- refcount updates (decrement
On 07/20/2011 05:09 AM, Gerd Hoffmann wrote:
Hi,
This patch series adds an easy way to tag devices as non-migratable
and puts it into use for ahci, ehci and a number of usb devices.
cheers,
Gerd
The following changes since commit 03ff09580ef6cbc4a893b6e3e6bbff33180ec70a:
Merge remote
Jan Kiszka writes:
> Almost just a reposting of the previously sent series. No patch
> modified, but a nifty (IMO) new one: ping forwarding for slirp using
> the unprivileged ICMP sockets of Linux 3.0. See commit log for a simple
> how-to.
My positive review of the previous version of 07-10 (pos
Hi,
vmstate: complain about devices without vmstate
I appreciate the sentiment of this patch but this cannot go into 0.15.
Peter Maydell noted that too, thats why there already is a migration.2
branch with this patch dropped which you can pull instead.
I'm not really sure this is total
Am 21.07.2011 17:07, schrieb Markus Armbruster:
> Luiz Capitulino writes:
>
>> On Wed, 20 Jul 2011 18:23:41 +0200
>> Markus Armbruster wrote:
>>
>>> The only caller is bdrv_set_locked(), and it ignores the value.
>>>
>>> Callees always return 0, except for FreeBSD's cdrom_set_locked(),
>>> which
Am 20.07.2011 18:23, schrieb Markus Armbruster:
> Callees always return 0, except for FreeBSD's cdrom_eject(), which
> returns -ENOTSUP when the device is in a terminally wedged state.
>
> The only caller is bdrv_eject(), and it maps -ENOTSUP to 0 since
> commit 4be9762a.
>
> Signed-off-by: Marku
Amit Shah writes:
> Passing on '0' as ballooning target to indicate retrieval of stats is
> bad API. It also makes 'balloon 0' in the monitor cause a segfault.
> Have two different functions handle the different functionality instead.
>
> Reported-by: Mike Cao
> Signed-off-by: Amit Shah
Can y
Am 20.07.2011 18:23, schrieb Markus Armbruster:
> Commit aea2a33c made bdrv_eject() obey the locked flag. Correct for
> medium eject (eject_flag set), incorrect for medium load (eject_flag
> clear). See MMC-5 Table 341 "Actions for Lock/Unlock/Eject".
>
> Signed-off-by: Markus Armbruster
SCSI
Markus Armbruster pointed out that not every SCSI command is supported
for a given device type. Based on his patch and suggestiongs this series
cleans up the SCSI device type and adds a check for supported commands.
Hannes Reinecke (6):
scsi-disk: Codingstyle fixes
scsi: Remove references to S
Replace tabs with spaces.
Signed-off-by: Hannes Reinecke
---
hw/scsi-disk.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 05d14ab..910d3b5 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -526,7 +526,7 @@ static i
REZERO_UNIT command is obsolete. Remove support for it.
Signed-off-by: Hannes Reinecke
---
hw/scsi-bus.c |3 ---
hw/scsi-defs.h |1 -
hw/scsi-disk.c |7 ---
3 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index facc98d..52a6784 10064
Sanitize SCSI command definitions.
Add _10 suffix to READ_CAPACITY, WRITE_VERIFY, VERIFY, READ_LONG,
WRITE_LONG, and WRITE_SAME.
Add new command definitions for LOCATE_10, UNMAP, VARLENGTH_CDB,
WRITE_FILEMARKS_16, EXTENDED_COPY, ATA_PASSTHROUGH, ACCESS_CONTROL_IN,
ACCESS_CONTROL_OUT, COMPARE_AND_WR
SET_WINDOW command is vendor-specific only.
So we shouldn't try to emulate it.
Signed-off-by: Hannes Reinecke
---
hw/scsi-bus.c |2 --
hw/scsi-defs.h |1 -
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index 8b1a412..facc98d 100644
--- a/hw
Hi :)
On 22.07.2011, at 16:08, Elie Richa wrote:
> Hello.
>
> I have been working on SMP support for the MPC8641D processor, so I have also
> worked on completing the SMP implementation of MPIC. I've been meaning to
> post a patch, but you beat me to it :)
Ah, very nice! It's great to see mor
On 22.07.2011, at 16:10, Elie Richa wrote:
>
> On 07/21/2011 03:27 AM, Alexander Graf wrote:
>> @@ -1288,7 +1288,7 @@ static void mpic_reset (void *opaque)
>>
>> mpp->glbc = 0x8000;
>> /* Initialise controller registers */
>> -mpp->frep = 0x004f0002;
>> +mpp->frep = 0x004f
Kevin Wolf writes:
> Am 20.07.2011 18:23, schrieb Markus Armbruster:
>> Callees always return 0, except for FreeBSD's cdrom_eject(), which
>> returns -ENOTSUP when the device is in a terminally wedged state.
>>
>> The only caller is bdrv_eject(), and it maps -ENOTSUP to 0 since
>> commit 4be9762
Instead of using its own definitions scsi-disk should
be using the device type of the parent device.
Signed-off-by: Hannes Reinecke
---
hw/scsi-defs.h |6 +-
hw/scsi-disk.c | 48
2 files changed, 29 insertions(+), 25 deletions(-)
diff -
Hi,
Please pull fixes for AFE smart cards, cleanup and missing frees
by Robert Relyea and Christophe Fergeau. Thanks.
The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06:
SPARC64: implement addtional MMU faults related to nonfaulting load
(2011-07-21 20:02:22 +)
Not every command is support for any device type. This patch adds
a check for rejecting unsupported commands.
Signed-off-by: Hannes Reinecke
---
hw/scsi-disk.c | 104 +++-
1 files changed, 103 insertions(+), 1 deletions(-)
diff --git a/hw/scs
Kevin Wolf writes:
> Am 20.07.2011 18:23, schrieb Markus Armbruster:
>> Commit aea2a33c made bdrv_eject() obey the locked flag. Correct for
>> medium eject (eject_flag set), incorrect for medium load (eject_flag
>> clear). See MMC-5 Table 341 "Actions for Lock/Unlock/Eject".
>>
>> Signed-off-b
Thanks, applied.
I also didn't notice the build breakage but it looks like I also ran
my tests with some old version, sorry.
On Fri, Jul 22, 2011 at 8:44 AM, Stefan Weil wrote:
> This change is needed because commit 06e12b65
> now uses an unsigned long long value
> (uint64_t && unsigned long lon
On Fri, Jul 22, 2011 at 8:06 AM, Stefan Hajnoczi wrote:
> On Thu, Jul 21, 2011 at 8:42 PM, Blue Swirl wrote:
>> On Thu, Jul 21, 2011 at 6:01 PM, Stefan Hajnoczi wrote:
>>> On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake wrote:
Thank you for persisting - you've found another hole that needs to
On the Versatile PB, PL110 graphics adaptor only natively supports
5551 pixel format; an external mux swaps bits around to allow
RGB565 and BGR565, under the control of bits [1:0] in the SYS_CLCD
system register.
Implement these SYS_CLCD register bits, and use a gpio line to
feed them out of the s
1 - 100 of 145 matches
Mail list logo
