Re: [Qemu-devel] [PATCH v2 1/1] virtio-console: Prevent abort()s in case of host chardev close

2011-07-20 Thread Markus Armbruster
Amit Shah writes: > A host chardev could close just before the guest sends some data to be > written. This will cause an -EPIPE error. This shouldn't be propagated > to virtio-serial-bus. > > Ideally we should close the port once -EPIPE is received, but since the > chardev interface doesn't ret

Re: [Qemu-devel] [V4 Patch 3/4 - Updated]Qemu: Command "block_set" for dynamic block params change

2011-07-20 Thread Supriya Kannery
On 07/13/2011 06:37 PM, Supriya Kannery wrote: Updated "block_set" command to accept multiple -drive parameters. Also, added code for re-opening of device file with original flags, incase opening file using changed hostcache setting fails.

Re: [Qemu-devel] External COW format for raw images

2011-07-20 Thread Robert Wang
On Tue, 2011-07-19 at 16:39 +0200, Frediano Ziglio wrote: > 2011/7/19 Robert Wang : > > As you known, raw image is very popular,but the raw image format does > > NOT support Copy-On-Write,a raw image file can NOT be used as a copy > > destination, then image streaming/Live Block Copy will NOT work.

Re: [Qemu-devel] [V4 Patch 4/4 - Updated]Qemu: Add commandline -drive option 'hostcache'

2011-07-20 Thread Supriya Kannery
On 07/05/2011 04:35 PM, Supriya Kannery wrote: Updated patch to use qemu_opt_get_bool() instead of qemu_opt_get() to read 'hostcache' --- qemu command option 'hostcache' added to -drive for block devices. While starting a VM from qe

Re: [Qemu-devel] [V4 Patch 1/4 -Updated]Qemu: Enhance "info block" to display host cache setting

2011-07-20 Thread Supriya Kannery
On 07/05/2011 04:19 PM, Supriya Kannery wrote: Updated patch to display hostcache = 1/0 instead of true/false in monitor. --- Enhance "info block" to display hostcache setting for each block device. Example: (qemu) info block ide0

[Qemu-devel] [RFC PATCH 2/5] use more stack

2011-07-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow.c | 133 +++--- 1 files changed, 62 insertions(+), 71 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index d19ef04..cd1f9e3 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -487,20 +487,12 @

[Qemu-devel] [RFC PATCH 5/5] qemu_aio_get used to clear all allocated buffer

2011-07-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 007fb57..8fd1ee5 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -499,7 +499,6 @@ static QCowAIOCB *qcow_aio_setup(BlockDriverState *bs,

Re: [Qemu-devel] live snapshot wiki updated

2011-07-20 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, Jul 19, 2011 at 04:14:27PM +0100, Stefan Hajnoczi wrote: >> On Tue, Jul 19, 2011 at 3:30 PM, Jes Sorensen >> wrote: >> > On 07/19/11 16:24, Eric Blake wrote: >> >> [adding the libvir-list] >> >> On 07/19/2011 08:09 AM, Jes Sorensen wrote: >> >>> Urgh, libv

[Qemu-devel] [RFC PATCH 3/5] more stack work

2011-07-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow.c | 53 ++--- 1 files changed, 26 insertions(+), 27 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index cd1f9e3..8ccd7d7 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -520,35 +520,18 @@ sta

[Qemu-devel] [RFC PATCH 0/5] Coroutines cleanup

2011-07-20 Thread Frediano Ziglio
These patches mostly cleanup some AIO code using coroutines. These patches apply to Kevin's repository, branch coroutine-block. Mostly they use stack instead of allocated AIO structure. Frediano Ziglio (5): allocate AIO on stack use more stack more stack work avoid dandling pointers qemu

Re: [Qemu-devel] [RFC v4 00/58] Memory API

2011-07-20 Thread Avi Kivity
On 07/19/2011 11:51 PM, Anthony Liguori wrote: On 07/19/2011 11:10 AM, Avi Kivity wrote: On 07/19/2011 07:05 PM, Avi Kivity wrote: On 07/19/2011 05:50 PM, Anthony Liguori wrote: There's bits I don't like about the interface Which bits are these? Nothing I haven't already commented on. I

Re: [Qemu-devel] [RFC v4 00/58] Memory API

2011-07-20 Thread Avi Kivity
On 07/20/2011 09:10 AM, Sasha Levin wrote: On Tue, 2011-07-19 at 21:53 -0500, Anthony Liguori wrote: > QEMU does use it and it's quite important. Coalesced MMIO is really > about write caching MMIO exits. It only works with devices that have > registers where writing has no side effects. Mo

[Qemu-devel] [RFC PATCH 1/5] allocate AIO on stack

2011-07-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow.c | 52 block/qcow2.c | 38 +++--- 2 files changed, 27 insertions(+), 63 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 6447c2a..d19ef04 100644 --

Re: [Qemu-devel] [RFC v4 00/58] Memory API

2011-07-20 Thread Avi Kivity
On 07/19/2011 08:30 PM, Jan Kiszka wrote: > Rebasing is already not so fun for me with 78 patches and counting. > Let's drop yours and focus of getting mine in shape, since it's a superset. The patches series are widely orthogonal except for both killing the obsolete start/stop logging logic.

Re: [Qemu-devel] [PATCH 0/2] netdev fixes

2011-07-20 Thread Mark McLoughlin
On Wed, 2011-07-20 at 11:19 +0300, Michael S. Tsirkin wrote: > On Tue, Jul 19, 2011 at 07:52:39PM +0200, Jan Kiszka wrote: > > On 2011-07-19 14:10, Michael S. Tsirkin wrote: > > > On Thu, Jun 16, 2011 at 06:45:35PM +0200, Markus Armbruster wrote: > > >> Markus Armbruster (2): > > >> Fix automatic

[Qemu-devel] [RFC PATCH 4/5] avoid dandling pointers

2011-07-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 8ccd7d7..007fb57 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -616,6 +616,7 @@ static int qcow_co_readv(BlockDriverState *bs, int64_t se

Re: [Qemu-devel] live snapshot wiki updated

2011-07-20 Thread Jes Sorensen
On 07/19/11 18:46, Daniel P. Berrange wrote: > On Tue, Jul 19, 2011 at 04:14:27PM +0100, Stefan Hajnoczi wrote: >> For fd-passing perhaps we have an opportunity to use a callback >> mechanism (QEMU request: filename -> libvirt response: fd) and do all >> the image format parsing in QEMU. > > The r

Re: [Qemu-devel] [PATCH 0/2] netdev fixes

2011-07-20 Thread Michael S. Tsirkin
On Tue, Jul 19, 2011 at 07:52:39PM +0200, Jan Kiszka wrote: > On 2011-07-19 14:10, Michael S. Tsirkin wrote: > > On Thu, Jun 16, 2011 at 06:45:35PM +0200, Markus Armbruster wrote: > >> Markus Armbruster (2): > >> Fix automatically assigned network names for netdev > >> Fix netdev name lookup in

Re: [Qemu-devel] [RFC 1/4] A separate thread for the VM migration

2011-07-20 Thread Avi Kivity
On 07/20/2011 06:56 AM, Umesh Deshpande wrote: Please give each patch a separate, meaningful title and post them in their own thread. See git format-patches --cover-letter git send-email -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH v2 1/1] virtio-console: Prevent abort()s in case of host chardev close

2011-07-20 Thread Amit Shah
On (Wed) 20 Jul 2011 [09:10:41], Markus Armbruster wrote: > Amit Shah writes: > > > A host chardev could close just before the guest sends some data to be > > written. This will cause an -EPIPE error. This shouldn't be propagated > > to virtio-serial-bus. > > > > Ideally we should close the por

[Qemu-devel] [PATCH 4/7] virtio-balloon: Separate status handling into separate function

2011-07-20 Thread Amit Shah
Separate out the code to retrieve balloon info from the code that sets balloon values. This will be used to separate the two callbacks from balloon.c and help cope with 'balloon 0' on the monitor. Currently, 'balloon 0' causes a segfault in monitor_resume(). Signed-off-by: Amit Shah --- hw/vir

Re: [Qemu-devel] live snapshot wiki updated

2011-07-20 Thread Jes Sorensen
On 07/19/11 18:14, Anthony Liguori wrote: >>> As nice as that sentiment is, it will never fly, because it would be a >>> regression in current behavior. The whole reason that the virt_use_nfs >>> SELinux bool exists is that some people are willing to make the partial >>> security tradeoff. Beside

Re: [Qemu-devel] live snapshot wiki updated

2011-07-20 Thread Jes Sorensen
On 07/19/11 18:47, Daniel P. Berrange wrote: > On Tue, Jul 19, 2011 at 04:30:19PM +0200, Jes Sorensen wrote: >> On 07/19/11 16:24, Eric Blake wrote: >>> Besides, I feel that having a well-documented file format, so that >>> independent applications can both parse the same file with the same >>> sem

[Qemu-devel] [PATCH 1/7] balloon: Make functions, local vars static

2011-07-20 Thread Amit Shah
balloon.h had function declarations for a couple of functions that are local to balloon.c. Make them static. Drop the 'qemu_' prefix for balloon.c-local variables, and make them static. Signed-off-by: Amit Shah --- balloon.c | 22 +++--- balloon.h |4 2 files changed

[Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault

2011-07-20 Thread Amit Shah
'balloon 0' in the monitor causes a segfault. This happens because the function that handles change in balloon values is also tasked with handling stats retrieval from the guest, and it does the retrieval when the balloon target is '0'. Silly API, replace it. Also do a few cleanups along the way

[Qemu-devel] [PATCH 5/7] balloon: Separate out stat and balloon handling

2011-07-20 Thread Amit Shah
Passing on '0' as ballooning target to indicate retrieval of stats is bad API. It also makes 'balloon 0' in the monitor cause a segfault. Have two different functions handle the different functionality instead. Reported-by: Mike Cao Signed-off-by: Amit Shah --- balloon.c | 17 +

Re: [Qemu-devel] External COW format for raw images

2011-07-20 Thread Stefan Hajnoczi
2011/7/19 Anthony Liguori : > On 07/19/2011 04:25 AM, Robert Wang wrote: >> As you known, raw image is very popular,but the raw image format does >> NOT support Copy-On-Write,a raw image file can NOT be used as a copy >> destination, then image streaming/Live Block Copy will NOT work. >> >> To fix

Re: [Qemu-devel] [PATCH] Add missing documentation for qemu-img -p

2011-07-20 Thread Kevin Wolf
Am 19.07.2011 15:01, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH 2/7] balloon: Add braces around if statements

2011-07-20 Thread Amit Shah
Signed-off-by: Amit Shah --- balloon.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/balloon.c b/balloon.c index f9bcf07..86f629e 100644 --- a/balloon.c +++ b/balloon.c @@ -65,9 +65,10 @@ static void print_balloon_stat(const char *key, QObject *obj, void *opaque)

Re: [Qemu-devel] [PATCH] Remove debugging messages.

2011-07-20 Thread Richard W.M. Jones
On Tue, Jul 19, 2011 at 04:56:24PM -0500, Anthony Liguori wrote: > Can't libguestfs just ignore the messages? It does, but they get printed to stderr which confuses users and has caused several bug reports in the past. We'll probably have to redirect them somewhere. > >$ qemu -nographic -device

[Qemu-devel] [PATCH v7 01/11] spice: add worker wrapper functions.

2011-07-20 Thread Alon Levy
From: Gerd Hoffmann Add wrapper functions for all spice worker calls. Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c|4 +- hw/qxl.c | 32 +- ui/spice-display.c | 95 --- ui/spice-display.h | 22 ++

[Qemu-devel] [PATCH] xen: fix xen-mapcache build on non-Xen capable targets

2011-07-20 Thread Avi Kivity
Signed-off-by: Avi Kivity --- xen-mapcache.h | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/xen-mapcache.h b/xen-mapcache.h index 606b8af..da874ca 100644 --- a/xen-mapcache.h +++ b/xen-mapcache.h @@ -9,6 +9,10 @@ #ifndef XEN_MAPCACHE_H #

[Qemu-devel] [PATCH 3/7] balloon: Simplify code flow

2011-07-20 Thread Amit Shah
Replace: if (foo) { ... } else { return 0; } by if (!foo) { return 0; } ... Signed-off-by: Amit Shah --- balloon.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/balloon.c b/balloon.c index 86f629e..d40be39 100644 --- a/balloon.c

[Qemu-devel] [PATCH v7 06/11] qxl: error handling fixes and cleanups.

2011-07-20 Thread Alon Levy
From: Gerd Hoffmann Add qxl_guest_bug() function which is supposed to be called in case sanity checks of guest requests fail. It raises an error IRQ and logs a message in case guest debugging is enabled. Make PANIC_ON() abort instead of exit. That macro should be used for qemu bugs only, any g

[Qemu-devel] [PATCH v7 02/11] spice: add qemu_spice_display_init_common

2011-07-20 Thread Alon Levy
From: Gerd Hoffmann Factor out SimpleSpiceDisplay initialization into qemu_spice_display_init_common() and call it from both qxl.c (for vga mode) and spice-display.c Signed-off-by: Gerd Hoffmann --- hw/qxl.c |7 +-- ui/spice-display.c | 17 +++-- ui/spice-displa

[Qemu-devel] [PATCH v7 04/11] qxl: fix surface tracking & locking

2011-07-20 Thread Alon Levy
From: Gerd Hoffmann Surface tracking needs proper locking since it is used from vcpu and spice worker threads, add it. Also reset the surface counter when zapping all surfaces. Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 13 - hw/qxl.h |2 ++ 2 files changed, 14 insertions(+

[Qemu-devel] [PATCH 6/7] balloon: Fix header comment; add Copyright

2011-07-20 Thread Amit Shah
Signed-off-by: Amit Shah --- balloon.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/balloon.c b/balloon.c index 8be3812..a938475 100644 --- a/balloon.c +++ b/balloon.c @@ -1,7 +1,9 @@ /* - * QEMU System Emulator + * Generic Balloon handlers and management * *

[Qemu-devel] [PATCH v7 03/11] spice/qxl: move worker wrappers

2011-07-20 Thread Alon Levy
From: Gerd Hoffmann Move the wrapper functions which are used by qxl only to qxl.c. Rename them from qemu_spice_* to qxl_spice_*. Also pass in a qxl state pointer instead of a SimpleSpiceDisplay pointer. Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c|4 +- hw/qxl.c | 67

[Qemu-devel] [PATCH v7 09/11] qxl: async io support using new spice api

2011-07-20 Thread Alon Levy
Some of the QXL port i/o commands are waiting for the spice server to complete certain actions. Add async versions for these commands, so we don't block the vcpu while the spice server processses the command. Instead the qxl device will raise an IRQ when done. The async command processing relies

[Qemu-devel] [PATCH 7/7] virtio-balloon: Fix header comment; add Copyright

2011-07-20 Thread Amit Shah
Signed-off-by: Amit Shah --- hw/virtio-balloon.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index 40b43b0..2ba7e95 100644 --- a/hw/virtio-balloon.c +++ b/hw/virtio-balloon.c @@ -1,7 +1,9 @@ /* - * Virtio Block Device + *

Re: [Qemu-devel] live snapshot wiki updated

2011-07-20 Thread Daniel P. Berrange
On Wed, Jul 20, 2011 at 10:26:49AM +0200, Jes Sorensen wrote: > On 07/19/11 18:47, Daniel P. Berrange wrote: > > On Tue, Jul 19, 2011 at 04:30:19PM +0200, Jes Sorensen wrote: > >> On 07/19/11 16:24, Eric Blake wrote: > >>> Besides, I feel that having a well-documented file format, so that > >>> ind

[Qemu-devel] [PATCH v7 11/11] qxl: bump pci rev

2011-07-20 Thread Alon Levy
From: Gerd Hoffmann Inform guest drivers about the new features I/O commands we have now (async commands, S3 support) if building with newer spice, i.e. if SPICE_INTERFACE_QXL_MINOR >= 1. sneaked in some 81+ column line spliting. Signed-off-by: Gerd Hoffmann Signed-off-by: Alon Levy --- hw/q

[Qemu-devel] [PATCH v7 07/11] qxl: make qxl_guest_bug take variable arguments

2011-07-20 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c |9 +++-- hw/qxl.h |2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 68ce409..d645c87 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -125,13 +125,18 @@ static void qxl_reset_memslots(PCIQXLDevice *d); static

Re: [Qemu-devel] [PATCH] virtio-9p: Fix syntax error in debug code

2011-07-20 Thread Aneesh Kumar K.V
On Wed, 20 Jul 2011 08:27:28 +0200, Stefan Weil wrote: > This error was reported by cppcheck: > > qemu/hw/9pfs/virtio-9p-debug.c:342: > error: Invalid number of character ({) when these macros are defined: > 'DEBUG_DATA'. > > Cc: Aneesh Kumar K.V > Signed-off-by: Stefan Weil > --- > hw/9pfs/v

Re: [Qemu-devel] live snapshot wiki updated

2011-07-20 Thread Daniel P. Berrange
On Wed, Jul 20, 2011 at 10:23:12AM +0200, Jes Sorensen wrote: > On 07/19/11 18:46, Daniel P. Berrange wrote: > > On Tue, Jul 19, 2011 at 04:14:27PM +0100, Stefan Hajnoczi wrote: > >> For fd-passing perhaps we have an opportunity to use a callback > >> mechanism (QEMU request: filename -> libvirt re

[Qemu-devel] [PATCH v7 00/11] async + suspend reworked

2011-07-20 Thread Alon Levy
v7 changes: use updated spice api (spice_qxl_update_area_async etc.) Alon Levy (5): qxl: add io_port_to_string qxl: make qxl_guest_bug take variable arguments qxl: only disallow specific io's in vga mode qxl: async io support using new spice api qxl: add QXL_IO_FLUSH_{SURFACES,RELEASE}

[Qemu-devel] [PATCH 5/9] usb storage: first migration support bits.

2011-07-20 Thread Gerd Hoffmann
Tag vmstate as unmigratable for the time being, to be removed when mgration support is finished. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-msd.c index 86582cc..8ed8594 100644 --- a/hw/u

Re: [Qemu-devel] live snapshot wiki updated

2011-07-20 Thread Kevin Wolf
Am 19.07.2011 18:46, schrieb Daniel P. Berrange: > On Tue, Jul 19, 2011 at 04:14:27PM +0100, Stefan Hajnoczi wrote: >> On Tue, Jul 19, 2011 at 3:30 PM, Jes Sorensen >> wrote: >>> On 07/19/11 16:24, Eric Blake wrote: [adding the libvir-list] On 07/19/2011 08:09 AM, Jes Sorensen wrote: >>

[Qemu-devel] [PATCH 3/9] ahci doesn't support migration

2011-07-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/ide/ich.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/ide/ich.c b/hw/ide/ich.c index 054e073..d241ea8 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -72,6 +72,11 @@ #include #include +static const VMStateDescription v

[Qemu-devel] [PATCH v7 05/11] qxl: add io_port_to_string

2011-07-20 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 40 +++- 1 files changed, 39 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index e832d00..7d8b312 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -409,6 +409,43 @@ static const char *qxl_mode_to_string(int mod

[Qemu-devel] [PATCH 8/9] usb-net doesn't support migration

2011-07-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-net.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-net.c b/hw/usb-net.c index 9be709f..4212e5b 100644 --- a/hw/usb-net.c +++ b/hw/usb-net.c @@ -1414,11 +1414,17 @@ static USBDevice *usb_net_init(const char *cmdline)

[Qemu-devel] [PATCH 6/9] usb-wacom doesn't support migration

2011-07-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-wacom.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-wacom.c b/hw/usb-wacom.c index 9d348e1..d76ee97 100644 --- a/hw/usb-wacom.c +++ b/hw/usb-wacom.c @@ -349,6 +349,11 @@ static int usb_wacom_initfn(USBDevice *dev)

Re: [Qemu-devel] error "kvm: virtio: trying to map MMIO memory"

2011-07-20 Thread Stéphanie Ouillon
Thank you for your help, I have been able to see where was the bug ! Indeed, I was losing some address values along the way in a callback function whereas I thought they were kept memorized. Regards Stéphanie

[Qemu-devel] [PATCH v7 08/11] qxl: only disallow specific io's in vga mode

2011-07-20 Thread Alon Levy
Since the driver is still in operation even after moving to UNDEFINED, i.e. by destroying primary in any way. Signed-off-by: Alon Levy --- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index d645c87..b946942 100644 --- a/hw/qxl.c +++ b/hw

Re: [Qemu-devel] live snapshot wiki updated

2011-07-20 Thread Daniel P. Berrange
On Wed, Jul 20, 2011 at 11:50:53AM +0200, Kevin Wolf wrote: > Am 19.07.2011 18:46, schrieb Daniel P. Berrange: > > On Tue, Jul 19, 2011 at 04:14:27PM +0100, Stefan Hajnoczi wrote: > >> On Tue, Jul 19, 2011 at 3:30 PM, Jes Sorensen > >> wrote: > >>> On 07/19/11 16:24, Eric Blake wrote: > [add

Re: [Qemu-devel] [PATCH] SPARC64: treat UA2007 ASI_BLK_* as translating ASIs.

2011-07-20 Thread Artyom Tarasenko
On Mon, Jul 18, 2011 at 7:32 AM, Tsuneo Saito wrote: > UA2007 ASI_BLK_* should be added in is_translating_asi(). > > Signed-off-by: Tsuneo Saito The comment "Ultrasparc IIi translating asi" has to be adjusted too. Otherwise Acked-by: Artyom Tarasenko The other patches - fcmp and fmovd - pass

[Qemu-devel] [PATCH 9/9] usb-serial doesn't support migration

2011-07-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-serial.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/usb-serial.c b/hw/usb-serial.c index 59cb0fb..70d694d 100644 --- a/hw/usb-serial.c +++ b/hw/usb-serial.c @@ -566,10 +566,16 @@ static USBDevice *usb_braille_init(cons

[Qemu-devel] [PATCH v7 10/11] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support

2011-07-20 Thread Alon Levy
Add two new IOs. QXL_IO_FLUSH_SURFACES - equivalent to update area for all surfaces, used to reduce vmexits from NumSurfaces to 1 on guest S3, S4 and resolution change (windows driver implementation is such that this is done on each of those occasions). QXL_IO_FLUSH_RELEASE - used to ensure

[Qemu-devel] [PATCH 01/10] slirp: Fix restricted mode

2011-07-20 Thread Jan Kiszka
This aligns the code to what the documentation claims: Allow everything but requests that would have to be routed outside of the virtual LAN. So we need to drop the unneeded IP-level filter, allow TFTP requests, and add the missing protocol-level filter to ICMP. CC: Gleb Natapov Signed-off-by: J

[Qemu-devel] [PATCH 7/9] usb-bt doesn't support migration

2011-07-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-bt.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-bt.c b/hw/usb-bt.c index e364513..4557802 100644 --- a/hw/usb-bt.c +++ b/hw/usb-bt.c @@ -548,10 +548,16 @@ USBDevice *usb_bt_init(HCIInfo *hci) return dev; } +

Re: [Qemu-devel] live snapshot wiki updated

2011-07-20 Thread Kevin Wolf
Am 20.07.2011 10:25, schrieb Jes Sorensen: > On 07/19/11 18:14, Anthony Liguori wrote: As nice as that sentiment is, it will never fly, because it would be a regression in current behavior. The whole reason that the virt_use_nfs SELinux bool exists is that some people are willing to

Re: [Qemu-devel] [PATCH] xen: fix xen-mapcache build on non-Xen capable targets

2011-07-20 Thread Alexander Graf
Oh, did the code that break this make it upstream already? I'll send a new pull request with my patches to fix all the regressions I've encountered ASAP. Alex On 20.07.2011, at 11:14, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- > xen-mapcache.h | 32

[Qemu-devel] [PATCH 05/10] slirp: Put forked exec into separate process group

2011-07-20 Thread Jan Kiszka
Recent smb daemons tend to terminate themselves via a process group SIGTERM. If the daemon is still in qemu's group by that time, qemu will die as well. Avoid this by always pushing fork_exec processes into a group of their own, not just (unused) type 2 execs. Signed-off-by: Jan Kiszka --- slirp

[Qemu-devel] [PATCH 04/10] slirp: Replace m_freem with m_free

2011-07-20 Thread Jan Kiszka
Remove this pointless wrapping. Signed-off-by: Jan Kiszka --- slirp/ip_icmp.c |6 +++--- slirp/ip_input.c |8 slirp/ip_output.c |4 ++-- slirp/mbuf.h |3 --- slirp/tcp_input.c | 10 +- slirp/tcp_subr.c |2 +- slirp/udp.c |2 +- 7 files ch

[Qemu-devel] [PATCH 4/9] ehci doesn't support migration

2011-07-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index a4758f9..8b0dcc3 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -2244,6 +2244,11 @@ static USBBusOps ehci_bus_ops = { .register

[Qemu-devel] [PATCH 08/10] net: Refactor net_client_types

2011-07-20 Thread Jan Kiszka
Position entries of net_client_types according to the corresponding values of NET_CLIENT_TYPE_*. The array size is now defined by NET_CLIENT_TYPE_MAX. This will allow to obtain entries based on type value in later patches. At this chance rename NET_CLIENT_TYPE_SLIRP to NET_CLIENT_TYPE_USER for the

[Qemu-devel] [PATCH 09/10] net: Dump client type 'info network'

2011-07-20 Thread Jan Kiszka
Include the client type name into the output of 'info network'. The result looks like this: (qemu) info network VLAN 0 devices: rtl8139.0: type=nic,model=rtl8139,macaddr=52:54:00:12:34:57 Devices not on any VLAN: virtio-net-pci.0: type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:56 \ ne

[Qemu-devel] [libvirt] Re: live snapshot wiki updated

2011-07-20 Thread Nicolas Sebrecht
The 20/07/11, Daniel P. Berrange wrote: > To make the decision whether the filename from QEMU is valid, we have > to parse the master image header data to see if the filename actually > matches the backing file required by the image assigned to the guest. Actually, libvirt should not have to worr

[Qemu-devel] [PATCH 10/10] net: Consistently use qemu_macaddr_default_if_unset

2011-07-20 Thread Jan Kiszka
Drop the open-coded MAC assignment from net_init_nic and replace it with standard qemu_macaddr_default_if_unset which is also used by qdev. That avoid creating colliding MACs when instantiating NICs via different mechanisms. This change requires to store the MAC as MACAddr in NICInfo, and the rema

[Qemu-devel] [PATCH 2/2] usb-uhci: fix irq handling on error.

2011-07-20 Thread Gerd Hoffmann
Spec on UHCI_STS_USBERR: "If the TD on which the error interrupt occurred also had its IOC bit set, both this bit and Bit 0 are set." Make UHCI emulation do that. Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-

[Qemu-devel] [PATCH 2/9] vmstate: complain about devices without vmstate

2011-07-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/hw.h |2 ++ hw/qdev.c |7 ++- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index df6ca65..d839af1 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -336,6 +336,8 @@ struct VMStateDescription { const VMStateSubsection *

[Qemu-devel] [PATCH 07/10] net: Improve layout of 'info network'

2011-07-20 Thread Jan Kiszka
Improve the layout when listing non-vlan clients via 'info network'. The result looks like this: (qemu) info network Devices not on any VLAN: orphan: net=10.0.2.0, restricted=n virtio-net-pci.0: model=virtio-net-pci,macaddr=52:54:00:12:34:56 \ network2: fd=5 e1000.0: model=e1000,macaddr=5

[Qemu-devel] [PATCH 06/10] slirp: Forward ICMP echo requests via unprivileged sockets

2011-07-20 Thread Jan Kiszka
Linux 3.0 gained support for unprivileged ICMP ping sockets. Use this feature to forward guest pings to the outer world. The host admin has to set the ping_group_range in order to grant access to those sockets. To allow ping for the users group (GID 100): echo 100 100 > /proc/sys/net/ipv4/ping_gro

[Qemu-devel] [PULL] usb patch queue

2011-07-20 Thread Gerd Hoffmann
Hi, Tiny usb patch queue with two small fixes. please pull for 0.15, Gerd The following changes since commit 03ff09580ef6cbc4a893b6e3e6bbff33180ec70a: Merge remote-tracking branch 'agraf/xen-next' into staging (2011-07-19 08:04:35 -0500) are available in the git repository at: git://

[Qemu-devel] [PATCH 1/9] vmstate: add no_migrate flag to VMStateDescription

2011-07-20 Thread Gerd Hoffmann
This allows to easily tag devices as non-migratable, so any attempt to migrate a virtual machine with the device in question active will make migration fail. Signed-off-by: Gerd Hoffmann --- hw/hw.h |1 + savevm.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/h

[Qemu-devel] [PATCH 03/10] slirp: Strictly associate DHCP/BOOTP and TFTP with virtual host

2011-07-20 Thread Jan Kiszka
Instead of accepting every DHCP/BOOTP and TFTP packet, only invoke the built-in servers if the target is the virtual host. Signed-off-by: Jan Kiszka --- slirp/udp.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/slirp/udp.c b/slirp/udp.c index f1a9a10..cefd5

[Qemu-devel] [PATCH 1/2] usb-hid: fixup changed tracking.

2011-07-20 Thread Gerd Hoffmann
Remove leftover calls to usb_hid_changed(). Take care to update the changed flag after delivering a event via GET_REPORT like we do when sending events via interrupt endpoint. Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH 4/6] exec.c: Use ram_addr_t in cpu_physical_memory_rw(...).

2011-07-20 Thread Alexander Graf
From: Anthony PERARD As the variable pd and addr1 inside the function cpu_physical_memory_rw are mean to handle a RAM address, they should be of the ram_addr_t type instead of unsigned long. Signed-off-by: Anthony PERARD Acked-by: Paolo Bonzini Signed-off-by: Alexander Graf --- exec.c |4

[Qemu-devel] [PULL] non-migratable devices

2011-07-20 Thread Gerd Hoffmann
Hi, This patch series adds an easy way to tag devices as non-migratable and puts it into use for ahci, ehci and a number of usb devices. cheers, Gerd The following changes since commit 03ff09580ef6cbc4a893b6e3e6bbff33180ec70a: Merge remote-tracking branch 'agraf/xen-next' into staging (20

[Qemu-devel] [PATCH 00/10] [RESEND] Various net and slirp fixes & enhancements

2011-07-20 Thread Jan Kiszka
Almost just a reposting of the previously sent series. No patch modified, but a nifty (IMO) new one: ping forwarding for slirp using the unprivileged ICMP sockets of Linux 3.0. See commit log for a simple how-to. CC: Gleb Natapov CC: Markus Armbruster CC: Peter Maydell Jan Kiszka (10): slirp

[Qemu-devel] [PATCH 0/6] Xen patch queue 2011-07-20

2011-07-20 Thread Alexander Graf
Hi Anthony, This is my current patch queue for Xen stuff that fixes even more regressions introduced by recent Xen patches. I hope this time we're regression-free. Please pull. Alex The following changes since commit 03ff09580ef6cbc4a893b6e3e6bbff33180ec70a: Anthony Liguori (1): Merge

Re: [Qemu-devel] [libvirt] Re: live snapshot wiki updated

2011-07-20 Thread Daniel P. Berrange
On Wed, Jul 20, 2011 at 12:15:02PM +0200, Nicolas Sebrecht wrote: > The 20/07/11, Daniel P. Berrange wrote: > > > To make the decision whether the filename from QEMU is valid, we have > > to parse the master image header data to see if the filename actually > > matches the backing file required by

[Qemu-devel] [PATCH 02/10] slirp: Canonicalize restrict syntax

2011-07-20 Thread Jan Kiszka
All other boolean arguments accept on|off - except for slirp's restrict. Fix that while still accepting the formerly allowed yes|y|no|n, but reject everything else. This avoids accidentally allowing external connections because syntax errors were so far interpreted as 'restrict=no'. CC: Gleb Natap

[Qemu-devel] [PATCH 3/6] xen: Fix xen_enabled().

2011-07-20 Thread Alexander Graf
From: Anthony PERARD Use the "host" CONFIG_ define instead of the "target" one. Signed-off-by: Anthony PERARD Acked-by: Paolo Bonzini Signed-off-by: Alexander Graf --- hw/xen.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xen.h b/hw/xen.h index e432705..43b95d

[Qemu-devel] [PULL] spice patch queue

2011-07-20 Thread Gerd Hoffmann
Hi, Two small spice fixes for 0.15. please pull, Gerd The following changes since commit 03ff09580ef6cbc4a893b6e3e6bbff33180ec70a: Merge remote-tracking branch 'agraf/xen-next' into staging (2011-07-19 08:04:35 -0500) are available in the git repository at: git://anongit.freedesktop.

[Qemu-devel] [PATCH 1/6] xen: introduce xen_change_state_handler

2011-07-20 Thread Alexander Graf
From: Anthony PERARD Remove the call to xenstore_record_dm_state from xen_main_loop_prepare that is HVM specific. Add a new vm_change_state_handler shared between xen_pv and xen_hvm machines to record the VM state to xenstore. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini Sig

[Qemu-devel] [PATCH 5/6] xen: remove CONFIG_XEN_MAPCACHE

2011-07-20 Thread Alexander Graf
We were still exporting CONFIG_XEN_MAPCACHE, even though it's completely unused by now. Remove it. Signed-off-by: Alexander Graf --- configure |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/configure b/configure index e57efb1..f537130 100755 --- a/configure +++ b/conf

[Qemu-devel] [PATCH 22/23] qcow2: Use Qcow2Cache in writeback mode during loadvm/savevm

2011-07-20 Thread Kevin Wolf
In snapshotting there is no guest involved, so we can safely use a writeback mode and do the flushes in the right place (i.e. at the very end). This improves the time that creating/restoring an internal snapshot takes with an image in writethrough mode. Signed-off-by: Kevin Wolf --- block/qcow2-

[Qemu-devel] [PATCH 2/6] xen: add mapcache stubs

2011-07-20 Thread Alexander Graf
During the transition to get rid of CONFIG_XEN_MAPCACHE we lost the mapcache stubs along the way. Nobody realized it because the commands were guarded by if (xen_enabled()) clauses that made gcc optimize out the respective calls. This patch adds the stubs again - this time in the generic xen-stubs

[Qemu-devel] [PATCH 2/2] qxl: upon reset, if spice worker is stopped, the command rings can be not empty

2011-07-20 Thread Gerd Hoffmann
From: Yonit Halperin Spice worker does no longer process commands when it is stopped. Otherwise, it might crash during migration when attempting to process commands while the guest is not completely loaded. Cc: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl.c |4 ++-- 1 files changed,

Re: [Qemu-devel] [RFC v4 00/58] Memory API

2011-07-20 Thread Jan Kiszka
On 2011-07-20 10:13, Avi Kivity wrote: > On 07/19/2011 08:30 PM, Jan Kiszka wrote: >>> Rebasing is already not so fun for me with 78 patches and counting. >>> Let's drop yours and focus of getting mine in shape, since it's a superset. >> >> The patches series are widely orthogonal except for both

[Qemu-devel] [PATCH 23/23] Add missing documentation for qemu-img -p

2011-07-20 Thread Kevin Wolf
From: Jes Sorensen Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- qemu-img-cmds.hx |4 ++-- qemu-img.texi|6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 2b70618..1299e83 100644 --- a/qemu-img-cmds.hx +++

[Qemu-devel] [PATCH 6/6] xen: make xen_enabled even more clever

2011-07-20 Thread Alexander Graf
When using xen_enabled() we're currently only checking if xen is enabled at all during the build. But what if you want to build multiple targets out of which only one can potentially run xen code? That means that for generic code we'll still have to fall back to the variable and potentially slow t

Re: [Qemu-devel] [libvirt] live snapshot wiki updated

2011-07-20 Thread Stefan Hajnoczi
On Wed, Jul 20, 2011 at 11:28 AM, Daniel P. Berrange wrote: > On Wed, Jul 20, 2011 at 12:15:02PM +0200, Nicolas Sebrecht wrote: >> The 20/07/11, Daniel P. Berrange wrote: >> >> > To make the decision whether the filename from QEMU is valid, we have >> > to parse the master image header data to see

[Qemu-devel] [PULL v2 00/23] Block patches

2011-07-20 Thread Kevin Wolf
(Reposting only changed or new patches) The following changes since commit 89b9ba661bd2d6155308f895ec075d813f0e129b: Fix signal handling of SIG_IPI when io-thread is enabled (2011-07-16 19:43:00 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Devi

[Qemu-devel] [PATCH 1/2] spice: add sanity check for spice ports

2011-07-20 Thread Gerd Hoffmann
Make sure at least one port (port=.. or tls-port=...) is specified. Also apply range checks to the port numbers. Signed-off-by: Gerd Hoffmann --- ui/spice-core.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index e142452..

Re: [Qemu-devel] [RFC v4 00/58] Memory API

2011-07-20 Thread Jan Kiszka
On 2011-07-20 10:13, Avi Kivity wrote: > On 07/19/2011 08:30 PM, Jan Kiszka wrote: >>> Rebasing is already not so fun for me with 78 patches and counting. >>> Let's drop yours and focus of getting mine in shape, since it's a superset. >> >> The patches series are widely orthogonal except for both

Re: [Qemu-devel] [RFC v4 00/58] Memory API

2011-07-20 Thread Anthony Liguori
On 07/20/2011 01:10 AM, Sasha Levin wrote: On Tue, 2011-07-19 at 21:53 -0500, Anthony Liguori wrote: QEMU does use it and it's quite important. Coalesced MMIO is really about write caching MMIO exits. It only works with devices that have registers where writing has no side effects. Moreover,

[Qemu-devel] [PATCH 05/23] scsi: Add 'hba_private' to SCSIRequest

2011-07-20 Thread Kevin Wolf
From: Hannes Reinecke 'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by replacing 'tag' with a driver-defined pointer 'hba_private'. This saves the lookup for driver handling several commands in parallel. 'tag' is still being kept for tracing

Re: [Qemu-devel] [PATCH] pci: Length-align config space accesses

2011-07-20 Thread Isaku Yamahata
Hi. This clean up looks good basically. But when conventional pci device is accessed via MMCONFIG area, addr &= addr_mask doesn't work as expected. The config area of [256, 4K) of conventional pci should have no effect. thanks, On Tue, Jul 19, 2011 at 11:39:02PM +0200, Jan Kiszka wrote: > From: J

  1   2   3   4   >