Re: [Qemu-devel] [PATCH] vnc: Fix compilation with --enable-vnc-png

2011-06-27 Thread Markus Armbruster
Stefan Weil writes: > Commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b fixed compilation > with --enable-vnc-png, but broke it with --enable-vnc-png. You mean "with --enable-vnc-jpeg, but", don't you? > The breakage is caused by pngconfig.h which checks whether > setjmp.h was already included an

Re: [Qemu-devel] [PATCH v3 09/12] VMDK: open/read/write for monolithicFlat image

2011-06-27 Thread Fam Zheng
On Mon, Jun 27, 2011 at 12:54 PM, Stefan Hajnoczi wrote: > On Mon, Jun 27, 2011 at 4:48 AM, Fam Zheng wrote: >> Parse vmdk decriptor file and open mono flat image. >> @@ -598,6 +600,154 @@ static int vmdk_open_vmdk4(BlockDriverState *bs, int >> flags) >>     return ret; >>  } >> >> +/* find an o

[Qemu-devel] Windows 7 guest hangs after waking up from S3

2011-06-27 Thread yhalperi
Hi, I'm using qemu with qxl (with S3/4 support. patches sent by Alon Levy). While with Windows xp guest I had no problems, Windows 7 (32 bits) hangs after S3 (it looks alive for a second, and then it gets stack).It happens only when using "-net tap"; with "-net user", I didn't encounter a pro

Re: [Qemu-devel] [PATCH v3] showing a splash picture when start

2011-06-27 Thread Jan Kiszka
On 2011-06-27 08:53, Wayne Xia wrote: > Made an option to let qemu pass a picture to bios, let the bios show it as a > logo. By default it is off, enable it as following That's better. :) > -boot splash_time=N,splash_filename=P > N have a max value of 0x, unit is ms. P is the a file name

[Qemu-devel] Need help: Save word (sw) and load word (lw) not working

2011-06-27 Thread Philip Loh
Hello, I'm new to QEMU development and am attempting to write code for a new board and system. I modeled the code after the code in the target-microblaze folder, but removed the dependency on the petalogix board and instead made it require the code from my board. At this point, it can boot and exe

Re: [Qemu-devel] Image streaming and live block copy

2011-06-27 Thread Kevin Wolf
Am 26.06.2011 14:50, schrieb Dor Laor: > On 06/24/2011 12:28 PM, Stefan Hajnoczi wrote: >> On Sun, Jun 19, 2011 at 5:02 PM, Dor Laor wrote: >>> On 06/18/2011 12:17 PM, Stefan Hajnoczi wrote: On Sat, Jun 18, 2011 at 10:15 AM, Stefan Hajnoczi wrote: > > On Fri, Jun 17, 2011

Re: [Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes

2011-06-27 Thread yhalperi
On 06/24/2011 04:02 PM, Alon Levy wrote: Currently we define the following relation between modes and primary surface existance: QXL_MODE_COMPAT QXL_MODE_NATIVE primary exists QXL_MODE_UNDEFINED QXL_MODE_VGA primary doesn't exist This, coupled with disallowing various IO's when not

Re: [Qemu-devel] [PATCH v3] showing a splash picture when start

2011-06-27 Thread Wayne Xia
On 2011-06-27 08:53, Wayne Xia wrote: Made an option to let qemu pass a picture to bios, let the bios show it as a logo. By default it is off, enable it as following That's better. :) -boot splash_time=N,splash_filename=P N have a max value of 0x, unit is ms. P is the a file name or

Re: [Qemu-devel] [PATCH v3 09/12] VMDK: open/read/write for monolithicFlat image

2011-06-27 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 8:00 AM, Fam Zheng wrote: > On Mon, Jun 27, 2011 at 12:54 PM, Stefan Hajnoczi wrote: >> On Mon, Jun 27, 2011 at 4:48 AM, Fam Zheng wrote: >>> Parse vmdk decriptor file and open mono flat image. >>> @@ -598,6 +600,154 @@ static int vmdk_open_vmdk4(BlockDriverState *bs, int

Re: [Qemu-devel] Windows 7 guest hangs after waking up from S3

2011-06-27 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 8:04 AM, yhalperi wrote: > I'm using qemu with qxl (with S3/4 support. patches sent by Alon Levy). > While with Windows xp guest I had no problems, Windows 7 (32 bits) hangs > after S3 (it looks alive for a second, and then it gets stack).It happens > only when using "-net

Re: [Qemu-devel] Need help: Save word (sw) and load word (lw) not working

2011-06-27 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 8:37 AM, Philip Loh wrote: > I'm new to QEMU development and am attempting to write code for a new board > and system. I modeled the code after the code in the target-microblaze > folder, but removed the dependency on the petalogix board and instead made > it require the co

Re: [Qemu-devel] [V2 3/3] Command "block_set" for dynamic block params change

2011-06-27 Thread Kevin Wolf
Am 22.06.2011 18:09, schrieb Supriya Kannery: > On 06/20/2011 08:04 PM, Kevin Wolf wrote: >> Am 17.06.2011 18:38, schrieb Supriya Kannery: > >>> + if (bdrv_is_inserted(bs)) { >>> + /* cache change applicable only if device inserted */ >>> + return bdrv

Re: [Qemu-devel] [PATCH v3] showing a splash picture when start

2011-06-27 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 7:53 AM, Wayne Xia wrote: > Made an option to let qemu pass a picture to bios, let the bios show it as a > logo. By default it is off, enable it as following >    -boot splash_time=N,splash_filename=P It's a shame qemu-config.c has some options that use this_syntax and som

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support

2011-06-27 Thread yhalperi
On 06/27/2011 11:16 AM, Alon Levy wrote: On Mon, Jun 27, 2011 at 09:28:45AM +0300, yhalperi wrote: On 06/26/2011 08:47 PM, Alon Levy wrote: On Sun, Jun 26, 2011 at 12:59:06PM -0400, Yonit Halperin wrote: Sorry for the late response, wasn't available. I'm afraid that (1) and (2) will indeed wa

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support

2011-06-27 Thread Alon Levy
On Mon, Jun 27, 2011 at 09:28:45AM +0300, yhalperi wrote: > On 06/26/2011 08:47 PM, Alon Levy wrote: > >On Sun, Jun 26, 2011 at 12:59:06PM -0400, Yonit Halperin wrote: > >>Sorry for the late response, wasn't available. > >>I'm afraid that (1) and (2) will indeed wakeup the worker, but will not >

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-27 Thread Kevin Wolf
Am 23.06.2011 15:16, schrieb Stefano Stabellini: > On Mon, 20 Jun 2011, Kevin Wolf wrote: diff --git a/hw/xen_platform.c b/hw/xen_platform.c index b167eee..9f8c843 100644 --- a/hw/xen_platform.c +++ b/hw/xen_platform.c @@ -34,6 +34,9 @@ #include "xen_backend.h" #i

Re: [Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes

2011-06-27 Thread Alon Levy
On Mon, Jun 27, 2011 at 10:42:46AM +0300, yhalperi wrote: > On 06/24/2011 04:02 PM, Alon Levy wrote: > >Currently we define the following relation between modes and primary surface > >existance: > > > > QXL_MODE_COMPAT > > QXL_MODE_NATIVE primary exists > > QXL_MODE_UNDEFINED > > QXL_MODE_VGA

Re: [Qemu-devel] Need help: Save word (sw) and load word (lw) not working

2011-06-27 Thread Philip Loh
Resolved: I accidentally compiled an executable that had a different memory map than the board's memory map. Thanks though! On 27 June 2011 16:17, Stefan Hajnoczi wrote: > On Mon, Jun 27, 2011 at 8:37 AM, Philip Loh wrote: > > I'm new to QEMU development and am attempting to write code for a n

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-27 Thread Peter Maydell
On 26 June 2011 12:11, Michael S. Tsirkin wrote: > On Tue, Jun 14, 2011 at 08:36:33PM +0300, Michael S. Tsirkin wrote: >> Signed-off-by: Michael S. Tsirkin > > Riku, could you fix this up in a way that makes sense please? > All I really care about is that -Werror build passes with the latest > gc

Re: [Qemu-devel] Image streaming and live block copy

2011-06-27 Thread Dor Laor
On 06/27/2011 10:48 AM, Kevin Wolf wrote: Am 26.06.2011 14:50, schrieb Dor Laor: On 06/24/2011 12:28 PM, Stefan Hajnoczi wrote: On Sun, Jun 19, 2011 at 5:02 PM, Dor Laor wrote: On 06/18/2011 12:17 PM, Stefan Hajnoczi wrote: On Sat, Jun 18, 2011 at 10:15 AM, Stefan Hajnoczi wrote: On F

[Qemu-devel] [PATCH v6 2/5] coroutine: introduce coroutines

2011-06-27 Thread Stefan Hajnoczi
From: Kevin Wolf Asynchronous code is becoming very complex. At the same time synchronous code is growing because it is convenient to write. Sometimes duplicate code paths are even added, one synchronous and the other asynchronous. This patch introduces coroutines which allow code that looks sy

[Qemu-devel] [PATCH v6 3/5] coroutine: implement coroutines using gthread

2011-06-27 Thread Stefan Hajnoczi
From: "Aneesh Kumar K.V" On platforms that don't support makecontext(3) use gthread based coroutine implementation. Darwin has makecontext(3) but getcontext(3) is stubbed out to return ENOTSUP. Andreas Färber debugged this and contributed the ./configure test which solves the issue for Darwin/

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-27 Thread Peter Maydell
On 27 June 2011 10:06, Peter Maydell wrote: > On 26 June 2011 12:11, Michael S. Tsirkin wrote: >> On Tue, Jun 14, 2011 at 08:36:33PM +0300, Michael S. Tsirkin wrote: >>> Signed-off-by: Michael S. Tsirkin >> >> Riku, could you fix this up in a way that makes sense please? >> All I really care abo

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support

2011-06-27 Thread Alon Levy
On Mon, Jun 27, 2011 at 11:25:47AM +0300, yhalperi wrote: > On 06/27/2011 11:16 AM, Alon Levy wrote: > >On Mon, Jun 27, 2011 at 09:28:45AM +0300, yhalperi wrote: > >>On 06/26/2011 08:47 PM, Alon Levy wrote: > >>>On Sun, Jun 26, 2011 at 12:59:06PM -0400, Yonit Halperin wrote: > Sorry for the lat

[Qemu-devel] [PULL] virtio-serial: Fix segfault on start

2011-06-27 Thread Amit Shah
Hello, This fixes a segfault at startup regression debugged and fixed by Luiz. Please pull. The following changes since commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b: Fix MinGW compilation when --enable-vnc-jpeg is specified (2011-06-26 20:19:38 +) are available in the git repository

[Qemu-devel] [PATCH v6 0/5] Coroutines for better asynchronous programming

2011-06-27 Thread Stefan Hajnoczi
Here is the latest version of the coroutine series with Mac OS X fixes from Andreas Färber . QEMU is event-driven and suffers when blocking operations are performed because VM execution may be stopped until the operation completes. Therefore many operations that could block are performed asynchro

[Qemu-devel] [PATCH v6 1/5] Add hard build dependency on glib

2011-06-27 Thread Stefan Hajnoczi
From: Anthony Liguori GLib is an extremely common library that has a portable thread implementation along with tons of other goodies. GLib and GObject have a fantastic amount of infrastructure we can leverage in QEMU including an object oriented programming infrastructure. Short term, it has a

Re: [Qemu-devel] serial input with -serial stdio

2011-06-27 Thread Amit Shah
Hello, On (Fri) 24 Jun 2011 [02:22:44], Edgar E. Iglesias wrote: > Hi, > > Tried to stream 2K of data into a guest via an emulated serial port backed > by -serial stdio but it failed. Looks like data flows for a while, then > suddenly even though the last call to can_rceive returns +, nothing com

Re: [Qemu-devel] unix domain socket communication with guests

2011-06-27 Thread Amit Shah
On (Fri) 24 Jun 2011 [12:54:07], Joel Uckelman wrote: > On Fri, Jun 24, 2011 at 4:54 AM, Amit Shah wrote: > >> > >> I guess this means I need to get networking running on the guest so > >> that it has a port visible to the host on which my server can listen. > >> Is there a guide somewhere for doi

[Qemu-devel] [PATCH v6 4/5] coroutine: add test-coroutine automated tests

2011-06-27 Thread Stefan Hajnoczi
To run automated tests for coroutines: make test-coroutine ./test-coroutine On success the program terminates with exit status 0. On failure an error message is written to stderr and the program exits with exit status 1. Signed-off-by: Stefan Hajnoczi --- .gitignore |1 + Makefi

[Qemu-devel] [PATCH v6 5/5] coroutine: add test-coroutine --benchmark-lifecycle

2011-06-27 Thread Stefan Hajnoczi
Add a microbenchmark for coroutine create, enter, and return (aka lifecycle). This is a useful benchmark because users are expected to create many coroutines, one per I/O request for example, and we therefore need to provide good performance in that scenario. To run: make test-coroutine ./te

[Qemu-devel] [PATCH v4 00/12] Adding VMDK monolithic flat support

2011-06-27 Thread Fam Zheng
Changes from v3: 01/12: move vmdk_add_extent here 03/12: boundary check 04/12: use vmdk_add_extent in separated vmdk_open_* 09/12: NULL-terminate the input string Fam Zheng (12): VMDK: introduce VmdkExtent VMDK: bugfix, align offset to cluster in get_whole_cluster VMDK: probe

Re: [Qemu-devel] 80-column rule and breaking output statements

2011-06-27 Thread Amit Shah
On (Sun) 26 Jun 2011 [20:43:16], Blue Swirl wrote: > On Wed, Jun 22, 2011 at 7:53 AM, Amit Shah wrote: [snip] > > From dec93d9eccd639f7bfd1343dca65fa112eb19e3e Mon Sep 17 00:00:00 2001 > > Message-Id: > > > > From: Amit Shah > > Date: Wed, 22 Jun 2011 10:20:48 +0530 > > Subject: [PATCH 1/1] C

Re: [Qemu-devel] Windows 7 guest hangs after waking up from S3

2011-06-27 Thread yhalperi
On 06/27/2011 11:12 AM, Stefan Hajnoczi wrote: On Mon, Jun 27, 2011 at 8:04 AM, yhalperi wrote: I'm using qemu with qxl (with S3/4 support. patches sent by Alon Levy). While with Windows xp guest I had no problems, Windows 7 (32 bits) hangs after S3 (it looks alive for a second, and then it get

[Qemu-devel] [PATCH v4 04/12] VMDK: separate vmdk_open by format version

2011-06-27 Thread Fam Zheng
Separate vmdk_open by subformats to: * vmdk_open_vmdk3 * vmdk_open_vmdk4 Signed-off-by: Fam Zheng --- block/vmdk.c | 195 + 1 files changed, 126 insertions(+), 69 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 3bf8980..81c105

[Qemu-devel] [PATCH v4 01/12] VMDK: introduce VmdkExtent

2011-06-27 Thread Fam Zheng
Introduced VmdkExtent array into BDRVVmdkState, enable holding multiple image extents for multiple file image support. Signed-off-by: Fam Zheng --- block/vmdk.c | 351 +- 1 files changed, 250 insertions(+), 101 deletions(-) diff --git a/b

[Qemu-devel] [PATCH v4 03/12] VMDK: probe for monolithicFlat images

2011-06-27 Thread Fam Zheng
Probe as the same behavior as VMware does. Recognize image as monolithicFlat descriptor file when the file is text and the first effective line (not '#' leaded comment or space line) is either 'version=1' or 'version=2'. No space or upper case charactors accepted. Signed-off-by: Fam Zheng --- bl

[Qemu-devel] [PATCH v4 05/12] VMDK: add field BDRVVmdkState.desc_offset

2011-06-27 Thread Fam Zheng
There are several occurrence of magic number 0x200 as the descriptor offset within mono sparse image file. This is not the case for images with separate descriptor file. So a field is added to BDRVVmdkState to hold the correct value. Signed-off-by: Fam Zheng --- block/vmdk.c | 26 +

[Qemu-devel] [PATCH v4 07/12] VMDK: move 'static' cid_update flag to bs field

2011-06-27 Thread Fam Zheng
Cid_update is the flag for updating CID on first write after opening the image. This should be per image open rather than per program life cycle, so change it from static var of vmdk_write to a field in BDRVVmdkState. Signed-off-by: Fam Zheng --- block/vmdk.c |6 +++--- 1 files changed, 3 in

Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users

2011-06-27 Thread Amit Shah
On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote: > Ping? There were a couple of things: > port 0, guest on, host off, throttle off guest on/off, host on/off doesn't convey much -- what's on/off? Also, 'throttle' could be 'thottled'? Amit

[Qemu-devel] [PATCH v4 06/12] VMDK: flush multiple extents

2011-06-27 Thread Fam Zheng
Flush all the file that referenced by the image. Signed-off-by: Fam Zheng --- block/vmdk.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index c3f0ab6..cf7370f 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1084,7 +1084,17 @@ s

[Qemu-devel] [PATCH v4 08/12] VMDK: change get_cluster_offset return type

2011-06-27 Thread Fam Zheng
The return type of get_cluster_offset was an offset that use 0 to denote 'not allocated', this will be no longer true for flat extents, as we see flat extent file as a single huge cluster whose offset is 0 and length is the whole file length. So now we use int return value, 0 means success and othe

[Qemu-devel] [PATCH v4 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster

2011-06-27 Thread Fam Zheng
In get_whole_cluster, the offset is not aligned to cluster when reading from backing_hd. When the first write to child is not at the cluster boundary, wrong address data from parent is copied to child. Signed-off-by: Fam Zheng --- block/vmdk.c |8 +--- 1 files changed, 5 insertions(+), 3

[Qemu-devel] [PATCH 1/2] libcacard: gitignore updates

2011-06-27 Thread Alon Levy
--- .gitignore |4 libcacard/.gitignore |1 + 2 files changed, 5 insertions(+), 0 deletions(-) create mode 100644 libcacard/.gitignore diff --git a/.gitignore b/.gitignore index 08013fc..7acafe7 100644 --- a/.gitignore +++ b/.gitignore @@ -68,3 +68,7 @@ cscope.* tags TAG

[Qemu-devel] [PATCH v4 09/12] VMDK: open/read/write for monolithicFlat image

2011-06-27 Thread Fam Zheng
Parse vmdk decriptor file and open mono flat image. Read/write the flat extent. Signed-off-by: Fam Zheng --- block/vmdk.c | 185 + 1 files changed, 172 insertions(+), 13 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index c84ea90.

[Qemu-devel] [PATCH 2/2] libcacard: add pc file, install it + includes

2011-06-27 Thread Alon Levy
Also add --pkgconfigdir and --includedir configure parameters. --- configure | 10 ++ libcacard/Makefile| 25 ++--- libcacard/libcacard.pc.in | 13 + 3 files changed, 45 insertions(+), 3 deletions(-) create mode 100644 libcacar

[Qemu-devel] [PATCH v4 12/12] BlockDriver: add bdrv_get_allocated_file_size() operation

2011-06-27 Thread Fam Zheng
qemu-img.c wants to count allocated file size of image. Previously it counts a single bs->file by 'stat' or Window API. As VMDK introduces multiple file support, the operation becomes format specific with platform specific meanwhile. The functions are moved to block/raw-{posix,win32}.c and qemu-im

[Qemu-devel] [PATCH v4 10/12] VMDK: create different subformats

2011-06-27 Thread Fam Zheng
Add create option 'format', with enums: monolithicSparse monolithicFlat twoGbMaxExtentSparse twoGbMaxExtentFlat Each creates a subformat image file. The default is monolithiSparse. Signed-off-by: Fam Zheng --- block/vmdk.c | 563 ++

Re: [Qemu-devel] Windows 7 guest hangs after waking up from S3

2011-06-27 Thread Gleb Natapov
On Mon, Jun 27, 2011 at 01:12:18PM +0300, yhalperi wrote: > On 06/27/2011 11:12 AM, Stefan Hajnoczi wrote: > >On Mon, Jun 27, 2011 at 8:04 AM, yhalperi wrote: > >>I'm using qemu with qxl (with S3/4 support. patches sent by Alon Levy). > >>While with Windows xp guest I had no problems, Windows 7 (3

[Qemu-devel] [PATCH v4 11/12] VMDK: fix coding style

2011-06-27 Thread Fam Zheng
Conform coding style in vmdk.c to pass scripts/checkpatch.pl checks. Signed-off-by: Fam Zheng --- block/vmdk.c | 79 +++-- 1 files changed, 48 insertions(+), 31 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index f1d0cc9..786cfc4 100

Re: [Qemu-devel] [PATCH 2/2] libcacard: add pc file, install it + includes

2011-06-27 Thread Christophe Fergeau
Hi, On Mon, Jun 27, 2011 at 12:34:44PM +0200, Alon Levy wrote: > Also add --pkgconfigdir and --includedir configure parameters. > --- > configure | 10 ++ > libcacard/Makefile| 25 ++--- > libcacard/libcacard.pc.in | 13 + > 3

Re: [Qemu-devel] [PATCH] xen: move to new pci initializers

2011-06-27 Thread Stefano Stabellini
On Sun, 26 Jun 2011, Michael S. Tsirkin wrote: > move ids to pci info structure > > Signed-off-by: Michael S. Tsirkin > > Untested. > tested and working correctly, it is fine by me. > --- > hw/xen_platform.c | 15 +++ > 1 files changed, 7 insertions(+), 8 deletions(-) > > dif

Re: [Qemu-devel] [PATCH 1/2] libcacard: fix soft=... parsing in vcard_emul_options

2011-06-27 Thread Christophe Fergeau
On Fri, Jun 24, 2011 at 06:51:51PM +0200, Alon Levy wrote: > On Fri, Jun 24, 2011 at 04:37:39PM +0200, Christophe Fergeau wrote: > > The previous parser had copy and paste errors when computing > > vname_length and type_params_length, "name" was used instead > > of respectively vname and type_param

Re: [Qemu-devel] [PATCH] pci_ids: tweak names to match linux/pci_ids.h

2011-06-27 Thread Stefano Stabellini
On Sun, 26 Jun 2011, Michael S. Tsirkin wrote: > Sync xen names to ones used by linux. Add > xen platform device id as well. > > Signed-off-by: Michael S. Tsirkin thanks for the patch, it is fine by me. > --- > hw/pci_ids.h |3 ++- > hw/xen_platform.c |8 > 2 files chang

[Qemu-devel] Build break in current -git.

2011-06-27 Thread Rob Landley
In file included from /usr/include/png.h:510, from ui/vnc-enc-tight.c:37: /usr/include/pngconf.h:371: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘.’ token /usr/include/pngconf.h:372: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘include’ make:

[Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum

2011-06-27 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- slirp/slirp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 1593be1..be30501 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -697,7 +697,7 @@ void if_encap(Slirp *slirp, const uint8_t *ip_data,

Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users

2011-06-27 Thread Markus Armbruster
Amit Shah writes: > On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote: >> Ping? > > There were a couple of things: > >> port 0, guest on, host off, throttle off > > guest on/off, host on/off doesn't convey much -- what's on/off? > > Also, 'throttle' could be 'thottled'? Discus

[Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-27 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- target-ppc/translate.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 0a03b44..d0ca821 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -3995

[Qemu-devel] [RFC v2 06/20] pc: grab system_memory

2011-06-27 Thread Avi Kivity
While eventually this should come from the machine initialization function, take a short cut to avoid converting all machines now. Signed-off-by: Avi Kivity --- hw/pc.c |3 ++- hw/pc.h |4 +++- hw/pc_piix.c |8 +++- 3 files changed, 12 insertions(+), 3 deletions(-) dif

[Qemu-devel] [RFC v2 02/20] memory: implement dirty tracking

2011-06-27 Thread Avi Kivity
Currently dirty tracking is implemented by passing through all calls to the underlying cpu_physical_memory_*() calls. Signed-off-by: Avi Kivity --- memory.c | 39 +++ memory.h |1 + 2 files changed, 32 insertions(+), 8 deletions(-) diff --git a/memory.c

[Qemu-devel] [RFC v2 08/20] pc: move global memory map out of pc_init1() and into its callers

2011-06-27 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/pc_piix.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index d83854c..f2d0476 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -68,7 +68,8 @@ static void ioapic_init(IsaIrqState *isa_irq_state)

[Qemu-devel] [RFC v2 18/20] cirrus: simplify vga window mmio access functions

2011-06-27 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 83 -- 1 files changed, 13 insertions(+), 70 deletions(-) diff --git a/hw/cirrus_vga.c b/h

[Qemu-devel] [RFC v2 07/20] pc: convert pc_memory_init() to memory API

2011-06-27 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/pc.c | 59 --- hw/pc.h |1 + 2 files changed, 41 insertions(+), 19 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 369566a..1c9d89a 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -41,6 +41,7 @@ #include "sys

[Qemu-devel] [RFC v2 17/20] cirrus: simplify bitblt BAR access functions

2011-06-27 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 87 ++ 1 files changed, 16 insertions(+), 71 deletions(-) diff --git a/hw/cirrus_vga.c b/h

[Qemu-devel] [RFC v2 14/20] vmsvga: don't remember pci BAR address in callback any more

2011-06-27 Thread Avi Kivity
We're going to remove the callback, so we can't use it to save the address. Use the pci API instead. Signed-off-by: Avi Kivity --- hw/vmware_vga.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 354c221..190b005 100644

[Qemu-devel] [RFC v2 05/20] exec.c: initialize memory map

2011-06-27 Thread Avi Kivity
Allocate the root memory region and initialize it. Signed-off-by: Avi Kivity --- exec.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index b03b5be..9b894b9 100644 --- a/exec.c +++ b/exec.c @@ -34,6 +34,8 @@ #include "kvm.h" #includ

[Qemu-devel] [RFC v2 16/20] cirrus: simplify mmio BAR access functions

2011-06-27 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 82 +++ 1 files changed, 10 insertions(+), 72 deletions(-) diff --git a/hw/cirrus_vga.c b/

[Qemu-devel] [RFC v2 12/20] usb-ohci: convert to MemoryRegion

2011-06-27 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/usb-ohci.c | 42 +- 1 files changed, 17 insertions(+), 25 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index 5d2ae01..e6a901f 100644 --- a/hw/usb-ohci.c +++ b/hw/usb-ohci.c @@ -62,7 +62,7 @@ typedef struct OHCI

[Qemu-devel] [RFC v2 20/20] cirrus: simplify linear framebuffer access functions

2011-06-27 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 78 +++--- 1 files changed, 10 insertions(+), 68 deletions(-) diff --git a/hw/cirrus_vga.c b/h

[Qemu-devel] [RFC v2 19/20] vga: simplify vga window mmio access functions

2011-06-27 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. We have to keep vga_mem_{read,write}b() since they're used by cirrus. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c |4 +- hw/vga.c| 56 +++---

[Qemu-devel] [RFC v2 09/20] pci: pass address space to pci bus when created

2011-06-27 Thread Avi Kivity
This is now done sloppily, via get_system_memory(). Eventually callers will be converted to stop using that. Signed-off-by: Avi Kivity --- hw/apb_pci.c |2 ++ hw/bonito.c|4 +++- hw/grackle_pci.c |5 +++-- hw/gt64xxx.c |4 +++- hw/pc.h|4 +++

[Qemu-devel] [RFC v2 03/20] memory: merge adjacent segments of a single memory region

2011-06-27 Thread Avi Kivity
Simple implementations of memory routers, for example the Cirrus VGA memory banks or the 440FX PAM registers can generate adjacent memory regions which are contiguous. Detect these and merge them; this saves kvm memory slots and shortens lookup times. Signed-off-by: Avi Kivity --- memory.c |

[Qemu-devel] [RFC v2 15/20] vga: convert vga and its derivatives to the memory API

2011-06-27 Thread Avi Kivity
Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 346 +-- hw/vga-isa-mm.c | 66

[Qemu-devel] [RFC v2 04/20] Internal interfaces for memory API

2011-06-27 Thread Avi Kivity
get_system_memory() provides the root of the memory hierarchy. This interface is intended to be private between memory.c and exec.c. If this file is included elsewhere, it should be regarded as a bug (or TODO item). However, it will be temporarily needed for the conversion to hierarchical memory

[Qemu-devel] [RFC v2 11/20] sysbus: add MemoryRegion based memory management API

2011-06-27 Thread Avi Kivity
Allow registering sysbus device memory using a MemoryRegion. Once all users are converted, sysbus_init_mmio() and sysbus_init_mmio_cb() will be removed. Signed-off-by: Avi Kivity --- hw/sysbus.c | 27 --- hw/sysbus.h |3 +++ 2 files changed, 27 insertions(+), 3 del

[Qemu-devel] [RFC v2 13/20] pci: add API to get a BAR's mapped address

2011-06-27 Thread Avi Kivity
This is a hack, for devices that have a back-channel to read this address back outside the normal configuration mechanisms, such as VMware svga. Signed-off-by: Avi Kivity --- hw/pci.c |5 + hw/pci.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pc

[Qemu-devel] [RFC v2 01/20] Hierarchical memory region API

2011-06-27 Thread Avi Kivity
The memory API separates the attributes of a memory region (its size, how reads or writes are handled, dirty logging, and coalescing) from where it is mapped and whether it is enabled. This allows a device to configure a memory region once, then hand it off to its parent bus to map it according to

[Qemu-devel] [RFC v2 10/20] pci: add MemoryRegion based BAR management API

2011-06-27 Thread Avi Kivity
Allow registering a BAR using a MemoryRegion. Once all users are converted, pci_register_bar() and pci_register_bar_simple() will be removed. Signed-off-by: Avi Kivity --- hw/pci.c | 47 +++ hw/pci.h |3 +++ 2 files changed, 42 insertions(+), 8

Re: [Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-27 Thread Stefano Stabellini
On Fri, 24 Jun 2011, Peter Maydell wrote: > On 24 June 2011 12:08, wrote: > > From: Stefano Stabellini > > > > qemu_ram_ptr_length should take ram_addr_t as argument rather than > > target_phys_addr_t because is doing comparisons with RAMBlock addresses. > > > > cpu_physical_memory_map should cr

[Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Avi Kivity
As expected, this is taking longer than expected, so I'm releasing something less complete than I'd have liked. Not even all of the PC machine is converted, but the difficult parts are (cirrus). It appears to work well. The major change compared to v1 is the introduction of memory_region_init_al

Re: [Qemu-devel] [RFC v2 03/20] memory: merge adjacent segments of a single memory region

2011-06-27 Thread Jan Kiszka
On 2011-06-27 15:21, Avi Kivity wrote: > Simple implementations of memory routers, for example the Cirrus VGA memory > banks > or the 440FX PAM registers can generate adjacent memory regions which are > contiguous. > Detect these and merge them; this saves kvm memory slots and shortens lookup >

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum

2011-06-27 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 1:41 PM, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- >  slirp/slirp.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) Any particular bug that this fixes? There have been 64 byte minimum padding patches to several emulated NICs. There

Re: [Qemu-devel] Build break in current -git.

2011-06-27 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 1:31 PM, Rob Landley wrote: > In file included from /usr/include/png.h:510, >                 from ui/vnc-enc-tight.c:37: > /usr/include/pngconf.h:371: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or > ‘__attribute__’ before ‘.’ token > /usr/include/pngconf.h:372: error: expected ‘

Re: [Qemu-devel] [PATCH v2] xen_disk: cope with missing xenstore "params" node

2011-06-27 Thread Stefano Stabellini
On Sat, 25 Jun 2011, Peter Maydell wrote: > On 24 June 2011 17:35, wrote: > > +out_error: > > +    qemu_free(blkdev->params); > > +    qemu_free(blkdev->mode); > > +    qemu_free(blkdev->type); > > +    qemu_free(blkdev->dev); > > +    qemu_free(blkdev->devtype); > > +    return -1; > > It occur

Re: [Qemu-devel] [RFC v2 03/20] memory: merge adjacent segments of a single memory region

2011-06-27 Thread Avi Kivity
On 06/27/2011 04:56 PM, Jan Kiszka wrote: On 2011-06-27 15:21, Avi Kivity wrote: > Simple implementations of memory routers, for example the Cirrus VGA memory banks > or the 440FX PAM registers can generate adjacent memory regions which are contiguous. > Detect these and merge them; this sav

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum

2011-06-27 Thread Fabien Chouteau
On 27/06/2011 15:50, Stefan Hajnoczi wrote: > On Mon, Jun 27, 2011 at 1:41 PM, Fabien Chouteau wrote: >> >> Signed-off-by: Fabien Chouteau >> --- >> slirp/slirp.c |4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) > > Any particular bug that this fixes? > > There have been 64 byt

Re: [Qemu-devel] [PATCH 0/2] iothread improvements for Mac OS X

2011-06-27 Thread Paolo Bonzini
On 06/09/2011 01:10 PM, Paolo Bonzini wrote: These are two old patches that I never submitted because I didn't really think they were useful except as cleanups. Recently, however, Alex Graf mentioned some problems that Mac OS X has with iothread, and they sounded to me like they were related to

[Qemu-devel] KVM call agenda for June 28

2011-06-27 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Later, Juan.

Re: [Qemu-devel] [PATCH 08/10] cocoa: Revert dependency on VNC

2011-06-27 Thread Jes Sorensen
On 06/14/11 03:22, Andreas Färber wrote: > In 821601ea5b02a68ada479731a4d3d07a9876632a (Make VNC support optional) > cocoa.o was moved from ui-obj-$(CONFIG_COCOA) to vnc-obj-$(CONFIG_COCOA), > adding a dependency on $(CONFIG_VNC). That must've been unintentional. > > Cc: Jes Sorensen > Cc: Anthon

[Qemu-devel] [RFC PATCH v2] Specification for qcow2 version 3

2011-06-27 Thread Kevin Wolf
This is the second draft for what I think could be added when we increase qcow2's version number to 3. This includes points that have been made by several people over the past few months. We're probably not going to implement this next week, but I think it's important to get discussions started ea

[Qemu-devel] [PATCH v3] xen_disk: cope with missing xenstore "params" node

2011-06-27 Thread stefano.stabellini
From: Stefano Stabellini When disk is a cdrom and the drive is empty the "params" node in xenstore might be missing completely: cope with it instead of segfaulting. Updated in v2: - actually removed the strchr(blkdev->params, ':') that caused the segfault; - free all the allocated strings fro

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Avi Kivity
On 06/27/2011 04:21 PM, Avi Kivity wrote: As expected, this is taking longer than expected, so I'm releasing something less complete than I'd have liked. Not even all of the PC machine is converted, but the difficult parts are (cirrus). It appears to work well. The major change compared to v1

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Avi Kivity
On 06/27/2011 06:37 PM, Anthony Liguori wrote: On 06/27/2011 08:21 AM, Avi Kivity wrote: As expected, this is taking longer than expected, so I'm releasing something less complete than I'd have liked. Not even all of the PC machine is converted, but the difficult parts are (cirrus). It appear

[Qemu-devel] [PATCHv2 2/4] libcacard: fix soft=... parsing in vcard_emul_options

2011-06-27 Thread Christophe Fergeau
The previous parser had copy and paste errors when computing vname_length and type_params_length, "name" was used instead of respectively vname and type_params. This led to length that could be bigger than the input string, and to access out of the array bounds when trying to copy these strings. va

Re: [Qemu-devel] [RFC v2 00/20] Memory API

2011-06-27 Thread Michael S. Tsirkin
On Mon, Jun 27, 2011 at 06:13:03PM +0300, Avi Kivity wrote: > On 06/27/2011 04:21 PM, Avi Kivity wrote: > >As expected, this is taking longer than expected, so I'm releasing something > >less complete than I'd have liked. Not even all of the PC machine is > >converted, but the difficult parts are

[Qemu-devel] [PATCHv2 4/4] libcacard: replace copy_string with strndup

2011-06-27 Thread Christophe Fergeau
copy_string reimplements strndup, this commit removes it and replaces all copy_string uses with strndup. Signed-off-by: Christophe Fergeau --- libcacard/vcard_emul_nss.c | 23 ++- 1 files changed, 6 insertions(+), 17 deletions(-) diff --git a/libcacard/vcard_emul_nss.c b/l

[Qemu-devel] [PATCHv2 0/4] libcacard fixes

2011-06-27 Thread Christophe Fergeau
Hey, Alon asked me to split the parsing patches to make the review easier, to here they are. Changes since v1: - split first patch into 3 patches, v1 2/2 is unchanged Christophe Fergeau (4): libcacard: s/strip(args++)/strip(args+1) libcacard: fix soft=... parsing in vcard_emul_options libc

Re: [Qemu-devel] IO errors in guest caused by LTP dio test

2011-06-27 Thread Kevin Wolf
Am 23.06.2011 01:36, schrieb Andi Kleen: > > Running LTP testcases/kernel/io/direct_io/test_dma_thread_diotest7 > causes IO errors in the guest. There are no IO errors on the host. > > Kernel Linux 3.0.0-rc* > Using a standard emulated IDE -hda image. Couldn't reproduce this in a quick test wit

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum

2011-06-27 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 3:23 PM, Fabien Chouteau wrote: > On 27/06/2011 15:50, Stefan Hajnoczi wrote: >> On Mon, Jun 27, 2011 at 1:41 PM, Fabien Chouteau >> wrote: >>> >>> Signed-off-by: Fabien Chouteau >>> --- >>>  slirp/slirp.c |    4 ++-- >>>  1 files changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCHv2 1/4] libcacard: s/strip(args++)/strip(args+1)

2011-06-27 Thread Christophe Fergeau
vcard_emul_options used args = strip(args++) a few times, which was not returning the expected result since the rest of the code expected args to be increased by at least 1, which is not the case if *args is not a blank space when this function is called. Replace these calls by "strip(args+1)" whic

  1   2   >