[Qemu-devel] [PATCH V2] Support logging xen-guest console

2011-06-22 Thread Chunyan Liu
Add code to support logging xen-domU console, as what xenconsoled does. Log info will be saved in /var/log/xen/console/guest-domUname.log. Signed-off-by: Chunyan Liu --- hw/xen_console.c | 71 ++ 1 files changed, 71 insertions(+), 0 deletions

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-22 Thread Jan Kiszka
On 2011-06-22 08:19, Pavel Dovgaluk wrote: >> "Pavel Dovgaluk" wrote: >>> This patch fixes save/restore of serial interface's state. >>> It includes changing of fcr setter function (it now does not invoke >>> an interrupt while loading vmstate), and saving/restoring all >>> fields that describ

Re: [Qemu-devel] block: regression: savevm/delvm too slow

2011-06-22 Thread Kevin Wolf
Am 21.06.2011 19:29, schrieb Luiz Capitulino: > I'm getting the following times when doing a savevm and delvm in current > HEAD eb47d7c5d (time in minutes, each time corresponds to a savevm/delvm run): > > savevm: 5:28m, 11:00m, 11:10m > delvm: 4:30m, 4:40m, > 15m > > Now, trying with qemu 0.13

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-22 Thread Pavel Dovgaluk
> >>> This patch fixes save/restore of serial interface's state. > >>> It includes changing of fcr setter function (it now does not invoke > >>> an interrupt while loading vmstate), and saving/restoring all > >>> fields that describe the state of serial interface (including timers). > >>> > >>>

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-22 Thread Jan Kiszka
On 2011-06-22 10:58, Pavel Dovgaluk wrote: >>> What is the purpose of subsections? >> >> To skip the new fields whenever possible. That would allow to continue >> saving a vmstate on a new version of qemu and then restoring it on an >> older one. > > Do you have an idea how to implement "neede

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support

2011-06-22 Thread Gerd Hoffmann
Hi, worker call. We can add a I/O command to ask qxl to push the release queue head to the release ring. So you suggest to replace QXL_IO_UPDATE_MEM with what, two io commands instead of using the val parameter? I'd like to (a) avoid updating the libspice-server API if possible and (b) h

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-22 Thread Pavel Dovgaluk
> >>> What is the purpose of subsections? > >> > >> To skip the new fields whenever possible. That would allow to continue > >> saving a vmstate on a new version of qemu and then restoring it on an > >> older one. > > > > Do you have an idea how to implement "needed" function for my case? > > B

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-22 Thread Jan Kiszka
On 2011-06-22 11:15, Pavel Dovgaluk wrote: > What is the purpose of subsections? To skip the new fields whenever possible. That would allow to continue saving a vmstate on a new version of qemu and then restoring it on an older one. >>> >>> Do you have an idea how to imp

Re: [Qemu-devel] buildbot failure in qemu on s390-next_i386_debian_5_0

2011-06-22 Thread Stefan Hajnoczi
On Wed, Jun 22, 2011 at 8:03 AM, wrote: > The Buildbot has detected a new failure on builder s390-next_i386_debian_5_0 > while building qemu. > Full details are available at: >  http://buildbot.b1-systems.de/qemu/builders/s390-next_i386_debian_5_0/builds/11 Haven't looked deeply into this but I

Re: [Qemu-devel] [PATCH] target-arm: support for ARM1176JZ-s cores

2011-06-22 Thread Peter Maydell
On 22 June 2011 00:42, Jamie Iles wrote: > On 21 June 2011 23:13, Peter Maydell wrote: >> Ah yes, sorry, I misread the TRM there. So it does have those, it's >> just the SEV/WFI/WFE it is missing. I guess we'll want an >> ARM_FEATURE_VAPA too. > > Could we perhaps infer and detect some of these f

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support

2011-06-22 Thread Alon Levy
On Wed, Jun 22, 2011 at 11:13:19AM +0200, Gerd Hoffmann wrote: > Hi, > > >>worker call. We can add a I/O command to ask qxl to push the > >>release queue head to the release ring. > > > >So you suggest to replace QXL_IO_UPDATE_MEM with what, two io commands > >instead > >of using the val param

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-22 Thread Pavel Dovgaluk
> On 2011-06-22 11:15, Pavel Dovgaluk wrote: > > What is the purpose of subsections? > > To skip the new fields whenever possible. That would allow to continue > saving a vmstate on a new version of qemu and then restoring it on an > older one. > >>> > >>> Do you have an

[Qemu-devel] [PATCH] exec.c: Fix calculation of code_gen_buffer_max_size

2011-06-22 Thread Peter Maydell
When calculating the point at which we should not try to put another TB into the code gen buffer, we have to allow not just for OPC_MAX_SIZE but OPC_BUF_SIZE. This is because the target translate.c will only stop when an instruction has put it past the OPC_MAX_SIZE limit, so we have to include the

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-06-22 Thread Peter Maydell
Ping^2 ? On 5 June 2011 14:12, Peter Maydell wrote: > Combination 'ping' and 'oops I forgot to cc the net/ maintainers'... > > -- PMM > > On 20 May 2011 16:49, Peter Maydell wrote: >> This patchset reverts commit f68b9d672, which was triggering >> spuriously for NICs created via -device rather t

Re: [Qemu-devel] [PATCH v3] configure: Don't create symlinks to nonexistent targets

2011-06-22 Thread Peter Maydell
ping? I didn't cc trivial first time round on the theory that any patch that makes it to v3 isn't trivial, but since nobody's commented on this version I guess it's OK... -- PMM On 3 June 2011 17:10, Peter Maydell wrote: > When we create the symlinks to source tree files, don't create them > if

Re: [Qemu-devel] [PATCH] XBRLE page delta compression for live migration of large memory apps

2011-06-22 Thread Anthony Liguori
On 05/22/2011 07:00 AM, Shribman, Aidan wrote: Subject: [PATCH] XBRLE page delta compression for live migration of large memory apps From: Aidan Shribman By using XBRLE (Xor Based Run-Length-Encoding) we can reduce required bandwidth for transfering of dirty memory pages during live migration

[Qemu-devel] [PATCH trivial 5/5] blockdev: Put space after comma in error message

2011-06-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- blockdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 1502575..7d579d6 100644 --- a/blockdev.c +++ b/blockdev.c @@ -293,7 +293,7 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)

[Qemu-devel] [PATCH trivial 0/5] Fix error_report() calls

2011-06-22 Thread Markus Armbruster
I limited myself to truly trivial fixes. I hope that's still useful enough to excuse a little rant. "bug: 0 0" is not a useful error message. Neither are "Desc next is 128", " too short" (too short indeed), "wrong magic" (some "wrong magic" skills will be handy to figure out what went wrong). I

[Qemu-devel] [PATCH trivial 3/5] qemu-img: Don't prepend qemu-img to error messages twice.

2011-06-22 Thread Markus Armbruster
error_report() prepends the location already. Example: $ qemu-img convert -6 qemu-img: qemu-img: option -6 is deprecated, please use '-o compat6' instead! Signed-off-by: Markus Armbruster --- qemu-img.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-img.c

[Qemu-devel] [PATCH trivial 1/5] sheepdog: qemu_bh_new() can't return null pointer, drop check

2011-06-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block/sheepdog.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 0392ca8..2180299 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -449,13 +449,7 @@ static int sd_schedule_bh(QEMUB

[Qemu-devel] [PATCH trivial 4/5] Spell "unkown" correctly in error_report() arguments

2011-06-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/lm32_sys.c |2 +- hw/lm32_timer.c|4 ++-- hw/lm32_uart.c |4 ++-- hw/milkymist-ac97.c|4 ++-- hw/milkymist-memcard.c |4 ++-- hw/milkymist-sysctl.c |4 ++-- 6 files changed, 11 insertions(+), 11 deletio

[Qemu-devel] [PATCH trivial 2/5] Strip trailing '\n' from error_report()'s first argument

2011-06-22 Thread Markus Armbruster
error_report() prepends location, and appends a newline. The message constructed from the arguments should not contain a newline. Fix the obvious offenders. Signed-off-by: Markus Armbruster --- block-migration.c |2 +- block/qcow2.c |2 +- block/sheepdog.c| 84

Re: [Qemu-devel] [PATCH v3] configure: Don't create symlinks to nonexistent targets

2011-06-22 Thread Stefan Hajnoczi
On Fri, Jun 03, 2011 at 05:10:40PM +0100, Peter Maydell wrote: > When we create the symlinks to source tree files, don't create them > if the file is not actually present in the source tree; this will > happen if the file is in a git submodule that wasn't checked out. > > This also avoids the odd

Re: [Qemu-devel] struct TimerState

2011-06-22 Thread Lluís
Nilay Vaish writes: > I would like to determine the later. icount will give the instruction count. I > need the instruction count as well, but is there some way to determine the > guest > cycles as well? On the current implementation, the number of cycles is directly related to the icount, so wh

Re: [Qemu-devel] [PATCH] XBRLE page delta compression for live migration of large memory apps

2011-06-22 Thread Stefan Hajnoczi
On Wed, Jun 22, 2011 at 1:01 PM, Anthony Liguori wrote: > On 05/22/2011 07:00 AM, Shribman, Aidan wrote: >> >> Subject: [PATCH] XBRLE page delta compression for live migration of large >> memory apps >> From: Aidan Shribman >> >> By using XBRLE (Xor Based Run-Length-Encoding) we can reduce require

Re: [Qemu-devel] [PATCH trivial 0/5] Fix error_report() calls

2011-06-22 Thread Anthony Liguori
On 06/22/2011 07:03 AM, Markus Armbruster wrote: I limited myself to truly trivial fixes. I hope that's still useful enough to excuse a little rant. "bug: 0 0" is not a useful error message. Neither are "Desc next is 128", " too short" (too short indeed), "wrong magic" (some "wrong magic" skil

Re: [Qemu-devel] block: regression: savevm/delvm too slow

2011-06-22 Thread Luiz Capitulino
On Wed, 22 Jun 2011 10:56:07 +0200 Kevin Wolf wrote: > Am 21.06.2011 19:29, schrieb Luiz Capitulino: > > I'm getting the following times when doing a savevm and delvm in current > > HEAD eb47d7c5d (time in minutes, each time corresponds to a savevm/delvm > > run): > > > > savevm: 5:28m, 11:00m

Re: [Qemu-devel] [PATCH v2] virtio-serial: Fix segfault on guest boot

2011-06-22 Thread Luiz Capitulino
On Wed, 22 Jun 2011 09:49:22 +0530 Amit Shah wrote: > On (Fri) 17 Jun 2011 [15:58:08], Luiz Capitulino wrote: > > If I start qemu with: > > > > # qemu -hda disks/test.img -enable-kvm -m 1G -snapshot \ > > -device virtio-serial \ > > -chardev socket,host=localhost,port=1234,se

Re: [Qemu-devel] [PULL] pci, virtio, exec, vhost

2011-06-22 Thread Anthony Liguori
On 06/19/2011 04:58 AM, Michael S. Tsirkin wrote: The following changes since commit 0b862cedf36d927818c50584ddd611b0370673df: configure: Detect and don't try to use older libcurl (2011-06-13 21:16:27 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kerne

Re: [Qemu-devel] [PATCH 00/15] [PULL] qemu-kvm.git uq/master queue

2011-06-22 Thread Anthony Liguori
On 06/21/2011 12:07 PM, Marcelo Tosatti wrote: The following changes since commit eb47d7c5d96060040931c42773ee07e61e547af9: hw/9118.c: Implement active-low interrupt support (2011-06-15 13:23:37 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.

Re: [Qemu-devel] [PULL 0/3]: Monitor queue

2011-06-22 Thread Anthony Liguori
On 06/21/2011 12:57 PM, Luiz Capitulino wrote: Anthony, The following patches have been sent to the list and look good to me. I've also tested them. Pulled. Thanks. Regards, Anthony Liguori The changes (since eb47d7c5d96060040931c42773ee07e61e547af9) are available in the following reposi

[Qemu-devel] [PATCH v4 10/18] qapi: add ordereddict.py helper library

2011-06-22 Thread Michael Roth
We need this to parse dictionaries with schema ordering intact so that C prototypes can be generated deterministically. Signed-off-by: Michael Roth --- scripts/ordereddict.py | 128 1 files changed, 128 insertions(+), 0 deletions(-) create mode

[Qemu-devel] [PATCH v4 01/18] Add hard build dependency on glib

2011-06-22 Thread Michael Roth
From: Anthony Liguori GLib is an extremely common library that has a portable thread implementation along with tons of other goodies. GLib and GObject have a fantastic amount of infrastructure we can leverage in QEMU including an object oriented programming infrastructure. Short term, it has a

Re: [Qemu-devel] [PULL 0/2] Trivial patches for June 9 to June 15 2011

2011-06-22 Thread Anthony Liguori
On 06/15/2011 11:47 AM, Stefan Hajnoczi wrote: The following changes since commit 71f34ad05359d7fa97996562d904979281ddc7f5: Merge remote-tracking branch 'alon/pull-libcacard-1' into staging (2011-06-15 09:03:49 -0500) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu

Re: [Qemu-devel] [PULL] Xen Patch Queue

2011-06-22 Thread Anthony Liguori
On 06/18/2011 09:57 PM, Alexander Graf wrote: Hi Anthony, This is my current patch queue for Xen patches. Please pull. Pulled. Thanks. Regards, Anthony Liguori Alex The following changes since commit eb47d7c5d96060040931c42773ee07e61e547af9: Peter Maydell (1): hw/9118.c: Im

[Qemu-devel] [PATCH v4 04/18] qapi: add QAPI visitor core

2011-06-22 Thread Michael Roth
Base definitions/includes for Visiter interface used by generated visiter/marshalling code. Includes a GenericList type. Our lists require an embedded element. Since these types are generated, if you want to use them in a different type of data structure, there's no easy way to add another embedde

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-06-22 Thread Anthony Liguori
On 05/20/2011 10:49 AM, Peter Maydell wrote: This patchset reverts commit f68b9d672, which was triggering spuriously for NICs created via -device rather than -net nic. It then reimplements the improved diagnostics with a different approach which only applies to '-net nic'. (It's only -net nic dev

Re: [Qemu-devel] [PATCH v2] Optimize screendump

2011-06-22 Thread Anthony Liguori
On 06/20/2011 03:12 AM, Avi Kivity wrote: When running kvm-autotest, fputc() is often the second highest (sometimes #1) function showing up in a profile. This is due to fputc() locking the file for every byte written. Optimize by buffering a line's worth of pixels and writing that out in a sing

[Qemu-devel] [PATCH v4 15/18] qapi: test schema used for unit tests

2011-06-22 Thread Michael Roth
This is how QMP commands/parameters/types would be defined. We use a subset of that functionality here to implement functions/types for unit testing. Signed-off-by: Michael Roth --- qapi-schema-test.json | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) create mod

[Qemu-devel] [PATCH v4 06/18] qapi: add QMP output visitor

2011-06-22 Thread Michael Roth
Type of Visiter class that serves as the inverse of the input visitor: it takes a series of native C types and uses their values to construct a corresponding QObject. The command marshaling/dispatcher functions will use this to convert the output of QMP functions into a QObject that can be sent ove

[Qemu-devel] [PATCH v4 02/18] qlist: add qlist_first()/qlist_next()

2011-06-22 Thread Michael Roth
Signed-off-by: Michael Roth --- qlist.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/qlist.h b/qlist.h index dbe7b92..d426bd4 100644 --- a/qlist.h +++ b/qlist.h @@ -16,6 +16,7 @@ #include "qobject.h" #include "qemu-queue.h" #include "qemu-common.h" +#inc

[Qemu-devel] [PATCH v4 16/18] qapi: add test-visitor, tests for gen. visitor code

2011-06-22 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile | 16 +++- test-visitor.c | 305 2 files changed, 320 insertions(+), 1 deletions(-) create mode 100644 test-visitor.c diff --git a/Makefile b/Makefile index 306cd9b..6083085 100644 --- a/

[Qemu-devel] [QAPI+QGA 2/3] QAPI code generation infrastructure v4

2011-06-22 Thread Michael Roth
This is Set 2/3 of the QAPI+QGA patchsets. These patches apply on top of master (set1 merged), and can also be obtained from: git://repo.or.cz/qemu/mdroth.git qapi-backport-set2-v4 (Set1+2 are a backport of some of the QAPI-related work from Anthony's glib tree. The main goal is to get the basic

[Qemu-devel] [PATCH v4 03/18] qapi: add module init types for qapi

2011-06-22 Thread Michael Roth
Signed-off-by: Michael Roth --- module.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/module.h b/module.h index 9263f1c..ef66730 100644 --- a/module.h +++ b/module.h @@ -24,12 +24,14 @@ typedef enum { MODULE_INIT_BLOCK, MODULE_INIT_DEVICE, MODULE_INIT_

[Qemu-devel] [PATCH v4 05/18] qapi: add QMP input visitor

2011-06-22 Thread Michael Roth
A type of Visiter class that is used to walk a qobject's structure and assign each entry to the corresponding native C type. Command marshaling function will use this to pull out QMP command parameters recieved over the wire and pass them as native arguments to the corresponding C functions. Signe

[Qemu-devel] [PATCH v4 13/18] qapi: add qapi-visit.py code generator

2011-06-22 Thread Michael Roth
This is the code generator for qapi visiter functions used to marshal/unmarshal/dealloc qapi types. It generates the following 2 files: $(prefix)qapi-visit.c: visiter function for a particular c type, used to automagically convert qobjects into the

[Qemu-devel] [PATCH v4 07/18] qapi: add QAPI dealloc visitor

2011-06-22 Thread Michael Roth
Type of Visitor class that can be passed into a qapi-generated C type's visitor function to free() any heap-allocated data types. Signed-off-by: Michael Roth --- Makefile.objs |2 +- qapi/qapi-dealloc-visitor.c | 138 +++ qapi/qapi-deall

[Qemu-devel] [PATCH v4 11/18] qapi: add qapi.py helper libraries

2011-06-22 Thread Michael Roth
Signed-off-by: Michael Roth --- scripts/qapi.py | 203 +++ 1 files changed, 203 insertions(+), 0 deletions(-) create mode 100644 scripts/qapi.py diff --git a/scripts/qapi.py b/scripts/qapi.py new file mode 100644 index 000..56af232 --- /

[Qemu-devel] [PATCH v4 08/18] qapi: add QMP command registration/lookup functions

2011-06-22 Thread Michael Roth
Registration/lookup functions for that provide a lookup table for dispatching QMP commands. Signed-off-by: Michael Roth --- Makefile.objs |1 + qapi/qmp-core.h | 40 qapi/qmp-registry.c | 40 3 fi

[Qemu-devel] [PATCH v4 17/18] qapi: add test-qmp-commands, tests for gen. marshalling/dispatch code

2011-06-22 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile|8 +++- test-qmp-commands.c | 113 +++ 2 files changed, 120 insertions(+), 1 deletions(-) create mode 100644 test-qmp-commands.c diff --git a/Makefile b/Makefile index 6083085..6adf1a9 100

[Qemu-devel] [PATCH v4 09/18] qapi: add QMP dispatch functions

2011-06-22 Thread Michael Roth
Given an object recieved via QMP, this code uses the dispatch table provided by qmp_registry.c to call the corresponding marshalling/dispatch function and format return values/errors for delivery to the QMP. Currently only synchronous QMP functions are supported, but this will also be used for asyn

[Qemu-devel] [PATCH v4 12/18] qapi: add qapi-types.py code generator

2011-06-22 Thread Michael Roth
This is the code generator for qapi types. It will generation the following files: $(prefix)qapi-types.h - C types corresponding to types defined in the schema you pass in $(prefix)qapi-types.c - Cleanup functions for the above C types The $(prefix) is used to as a n

[Qemu-devel] [PATCH v4 14/18] qapi: add qapi-commands.py code generator

2011-06-22 Thread Michael Roth
This is the code generator for qapi command marshaling/dispatch. Currently only generators for synchronous qapi/qmp functions are supported. This script generates the following files: $(prefix)qmp-marshal.c: command marshal/dispatch functions for each QMP command define

[Qemu-devel] [PATCH v4 18/18] qapi: add QAPI code generation documentation

2011-06-22 Thread Michael Roth
Signed-off-by: Michael Roth --- docs/qapi-code-gen.txt | 316 1 files changed, 316 insertions(+), 0 deletions(-) create mode 100644 docs/qapi-code-gen.txt diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt new file mode 100644 index 0

[Qemu-devel] [PATCH] tcg/README: Expand advice on number of TCG ops per target insn

2011-06-22 Thread Peter Maydell
Expand the note on the number of TCG ops generated per target insn, to be clearer about the range of applicability of the 20 op rule of thumb. Also add a note about the hard MAX_OP_PER_INSTR limit. Signed-off-by: Peter Maydell --- The expansion of the first bullet point is based on remarks by Aur

[Qemu-devel] [PATCH] MAINTAINERS: Fix typo in email address

2011-06-22 Thread Peter Maydell
Fix a typo in one of the copies of Aurelien Jarno's email address. Signed-off-by: Peter Maydell --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 35d4496..6115e4e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -480,7 +480,7 @

Re: [Qemu-devel] [V3 1/3] Enhance "info block" to display hostcache setting

2011-06-22 Thread Supriya Kannery
On 06/20/2011 07:53 PM, Kevin Wolf wrote: Am 17.06.2011 18:37, schrieb Supriya Kannery: + int open_flags = qdict_get_int(bs_dict, "open_flags"); + if (open_flags& BDRV_O_NOCACHE) + monitor_printf(mon, " hostcache=false"); + else +

[Qemu-devel] [PATCH] exec-all.h: Make MAX_OP_PER_INSTR large enough for target-arm's uses

2011-06-22 Thread Peter Maydell
The target-arm frontend's worst-case TCG ops per instr is 194 (and in general many of the "load multiple registers" ARM instructions generate more than 100 TCG ops). Raise MAX_OP_PER_INSTR accordingly to avoid possible buffer overruns. Since it doesn't make any sense for the "64 bit guest on 32 bi

Re: [Qemu-devel] [PATCH] target-arm: support for ARM1176JZ-s cores

2011-06-22 Thread Jamie Iles
On Wed, Jun 22, 2011 at 10:40:12AM +0100, Peter Maydell wrote: > On 22 June 2011 00:42, Jamie Iles wrote: > > On 21 June 2011 23:13, Peter Maydell wrote: > >> Ah yes, sorry, I misread the TRM there. So it does have those, it's > >> just the SEV/WFI/WFE it is missing. I guess we'll want an > >> AR

Re: [Qemu-devel] [V2 3/3] Command "block_set" for dynamic block params change

2011-06-22 Thread Supriya Kannery
On 06/20/2011 08:04 PM, Kevin Wolf wrote: Am 17.06.2011 18:38, schrieb Supriya Kannery: + if (bdrv_is_inserted(bs)) { + /* cache change applicable only if device inserted */ + return bdrv_change_hostcache(bs, enable); + }

[Qemu-devel] [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids

2011-06-22 Thread anthony.perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/piix_pci.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 26ce904..d08b31a 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_inf

Re: [Qemu-devel] [PATCH] target-arm: support for ARM1176JZ-s cores

2011-06-22 Thread Jamie Iles
On Wed, Jun 22, 2011 at 05:01:30PM +0100, Peter Maydell wrote: > On 22 June 2011 16:45, Jamie Iles wrote: > > On Wed, Jun 22, 2011 at 10:40:12AM +0100, Peter Maydell wrote: > >> Mostly what I'd like is for the actual code implementing things to > >> be gated on a fairly fine-grained set of flags,

Re: [Qemu-devel] [PATCH] target-arm: support for ARM1176JZ-s cores

2011-06-22 Thread Peter Maydell
On 22 June 2011 17:16, Jamie Iles wrote: > The ARM1176 technically is a v6K core, but the actual definition of v6K > seems a bit vague on required features. > > As wfi is a valid encoding on 1176 I personally don't see this as being > a blocking issue (though technically incorrect, though most cod

Re: [Qemu-devel] [PATCH] target-arm: support for ARM1176JZ-s cores

2011-06-22 Thread Peter Maydell
On 22 June 2011 16:45, Jamie Iles wrote: > On Wed, Jun 22, 2011 at 10:40:12AM +0100, Peter Maydell wrote: >> Mostly what I'd like is for the actual code implementing things to >> be gated on a fairly fine-grained set of flags, so that we can confine >> the "what does this core have? what things im

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-22 Thread Jan Kiszka
On 2011-06-22 12:13, Pavel Dovgaluk wrote: >> On 2011-06-22 11:15, Pavel Dovgaluk wrote: >>> What is the purpose of subsections? >> >> To skip the new fields whenever possible. That would allow to continue >> saving a vmstate on a new version of qemu and then restoring it on an >>

Re: [Qemu-devel] [PATCH] qemu-char: Print strerror message on failure

2011-06-22 Thread Anthony Liguori
On 06/21/2011 11:18 AM, Kevin Wolf wrote: Am 21.06.2011 18:09, schrieb Markus Armbruster: Kevin Wolf writes: The only way for chardev drivers to communicate an error was to return a NULL pointer, which resulted in an error message that said _that_ something went wrong, but not _why_. This pa

[Qemu-devel] [PATCH 8/8] target-arm: Fix BASEPRI, BASEPRI_MAX, and FAULTMASK access

2011-06-22 Thread Peter Maydell
From: Sebastian Huber Correct the decode of the register numbers for BASEPRI, BASEPRI_MAX and FAULTMASK, according to "ARMv7-M Architecture Reference Manual" issue D section "B5.2.3 MRS" and "B5.2.3 MSR". Signed-off-by: Sebastian Huber Signed-off-by: Peter Maydell --- target-arm/helper.c |

[Qemu-devel] [PATCH 6/8] Revert "Makefile.target: Allow target helpers to be in any *_helper.c file"

2011-06-22 Thread Peter Maydell
Reverts commit 348883d4828d7434e1053407818598f7fb15e594, so the global env is no longer available to helper.c files other than op_helper.c. Signed-off-by: Peter Maydell --- Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target

[Qemu-devel] [PATCH 7/8] target-arm: Minimal implementation of performance counters

2011-06-22 Thread Peter Maydell
Newer Linux kernels assume the existence of the performance counter cp15 registers. Provide a minimal implementation of these registers. We support no events. This should be compliant with the ARM ARM, except that we don't implement the cycle counter. Signed-off-by: Peter Maydell --- target-arm/

[Qemu-devel] [PATCH 4/8] target-arm: Pass fp status pointer explicitly to neon fp helpers

2011-06-22 Thread Peter Maydell
Make the Neon helpers for various floating point operations take an explicit pointer to the float_status they use, so they don't rely on the global environment pointer any more. This also allows us to drop the mul/sub/add helpers completely and just use the vfp versions. Signed-off-by: Peter Mayde

[Qemu-devel] [PATCH 2/8] target-arm: Add helper function to generate code to get fpstatus pointer

2011-06-22 Thread Peter Maydell
Add and use a helper function which returns a TCGv which is a pointer to the fp_status for either Neon or VFP operations. Signed-off-by: Peter Maydell --- target-arm/translate.c | 40 1 files changed, 16 insertions(+), 24 deletions(-) diff --git a/targ

[Qemu-devel] [PATCH 5/8] Revert "target-arm: Use global env in neon_helper.c helpers"

2011-06-22 Thread Peter Maydell
This effectively reverts commit 2a3f75b42ac255be09ec2939b96c549ec830efd3 so that we return to passing CPUState to helpers as an explicit parameter. (There were a number of conflicts in target-arm/translate.c which had to be resolved by hand so it is not a pure revert.) Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 0/8] ARM patch queue

2011-06-22 Thread Peter Maydell
This is a pull request for various ARM related patches which have been on the list for a while (mostly but not entirely mine). The performance counters patch had quite a bit of discussion when originally posted (http://patchwork.ozlabs.org/patch/92423/) which was basically focused around the quest

[Qemu-devel] [PATCH 3/8] target-arm: Make VFP binop helpers take pointer to fpstatus, not CPUState

2011-06-22 Thread Peter Maydell
Make the VFP binop helper functions take a pointer to the fp status, not the entire CPUState. This will allow us to use them for Neon operations too. Signed-off-by: Peter Maydell --- target-arm/helper.c| 10 ++ target-arm/helper.h| 16 target-arm/translate.c

Re: [Qemu-devel] [PATCH V2] Support logging xen-guest console

2011-06-22 Thread Stefano Stabellini
On Wed, 22 Jun 2011, Chunyan Liu wrote: > Add code to support logging xen-domU console, as what xenconsoled does. Log > info > will be saved in /var/log/xen/console/guest-domUname.log. > I think is OK. Only one more thing: please make sure your lines don't go over 80 characters.

[Qemu-devel] [PATCH 1/8] Revert "target-arm: Use global env in iwmmxt_helper.c helpers"

2011-06-22 Thread Peter Maydell
This reverts commit 947a2fa21b61703802a660a938cabd7b3600ee79, returning the iwmmxt helpers to passing env in as a parameter. Signed-off-by: Peter Maydell --- target-arm/helper.h| 122 +- target-arm/iwmmxt_helper.c | 80 --

Re: [Qemu-devel] [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids

2011-06-22 Thread Stefano Stabellini
On Wed, 22 Jun 2011, anthony.per...@citrix.com wrote: > From: Anthony PERARD > > Signed-off-by: Anthony PERARD > --- > hw/piix_pci.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/hw/piix_pci.c b/hw/piix_pci.c > index 26ce904..d08b31a 100644 > --- a/hw/piix_pci

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids

2011-06-22 Thread Anthony PERARD
On Wed, Jun 22, 2011 at 18:43, Stefano Stabellini wrote: > On Wed, 22 Jun 2011, anthony.per...@citrix.com wrote: >> From: Anthony PERARD >> >> Signed-off-by: Anthony PERARD >> --- >>  hw/piix_pci.c |    3 +++ >>  1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/hw/piix_pci.c b

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids

2011-06-22 Thread Stefano Stabellini
On Wed, 22 Jun 2011, Anthony PERARD wrote: > On Wed, Jun 22, 2011 at 18:43, Stefano Stabellini > wrote: > > On Wed, 22 Jun 2011, anthony.per...@citrix.com wrote: > >> From: Anthony PERARD > >> > >> Signed-off-by: Anthony PERARD > >> --- > >>  hw/piix_pci.c |    3 +++ > >>  1 files changed, 3 ins

[Qemu-devel] RFC: Qemu Guest Tools ISO

2011-06-22 Thread Michael Roth
Goal: Provide a mechanism, similar to vmware and virtualbox guest tools ISOs, that allows us to easily distribute guest tools (and potentially drivers) for linux and windows guests. Advantages (rough list to start the discussion, feel free to add/comment): - Simplify deployment of guest addi

Re: [Qemu-devel] [PATCH V2] Support logging xen-guest console

2011-06-22 Thread Anthony Liguori
On 06/22/2011 02:26 AM, Chunyan Liu wrote: Add code to support logging xen-domU console, as what xenconsoled does. Log info will be saved in /var/log/xen/console/guest-domUname.log. It needs to be specified by command line. It's not appropriate to assume qemu is running as root with access to

Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers

2011-06-22 Thread Stefan Weil
Am 08.06.2011 16:10, schrieb Jan Kiszka: This helps reducing our build-time checks for feature support in the available Linux kernel headers. And it helps users that do not have sufficiently recent headers installed on their build machine. Consequently, the patch removes and build-time checks fo

Re: [Qemu-devel] [PATCH v2] Optimize screendump

2011-06-22 Thread Andreas Färber
Am 20.06.2011 um 15:11 schrieb Avi Kivity: On 06/20/2011 03:33 PM, Jan Kiszka wrote: > --- a/hw/vga.c > +++ b/hw/vga.c > @@ -2349,15 +2349,19 @@ int ppm_save(const char *filename, struct DisplaySurface *ds) Unrelated to this patch, but why is this function located in vga.c and not in

Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers

2011-06-22 Thread Jan Kiszka
On 2011-06-22 22:51, Stefan Weil wrote: > Am 08.06.2011 16:10, schrieb Jan Kiszka: >> This helps reducing our build-time checks for feature support in the >> available Linux kernel headers. And it helps users that do not have >> sufficiently recent headers installed on their build machine. >> >> Co

Re: [Qemu-devel] struct TimerState

2011-06-22 Thread Andreas Färber
Am 21.06.2011 um 12:24 schrieb Nilay Vaish: Is there a way to know how many cycles the virtual machine has been running for? No. QEMU's emulation is not cycle-accurate. The instruction counter (icount) gives you an indication of how much workload the guest has processed but no indication h

[Qemu-devel] buildbot failure in qemu on default_ppc

2011-06-22 Thread qemu
The Buildbot has detected a new failure on builder default_ppc while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/69 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: qemu-ppc.opensuse.org Build Reason:

[Qemu-devel] IO errors in guest caused by LTP dio test

2011-06-22 Thread Andi Kleen
Running LTP testcases/kernel/io/direct_io/test_dma_thread_diotest7 causes IO errors in the guest. There are no IO errors on the host. Kernel Linux 3.0.0-rc* Using a standard emulated IDE -hda image. I tried a few qemu versions, it happens at least with the one in FC14 and with 0.14. qemu master

[Qemu-devel] [BREAKAGE] KVM pulls break MinGW builds

2011-06-22 Thread Roy Tam
The pulls makes KVM enabled by default, which is not available in MinGW(Win32) environment. Even through I put --disable-kvm switch in ./configure, I still can't get QEMU compiled: (...) CCi386-softmmu/pc_piix.o CCi386-softmmu/kvmclock.o In file included from C:/msys/home/User/qemu/hw/

[Qemu-devel] [PATCH trivial] Fix comment typos in hw/armv7m.c

2011-06-22 Thread Matthew Fernandez
Fix a couple of typos in comments. Signed-off-by: Matthew Fernandez This patch doesn't touch any code and should (hopefully) not be controversial. There doesn't seem to be a maintainer for this file, but changes are trivial. diff --git a/hw/armv7m.c b/hw/armv7m.c index 72d010a..83f3393 100

Re: [Qemu-devel] [PATCH trivial] Fix comment typos in hw/armv7m.c

2011-06-22 Thread Stefan Weil
Am 23.06.2011 02:59, schrieb Matthew Fernandez: Fix a couple of typos in comments. Signed-off-by: Matthew Fernandez This patch doesn't touch any code and should (hopefully) not be controversial. There doesn't seem to be a maintainer for this file, but changes are trivial. diff --git a/hw/

Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers

2011-06-22 Thread Stefan Weil
Am 22.06.2011 23:37, schrieb Jan Kiszka: On 2011-06-22 22:51, Stefan Weil wrote: If not, kvm="yes" should be restricted to platforms with kvm support. Otherwise, QEMU builds will fail very early: ERROR: Host kernel lacks signalfd() support, but KVM depends on it when the IO thread is disabled.

Re: [Qemu-devel] buildbot failure in qemu on default_ppc

2011-06-22 Thread Stefan Hajnoczi
On Thu, Jun 23, 2011 at 12:27 AM, wrote: > The Buildbot has detected a new failure on builder default_ppc while building > qemu. > Full details are available at: >  http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/69 http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/6