Re: [Qemu-devel] [PATCH 00/11] cpu model bug fixes and definition corrections (v2)

2011-06-09 Thread Markus Armbruster
Jan Kiszka writes: [...] >> Something else I may have missed? >> > > Nothing critical, I'm just hoping someone finds the time to fix > sysconfigs loading when starting qemu from a build directory. :) There's nice to have, important, critical, and really annoying. This one's really annoying.

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-09 Thread Paolo Bonzini
On 06/09/2011 01:28 AM, Rusty Russell wrote: > after some preliminary discussion on the QEMU mailing list, I present a > draft specification for a virtio-based SCSI host (controller, HBA, you > name it). OK, I'm impressed. This is very well written and it doesn't make any of the obvious mis

Re: [Qemu-devel] assigned EHCI USB headset not working

2011-06-09 Thread Jan Kiszka
On 2011-06-09 09:08, André Weidemann wrote: > Hi Jan, > > On 09.06.2011 08:53, Jan Kiszka wrote: >> On 2011-06-09 08:19, André Weidemann wrote: >>> Hi Gerd, >>> >>> On 08.06.2011 14:49, Gerd Hoffmann wrote: Hi, > The sound device shows up under Windows7 and drivers are installed

[Qemu-devel] [PATCH] pci: Update pci_regs header

2011-06-09 Thread Jan Kiszka
From: Jan Kiszka Pulls in latest version from kernel 3.0-rc2. Some changes around AER now require local defines as QEMU accesses the error source identification register via sub-words. CC: Isaku Yamahata Signed-off-by: Jan Kiszka --- I don't think the #define requirements of pcie_aer are ups

[Qemu-devel] [PATCH] msix: Use replace local defines with pci_regs versions

2011-06-09 Thread Jan Kiszka
From: Jan Kiszka This also cleans up an open-coded 64-bit message address readout. Signed-off-by: Jan Kiszka --- Depends on the pci_regs.h update. hw/msix.c | 40 +++- 1 files changed, 15 insertions(+), 25 deletions(-) diff --git a/hw/msix.c b/hw/msix.c

Re: [Qemu-devel] [PATCH v2][ 05/21] qapi: add qapi-types.py code generator

2011-06-09 Thread Markus Armbruster
Anthony Liguori writes: > On 06/03/2011 05:33 PM, Michael Roth wrote: >> This is the code generator for qapi types. It will generation the >> following files: >> >>$(prefix)qapi-types.h - C types corresponding to types defined in >>the schema you pass in >>$(pr

Re: [Qemu-devel] [PATCH 2/2] qemu-options.hx: Update virtfs command documentation

2011-06-09 Thread Markus Armbruster
"Aneesh Kumar K.V" writes: > Clarify the virtfs option better > > Signed-off-by: Aneesh Kumar K.V > --- > qemu-options.hx | 116 > ++- > 1 files changed, 72 insertions(+), 44 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx >

Re: [Qemu-devel] [PATCH 01/12] VMDK: Introduced VmdkExtent

2011-06-09 Thread Stefan Hajnoczi
On Sat, Jun 04, 2011 at 08:40:22AM +0800, Fam Zheng wrote: > fail: > -qemu_free(s->l1_backup_table); > -qemu_free(s->l1_table); > -qemu_free(s->l2_cache); > +if(s->extents) { > +qemu_free(s->extents[0].l1_backup_table); > +qemu_free(s->extents[0].l1_table); > +

Re: [Qemu-devel] [RFC v4 09/12] fdc: Implement ISA set_state() callback

2011-06-09 Thread Gerd Hoffmann
Hi, +VMSTATE_ISA_DEVICE_V(busdev, FDCtrlISABus, 3), Where is the patch adding this? cheers, Gerd

Re: [Qemu-devel] [PULL] libcacard libtoolized + usb-ccid fix

2011-06-09 Thread Alon Levy
Ping? On Tue, May 31, 2011 at 07:42:20PM +0300, Alon Levy wrote: > Hi, > > This pull request includes the libcacard.la library target and a memory leak > fix by Markus. Please pull. > > The following changes since commit b1d7d2b93a1d6b2d2848b616cc35acdf521c923c: > > Merge remote-tracking bran

Re: [Qemu-devel] [RFC v4 09/12] fdc: Implement ISA set_state() callback

2011-06-09 Thread Andreas Färber
Am 09.06.2011 um 09:56 schrieb Gerd Hoffmann: +VMSTATE_ISA_DEVICE_V(busdev, FDCtrlISABus, 3), Where is the patch adding this? v4 03/12: http://patchwork.ozlabs.org/patch/99537/ Note that there's no VMSTATE_PCI_DEVICE_V(), but I found the _V very convenient here. Andreas

Re: [Qemu-devel] [PATCH] [qemu-iotests] Update filter for default cluster size

2011-06-09 Thread Christoph Hellwig
Thanks, applied. And sorry, I did it before reading stefan's review, so the tag is missing in the commit.

Re: [Qemu-devel] vmdk fails qemu-iotest 019

2011-06-09 Thread Stefan Hajnoczi
On Wed, Jun 8, 2011 at 3:55 PM, Kevin Wolf wrote: > Am 08.06.2011 16:17, schrieb Fam Zheng: >> Oh, you're right, and I think there is a patch of mine related to the fail: >> >> "[PATCH 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster" >> >> Can you test if this fixes it? > > Thank

Re: [Qemu-devel] [PATCH] [qemu-iotests] Update filter for default cluster size

2011-06-09 Thread Andreas Färber
Am 09.06.2011 um 11:33 schrieb Christoph Hellwig: Thanks, applied. And sorry, I did it before reading stefan's review, so the tag is missing in the commit. git commit --amend # if the last one or git rebase -i origin/master # with r[eword] :) Andreas

Re: [Qemu-devel] [PATCH] doc: Minor typo fix.

2011-06-09 Thread Stefan Hajnoczi
On Thu, Jun 09, 2011 at 07:50:43AM +1000, Brad Hards wrote: > Thanks to agraf_, stefanha and Snader_LB for their IRC assistance. > > Thanks to Markus Armbruster and Alexander Graf (again) for their > assistance with the second version of this patch. No patch is too > simple to test... > > Signed-

Re: [Qemu-devel] [PATCH] [qemu-iotests] Update filter for default cluster size

2011-06-09 Thread Christoph Hellwig
On Thu, Jun 09, 2011 at 11:47:24AM +0200, Andreas F?rber wrote: > Am 09.06.2011 um 11:33 schrieb Christoph Hellwig: > >> Thanks, applied. >> >> And sorry, I did it before reading stefan's review, so the tag is missing >> in >> the commit. > > > git commit --amend # if the last one or > git rebase

[Qemu-devel] stale savannah git repo (was: Re: KVM call agenda for April 05)

2011-06-09 Thread Peter Maydell
On 5 April 2011 09:29, Alexander Graf wrote: > On 05.04.2011, at 08:01, Brad Hards wrote: >> It isn't even easy to figure out what trees there are (apart from the >> main one) and a google search for "qemu git" produces some misleading >> links to savannah and places other than git://git.qemu.org/

Re: [Qemu-devel] [PATCH 01/12] VMDK: Introduced VmdkExtent

2011-06-09 Thread Fam Zheng
On Thu, Jun 9, 2011 at 3:58 PM, Stefan Hajnoczi wrote: > On Sat, Jun 04, 2011 at 08:40:22AM +0800, Fam Zheng wrote: >>   fail: >> -    qemu_free(s->l1_backup_table); >> -    qemu_free(s->l1_table); >> -    qemu_free(s->l2_cache); >> +    if(s->extents) { >> +        qemu_free(s->extents[0].l1_back

Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback

2011-06-09 Thread Gerd Hoffmann
Hi, +const VMStateDescription vmstate_isa_device = { +.name = "ISADevice", +.version_id = 1, +.minimum_version_id = 1, +.fields = (VMStateField []) { +VMSTATE_BOOL(enabled, ISADevice), +VMSTATE_END_OF_LIST() +} +}; That alone isn't enougth. You also need

[Qemu-devel] [PATCH] Changelog: Add explanatory note that this file is no longer updated

2011-06-09 Thread Peter Maydell
Add an explanatory note to the top of Changelog pointing at the wiki and git history for changelogs for more recent releases. Signed-off-by: Peter Maydell --- Changelog |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/Changelog b/Changelog index 1c41e14..28a69af 1006

[Qemu-devel] [PATCH v2 3/6] Do constant folding for basic arithmetic operations.

2011-06-09 Thread Kirill Batuzov
Perform actual constant folding for ADD, SUB and MUL operations. Signed-off-by: Kirill Batuzov --- tcg/optimize.c | 156 1 files changed, 156 insertions(+), 0 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 7996798..29da6

[Qemu-devel] [PATCH v2 5/6] Do constant folding for shift operations.

2011-06-09 Thread Kirill Batuzov
Perform constant forlding for SHR, SHL, SAR, ROTR, ROTL operations. Signed-off-by: Kirill Batuzov --- tcg/optimize.c | 86 1 files changed, 86 insertions(+), 0 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 0bd8c78..653

[Qemu-devel] [PATCH v2 2/6] Add copy and constant propagation.

2011-06-09 Thread Kirill Batuzov
Make tcg_constant_folding do copy and constant propagation. It is a preparational work before actual constant folding. Signed-off-by: Kirill Batuzov --- tcg/optimize.c | 161 1 files changed, 161 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH v2 4/6] Do constant folding for boolean operations.

2011-06-09 Thread Kirill Batuzov
Perform constant folding for AND, OR, XOR operations. Signed-off-by: Kirill Batuzov --- tcg/optimize.c | 56 1 files changed, 56 insertions(+), 0 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 29da6fa..0bd8c78 100644 --

Re: [Qemu-devel] [PATCH] pci: Update pci_regs header

2011-06-09 Thread Isaku Yamahata
pcie_aer.c change looks good. Thanks. On Thu, Jun 09, 2011 at 09:18:30AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Pulls in latest version from kernel 3.0-rc2. > > Some changes around AER now require local defines as QEMU accesses the > error source identification register via sub-words.

[Qemu-devel] [PATCH v2 6/6] Do constant folding for unary operations.

2011-06-09 Thread Kirill Batuzov
Perform constant folding for NOT and EXT{8,16,32}{S,U} operations. Signed-off-by: Kirill Batuzov --- tcg/optimize.c | 83 1 files changed, 83 insertions(+), 0 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 653f399..2cdc

Re: [Qemu-devel] [PATCH 01/12] VMDK: Introduced VmdkExtent

2011-06-09 Thread Stefan Hajnoczi
On Thu, Jun 9, 2011 at 11:20 AM, Fam Zheng wrote: > On Thu, Jun 9, 2011 at 3:58 PM, Stefan Hajnoczi wrote: >> On Sat, Jun 04, 2011 at 08:40:22AM +0800, Fam Zheng wrote: >>>   fail: >>> -    qemu_free(s->l1_backup_table); >>> -    qemu_free(s->l1_table); >>> -    qemu_free(s->l2_cache); >>> +    i

[Qemu-devel] [PATCH v2 0/6] Implement constant folding and copy propagation in TCG

2011-06-09 Thread Kirill Batuzov
This series implements some basic machine-independent optimizations. They simplify code and allow liveness analysis do it's work better. Suppose we have following ARM code: movwr12, #0xb6db movtr12, #0xdb6d In TCG before optimizations we'll have: movi_i32 tmp8,$0xb6db mov_i32 r12,t

[Qemu-devel] [PATCH 0/2] iothread improvements for Mac OS X

2011-06-09 Thread Paolo Bonzini
These are two old patches that I never submitted because I didn't really think they were useful except as cleanups. Recently, however, Alex Graf mentioned some problems that Mac OS X has with iothread, and they sounded to me like they were related to these patches. And quite surprisingly, both of

[Qemu-devel] [PATCH 1/2] iothread: replace fair_mutex with a condition variable

2011-06-09 Thread Paolo Bonzini
This conveys the intention better, and scales to more than >1 threads contending the mutex with the iothread (as long as all of them have a "quiescent point" like the TCG thread has). Also, on Mac OS X the fair_mutex somehow didn't work as intended and deadlocked. Signed-off-by: Paolo Bonzini Te

[Qemu-devel] [PATCH 2/2] qemu-timer: change unix timer to dynticks

2011-06-09 Thread Paolo Bonzini
A timer that wakes up every millisecond puts a lot of stress on the iothread. The large amount of IPIs causes very high context switch activity, making emulation slow and the UI unusable. This is by the way the same reason why the Windows timers were switched to dynticks. Signed-off-by: Paolo Bo

[Qemu-devel] [PATCH v2 1/6] Add TCG optimizations stub

2011-06-09 Thread Kirill Batuzov
Added file tcg/optimize.c to hold TCG optimizations. Function tcg_optimize is called from tcg_gen_code_common. It calls other functions performing specific optimizations. Stub for constant folding was added. Signed-off-by: Kirill Batuzov --- Makefile.target |2 +- tcg/optimize.c | 91

Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback

2011-06-09 Thread Andreas Färber
Hi, Am 09.06.2011 um 12:39 schrieb Gerd Hoffmann: +const VMStateDescription vmstate_isa_device = { +.name = "ISADevice", +.version_id = 1, +.minimum_version_id = 1, +.fields = (VMStateField []) { +VMSTATE_BOOL(enabled, ISADevice), +VMSTATE_END_OF_LIST() +} +}

Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback

2011-06-09 Thread Gerd Hoffmann
Hi, Btw is 1 correct here or should an initial version be 0? I think for sub-structs it doesn't matter at all, only for top-level vmstates. I get the feeling that doing all this in the pc87312 emulation is easier as it needs to have this logic anyway for config register writes and you ca

Re: [Qemu-devel] [PATCH] sigfd: use pthread_sigmask

2011-06-09 Thread Andreas Färber
Am 09.06.2011 um 00:55 schrieb Alexander Graf: Qemu uses signalfd to figure out, if a signal occured without the need to actually receive the signal. Instead, it can read from the fd to receive its news. Now, we obviously don't always have signalfd around. Especially not on non-Linux systems

Re: [Qemu-devel] [PULL] spice patch queue

2011-06-09 Thread Anthony Liguori
On 06/06/2011 07:49 AM, Gerd Hoffmann wrote: Hi, Resending pull request for the spice patch queue. Almost nothing changed, the queue gained one additional fix from Alon and was rebased to latest master. Pulled. Thanks. Regards, Anthony Liguori please pull, Gerd The following chan

Re: [Qemu-devel] [PULL 00/12] Block patches

2011-06-09 Thread Anthony Liguori
On 06/08/2011 08:48 AM, Kevin Wolf wrote: The following changes since commit a90d4690074526f54ad0851fce19fa6783f06803: Add an isa device for SGA (2011-06-07 13:52:30 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled. Thanks. Regards, An

Re: [Qemu-devel] [PULL] collection of small VirtFS patches.

2011-06-09 Thread Anthony Liguori
On 06/01/2011 12:33 PM, Venkateswararao Jujjuri wrote: The following changes since commit 578c7b2ca8ee9e97fa8693b1a83d517e8e3f962e: Juha Riihim?ki (1): audio: fix integer overflow expression are available in the git repository at: git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony Pulled.

Re: [Qemu-devel] [PULL 0/6] Trivial patches for May 30 to June 8 2011

2011-06-09 Thread Anthony Liguori
On 06/08/2011 03:24 AM, Stefan Hajnoczi wrote: The following changes since commit a90d4690074526f54ad0851fce19fa6783f06803: Add an isa device for SGA (2011-06-07 13:52:30 -0500) are available in the git repository at: git://repo.or.cz/qemu/stefanha.git trivial-patches Pulled. Thanks.

Re: [Qemu-devel] [PULL 0/5]: Monitor queue

2011-06-09 Thread Anthony Liguori
On 06/01/2011 10:54 AM, Luiz Capitulino wrote: Anthony, The following patches have been sent to the list and look good to me. I've also tested them. The changes (since 578c7b2ca8ee9e97fa8693b1a83d517e8e3f962e) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.g

Re: [Qemu-devel] [PULL] spice patch queue

2011-06-09 Thread Anthony Liguori
On 06/06/2011 07:49 AM, Gerd Hoffmann wrote: Hi, Resending pull request for the spice patch queue. Almost nothing changed, the queue gained one additional fix from Alon and was rebased to latest master. Pulled. Thanks. Regards, Anthony Liguori please pull, Gerd The following chan

Re: [Qemu-devel] [PATCH v2] savevm: fix corruption in vmstate_subsection_load().

2011-06-09 Thread Kevin Wolf
Am 24.01.2011 10:30, schrieb Yoshiaki Tamura: > Although it's rare to happen in live migration, when the head of a > byte stream contains 0x05 which is the marker of subsection, the > loader gets corrupted because vmstate_subsection_load() continues even > the device doesn't require it. This patch

[Qemu-devel] [PATCH 0/3] IDE and live migration fun

2011-06-09 Thread Kevin Wolf
Patch 1 describes the real problem that I was going to solve. While fixing this, I stumbled across some more migration problems that are included in this series. Some refactoring is still left to do after this, but I'd prefer to keep this series with the hard stuff short. This is the test case tha

Re: [Qemu-devel] [PATCH v2] savevm: fix corruption in vmstate_subsection_load().

2011-06-09 Thread Paolo Bonzini
On 06/09/2011 02:48 PM, Kevin Wolf wrote: This means that subsections are silently ignored if the old version didn't have any subsection for the device. Wasn't it a fundamental point of the design of subsections that this would fail? Unfortunately you cannot have it both ways because the migrat

[Qemu-devel] [PATCH 1/3] ide: Split error status from status register

2011-06-09 Thread Kevin Wolf
When adding the werror=stop mode, some flags were added to s->status which are used to determine what kind of operation should be restarted when the VM is continued. Unfortunately, it turns out that s->status is in fact a device register and as such is visible to the guest (some of the abused bits

[Qemu-devel] [PATCH 2/3] ide: Fix ide_drive_pio_state_needed()

2011-06-09 Thread Kevin Wolf
When a failed PIO request caused the VM to stop, we still need to transfer the PIO state even though DRQ=0 at this point. Signed-off-by: Kevin Wolf --- hw/ide/core.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index da250ac..e5def8b 10

Re: [Qemu-devel] [PATCH 1/3] ide: Split error status from status register

2011-06-09 Thread Paolo Bonzini
On 06/09/2011 03:15 PM, Kevin Wolf wrote: +/* This function accesses bm->bus->error_status which is loaded only after + * BMDMA itself. This is why the function is called from ide_pci_post_load + * instead of being registered with VMState where it would run too early. */ +static int ide_bmdma_pos

[Qemu-devel] [PATCH 3/3] ide: Add forgotten VMSTATE_END_OF_LIST in subsection

2011-06-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- hw/ide/core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index e5def8b..399b74c 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1864,6 +1864,7 @@ const VMStateDescription vmstate_ide_atapi_gesn_state = {

Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-09 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > > Peter Maydell writes: > >> If you have a model with more than one USB bus, and you >> create a USB device on the command line without specifying >> which bus to plug it into, QEMU will choose a different bus >> depending on whether you use the legacy "-usbdevic

Re: [Qemu-devel] [PATCH 1/3] ide: Split error status from status register

2011-06-09 Thread Kevin Wolf
Am 09.06.2011 15:27, schrieb Paolo Bonzini: > On 06/09/2011 03:15 PM, Kevin Wolf wrote: >> +/* This function accesses bm->bus->error_status which is loaded only after >> + * BMDMA itself. This is why the function is called from ide_pci_post_load >> + * instead of being registered with VMState where

Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback

2011-06-09 Thread Andreas Färber
Hi, Am 09.06.2011 um 14:23 schrieb Gerd Hoffmann: I get the feeling that doing all this in the pc87312 emulation is easier as it needs to have this logic anyway for config register writes and you can probably reuse the code for loadvm pre- and postprocessing. Well, I wasn't looking for the ea

Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-09 Thread Gerd Hoffmann
Hi, Gave up after resending it one or two times, the forgot about it, wasn't *that* important to me. Still got a pointer to the patch? Not in my git tree any more. Google found me this instead: http://permalink.gmane.org/gmane.comp.emulators.qemu/74360 Looks like I'm not the only one wh

Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback

2011-06-09 Thread Gerd Hoffmann
Hi, In that case it won't work (out-of-sync) and we shouldn't introduce VMState for pc87312 at all imo. In theory we'd probably need a pc87312-owned bus to put the devices on but then I don't see how to reuse the existing isa devices. Oh, that should actually work just fine and is maybe the

Re: [Qemu-devel] [PATCH] pci: Update pci_regs header

2011-06-09 Thread Michael S. Tsirkin
On Thu, Jun 09, 2011 at 09:18:30AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Pulls in latest version from kernel 3.0-rc2. > > Some changes around AER now require local defines as QEMU accesses the > error source identification register via sub-words. > > CC: Isaku Yamahata > Signed-off-b

Re: [Qemu-devel] [PATCH 1/3] ide: Split error status from status register

2011-06-09 Thread Paolo Bonzini
On 06/09/2011 04:07 PM, Kevin Wolf wrote: I think you're right. We could enable it unconditionally (and change the bm->status line from = to |=), but anyway it's redundant if the subsections are present, so it wouldn't make a difference. Yes, I was thinking the same. Paolo

Re: [Qemu-devel] [PATCH] msix: Use replace local defines with pci_regs versions

2011-06-09 Thread Michael S. Tsirkin
On Thu, Jun 09, 2011 at 09:39:56AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > This also cleans up an open-coded 64-bit message address readout. > > Signed-off-by: Jan Kiszka Thanks, applied. > --- > > Depends on the pci_regs.h update. > > hw/msix.c | 40 +++--

Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-09 Thread Peter Maydell
On 9 June 2011 14:59, Markus Armbruster wrote: > The fact that we duplicate qtree information in a separate list "busses" > either means we've been too lazy to garbage collect busses, or we've > failed to make working with the qtree as easy as it should be. If you get rid of busses you need to up

Re: [Qemu-devel] [PATCH v4 01/12] qdev: Add support for property type bool

2011-06-09 Thread Markus Armbruster
Andreas Färber writes: > VMState supports the type bool but qdev instead supports bit, backed by > uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev_prop_set_bool(). > > Since, e.g., enabled=on does not look nice, parse/print "yes" and "no". The difference between bool and bit properties

Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback

2011-06-09 Thread Markus Armbruster
Andreas Färber writes: > To allow enabling/disabling present ISA devices without hotplug, > keep track of state and add a helper to avoid enabling twice. > Since the properties to be configured are defined at device level, > delegate the actual work to a callback function. > > If no callback is s

Re: [Qemu-devel] [PATCH v3 00/39] pci: initialize ids in pci common code

2011-06-09 Thread Michael S. Tsirkin
On Thu, Jun 09, 2011 at 10:56:52AM +0900, Isaku Yamahata wrote: > Ping? I put this on my tree, it will get in with the next merge, hope to send that next week. -- MST

Re: [Qemu-devel] [RFC v4 05/12] isa: Allow to un-associate an IRQ

2011-06-09 Thread Markus Armbruster
Andreas Färber writes: > Signed-off-by: Andreas Färber > --- > hw/isa-bus.c | 14 ++ > hw/isa.h |1 + > 2 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/hw/isa-bus.c b/hw/isa-bus.c > index 1f64673..6ac3e61 100644 > --- a/hw/isa-bus.c > +++ b/hw/isa-bus.c

Re: [Qemu-devel] [PATCH] sigfd: use pthread_sigmask

2011-06-09 Thread Andreas Färber
Am 09.06.2011 um 14:36 schrieb Andreas Färber: Am 09.06.2011 um 00:55 schrieb Alexander Graf: Qemu uses signalfd to figure out, if a signal occured without the need to actually receive the signal. Instead, it can read from the fd to receive its news. Now, we obviously don't always have si

Re: [Qemu-devel] [RFC v4 04/12] isa: Allow to un-assign I/O ports

2011-06-09 Thread Markus Armbruster
Andreas Färber writes: > Signed-off-by: Andreas Färber > --- > hw/isa-bus.c | 14 ++ > hw/isa.h |1 + > 2 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/hw/isa-bus.c b/hw/isa-bus.c > index d258932..1f64673 100644 > --- a/hw/isa-bus.c > +++ b/hw/isa-bus.c

Re: [Qemu-devel] [PATCH v2][ 05/21] qapi: add qapi-types.py code generator

2011-06-09 Thread Luiz Capitulino
On Fri, 3 Jun 2011 17:33:03 -0500 Michael Roth wrote: > This is the code generator for qapi types. It will generation the > following files: > > $(prefix)qapi-types.h - C types corresponding to types defined in > the schema you pass in > $(prefix)qapi-types.c - Cle

Re: [Qemu-devel] [PATCH v2][ 09/21] qapi: add qapi-visit-core.h

2011-06-09 Thread Luiz Capitulino
On Fri, 3 Jun 2011 17:33:07 -0500 Michael Roth wrote: > Base definitions/includes for Visiter interface used by generated > visiter/marshalling code. > > Signed-off-by: Michael Roth > --- > qapi/qapi-visit-core.h | 187 > > 1 files changed, 1

Re: [Qemu-devel] assigned EHCI USB headset not working

2011-06-09 Thread Jan Kiszka
On 2011-06-09 17:13, malc wrote: > On Thu, 9 Jun 2011, Jan Kiszka wrote: > >> On 2011-06-09 09:08, Andr? Weidemann wrote: >>> Hi Jan, >>> >>> On 09.06.2011 08:53, Jan Kiszka wrote: On 2011-06-09 08:19, Andr? Weidemann wrote: > Hi Gerd, > > On 08.06.2011 14:49, Gerd Hoffmann wrote:

Re: [Qemu-devel] [RFC v4 05/12] isa: Allow to un-associate an IRQ

2011-06-09 Thread Markus Armbruster
Markus Armbruster writes: > Andreas Färber writes: > >> Signed-off-by: Andreas Färber >> --- >> hw/isa-bus.c | 14 ++ >> hw/isa.h |1 + >> 2 files changed, 15 insertions(+), 0 deletions(-) >> >> diff --git a/hw/isa-bus.c b/hw/isa-bus.c >> index 1f64673..6ac3e61 100644 >>

Re: [Qemu-devel] [RFC v4 07/12] serial: Implement ISA set_state() callback

2011-06-09 Thread Markus Armbruster
Andreas Färber writes: > Incorporate ISA VMState. Add "enabled" property. Could you explain why you need to stick VMSTATE_ISA_DEVICE_V() into vmstate_isa_serial, but not for the other devices? > > Signed-off-by: Andreas Färber > --- > hw/serial.c | 30 +- > 1 fil

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Luiz Capitulino
On Fri, 3 Jun 2011 17:33:08 -0500 Michael Roth wrote: > A type of Visiter class that is used to walk a qobject's > structure and assign each entry to the corresponding native C type. > Command marshaling function will use this to pull out QMP command > parameters recieved over the wire and pass

Re: [Qemu-devel] assigned EHCI USB headset not working

2011-06-09 Thread malc
On Thu, 9 Jun 2011, Jan Kiszka wrote: > On 2011-06-09 09:08, Andr? Weidemann wrote: > > Hi Jan, > > > > On 09.06.2011 08:53, Jan Kiszka wrote: > >> On 2011-06-09 08:19, Andr? Weidemann wrote: > >>> Hi Gerd, > >>> > >>> On 08.06.2011 14:49, Gerd Hoffmann wrote: > Hi, > > > The sound

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-09 Thread Marc-Antoine Perennou
On 4 June 2011 00:54, malc wrote: > On Sat, 4 Jun 2011, Aurelien Jarno wrote: > >> On Sat, Jun 04, 2011 at 01:57:23AM +0400, malc wrote: >> > On Fri, 3 Jun 2011, Aurelien Jarno wrote: >> > >> > > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: >> > > > pulse/simple.h does no

Re: [Qemu-devel] [PATCH v2][ 05/21] qapi: add qapi-types.py code generator

2011-06-09 Thread Michael Roth
On 06/09/2011 10:05 AM, Luiz Capitulino wrote: On Fri, 3 Jun 2011 17:33:03 -0500 Michael Roth wrote: This is the code generator for qapi types. It will generation the following files: $(prefix)qapi-types.h - C types corresponding to types defined in the schema y

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Michael Roth
On 06/09/2011 10:30 AM, Luiz Capitulino wrote: On Fri, 3 Jun 2011 17:33:08 -0500 Michael Roth wrote: A type of Visiter class that is used to walk a qobject's structure and assign each entry to the corresponding native C type. Command marshaling function will use this to pull out QMP command p

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-06-09 Thread Jagane Sundar
Hello Stefan, Can you expand on this some more? I have similar concerns for Livebackup. At the beginning of your paragraph, did you mean 'asynchronous I/O emulation' instead of 'synchronous I/O emulation'? Also, I don't understand the 'stack' construct that you refer to. When you say 'push a

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Luiz Capitulino
On Thu, 09 Jun 2011 10:41:53 -0500 Michael Roth wrote: > On 06/09/2011 10:30 AM, Luiz Capitulino wrote: > > On Fri, 3 Jun 2011 17:33:08 -0500 > > Michael Roth wrote: > > > >> A type of Visiter class that is used to walk a qobject's > >> structure and assign each entry to the corresponding nativ

Re: [Qemu-devel] assigned EHCI USB headset not working

2011-06-09 Thread malc
On Thu, 9 Jun 2011, Jan Kiszka wrote: > On 2011-06-09 17:13, malc wrote: > > On Thu, 9 Jun 2011, Jan Kiszka wrote: > > [..snip..] > > Sound output over (at least) ALSA is not smoothly working in polled > mode. It's similar to [1], which is yet unsolved. > > Jan > > [1] http://thread.gmane.or

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Peter Maydell
On 3 June 2011 23:33, Michael Roth wrote: > A type of Visiter class [randomly noted against this patch because this is where I happened to notice it...] Should be "Visitor" throughout (and in other patches), please? -- PMM

Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback

2011-06-09 Thread Markus Armbruster
Andreas Färber writes: > Hi, > > Am 09.06.2011 um 14:23 schrieb Gerd Hoffmann: > I get the feeling that doing all this in the pc87312 emulation is easier as it needs to have this logic anyway for config register writes and you can probably reuse the code for loadvm pre- and po

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Michael Roth
On 06/09/2011 11:26 AM, Peter Maydell wrote: On 3 June 2011 23:33, Michael Roth wrote: A type of Visiter class [randomly noted against this patch because this is where I happened to notice it...] Should be "Visitor" throughout (and in other patches), please? -- PMM Stefan pointed that out

Re: [Qemu-devel] [PATCH RFC 0/3] basic support for composing sysbus devices

2011-06-09 Thread Markus Armbruster
Jan Kiszka writes: > On 2011-06-08 13:33, Peter Maydell wrote: >> At the moment you can't really implement one sysbus device by saying >> that it's composed of a set of other sysbus devices. This patch adds >> new functions sysbus_pass_mmio() and sysbus_pass_one_irq() which >> allow a sysbus devi

Re: [Qemu-devel] [RFC v4 07/12] serial: Implement ISA set_state() callback

2011-06-09 Thread Andreas Färber
Am 09.06.2011 um 17:35 schrieb Markus Armbruster: Andreas Färber writes: Incorporate ISA VMState. Add "enabled" property. Could you explain why you need to stick VMSTATE_ISA_DEVICE_V() into vmstate_isa_serial, but not for the other devices? I stuck it in all affected devices that have VMS

[Qemu-devel] [PATCH] vmstate: Add unmigratable flag

2011-06-09 Thread Jan Kiszka
A first step towards getting rid of register_device_unmigratable (ivshmem and lacking vmstate support in virtio are blocking this): Allow to register an unmigratable vmstate via qdev, i.e. tag a device declaratively. Signed-off-by: Jan Kiszka --- hw/hw.h |1 + savevm.c |1 + 2 files ch

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Michael Roth
On 06/09/2011 10:55 AM, Luiz Capitulino wrote: On Thu, 09 Jun 2011 10:41:53 -0500 Michael Roth wrote: On 06/09/2011 10:30 AM, Luiz Capitulino wrote: On Fri, 3 Jun 2011 17:33:08 -0500 Michael Roth wrote: A type of Visiter class that is used to walk a qobject's structure and assign each en

Re: [Qemu-devel] [PATCH RFC 0/3] basic support for composing sysbus devices

2011-06-09 Thread Jan Kiszka
On 2011-06-09 18:40, Markus Armbruster wrote: > Jan Kiszka writes: > >> On 2011-06-08 13:33, Peter Maydell wrote: >>> At the moment you can't really implement one sysbus device by saying >>> that it's composed of a set of other sysbus devices. This patch adds >>> new functions sysbus_pass_mmio()

Re: [Qemu-devel] assigned EHCI USB headset not working

2011-06-09 Thread Jan Kiszka
On 2011-06-09 18:09, malc wrote: > On Thu, 9 Jun 2011, Jan Kiszka wrote: > >> On 2011-06-09 17:13, malc wrote: >>> On Thu, 9 Jun 2011, Jan Kiszka wrote: >>> > > [..snip..] > >> >> Sound output over (at least) ALSA is not smoothly working in polled >> mode. It's similar to [1], which is yet unsol

Re: [Qemu-devel] [PATCH 11/12] kvm: x86: Pass KVMState to kvm_arch_get_supported_cpuid

2011-06-09 Thread Eduardo Habkost
On Wed, Jun 08, 2011 at 04:11:05PM +0200, Jan Kiszka wrote: > kvm_arch_get_supported_cpuid checks for global cpuid restrictions, it > does not require any CPUState reference. Changing its interface allows > to call it before any VCPU is initialized. I'm wondering if it wouldn't be simpler to keep

Re: [Qemu-devel] [PATCH 11/12] kvm: x86: Pass KVMState to kvm_arch_get_supported_cpuid

2011-06-09 Thread Jan Kiszka
On 2011-06-09 19:33, Eduardo Habkost wrote: > On Wed, Jun 08, 2011 at 04:11:05PM +0200, Jan Kiszka wrote: >> kvm_arch_get_supported_cpuid checks for global cpuid restrictions, it >> does not require any CPUState reference. Changing its interface allows >> to call it before any VCPU is initialized.

[Qemu-devel] [PATCH] coroutine: Implement coroutines using gthread

2011-06-09 Thread Aneesh Kumar K.V
On platforms that doesn't support makecontext use gthread based coroutine implementation. Signed-off-by: Aneesh Kumar K.V --- NOTE: Tested on linux with force compliation of coroutine-gthread.c Makefile.objs |5 ++ configure | 18 + coroutine-gthread.c | 172

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-09 Thread Andreas Färber
Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou: On 4 June 2011 00:54, malc wrote: On Sat, 4 Jun 2011, Aurelien Jarno wrote: On Sat, Jun 04, 2011 at 01:57:23AM +0400, malc wrote: On Fri, 3 Jun 2011, Aurelien Jarno wrote: On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou

Re: [Qemu-devel] [PATCH v2][ 11/21] qapi: add QMP output visiter

2011-06-09 Thread Luiz Capitulino
On Fri, 3 Jun 2011 17:33:09 -0500 Michael Roth wrote: > Type of Visiter class that serves as the inverse of the input visiter: > it takes a series of native C types and uses their values to construct a > corresponding QObject. The command marshaling/dispatcher functions will > use this to conver

Re: [Qemu-devel] [PATCH 11/12] kvm: x86: Pass KVMState to kvm_arch_get_supported_cpuid

2011-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2011 at 07:41:03PM +0200, Jan Kiszka wrote: > > I'm wondering if it wouldn't be simpler to keep the existing interface > > but just initialize CPUState->kvm_state earlier (today it is initialized > > only on kvm_init_vcpu(), although the kvm_state global is initialized > > much ear

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Anthony Liguori
On 06/09/2011 11:41 AM, Michael Roth wrote: On 06/09/2011 11:26 AM, Peter Maydell wrote: On 3 June 2011 23:33, Michael Roth wrote: A type of Visiter class [randomly noted against this patch because this is where I happened to notice it...] Should be "Visitor" throughout (and in other patches

Re: [Qemu-devel] [PATCH v2][ 09/21] qapi: add qapi-visit-core.h

2011-06-09 Thread Anthony Liguori
On 06/09/2011 10:14 AM, Luiz Capitulino wrote: On Fri, 3 Jun 2011 17:33:07 -0500 Michael Roth wrote: Base definitions/includes for Visiter interface used by generated visiter/marshalling code. Signed-off-by: Michael Roth --- qapi/qapi-visit-core.h | 187 +++

Re: [Qemu-devel] [PATCH] vmstate: Add unmigratable flag

2011-06-09 Thread Markus Armbruster
Jan Kiszka writes: > A first step towards getting rid of register_device_unmigratable > (ivshmem and lacking vmstate support in virtio are blocking this): > > Allow to register an unmigratable vmstate via qdev, i.e. tag a device > declaratively. Declarative is nicer than imperative. ACK.

Re: [Qemu-devel] [PATCH] cocoa: Provide central qemu_main() prototype

2011-06-09 Thread Andreas Färber
Am 29.05.2011 um 21:58 schrieb Andreas Färber: This fixes a missing prototype warning in vl.c and obsoletes the prototype in cocoa.m. Adjust callers in cocoa.m to supply third argument, which is currently only used on Linux/ppc. The prototype is designed so that it could be shared with SDL and

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-09 Thread Markus Armbruster
Aurelien Jarno writes: > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: >> pulse/simple.h does not include stdlib.h >> We cannot use NULL since it may not be defined >> Use 0 instead > > I am unable to reproduce this issue, even with gcc-4.6. Also please note > that NULL i

Re: [Qemu-devel] [PATCH] cocoa: Revert dependency on VNC

2011-06-09 Thread Andreas Färber
Am 02.06.2011 um 20:59 schrieb Andreas Färber: In 821601ea5b02a68ada479731a4d3d07a9876632a (Make VNC support optional) cocoa.o was moved from ui-obj-$(CONFIG_COCOA) to vnc-obj-$ (CONFIG_COCOA), adding a dependency on $(CONFIG_VNC). That must've been unintentional. Cc: Jes Sorensen Cc: Antho

[Qemu-devel] gtester questions/issues

2011-06-09 Thread Luiz Capitulino
I've started writing some tests with the glib test framework (used by the qapi patches) but am facing some issues that doesn't seem to exist with check (our current framework). Of course that it's possible that I'm missing something, in this case pointers are welcome, but I must admit that my fir

Re: [Qemu-devel] [PATCH v2] Darwin: Fix compilation warning regarding the deprecated daemon() function

2011-06-09 Thread Andreas Färber
Am 07.06.2011 um 05:34 schrieb Alexandre Raymond: Changes since v1: create a wrapper function named qemu_daemon() in oslib-posix.c instead of putting the OS specific workaround in qemu-nbd.c directly. On OSX >= 10.5, daemon() is deprecated, resulting in the following warning: 8< qe

[Qemu-devel] [PATCH] cocoa: Avoid warning related to multiple handleEvent: definitions

2011-06-09 Thread Andreas Färber
Avoid compiler confusion as to which method signature to use for the handleEvent: selector on OSX >= 10.6 by making the variable type-safe as opposed to generic 'id' type. Requires moving the variable definition to after the class definition. 8< ui/cocoa.m: In function ‘cocoa_refresh’: ui/

  1   2   >