Re: [Qemu-devel] [RFC PATCH 2/6] scsi: support parsing of SAM logical unit numbers

2011-05-25 Thread Christoph Hellwig
On Fri, May 20, 2011 at 05:03:33PM +0200, Paolo Bonzini wrote: > SAM logical unit numbers are complicated beasts that can address > multiple levels of buses and targets before finally reaching > logical units. Begin supporting them by correctly parsing vSCSI > LUNs. > > Note that with the current

Re: [Qemu-devel] [PATCH 00/26] q35 chipset support for native pci express support

2011-05-25 Thread Jan Kiszka
On 2011-05-17 09:15, Jan Kiszka wrote: > On 2011-05-16 23:55, Adnan Khaleel wrote: >> I finally got this work after I realised that the AHCI driver was not being >> loaded in my disk image and that ACHI was not being enabled in the Seabios >> .config file. >> This is really good work Yamahata, th

Re: [Qemu-devel] [RFC PATCH 3/6] scsi-generic: allow customization of the lun

2011-05-25 Thread Christoph Hellwig
On Fri, May 20, 2011 at 05:03:34PM +0200, Paolo Bonzini wrote: > This allows passthrough of devices with LUN != 0, by redirecting them to > LUN0 in the emulated target. I'm not quite sure what this code is for. Each /dev/sg device reresents a LUN. So if we want to suport multiple LUNs in qemu fo

[Qemu-devel] [PATCH v3 1/2] Generalize -machine command line option

2011-05-25 Thread Jan Kiszka
From: Jan Kiszka -machine somehow suggests that it selects the machine, but it doesn't. Fix that before this command is set in stone. Actually, -machine should supersede -M and allow to introduce arbitrary per-machine options to the command line. That will change the internal realization again,

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-25 Thread Ian Campbell
On Wed, 2011-05-25 at 10:23 +0200, Jan Kiszka wrote: > On 2011-05-25 10:13, Ian Campbell wrote: > > On Tue, 2011-05-24 at 18:18 +0200, Jan Kiszka wrote: > >> On 2011-05-24 18:06, Ian Campbell wrote: > >> Well, first of all I think this revealed a Xen bug because it crashes > >> when you try to run

Re: [Qemu-devel] [PATCH] block/raw-posix: use a character device if a block device is given

2011-05-25 Thread Kevin Wolf
Am 25.05.2011 14:19, schrieb Christoph Egger: > On 05/25/11 12:43, Kevin Wolf wrote: >> Am 24.05.2011 11:30, schrieb Christoph Egger: >>> >>> On NetBSD a userland process is better with the character device >>> interface. In addition, a block device can't be opened twice; if a Xen >>> backend opens

Re: [Qemu-devel] [PATCH] vmdk: fix endianness bugs

2011-05-25 Thread Kevin Wolf
Am 25.05.2011 00:46, schrieb Alexander Graf: > The vmdk code is sloppy when handling the header descriptor during > creation of an image. Fix all header accesses in the create path to > either store native endianness or convert it when appropriate. > > Reported-by: Yury Tsarev > Signed-off-by: Al

Re: [Qemu-devel] [RFC PATCH 0/6] SCSI series part 2, rewrite LUN parsing

2011-05-25 Thread Christoph Hellwig
On Fri, May 20, 2011 at 07:37:30PM +0200, Paolo Bonzini wrote: > On 05/20/2011 06:14 PM, Christoph Hellwig wrote: >> I don't quite understand what you mean with path here. It doesn't >> seem to map to any SAM concept, nor does it seem to be related >> to traditional multipathing. > > It's what SAM

Re: [Qemu-devel] [RFC PATCH 4/6] scsi-disk: allow customization of the lun

2011-05-25 Thread Christoph Hellwig
> case REPORT_LUNS: > +assert(!s->lun); Besides REPORT_LUNS really belonging into the core code as mentioned before the assert seems dangerous to me. What protects a guest from issuing a REPORT LUNS for a non-zero LUN and hitting this assert? Note that SPC explicitly allows sending

Re: [Qemu-devel] [RFC] reduce reported VGA framebuffer to 8 MiB

2011-05-25 Thread Alon Levy
On Wed, May 25, 2011 at 04:06:03PM +0200, Gerd Hoffmann wrote: > On 05/25/11 15:53, Alon Levy wrote: > >Without this windows xp guests set a 4 bits per pixel graphics mode. > > Hmm? Never seen this. Details please. When I start a windows xp guest with -vga qxl and no qxl driver installed I get

Re: [Qemu-devel] [PATCH] block/raw-posix: use a character device if a block device is given

2011-05-25 Thread Kevin Wolf
Am 24.05.2011 11:30, schrieb Christoph Egger: > > On NetBSD a userland process is better with the character device > interface. In addition, a block device can't be opened twice; if a Xen > backend opens it, qemu can't and vice-versa. If you provide a Signed-off-by, I think this patch is ready to

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-25 Thread Bastien ROUCARIES
Le mardi 24 mai 2011 21:58:12, Stefan Hajnoczi a écrit : > On Tue, May 24, 2011 at 08:37:50PM +0100, Jamie Lokier wrote: > TBH I'm almost at the stage where I think we should just use threads > and/or async callbacks, as appropriate. Hopefully I'll be able to cook > up a reasonably portable implem

[Qemu-devel] [PATCH] PPC: fix sregs usage on booke

2011-05-25 Thread Alexander Graf
When compiling qemu with kvm support on BookE PPC machines, I get the following error: cc1: warnings being treated as errors /tmp/qemu/target-ppc/kvm.c: In function 'kvm_arch_get_registers': /tmp/qemu/target-ppc/kvm.c:188: error: unused variable 'sregs' This is due to overly ambitious #ifde

Re: [Qemu-devel] [PATCH] qcow2: Fix in-flight list after qcow2_cache_put failure

2011-05-25 Thread Christoph Hellwig
On Tue, May 24, 2011 at 04:47:19PM +0200, Kevin Wolf wrote: > If qcow2_cache_put returns an error during cluster allocation and the > allocation fails, it must be removed from the list of in-flight allocations. > Otherwise we'd get a loop in the list when the ACB is used for the next > allocation.

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-25 Thread Jan Kiszka
On 2011-05-25 10:13, Ian Campbell wrote: > On Tue, 2011-05-24 at 18:18 +0200, Jan Kiszka wrote: >> On 2011-05-24 18:06, Ian Campbell wrote: >>> On Sun, 2011-05-22 at 13:00 +0200, Jan Kiszka wrote: From: Jan Kiszka -machine somehow suggests that it selects the machine, but it doesn't

Re: [Qemu-devel] [PATCH] block/raw-posix: use a character device if a block device is given

2011-05-25 Thread Christoph Egger
On 05/25/11 12:43, Kevin Wolf wrote: Am 24.05.2011 11:30, schrieb Christoph Egger: On NetBSD a userland process is better with the character device interface. In addition, a block device can't be opened twice; if a Xen backend opens it, qemu can't and vice-versa. If you provide a Signed-off-b

[Qemu-devel] [RFC] reduce reported VGA framebuffer to 8 MiB

2011-05-25 Thread Alon Levy
Without this windows xp guests set a 4 bits per pixel graphics mode. With it we get the same behavior as with -vga std, that is a 32 bpp graphics mode. This fits the size reported by hw/vga-pci.c . --- Sending as RFC since I'm not sure if this is the right thing, nor that it doesn't actually inter

Re: [Qemu-devel] [PATCH] block/raw-posix: get right partition size

2011-05-25 Thread Kevin Wolf
Am 23.05.2011 14:31, schrieb Christoph Egger: > > use the correct way to get the size of a disk device or partition > > From: Adam Hamsik > Signed-off-by: Christoph Egger Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] ccid-card-emulated: handle no backend (fixes segfault)

2011-05-25 Thread Markus Armbruster
Alon Levy writes: > During initialization if no "backend=something" attribute is supplied > don't try to call strcmp with second argument being NULL. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 0/5] virtio-serial: Fixes and cleanups

2011-05-25 Thread Amit Shah
On (Wed) 25 May 2011 [14:21:09], Markus Armbruster wrote: > Feel free to drop PATCH 3/3 if you believe we need to keep the useless > property is_console for backward compatibility. I don't think anyone uses it; it's better gone. Thanks for the patches, applied to my tree. Will send a pull reques

Re: [Qemu-devel] [RFC] reduce reported VGA framebuffer to 8 MiB

2011-05-25 Thread Alon Levy
On Wed, May 25, 2011 at 05:33:59PM +0300, Alon Levy wrote: > On Wed, May 25, 2011 at 04:06:03PM +0200, Gerd Hoffmann wrote: > > On 05/25/11 15:53, Alon Levy wrote: > > >Without this windows xp guests set a 4 bits per pixel graphics mode. > > > > Hmm? Never seen this. Details please. > > When I

Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-25 Thread Paolo Bonzini
On 05/25/2011 12:12 AM, David Gibson wrote: @@ -602,6 +604,8 @@ static int spapr_vio_busdev_init(DeviceState *qdev, DeviceInfo *qinfo) } dev->qdev.id = id; +dev->vio_irq_num = bus->irq++; +dev->qirq = xics_find_qirq(spapr->icp, dev->vio_irq_num); I'd prefer to see an spapr

Re: [Qemu-devel] [PATCH V4 03/10] Add persistent state handling to TPM TIS frontend driver

2011-05-25 Thread Stefan Berger
On 05/18/2011 03:25 AM, Markus Armbruster wrote: Stefan Berger writes: +static void tis_register_device(void) +{ +isa_qdev_register(&tis_device_info); +} + +device_init(tis_register_device) Why is this device no_user? In case you want to review V5, I posted it: http://lists.nongnu.org/a

Re: [Qemu-devel] Derivative snapshots or snapshots for versioning

2011-05-25 Thread Mike Young
Thanks Stefan! On 5/25/11 1:21 AM, "Stefan Hajnoczi" wrote: >On Tue, May 24, 2011 at 5:14 PM, Mike Young >wrote: >> I'm trying to see if I can I do a derivative snapshot as a means of >> versioning. I wish to do this vs dd or cp as it's much faster. I do not >> intend to apply a snapshot back t

Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev

2011-05-25 Thread Paolo Bonzini
On 05/25/2011 12:14 AM, David Gibson wrote: I don't see what the point of this is. Absolute irq numbers have no special meaning in the XICS context, and the guest kernel will remap them to virtual irqs anyway. It allows you to see the irq in "info qtree" for example. Paolo

Re: [Qemu-devel] [0/25] Async threading for VirtFS using glib threads & coroutines.

2011-05-25 Thread Stefan Hajnoczi
On Tue, May 24, 2011 at 10:00 PM, Jamie Lokier wrote: > Venkateswararao Jujjuri wrote: >> This model makes the code simple and also in one shot we can convert >> all v9fs_do_syscalls into asynchronous threads. But as Aneesh raised >> will there be any additional overhead for the additional jumps?

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-25 Thread Paolo Bonzini
On 05/24/2011 11:21 PM, Anthony Liguori wrote: Why not use threads as a coroutine fallback? That's essentially what we would do to be "fully threaded". Not exactly, there would be much less synchronization going on. Using threads to implement coroutines means you go through the slow path of

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-25 Thread Anthony PERARD
On Wed, 25 May 2011, Ian Campbell wrote: > On Tue, 2011-05-24 at 18:18 +0200, Jan Kiszka wrote: > > On 2011-05-24 18:06, Ian Campbell wrote: > > > On Sun, 2011-05-22 at 13:00 +0200, Jan Kiszka wrote: > > >> From: Jan Kiszka > > >> > > >> -machine somehow suggests that it selects the machine, but

Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev

2011-05-25 Thread Markus Armbruster
David Gibson writes: > On Tue, May 24, 2011 at 01:45:07PM +0200, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> Cc: Alexander Graf >> Cc: David Gibson >> --- >> hw/spapr_vio.c |8 +++- >> 1 files changed, 7 insertions(+), 1 deletions(-) >> >> diff --git a/hw/spapr_vio.c b/hw

Re: [Qemu-devel] [RFC PATCH 0/6] SCSI series part 2, rewrite LUN parsing

2011-05-25 Thread Paolo Bonzini
On 05/25/2011 03:17 PM, Christoph Hellwig wrote: On Fri, May 20, 2011 at 07:37:30PM +0200, Paolo Bonzini wrote: On 05/20/2011 06:14 PM, Christoph Hellwig wrote: I don't quite understand what you mean with path here. It doesn't seem to map to any SAM concept, nor does it seem to be related to t

Re: [Qemu-devel] [RFC] reduce reported VGA framebuffer to 8 MiB

2011-05-25 Thread Gerd Hoffmann
On 05/25/11 15:53, Alon Levy wrote: Without this windows xp guests set a 4 bits per pixel graphics mode. Hmm? Never seen this. Details please. cheers, Gerd

Re: [Qemu-devel] [RFC PATCH 3/6] scsi-generic: allow customization of the lun

2011-05-25 Thread Paolo Bonzini
On 05/25/2011 03:10 PM, Christoph Hellwig wrote: On Fri, May 20, 2011 at 05:03:34PM +0200, Paolo Bonzini wrote: This allows passthrough of devices with LUN != 0, by redirecting them to LUN0 in the emulated target. I'm not quite sure what this code is for. Each /dev/sg device reresents a LUN.

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-25 Thread Ian Campbell
On Tue, 2011-05-24 at 18:18 +0200, Jan Kiszka wrote: > On 2011-05-24 18:06, Ian Campbell wrote: > > On Sun, 2011-05-22 at 13:00 +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> -machine somehow suggests that it selects the machine, but it doesn't. > >> Fix that before this command is set i

[Qemu-devel] [PATCH 3/5] virtio-serial: Drop useless property is_console

2011-05-25 Thread Markus Armbruster
All you could ever achieve with it is break stuff, so removing it should be safe. Signed-off-by: Markus Armbruster --- hw/virtio-console.c |2 -- hw/virtio-serial.h |3 --- 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 50b

[Qemu-devel] [PATCH 5/5] virtio-console: Simplify init callbacks

2011-05-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/virtio-console.c | 35 +-- 1 files changed, 9 insertions(+), 26 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 713f6ef..b076331 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -74,

[Qemu-devel] [PATCH 4/5] virtio-serial: Drop redundant VirtIOSerialPort member info

2011-05-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/virtio-console.c|9 ++--- hw/virtio-serial-bus.c | 42 ++ hw/virtio-serial.h |1 - 3 files changed, 32 insertions(+), 20 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c inde

Re: [Qemu-devel] [PATCH v3 1/2] Generalize -machine command line option

2011-05-25 Thread Ian Campbell
On Wed, 2011-05-25 at 09:03 +0200, Jan Kiszka wrote: > From: Jan Kiszka > > -machine somehow suggests that it selects the machine, but it doesn't. > Fix that before this command is set in stone. > > Actually, -machine should supersede -M and allow to introduce arbitrary > per-machine options to

[Qemu-devel] [PATCH 2/5] virtio-serial: Clean up virtconsole detection

2011-05-25 Thread Markus Armbruster
virtio-serial-bus needs to treat "virtconsole" devices specially. It uses VirtIOSerialPort member is_console to recognize them. It gets its value via property initialization. Cute hack, except it lets users mess with it: "-device virtconsole,is_console=0" isn't plugged into port 0 as it should.

[Qemu-devel] [PATCH 0/5] virtio-serial: Fixes and cleanups

2011-05-25 Thread Markus Armbruster
Feel free to drop PATCH 3/3 if you believe we need to keep the useless property is_console for backward compatibility. Markus Armbruster (5): virtio-serial: Plug memory leak on qdev exit() virtio-serial: Clean up virtconsole detection virtio-serial: Drop useless property is_console virtio-

Re: [Qemu-devel] [PATCH][qemu-iotests] add qed support to 025 image resize test

2011-05-25 Thread Christoph Hellwig
Thanks, applied.

[Qemu-devel] [PATCH 1/5] virtio-serial: Plug memory leak on qdev exit()

2011-05-25 Thread Markus Armbruster
virtio_serial_init() allocates the VirtIOSerialBus dynamically, but virtio_serial_exit() doesn't free it. Fix by getting rid of the allocation. Signed-off-by: Markus Armbruster --- hw/virtio-serial-bus.c | 27 +-- 1 files changed, 9 insertions(+), 18 deletions(-) diff

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-25 Thread Stefan Hajnoczi
On Tue, May 24, 2011 at 9:51 PM, Jamie Lokier wrote: > Stefan Hajnoczi wrote: >> My current plan is to try using sigaltstack(2) instead of >> makecontext()/swapcontext() as a hack since OpenBSD doesn't have >> makecontext()/swapcontext(). > > sigaltstack() is just a system call to tell the system

[Qemu-devel] [RFCv2] vga: VBE: report maximum VGA_MEM_SIZE memory

2011-05-25 Thread Alon Levy
When using -vga qxl the amount reported is minimally 32 MiB, making windows guests come up in a 16 color mode. With this change they work correctly, coming up with the full range of VBE supported modes. This patch changes just the reported memory size by VBE (VBE_DISPI_INDEX_VIDEO_MEMORY_64K) and

[Qemu-devel] [PATCH 2/6] target-arm: Add helper function to generate code to get fpstatus pointer

2011-05-25 Thread Peter Maydell
Add and use a helper function which returns a TCGv which is a pointer to the fp_status for either Neon or VFP operations. Signed-off-by: Peter Maydell --- target-arm/translate.c | 40 1 files changed, 16 insertions(+), 24 deletions(-) diff --git a/targ

[Qemu-devel] [PATCH 6/6] Revert "Makefile.target: Allow target helpers to be in any *_helper.c file"

2011-05-25 Thread Peter Maydell
Reverts commit 348883d4828d7434e1053407818598f7fb15e594, so the global env is no longer available to helper.c files other than op_helper.c. Signed-off-by: Peter Maydell --- Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target

[Qemu-devel] [PATCH 4/6] target-arm: Pass fp status pointer explicitly to neon fp helpers

2011-05-25 Thread Peter Maydell
Make the Neon helpers for various floating point operations take an explicit pointer to the float_status they use, so they don't rely on the global environment pointer any more. This also allows us to drop the mul/sub/add helpers completely and just use the vfp versions. Signed-off-by: Peter Mayde

[Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env

2011-05-25 Thread Peter Maydell
This patchset is largely aimed at rolling back the changes from an earlier patchset of mine: http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00244.html which made various Neon helper routines use the correct FP status flags by having them use the global env. Since we've decided we're tryin

[Qemu-devel] [PATCH 1/6] Revert "target-arm: Use global env in iwmmxt_helper.c helpers"

2011-05-25 Thread Peter Maydell
This reverts commit 947a2fa21b61703802a660a938cabd7b3600ee79, returning the iwmmxt helpers to passing env in as a parameter. Signed-off-by: Peter Maydell --- target-arm/helper.h| 122 +- target-arm/iwmmxt_helper.c | 80 --

[Qemu-devel] [PATCH 3/6] target-arm: Make VFP binop helpers take pointer to fpstatus, not CPUState

2011-05-25 Thread Peter Maydell
Make the VFP binop helper functions take a pointer to the fp status, not the entire CPUState. This will allow us to use them for Neon operations too. Signed-off-by: Peter Maydell --- target-arm/helper.c| 10 ++ target-arm/helper.h| 16 target-arm/translate.c

[Qemu-devel] [PATCH 5/6] Revert "target-arm: Use global env in neon_helper.c helpers"

2011-05-25 Thread Peter Maydell
This effectively reverts commit 2a3f75b42ac255be09ec2939b96c549ec830efd3 so that we return to passing CPUState to helpers as an explicit parameter. (There were a number of conflicts in target-arm/translate.c which had to be resolved by hand so it is not a pure revert.) Signed-off-by: Peter Maydell

Re: [Qemu-devel] Derivative snapshots or snapshots for versioning

2011-05-25 Thread Stefan Hajnoczi
On Tue, May 24, 2011 at 5:14 PM, Mike Young wrote: > I'm trying to see if I can I do a derivative snapshot as a means of > versioning. I wish to do this vs dd or cp as it's much faster. I do not > intend to apply a snapshot back to an original volume. > So, let's say I have original_volume.img and

Re: [Qemu-devel] 9p and savevm'd snapshots

2011-05-25 Thread Alex Young
On 24/05/11 19:36, Anthony Liguori wrote: > On 05/24/2011 03:54 AM, Alex Young wrote: >> Hi there, >> >> I'm having a problem with 9p virtfs mounts going away when I savevm, >> quit, then restart with -loadvm. The mount seems to cause the guest >> kernel to hang if I interact with it in any way tha

[Qemu-devel] Looking for the correct way to pull register values out of QEMU

2011-05-25 Thread Nathan DeBardeleben
Hello all, hopefully this message is not too trivial. I am looking for some simple direction. What I am looking to do is to pull the register states out of a QEMU session external to the session. I figure at very least I could save the state of the VM to a file and then dig through it but th

[Qemu-devel] [PATCH] configure: Don't create symlinks to nonexistent targets

2011-05-25 Thread Peter Maydell
When we create the symlinks to source tree files, don't create them if the file is not actually present in the source tree; this will happen if the file is in a git submodule that wasn't checked out. This also avoids the odd effect where an in-source-tree configure will end up creating the missing

[Qemu-devel] [PATCH v2] configure: Don't create symlinks to nonexistent targets

2011-05-25 Thread Peter Maydell
When we create the symlinks to source tree files, don't create them if the file is not actually present in the source tree; this will happen if the file is in a git submodule that wasn't checked out. This also avoids the odd effect where an in-source-tree configure will end up creating the missing

Re: [Qemu-devel] [PATCH v2] configure: Don't create symlinks to nonexistent targets

2011-05-25 Thread Stefan Weil
Am 25.05.2011 19:30, schrieb Peter Maydell: When we create the symlinks to source tree files, don't create them if the file is not actually present in the source tree; this will happen if the file is in a git submodule that wasn't checked out. This also avoids the odd effect where an in-source-t

Re: [Qemu-devel] Looking for the correct way to pull register values out of QEMU

2011-05-25 Thread Mulyadi Santosa
On Wed, May 25, 2011 at 23:42, Nathan DeBardeleben wrote: > Hello all, hopefully this message is not too trivial.  I am looking for some > simple direction. > > What I am looking to do is to pull the register states out of a QEMU session > external to the session.  I figure at very least I could s

Re: [Qemu-devel] Looking for the correct way to pull register values out of QEMU

2011-05-25 Thread Richard Henderson
On 05/25/2011 09:42 AM, Nathan DeBardeleben wrote: > 1: Stop QEMU (maybe not necessary?) > 2: Drag down the set of registers > 3: Release QEMU (contingent on #1) > 4: Repeat over some periodic sampling rate. > 5: Produce a "gprof-like" graph of where the PC was during the time observed. The gdb re

[Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-05-25 Thread Greg McGary
I would like to create a QEMU model of an SoC that has several CPU cores having different architectures. I'm guessing this can be done. Has anyone has thought much about this, and/or have advice? FYI, I am reasonably experienced with QEMU--I ported it to a new proprietary generic-RISC archite

[Qemu-devel] [PATCH 1/2] QMP: add get_events(wait=True) option

2011-05-25 Thread Stefan Hajnoczi
The get_events() function polls for new QMP events and then returns. It can be useful to wait for the next QMP event so add the boolean 'wait' keyword argument. Signed-off-by: Stefan Hajnoczi --- QMP/qmp.py | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/QMP/q

[Qemu-devel] [PATCH 2/2] QMP: add server mode to QEMUMonitorProtocol

2011-05-25 Thread Stefan Hajnoczi
QEMU supports socket chardevs that establish connections like a server or a client. The QEMUMonitorProtocol class only supports connecting as a client. It is not possible to connect race-free when launching QEMU since trying to connect before QEMU has bound and is listening on the socket results

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-25 Thread Richard Henderson
On 05/25/2011 12:09 AM, Stefan Hajnoczi wrote: > On Tue, May 24, 2011 at 9:51 PM, Jamie Lokier wrote: >> Stefan Hajnoczi wrote: >>> My current plan is to try using sigaltstack(2) instead of >>> makecontext()/swapcontext() as a hack since OpenBSD doesn't have >>> makecontext()/swapcontext(). >> >>

[Qemu-devel] Virtio net bringup for new arch?

2011-05-25 Thread Greg McGary
I have a new architecture port that can boot linux and work interactively with a UART. The next step to facilitate application development is to have NFS filesystems. The real HW has no bus--it will have some sort of shared-memory, SW-arbitrated access to a control processor's devices. For dev

Re: [Qemu-devel] [PATCH v4 1/4] rbd: use the higher level librbd instead of just librados

2011-05-25 Thread Christian Brunner
Apart from two cosmetic issues (see below), I think this patch is ready to replace the old rbd driver. You can add: Reviewed-by: Christian Brunner Regards Christian 2011/5/24 Josh Durgin : > librbd stacks on top of librados to provide access > to rbd images. > > Using librbd simplifies the qemu

Re: [Qemu-devel] [PATCH v4 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-25 Thread Christian Brunner
Looks good to me: Reviewed-by: Christian Brunner 2011/5/24 Josh Durgin : > The new format is > rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] > Each option is used to configure rados, and may be any Ceph option, or "conf". > The "conf" option specifies a Ceph configuration file

Re: [Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-05-25 Thread Peter Maydell
On 25 May 2011 19:44, Greg McGary wrote: > I would like to create a QEMU model of an SoC that has several > CPU cores having different architectures.  I'm guessing this > can be done. It's not supported currently as far as I'm aware. There was at least one paper at the QEMU Forum earlier this yea

Re: [Qemu-devel] [PATCH v4 3/4] rbd: check return values when scheduling aio

2011-05-25 Thread Christian Brunner
We should not leave this out: Reviewed-by: Christian Brunner 2011/5/24 Josh Durgin : > If scheduling fails, the number of outstanding I/Os must be correct, > or there will be a hang when waiting for everything to be flushed. > > Reported-by: Stefan Hajnoczi > Signed-off-by: Josh Durgin > --- >

Re: [Qemu-devel] [PATCH v4 4/4] rbd: Add bdrv_truncate implementation

2011-05-25 Thread Christian Brunner
Looks good to me: Reviewed-by: Christian Brunner 2011/5/24 Josh Durgin : > Signed-off-by: Josh Durgin > --- >  block/rbd.c |   15 +++ >  1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/block/rbd.c b/block/rbd.c > index c9f32e4..015ae8e 100644 > --- a/block/rbd.c

Re: [Qemu-devel] [PATCH v2] configure: Don't create symlinks to nonexistent targets

2011-05-25 Thread Paolo Bonzini
On 05/25/2011 07:49 PM, Stefan Weil wrote: + if [ -e "$source_path/$f" -a ! -e "$f" ]; then + symlink "$source_path/$f" "$f" + fi Please use && instead of -a, and "! [" instead of "[ !". Paolo

Re: [Qemu-devel] Virtio net bringup for new arch?

2011-05-25 Thread Alexander Graf
On 25.05.2011, at 21:00, Greg McGary wrote: > I have a new architecture port that can boot linux and work interactively > with a UART. > The next step to facilitate application development is to have NFS > filesystems. The > real HW has no bus--it will have some sort of shared-memory, SW-arbit

Re: [Qemu-devel] Virtio net bringup for new arch?

2011-05-25 Thread Greg McGary
On 05/25/11 13:10, Alexander Graf wrote: > Now, if your device can do MMIO even on real hardware, that'd certainly ease > a lot of things for you, as you could just reuse all the hardware emulation > in Qemu and get Linux drivers for free as well. It would certainly save you > from a lot of head

[Qemu-devel] [PATCH 03/12] target-s390x: Add missing tcg_temp_free_i64()

2011-05-25 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index a240efa..bf6bda5 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -1095,6 +1095,7 @@ st

[Qemu-devel] [PATCH 11/12] target-s390x: Add missing tcg_temp_free_i64()

2011-05-25 Thread Stefan Weil
load_reg() needs a matching tcg_temp_free_i64(). Signed-off-by: Stefan Weil --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index cfd2297..1261be4 100644 --- a/target-s390x/translate.c +++ b

[Qemu-devel] [PATCH 08/12] target-s390x: Add missing tcg_temp_free_i64()

2011-05-25 Thread Stefan Weil
load_reg() needs a matching tcg_temp_free_i64(). Signed-off-by: Stefan Weil --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 3143703..aec1272 100644 --- a/target-s390x/translate.c +++ b

[Qemu-devel] [PATCH 06/12] target-s390x: Add missing tcg_temp_free_i64()

2011-05-25 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target-s390x/translate.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index bf6a363..474d13b 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -4598,6 +4598,8 @@ s

[Qemu-devel] [PATCH 09/12] target-s390x: Add missing tcg_temp_free_i64()

2011-05-25 Thread Stefan Weil
load_reg() needs a matching tcg_temp_free_i64(). Signed-off-by: Stefan Weil --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index aec1272..67b249b 100644 --- a/target-s390x/translate.c +++ b

[Qemu-devel] [PATCH 01/12] target-s390x: Fix wrong argument in call of tcg_gen_shl_i64()

2011-05-25 Thread Stefan Weil
tcg_gen_shl_i64 needs an argument of type TCGv_i64. Using tmp4 needs some additional changes. Signed-off-by: Stefan Weil --- target-s390x/translate.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 8e71df3.

[Qemu-devel] [PATCH 05/12] target-s390x: Add missing tcg_temp_free_i64()

2011-05-25 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target-s390x/translate.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 723e53d..bf6a363 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -2966,6 +2966,8 @@ s

[Qemu-devel] [PATCH 10/12] target-s390x: Add missing tcg_temp_free_i64()

2011-05-25 Thread Stefan Weil
load_reg() needs a matching tcg_temp_free_i64(). Signed-off-by: Stefan Weil --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 67b249b..cfd2297 100644 --- a/target-s390x/translate.c +++ b

[Qemu-devel] [PATCH 04/12] target-s390x: Add missing tcg_temp_free_i64()

2011-05-25 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index bf6bda5..723e53d 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -2097,6 +2097,7 @@ do

[Qemu-devel] [PATCH 02/12] target-s390x: Fix duplicate call of tcg_temp_new_i64

2011-05-25 Thread Stefan Weil
tmp2 = tcg_temp_new_i64() is already executed unconditionally, so there is no need to call it a second time for 64 bit hosts. Signed-off-by: Stefan Weil --- target-s390x/translate.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/t

[Qemu-devel] [PATCH 00/12] target-s390x: Several small fixes

2011-05-25 Thread Stefan Weil
The first patch was triggered by a compilation error with configuration --enable-debug-tcg on 64 bit hosts. While looking for a fix, I noticed another issue in the same function which I tried to fix in the 2nd patch. Finally, I reviewed all allocations of TCGv_i64 values and the matching tcg_temp

[Qemu-devel] [PATCH 12/12] target-s390x: Add missing tcg_temp_free_i32()

2011-05-25 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target-s390x/translate.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 1261be4..baecd3f 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -1078,9 +1078,12 @@

[Qemu-devel] [PATCH 07/12] target-s390x: Add missing tcg_temp_free_i64()

2011-05-25 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 474d13b..3143703 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -4623,6 +4623,7 @@ st

[Qemu-devel] [PATCH v5 0/4] rbd improvements

2011-05-25 Thread Josh Durgin
This patchset moves the complexity of the rbd format into librbd and adds truncation support. Changes since v4: * fixed cosmetic issues pointed out by Christian Brunner Changes since v3: * trivially rebased * updated copyright header Changes since v2: * return values are checked in rbd_aio_r

[Qemu-devel] [PATCH v5 3/4] rbd: check return values when scheduling aio

2011-05-25 Thread Josh Durgin
If scheduling fails, the number of outstanding I/Os must be correct, or there will be a hang when waiting for everything to be flushed. Reported-by: Stefan Hajnoczi Signed-off-by: Josh Durgin --- block/rbd.c | 24 1 files changed, 20 insertions(+), 4 deletions(-) dif

[Qemu-devel] [PATCH v5 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-25 Thread Josh Durgin
The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] Each option is used to configure rados, and may be any Ceph option, or "conf". The "conf" option specifies a Ceph configuration file to read. This allows rbd volumes from more than one Ceph cluster to be used by speci

[Qemu-devel] [PATCH v5 4/4] rbd: Add bdrv_truncate implementation

2011-05-25 Thread Josh Durgin
Signed-off-by: Josh Durgin --- block/rbd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index a44d160..b95b1eb 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -688,6 +688,20 @@ static int64_t qemu_rbd_getlength(BlockDriverState *b

[Qemu-devel] [PATCH v5 1/4] rbd: use the higher level librbd instead of just librados

2011-05-25 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c | 795 +++-

Re: [Qemu-devel] [PATCH v4 1/4] rbd: use the higher level librbd instead of just librados

2011-05-25 Thread Josh Durgin
On 05/25/2011 12:18 PM, Christian Brunner wrote: Apart from two cosmetic issues (see below), I think this patch is ready to replace the old rbd driver. You can add: Reviewed-by: Christian Brunner Regards Christian Thanks, I fixed these in v5. Josh 2011/5/24 Josh Durgin: librbd stacks on

Re: [Qemu-devel] Virtio net bringup for new arch?

2011-05-25 Thread Alexander Graf
On 25.05.2011, at 22:22, Greg McGary wrote: > On 05/25/11 13:10, Alexander Graf wrote: >> Now, if your device can do MMIO even on real hardware, that'd certainly ease >> a lot of things for you, as you could just reuse all the hardware emulation >> in Qemu and get Linux drivers for free as well

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: Use correct float status for Neon int-float conversions

2011-05-25 Thread Stefan Weil
Am 19.05.2011 15:46, schrieb Peter Maydell: The Neon versions of int-float conversions must use the "standard FPSCR" rather than the default FPSCR. Implement this by having the helper functions take a pointer to the appropriate float_status value rather than simply taking a pointer to the entire

Re: [Qemu-devel] [PATCH 1/2] QMP: add get_events(wait=True) option

2011-05-25 Thread Luiz Capitulino
On Wed, 25 May 2011 19:48:00 +0100 Stefan Hajnoczi wrote: > The get_events() function polls for new QMP events and then returns. It > can be useful to wait for the next QMP event so add the boolean 'wait' > keyword argument. > > Signed-off-by: Stefan Hajnoczi > --- > QMP/qmp.py | 11 +++

Re: [Qemu-devel] [PATCH 2/2] QMP: add server mode to QEMUMonitorProtocol

2011-05-25 Thread Luiz Capitulino
On Wed, 25 May 2011 19:48:01 +0100 Stefan Hajnoczi wrote: > QEMU supports socket chardevs that establish connections like a server > or a client. The QEMUMonitorProtocol class only supports connecting as > a client. It is not possible to connect race-free when launching QEMU > since trying to c

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: Use correct float status for Neon int-float conversions

2011-05-25 Thread Peter Maydell
On 25 May 2011 21:49, Stefan Weil wrote: > This patch breaks compilation at least on 64 bit hosts with configure option > --enable-debug-tcg > (tested on 64 bit Debian Linux). > > target-arm/translate.c: In function ‘gen_vfp_uito’: > target-arm/translate.c:999: error: incompatible type for argumen

Re: [Qemu-devel] Virtio net bringup for new arch?

2011-05-25 Thread Richard Henderson
On 05/25/2011 01:22 PM, Greg McGary wrote: > MMIO, yes. Any opinion on whether or not to have a minimal fake PCI bus? It's probably easiest to pretend your HW has PCI, yes. Alex is suggesting that it would be easier to pretend you have one of the existing PCI host controllers as well. I don't k

Re: [Qemu-devel] [PATCH 00/12] target-s390x: Several small fixes

2011-05-25 Thread Peter Maydell
On 25 May 2011 21:25, Stefan Weil wrote: > Feel free to combine patches if larger patches are preferred. I'd vote for combining at least 03..12, having nine patches all of which have the same summary line is a bit confusing :-) -- PMM

Re: [Qemu-devel] [PATCH 01/12] target-s390x: Fix wrong argument in call of tcg_gen_shl_i64()

2011-05-25 Thread Alexander Graf
On 25.05.2011, at 22:25, Stefan Weil wrote: > tcg_gen_shl_i64 needs an argument of type TCGv_i64. > Using tmp4 needs some additional changes. > > Signed-off-by: Stefan Weil > --- > target-s390x/translate.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/targ

Re: [Qemu-devel] [PATCH 00/12] target-s390x: Several small fixes

2011-05-25 Thread Alexander Graf
On 26.05.2011, at 00:10, Peter Maydell wrote: > On 25 May 2011 21:25, Stefan Weil wrote: >> Feel free to combine patches if larger patches are preferred. > > I'd vote for combining at least 03..12, having nine patches all > of which have the same summary line is a bit confusing :-) I actually

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-05-25 Thread Oleg
>> Do you think it will ever get fixed in a reasonable amount of time (or ever) >Well, it's on my list of things to look at, but generally my focus is the current (ARMv7) architecture, and fixing ARMv5 only bugs is lower priority. But there's a pretty good chance I'll get to it somewhere in the ne

  1   2   >