Hi Gerd,
hm, if I add it multiple times and plug in a USB flashdrive, then all
slots are filled up with this device (duplicated)...
And Windows detects them with the result, that the "not first" devices
are marked with a yellow exclamation mark in the device manager.
And the next device plugged i
On 17.05.2011, at 08:47, David Gibson wrote:
> From: Alexey Kardashevskiy
>
> The recently added pseries machine does not currently support PCI
> emulation. For the (upcoming) kvm case, this is quite difficult to do
> because the preferred HV mode for the host kernel does not allow MMIO
> emul
Hi,
More specifically:
http://www.mail-archive.com/qemu-devel@nongnu.org/msg30337.html
Reference added to the commit message.
cheers,
Gerd
On 2011-05-16 23:55, Adnan Khaleel wrote:
> I finally got this work after I realised that the AHCI driver was not being
> loaded in my disk image and that ACHI was not being enabled in the Seabios
> .config file.
> This is really good work Yamahata, thanks.
>
>
> As far as I can tell, everythin
Hi all,
I created one guest on Ubuntu 10.10:
=
sudo virt-install --connect qemu:///system -n ubuntu-10.10-guest -r 1024
--vcpus=1 -c /tmp/ubuntu-10.10-desktop-i386.iso --os-type=linux
--disk=/var/lib/libvirt/images/ubuntu-10.10-guest.img,size=10 --vnc
--accelerate
Afte
On 05/16/11 13:56, Gerd Hoffmann wrote:
This patch finally merges the EHCI host adapter aka USB 2.0 support.
Based on git://git.kiszka.org/qemu.git ehci
Changes:
- Adapt to recent changes in the usb subsystem.
- Don't create device automagically, use -device instead.
- Add quickstart t
Hi,
git://git.kraxel.org/qemu usb.11.pull
Cool! I'm glad to see someone actively working in this space.
Any specific areas where testing would be helpful?
All over the place ;)
Current state:
usb device emulation:
- usb-storage should work fine on high speed.
- all others do either
Am 16.05.2011 18:26, schrieb Paolo Bonzini:
> On 05/16/2011 05:58 PM, Kevin Wolf wrote:
>> Thanks. Still doesn't make much sense to me, the patch shouldn't change
>> anything with respect to a malloc, but I can reproduce a segfault now. I
>> think I'll have a closer look tomorrow.
>
> This fixes i
Jan Kiszka writes:
> On 2011-05-16 09:28, Gerd Hoffmann wrote:
>> On 05/13/11 16:18, Markus Armbruster wrote:
>>> VGA, cirrus-vga and vmware-svga do. Gerd, you added it (commit
>>> a19cbfb3), care to explain?
>>
>> Just forgot to add it to the list when merging.
>> I'll go stuff a patch into th
LinkedIn
Paulo Silva requested to add you as a connection on LinkedIn:
--
Jiajun,
I'd like to add you to my professional network on LinkedIn.
- Paulo
Accept invitation from Paulo Silva
http://www.linkedin.com/e/-kkb1ec-gnsl5q5u-64/qTMmi8QEI_f3
Am 16.05.2011 20:10, schrieb Supriya Kannery:
> Enhance "info block" to display cache setting
>
> Example:
> (qemu) info block
> ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2
> encrypted=0
>
> Enhanced to include "cache" setting:
> (qemu) info block
> ide0-hd0: type=hd remo
Kevin Wolf wrote:
Am 16.05.2011 20:10, schrieb Supriya Kannery:
Enhance "info block" to display cache setting
Example:
(qemu) info block
ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2
encrypted=0
Enhanced to include "cache" setting:
(qemu) info block
ide0-hd0: type=hd
Christoph Hellwig wrote:
Why are you even trying this again?
Enabling control of cache setting from qemu monitor will help
users/admins to
accomplish cache value change without depending on the guest.
As explained very clearly last time you
can't change from a writeback-style to a write-throu
Anthony Liguori wrote:
On 05/16/2011 03:23 PM, Christoph Hellwig wrote:
Why are you even trying this again? As explained very clearly last
time you
can't change from a writeback-style to a write-through style I/O from
the monitor without creating massive data integrity problems.
To further c
During initialization if no "backend=something" attribute is supplied
don't try to call strcmp with second argument being NULL.
Signed-off-by: Alon Levy
---
hw/ccid-card-emulated.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/ccid-card-emulated.c b/hw/ccid-card-e
Am 16.05.2011 10:33, schrieb Markus Armbruster:
> Anthony Liguori writes:
>
>> On 05/13/2011 11:36 AM, Markus Armbruster wrote:
>>> When Gerd qdevified USB, he kept legacy -usbdevice working (commit
>>> 0958b4cc...). What about new USB devices? Should they get a legacy
>>> syntax, too?
>>>
>>>
This series includes the following improvements to the SCSI subsystem:
1) introduction of SCSIBusOps that generalize the existing
command_complete callback;
2) widespread use of the SCSIRequest abstraction, with simpler memory
management (refcounting) and with various common idioms converted into
scsi-generic scsi_read_complete() should not -both- call the client
complete callback with SCSI_REASON_DATA -and- call
scsi_command_complete(). The former will cause the client to queue a
new read or write request, while the later will free the request data
structure, thus causing the new read or
There are more operations than a SCSI bus can handle, besides completing
commands. One example, which this series will introduce, is cleaning up
after a request is cancelled.
More long term, a "SCSI bus" can represent the LUNs attached to a
target; in this case, while all commands will ultimately
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |6 ++
trace-events |6 ++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index ceeb4ec..0fd85fc 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -4,6 +4,7 @@
#include "scsi-defs.h"
#
This covers the case of canceling a request's I/O and still
completing it.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c|9 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |8 ++--
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.
From: Hannes Reinecke
The SCSI spec has a quite detailed list of sense codes available.
It even mandates the use of specific ones for some failure cases.
The current implementation just has one type of generic error
which is actually a violation of the spec in certain cases.
This patch introduces
This abstracts calling the command_complete callback, reducing churn
in the following patches.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |6 ++
hw/scsi-disk.c|8
hw/scsi-generic.c |6 +++---
hw/scsi.h |1 +
trace-events |1 +
5 files cha
From: Hannes Reinecke
Currently the SCSIRequest structure is abstracted away and cannot accessed
directly from the driver. This requires the handler to do a lookup on
an abstract 'tag' which identifies the SCSIRequest structure.
With this patch the SCSIRequest structure is exposed to the driver.
Signed-off-by: Paolo Bonzini
---
hw/esp.c |2 +-
hw/lsi53c895a.c |3 +--
hw/scsi-bus.c|5 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |2 +-
hw/usb-msd.c |2 +-
6 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/esp.c b/hw/esp.c
index 3a6
Move the common part of scsi-disk.c and scsi-generic.c to the SCSI layer.
At the same time, protect against the request being freed under the
feet of the send_command callback.
This fixes a use-after-free that happened when scsi-disk's
scsi_disk_emulate_command completed an illegal request, and st
Signed-off-by: Paolo Bonzini
---
hw/lsi53c895a.c | 63 +-
1 files changed, 38 insertions(+), 25 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index ccea6ad..3b67155 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -652,38 +
Signed-off-by: Paolo Bonzini
---
hw/scsi-generic.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 5bfbb8a..e1f8a8a 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -288,7 +288,6 @@ static int32_t scsi_send_command(
The code for canceling requests upon reset is already the same. Clean
it up and move it to scsi-bus.c.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c | 12
hw/scsi-disk.c| 18 ++
hw/scsi-generic.c | 18 ++
hw/scsi.h |1 +
4
... and remove some SCSIDevice variables or fields that now become unused.
Signed-off-by: Paolo Bonzini
---
hw/esp.c |2 +-
hw/lsi53c895a.c |2 +-
hw/scsi-bus.c|5 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |8 ++--
hw/usb-msd.c |2 +-
6 files chan
With the next patch, a device may hold SCSIRequest for an indefinite
time. Split a rather big patch, and protect against access errors,
by reference counting them. One such access error in fact exists (it
is visible by testing the lsi driver with MALLOC_PERTURB_), and this
patch provides the infr
Signed-off-by: Paolo Bonzini
---
hw/esp.c | 26 ++
hw/lsi53c895a.c | 22 --
hw/scsi-bus.c| 10 ++
hw/scsi.h|1 +
hw/spapr_vscsi.c | 26 ++
hw/usb-msd.c | 15 ---
trace-ev
This is for when the request must be dropped in the void,
but still memory should be freed. To this end, the devices
register a second callback in SCSIBusOps.
Signed-off-by: Paolo Bonzini
Signed-off-by: Jonathan Nieder
---
hw/esp.c | 16 ++--
hw/lsi53c895a.c | 33 +++
The return value is unused anyway.
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c|6 ++
hw/scsi-generic.c |7 ++-
hw/scsi.h |2 +-
3 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 65744c7..4c7a53e 100644
--- a/
From: Hannes Reinecke
The get_sense callback copies existing sense information into
the provided buffer. This is required if sense information
should be transferred together with the command response.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |9 +++
Signed-off-by: Paolo Bonzini
---
hw/esp.c | 60 +---
hw/lsi53c895a.c | 48 +++---
hw/scsi-bus.c|4 +-
hw/scsi.h|9 +
hw/spapr_vscsi.c | 101 ++
hw/usb-msd.c
From: Hannes Reinecke
scsi_req_parse() already provides for a data direction setting,
so we should be using it to check for correct direction.
And we should return the sense code 'INVALID FIELD IN CDB'
in these cases.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
---
hw/scsi-dis
The sg driver currently has a hardcoded limit of commands it
can handle simultaneously. When this limit is reached the
driver will return -EDOM. So we need to capture this to
enable proper return values here.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
---
hw/scsi-generic.c |
On 17 May 2011 07:44, Jan Kiszka wrote:
> On 2011-05-17 03:38, andrzej zaborowski wrote:
>> On 16 May 2011 15:08, Dmitry Eremin-Solenikov wrote:
>>> On 5/16/11, andrzej zaborowski wrote:
On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote:
> Socket is required, as we have to know the Q
Hi Hans,
On Tue, May 03, 2011 at 01:03:40PM +0200, Hans de Goede wrote:
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index a13599d..e9e8d54 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -950,7 +950,7 @@ static int kvm_get_xsave(CPUState *env)
> @@ -966,7 +966,7 @@ stati
On 2011-05-17 13:08, andrzej zaborowski wrote:
> On 17 May 2011 07:44, Jan Kiszka wrote:
>> On 2011-05-17 03:38, andrzej zaborowski wrote:
>>> On 16 May 2011 15:08, Dmitry Eremin-Solenikov wrote:
On 5/16/11, andrzej zaborowski wrote:
> On 16 May 2011 06:54, Dmitry Eremin-Solenikov
>>>
No flag to configure is required. Instead, added a libcacard.la target that
is not built by default, only when requested explicitly via:
mkdir build
cd build
../configure
make libcacard.la
make install-libcacard
Uses libtool to do actual linking of object files and shared library, and
installing.
On Tue, May 17, 2011 at 03:03:45PM +0300, Alon Levy wrote:
Forgot to mention this is the v3, with the following fixes:
* no warning, properly use libtool to wrap dtrace (which calls gcc).
* tested with all tracing backends but ust (and in the process of testing that)
* moved general rule for pr
Fix a bug in the linux-user ELF loader code where it was not correctly
handling images where the lowest vaddr to be loaded was not page aligned.
The problem was that the code to probe for a suitable guest base address
was changing the 'loaddr' variable (by rounding it to a page boundary),
which mea
On 05/17/11 01:20, Gerd Hoffmann wrote:
>> On 05/16/11 13:56, Gerd Hoffmann wrote:
>>> This patch finally merges the EHCI host adapter aka USB 2.0 support.
>>>
>>> Based on git://git.kiszka.org/qemu.git ehci
>>>
>>> Changes:
>>>- Adapt to recent changes in the usb subsystem.
>>>- Don't cr
On 12.05.2011, at 10:50, Christian Borntraeger wrote:
>> I'd definitely prefer that over the change on vl.c :)
>
> the s390 memory detection has a 16bit field that specifies the amount of
> increments. This patch adopts the memory size to always fit into that
> scheme. This also fixes virtio det
On 15.05.2011, at 18:41, Alexey Zaytsev wrote:
> Hi again.
>
> After reverting 667bb59, ahci works fine in Linux, if I boot it with
> -kernel, but grub seems to have some problems.
> Grub2 gets to the rescue prompt. The disk and its partitions seem to
> be detected correctly, but not the filesys
Hi,
As someone who spent a significant amount of time working on the EHCI
code last year I am absolutely not ok with this. The entire contribution
history for EHCI lost - and for no reason.
There is a reason. I've tried to keep the history, but it was a big
mess with conflicts and build err
On 05/17/11 06:42, David Ahern wrote:
>
>
> On 05/17/11 01:20, Gerd Hoffmann wrote:
>>> On 05/16/11 13:56, Gerd Hoffmann wrote:
This patch finally merges the EHCI host adapter aka USB 2.0 support.
Based on git://git.kiszka.org/qemu.git ehci
Changes:
- Adapt to r
On Tue, May 17, 2011 at 09:15:39AM +0200, Jan Kiszka wrote:
> On 2011-05-16 23:55, Adnan Khaleel wrote:
> > I finally got this work after I realised that the AHCI driver was not being
> > loaded in my disk image and that ACHI was not being enabled in the Seabios
> > .config file.
> > This is real
On 17.05.2011, at 15:16, Alexander Graf wrote:
>
> On 12.05.2011, at 10:50, Christian Borntraeger wrote:
>
>>> I'd definitely prefer that over the change on vl.c :)
>>
>> the s390 memory detection has a 16bit field that specifies the amount of
>> increments. This patch adopts the memory size t
Hi,
+
On 17.05.2011, at 15:46, Alexander Graf wrote:
>
> On 15.05.2011, at 18:41, Alexey Zaytsev wrote:
>
>> Hi again.
>>
>> After reverting 667bb59, ahci works fine in Linux, if I boot it with
>> -kernel, but grub seems to have some problems.
>> Grub2 gets to the rescue prompt. The disk and it
On 17.05.2011, at 16:07, René Rebe wrote:
> Hi,
> +
> On 17.05.2011, at 15:46, Alexander Graf wrote:
>
>>
>> On 15.05.2011, at 18:41, Alexey Zaytsev wrote:
>>
>>> Hi again.
>>>
>>> After reverting 667bb59, ahci works fine in Linux, if I boot it with
>>> -kernel, but grub seems to have some pr
On 05/17/11 07:46, Gerd Hoffmann wrote:
>
> Hi,
>
As someone who spent a significant amount of time working on the EHCI
code last year I am absolutely not ok with this. The entire
contribution
history for EHCI lost - and for no reason.
>>>
>>> There is a reason. I've trie
On 2011-05-17 15:57, Isaku Yamahata wrote:
> On Tue, May 17, 2011 at 09:15:39AM +0200, Jan Kiszka wrote:
>> On 2011-05-16 23:55, Adnan Khaleel wrote:
>>> I finally got this work after I realised that the AHCI driver was not being
>>> loaded in my disk image and that ACHI was not being enabled in t
Hi! I was wondering why qemu-img consumes so much CPU when it converts
one partially allocated qcow2 image to another qcow2 image and I've
written a patch which improves the situation a little.
I have an image:
> $ qemu-img info ubuntu.10.04.qcow2
> image: ubuntu.10.04.qcow2
> file format: qcow2
>
Hi,
Right, you did not even try to work with Jan's tree. There is no reason
the EHCI code could not have been brought in to qemu that way.
The usual way to review & merge code is to send a patch series against
recent master to qemu-devel, optionally with a git tree to pull from.
So I tried
On 05/14/2011 12:36 PM, Blue Swirl wrote:
> Simplify cpu-exec.c by refactoring.
>
> Signed-off-by: Blue Swirl
Signed-off-by: Richard Henderson
This ought to go in no matter what happens with the rest.
r~
On 05/14/2011 12:37 PM, Blue Swirl wrote:
> tb_invalidate_page_range() was intended to be used to invalidate an area of a
> TB
> which the guest explicitly flushes from i-cache. However, QEMU detects writes
> to code areas where TBs have been generated, so this has never been useful.
>
> Delete t
Thanks for tracking this down!
On 14 May 2011 20:36, Blue Swirl wrote:
> +#if defined(__i386__)
> +#elif defined(__x86_64__)
> +#elif defined(_ARCH_PPC)
> +#elif defined(__alpha__)
> +#elif defined(__sparc__)
> +#elif defined(__arm__)
> +#elif defined(__mc68000)
> +#elif defined(__ia64)
> +#elif defined(__s390__)
> +#
> Thanks for tracking this down!
Indeed, thanks a lot for the very fast action on this.
--
Gustavo Niemeyer
http://niemeyer.net
http://niemeyer.net/blog
http://niemeyer.net/twitter
On 05/14/2011 12:37 PM, Blue Swirl wrote:
> Delegate TCG temp_buf setup to targets, so that they can use a stack
> frame later instead.
>
> Signed-off-by: Blue Swirl
Reviewed-by: Richard Henderson
I think this sub-series moving TCG temps to the stack frame should
go in. We can tidy up the ot
On 05/14/2011 12:38 PM, Blue Swirl wrote:
> size_t is unsigned, so the frame offset calculations can be incorrect for
> negative offsets.
>
> Signed-off-by: Blue Swirl
Reviewed-by: Richard Henderson
r~
On 05/14/2011 12:38 PM, Blue Swirl wrote:
> -frame_size = push_size + TCG_STATIC_CALL_ARGS_SIZE;
> +frame_size = push_size + TCG_STATIC_CALL_ARGS_SIZE +
> +CPU_TEMP_BUF_NLONGS * sizeof(long);
> frame_size = (frame_size + TCG_TARGET_STACK_ALIGN - 1) &
> ~(TCG_TARGET_STA
Hi,
(And by the way, where are the focused patches for each, especially the
last one - nuking the 8kHz code?
It's squashed in, like everything else.
We know that it worked on linux and
that printers, scanners and storage devices worked ok (mostly).
8 kHz is insane.
I looked closely whil
Minutes of today KVM call:
- import of headers
in marcelo hands through kvm tree
- libtool integration
* autoconf
* gnulib -> if we move to glib, we have something similar for free
* recursive Makefile
Paolo item: propose timeline & plan on wiki, and discuss from there
- SCSI integratio
Hi,
I' m glad to submit my first patches to the QEMU-devel list.
This set of patches improves SPARC handling of trap and the shutdown
capability on trap 0.
Regards,
Fabien Chouteau (1) :
Improve sparc handling of ta
Julien Grall (1) :
Fix TA0_SHUTDOWN feature
target-sparc/helper.h |
Improve sparc handling of ta
Signed-off-by: Julien Grall
---
target-sparc/helper.h | 1 +
target-sparc/op_helper.c | 6 ++
target-sparc/translate.c | 7 ---
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/target-sparc/helper.h b/target-sparc/helper.h
index 12e
Fix TA0_SHUTDOWN feature
Signed-off-by: Julien Grall
---
target-sparc/op_helper.c | 13 +++--
target-sparc/translate.c |9 +
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c
index a6fabad..cb775f5 100644
--
On Tue, May 17, 2011 at 3:33 PM, Dmitry Konishchev wrote:
> Hi! I was wondering why qemu-img consumes so much CPU when it converts
> one partially allocated qcow2 image to another qcow2 image and I've
> written a patch which improves the situation a little.
Please see http://wiki.qemu.org/Contrib
On Mon, May 16, 2011 at 04:10:21PM -0500, Anthony Liguori wrote:
> To further clarify:
>
> Today cache=none|writethrough|writeback does two things. It:
>
> 1) Changes the WCE flag that's visible to the guest
>
> 2) Determines whether the host page cache is used for doing guest I/O
>
> As Christoph
On 05/15/2011 07:13 AM, Aurelien Jarno wrote:
> +temp = floatx80_add(ST0, floatx80_one, &env->fp_status);
> +if (!floatx80_is_neg(temp)) {
> +temp = floatx80_add(ST0, floatx80_one, &env->fp_status);
> +temp = floatx80_log2(temp, &env->fp_status);
> +ST1 = floatx80_mu
Change BDRV_O_NOCACHE to only imply bypassing the host OS file cache,
but no writeback semantics. All existing callers are changed to also
specify BDRV_O_CACHE_WB to give them writeback semantics.
Signed-off-by: Christoph Hellwig
Index: qemu/block.c
=
If an op with dead outputs is not removed, because it has side effects
or has multiple output arguments and only one dead, mark the TCG
registers as dead instead of keeping them allocated. This avoid a few
register spills on TCG targets with low register count, especially with
div2 and mul2 ops,
Allow all args to be dead by replacing the input specific op_dead_iargs
variable by op_dead_args. Note this is a purely mechanical change.
Signed-off-by: Aurelien Jarno
---
tcg/tcg.c | 71 +++--
tcg/tcg.h |4 +-
2 files changed, 38 in
This patch series is a first attempt after the TCG_AREG0 discussion to
show it's possible to easily (at least without making huge changes to
the TCG core code) spare some registers and avoid a few spills on low
register count TCG targets like i386.
On i386 hosts some TB are reduced by up to 10%, t
If an op is not removed and has dead output arguments, mark it
in op_dead_args similarly to what is done for input arguments.
Signed-off-by: Aurelien Jarno
---
tcg/tcg.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 9a48cb9..82d3e1d
Looks like you haven't updated this one for the last round of review,
yet.
Gerd Hoffmann writes:
> The device path isn't just a number. It specifies the physical port
> the device is connected to and in case the device is connected via
> usb hub you'll have two numbers there, like this: "5.1".
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/acpi_piix4.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 96f5222..03d833a 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -317,13 +317,9 @@
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/grackle_pci.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/grackle_pci.c b/hw/grackle_pci.c
index d35701f..7a5221c 100644
--- a/hw/grackle_pci.c
+++ b/hw/grackle_pci.c
@@ -104,11 +104,
vender id/device id... in pci configuration space are read-only registers
which are commonly defined for all pci devices.
So initialize them in common code and it simplifies the initialization a bit.
I didn't converted virtio-pci and qxl because it determines ids dynaically.
So I'll leave those con
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/bonito.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/bonito.c b/hw/bonito.c
index 65a4a63..e8c57a3 100644
--- a/hw/bonito.c
+++ b/hw/bonito.c
@@ -691,11 +691,7 @@ static int bonito_i
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/intel-hda.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/intel-hda.c b/hw/intel-hda.c
index 5485745..0ce 100644
--- a/hw/intel-hda.c
+++ b/hw/intel-hda.c
@@ -1138,10 +1138,6 @@ sta
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/xio3130_downstream.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/xio3130_downstream.c b/hw/xio3130_downstream.c
index 5aa6a6b..d3c387d 100644
--- a/hw/xio3130_downstream.c
+++ b/hw/xio3
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/gt64xxx.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c
index c66188f..8e1f6a0 100644
--- a/hw/gt64xxx.c
+++ b/hw/gt64xxx.c
@@ -1118,14 +1118,10 @@ static int g
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/rtl8139.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index c7c7a3c..34e3a9e 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
@@ -3453,10 +3453,6 @@ static int pc
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/wdt_i6300esb.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c
index 0791721..bd57fd3 100644
--- a/hw/wdt_i6300esb.c
+++ b/hw/wdt_i6300esb.c
@@ -400,9 +40
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/xio3130_upstream.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/xio3130_upstream.c b/hw/xio3130_upstream.c
index a7640f5..8283695 100644
--- a/hw/xio3130_upstream.c
+++ b/hw/xio3130_upst
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/lsi53c895a.c | 17 -
1 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index be4df58..af87b2c 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -2212,15
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/vmware_vga.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index 4656767..354c221 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -1280,15 +128
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/sh_pci.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sh_pci.c b/hw/sh_pci.c
index e99d8db..a076cf2 100644
--- a/hw/sh_pci.c
+++ b/hw/sh_pci.c
@@ -137,8 +137,6 @@ static int sh_pci_init_de
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/ide/cmd646.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
index 5d5464a..56302b5 100644
--- a/hw/ide/cmd646.c
+++ b/hw/ide/cmd646.c
@@ -226,14 +226,8 @
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/dec_pci.c | 26 +++---
1 files changed, 7 insertions(+), 19 deletions(-)
diff --git a/hw/dec_pci.c b/hw/dec_pci.c
index bf88f2a..a35f382 100644
--- a/hw/dec_pci.c
+++ b/hw/dec_pci.c
@@ -50,28 +50,16
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/ac97.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/hw/ac97.c b/hw/ac97.c
index d71072d..bf1d1d4 100644
--- a/hw/ac97.c
+++ b/hw/ac97.c
@@ -1281,9 +1281,6 @@ static int ac97_initfn (PCID
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/e1000.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index f160bfc..96d84f9 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1164,12 +1164,8 @@ static int pci_e1000_in
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/cirrus_vga.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 722cac7..e239e21 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -3097,7 +3097,6 @@
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/qxl.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index fe4212b..63cffc3 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1233,7 +1233,6 @@ static int qxl_init_common(PCIQXLDe
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/ivshmem.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/ivshmem.c b/hw/ivshmem.c
index 7b19a81..3055dd2 100644
--- a/hw/ivshmem.c
+++ b/hw/ivshmem.c
@@ -706,12 +706,7 @@ static int pci_
use PCIDeviceInfo to initialize ids.
Signed-off-by: Isaku Yamahata
---
hw/ioh3420.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/ioh3420.c b/hw/ioh3420.c
index 95adf09..a6bfbb9 100644
--- a/hw/ioh3420.c
+++ b/hw/ioh3420.c
@@ -104,12 +104,8 @@ static int ioh34
1 - 100 of 241 matches
Mail list logo
