Re: [Qemu-devel] [RESEND][PATCH 3/9] microdrive: qdevify

2011-05-16 Thread andrzej zaborowski
On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote: > Hello, > > On 5/16/11, andrzej zaborowski wrote: >> On 25 April 2011 11:06, Dmitry Eremin-Solenikov >> wrote: >>> Switch dscm1 microdrive driver to use qdev infrastructure. >>> --- >>>  hw/ide/microdrive.c |   49 >>>

[Qemu-devel] [PATCH] qed: support for growing images

2011-05-16 Thread Stefan Hajnoczi
The .bdrv_truncate() operation resizes images and growing is easy to implement in QED. Simply check that the new size is valid and then update the image_size header field to reflect the new size. Signed-off-by: Stefan Hajnoczi --- block/qed.c | 22 +- 1 files changed, 21 i

[Qemu-devel] [PATCH][qemu-iotests] add qed support to 025 image resize test

2011-05-16 Thread Stefan Hajnoczi
QED now supports the truncate (aka resize) operation for growing images. Update test 025 so it runs for QED. Signed-off-by: Stefan Hajnoczi --- 025 |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/025 b/025 index 691b6da..7062aa6 100755 --- a/025 +++ b/025 @@ -39,7 +39,7

[Qemu-devel] [PATCH v4 6/6] block: Remove type hint, it's guest matter, doesn't belong here

2011-05-16 Thread Markus Armbruster
No users of bdrv_get_type_hint() left. bdrv_set_type_hint() can make the media removable by side effect. Make that explicit. Signed-off-by: Markus Armbruster --- block.c | 12 block.h |5 - block_int.h |1 - blockdev.c |4 ++-- 4 files changed, 2 inserti

[Qemu-devel] [PATCH v4 4/6] block QMP: Deprecate query-block's "type", drop info block's "type="

2011-05-16 Thread Markus Armbruster
query-block's specification documents response member "type" with values "hd", "cdrom", "floppy", "unknown". Its value is unreliable: a block device used as floppy has type "floppy" if created with if=floppy, but type "hd" if created with if=none. That's because with if=none, the type is at best

[Qemu-devel] [PATCH v4 5/6] blockdev: Store -drive option media in DriveInfo

2011-05-16 Thread Markus Armbruster
DriveInfo is closely tied to -drive, and like -drive, it mixes information about host and guest part of the block device. Unlike DriveInfo, BlockDriverState should be about the host part only. One of the remaining guest bits there is the "type hint". -drive option media sets it, and qdevs "ide-d

[Qemu-devel] [PATCH v4 2/6] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd"

2011-05-16 Thread Markus Armbruster
A "scsi-disk" is either a hard disk or a CD-ROM, depending on the associated BlockDriverState's type hint. Unclean; disk vs. CD belongs to the guest part, not the host part. Have separate qdevs "scsi-hd" and "scsi-cd" to model disk vs. CD in the guest part. Keep scsi-disk for backward compatibil

[Qemu-devel] [PATCH v4 3/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM

2011-05-16 Thread Markus Armbruster
ide-hd does *not* suppress the default CD-ROM, unlike legacy ide-drive. scsi-cd *does* suppress it, unlike legacy scsi-disk. Signed-off-by: Markus Armbruster --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index bffba69..e271c0b 100644 --- a/vl.c +

[Qemu-devel] [PATCH v4 0/6] Split ide-drive and scsi-disk qdevs, and more

2011-05-16 Thread Markus Armbruster
This patch series is about purging the "type hint" from the block layer. My previous series cleaned up improper uses it. Remaining uses are info block and qdevs ide-drive, scsi-disk. ide-drive and scsi-disk can either act as disk or as CD drive. They use their drive's type hint to decide betwee

[Qemu-devel] [PATCH v4 1/6] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd"

2011-05-16 Thread Markus Armbruster
An "ide-drive" is either a hard disk or a CD-ROM, depending on the associated BlockDriverState's type hint. Unclean; disk vs. CD belongs to the guest part, not the host part. Have separate qdevs "ide-hd" and "ide-cd" to model disk vs. CD in the guest part. Keep ide-drive for backward compatibili

Re: [Qemu-devel] [RESEND][PATCH 3/9] microdrive: qdevify

2011-05-16 Thread Dmitry Eremin-Solenikov
On 5/16/11, andrzej zaborowski wrote: > On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote: >> Hello, >> >> On 5/16/11, andrzej zaborowski wrote: >>> On 25 April 2011 11:06, Dmitry Eremin-Solenikov >>> wrote: Switch dscm1 microdrive driver to use qdev infrastructure. --- hw

[Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
No flag to configure is required. Instead, added a libcacard.la target that is not built by default, only when requested explicitly via: mkdir build cd build ../configure make libcacard.la make install-libcacard Uses libtool to do actual linking of object files and shared library, and installing.

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Anthony Liguori
On 05/16/2011 08:25 AM, Alon Levy wrote: No flag to configure is required. Instead, added a libcacard.la target that is not built by default, only when requested explicitly via: mkdir build cd build ../configure make libcacard.la make install-libcacard Uses libtool to do actual linking of objec

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 03:28 PM, Anthony Liguori wrote: *** Warning: Linking the shared library libcacard.la against the non-libtool *** objects ../trace-dtrace.o is not portable! I don't think slipping in libtool like this is such a good idea. I disagree but, the warning is indeed legitimate,

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-16 Thread Markus Armbruster
Rob Landley writes: > On 05/13/2011 07:19 AM, Markus Armbruster wrote: >> Rob Landley writes: >> >>> On 05/13/2011 01:54 AM, Markus Armbruster wrote: Rob Landley writes: > On 05/12/2011 09:10 AM, Markus Armbruster wrote: >> Rob Landley writes: >> >>> In 1.14.0, if I

Re: [Qemu-devel] KVM Forum 2011: Call For Participation

2011-05-16 Thread Dor Laor
The abstract submission deadline was originally set for today. The forum committee agreed to extend the deadline period until next Sunday, May 22. The notification date remains the same (May 31). Thanks, your KVM Forum 2011 Program Committee On 04/21/2011 08:21 PM, kvm-forum-2011...@redhat.

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 03:59:53PM +0200, Paolo Bonzini wrote: > On 05/16/2011 03:28 PM, Anthony Liguori wrote: > >> > >> > >> *** Warning: Linking the shared library libcacard.la against the > >>non-libtool > >> *** objects ../trace-dtrace.o is not portable! > > > >I don't think slipping in lib

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 08:28:49AM -0500, Anthony Liguori wrote: > On 05/16/2011 08:25 AM, Alon Levy wrote: > >No flag to configure is required. Instead, added a libcacard.la target that > >is not built by default, only when requested explicitly via: > > > >mkdir build > >cd build > >../configure >

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 07:37 PM, Alon Levy wrote: I've settled on libtool as the linker solution since it seems to be the de facto standard, please correct me on this point if I'm wrong. We are not using autoconf, so I've called it directly in it's various modes, compile, link and install. I agree. I d

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 04:44:03PM +0200, Paolo Bonzini wrote: > On 05/16/2011 07:37 PM, Alon Levy wrote: > >I've settled on libtool > >as the linker solution since it seems to be the de facto standard, please > >correct me on this point if I'm wrong. We are not using autoconf, so > >I've called it

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Kevin Wolf
Hi Jonathan, Am 16.05.2011 13:23, schrieb Jonathan Nieder: > Hi, > > Kevin Wolf wrote: > >> This pulls the request completion for error cases from the caller to >> scsi_disk_emulate_command. This should not change semantics, but allows to >> reuse scsi_handle_write_error() for flushes in the nex

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Kevin Wolf wrote: > I also reviewed the patch that you mentioned and I can't find anything > suspicious there. I'm afraid you'll have to bite the bullet and run it > with some debugging code yourself (if it's really related to that patch, > you'll want to enable DPRINTF in hw/scsi-disk.c as a firs

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Kevin Wolf wrote: > Your instructions seemed clear enough, so I tried to reproduce your > problem. Now I have an ARM VM with a Debian installation that works just > fine and I have no idea what to use it for. ;-) So I was puzzled about this for a while, but then I had a flash of inspiration:

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Kevin Wolf
Am 16.05.2011 17:43, schrieb Jonathan Nieder: > Kevin Wolf wrote: > >> Your instructions seemed clear enough, so I tried to reproduce your >> problem. Now I have an ARM VM with a Debian installation that works just >> fine and I have no idea what to use it for. ;-) > > So I was puzzled about this

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Paul Brook
> > I just spoke with Paul on IRC about this. In summary: > > * for a helper to cause an exception then it has (a) to make sure CPU > > > > state (pc, condflags) is sync'd before the call to the helper and (b) > > the helper has to be in a file with access to global env, because it > > needs to ca

Re: [Qemu-devel] TCG: AREG0 removal planning

2011-05-16 Thread Paul Brook
> > For changes to > > the TCG side we want to consider how we can provide useful aliasing > > information, rather than a naive replacement of TCG_AREG0 with a > > variable. > > What aliasing information? Aliasing of cpu state accesses between tcg_global_mem_new_* variables, qemu_ld/st ops, and

Re: [Qemu-devel] AHCI broken in current git, bisected.

2011-05-16 Thread Anthony Liguori
On 05/15/2011 03:03 PM, Michael S. Tsirkin wrote: On Sun, May 15, 2011 at 10:20:23PM +0300, Michael S. Tsirkin wrote: On Sun, May 15, 2011 at 07:14:42PM +0200, Jan Kiszka wrote: Pity I missed this the first time. Thanks! Ah, I see, I didn't miss it, just back from vacation and didn't get so f

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 05:58 PM, Kevin Wolf wrote: > Thanks. Still doesn't make much sense to me, the patch shouldn't change > anything with respect to a malloc, but I can reproduce a segfault now. I > think I'll have a closer look tomorrow. This fixes it on top of my SCSI refactoring series. Should I sen

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Peter Maydell
On 16 May 2011 17:10, Paul Brook wrote: >> > I just spoke with Paul on IRC about this. In summary: >> >  * for a helper to cause an exception then it has (a) to make sure CPU >> > >> > state (pc, condflags) is sync'd before the call to the helper and (b) >> > the helper has to be in a file with ac

[Qemu-devel] segfault with VNC and --enable-debug

2011-05-16 Thread Anthony PERARD
Hi, I found a segfault when I use VNC with qemu compiled with --enable-debug. Without debug mode, that works fine. The segfault happen usualy when the debian (guest) is ready to be used, or a little bit after I'm logged in, in console mode. Here is few detail: HEAD 711c212 Merge remote-tracking

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Aurelien Jarno
On Mon, May 16, 2011 at 05:37:03PM +0100, Peter Maydell wrote: > On 16 May 2011 17:10, Paul Brook wrote: > >> > I just spoke with Paul on IRC about this. In summary: > >> >  * for a helper to cause an exception then it has (a) to make sure CPU > >> > > >> > state (pc, condflags) is sync'd before t

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Aurelien Jarno
On Mon, May 16, 2011 at 10:59:47AM +0100, Peter Maydell wrote: > On 14 May 2011 22:32, Aurelien Jarno wrote: > > On Fri, May 06, 2011 at 03:32:27PM +0100, Peter Maydell wrote: > >> I just spoke with Paul on IRC about this. In summary: > >>  * for a helper to cause an exception then it has (a) to m

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Peter Maydell
On 16 May 2011 18:29, Aurelien Jarno wrote: > On Mon, May 16, 2011 at 05:37:03PM +0100, Peter Maydell wrote: >> You can do this by calling GETPC() from the top level helper function >> though, right? [OK, we'd need to move the definition out of dyngen-exec.h.] > > No we don't need to move it out o

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Peter Maydell
On 16 May 2011 18:29, Aurelien Jarno wrote: > That said given this patch is more or less an extension of an existing > code, we may want to apply it anyway. That is the conclusion I'm hoping to persuade you to, yes :-) -- PMM

[Qemu-devel] Regression "Warning: more nics requested than this machine supports"

2011-05-16 Thread Markus Armbruster
Watch this: $ qemu-system-x86_64 -nodefaults -enable-kvm -m 384 -vnc :0 -S -netdev user,id=net0 -device e1000,netdev=net0 Warning: more nics requested than this machine supports; some have been ignored (qemu) info network Devices not on any VLAN: net0: net=10.0.2.0, restric

[Qemu-devel] [RFC Patch 0/3]Qemu: Enable dynamic cache change through qemu monitor

2011-05-16 Thread Supriya Kannery
 Currently cache setting of a block device cannot be changed without restarting a running VM. Following patchset is for enabling dynamic change of cache setting for block devices through qemu monitor. Code changes are based on patches from Christoph Hellwig and Prerna Saxena. Monitor command

[Qemu-devel] [RFC Patch 1/3]Qemu: Enhance "info block" to display cache setting

2011-05-16 Thread Supriya Kannery
Enhance "info block" to display cache setting Example: (qemu) info block ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypted=0 Enhanced to include "cache" setting: (qemu) info block ide0-hd0: type=hd removable=0 cache=none file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypte

[Qemu-devel] [RFC Patch 2/3]Qemu: New error classes for file reopen and device insertion

2011-05-16 Thread Supriya Kannery
New errors defined for device insertion and file reopen Signed-off-by: Supriya Kannery --- qerror.c |8 qerror.h |6 ++ 2 files changed, 14 insertions(+) Index: qemu/qerror.c === --- qemu.orig/qerror.c +++ qem

[Qemu-devel] [RFC Patch 3/3]Qemu: Add command "cache_set" for dynamic cache change

2011-05-16 Thread Supriya Kannery
Add monitor command "cache_set" for dynamic cache change Signed-off-by: Christoph Hellwig Signed-off-by: Supriya Kannery --- block.c | 53 + block.h |2 ++ blockdev.c | 20 blockdev.h |

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Aurelien Jarno
On Mon, May 16, 2011 at 06:47:42PM +0100, Peter Maydell wrote: > On 16 May 2011 18:29, Aurelien Jarno wrote: > > On Mon, May 16, 2011 at 05:37:03PM +0100, Peter Maydell wrote: > >> You can do this by calling GETPC() from the top level helper function > >> though, right? [OK, we'd need to move the

Re: [Qemu-devel] BUG: 0.14.0 -device usb-host supports only one device

2011-05-16 Thread Erik Rull
Gerd Hoffmann wrote: Hi, When enabling the -device usb-host option support for adding automatically USB devices from the host to the guest, only one device gets detected. Yes. -device usb-host creates a *single* virtual usb device instance. When a matching device on the host is found the vi

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Paolo Bonzini wrote: > This fixes it on top of my SCSI refactoring series. Thanks! Works here, too, for what it's worth. I squashed the following in when applying the "scsi: introduce scsi_req_cancel" patch, for easier reading and to get a little closer to warning-free compilation with gcc 4.6.

[Qemu-devel] [PATCH v3] Add an isa device for SGA

2011-05-16 Thread Glauber Costa
This patch adds a dummy legacy ISA device whose responsibility is to deploy sgabios, an option rom for a serial graphics adapter. The proposal is that this device is always-on when -nographics, but can otherwise be enable in any setup when -device sga is used. [v2: suggestions on qdev by Markus ]

Re: [Qemu-devel] KVM call agenda for May 17th

2011-05-16 Thread Anthony Liguori
On 05/16/2011 07:17 AM, Paolo Bonzini wrote: On 05/16/2011 12:07 PM, Juan Quintela wrote: From two weeks ago, we have already: - import kvm headers into qemu, drop #ifdef maze (Jan) SCSI patches merge plan - libtool usage Regards, Anthony Liguori Paolo

Re: [Qemu-devel] TCG: AREG0 removal planning

2011-05-16 Thread Blue Swirl
On Mon, May 16, 2011 at 7:16 PM, Paul Brook wrote: >> > For changes to >> > the TCG side we want to consider how we can provide useful aliasing >> > information, rather than a naive replacement of TCG_AREG0 with a >> > variable. >> >> What aliasing information? > > Aliasing of cpu state accesses b

[Qemu-devel] [PATCH 00/18] usb patch queue: add usb 2.0

2011-05-16 Thread Gerd Hoffmann
Hi, Here is the current usb patch queue. Patches 1-9 have been on the list already, the other ones are new. I plan to send a pull request for this stuff next week. The major new feature added is USB 2.0 support: A bunch of fixes and improvements for the usb passthrough code. The EHCI host a

[Qemu-devel] [PATCH 06/18] usb: Pass the packet to the device's handle_control callback

2011-05-16 Thread Gerd Hoffmann
From: Hans de Goede This allows using the generic usb_generic_handle_packet function from device code which does ASYNC control requests (such as the linux host pass through code). Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/bt-hid.c |6 +++--- hw/usb-bt.c |

[Qemu-devel] [PATCH 01/18] usb: Add Interface Association Descriptor descriptor type

2011-05-16 Thread Gerd Hoffmann
From: Brad Hards Signed-off-by: Brad Hards Signed-off-by: Gerd Hoffmann --- hw/usb.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index 7e46141..ca06bf8 100644 --- a/hw/usb.h +++ b/hw/usb.h @@ -124,6 +124,7 @@ #define USB_DT_ENDPOINT

[Qemu-devel] [PATCH 11/18] usb-linux: walk async urb list in cancel

2011-05-16 Thread Gerd Hoffmann
Lookup async urbs which are to be canceled using the linked list instead of the direct opaque pointer. There are two reasons we are doing that: First, to avoid the opaque poiner to the callback, which is needed for upcoming cleanups. Second, because we might need multiple urbs per request for hi

[Qemu-devel] [PATCH 03/18] usb: remove fallback to bNumInterfaces if no .nif

2011-05-16 Thread Gerd Hoffmann
From: Brad Hards All callers have been updated. Signed-off-by: Brad Hards Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index 62591f2..a784155 100644 --- a/hw/usb-desc.c +++ b/hw/usb-de

[Qemu-devel] [PATCH 13/18] usb-linux: fix max_packet_size for highspeed.

2011-05-16 Thread Gerd Hoffmann
Calculate the max packet size correctly. Only bits 0..11 specify the size, bits 11+12 specify the number of (highspeed) microframes the endpoint wants to use. Signed-off-by: Gerd Hoffmann --- usb-linux.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PATCH 09/18] usb-linux: add hostport property

2011-05-16 Thread Gerd Hoffmann
This patch adds a hostport property which allows to specify the host usb devices to pass through by bus number and physical port. This means you can basically hand over one (or more) of the usb plugs on your host to the guest and whatever device is plugged in there will show up in the guest. Usag

[Qemu-devel] [PATCH 05/18] Bug #757654: UHCI fails to signal stall response patch

2011-05-16 Thread Gerd Hoffmann
From: Jan Vesely UHCI host controller status register indicates error and an interrupt is triggered on BABBLE and STALL errors. Signed-off-by: Jan Vesely Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/usb-uhci.c b/

[Qemu-devel] [PATCH 10/18] usb-linux: track aurbs in list

2011-05-16 Thread Gerd Hoffmann
This patch adds code to track all async urbs in a linked list, so we can find them without having to pass around a opaque pointer to them. Prerequisite for the cleanups. Signed-off-by: Gerd Hoffmann --- usb-linux.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) di

[Qemu-devel] [PATCH 14/18] usb: add usb_handle_packet

2011-05-16 Thread Gerd Hoffmann
Add a usb_handle_packet function, put it into use everywhere. Right now it just calls dev->info->handle_packet(), that will change in future patches though. Signed-off-by: Gerd Hoffmann --- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |4 ++-- hw/usb-uhci.c |2 +- hw/u

[Qemu-devel] [PATCH 08/18] usb-linux: fix device path aka physical port handling

2011-05-16 Thread Gerd Hoffmann
The device path isn't just a number. It specifies the physical port the device is connected to and in case the device is connected via usb hub you'll have two numbers there, like this: "5.1". The first specifies the root port where the hub is plugged into, the second specifies the port number of

[Qemu-devel] [PATCH 02/18] usb: update config descriptors to identify number of interfaces

2011-05-16 Thread Gerd Hoffmann
From: Brad Hards Previously we relied on the .bNumInterfaces, but that won't always be accurate after the introduction of grouped interfaces. Signed-off-by: Brad Hards Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c|3 +++ hw/usb-hub.c|1 + hw/usb-msd.c|2 ++ hw/usb-seri

[Qemu-devel] [PATCH 17/18] usb-storage: don't call usb_packet_complete twice

2011-05-16 Thread Gerd Hoffmann
usb_msd_copy_data() may cause a recursive call to usb_msd_command_complete() which in turn may complete the packet, setting s->packet to NULL in case it does. Recheck s->packet before calling usb_packet_complete() to fix the double call. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c |2 +- 1

[Qemu-devel] [PATCH 12/18] usb-linux: split large xfers

2011-05-16 Thread Gerd Hoffmann
Add support for splitting large transfers into multiple smaller ones. This is needed for the upcoming EHCI emulation which allows guests to submit requests up to 20k in size. The linux kernel allows 16k max size though. Roughly based on a patch from git://git.kiszka.org/qemu.git ehci Signed-off-

[Qemu-devel] [PATCH 16/18] usb: move cancel callback to USBDeviceInfo

2011-05-16 Thread Gerd Hoffmann
Remove the cancel callback from the USBPacket struct, move it over to USBDeviceInfo. Zap usb_defer_packet() which is obsolete now. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c |8 +++- hw/usb.c |2 +- hw/usb.h | 17 + usb-linux.c |7 +++ 4 files c

[Qemu-devel] [PATCH 04/18] usb: add support for "grouped" interfaces and the Interface Association Descriptor

2011-05-16 Thread Gerd Hoffmann
From: Brad Hards This is used for some devices that have multiple interfaces that form a logic device. An example is Video Class, which has a Control interface and a Streaming interface. There can be additional interfaces on the same (physical) devices (e.g. a microphone), and Interface Associati

[Qemu-devel] [PATCH 07/18] usb-linux: use usb_generic_handle_packet()

2011-05-16 Thread Gerd Hoffmann
From: Hans de Goede Make the linux usb host passthrough code use the usb_generic_handle_packet() function, rather then the curent DYI code. This removes 200 lines of almost identical code. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb.c| 41 +- hw/usb.h

[Qemu-devel] [PATCH 15/18] usb: keep track of packet owner.

2011-05-16 Thread Gerd Hoffmann
Keep track of the device which owns the usb packet for async processing. Signed-off-by: Gerd Hoffmann --- hw/usb.c | 32 hw/usb.h | 18 +++--- 2 files changed, 35 insertions(+), 15 deletions(-) diff --git a/hw/usb.c b/hw/usb.c index 966cb0f..8a9a

Re: [Qemu-devel] [PATCH 00/18] usb patch queue: add usb 2.0

2011-05-16 Thread Anthony Liguori
On 05/16/2011 02:56 PM, Gerd Hoffmann wrote: Hi, Here is the current usb patch queue. Patches 1-9 have been on the list already, the other ones are new. I plan to send a pull request for this stuff next week. The major new feature added is USB 2.0 support: A bunch of fixes and improvement

Re: [Qemu-devel] [RFC Patch 0/3]Qemu: Enable dynamic cache change through qemu monitor

2011-05-16 Thread Christoph Hellwig
Why are you even trying this again? As explained very clearly last time you can't change from a writeback-style to a write-through style I/O from the monitor without creating massive data integrity problems. See my patchset that allows changing this from the guest for how it should be done - I ju

Re: [Qemu-devel] [RFC Patch 0/3]Qemu: Enable dynamic cache change through qemu monitor

2011-05-16 Thread Anthony Liguori
On 05/16/2011 03:23 PM, Christoph Hellwig wrote: Why are you even trying this again? As explained very clearly last time you can't change from a writeback-style to a write-through style I/O from the monitor without creating massive data integrity problems. To further clarify: Today cache=none

Re: [Qemu-devel] [PATCH 00/26] q35 chipset support for native pci express support

2011-05-16 Thread Adnan Khaleel
I finally got this work after I realised that the AHCI driver was not being loaded in my disk image and that ACHI was not being enabled in the Seabios .config file. This is really good work Yamahata, thanks. As far as I can tell, everything works like the stock Qemu 0.14 except networking. The

[Qemu-devel] Debug Qemu dhcpd

2011-05-16 Thread Adnan Khaleel
I'm using Isaku Yamahata's q35 chipset model in Qemu0.14 and I'm trying to figure out why the Qemu dhcpd server is not responding back to the nic device in the guest OS when used with user mode networking. The guest OS sees the network device and initialises it but I think the Qemu DHCP server/f

Re: [Qemu-devel] [PATCH 2/3] target-mips:Support for Cavium-Octeon specific instructions

2011-05-16 Thread Andreas Färber
Am 29.04.2011 um 08:19 schrieb Khansa Butt: From f699dbfdca62c5af92d764673b2300131d26263e Mon Sep 17 00:00:00 2001 From: Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt > Date: Wed, 27 Apr 2011 16:08:16 +0500 Subject: [PATCH 2/3] target-mips:Support for Cavium-Octeon specific instructio

Re: [Qemu-devel] [RESEND][PATCH 3/9] microdrive: qdevify

2011-05-16 Thread andrzej zaborowski
On 16 May 2011 15:08, Dmitry Eremin-Solenikov wrote: > On 5/16/11, andrzej zaborowski wrote: >> On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote: >>> Socket is required, as we have to know the QBus before creating the >>> device on it. >> >> Let's skip the qbusification then.  It seems that q

Re: [Qemu-devel] [PATCH 12/18] usb-linux: split large xfers

2011-05-16 Thread David Ahern
On 05/16/11 13:56, Gerd Hoffmann wrote: > Add support for splitting large transfers into multiple smaller ones. > This is needed for the upcoming EHCI emulation which allows guests > to submit requests up to 20k in size. The linux kernel allows 16k > max size though. > > Roughly based on a patch

Re: [Qemu-devel] [RESEND][PATCH 3/9] microdrive: qdevify

2011-05-16 Thread Jan Kiszka
On 2011-05-17 03:38, andrzej zaborowski wrote: > On 16 May 2011 15:08, Dmitry Eremin-Solenikov wrote: >> On 5/16/11, andrzej zaborowski wrote: >>> On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote: Socket is required, as we have to know the QBus before creating the device on it. >>>

[Qemu-devel] [PATCH 1/3] pSeries: Clean up write-only variables

2011-05-16 Thread David Gibson
A few pieces of the pSeries emulation code have variables which are set but never used, which causes warnings on gcc 4.6. This patch removes these instances. Signed-off-by: David Gibson --- hw/spapr_hcall.c |7 +-- hw/spapr_llan.c |3 --- 2 files changed, 1 insertions(+), 9 deletio

[Qemu-devel] pSseries platform updates, cleanup and virtio support

2011-05-16 Thread David Gibson
Hi Alex, Here's a few more patches for the pSeries machine emulation. First there's a small cleanup / bugfix that removes warnings with gcc 4.6. Then there are two patches which add virtio support (as opposed to PAPR style VIO) to the pSeries platform. Please apply.

[Qemu-devel] [PATCH 2/3] virtio: Added function to calculate number of bytes required to allocate a VRing

2011-05-16 Thread David Gibson
From: Alexey Kardashevskiy The existing function virtio_queue_get_ring_size returns number of bytes for vring only when it is already initialized. In order to know how much memory new vring requires, new function virtio_queue_get_mem_size has been introduced. It is a copy of the vring_size funct

[Qemu-devel] [PATCH 3/3] powerpc-virtio: virtio support introduced (block, network, serial, balloon, 9p-fs), both fullemu and power-kvm

2011-05-16 Thread David Gibson
From: Alexey Kardashevskiy The recently added pseries machine does not currently support PCI emulation. For the (upcoming) kvm case, this is quite difficult to do because the preferred HV mode for the host kernel does not allow MMIO emulation (a hardware limitation). Therefore, to support virti

Re: [Qemu-devel] [PATCH 2/3] virtio: Added function to calculate number of bytes required to allocate a VRing

2011-05-16 Thread Alexander Graf
On 17.05.2011, at 08:47, David Gibson wrote: > From: Alexey Kardashevskiy > > The existing function virtio_queue_get_ring_size returns number of bytes > for vring only when it is already initialized. > > In order to know how much memory new vring requires, new function > virtio_queue_get_mem_s

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/15/2011 05:40 PM, Alon Levy wrote: -ln -s "$source_path/libcacard/Makefile" libcacard/Makefile +ln -s -f "$source_path/libcacard/Makefile" libcacard/Makefile Use the "symlink" function rather than ln -s -f for portability to broken platforms, please. Note that this requires lib

Re: [Qemu-devel] Why does -device qxl-vga not suppress default vga?

2011-05-16 Thread Gerd Hoffmann
On 05/13/11 16:18, Markus Armbruster wrote: VGA, cirrus-vga and vmware-svga do. Gerd, you added it (commit a19cbfb3), care to explain? Just forgot to add it to the list when merging. I'll go stuff a patch into the spice patch queue. Does "-device VGA" work these days btw? Last time I tries it

Re: [Qemu-devel] Why does -device qxl-vga not suppress default vga?

2011-05-16 Thread Jan Kiszka
On 2011-05-16 09:28, Gerd Hoffmann wrote: > On 05/13/11 16:18, Markus Armbruster wrote: >> VGA, cirrus-vga and vmware-svga do. Gerd, you added it (commit >> a19cbfb3), care to explain? > > Just forgot to add it to the list when merging. > I'll go stuff a patch into the spice patch queue. > > Doe

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-16 Thread Dor Laor
On 05/16/2011 12:38 AM, Jagane Sundar wrote: Hello Dor, One important advantage of live snapshot over live backup is support of multiple (consecutive) live snapshots while there can be only a single live backup at one time. This is why I tend to think that although live backup carry some benefi

Re: [Qemu-devel] Should new USB devices such as usb-ccid support legacy -usbdevice?

2011-05-16 Thread Gerd Hoffmann
On 05/13/11 18:47, Anthony Liguori wrote: On 05/13/2011 11:36 AM, Markus Armbruster wrote: When Gerd qdevified USB, he kept legacy -usbdevice working (commit 0958b4cc...). What about new USB devices? Should they get a legacy syntax, too? Any reason to do that? We already have a number of devi

Re: [Qemu-devel] Why is qdev vga-isa no_user?

2011-05-16 Thread Markus Armbruster
Blue Swirl writes: > On Fri, May 13, 2011 at 4:36 PM, Markus Armbruster wrote: >> Blue, you did the conversion (commit 7435b791), care to explain? > > Because I/O ports of VGA are fixed, so there can be only zero (which > is handled by -vga none) or one devices. Reason I'm asking: the other VGA

Re: [Qemu-devel] Why does -device qxl-vga not suppress default vga?

2011-05-16 Thread Markus Armbruster
Gerd Hoffmann writes: > On 05/13/11 16:18, Markus Armbruster wrote: >> VGA, cirrus-vga and vmware-svga do. Gerd, you added it (commit >> a19cbfb3), care to explain? > > Just forgot to add it to the list when merging. > I'll go stuff a patch into the spice patch queue. > > Does "-device VGA" work

Re: [Qemu-devel] [PATCH v2] Add an isa device for SGA

2011-05-16 Thread Brad Hards
On Thu, 12 May 2011 10:55:13 pm Glauber Costa wrote: > This patch adds a dummy legacy ISA device whose responsibility is to > deploy sgabios, an option rom for a serial graphics adapter. > The proposal is that this device is always-on when -nographics, > but can otherwise be enable in any setup whe

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-16 Thread Jagane Sundar
Hello Dor, Let me see if I understand live snapshot correctly: If I want to configure a VM for daily backup, then I would do the following: - Create a snapshot s1. s0 is marked read-only. - Do a full backup of s0 on day 0. - On day 1, I would create a new snapshot s2, then copy over the snapsho

Re: [Qemu-devel] Should new USB devices such as usb-ccid support legacy -usbdevice?

2011-05-16 Thread Markus Armbruster
Anthony Liguori writes: > On 05/13/2011 11:36 AM, Markus Armbruster wrote: >> When Gerd qdevified USB, he kept legacy -usbdevice working (commit >> 0958b4cc...). What about new USB devices? Should they get a legacy >> syntax, too? >> >> The only existing new device is usb-ccid, and it got one i

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Peter Maydell
On 14 May 2011 22:32, Aurelien Jarno wrote: > On Fri, May 06, 2011 at 03:32:27PM +0100, Peter Maydell wrote: >> I just spoke with Paul on IRC about this. In summary: >>  * for a helper to cause an exception then it has (a) to make sure CPU >> state (pc, condflags) is sync'd before the call to the

[Qemu-devel] KVM call agenda for May 17th

2011-05-16 Thread Juan Quintela
Please send in any agenda items you are interested in covering. >From two weeks ago, we have already: - import kvm headers into qemu, drop #ifdef maze (Jan) Thanks, Juan.

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 09:00:10AM +0200, Paolo Bonzini wrote: > On 05/15/2011 05:40 PM, Alon Levy wrote: > >-ln -s "$source_path/libcacard/Makefile" libcacard/Makefile > >+ln -s -f "$source_path/libcacard/Makefile" libcacard/Makefile > > Use the "symlink" function rather than ln -s -f for

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 12:25 PM, Alon Levy wrote: > Note that this requires libtool at build time rather than only for > maintainers. This is unlike all other software using it. However, > I believe this is not too bad given that a special make invocation > is required. I was under the impression t

Re: [Qemu-devel] Add option to disable Cocoa on Mac OS X

2011-05-16 Thread Ben Leslie
On Wed, May 11, 2011 at 23:54, Peter Maydell wrote: > On 7 May 2011 12:40, Alexander Graf wrote: >> So I suppose the only thing missing is a --disable-cocoa option, yup. > > I've just noticed that some of the code in block/raw-posix.c > uses the CONFIG_COCOA #define to gate whether to do MacOSX >

[Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Hi, Kevin Wolf wrote: > This pulls the request completion for error cases from the caller to > scsi_disk_emulate_command. This should not change semantics, but allows to > reuse scsi_handle_write_error() for flushes in the next patch. Today I tried out qemu-system-arm for the first time. It's f

[Qemu-devel] [PATCH] Abort on attempts to load out-of-range ROMs

2011-05-16 Thread Ben Leslie
Abort on attempts to load out-of-range ROMs Change ROM loading behaviour so that attempts to load ROMs that fall outside valid memory ranges causing an abort with a useful error message, rather than silently ignoring the problem. Signed-off-by: Ben Leslie --- exec.c |2 +- 1 files changed,

[Qemu-devel] [PATCH] piix_pci: fix piix3_set_irq_pic()

2011-05-16 Thread TeLeMan
If pic_irq is greater than 7, the irq level is always 0 on 32bits. Signed-off-by: TeLeMan --- hw/piix_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 7f1c4cc..85a320e 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -312,7 +312

Re: [Qemu-devel] [Qemu-trivial] [PATCH] piix_pci: fix piix3_set_irq_pic()

2011-05-16 Thread Stefan Hajnoczi
On Mon, May 16, 2011 at 12:50 PM, TeLeMan wrote: > If pic_irq is greater than 7, the irq level is always 0 on 32bits. > > Signed-off-by: TeLeMan > --- >  hw/piix_pci.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial-patches tree: http://repo.or.cz/w/q

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Gerd Hoffmann
Hi, Usually programs that are fully autoconf-iscated will ship a subset of libtool sources in the tarball, build a custom version at configure time, and invoke it from the Makefile via ./libtool. This has the advantage that only the maintainer needs to have libtool installed. OTOH we do not us

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 02:06 PM, Gerd Hoffmann wrote: Usually programs that are fully autoconf-iscated will ship a subset of libtool sources in the tarball, build a custom version at configure time, and invoke it from the Makefile via ./libtool. This has the advantage that only the maintainer needs to hav

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 02:07:55PM +0200, Paolo Bonzini wrote: > On 05/16/2011 02:06 PM, Gerd Hoffmann wrote: > >>Usually programs that are fully autoconf-iscated will ship a subset of > >>libtool sources in the tarball, build a custom version at configure > >>time, and invoke it from the Makefile

[Qemu-devel] [PATCH v2 00/21] SCSI subsystem improvements

2011-05-16 Thread Paolo Bonzini
This series includes the following improvements to the SCSI subsystem: 1) introduction of SCSIBusOps that generalize the existing command_complete callback; 2) widespread use of the SCSIRequest abstraction, with simpler memory management (refcounting) and with various common idioms converted into

  1   2   >