Re: [Qemu-devel] [PATCH 1/2] Add dd-style SIGUSR1 progress reporting

2011-04-28 Thread Jes Sorensen
On 04/27/11 18:14, Markus Armbruster wrote: >> +static void progress_simple_init(void) >> +{ >> +state.print = progress_simple_print; >> +state.end = progress_simple_end; >> +} >> + >> +#ifdef CONFIG_POSIX >> +static void sigusr_print(int signal) >> +{ >> +printf("(%3.2f/100%%)\n",

[Qemu-devel] [PULL] char, virtio-serial, spice

2011-04-28 Thread Amit Shah
Hello, These are assorted fixes to the char code, big endian handling of virtio-serial code and addition of a guest open/close notification for spice to use from virtio-console. (The git mirror might take a while to show up these patches.) The following changes since commit a7d3970d0635ebce1412

[Qemu-devel] [PATCH 3/6] spice-chardev: listen to frontend guest open / close

2011-04-28 Thread Amit Shah
From: Hans de Goede Note the vmc_register_interface() in spice_chr_write is left in place in case someone uses spice-chardev with a frontend which does not have guest open / close notification. Signed-off-by: Hans de Goede Reviewed-by: Alon Levy Signed-off-by: Amit Shah --- spice-qemu-char.c

[Qemu-devel] [Bug 696530] Re: qemu-0.13.0-r2 special keys different when using -alt-grab

2011-04-28 Thread Phillip Merensky
Thank you! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/696530 Title: qemu-0.13.0-r2 special keys different when using -alt-grab Status in QEMU: New Bug description: I use -alt-grab with qem

[Qemu-devel] [PATCH 1/6] chardev: Allow frontends to notify backends of guest open / close

2011-04-28 Thread Amit Shah
From: Hans de Goede Some frontends know when the guest has opened the "channel" and is actively listening to it, for example virtio-serial. This patch adds 2 new qemu-chardev functions which can be used by frontends to signal guest open / close, and allows interested backends to listen to this.

[Qemu-devel] [PATCH 2/6] virtio-console: notify backend of guest open / close

2011-04-28 Thread Amit Shah
From: Hans de Goede Signed-off-by: Hans de Goede Reviewed-by: Alon Levy Signed-off-by: Amit Shah --- hw/virtio-console.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 6b5237b..de539c4 100644 --- a/hw/

[Qemu-devel] [PATCH 4/6] char: Allow devices to use a single multiplexed chardev.

2011-04-28 Thread Amit Shah
From: Kusanagi Kouichi This fixes regression caused by commit 2d6c1ef40f3678ab47a4d14fb5dadaa486bfcda6 ("char: Prevent multiple devices opening same chardev"): -nodefaults -nographic -chardev stdio,id=stdio,mux=on,signal=off \ -mon stdio -device virtio-serial-pci \ -device virtconsole,chardev=

[Qemu-devel] [PATCH 5/6] char: Detect chardev release by NULL handlers as well as NULL opaque

2011-04-28 Thread Amit Shah
Juan says he prefers these extra checks to ensure a user of a chardev is releasing it. Requested-by: Juan Quintela Signed-off-by: Amit Shah --- qemu-char.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index eaf6571..5e04a20 100644 --- a/qem

[Qemu-devel] [PATCH 6/6] virtio-serial: Fix endianness bug in the config space

2011-04-28 Thread Amit Shah
From: Alexey Kardashevskiy The virtio serial specification requres that the values in the config space are encoded in native endian of the guest. The qemu virtio-serial code did not do conversion to the guest endian format what caused problems when host and guest use different format. This patc

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-04-28 Thread Boris Derzhavets
Disabling AppArmor really allows libvirt to go with no problems. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/723871 Title: qemu-kvm-0.14.0 Aborts with -vga qxl Status in QEMU: Confirmed Status

[Qemu-devel] [PATCH] ide/atapi: fix set but unused

2011-04-28 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/ide/atapi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 690a0ab..81fa01b 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -1080,12 +1080,14 @@ static const struct { void ide_atapi_cmd(IDES

[Qemu-devel] [PATCHv2 0/4] qxl: debug related fixes

2011-04-28 Thread Alon Levy
These patches contain three small fixes, and one patch requiring more review that adds support for using chardevs for specific debug information: one for guest debug prints, and another for qxl command ring logging. This allows easier parsing and logging of this data for debugging. v1->v2: use qe

[Qemu-devel] [PATCHv2 1/4] qxl: interface_get_command: fix reported mode

2011-04-28 Thread Alon Levy
report correct mode when in undefined mode. --- hw/qxl.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index fe4212b..63e295b 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -336,6 +336,21 @@ static void interface_get_init_info(QXLInstance *

[Qemu-devel] [PATCHv2 2/4] qxl: add mode to debugprint on destroy primary

2011-04-28 Thread Alon Levy
--- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 63e295b..ccd820c 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1009,7 +1009,7 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) break; case QXL_IO_DESTROY

[Qemu-devel] [PATCHv2 4/4] qxl: allow QXL_IO_LOG also in vga

2011-04-28 Thread Alon Levy
The driver may change us to vga mode and still issue a QXL_IO_LOG, which we can easily support. --- hw/qxl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index ecab001..d55f96a 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -941,6 +941,7 @@ static void iopo

[Qemu-devel] [PATCHv2 3/4] qxl: add debug_cs and cmdlog_cs

2011-04-28 Thread Alon Levy
With this you can output the command log and/or the guest debug (driver) output to a chardev instead of stderr: -global qxl-vga.cmdlog_chardev=qxl_cmdlog_chardev -global qxl-vga.debug_chardev=qxl_debug_chardev useful for debugging. if no chardev is specified prints to stderr like the old code. --

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-04-28 Thread Boris Derzhavets
Just disabling libvirtd profile is enough as well :- # apparmor_parser -R /etc/apparmor.d/usr.sbin.libvirtd # ln -s /etx/apparmor.d/usr.sbin.libvirtd /etc/apparmor.d/disable/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bu

[Qemu-devel] [PATCH] qemu-progress.c: printf isn't signal safe

2011-04-28 Thread Jes . Sorensen
From: Jes Sorensen Change the signal handling to indicate a signal is pending, rather then printing directly from the signal handler. In addition make the signal prints go to stderr, rather than stdout. Signed-off-by: Jes Sorensen --- qemu-progress.c |7 ++- 1 files changed, 6 inserti

Re: [Qemu-devel] Qemu-img convert with -B

2011-04-28 Thread Brad Campbell
On 28/04/11 14:36, Kevin Wolf wrote: Am 28.04.2011 04:06, schrieb Brad Campbell: On 27/04/11 22:02, Brad Campbell wrote: On 27/04/11 21:56, Kevin Wolf wrote: When you don't have a backing file, leaving an cluster unallocated means that it's zero. When you have a backing file, it could be anyt

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-28 Thread Gerd Hoffmann
On 04/08/11 18:37, Luiz Capitulino wrote: On Fri, 08 Apr 2011 16:34:21 +0200 Markus Armbruster wrote: Brad Hards writes: This addresses https://bugs.launchpad.net/qemu/+bug/752476 which basically points out that using the mouse_button command causes the mouse cursor to warp to the origin (w

[Qemu-devel] [Bug 772275] Re: qemu-kvm-0.14.0 + kernel 2.6.35 : win2008r2 virtio nic hanging

2011-04-28 Thread Alexandre Derumier
Forget to say: i'm using a quad-amd opteron 6172 (12cores) server, 256gb ram. kvm guest launch command: /usr/bin/kvm -monitor unix:/var/run/qemu-server/124.mon,server,nowait -vnc unix:/var/run/qemu-server/124.vnc,password -pidfile /var/run/qemu- server/124.pid -daemonize -usbdevice tablet -name

[Qemu-devel] [Bug 772275] [NEW] qemu-kvm-0.14.0 + kernel 2.6.35 : win2008r2 virtio nic hanging

2011-04-28 Thread Alexandre Derumier
Public bug reported: Hi, I'm a proxmox distrib user, I have network error with virtio nic cards in win2008r2sp1 server, only with qemu 0.14 and 2.6.35 kernel combination. after some network transferts (can be 2mb or 500mb), nic doesn't respond anymore. only way is to reboot. e1000 driver worki

Re: [Qemu-devel] [PATCH] Fix bug with virtio-9p rename

2011-04-28 Thread Sassan Panahinejad
Malahal Naineni's patch "Stop renaming files with similar name!" (posted since this one) also fixes this bug. I don't mind which one gets merged, as long as the bug gets fixed ;) Sassan On 27 April 2011 19:30, Sassan Panahinejad wrote: > After renaming a file, any existing references to the fi

Re: [Qemu-devel] [PATCH] qemu-progress.c: printf isn't signal safe

2011-04-28 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > Change the signal handling to indicate a signal is pending, rather > then printing directly from the signal handler. > > In addition make the signal prints go to stderr, rather than stdout. > > Signed-off-by: Jes Sorensen > --- > qemu-pro

Re: [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions

2011-04-28 Thread Peter Maydell
Ping? The two UNDEF patches have both been applied, so this patch applies cleanly to master now. -- PMM On 20 April 2011 15:52, Peter Maydell wrote: > Move VLD/VST multiple into helper functions, as some cases can > generate more TCG ops than the maximum per-instruction limit > and certainly mor

[Qemu-devel] [PATCH v2] qemu-progress.c: printf isn't signal safe

2011-04-28 Thread Jes . Sorensen
From: Jes Sorensen Change the signal handling to indicate a signal is pending, rather then printing directly from the signal handler. In addition make the signal prints go to stderr, rather than stdout. Signed-off-by: Jes Sorensen --- qemu-progress.c |7 ++- 1 files changed, 6 inserti

[Qemu-devel] [PATCHv2 1/3] virtio-serial-bus: use bh for unthrottling

2011-04-28 Thread Alon Levy
Instead of calling flush_queued_data when unthrottling, schedule a bh. That way we can return immediately to the caller, and the flush uses the same call path as a have_data for callbackee. --- hw/virtio-serial-bus.c | 11 +-- hw/virtio-serial.h |5 + 2 files changed, 14 inse

[Qemu-devel] [PATCHv2 2/3] bh: add qemu_bh_is_scheduled

2011-04-28 Thread Alon Levy
--- async.c |4 qemu-common.h |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/async.c b/async.c index 57ac3a8..204716e 100644 --- a/async.c +++ b/async.c @@ -214,3 +214,7 @@ void qemu_bh_update_timeout(int *timeout) } } +int qemu_bh_is_scheduled(QEMU

[Qemu-devel] [PATCHv2 3/3] virtio-serial-bus: on migration send status of pending ports bh

2011-04-28 Thread Alon Levy
migration protocol bumped to 4, adding a single byte per port which is 1 if there is a bh scheduled, 0 otherwise. --- hw/virtio-serial-bus.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index 8556e08..7fb8ade

[Qemu-devel] [PATCHv2 0/3] virtio-serial-bus: use a bh for flush_queued_data

2011-04-28 Thread Alon Levy
This replaces the direct call of flush_queued_data with a bottom half, making the callpath for the chardev identical in a normal write and a write resulting from unthrottling. It includes a patch to add an accessor to QEMUBH to get scheduled status, to keep the bh scheduled across migration. Migr

Re: [Qemu-devel] [PATCH 1/2] Add dd-style SIGUSR1 progress reporting

2011-04-28 Thread Paolo Bonzini
On 04/28/2011 09:18 AM, Jes Sorensen wrote: On 04/27/11 18:14, Markus Armbruster wrote: +static void progress_simple_init(void) +{ +state.print = progress_simple_print; +state.end = progress_simple_end; +} + +#ifdef CONFIG_POSIX +static void sigusr_print(int signal) +{ +printf("(

Re: [Qemu-devel] [PATCH] ide/atapi: fix set but unused

2011-04-28 Thread Paolo Bonzini
On 04/28/2011 10:07 AM, Alon Levy wrote: Signed-off-by: Alon Levy --- hw/ide/atapi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 690a0ab..81fa01b 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -1080,12 +1080,14 @@ stati

Re: [Qemu-devel] [PATCH] ide/atapi: fix set but unused

2011-04-28 Thread Stefan Weil
Am 28.04.2011 14:07, schrieb Paolo Bonzini: On 04/28/2011 10:07 AM, Alon Levy wrote: Signed-off-by: Alon Levy --- hw/ide/atapi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 690a0ab..81fa01b 100644 --- a/hw/ide/atapi.c +++ b

Re: [Qemu-devel] [PULL] qemu-timer: Add and use new function qemu_timer_expired_ns and other patches

2011-04-28 Thread Stefan Weil
Am 20.04.2011 16:26, schrieb Stefan Weil: Hello, the four qemu-timer related patches which I sent to qemu-devel can now be pulled. Maybe this makes the commit to git master easier. There was no feedback for the first three patches. The fourth patch changes windows code only and is needed for

Re: [Qemu-devel] [PATCH] ide/atapi: fix set but unused

2011-04-28 Thread Paolo Bonzini
On 04/28/2011 02:16 PM, Stefan Weil wrote: What about using buf instead of packet (no need for extensions, reduces code by 4 lines)? Uh, you're right!... I was assuming some side effect later, but after the refactoring this is indeed the only place where packet is used in the function, and i

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Jes Sorensen
On 04/27/11 17:05, Jes Sorensen wrote: > On 04/27/11 17:05, Luiz Capitulino wrote: >> On Mon, 18 Apr 2011 16:27:01 +0200 >> jes.soren...@redhat.com wrote: >> >>> From: Jes Sorensen >>> >>> This is quivalent to snapshot_blkdev in the human monitor, with _sync >>> added to the command name to make i

Re: [Qemu-devel] [PATCH v2] qemu-progress.c: printf isn't signal safe

2011-04-28 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > Change the signal handling to indicate a signal is pending, rather > then printing directly from the signal handler. > > In addition make the signal prints go to stderr, rather than stdout. Looks good now.

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Jes Sorensen
On 04/27/11 17:05, Luiz Capitulino wrote: >> > +Synchronous snapshot of block device, using snapshot file as target >> > +if provided. > It's not optional in HMP: > > (qemu) snapshot_blkdev ide0-hd0 > Parameter 'snapshot_file' is missing > (qemu) > The parameter is optional in HMP, however i

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Jes Sorensen
On 04/27/11 17:05, Luiz Capitulino wrote: >> +If a new image file is specified, the new image file will become the >> > +new root image. If format is specified, the snapshot file will be >> > +created in that format. Otherwise the snapshot will be internal! >> > +(currently unsupported). > Sorry fo

[Qemu-devel] [Bug 772358] [NEW] VNC working depends on command line options order

2011-04-28 Thread Jarda Benkovsky
Public bug reported: OS: Ubuntu 10.04.2, amd64 Pkg version: 0.12.3+noroms-0ubuntu9.5 if -nographic option is specified before -vnc, vnc works, if vice-versa, it does not. I have been told (thanks, mjt), that -nographic is supposed to disable any graphic output, including vnc, so possibly it's a d

[Qemu-devel] [PATCHv2] ide/atapi: fix set but unused

2011-04-28 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/ide/atapi.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 690a0ab..0073c8d 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -1080,17 +1080,15 @@ static const struct { void ide_atapi_cmd(IDES

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Kevin Wolf
Am 28.04.2011 15:21, schrieb Jes Sorensen: > On 04/27/11 17:05, Luiz Capitulino wrote: >>> +If a new image file is specified, the new image file will become the +new root image. If format is specified, the snapshot file will be +created in that format. Otherwise the snapshot will be inter

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Jes Sorensen
On 04/28/11 15:41, Kevin Wolf wrote: >>> Finally, what's the expect behavior when -snapshot is used? I'm getting >>> >> this: >>> >> >>> >> (qemu) snapshot_blkdev ide0-hd0 snap-test >>> >> Could not open '/tmp/vl.6w8YXA' >>> >> (qemu) >> > >> > What type of file system is your /tmp? You need to

[Qemu-devel] [PATCH] Fix bug with virtio-9p xattr functions return values

2011-04-28 Thread Sassan Panahinejad
Several functions in virtio-9p-xattr.c are passing the return value of the associated host system call back to the client instead of errno. Since this value is -1 for any error (which, when received in the guest app as errno, indicates "operation not permitted") it is causing guest applications t

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-04-28 Thread Jamie Strandboge
Boris, you should not disable the profile but instead update it. See https://wiki.ubuntu.com/DebuggingApparmor and /usr/share/doc/libvirt- bin/README.Debian for details. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.lau

Re: [Qemu-devel] [PULL] Request for Pull

2011-04-28 Thread Anthony Liguori
On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote: The following changes since commit 661bfc80e876d32da8befe53ba0234d87fc0bcc2: Jan Kiszka (1): pflash: Restore & fix lazy ROMD switching are available in the git repository at: git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony Pulled. Th

Re: [Qemu-devel] [PULL] char, virtio-serial, spice

2011-04-28 Thread Anthony Liguori
On 04/28/2011 02:30 AM, Amit Shah wrote: Hello, These are assorted fixes to the char code, big endian handling of virtio-serial code and addition of a guest open/close notification for spice to use from virtio-console. (The git mirror might take a while to show up these patches.) Pulled. Th

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-04-28 Thread Peter Maydell
> Do you think it will ever get fixed in a reasonable amount of time (or ever) Well, it's on my list of things to look at, but generally my focus is the current (ARMv7) architecture, and fixing ARMv5 only bugs is lower priority. But there's a pretty good chance I'll get to it somewhere in the next

[Qemu-devel] [PATCH] multiboot: set boot_device to first partition

2011-04-28 Thread Arun Thomas
The multiboot info struct's 'boot_device' field has 'part1' set to 0x01, which maps to the second primary partition. To specify the first primary partition, 'part1' should be set to 0x00, since partition numbers start from zero according to the multiboot spec. Signed-off-by: Arun Thomas --- hw/

[Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command

2011-04-28 Thread Jes . Sorensen
From: Jes Sorensen Add QMP bits for snapshot_blkdev command. This is the same as snapshot_blkdev in the human monitor. The command is synchronous. In the future async commands may be added with the name _async/-async. Signed-off-by: Jes Sorensen --- qmp-commands.hx | 38 +

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Luiz Capitulino
On Thu, 28 Apr 2011 15:21:41 +0200 Jes Sorensen wrote: > On 04/27/11 17:05, Luiz Capitulino wrote: > >> +If a new image file is specified, the new image file will become the > >> > +new root image. If format is specified, the snapshot file will be > >> > +created in that format. Otherwise the sna

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-04-28 Thread Boris Derzhavets
Thanks for advice. My primary target was to make sure , that it's not libvirt 8.8.1 on Ubuntu 11.04 issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/723871 Title: qemu-kvm-0.14.0 Aborts with -v

[Qemu-devel] [PATCH v3 0/5] hpet 'driftfix': alleviate time drift with HPET periodic timers

2011-04-28 Thread Ulrich Obergfell
Hi, This is version 3 of a series of patches that I originally posted in: http://lists.gnu.org/archive/html/qemu-devel/2011-03/msg01989.html http://lists.gnu.org/archive/html/qemu-devel/2011-03/msg01992.html http://lists.gnu.org/archive/html/qemu-devel/2011-03/msg01991.html http:/

[Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)

2011-04-28 Thread Ulrich Obergfell
'target_get_irq_delivered' and 'target_reset_irq_delivered' contain entry addresses of functions that are utilized by update_irq() to detect coalesced interrupts. apic code loads these pointers during initialization. This change can be replaced if a generic feedback infrastructure to track coalesc

[Qemu-devel] [PATCH v3 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-28 Thread Ulrich Obergfell
The new fields in HPETTimer are covered by a separate VMStateDescription which is a subsection of 'vmstate_hpet_timer'. They are only migrated if -global hpet.driftfix=on Signed-off-by: Ulrich Obergfell --- hw/hpet.c | 33 + 1 files changed, 33 insertions(+

[Qemu-devel] [PATCH v3 4/5] hpet 'driftfix': add code in update_irq() to detect coalesced interrupts (x86 apic only)

2011-04-28 Thread Ulrich Obergfell
update_irq() uses a similar method as in 'rtc_td_hack' to detect coalesced interrupts. The function entry addresses are retrieved from 'target_get_irq_delivered' and 'target_reset_irq_delivered'. This change can be replaced if a generic feedback infrastructure to track coalesced IRQs for periodic,

[Qemu-devel] [PATCH v3 2/5] hpet 'driftfix': add driftfix property to HPETState and DeviceInfo

2011-04-28 Thread Ulrich Obergfell
driftfix is a 'bit type' property. Compensation of delayed callbacks and coalesced interrupts can be enabled with the command line option -global hpet.driftfix=on driftfix is 'off' (disabled) by default. Signed-off-by: Ulrich Obergfell --- hw/hpet.c |3 +++ 1 files changed, 3 insertion

[Qemu-devel] [PATCH v3 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-04-28 Thread Ulrich Obergfell
Loss of periodic timer interrupts caused by delayed callbacks and by interrupt coalescing is compensated by gradually injecting additional interrupts during subsequent timer intervals, starting at a rate of one additional interrupt per interval. The injection of additional interrupts is based on a

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Jes Sorensen
On 04/28/11 16:21, Luiz Capitulino wrote: > On Thu, 28 Apr 2011 15:21:41 +0200 > Jes Sorensen wrote: > >> On 04/27/11 17:05, Luiz Capitulino wrote: >>> All arguments should be mandatory in QMP, IMO. >> >> Sorry, but there is absolutely no reason to make all arguments >> mandatory. Sure it can be

[Qemu-devel] [PATCH 1/2] atapi: Move comment to proper place

2011-04-28 Thread Amit Shah
Move misplaced comment for media_is_dvd() Signed-off-by: Amit Shah --- hw/ide/atapi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 690a0ab..86b18d8 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -71,12 +71,12 @@ static void

[Qemu-devel] [PATCH 2/2] atapi: Explain why we need a 'media not present' state

2011-04-28 Thread Amit Shah
After the re-org of the atapi code, it might not be intuitive for a reader of the code to understand why we're inserting a 'media not present' state between cd changes. Signed-off-by: Amit Shah --- hw/ide/atapi.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Anthony Liguori
On 04/27/2011 10:05 AM, Luiz Capitulino wrote: On Mon, 18 Apr 2011 16:27:01 +0200 jes.soren...@redhat.com wrote: From: Jes Sorensen This is quivalent to snapshot_blkdev in the human monitor, with _sync added to the command name to make it explicit that the command is synchronous and leave spac

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Anthony Liguori
On 04/28/2011 09:21 AM, Luiz Capitulino wrote: On Thu, 28 Apr 2011 15:21:41 +0200 Jes Sorensen wrote: On 04/27/11 17:05, Luiz Capitulino wrote: +If a new image file is specified, the new image file will become the +new root image. If format is specified, the snapshot file will be +created in

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Jes Sorensen
On 04/28/11 16:36, Anthony Liguori wrote: > On 04/27/2011 10:05 AM, Luiz Capitulino wrote: >> On Mon, 18 Apr 2011 16:27:01 +0200 >> jes.soren...@redhat.com wrote: >> >>> From: Jes Sorensen >>> >>> This is quivalent to snapshot_blkdev in the human monitor, with _sync >>> added to the command name to

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Kevin Wolf
Am 28.04.2011 15:46, schrieb Jes Sorensen: > On 04/28/11 15:41, Kevin Wolf wrote: Finally, what's the expect behavior when -snapshot is used? I'm getting >> this: >> >> (qemu) snapshot_blkdev ide0-hd0 snap-test >> Could not open '/tmp/vl.6w8YXA' >> (qemu) What

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Jes Sorensen
On 04/28/11 16:42, Kevin Wolf wrote: > What type of file system is your /tmp? You need to provide full path to > the snapshot file if you don't want it created next to where your > qemu > binary is being executed. >>> >> I think the problem is that this is a temporar

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Anthony Liguori
On 04/28/2011 09:38 AM, Jes Sorensen wrote: Sorry but this is utterly bogus. The snapshot support as is works fine, and the command is in the monitor. We should expose it in QMP as well. It went in for the monitor because it was considered an imperfect command so we held up the QMP side beca

Re: [Qemu-devel] [PATCHv2] ide/atapi: fix set but unused

2011-04-28 Thread Stefan Weil
Am 28.04.2011 15:34, schrieb Alon Levy: Signed-off-by: Alon Levy --- hw/ide/atapi.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 690a0ab..0073c8d 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -1080,17 +1080,15 @@ static

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Jes Sorensen
On 04/28/11 16:46, Anthony Liguori wrote: > On 04/28/2011 09:38 AM, Jes Sorensen wrote: >> >> Sorry but this is utterly bogus. >> >> The snapshot support as is works fine, and the command is in the >> monitor. We should expose it in QMP as well. > > It went in for the monitor because it was consid

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-28 Thread Anthony Liguori
On 04/28/2011 09:57 AM, Jes Sorensen wrote: On 04/28/11 16:46, Anthony Liguori wrote: On 04/28/2011 09:38 AM, Jes Sorensen wrote: Sorry but this is utterly bogus. The snapshot support as is works fine, and the command is in the monitor. We should expose it in QMP as well. It went in for the

Re: [Qemu-devel] [PATCH] NBD: Convert the NBD driver to use the AIO interface.

2011-04-28 Thread Nicholas Thomas
Hi again Kevin, all, Thanks for applying the first four patches, and apologies for taking so long to get back to you. I've found the time to take your comments on-board and re-do the last patch, + the string-leak patch; I'll send them on shortly, I just wanted to make a few notes on yours, first.

[Qemu-devel] [PATCH 1/2] NBD: Avoid leaking a couple of strings when the NBD device is closed

2011-04-28 Thread nick
From: Nick Thomas Signed-off-by: Nick Thomas --- block/nbd.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 1d6b225..7a52f62 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -239,6 +239,10 @@ static int nbd_write(BlockDriverState *bs, in

[Qemu-devel] [PATCH 2/2] NBD: Convert the NBD driver to use the AIO interface.

2011-04-28 Thread nick
From: Nick Thomas This preserves the previous behaviour where the NBD server is unavailable or goes away during guest execution, but switches the NBD backend to present the AIO interface instead of the sync IO interface. We also split read & write requests into 1 MiB blocks (minus header). This

[Qemu-devel] [PATCH 04/18] Fix typo in comment (colum -> column)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/ssd0303.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ssd0303.c b/hw/ssd0303.c index 108c068..b39e259 100644 --- a/hw/ssd0303.c +++ b/hw/ssd0303.c @@ -93,7 +93,7 @@ static int ssd0303_send(i2c_slave *i2c, uint8_t data)

[Qemu-devel] [PATCH 10/18] Fix typos in comments (existance -> existence)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- libcacard/vscard_common.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h index bebd52d..609ae98 100644 --- a/libcacard/vscard_common.h +++ b/libcacard/vscard_common.h @@ -153,7 +153,7 @

[Qemu-devel] [PATCH 11/18] Fix typos in comments (interupt -> interrupt)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- cpu-exec.c |2 +- hw/mst_fpga.c|2 +- hw/pl031.c |2 +- hw/pl061.c |4 ++-- target-mips/translate_init.c |2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/c

[Qemu-devel] [PATCH 01/18] Fix typos in comments (dependancy -> dependency)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- Changelog |2 +- Makefile.objs |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index 152feaa..1c41e14 100644 --- a/Changelog +++ b/Changelog @@ -525,7 +525,7 @@ version 0.1.5: - ppc64 support + personality(

[Qemu-devel] [PATCH 03/18] Fix typos in comments (accessable -> accessible, priveleged -> privileged)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/sh7750_regs.h |6 +++--- target-cris/cpu.h |2 +- tests/test-mmap.c |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/sh7750_regs.h b/hw/sh7750_regs.h index 5a23a2c..6ec13ab 100644 --- a/hw/sh7750_regs.h +++ b/hw/sh7750_regs.

[Qemu-devel] [PATCH 12/18] Fix typos in comments (instanciation -> instantiation)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/ppc4xx_devs.c|2 +- target-ppc/translate_init.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc4xx_devs.c b/hw/ppc4xx_devs.c index 7f9ed17..68bdfaa 100644 --- a/hw/ppc4xx_devs.c +++ b/hw/ppc4xx_devs.c @@ -38,7 +38,

[Qemu-devel] [PATCH 09/18] Fix typos in comments (imediately -> immediately)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/lan9118.c |2 +- hw/syborg_serial.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/lan9118.c b/hw/lan9118.c index 2dc8d18..4c42fe9 100644 --- a/hw/lan9118.c +++ b/hw/lan9118.c @@ -721,7 +721,7 @@ static void do_phy_write(la

[Qemu-devel] [PATCH 05/18] Fix typo in comment (auxilliary -> auxiliary)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/pci_regs.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci_regs.h b/hw/pci_regs.h index dd0bed4..5a5ab89 100644 --- a/hw/pci_regs.h +++ b/hw/pci_regs.h @@ -223,7 +223,7 @@ #define PCI_PM_CAP_PME_CLOCK 0x0008 /* PME clock requi

[Qemu-devel] [PATCH 08/18] Fix typo in comment (dieing -> dying)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- linux-user/signal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index ce033e9..6fe086b 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -391,7 +391,7 @@ static void QEMU_NORETURN fo

[Qemu-devel] [PATCH 17/18] Fix typo in comment (truely -> truly)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- linux-user/mmap.c |2 +- target-cris/translate_v10.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 0cf22f8..994c02b 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -354,7

[Qemu-devel] [Bug 458521] Re: kvm crash when using virtio for network, hardy guest

2011-04-28 Thread Jamie Strandboge
@John, what is the status of this bug on Hardy/linux? ** Changed in: qemu Status: In Progress => Fix Released ** Changed in: linux (Ubuntu Hardy) Status: Triaged => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [PATCH 16/18] Fix typo in comment (responsiblity -> responsibility)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/pcie_aer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pcie_aer.c b/hw/pcie_aer.c index 0c4e8a5..f08d3c7 100644 --- a/hw/pcie_aer.c +++ b/hw/pcie_aer.c @@ -612,7 +612,7 @@ static bool pcie_aer_inject_uncor_error(PCIEAERInject *inj

[Qemu-devel] [PATCH 15/18] Fix typo in comment (relevent -> relevant)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hppa-dis.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hppa-dis.c b/hppa-dis.c index 49f99c8..a5760a9 100644 --- a/hppa-dis.c +++ b/hppa-dis.c @@ -1645,7 +1645,7 @@ static const char *const fp_reg_names[] = typedef unsigned int CORE_

[Qemu-devel] [PATCH 13/18] Fix typos in comments (neccessary -> necessary)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- bsd-user/qemu.h|2 +- linux-user/qemu.h |2 +- target-arm/translate.c |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index e343894..1ba2d08 100644 --- a/bsd-user/qemu.h +++ b/bsd-use

[Qemu-devel] [PATCH 14/18] Fix typos in comments and code (occured -> occurred and related)

2011-04-28 Thread Stefan Weil
The code changed here is an unused data type name (evt_flush_occurred). Signed-off-by: Stefan Weil --- block.c|2 +- block/qcow2-refcount.c |2 +- cpu-all.h |2 +- cpu-exec.c |2 +- hw/bt.h|2 +- hw/pcie.c

[Qemu-devel] [PATCH 18/18] Fix typos in comment (threshhold -> threshold, mapp -> map)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/xilinx_axidma.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xilinx_axidma.c b/hw/xilinx_axidma.c index e32534f..571a5b0 100644 --- a/hw/xilinx_axidma.c +++ b/hw/xilinx_axidma.c @@ -134,10 +134,10 @@ static inline int stream_idle

[Qemu-devel] [PATCH 06/18] Fix typo in comment (embeded -> embedded)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target-ppc/cpu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 04b1259..e438b17 100644 --- a/target-ppc/cpu.h +++ b/target-ppc/cpu.h @@ -225,7 +225,7 @@ enum { /* 970FX specific exceptions

[Qemu-devel] [PATCH 07/18] Fix typo in comment (consistant -> consistent)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- libcacard/vcard_emul_nss.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c index baada52..f3db657 100644 --- a/libcacard/vcard_emul_nss.c +++ b/libcacard/vcard_emul_nss.c @@ -971,7 +97

[Qemu-devel] [PATCH 02/18] Fix typos in comments (accross -> across)

2011-04-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- darwin-user/syscall.c |2 +- target-microblaze/helper.c |2 +- tcg/tcg.h |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/darwin-user/syscall.c b/darwin-user/syscall.c index 060acc8..f3cc1f8 100644 --- a/darwi

[Qemu-devel] Bug in virtio-9p when fstatting an fd referring to a file that no longer exists

2011-04-28 Thread Sassan Panahinejad
It should be possible for guest applications to fstat a file for which they have a valid file descriptor, even if the file has been removed. Demonstrated by the code sample below (fstat reports no such file or directory). Strangely it seems that reading from a file in this state works fine (and whe

Re: [Qemu-devel] Bug in virtio-9p when fstatting an fd referring to a file that no longer exists

2011-04-28 Thread Sassan Panahinejad
This thread seems relevant: http://www.mail-archive.com/linux-fsdevel@vger.kernel.org/msg09159.html Unless things have changed, it looks like the problem is in the client kernel (although note that there isn't support in qemu, even if the client did send an fid associated with an open file!). Any t

[Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements)

2011-04-28 Thread Stefan Weil
From: Stefan Weil Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files without fixing the include paths. Signed-off-by: Stefan Weil --- hw/9pfs/virtio-9p-debug.c |5 +++-- hw/9pfs/virtio-9p-local.c |3 ++- hw/9pfs/virtio-9p-posix-acl.c |2 +- hw/9pfs/virtio-9p

Re: [Qemu-devel] [PULL] Request for Pull

2011-04-28 Thread Stefan Weil
Am 28.04.2011 15:56, schrieb Anthony Liguori: On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote: The following changes since commit 661bfc80e876d32da8befe53ba0234d87fc0bcc2: Jan Kiszka (1): pflash: Restore & fix lazy ROMD switching are available in the git repository at: git://repo.or.cz/q

Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements)

2011-04-28 Thread Anthony Liguori
On 04/28/2011 12:08 PM, Stefan Weil wrote: From: Stefan Weil Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files without fixing the include paths. Signed-off-by: Stefan Weil This is not correct. I think we learned in IRC that the problem is Stefan is using CFLAGS=-g which over

Re: [Qemu-devel] [PULL] Request for Pull

2011-04-28 Thread Anthony Liguori
On 04/28/2011 12:21 PM, Stefan Weil wrote: Am 28.04.2011 15:56, schrieb Anthony Liguori: On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote: The following changes since commit 661bfc80e876d32da8befe53ba0234d87fc0bcc2: Jan Kiszka (1): pflash: Restore & fix lazy ROMD switching are available i

Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements)

2011-04-28 Thread Stefan Weil
Am 28.04.2011 19:39, schrieb Anthony Liguori: On 04/28/2011 12:08 PM, Stefan Weil wrote: From: Stefan Weil Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files without fixing the include paths. Signed-off-by: Stefan Weil This is not correct. I think we learned in IRC that the p

Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements)

2011-04-28 Thread Anthony Liguori
On 04/28/2011 12:44 PM, Stefan Weil wrote: Am 28.04.2011 19:39, schrieb Anthony Liguori: On 04/28/2011 12:08 PM, Stefan Weil wrote: From: Stefan Weil Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files without fixing the include paths. Signed-off-by: Stefan Weil This is not cor

  1   2   >