Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-11 Thread Markus Armbruster
Avi Kivity writes: > On 04/08/2011 12:41 AM, Anthony Liguori wrote: >> >> And it's a good thing to have, but exposing this as the only API to >> do something as simple as generating a guest crash dump is not the >> friendliest thing in the world to do to users. > > nmi is a fine name for somethin

[Qemu-devel] Re: [PATCH 4/4] qemu-timer: Fix timers for w32

2011-04-11 Thread Paolo Bonzini
On 04/10/2011 08:28 PM, Stefan Weil wrote: Commit 68c23e5520e8286d79d96ab47c0ea722ceb75041 removed the multimedia timer, but this timer is needed for certain Linux kernels. Otherwise Linux boot stops with this error: MP-BIOS bug: 8254 timer not connected to IO-APIC So the multimedia timer

[Qemu-devel] Re: [PATCH] ppc: remove a write-only variable

2011-04-11 Thread Alexander Graf
On 11.04.2011, at 06:30, David Gibson wrote: > On Sat, Apr 09, 2011 at 05:28:06PM +0200, Alexander Graf wrote: >> >> >> >> >> Am 09.04.2011 um 16:56 schrieb Blue Swirl : >> >>> Remove a write-only variable, spotted by GCC 4.6.0: >>> /src/qemu/hw/ppc.c: In function 'power7_set_irq': >>> /src/

Re: [Qemu-devel] [PATCH v2 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-11 Thread Ulrich Obergfell
>> typedef struct HPETState { >> @@ -248,7 +253,7 @@ static int hpet_post_load(void *opaque, int >> version_id) >> >> static const VMStateDescription vmstate_hpet_timer = { >> .name = "hpet_timer", >> - .version_id = 1, >> + .version_id = 3, > > Why jump from 1 to 3? > >> .minimum

[Qemu-devel] Re: To O_EXCL or not to O_EXCL open host_cdrom

2011-04-11 Thread Stefan Hajnoczi
On Mon, Apr 11, 2011 at 10:37:32AM +0530, Amit Shah wrote: > On (Fri) 08 Apr 2011 [12:33:27], Stefan Hajnoczi wrote: > > The other concern I have about using O_EXCL is that we expose > > ourselves to race conditions if there is ever a need to re-open the > > device. When QEMU closes its file descr

Re: [Qemu-devel] Question about total_sectors in block/vpc.c

2011-04-11 Thread Stefan Hajnoczi
On Sun, Apr 10, 2011 at 05:02:20PM +0800, Lyu Mitnick wrote: > diff --git a/block.c b/block.c > index f731c7a..a80ec49 100644 > --- a/block.c > +++ b/block.c > @@ -239,6 +239,16 @@ int bdrv_create(BlockDriver *drv, const char* filename, > if (!drv->bdrv_create) > return -ENOTSUP; > > +

Re: [Qemu-devel] [PATCH] qemu-iotests: Fixed no scratch directory in qemu-iotests

2011-04-11 Thread Stefan Hajnoczi
On Sat, Apr 09, 2011 at 05:21:24AM +0800, Lyu Mitnick wrote: > This my first time to submit patch, please tell me if I have something > wrong! Please CC Christoph Hellwig who maintains qemu-iotests. Also, please prepend the email subject with "[qemu-iotests]" so it's easy to spot that this patch

[Qemu-devel] Re: [PATCH 3/5] atapi: GESN: Spin off No Event Available handling into own function

2011-04-11 Thread Kevin Wolf
Am 09.04.2011 12:36, schrieb Amit Shah: > On (Fri) 08 Apr 2011 [15:31:49], Kevin Wolf wrote: >> Am 08.04.2011 09:15, schrieb Amit Shah: >>> Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available status in its >>> own function. >>> >>> Also ensure the buffer the driver sent us is big enough to fi

Re: [Qemu-devel] [PATCH v2 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-11 Thread Ulrich Obergfell
>> vmstate_hpet_timer = { >> VMSTATE_UINT64(fsb, HPETTimer), >> VMSTATE_UINT64(period, HPETTimer), >> VMSTATE_UINT8(wrap_flag, HPETTimer), >> + VMSTATE_UINT64_V(saved_period, HPETTimer, 3), >> + VMSTATE_UINT64_V(ticks_not_accounted, HPETTimer, 3), >> + VMSTATE_UINT32_

Re: [Qemu-devel] [PATCH v2 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-11 Thread Avi Kivity
On 04/11/2011 12:06 PM, Ulrich Obergfell wrote: >> vmstate_hpet_timer = { >>VMSTATE_UINT64(fsb, HPETTimer), >>VMSTATE_UINT64(period, HPETTimer), >>VMSTATE_UINT8(wrap_flag, HPETTimer), >> + VMSTATE_UINT64_V(saved_period, HPETTimer, 3), >> + VMSTATE_UINT64_V(t

Re: [Qemu-devel] [PATCH 1/4] vnc: tight: Fix crash after 2GB of output

2011-04-11 Thread Corentin Chary
Aurelien, could you also take a look at http://patchwork.ozlabs.org/patch/87717/ ? Thanks, -- Corentin Chary http://xf.iksaif.net

Re: [Qemu-devel] [PATCH 1/4] vnc: tight: Fix crash after 2GB of output

2011-04-11 Thread Aurelien Jarno
On Mon, Apr 11, 2011 at 11:27:23AM +0200, Corentin Chary wrote: > Aurelien, could you also take a look at > http://patchwork.ozlabs.org/patch/87717/ ? I gave a look, but I don't really know this part of QEMU, so I would prefer if someone else look at it. -- Aurelien Jarno

Re: [Qemu-devel] [PATCH 0/3] qed: Add support for zero clusters

2011-04-11 Thread Kevin Wolf
Am 17.12.2010 16:58, schrieb Stefan Hajnoczi: > This patch series adds zero data clusters to QED. Clusters can be marked as > zero clusters to store zeroed regions in a space-efficient way. The patch > never actually creates new zero clusters but includes the I/O path support > code > to handle

[Qemu-devel] Re: Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Luiz Capitulino
On Sat, 9 Apr 2011 13:34:43 +0300 Blue Swirl wrote: > On Sat, Apr 9, 2011 at 2:25 AM, Luiz Capitulino > wrote: > > Hi there, > > > > Summary: > > > >  - PXE boot in qemu.git (HEAD f124a41) is quite slow, more than 5 minutes. > > Got > >   the problem with e1000, virtio and rtl8139. However, pc

Re: [Qemu-devel] [PATCH v2 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-11 Thread Anthony Liguori
On 04/11/2011 04:08 AM, Avi Kivity wrote: On 04/11/2011 12:06 PM, Ulrich Obergfell wrote: >> vmstate_hpet_timer = { >>VMSTATE_UINT64(fsb, HPETTimer), >>VMSTATE_UINT64(period, HPETTimer), >>VMSTATE_UINT8(wrap_flag, HPETTimer), >> + VMSTATE_UINT64_V(saved_peri

Re: [Qemu-devel] [PATCH v2 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-11 Thread Anthony Liguori
On 04/11/2011 03:24 AM, Ulrich Obergfell wrote: typedef struct HPETState { @@ -248,7 +253,7 @@ static int hpet_post_load(void *opaque, int version_id) static const VMStateDescription vmstate_hpet_timer = { .name = "hpet_timer", - .version_id = 1, + .version_id = 3, Why jump from 1

Re: [Qemu-devel] To O_EXCL or not to O_EXCL open host_cdrom

2011-04-11 Thread Avi Kivity
On 04/08/2011 02:33 PM, Stefan Hajnoczi wrote: Amit and I were discussing the pros and cons of using O_EXCL to open host CD-ROM devices on IRC but this discussion could benefit from more input. Linux block devices (like /dev/sr0 CD-ROMs) can be opened with O_EXCL and only one userspace process w

Re: [Qemu-devel] Re: To O_EXCL or not to O_EXCL open host_cdrom

2011-04-11 Thread Avi Kivity
On 04/11/2011 11:31 AM, Stefan Hajnoczi wrote: On Mon, Apr 11, 2011 at 10:37:32AM +0530, Amit Shah wrote: > On (Fri) 08 Apr 2011 [12:33:27], Stefan Hajnoczi wrote: > > The other concern I have about using O_EXCL is that we expose > > ourselves to race conditions if there is ever a need to re

[Qemu-devel] [PATCH 0/7] Rework PCMCIA subsystem

2011-04-11 Thread Dmitry Eremin-Solenikov
Please pull the following changeset that makes PCMCIA subsystem to use QBus and Qdev for managing devices. Currently the only implementation of PCMCIA host is a PXA2xx host and the only possible PCMCIA device is IDE MicroDrive (dscm1). With this patchset I can create a microdrive device from c

[Qemu-devel] [PATCH 5/7] pcmcia: move attach and detach socket methods to PCMCIASocket

2011-04-11 Thread Dmitry Eremin-Solenikov
Make attach and detach calls to be automatically called by PCMCIA card instantiation code, rather than calling them by hand from the board code. Signed-off-by: Dmitry Eremin-Solenikov --- hw/pcmcia.c| 45 +++- hw/pcmcia.h|2 + hw/pxa.h

[Qemu-devel] [PATCH 3/7] microdrive: qdevify

2011-04-11 Thread Dmitry Eremin-Solenikov
Switch dscm1 microdrive driver to use qdev infrastructure. --- hw/ide/microdrive.c | 49 +++-- hw/pcmcia.h |2 +- hw/spitz.c |5 - hw/tosa.c |5 - 4 files changed, 48 insertions(+), 13 deletions(-) di

[Qemu-devel] [PATCH 2/7] PCMCIA: start qdev'ication

2011-04-11 Thread Dmitry Eremin-Solenikov
Convert PCMCIA bus handling code to use QBus internally. MicroDrive code is still unaffected. Signed-off-by: Dmitry Eremin-Solenikov --- Makefile.objs |3 ++ hw/pcmcia.c| 102 hw/pcmcia.h| 15 +++- hw/pxa2xx_pcm

[Qemu-devel] [PATCH 4/7] pcmcia: move all card callbacks to PCMCIACardInfo

2011-04-11 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov last commit fixup Signed-off-by: Dmitry Eremin-Solenikov Revert "microdrive fixup" This reverts commit 6a9f969b0626e218ff910d84ed1c9eec285cbcd5. Signed-off-by: Dmitry Eremin-Solenikov --- hw/ide/microdrive.c | 41

[Qemu-devel] [PATCH 1/7] pxa2xx_pcmcia: qdevify

2011-04-11 Thread Dmitry Eremin-Solenikov
Use qdev insfrastructure for managing PXA PCMCIA devices. PCMCIA bus itself isn't converted to QBus (yet). pxa2xx_pcmcia_init() function is moved to pcmcia.h as it will be used by other cores/devices (like StrongARM). Signed-off-by: Dmitry Eremin-Solenikov --- hw/mainstone.c | 14 +

Re: [Qemu-devel] [PATCH v2 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-11 Thread Glauber Costa
On Mon, 2011-04-11 at 08:10 -0500, Anthony Liguori wrote: > On 04/11/2011 04:08 AM, Avi Kivity wrote: > > On 04/11/2011 12:06 PM, Ulrich Obergfell wrote: > >> >> vmstate_hpet_timer = { > >> >>VMSTATE_UINT64(fsb, HPETTimer), > >> >>VMSTATE_UINT64(period, HPETTimer), > >> >>

[Qemu-devel] Breaking out virtfs as a standalone server?

2011-04-11 Thread Rob Landley
Right now, there's no decent userspace server for the 9p filesystem that I can find. (In part because the 9P2000.L spec is an undocumented work in progress.) The only up-to-date server seems to be virtfs in qemu, which has no TCP transport layer. Are there any plans to: A) Add a TCP transport l

Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-11 Thread Markus Armbruster
Amit Shah writes: > On (Fri) 08 Apr 2011 [11:39:26], Markus Armbruster wrote: >> Results of quick test run now, patch review to follow. >> >> Test uses a simple program to try ioctl CDROM_DRIVE_STATUS (attached). > > ... > >> Test in guest without your patches: >> >> [start with empty drive

Re: [Qemu-devel] [PATCH v2 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-11 Thread Avi Kivity
On 04/11/2011 04:39 PM, Glauber Costa wrote: On Mon, 2011-04-11 at 08:10 -0500, Anthony Liguori wrote: > On 04/11/2011 04:08 AM, Avi Kivity wrote: > > On 04/11/2011 12:06 PM, Ulrich Obergfell wrote: > >> >> vmstate_hpet_timer = { > >> >> VMSTATE_UINT64(fsb, HPETTimer), > >>

Re: [Qemu-devel] [PATCH v2 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-11 Thread Glauber Costa
On Mon, 2011-04-11 at 08:47 -0500, Anthony Liguori wrote: > On 04/11/2011 08:39 AM, Glauber Costa wrote: > > On Mon, 2011-04-11 at 08:10 -0500, Anthony Liguori wrote: > >> On 04/11/2011 04:08 AM, Avi Kivity wrote: > >>> On 04/11/2011 12:06 PM, Ulrich Obergfell wrote: > >> vmstate_hpet_timer =

[Qemu-devel] [PATCH] vmstate: fix varrays with uint32_t indexes

2011-04-11 Thread Amos Kong
VARRAY_UINT32 only exists in vmstate_load_state(), but not in vmstate_save_state(). CC: Juan Quintela Signed-off-by: Amos Kong --- savevm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 03fce62..09825e6 100644 --- a/savevm.c +++ b/savevm.c @

Re: [Qemu-devel] [PATCH v2 3/5] hpet 'driftfix': add fields to HPETTimer and VMStateDescription

2011-04-11 Thread Anthony Liguori
On 04/11/2011 08:39 AM, Glauber Costa wrote: On Mon, 2011-04-11 at 08:10 -0500, Anthony Liguori wrote: On 04/11/2011 04:08 AM, Avi Kivity wrote: On 04/11/2011 12:06 PM, Ulrich Obergfell wrote: vmstate_hpet_timer = { VMSTATE_UINT64(fsb, HPETTimer), VMSTATE_UINT64(perio

[Qemu-devel] [PATCH 7/7] ide-core: allocate metadata storage for CFATA drives

2011-04-11 Thread Dmitry Eremin-Solenikov
Currently it's done by hw/ide/microdrive.c To simplify that part, move this initialization to ide core. Signed-off-by: Dmitry Eremin-Solenikov --- hw/ide/core.c |4 hw/ide/internal.h |2 ++ hw/ide/microdrive.c |6 +- 3 files changed, 7 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH 6/7] pxa: change order of pcmcia devices instantiation, so that the socket 0 will be default

2011-04-11 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/pxa2xx.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index ef4c0a2..bcb42cf 100644 --- a/hw/pxa2xx.c +++ b/hw/pxa2xx.c @@ -,8 +,8 @@ PXA2xxState *pxa270_init(unsigned int sdram_size, co

[Qemu-devel] Re: [PATCH 1/2] atapi: Drives can be locked without media present

2011-04-11 Thread Kevin Wolf
Am 09.04.2011 12:24, schrieb Amit Shah: > Drivers are free to lock drives without any media present. Such a > condition should not result in an error condition. > > See Table 341 in MMC-5 spec for details. > > Signed-off-by: Amit Shah Thanks, applied both to the block branch. Kevin

[Qemu-devel] Re: [PATCH] target-sh4: get rid of CPU_{Float, Double}U

2011-04-11 Thread Nathan Froyd
On Sun, Apr 10, 2011 at 09:13:05PM +0200, Aurelien Jarno wrote: > SH4 is always using softfloat, so it's possible to have helpers directly > taking float32 or float64 value. This allow to get rid of conversions > through CPU_{Float,Double}U. Eh, I think this punning on i32/f32 and i64/f64 values i

[Qemu-devel] Re: [PATCH] target-sh4: get rid of CPU_{Float, Double}U

2011-04-11 Thread Peter Maydell
On 11 April 2011 15:55, Nathan Froyd wrote: > On Sun, Apr 10, 2011 at 09:13:05PM +0200, Aurelien Jarno wrote: >> SH4 is always using softfloat, so it's possible to have helpers directly >> taking float32 or float64 value. This allow to get rid of conversions >> through CPU_{Float,Double}U. > > Eh,

Re: [Qemu-devel] [PATCH 1/3] arm: basic support for ARMv4/ARMv4T emulation

2011-04-11 Thread Dmitry Eremin-Solenikov
Hi, On 4/10/11, Marek Vasut wrote: > On Monday 04 April 2011 15:38:44 Dmitry Eremin-Solenikov wrote: >> Currently target-arm/ assumes at least ARMv5 core. Add support for >> handling also ARMv4/ARMv4T. This changes the following instructions: >> >> BX(v4T and later) >> >> BKPT, BLX, CDP2, CLZ, LD

[Qemu-devel] [PATCH 00/13] ARM: Handle UNDEF cases in Neon data processing insns

2011-04-11 Thread Peter Maydell
This extremely dull patch set cleans up the UNDEF handling in the Neon data processing instruction space, so that we UNDEF in all the cases where the architecture demands it, and do so early enough that we don't leak a TCG temporary in the process. It also fixes the handling of the one UNPREDICTABL

[Qemu-devel] [PATCH 05/13] target-arm: Collapse VSRI case into VSHL, VSLI

2011-04-11 Thread Peter Maydell
Collapse some switch cases for VSRI into those for VSHL, VSLI, since the bodies are the same. (This is not completely obvious for the size < 3 case, but since for VSRI we know U=1 the GEN_NEON_INTEGER_OP() expansion is equivalent to the open-coded VSHL/VSLI case.) Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH 03/13] target-arm: Simplify three-register pairwise code

2011-04-11 Thread Peter Maydell
From: Juha Riihimäki Since we know that the case of (pairwise && q) has been caught earlier, we can simplify the register setup code for each pass in the three-register-same-size Neon loop. Signed-off-by: Juha Riihimäki --- target-arm/translate.c | 19 --- 1 files changed, 8

[Qemu-devel] [PATCH 08/13] target-arm: Handle UNDEF cases for Neon 2 regs + scalar forms

2011-04-11 Thread Peter Maydell
Add missing checks for cases which must UNDEF in the Neon "2 registers and a scalar" data processing instruction space. Signed-off-by: Peter Maydell --- target-arm/translate.c | 37 +++-- 1 files changed, 27 insertions(+), 10 deletions(-) diff --git a/target-ar

[Qemu-devel] [PATCH 11/13] target-arm: Handle UNDEF cases for Neon 2 register misc forms

2011-04-11 Thread Peter Maydell
Add missing UNDEF checks for Neon "two register miscellaneous" forms: * all instructions except VMOVN,VQMOVN must UNDEF if Q==1 && (Vd<0> == 1 || Vm<0> == 1) * VMOVN,VQMOVN,VCVT.F16.F32 UNDEF if Q == 1 || Vm<0> == 1 * VSHLL,VCVT.F32.F16 UNDEF if Q == 1 || Vd<0> == 1 (The only other UNDEF case

[Qemu-devel] [PATCH 09/13] target-arm: Handle UNDEF cases for VEXT

2011-04-11 Thread Peter Maydell
VEXT must UNDEF if Q == 1 && (Vd<0> == 1 || Vr<0> == 1 || Vm<0> == 1) Signed-off-by: Peter Maydell --- target-arm/translate.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 15c2015..f47e5ea 100644 --- a/target-arm

[Qemu-devel] [PATCH 13/13] target-arm: Handle UNDEF cases for VDUP (scalar)

2011-04-11 Thread Peter Maydell
From: Juha Riihimäki Handle the UNDEF cases for VDUP(scalar): imm4 == x000 Q == 1 && Vd<0> == 1 Signed-off-by: Juha Riihimäki --- target-arm/translate.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index be25c8f..6

[Qemu-devel] [PATCH 10/13] target-arm: Simplify checking of size field in Neon 2reg-misc forms

2011-04-11 Thread Peter Maydell
Many of the Neon "2 register misc" instruction forms require invalid size fields to cause the instruction to UNDEF. Pull this information out into an array; this simplifies the code and also means we can do the check early and avoid the problem of leaking TCG temporaries in the illegal_op case. Si

[Qemu-devel] [PATCH 12/13] target-arm: Treat UNPREDICTABLE VTBL, VTBX case as UNDEF

2011-04-11 Thread Peter Maydell
Catch the UNPREDICTABLE case for Neon VTBL,VTBX, and UNDEF it rather than allowing the helper function to index off the end of the register file. Signed-off-by: Peter Maydell --- target-arm/translate.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/target-arm/tr

[Qemu-devel] [PATCH 02/13] target-arm: Handle UNDEF cases for Neon 3-regs-same insns

2011-04-11 Thread Peter Maydell
Correct the handling of UNDEF cases for the NEON "3 registers same size" forms, by adding missing checks and rationalising some others so they are done early enough to avoid leaking TCG temporaries. Signed-off-by: Peter Maydell --- target-arm/translate.c | 54 ++

[Qemu-devel] [PATCH 01/13] target-arm: Use lookup table for size check on Neon 3-reg-same insns

2011-04-11 Thread Peter Maydell
Simplify the checks for invalid size values for the Neon "three registers of the same size" instruction forms (and add them where they were missing) by using a lookup table. This includes adding symbolic constants for the op values in this space, since we now use them in multiple places. Signed-o

[Qemu-devel] [PATCH 04/13] target-arm: Handle UNDEF cases for Neon "2 regs and shift" insns

2011-04-11 Thread Peter Maydell
Correctly handle all the UNDEF cases for Neon instructions of the "2 registers and shift" form, and make sure that we check for these cases early enough not to leak TCG temporaries. Signed-off-by: Peter Maydell --- target-arm/translate.c | 41 ++--- 1 files

[Qemu-devel] [PATCH 07/13] target-arm: Handle UNDEF cases for Neon 3-regs-different-widths

2011-04-11 Thread Peter Maydell
Add missing UNDEF checks for instructions in the Neon "3 registers of different widths" data processing space. Signed-off-by: Peter Maydell --- target-arm/translate.c | 56 ++- 1 files changed, 36 insertions(+), 20 deletions(-) diff --git a/target-a

[Qemu-devel] [PATCH 06/13] target-arm: Handle UNDEF cases for Neon invalid modified-immediates

2011-04-11 Thread Peter Maydell
For Neon "one register and a modified immediate value" forms, the combination op=1 cmode= is unallocated and should UNDEF. All instructions of this form also UNDEF if Q == 1 and Vd<0> == 1. We also add a comment on the only UNPREDICTABLE in this space. Signed-off-by: Peter Maydell --- target

Re: [Qemu-devel] Re: [PATCH] target-sh4: get rid of CPU_{Float, Double}U

2011-04-11 Thread Peter Maydell
On 11 April 2011 16:19, Richard Henderson wrote: > On 04/11/2011 08:09 AM, Peter Maydell wrote: >> (4) I think you should be able to write a helper function for an >> add as just >>  float32 HELPER(my_float_add)(float32 a, float32 b) { >>      return float32_add(a, b, status); >>  } > > While this

Re: [Qemu-devel] [PATCH 13/13] target-arm: Handle UNDEF cases for VDUP (scalar)

2011-04-11 Thread Peter Maydell
On 11 April 2011 16:26, Peter Maydell wrote: > From: Juha Riihimäki > > Handle the UNDEF cases for VDUP(scalar): >  imm4 == x000 >  Q == 1 && Vd<0> == 1 > > Signed-off-by: Juha Riihimäki Reviewed-by: Peter Maydell (obviously... but I forgot to put that into the commit message.) -- PMM

Re: [Qemu-devel] [PATCH 03/13] target-arm: Simplify three-register pairwise code

2011-04-11 Thread Peter Maydell
On 11 April 2011 16:26, Peter Maydell wrote: > From: Juha Riihimäki > > Since we know that the case of (pairwise && q) has been caught > earlier, we can simplify the register setup code for each pass > in the three-register-same-size Neon loop. > > Signed-off-by: Juha Riihimäki Reviewed-by: Pet

[Qemu-devel] [Bug 757654] Re: UHCI fails to signal stall response

2011-04-11 Thread jvesely
** Patch added: "report error on stall response" https://bugs.launchpad.net/bugs/757654/+attachment/2017520/+files/usb_stall.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/757654 Title: UH

[Qemu-devel] [Bug 757654] [NEW] UHCI fails to signal stall response

2011-04-11 Thread jvesely
Public bug reported: When TD execution results in STALL error (STALL handshake, no stall as a result of err count reaching 0), there is no way to know about it except for checking that TD. IMO it is an error condition and it should be reflected in the status register (and issue an interrupt if ena

[Qemu-devel] Re: [PATCH] target-sh4: get rid of CPU_{Float, Double}U

2011-04-11 Thread Aurelien Jarno
On Mon, Apr 11, 2011 at 04:09:53PM +0100, Peter Maydell wrote: > On 11 April 2011 15:55, Nathan Froyd wrote: > > On Sun, Apr 10, 2011 at 09:13:05PM +0200, Aurelien Jarno wrote: > >> SH4 is always using softfloat, so it's possible to have helpers directly > >> taking float32 or float64 value. This

[Qemu-devel] [PATCH] target-arm: Don't overflow when calculating value for signed VABAL

2011-04-11 Thread Peter Maydell
In the VABAL instruction we take the absolute difference of two values of size x and store it in a result of size 2x. This means we have to be careful to calculate the absolute difference using a wide enough type that we don't accidentally overflow. Signed-off-by: Peter Maydell --- target-arm/ne

Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Anthony Liguori
On 04/11/2011 03:04 PM, Jan Kiszka wrote: On 2011-04-11 21:15, Luiz Capitulino wrote: On Mon, 11 Apr 2011 13:00:32 -0600 Alex Williamson wrote: On Mon, 2011-04-11 at 15:35 -0300, Luiz Capitulino wrote: On Fri, 08 Apr 2011 19:50:57 -0500 Anthony Liguori wrote: On 04/08/2011 06:25 PM, Luiz

Re: [Qemu-devel] [PATCH v2 1/2] rbd: use the higher level librbd instead of just librados

2011-04-11 Thread Josh Durgin
On 04/08/2011 01:43 AM, Stefan Hajnoczi wrote: On Mon, Mar 28, 2011 at 04:15:57PM -0700, Josh Durgin wrote: librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes.

[Qemu-devel] [PATCH v2] kvm: ppc: fixes for KVM_SET_SREGS on init

2011-04-11 Thread Scott Wood
Classic/server ppc has had SREGS for a while now (though I think not always?), but it's still missing for booke. Check the capability before calling KVM_SET_SREGS. Without this, booke kvm fails to boot as of commit 84b4915dd2c0eaa86c970ffc42a68ea8ba9e48b5 (kvm: Handle kvm_init_vcpu errors). Also

Re: [Qemu-devel] [V9fs-developer] Breaking out virtfs as a standalone server?

2011-04-11 Thread Jim Garlick
FWIW I've put a prerelease (1.0-pre20) of a pure 9P2000.L server up here: http://code.google.com/p/diod/ If anyone would like to give it a spin with a 2.6.38-ish kernel, please do and let me know how it goes! To get started with a quick (insecure) test: $ tar xjf diod-1.0-pre20.tar.bz2 $ cd di

Re: [Qemu-devel] Question about total_sectors in block/vpc.c

2011-04-11 Thread Lyu Mitnick
Hello Christoph, Stefan I am wondering whether the problem occurred that value of BDRV_SECTOR_SIZE is a macro constant (defined at block.h). This problem could be fixed if we use variable instead of macro to implement BDRV_SECTOR_SIZE. Each block device may reassign the value if needed. Is it righ

[Qemu-devel] [Bug 757654] Re: UHCI fails to signal stall response

2011-04-11 Thread Brad Hards
Hi, Thanks for reporting this issue. Just so you are aware: the qemu USB maintainer is probably going to be away for a while longer, so don't be too worried if this patch doesn't get looked at for 2-4 weeks. Brad -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH v2 0/3] pc-bios: Use iPXE ROMs

2011-04-11 Thread Alex Williamson
On Mon, 2011-04-11 at 23:13 +0200, Stefan Weil wrote: > Am 11.04.2011 21:35, schrieb Alex Williamson: > > This series replaces our current gPXE based PXE ROMs with iPXE > > versions from the iPXE project (http://ipxe.org). This version > > adds ipxe to our submodules so it can be easily included in

Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Luiz Capitulino
On Mon, 11 Apr 2011 22:04:52 +0200 Jan Kiszka wrote: > On 2011-04-11 21:15, Luiz Capitulino wrote: > > On Mon, 11 Apr 2011 13:00:32 -0600 > > Alex Williamson wrote: > > > >> On Mon, 2011-04-11 at 15:35 -0300, Luiz Capitulino wrote: > >>> On Fri, 08 Apr 2011 19:50:57 -0500 > >>> Anthony Liguori

Re: [Qemu-devel] [PATCH v2 0/3] pc-bios: Use iPXE ROMs

2011-04-11 Thread Stefan Weil
Am 11.04.2011 21:35, schrieb Alex Williamson: This series replaces our current gPXE based PXE ROMs with iPXE versions from the iPXE project (http://ipxe.org). This version adds ipxe to our submodules so it can be easily included in releases. I'm still including a script for updating these, perhap

[Qemu-devel] UNBEATABLE OFFER: ORDER 2 APPLE iPHONES AND GET 1 FREE

2011-04-11 Thread TELECOM SALES UK
TELECOM-SALES & SERVICE Lmtd UK is offering BRAND NEW PHONES 3G/4G,TRI-BAND/QUADBAND,Factory Sealed Boxes,complete Accessories and 1 year Manufacturers Warranty,Also Guaranteed to work with all GSM Carrier/Network Worldwide. APPLE iPHONE 4G/32GB = $450 http://www.apple.com/iphone/ APPLE iPADS

Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Jan Kiszka
On 2011-04-11 22:18, Jan Kiszka wrote: > On 2011-04-11 22:14, Alex Williamson wrote: >> On Mon, 2011-04-11 at 22:04 +0200, Jan Kiszka wrote: >>> On 2011-04-11 21:15, Luiz Capitulino wrote: On Mon, 11 Apr 2011 13:00:32 -0600 Alex Williamson wrote: > On Mon, 2011-04-11 at 15:35 -0

Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Luiz Capitulino
On Mon, 11 Apr 2011 13:00:32 -0600 Alex Williamson wrote: > On Mon, 2011-04-11 at 15:35 -0300, Luiz Capitulino wrote: > > On Fri, 08 Apr 2011 19:50:57 -0500 > > Anthony Liguori wrote: > > > > > On 04/08/2011 06:25 PM, Luiz Capitulino wrote: > > > > Hi there, > > > > > > > > Summary: > > > > > >

[Qemu-devel] [PATCH v2 0/3] pc-bios: Use iPXE ROMs

2011-04-11 Thread Alex Williamson
This series replaces our current gPXE based PXE ROMs with iPXE versions from the iPXE project (http://ipxe.org). This version adds ipxe to our submodules so it can be easily included in releases. I'm still including a script for updating these, perhaps someone better with Makefiles can eventually

Re: [Qemu-devel] GSoC - QCOW2 <-> QED image converter

2011-04-11 Thread Christoph Hellwig
On Thu, Apr 07, 2011 at 07:10:00AM +0800, Lyu Mitnick wrote: > Would you mind to share your solution about this feature?? My idea is > replace > all bdrv_pread(), bdrv_pwrite_sync(), bdrv_pwrite() in block/vpc.c to > bdrv_pread_split(), bdrv_pwrite_sync_split(), bdrv_pwrite_split() > corresponding

Re: [Qemu-devel] No scratch directory in qemu-iotests

2011-04-11 Thread Christoph Hellwig
On Fri, Apr 08, 2011 at 09:47:47AM +0100, Stefan Hajnoczi wrote: > I think it's a good idea to make qemu-iotests work out-of-the-box. > Can you send a patch for this? > > Note that scratch/ is in .gitignore so you might have to tweak > .gitignore to get the behavior you want. Alternatively common

Re: [Qemu-devel] [PATCH] ppc: remove a write-only variable

2011-04-11 Thread Blue Swirl
On Mon, Apr 11, 2011 at 10:48 AM, Alexander Graf wrote: > > On 11.04.2011, at 06:30, David Gibson wrote: > >> On Sat, Apr 09, 2011 at 05:28:06PM +0200, Alexander Graf wrote: >>> >>> >>> >>> >>> Am 09.04.2011 um 16:56 schrieb Blue Swirl : >>> Remove a write-only variable, spotted by GCC 4.6.0:

Re: [Qemu-devel] [PATCH 4/4] qemu-timer: Fix timers for w32

2011-04-11 Thread Stefan Weil
Am 11.04.2011 09:36, schrieb Paolo Bonzini: On 04/10/2011 08:28 PM, Stefan Weil wrote: Commit 68c23e5520e8286d79d96ab47c0ea722ceb75041 removed the multimedia timer, but this timer is needed for certain Linux kernels. Otherwise Linux boot stops with this error: MP-BIOS bug: 8254 timer not c

Re: [Qemu-devel] [PATCH 2/2 V7] qemu, qmp: add inject-nmi qmp command

2011-04-11 Thread Blue Swirl
On Mon, Apr 11, 2011 at 10:01 AM, Markus Armbruster wrote: > Avi Kivity writes: > >> On 04/08/2011 12:41 AM, Anthony Liguori wrote: >>> >>> And it's a good thing to have, but exposing this as the only API to >>> do something as simple as generating a guest crash dump is not the >>> friendliest th

Re: [Qemu-devel] Question about total_sectors in block/vpc.c

2011-04-11 Thread Christoph Hellwig
On Sat, Apr 09, 2011 at 09:05:41PM +0100, Stefan Hajnoczi wrote: > On Sat, Apr 9, 2011 at 5:51 PM, Lyu Mitnick wrote: > > Hell all, > > I have take a look of block/vpc.c and meet a question in vpc_create().?At > > the line > > 550, the code is: > > total_sectors = options->value.n / 512; > > I am

[Qemu-devel] [PATCH 1/3] slirp: Implement TFTP Blocksize option

2011-04-11 Thread Herve Poussineau
From: Herv� Poussineau This option is described in RFC 1783. As this is only an optional field, we may ignore it in some situations and handle it in some others. Here, if client requests a block size bigger than the block size we emit (512 bytes), accept the option with a value of 512 Signed-off

Re: [Qemu-devel] [PATCH v2 0/3] pc-bios: Use iPXE ROMs

2011-04-11 Thread Anthony Liguori
On 04/11/2011 02:35 PM, Alex Williamson wrote: This series replaces our current gPXE based PXE ROMs with iPXE versions from the iPXE project (http://ipxe.org). This version adds ipxe to our submodules so it can be easily included in releases. I'm still including a script for updating these, per

[Qemu-devel] [qemu-iotests] [PATCH] common.config: Fix no $TEST_DIR directory

2011-04-11 Thread Mitnick Lyu
mkdir $TEST_DIR on common.config first run Signed-off-by: Mitnick Lyu --- common.config |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/common.config b/common.config index bdd0530..d5a72af 100644 --- a/common.config +++ b/common.config @@ -102,8 +102,12 @@ export QE

Re: [Qemu-devel] [PATCH] target-sh4: get rid of CPU_{Float, Double}U

2011-04-11 Thread Richard Henderson
On 04/11/2011 08:30 AM, Peter Maydell wrote: > On 11 April 2011 16:19, Richard Henderson wrote: >> On 04/11/2011 08:09 AM, Peter Maydell wrote: >>> (4) I think you should be able to write a helper function for an >>> add as just >>> float32 HELPER(my_float_add)(float32 a, float32 b) { >>> re

Re: [Qemu-devel] [PATCH V12 05/17] xen: Add xenfv machine

2011-04-11 Thread Jan Kiszka
On 2011-04-11 20:10, Anthony PERARD wrote: >>> } >>> >>> static CPUState *pc_new_cpu(const char *cpu_model) >>> @@ -952,7 +957,12 @@ void pc_cpus_init(const char *cpu_model) >>> #endif >>> } >>> >>> -for(i = 0; i < smp_cpus; i++) { >>> +if (!xen_enabled()) { >>> +for(i = 0;

Re: [Qemu-devel] Breaking out virtfs as a standalone server?

2011-04-11 Thread Venkateswararao Jujjuri
On 04/11/2011 06:42 AM, Rob Landley wrote: Right now, there's no decent userspace server for the 9p filesystem that I can find. (In part because the 9P2000.L spec is an undocumented work in progress.) This statement is true for 9P2000.L protocol; But for older protocols we have standalone serve

Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Jan Kiszka
On 2011-04-11 23:05, Luiz Capitulino wrote: > On Mon, 11 Apr 2011 22:04:52 +0200 > Jan Kiszka wrote: > >> On 2011-04-11 21:15, Luiz Capitulino wrote: >>> On Mon, 11 Apr 2011 13:00:32 -0600 >>> Alex Williamson wrote: >>> On Mon, 2011-04-11 at 15:35 -0300, Luiz Capitulino wrote: > On Fri,

Re: [Qemu-devel] KVM call agenda for April 12

2011-04-11 Thread Anthony Liguori
On 04/11/2011 11:35 AM, Juan Quintela wrote: Please, send in any agenda items you are interested in covering. I won't be able to attend due. Regards, Anthony Liguori Later, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.ker

Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Jan Kiszka
On 2011-04-11 22:14, Alex Williamson wrote: > On Mon, 2011-04-11 at 22:04 +0200, Jan Kiszka wrote: >> On 2011-04-11 21:15, Luiz Capitulino wrote: >>> On Mon, 11 Apr 2011 13:00:32 -0600 >>> Alex Williamson wrote: >>> On Mon, 2011-04-11 at 15:35 -0300, Luiz Capitulino wrote: > On Fri, 08 Ap

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-11 Thread Igor Kovalenko
On Mon, Apr 11, 2011 at 9:53 PM, Artyom Tarasenko wrote: > > Can do it, but I'd like to understand first what we are looking for. > How does the main works in this case? Is it something like following? > > translate {brz,pn ; wrpr} -> optimize -> execute ->translate {retl ; > ...} ->optimize -> ex

Re: [Qemu-devel] [PATCH v2 0/3] pc-bios: Use iPXE ROMs

2011-04-11 Thread Alex Williamson
On Mon, 2011-04-11 at 14:48 -0500, Anthony Liguori wrote: > On 04/11/2011 02:35 PM, Alex Williamson wrote: > > This series replaces our current gPXE based PXE ROMs with iPXE > > versions from the iPXE project (http://ipxe.org). This version > > adds ipxe to our submodules so it can be easily inclu

[Qemu-devel] [PATCH 3/3] slirp: improve TFTP performance

2011-04-11 Thread Herve Poussineau
From: Herv� Poussineau When transfering a file, keep it open during the whole transfer, instead of opening/closing it for each block. Signed-off-by: Herv� Poussineau --- slirp/tftp.c | 20 slirp/tftp.h |1 + 2 files changed, 13 insertions(+), 8 deletions(-) diff --g

[Qemu-devel] [PATCH v2 0/3] io-thread optimizations

2011-04-11 Thread Jan Kiszka
These patches were posted before. They bring down the overhead of the io-thread mode for TCG here, specifically when emulating SMP. The major change in this version, besides rebasing, is the exclusion of KVM from the main loop polling optimization. Jan Kiszka (3): Do not drop global mutex for

[Qemu-devel] [PATCH v2 3/3] Do not kick vcpus in TCG mode

2011-04-11 Thread Jan Kiszka
From: Jan Kiszka In TCG mode, iothread and vcpus run in lock-step. So it's pointless to send a signal from qemu_cpu_kick to the vcpu thread - if we got here, the receiver already left the vcpu loop. Signed-off-by: Jan Kiszka --- cpus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-

Re: [Qemu-devel] [PATCH v2 0/3] pc-bios: Use iPXE ROMs

2011-04-11 Thread Alex Williamson
On Mon, 2011-04-11 at 13:57 -0600, Alex Williamson wrote: > On Mon, 2011-04-11 at 14:48 -0500, Anthony Liguori wrote: > > On 04/11/2011 02:35 PM, Alex Williamson wrote: > > > This series replaces our current gPXE based PXE ROMs with iPXE > > > versions from the iPXE project (http://ipxe.org). This

[Qemu-devel] [PATCH v2 2/3] Poll main loop after I/O events were received

2011-04-11 Thread Jan Kiszka
From: Jan Kiszka Polling until select returns empty fdsets helps to reduce the switches between iothread and vcpus. The benefit of this patch is best visible when running an SMP guest on an SMP host in emulation mode. Signed-off-by: Jan Kiszka --- sysemu.h |2 +- vl.c | 12 --

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-11 Thread Artyom Tarasenko
On Mon, Apr 11, 2011 at 5:16 AM, Igor Kovalenko wrote: > On Mon, Apr 11, 2011 at 12:00 AM, Artyom Tarasenko > wrote: >> On Sun, Apr 10, 2011 at 9:41 PM, Igor Kovalenko >> wrote: >>> On Sun, Apr 10, 2011 at 11:37 PM, Artyom Tarasenko >>> wrote: On Sun, Apr 10, 2011 at 8:52 PM, Igor Kovale

Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Alex Williamson
On Mon, 2011-04-11 at 22:04 +0200, Jan Kiszka wrote: > On 2011-04-11 21:15, Luiz Capitulino wrote: > > On Mon, 11 Apr 2011 13:00:32 -0600 > > Alex Williamson wrote: > > > >> On Mon, 2011-04-11 at 15:35 -0300, Luiz Capitulino wrote: > >>> On Fri, 08 Apr 2011 19:50:57 -0500 > >>> Anthony Liguori w

Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Alex Williamson
On Mon, 2011-04-11 at 15:35 -0300, Luiz Capitulino wrote: > On Fri, 08 Apr 2011 19:50:57 -0500 > Anthony Liguori wrote: > > > On 04/08/2011 06:25 PM, Luiz Capitulino wrote: > > > Hi there, > > > > > > Summary: > > > > > > - PXE boot in qemu.git (HEAD f124a41) is quite slow, more than 5 > > > m

Re: [Qemu-devel] [PATCH] target-sh4: get rid of CPU_{Float, Double}U

2011-04-11 Thread Richard Henderson
On 04/11/2011 08:09 AM, Peter Maydell wrote: > (4) I think you should be able to write a helper function for an > add as just > float32 HELPER(my_float_add)(float32 a, float32 b) { > return float32_add(a, b, status); > } While this is a laudable goal, this will fail for hosts that pass all

[Qemu-devel] [Bug 757702] [NEW] Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-11 Thread Anup Patel
Public bug reported: ARMv7a has lot of undefined instruction from its instruction opcode space. This undefined instructions are very useful for replacing sensitive non-priviledged instructions of guest operating systems (virtualization). The undefined instruction exception executes at + 0x4, wher

[Qemu-devel] [PATCH] ppc.ld: add rela.iplt and provide __rela_iplt_{start, end}

2011-04-11 Thread Andreas Schwab
Signed-off-by: Andreas Schwab --- ppc.ld |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/ppc.ld b/ppc.ld index 5248ef1..18511ce 100644 --- a/ppc.ld +++ b/ppc.ld @@ -49,6 +49,12 @@ SECTIONS .rela.sbss2 : { *(.rela.sbss2 .rela.sbss2.* .rela.gnu.linkonce.sb2.*) }

[Qemu-devel] [PATCH v2 1/3] Add ipxe submodule

2011-04-11 Thread Alex Williamson
Signed-off-by: Alex Williamson --- .gitmodules |3 +++ roms/ipxe |1 + 2 files changed, 4 insertions(+), 0 deletions(-) create mode 16 roms/ipxe diff --git a/.gitmodules b/.gitmodules index 44fdd1a..7884471 100644 --- a/.gitmodules +++ b/.gitmodules @@ -7,3 +7,6 @@ [submodule "r

  1   2   >