[Qemu-devel] Patch1 for Mips64 usermode

2011-04-09 Thread Khansa Butt
*commands for patch apply* git apply --ignore-whitespace --ignore-space-change --check ~/patch1 git am --ignore-whitespace --ignore-space-change ~/patch1 *Patch* >From e96e20e50cada1c9e1b65de5925281cdd5659746 Mon Sep 17 00:00:00 2001 From: Ehsan-ul-Haq & Khansa Butt Date: Sat, 9 Apr 2011 10:51:22

[Qemu-devel] Re: [PATCH] ioapic: when switches to level trigger mode, interrupts raised repeatedly.

2011-04-09 Thread Jan Kiszka
On 2011-04-04 04:15, Isaku Yamahata wrote: > On Mon, Apr 04, 2011 at 08:42:07AM +0900, Isaku Yamahata wrote: >> > Thank you for applying. But I found that the patch is wrong and >> > I'm preparing the new one. Can you please revert it? > Here is the corrected patch. The first wrong patch clears the

Re: [Qemu-devel] MIPS64 user mode emulation Patch

2011-04-09 Thread Khansa Butt
Please see the online comments highlighted in red. I'll be sending corrected Patches to the mailing list. On Wed, Mar 30, 2011 at 9:38 PM, Nathan Froyd wrote: > On Sat, Mar 26, 2011 at 11:58:37AM +0500, Khansa Butt wrote: > > Subject: [PATCH] MIPS64 user mode emulation in QEMU > > This patch add

[Qemu-devel] [PATCH 1/2] atapi: Drives can be locked without media present

2011-04-09 Thread Amit Shah
Drivers are free to lock drives without any media present. Such a condition should not result in an error condition. See Table 341 in MMC-5 spec for details. Signed-off-by: Amit Shah --- hw/ide/core.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/ide/core.

[Qemu-devel] [PATCH 2/2] atapi: Report correct errors on guest eject request

2011-04-09 Thread Amit Shah
Table 629 of the MMC-5 spec mentions two different error conditions when a CDROM eject is requested: a) while a disc is inserted and b) while a disc is not inserted. Ensure we return the appropriate error for the present condition of the drive and disc status. Signed-off-by: Amit Shah --- hw/id

[Qemu-devel] Re: Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-09 Thread Blue Swirl
On Sat, Apr 9, 2011 at 2:25 AM, Luiz Capitulino wrote: > Hi there, > > Summary: > >  - PXE boot in qemu.git (HEAD f124a41) is quite slow, more than 5 minutes. Got >   the problem with e1000, virtio and rtl8139. However, pcnet *works* (it's >   as fast as qemu-kvm.git) > >  - PXE boot in qemu-kvm.g

[Qemu-devel] Re: [PATCH 3/5] atapi: GESN: Spin off No Event Available handling into own function

2011-04-09 Thread Amit Shah
On (Fri) 08 Apr 2011 [15:31:49], Kevin Wolf wrote: > Am 08.04.2011 09:15, schrieb Amit Shah: > > Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available status in its > > own function. > > > > Also ensure the buffer the driver sent us is big enough to fill in all > > the data we have -- else jus

[Qemu-devel] Re: [PATCH 4/5] atapi: GESN: Add enums for commonly-used field types

2011-04-09 Thread Amit Shah
On (Fri) 08 Apr 2011 [16:21:38], Kevin Wolf wrote: > Am 08.04.2011 09:15, schrieb Amit Shah: > > Instead of using magic numbers, use enums that are more descriptive of > > the fields being used. > > > > Signed-off-by: Amit Shah > > --- > > hw/ide/core.c | 11 +-- > > 1 files changed, 9

Re: [Qemu-devel] QEMU development for MIPS64 user mode

2011-04-09 Thread Khansa Butt
Please see inline comments highlighted in red. On Wed, Mar 30, 2011 at 12:04 AM, Andreas Färber wrote: > Hi, > > Am 29.03.2011 um 08:49 schrieb Khansa Butt: > > > I have added support for MIPS64 user mode emulation in QEMU and email git >> patch to the qemu-devel mailing list >> but I got no any

[Qemu-devel] [PATCH 1/2] Support for MIPS64 user mode emulation

2011-04-09 Thread Khansa Butt
>From e96e20e50cada1c9e1b65de5925281cdd5659746 Mon Sep 17 00:00:00 2001 From: Ehsan-ul-Haq & Khansa Butt Date: Sat, 9 Apr 2011 10:51:22 +0500 Subject: [PATCH 1/2] Support for MIPS64 user mode emulation Signed-off-by: Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt < kha...@kics.edu.pk> ---

[Qemu-devel] Re: [PATCH] ioapic: when switches to level trigger mode, interrupts raised repeatedly.

2011-04-09 Thread Isaku Yamahata
On Sat, Apr 09, 2011 at 10:38:10AM +0200, Jan Kiszka wrote: > On 2011-04-04 04:15, Isaku Yamahata wrote: > > On Mon, Apr 04, 2011 at 08:42:07AM +0900, Isaku Yamahata wrote: > >> > Thank you for applying. But I found that the patch is wrong and > >> > I'm preparing the new one. Can you please revert

Re: [Qemu-devel] [PATCH] mpc85xx_pci_map_irq: change "unknow" to "unknown".

2011-04-09 Thread Stefan Hajnoczi
Merged into the trivial patches tree: git://repo.or.cz/qemu/stefanha.git trivial-patches A pull request will be sent to merge this into qemu.git. For more information, see http://wiki.qemu.org/Contribute/TrivialPatches. Stefan

[Qemu-devel] [PATCH] ioapic: Do not set irr for masked edge IRQs

2011-04-09 Thread Jan Kiszka
On 2011-04-09 13:05, Isaku Yamahata wrote: > On Sat, Apr 09, 2011 at 10:38:10AM +0200, Jan Kiszka wrote: >> On 2011-04-04 04:15, Isaku Yamahata wrote: >>> On Mon, Apr 04, 2011 at 08:42:07AM +0900, Isaku Yamahata wrote: > Thank you for applying. But I found that the patch is wrong and > I'm

[Qemu-devel] Re: [PATCH v2] configure: avoid basename usage message

2011-04-09 Thread Stefan Hajnoczi
On Fri, Apr 08, 2011 at 02:15:50PM -0500, Scott Wood wrote: > basename prints a missing-argument error when sdlconfig is empty > and we're cross-compiling. > > Signed-off-by: Scott Wood > --- > v2: quote the input to basename rather than introduce an extra test, > as suggested by Stefan. > > co

Re: [Qemu-devel] [PATCH] event: trivial coding style fixes.

2011-04-09 Thread Stefan Hajnoczi
On Sat, Apr 09, 2011 at 12:11:36PM +1000, Brad Hards wrote: > > Signed-off-by: Brad Hards > --- > input.c | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) The rest of the file follows the coding style, so I guess this change is reasonable. Merged into the trivial patch

[Qemu-devel] [PULL] Trivial patches for 8-9 April 2011

2011-04-09 Thread Stefan Hajnoczi
The following changes since commit 6957785773e8a3cc8bd51f0e3172eaccbbaa5f3a: ppce500_mpc8544ds: Fix compile with --enable-debug and --disable-kvm (2011-04-08 12:20:08 +0200) are available in the git repository at: git://repo.or.cz/qemu/stefanha.git trivial-patches Adam Lackorzynski (1):

[Qemu-devel] Re: [PATCH] ioapic: Do not set irr for masked edge IRQs

2011-04-09 Thread Jan Kiszka
On 2011-04-09 13:18, Jan Kiszka wrote: > On 2011-04-09 13:05, Isaku Yamahata wrote: >> On Sat, Apr 09, 2011 at 10:38:10AM +0200, Jan Kiszka wrote: >>> On 2011-04-04 04:15, Isaku Yamahata wrote: On Mon, Apr 04, 2011 at 08:42:07AM +0900, Isaku Yamahata wrote: >> Thank you for applying. But I

[Qemu-devel] Re: [PATCH] ioapic: Do not set irr for masked edge IRQs

2011-04-09 Thread Jan Kiszka
On 2011-04-09 13:26, Jan Kiszka wrote: > On 2011-04-09 13:18, Jan Kiszka wrote: >> On 2011-04-09 13:05, Isaku Yamahata wrote: >>> On Sat, Apr 09, 2011 at 10:38:10AM +0200, Jan Kiszka wrote: On 2011-04-04 04:15, Isaku Yamahata wrote: > On Mon, Apr 04, 2011 at 08:42:07AM +0900, Isaku Yamahat

[Qemu-devel] Re: [PATCH] ioapic: Do not set irr for masked edge IRQs

2011-04-09 Thread Isaku Yamahata
On Sat, Apr 09, 2011 at 01:26:07PM +0200, Jan Kiszka wrote: > On first glance, it looks like KVM's in-kernel IOAPIC model is affected > by the same issue. Agreed. > As you have the test case at hand, could you run it > against qemu-kvm which stresses the kernel version? Unfortunately I don't h

[Qemu-devel] [Bug 721659] Re: qemu-kvm-0.13.0 doesn't pass USB devices to the VM

2011-04-09 Thread Brad Hards
Hi, Thanks for reporting this problem. Can you tell me a bit more about your configuration? For example: What are the guest and host operating systems? Is it always "need -1"? Do you ever see "need 1"? What is the device you're trying to open? Can you show the USB descriptors (e.g. from lsusb)?

[Qemu-devel] Re: Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-09 Thread Stefan Hajnoczi
On Sat, Apr 9, 2011 at 1:50 AM, Anthony Liguori wrote: > On 04/08/2011 06:25 PM, Luiz Capitulino wrote: >> >> Hi there, >> >> Summary: >> >>  - PXE boot in qemu.git (HEAD f124a41) is quite slow, more than 5 minutes. >> Got >>    the problem with e1000, virtio and rtl8139. However, pcnet *works* >>

Re: [Qemu-devel] [PULL] Trivial patches for 8-9 April 2011

2011-04-09 Thread Aurelien Jarno
On Sat, Apr 09, 2011 at 12:25:42PM +0100, Stefan Hajnoczi wrote: > The following changes since commit 6957785773e8a3cc8bd51f0e3172eaccbbaa5f3a: > > ppce500_mpc8544ds: Fix compile with --enable-debug and --disable-kvm > (2011-04-08 12:20:08 +0200) > > are available in the git repository at: >

[Qemu-devel] Re: [PATCH 5/5] atapi: Implement 'media' subcommand of GET_EVENT_STATUS_NOTIFICATION command

2011-04-09 Thread Amit Shah
On (Fri) 08 Apr 2011 [18:17:38], Kevin Wolf wrote: > Am 08.04.2011 09:15, schrieb Amit Shah: > > Implement the 'media' sub-command of the GET_EVENT_STATUS_NOTIFICATION > > command. This helps us report tray open, tray closed, no media, media > > present states to the guest. > > > > Newer Linux ke

[Qemu-devel] [PATCH] ppc: remove a write-only variable

2011-04-09 Thread Blue Swirl
Remove a write-only variable, spotted by GCC 4.6.0: /src/qemu/hw/ppc.c: In function 'power7_set_irq': /src/qemu/hw/ppc.c:255:9: error: variable 'cur_level' set but not used [-Werror=unused-but-set-variable] Signed-off-by: Blue Swirl --- hw/ppc.c |2 -- 1 files changed, 0 insertions(+), 2 del

[Qemu-devel] Re: [PATCH] ppc: remove a write-only variable

2011-04-09 Thread Alexander Graf
Am 09.04.2011 um 16:56 schrieb Blue Swirl : > Remove a write-only variable, spotted by GCC 4.6.0: > /src/qemu/hw/ppc.c: In function 'power7_set_irq': > /src/qemu/hw/ppc.c:255:9: error: variable 'cur_level' set but not used > [-Werror=unused-but-set-variable] > > Signed-off-by: Blue Swirl > -

Re: [Qemu-devel] [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode

2011-04-09 Thread Aurelien Jarno
On Sun, Apr 03, 2011 at 01:16:26PM -0700, Jordan Justen wrote: > When checking pfl->rom_mode for when to lazily reenter ROMD mode, > the value was check was the opposite of what it should have been. > This prevent the part from returning to ROMD mode after a write > was made to the CFI rom region.

Re: [Qemu-devel] [PATCH 0/4] acpi: factor out fixed hardware logic

2011-04-09 Thread Aurelien Jarno
On Fri, Mar 25, 2011 at 07:54:37PM +0900, Isaku Yamahata wrote: > So far acpi fixed hardware logic (PM TMR, PM1a_EVT, PM1_CNT and GPE0) > are embedded in each device.(acpi_piix.c and vt82c686). > This patch series factors out the logic and consolidate them. > This was the part of q35 chipset patch

[Qemu-devel] Question about total_sectors in block/vpc.c

2011-04-09 Thread Lyu Mitnick
Hell all, I have take a look of block/vpc.c and meet a question in vpc_create(). At the line 550, the code is: total_sectors = options->value.n / 512; I am wondering whether the size between total_sectors * 512 and options->value.n would be discard. Thanks Mitnick

Re: [Qemu-devel] Question about total_sectors in block/vpc.c

2011-04-09 Thread Stefan Hajnoczi
On Sat, Apr 9, 2011 at 5:51 PM, Lyu Mitnick wrote: > Hell all, > I have take a look of block/vpc.c and meet a question in vpc_create(). At > the line > 550, the code is: > total_sectors = options->value.n / 512; > I am wondering whether the size between total_sectors * 512 > and options->value.n >

[Qemu-devel] [PATCH] configure: disable opengl per default

2011-04-09 Thread Michael Walle
There is a bug in nvidia's binary GPU driver, which causes a segmentation fault if linked to libGL. Signed-off-by: Michael Walle --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 2bb3faa..be40a31 100755 --- a/configure +++ b/config

Re: [Qemu-devel] [PATCH] smbus_eeprom: consolidate smbus eeprom creation oc pc_piix, mips_mapta, mips_fulong

2011-04-09 Thread Aurelien Jarno
On Tue, Apr 05, 2011 at 11:07:06AM +0900, Isaku Yamahata wrote: > consolidate smbus initialization for pc_piix, mips_malta and mips_fulong. > > Cc: Aurelien Jarno > Cc: Huacai Chen > Signed-off-by: Isaku Yamahata > Reviewed-by: Aurelien Jarno > --- > hw/mips_fulong2e.c |9 + > hw/

Re: [Qemu-devel] [PATCH 4/4] vnc: Limit r/w access to size of allocated memory

2011-04-09 Thread Aurelien Jarno
On Mon, Mar 21, 2011 at 09:34:38AM +0100, Corentin Chary wrote: > From: Stefan Weil > > This fixes memory reads and writes which exceeded the upper limit > of allocated memory vd->guest.ds->data and vd->server->data. > > Cc: Anthony Liguori > Signed-off-by: Stefan Weil > Signed-off-by: Corenti

Re: [Qemu-devel] [PATCH 1/4] vnc: tight: Fix crash after 2GB of output

2011-04-09 Thread Aurelien Jarno
On Mon, Mar 21, 2011 at 09:34:35AM +0100, Corentin Chary wrote: > From: Michael Tokarev > > fix 2Gb integer overflow in in VNC tight and zlib encodings > > As found by Roland Dreier (excellent > catch!), when amount of VNC compressed data produced by zlib > and sent to client exceeds 2Gb, integ

Re: [Qemu-devel] [PATCH 1/3] cpu-common: Modify cpu_physical_memory_read and cpu_physical_memory_write

2011-04-09 Thread Aurelien Jarno
On Sat, Mar 26, 2011 at 09:06:55PM +0100, Stefan Weil wrote: > A lot of calls don't operate on bytes but on words or on structured data. > So instead of a pointer to uint8_t, a void pointer is the better choice. > > This allows removing many type casts. > > (Some very early implementations of mem

Re: [Qemu-devel] [PATCH 2/3] exec: Remove a type cast which is no longer needed

2011-04-09 Thread Aurelien Jarno
On Sat, Mar 26, 2011 at 09:06:56PM +0100, Stefan Weil wrote: > All other type casts in calls of cpu_physical_memory_write are > used by hardware emulations and will be fixed by separate patches. > > Cc: Blue Swirl > Signed-off-by: Stefan Weil > --- > exec.c |2 +- > 1 files changed, 1 inser

Re: [Qemu-devel] [PATCH 3/3] monitor: Remove some type casts which are no longer needed

2011-04-09 Thread Aurelien Jarno
On Sat, Mar 26, 2011 at 09:11:05PM +0100, Stefan Weil wrote: > All other type casts in calls of cpu_physical_memory_read are > used by hardware emulations and will be fixed by separate patches. > > v2: Fixed subject line > > Cc: Blue Swirl > Signed-off-by: Stefan Weil > --- > monitor.c | 48

Re: [Qemu-devel] [PATCH] [arm m68k] move helpers.h to helper.h

2011-04-09 Thread Aurelien Jarno
On Sun, Mar 27, 2011 at 09:42:23PM +0200, Lluís wrote: > This provides a consistent naming scheme across all targets. > > Signed-off-by: Lluís Vilanova > --- > target-arm/helper.c|2 > target-arm/helper.h| 475 > > target-arm/he

Re: [Qemu-devel] [PATCH] Fix conversions from pointer to tcg_target_long

2011-04-09 Thread Aurelien Jarno
On Sat, Apr 02, 2011 at 01:36:31PM +0200, Stefan Weil wrote: > tcg_gen_exit_tb takes a parameter of type tcg_target_long, > so the type casts of pointer to long should be replaced by > type casts of pointer to tcg_target_long (suggested by Blue Swirl). > > These changes are needed for build enviro

[Qemu-devel] qemu_malloc failing

2011-04-09 Thread Brad Hards
Hi, I'm trying to investigate a bug (crash) that I see when attaching a USB device (a UVC webcam) from the host to the guest. I'm running it as: sudo gdb --args /opt/bin/qemu -hda ubuntu-test -name kubuntu-qemu -usb -device usb-tablet -m 1024 -serial stdio -usbdevice host:0c45:6450 (I've tried

Re: [Qemu-devel] qemu_malloc failing

2011-04-09 Thread Mulyadi Santosa
Hi... On Sun, Apr 10, 2011 at 09:08, Brad Hards wrote: > Program received signal SIGSEGV, Segmentation fault. > 0x75a4e66c in malloc_consolidate (av=0x75d55e40) at malloc.c:5161 > 5161    malloc.c: No such file or directory. >        in malloc.c > (gdb) bt > #0  0x75a4e66c in

Re: [Qemu-devel] [PATCH 1/3] cpu-common: Modify cpu_physical_memory_read and cpu_physical_memory_write

2011-04-09 Thread Stefan Weil
Am 10.04.2011 00:37, schrieb Aurelien Jarno: On Sat, Mar 26, 2011 at 09:06:55PM +0100, Stefan Weil wrote: A lot of calls don't operate on bytes but on words or on structured data. So instead of a pointer to uint8_t, a void pointer is the better choice. This allows removing many type casts. (So

Re: [Qemu-devel] [PATCH 4/4] vnc: Limit r/w access to size of allocated memory

2011-04-09 Thread Stefan Weil
Am 10.04.2011 00:17, schrieb Aurelien Jarno: On Mon, Mar 21, 2011 at 09:34:38AM +0100, Corentin Chary wrote: From: Stefan Weil This fixes memory reads and writes which exceeded the upper limit of allocated memory vd->guest.ds->data and vd->server->data. Cc: Anthony Liguori Signed-off-by: Ste

Re: [Qemu-devel] qemu_malloc failing

2011-04-09 Thread Stefan Hajnoczi
On Sun, Apr 10, 2011 at 3:08 AM, Brad Hards wrote: > #3  0x0042b3d6 in qemu_malloc (size=2128) at qemu-malloc.c:49 It's only slightly more than 2 KB. When malloc(3) fails it returns NULL, it doesn't crash. As Mulyadi suggested, this looks like heap corruption. If you have no idea where