Re: [Qemu-devel] Qemu 0.9.1

2011-03-13 Thread Andreas Färber
Hi Marco, Am 07.03.2011 um 17:25 schrieb Marco Cianfriglia: I'm working with qemu 0.9.1 for my thesis and I'm trying to understand how a full-emulation (qemu without kvm or kqemu) Virtual Machine works at low level. I studied your smart source code but I don't understand how qemu manages

[Qemu-devel] Re: [PATCH] moving eeprom initialization

2011-03-13 Thread Blue Swirl
Thanks, applied. On Sun, Mar 6, 2011 at 11:27 PM, William Dauchy wrote: > The initialization should not be only on reset but also when initializing > the device. > It resolves a bug when hot plugging a pci network device: the mac address > was always null. > > Signed-off-by: William Dauchy > Sig

[Qemu-devel] Re: [PATCH RESEND] hw/fmopl: Fix buffer access out-of-bounds errors

2011-03-13 Thread Blue Swirl
Thanks, applied. On Sat, Mar 12, 2011 at 6:43 PM, Stefan Weil wrote: > Index 75 is one too large for AR_TABLE[75], DR_TABLE[75]. > This error was reported by cppcheck. > > hw/fmopl.c:600: error: Buffer access out-of-bounds: OPL.AR_TABLE > hw/fmopl.c:601: error: Buffer access out-of-bounds: OPL.DR

[Qemu-devel] [PATCH RESEND(REBASED)] Fix trivial "endianness bugs"

2011-03-13 Thread Stefan Weil
Replace endianess -> endianness. Signed-off-by: Stefan Weil --- audio/sdlaudio.c | 20 ++-- block/vdi.c |4 ++-- target-microblaze/translate.c |2 +- target-mips/cpu.h |2 +- usb-bsd.c |2 +- 5 files

[Qemu-devel] Re: [PATCH v4 upstream 00/21] Win32 iothread support

2011-03-13 Thread Blue Swirl
Thanks, applied all. On Sat, Mar 12, 2011 at 6:43 PM, Paolo Bonzini wrote: > Here is again the full series for Win32 iothread support.  It should be > ready now. > > Patches 1 to 5 are generic Win32 improvements, including the qemu-thread > implementation.  To simplify the dependencies, I think i

[Qemu-devel] [PATCH] win32: implement missing timersub

2011-03-13 Thread Blue Swirl
Implement and wrap timersub() for Win32. Signed-off-by: Blue Swirl --- osdep.h | 19 +-- ui/vnc.c |6 +++--- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/osdep.h b/osdep.h index 27eedcf..8c45000 100644 --- a/osdep.h +++ b/osdep.h @@ -8,9 +8,7 @@ #includ

Re: [Qemu-devel] [PATCH -V3 1/8] hw/9pfs: Add V9fsfidmap in preparation for adding fd reclaim

2011-03-13 Thread Stefan Hajnoczi
On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V wrote: > Signed-off-by: Aneesh Kumar K.V > --- >  hw/9pfs/virtio-9p.c |  327 > ++- >  hw/9pfs/virtio-9p.h |   22 +++- >  2 files changed, 184 insertions(+), 165 deletions(-) I don't understand why t

Re: [Qemu-devel] [PATCH -V3 2/8] hw/9pfs: Add file descriptor reclaim support

2011-03-13 Thread Stefan Hajnoczi
On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V wrote: > @@ -107,7 +108,12 @@ static int v9fs_do_closedir(V9fsState *s, DIR *dir) > >  static int v9fs_do_open(V9fsState *s, V9fsString *path, int flags) >  { > -    return s->ops->open(&s->ctx, path->data, flags); > +    int fd; > +    fd = s->ops-

Re: [Qemu-devel] [PATCH -V3 3/8] hw/9pfs: Use v9fs_do_close instead of close

2011-03-13 Thread Stefan Hajnoczi
On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V wrote: > @@ -1873,7 +1873,7 @@ static void v9fs_post_lcreate(V9fsState *s, > V9fsLcreateState *vs, int err) >         vs->fidp->fsmap.fid_type = P9_FID_NONE; >         err = -errno; >         if (vs->fidp->fsmap.fs.fd > 0) { For completeness: vs->

Re: [Qemu-devel] [PATCH -V3 4/8] hw/9pfs: Implement syncfs

2011-03-13 Thread Stefan Hajnoczi
On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V wrote: > +static void v9fs_post_do_syncfs(V9fsState *s, V9fsPDU *pdu, int err) > +{ > +    if (err == -1) { > +        err = -errno; > +    } errno may have been clobbered by any standard library function/syscall invoked by this thread before v9fs_

Re: [Qemu-devel] [PATCH -V3 5/8] hw/9pfs: Add open flag to fid

2011-03-13 Thread Stefan Hajnoczi
On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V wrote: > +static int get_dotl_openflags(int oflags) > +{ > +    int flags; > +    /* > +     * Since we can share the fd between multiple fids, > +     * open the file in read write mode > +     */ I didn't know that fds are shared between fids. A

Re: [Qemu-devel] [PATCH -V3 6/8] hw/9pfs: Add directory reclaim support

2011-03-13 Thread Stefan Hajnoczi
On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V wrote: > Signed-off-by: Aneesh Kumar K.V > --- >  hw/9pfs/virtio-9p.c |   21 +++-- >  1 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c > index 1fa7256..293a562 100644 > ---

Re: [Qemu-devel] [PATCH] win32: implement missing timersub

2011-03-13 Thread Stefan Weil
Am 13.03.2011 15:49, schrieb Blue Swirl: Implement and wrap timersub() for Win32. Signed-off-by: Blue Swirl --- osdep.h | 19 +-- ui/vnc.c | 6 +++--- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/osdep.h b/osdep.h index 27eedcf..8c45000 100644 --- a/osdep.h +++

Re: [Qemu-devel] [PATCH -V3 7/8] hw/9pfs: Add new virtfs option cache=none to skip host page cache

2011-03-13 Thread Stefan Hajnoczi
On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V wrote: > cache=none implies the file are opened in the host with O_SYNC open flag O_SYNC does not bypass the host page cache. It ensures that writes only complete once data has been written to the disk. O_DIRECT is a hint to bypass the host page

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-03-13 Thread Anthony Liguori
On 03/12/2011 11:51 PM, Chunqiang Tang wrote: In short, FVD's internal snapshot achieves the ideal properties of G1-G6, by 1) using the reference count table to only track "static" snapshots, 2) not keeping the reference count table in memory, 3) not updating the on-disk "static" reference count

[Qemu-devel] [PATCH] w32: Add missing functions qemu_mutex_destroy, qemu_cond_destroy

2011-03-13 Thread Stefan Weil
These functions were missing in commit 9257d46d55f1fe4e8209be9a6870e339ac3266fe. Both functions are needed for compilations with configuration --enable-vnc-thread. Cc: Paolo Bonzini Cc: Blue Swirl Signed-off-by: Stefan Weil --- qemu-thread-win32.c | 21 + 1 files changed

[Qemu-devel] [PATCH] vl.c: Replace -virtfs string manipulation with QemuOpts

2011-03-13 Thread Stefan Hajnoczi
The -virtfs option creates an fsdev representing the pass-through file system and a guest-visible virtio-9p-pci device that can access this file system. This patch replaces the string manipulation used to build and reparse option lists with direct QemuOpts calls. Removing the string manipulation

Re: [Qemu-devel] [PATCH -V3 2/8] hw/9pfs: Add file descriptor reclaim support

2011-03-13 Thread Aneesh Kumar K. V
On Sun, 13 Mar 2011 16:08:29 +, Stefan Hajnoczi wrote: > On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V > wrote: > > @@ -107,7 +108,12 @@ static int v9fs_do_closedir(V9fsState *s, DIR *dir) > > > >  static int v9fs_do_open(V9fsState *s, V9fsString *path, int flags) > >  { > > -    return s-

Re: [Qemu-devel] [PATCH -V3 3/8] hw/9pfs: Use v9fs_do_close instead of close

2011-03-13 Thread Aneesh Kumar K. V
On Sun, 13 Mar 2011 16:10:20 +, Stefan Hajnoczi wrote: > On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V > wrote: > > @@ -1873,7 +1873,7 @@ static void v9fs_post_lcreate(V9fsState *s, > > V9fsLcreateState *vs, int err) > >         vs->fidp->fsmap.fid_type = P9_FID_NONE; > >         err = -e

Re: [Qemu-devel] [PATCH -V3 4/8] hw/9pfs: Implement syncfs

2011-03-13 Thread Aneesh Kumar K. V
On Sun, 13 Mar 2011 16:24:13 +, Stefan Hajnoczi wrote: > On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V > wrote: > > +static void v9fs_post_do_syncfs(V9fsState *s, V9fsPDU *pdu, int err) > > +{ > > +    if (err == -1) { > > +        err = -errno; > > +    } > > errno may have been clobbere

Re: [Qemu-devel] [PATCH -V3 5/8] hw/9pfs: Add open flag to fid

2011-03-13 Thread Aneesh Kumar K. V
On Sun, 13 Mar 2011 16:38:39 +, Stefan Hajnoczi wrote: > On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V > wrote: > > +static int get_dotl_openflags(int oflags) > > +{ > > +    int flags; > > +    /* > > +     * Since we can share the fd between multiple fids, > > +     * open the file in re

[Qemu-devel] User emulators broken

2011-03-13 Thread Blue Swirl
Build for user emulators fails: LINK i386-linux-user/qemu-i386 ../simpletrace.o: In function `st_init': /src/qemu/simpletrace.c:350: undefined reference to `error_report' Maybe error_report() should be replaced with fprintf() or qemu-error-user.c could be added.

Re: [Qemu-devel] [PATCH -V3 6/8] hw/9pfs: Add directory reclaim support

2011-03-13 Thread Aneesh Kumar K. V
On Sun, 13 Mar 2011 16:42:56 +, Stefan Hajnoczi wrote: > On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V > wrote: > > Signed-off-by: Aneesh Kumar K.V > > --- > >  hw/9pfs/virtio-9p.c |   21 +++-- > >  1 files changed, 19 insertions(+), 2 deletions(-) > > > > diff --git a/hw/

Re: [Qemu-devel] [PATCH -V3 7/8] hw/9pfs: Add new virtfs option cache=none to skip host page cache

2011-03-13 Thread Aneesh Kumar K. V
On Sun, 13 Mar 2011 17:23:50 +, Stefan Hajnoczi wrote: > On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V > wrote: > > cache=none implies the file are opened in the host with O_SYNC open flag > > O_SYNC does not bypass the host page cache. It ensures that writes > only complete once data ha

Re: [Qemu-devel] [PATCH -V3 1/8] hw/9pfs: Add V9fsfidmap in preparation for adding fd reclaim

2011-03-13 Thread Aneesh Kumar K. V
On Sun, 13 Mar 2011 15:46:29 +, Stefan Hajnoczi wrote: > On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V > wrote: > > Signed-off-by: Aneesh Kumar K.V > > --- > >  hw/9pfs/virtio-9p.c |  327 > > ++- > >  hw/9pfs/virtio-9p.h |   22 +++- > >  2

[Qemu-devel] Re: User emulators broken

2011-03-13 Thread Stefan Hajnoczi
On Sun, Mar 13, 2011 at 7:01 PM, Blue Swirl wrote: > Build for user emulators fails: >  LINK  i386-linux-user/qemu-i386 > ../simpletrace.o: In function `st_init': > /src/qemu/simpletrace.c:350: undefined reference to `error_report' > > Maybe error_report() should be replaced with fprintf() or > qe

[Qemu-devel] [PATCH] simpletrace: Move st_init() error reporting

2011-03-13 Thread Stefan Hajnoczi
User emulator builds do not have error_report() so it should not be used by simpletrace.c. In fact, error reporting inside simpletrace.c is inappropriate and should be done by the caller instead. This patch moves st_init() error reporting out to its caller, vl.c:main(). Reported-by: Blue Swirl

[Qemu-devel] [PATCH] Added missing sigbus_reraise() to non-Linux platforms

2011-03-13 Thread Palle Lyckegaard
Hi, File cpus.c seems to be missing sigbus_reraise() on non-Linux platforms. The following patch fixes building qemu on Solaris 11 Express (SPARC). Regards Palle Signed-off-by: Palle Lyckegaard --- cpus.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/cpus.c

Re: [Qemu-devel] [PATCH -V3 1/8] hw/9pfs: Add V9fsfidmap in preparation for adding fd reclaim

2011-03-13 Thread Stefan Hajnoczi
On Sun, Mar 13, 2011 at 7:06 PM, Aneesh Kumar K. V wrote: > On Sun, 13 Mar 2011 15:46:29 +, Stefan Hajnoczi > wrote: >> On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V >> wrote: >> > @@ -185,17 +188,22 @@ typedef struct V9fsXattr >> >     int flags; >> >  } V9fsXattr; >> > >> > +typedef st

Re: [Qemu-devel] [PATCH -V3 7/8] hw/9pfs: Add new virtfs option cache=none to skip host page cache

2011-03-13 Thread Stefan Hajnoczi
On Sun, Mar 13, 2011 at 7:04 PM, Aneesh Kumar K. V wrote: > On Sun, 13 Mar 2011 17:23:50 +, Stefan Hajnoczi > wrote: >> On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V >> wrote: >> > cache=none implies the file are opened in the host with O_SYNC open flag >> >> O_SYNC does not bypass the h

Re: [Qemu-devel] [PATCH] rbd: don't link with -lcrypto

2011-03-13 Thread Christian Brunner
You are right, libcrypto can be omitted. (Recent versions of ceph use crypto++ anyway.) Thanks, Christian Reviewed-by: Christian Brunner 2011/3/7 Aurelien Jarno : > rbd support tries to both link with -lrados and -lcrypto. While the > first one is of course necessary, the second is not neces

Re: [Qemu-devel] [PATCH 00/17 v3] LatticeMico32 target

2011-03-13 Thread Michael Walle
Am Montag 07 März 2011, 14:20:09 schrieb Edgar E. Iglesias: > Got a conflict on patch nr 16 though. Would be good if you could double > check upstreams configure to verify I resolved it correctly... It's OK, thanks. -- Michael

[Qemu-devel] RFC: Emulation of PC System Flash V2

2011-03-13 Thread Jordan Justen
Thanks to everyone's feedback on my previous proposal (in particular Jan Kiszka for pointing out hw/pflash_cfi*), I now have a second, much simpler proposal. http://wiki.qemu.org/Features/PC_System_Flash One area where this deviates from some of the previous feedback is in the command line parame

[Qemu-devel] [Bug 732155] Re: system_reset doesn't work with qemu-kvm and latest SeaBIOS

2011-03-13 Thread Matthew Bloch
This patch to SeaBIOS seems to fix it, but I still think there's a bug in kvm if it behaves differently with or without the "-no-kvm" flag. ** Tags added: bios kvm reset ** Patch added: "qemu-reset.patch" https://bugs.launchpad.net/qemu/+bug/732155/+attachment/1906859/+files/qemu-reset.patch

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-03-13 Thread Chunqiang Tang
> > In short, FVD's internal snapshot achieves the ideal properties of G1-G6, > > by 1) using the reference count table to only track "static" snapshots, 2) > > not keeping the reference count table in memory, 3) not updating the > > on-disk "static" reference count table when the VM runs, and 4)

Re: [Qemu-devel] [PATCH 1/7] target-arm: Make Neon helper routines use correct FP status

2011-03-13 Thread Nathan Froyd
On Fri, Mar 11, 2011 at 10:31:31PM +, Peter Maydell wrote: > On 11 March 2011 18:30, Nathan Froyd wrote: > > Is there a reason that you don't simply use the global env rather than > > passing in an extra parameter everywhere? > > Just following the pattern that generally seems to be used by >

[Qemu-devel] qemu audio alsa support

2011-03-13 Thread Wasim Muhammed
Hi , Can anyone tell me what are the dependencies for building qemu with alsa support ,My build is failing with the below error Error: alsa check failed Make sure to have the alsa libs and headers installed. Can anyone give me the list of packages to be installed ,I am do