Re: [Qemu-devel] [PATCH] Add qcow2 documentation

Am 09.03.2011 19:08, schrieb Dushyant Bansal: > On Tuesday 08 March 2011 05:17 PM, Kevin Wolf wrote: >> This adds a description of the qcow2 file format to the docs/ directory. >> Besides documenting what's there, which is never wrong, the document should >> provide a good basis for the discussion

Re: [Qemu-devel] [PATCH 1/2][RESEND] vl: initialize all displaystates

Hello, On 3/10/11, andrzej zaborowski wrote: > On 4 March 2011 01:48, Dmitry Eremin-Solenikov wrote: >> Init not only first displaystate, but all. Otherwise machines with >> multiple display devices (e.g. tosa, as it exists now) will just >> segfault on ds switch. >> >> Signed-off-by: Dmitry Er

[Qemu-devel] Re: [PULL (resend, rebase) 2/5] virtio-serial: Disallow generic ports at id 0

On (Thu) 10 Mar 2011 [11:39:16], Amit Shah wrote: > Port 0 is reserved for virtconsole devices for backward compatibility > with the old -virtioconsole (from qemu 0.12) device type. > > libvirt prior to commit 8e28c5d40200b4c5d483bd585d237b9d870372e5 used > port 0 for generic ports. libvirt will

[Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus

Currently reset handler is registered for System bus twice: once during bus creation and once in vl.c. Remove the second qemu_register_reset() invocation. Also while we are at it, remove incorrect check at qbus_create_inplace(): when system bus is created, main_system_bus is NULL (as it's not yet c

[Qemu-devel] Re: RFC: emulation of system flash

On 03/10/2011 06:51 AM, Jordan Justen wrote: Hi all, I have documented a simple flash-like device which I think could be useful for qemu/kvm in some cases. (Particularly for allowing persistent UEFI non-volatile variables.) http://wiki.qemu.org/Features/System_Flash Let me know if you have an

Re: [Qemu-devel] [PATCH] QMP: add snapshot_blkdev_sync command

On 03/09/11 18:03, Anthony Liguori wrote: > On 03/09/2011 10:01 AM, Kevin Wolf wrote: >>> I'm not sure blkdev is the right prefix. Kevin, what are your thoughts >>> here? Does 'blkdev' make sense for any command operating on a block >>> device (that is, a qdev device that happens to have a block

Re: [Qemu-devel] [PATCH] QMP: add snapshot_blkdev_sync command

Am 09.03.2011 18:03, schrieb Anthony Liguori: > On 03/09/2011 10:01 AM, Kevin Wolf wrote: >> Am 09.03.2011 16:46, schrieb Anthony Liguori: >>> On 03/09/2011 09:37 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen Add QMP bits for snapshot_blkdev_sync command. This is the same as

Re: [Qemu-devel] Issue with snapshot outside qcow2 disk - qemu 0.14.0

On Thu, Mar 10, 2011 at 1:51 AM, SAURAV LAHIRI wrote: > Scenario 1: > 1) I executed following with the vm in shutdown state. > "#qemu-img snapshot -c snap1 /home/user1/lucid-vm2" Here you are snapshotting the current disk image and storing the snapshot away as "snap1". > 2) Brought the VM Up. >

Re: [Qemu-devel] Issue with snapshot outside qcow2 disk - qemu 0.14.0

On 03/10/11 10:27, Stefan Hajnoczi wrote: >> Is Scenario 2 safe where in the copying the snapshot outside the original >> qcow2 is being executed with the VM running. This is because if this is safe >> then this could be an approach as it would not require a long downtime for >> the VM. > > The

[Qemu-devel] Re: RFC: emulation of system flash

On Wed, Mar 09, 2011 at 08:51:23PM -0800, Jordan Justen wrote: > Hi all, > > I have documented a simple flash-like device which I think could be > useful for qemu/kvm in some cases. (Particularly for allowing > persistent UEFI non-volatile variables.) > > http://wiki.qemu.org/Features/System_Fla

Re: [Qemu-devel] Issue with snapshot outside qcow2 disk - qemu 0.14.0

On Thu, Mar 10, 2011 at 9:32 AM, Jes Sorensen wrote: > On 03/10/11 10:27, Stefan Hajnoczi wrote: >> I have CCed Jes who has been working on a live snapshot mechanism.  He >> recently added the snapshot_blkdev monitor command that takes a >> snapshot of a block device while the VM is running.  A ne

Re: [Qemu-devel] Issue with snapshot outside qcow2 disk - qemu 0.14.0

On 03/10/11 10:58, Stefan Hajnoczi wrote: > On Thu, Mar 10, 2011 at 9:32 AM, Jes Sorensen wrote: >> On 03/10/11 10:27, Stefan Hajnoczi wrote: >>> I have CCed Jes who has been working on a live snapshot mechanism. He >>> recently added the snapshot_blkdev monitor command that takes a >>> snapshot

[Qemu-devel] Re: [V8 PATCH 05/11] virtio-9p: Add support to open a file in chroot environment

On Wed, Mar 9, 2011 at 5:15 PM, M. Mohan Kumar wrote: > +/* Return opened file descriptor on success or -errno on error */ > +int v9fs_request(FsContext *fs_ctx, V9fsFileObjectRequest *request) >  { > -    (void)v9fs_receivefd; > -    (void)v9fs_write_request; > +    int fd, sock_error; > +    qem

[Qemu-devel] Re: RFC: emulation of system flash

On 2011-03-10 10:47, Gleb Natapov wrote: > On Wed, Mar 09, 2011 at 08:51:23PM -0800, Jordan Justen wrote: >> Hi all, >> >> I have documented a simple flash-like device which I think could be >> useful for qemu/kvm in some cases. (Particularly for allowing >> persistent UEFI non-volatile variables.

[Qemu-devel] [PATCH 5/9] vmstate: add VMSTATE_INT64_ARRAY

Signed-off-by: Juan Quintela --- hw/hw.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 0ed63c5..d801694 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -802,6 +802,12 @@ extern const VMStateDescription vmstate_usb_device; #define VMSTATE_UINT32_ARRAY

[Qemu-devel] [PATCH 0/9] VMState infrastructure

Hi This is the infrastructure that I pushed on my previous series. Anthony don't like 58 patches series (why? O:-) And then split the series in three. This are the infrastructure patches needed for the other two series. Anthony, please apply. Later, Juan. Juan Quintela (9): vmstate: add VMST

[Qemu-devel] [PATCH 1/9] vmstate: add VMSTATE_UINT32_EQUAL

Signed-off-by: Juan Quintela --- hw/hw.h |4 savevm.c | 21 + 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 4e2d592..0299207 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -343,6 +343,7 @@ extern const VMStateInfo vmstate_info_int64

[Qemu-devel] [PATCH 2/9] vmstate: Fix varrays with uint8 indexes

Signed-off-by: Juan Quintela --- hw/hw.h |5 +++-- savevm.c |2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 0299207..40c6396 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -298,6 +298,7 @@ enum VMStateFlags { VMS_VARRAY_UINT16= 0x080, /* Arr

[Qemu-devel] [PATCH 3/9] vmstate: add UINT32 VARRAYS

Signed-off-by: Juan Quintela --- hw/hw.h | 11 +++ savevm.c |2 ++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 40c6396..6e78fa9 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -299,6 +299,7 @@ enum VMStateFlags { VMS_VBUFFER = 0x100,

[Qemu-devel] [PATCH 9/9] vmstate: move timers to use test instead of version

Signed-off-by: Juan Quintela --- hw/hw.h | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 4e09f18..1b09039 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -399,6 +399,15 @@ extern const VMStateInfo vmstate_info_unused_buffer; .offset =

[Qemu-devel] [PATCH 6/9] vmstate: add VMSTATE_STRUCT_VARRAY_UINT32

Signed-off-by: Juan Quintela --- hw/hw.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index d801694..c198ce8 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -539,6 +539,16 @@ extern const VMStateInfo vmstate_info_unused_buffer; .offset = offs

[Qemu-devel] [PATCH 8/9] vmstate: be able to store/save a pci device from a pointer

Signed-off-by: Juan Quintela --- hw/hw.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 9df1c2c..4e09f18 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -629,6 +629,14 @@ extern const VMStateDescription vmstate_pci_device; .offset = vmstate_

[Qemu-devel] [PATCH 4/9] vmstate: add VMSTATE_STRUCT_VARRAY_INT32

Signed-off-by: Juan Quintela --- hw/hw.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 6e78fa9..0ed63c5 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -529,6 +529,16 @@ extern const VMStateInfo vmstate_info_unused_buffer; .offset = vmst

[Qemu-devel] [PATCH 7/9] vmstate: Add a way to send a partial array

Signed-off-by: Juan Quintela --- hw/hw.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index c198ce8..9df1c2c 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -429,6 +429,15 @@ extern const VMStateInfo vmstate_info_unused_buffer; .offset = vmstat

[Qemu-devel] Re: RFC: emulation of system flash

On 2011-03-10 12:27, Jan Kiszka wrote: > On 2011-03-10 10:47, Gleb Natapov wrote: >> On Wed, Mar 09, 2011 at 08:51:23PM -0800, Jordan Justen wrote: >>> Hi all, >>> >>> I have documented a simple flash-like device which I think could be >>> useful for qemu/kvm in some cases. (Particularly for allow

[Qemu-devel] [PATCH 04/32] vmstate: port m48t59

Signed-off-by: Juan Quintela --- hw/m48t59.c | 36 +--- 1 files changed, 13 insertions(+), 23 deletions(-) diff --git a/hw/m48t59.c b/hw/m48t59.c index 2020487..82223c9 100644 --- a/hw/m48t59.c +++ b/hw/m48t59.c @@ -585,28 +585,18 @@ static CPUReadMemoryFunc * c

[Qemu-devel] [PATCH 03/32] vmstate: port ads7846

Signed-off-by: Juan Quintela --- hw/ads7846.c | 41 ++--- 1 files changed, 18 insertions(+), 23 deletions(-) diff --git a/hw/ads7846.c b/hw/ads7846.c index b3bbeaf..9c58a5f 100644 --- a/hw/ads7846.c +++ b/hw/ads7846.c @@ -105,35 +105,30 @@ static void ads784

[Qemu-devel] Re: RFC: emulation of system flash

On Thu, Mar 10, 2011 at 12:27:55PM +0100, Jan Kiszka wrote: > On 2011-03-10 10:47, Gleb Natapov wrote: > > On Wed, Mar 09, 2011 at 08:51:23PM -0800, Jordan Justen wrote: > >> Hi all, > >> > >> I have documented a simple flash-like device which I think could be > >> useful for qemu/kvm in some cases

[Qemu-devel] [PATCH 00/32] VMState port of misc devices

Hi This are the devices that conversion was trivial. Series is on top of my previous series: [PATCH 0/9] VMState infrastructure All coments from Blue Swirl have been addressed (thanks for them). Change for PCI Device from Isazu was not implemented because I can test that it work. I like th

[Qemu-devel] [PATCH 09/32] vmstate: port pmtimer

It was a half conversion. Finish it. enabled can only get values of 0, 1 or 2, was declared as an int but sent as an unint8_t, change its type. Signed-off-by: Juan Quintela --- hw/hw.h | 17 ++- hw/ptimer.c | 59 +++-- qe

[Qemu-devel] [PATCH 06/32] vmstate: port arm sp804

Signed-off-by: Juan Quintela --- hw/arm_timer.c | 29 +++-- 1 files changed, 11 insertions(+), 18 deletions(-) diff --git a/hw/arm_timer.c b/hw/arm_timer.c index 82f05de..cfd1ebe 100644 --- a/hw/arm_timer.c +++ b/hw/arm_timer.c @@ -235,24 +235,17 @@ static CPUWriteMemor

[Qemu-devel] [PATCH 01/32] vmstate: port adb_kbd

Signed-off-by: Juan Quintela --- hw/adb.c | 40 ++-- 1 files changed, 14 insertions(+), 26 deletions(-) diff --git a/hw/adb.c b/hw/adb.c index 99b30f6..fbf5080 100644 --- a/hw/adb.c +++ b/hw/adb.c @@ -261,30 +261,19 @@ static int adb_kbd_request(ADBDevice *d

[Qemu-devel] [PATCH 02/32] vmstate: port adb_mouse

Signed-off-by: Juan Quintela --- hw/adb.c | 43 +++ 1 files changed, 15 insertions(+), 28 deletions(-) diff --git a/hw/adb.c b/hw/adb.c index fbf5080..7499cdc 100644 --- a/hw/adb.c +++ b/hw/adb.c @@ -427,32 +427,20 @@ static int adb_mouse_reset(ADBDevice

[Qemu-devel] [PATCH 10/32] vmstate: port syborg_rtc

Signed-off-by: Juan Quintela --- hw/syborg_rtc.c | 34 -- 1 files changed, 12 insertions(+), 22 deletions(-) diff --git a/hw/syborg_rtc.c b/hw/syborg_rtc.c index 329aa42..4e24e52 100644 --- a/hw/syborg_rtc.c +++ b/hw/syborg_rtc.c @@ -102,26 +102,17 @@ static CPU

[Qemu-devel] [PATCH 17/32] vmstate: port pl022 ssp

Signed-off-by: Juan Quintela --- hw/pl022.c | 84 +-- 1 files changed, 36 insertions(+), 48 deletions(-) diff --git a/hw/pl022.c b/hw/pl022.c index ffe05ab..00e494a 100644 --- a/hw/pl022.c +++ b/hw/pl022.c @@ -239,54 +239,42 @@ static CPU

[Qemu-devel] [PATCH 05/32] vmstate: port mipsnet

Signed-off-by: Juan Quintela --- hw/mipsnet.c | 53 +++-- 1 files changed, 19 insertions(+), 34 deletions(-) diff --git a/hw/mipsnet.c b/hw/mipsnet.c index c5e54ff..26aad51 100644 --- a/hw/mipsnet.c +++ b/hw/mipsnet.c @@ -202,44 +202,29 @@ static

[Qemu-devel] [PATCH 07/32] vmstate: port arm_timer

Signed-off-by: Juan Quintela --- hw/arm_timer.c | 37 ++--- 1 files changed, 14 insertions(+), 23 deletions(-) diff --git a/hw/arm_timer.c b/hw/arm_timer.c index cfd1ebe..dac9e70 100644 --- a/hw/arm_timer.c +++ b/hw/arm_timer.c @@ -140,28 +140,19 @@ static void

[Qemu-devel] [PATCH 12/32] vmstate: port pl011

Signed-off-by: Juan Quintela --- hw/pl011.c | 76 +++ 1 files changed, 25 insertions(+), 51 deletions(-) diff --git a/hw/pl011.c b/hw/pl011.c index 77f0dbf..3b94b14 100644 --- a/hw/pl011.c +++ b/hw/pl011.c @@ -235,56 +235,30 @@ static CPU

[Qemu-devel] [PATCH 27/32] vmstate: port syborg_pointer

Signed-off-by: Juan Quintela --- hw/syborg_pointer.c | 73 +++--- 1 files changed, 28 insertions(+), 45 deletions(-) diff --git a/hw/syborg_pointer.c b/hw/syborg_pointer.c index a886888..2f99707 100644 --- a/hw/syborg_pointer.c +++ b/hw/syborg_pointe

[Qemu-devel] [PATCH 08/32] vmstate: port sysborg_timer

Signed-off-by: Juan Quintela --- hw/syborg_timer.c | 46 -- 1 files changed, 16 insertions(+), 30 deletions(-) diff --git a/hw/syborg_timer.c b/hw/syborg_timer.c index cedcd8e..50c813e 100644 --- a/hw/syborg_timer.c +++ b/hw/syborg_timer.c @@ -174,34

[Qemu-devel] [PATCH 13/32] vmstate: port armv7m nvic

Signed-off-by: Juan Quintela --- hw/armv7m_nvic.c | 39 ++- 1 files changed, 14 insertions(+), 25 deletions(-) diff --git a/hw/armv7m_nvic.c b/hw/armv7m_nvic.c index 6c7ce01..397f5c9 100644 --- a/hw/armv7m_nvic.c +++ b/hw/armv7m_nvic.c @@ -365,30 +365,19 @@

[Qemu-devel] [PATCH 26/32] vmstate: port ppc4xx_pci

Signed-off-by: Juan Quintela --- hw/ppc4xx_pci.c | 80 ++ 1 files changed, 39 insertions(+), 41 deletions(-) diff --git a/hw/ppc4xx_pci.c b/hw/ppc4xx_pci.c index f62f1f9..299473c 100644 --- a/hw/ppc4xx_pci.c +++ b/hw/ppc4xx_pci.c @@ -285,50 +

[Qemu-devel] [PATCH 14/32] vmstate: port stellaris i2c

Signed-off-by: Juan Quintela --- hw/stellaris.c | 49 + 1 files changed, 17 insertions(+), 32 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 5d8bd55..715e48c 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -844,36 +844,22 @@

[Qemu-devel] [PATCH 19/32] vmstate: port cuda

Signed-off-by: Juan Quintela --- hw/cuda.c | 116 - 1 files changed, 46 insertions(+), 70 deletions(-) diff --git a/hw/cuda.c b/hw/cuda.c index e4c178d..f47dfab 100644 --- a/hw/cuda.c +++ b/hw/cuda.c @@ -644,80 +644,56 @@ static CPURea

[Qemu-devel] Re: RFC: emulation of system flash

On 03/10/2011 12:46 PM, Jan Kiszka wrote: Better define flash chips as qdev devices and make the attributes qdev properties: -device flash,image=...,base=...,overlay=...,overlay_start=... Images should be addressed by block device IDs and created via '-drive' (likely requires a new interfa

[Qemu-devel] [PATCH 20/32] vmstate: port stellaris gptm

Signed-off-by: Juan Quintela --- hw/stellaris.c | 84 1 files changed, 24 insertions(+), 60 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index b67f687..151b707 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -280,64 +280

[Qemu-devel] [PATCH 18/32] vmstate: port heathrow_pic

Signed-off-by: Juan Quintela --- hw/heathrow_pic.c | 62 +--- 1 files changed, 25 insertions(+), 37 deletions(-) diff --git a/hw/heathrow_pic.c b/hw/heathrow_pic.c index b19b754..5fd71a0 100644 --- a/hw/heathrow_pic.c +++ b/hw/heathrow_pic.c @@ -

[Qemu-devel] [PATCH 16/32] vmstate: port stellaris sys

Signed-off-by: Juan Quintela --- hw/stellaris.c | 71 +++ 1 files changed, 25 insertions(+), 46 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 9b83fb4..b67f687 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -605,58 +605,

[Qemu-devel] [PATCH 03/13] vmstate: port pxa2xx_lcd

Signed-off-by: Juan Quintela --- hw/pxa2xx_lcd.c | 110 +- 1 files changed, 43 insertions(+), 67 deletions(-) diff --git a/hw/pxa2xx_lcd.c b/hw/pxa2xx_lcd.c index 55e95be..e524802 100644 --- a/hw/pxa2xx_lcd.c +++ b/hw/pxa2xx_lcd.c @@ -833,74 +

[Qemu-devel] [PATCH 23/32] vmstate: port pxa2xx_mm

Signed-off-by: Juan Quintela --- hw/pxa2xx.c | 33 - 1 files changed, 12 insertions(+), 21 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index a3ba30a..0a9af4c 100644 --- a/hw/pxa2xx.c +++ b/hw/pxa2xx.c @@ -516,25 +516,16 @@ static CPUWriteMemoryFunc * con

[Qemu-devel] [PATCH 21/32] vmstate: port pxa2xx_i2s

Signed-off-by: Juan Quintela --- hw/pxa2xx.c | 53 ++--- 1 files changed, 18 insertions(+), 35 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index 4c7b9e6..9bafe05 100644 --- a/hw/pxa2xx.c +++ b/hw/pxa2xx.c @@ -1748,39 +1748,23 @@ static CP

[Qemu-devel] [PATCH 22/32] vmstate: port pxa2xx_cm

Signed-off-by: Juan Quintela --- hw/pxa2xx.c | 39 ++- 1 files changed, 14 insertions(+), 25 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index 9bafe05..a3ba30a 100644 --- a/hw/pxa2xx.c +++ b/hw/pxa2xx.c @@ -227,29 +227,18 @@ static CPUWriteMemoryFunc

[Qemu-devel] [PATCH 24/32] vmstate: port pxa2xx_pm

Signed-off-by: Juan Quintela --- hw/pxa2xx.c | 33 - 1 files changed, 12 insertions(+), 21 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index 0a9af4c..aada093 100644 --- a/hw/pxa2xx.c +++ b/hw/pxa2xx.c @@ -146,25 +146,16 @@ static CPUWriteMemoryFunc * con

[Qemu-devel] [PATCH 25/32] vmstate: port ppce500_pci

Signed-off-by: Juan Quintela --- hw/ppce500_pci.c | 87 +- 1 files changed, 40 insertions(+), 47 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index 11edd03..132d8f7 100644 --- a/hw/ppce500_pci.c +++ b/hw/ppce500_pci.c @@ -216

[Qemu-devel] [PATCH v2 0/3] really fix -icount with iothread

This is a "real" fix for -icount, real in the sense that it works in all cases including those that weren't fixed by my first attempt. Patch 1 is the three-line fix. With that in, patch 2 can revert the previous attempt(s). Finally, patch 3 makes the icount code clearer by finishing the bugfix/r

[Qemu-devel] [PATCH 28/32] vmstate: port stellaris_adc

Signed-off-by: Juan Quintela --- hw/stellaris.c | 89 +-- 1 files changed, 34 insertions(+), 55 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 151b707..6e31d89 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -1058,60 +105

[Qemu-devel] [PATCH 29/32] vmstate: port syborg_serial

Signed-off-by: Juan Quintela --- hw/syborg_serial.c | 60 +++ 1 files changed, 18 insertions(+), 42 deletions(-) diff --git a/hw/syborg_serial.c b/hw/syborg_serial.c index 34ce076..df2950f 100644 --- a/hw/syborg_serial.c +++ b/hw/syborg_serial.c

[Qemu-devel] Re: [V8 PATCH 11/11] virtio-9p: Chroot environment for other functions

On Wed, Mar 9, 2011 at 5:16 PM, M. Mohan Kumar wrote: > Add chroot functionality for systemcalls that can operate on a file > using relative directory file descriptor. I suspect the relative directory approach is broken and escapes the chroot. Here's why: The request is local_chmod(fs_ctx, "/..

[Qemu-devel] [PATCH 31/32] vmstate: port stellaris gamepad

Signed-off-by: Juan Quintela --- hw/stellaris_input.c | 50 -- 1 files changed, 24 insertions(+), 26 deletions(-) diff --git a/hw/stellaris_input.c b/hw/stellaris_input.c index 16aae96..06c5f9d 100644 --- a/hw/stellaris_input.c +++ b/hw/stellaris

[Qemu-devel] [PATCH 08/13] mac_nvram: size is a size, no need to be a target dependent type

Signed-off-by: Juan Quintela --- hw/mac_nvram.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/mac_nvram.c b/hw/mac_nvram.c index c2a2fc2..64f0192 100644 --- a/hw/mac_nvram.c +++ b/hw/mac_nvram.c @@ -38,7 +38,7 @@ #endif struct MacIONVRAMState { -target_phys_a

[Qemu-devel] [PATCH 00/13] VMState port more devices

Hi, This is the second half of devices that needed some change for vmstate conversion. Change was minimal. Fixed issues from previous sent. Again thanks to Blaw Swirl for the comments and review. This series apply on top of: [PATCH 0/9] VMState infrastructure [PATCH 00/32] VMState port of m

Re: [Qemu-devel] [PATCH 19/22] qapi: add QMP put-event command

On 03/09/2011 04:26 PM, Anthony Liguori wrote: On 03/09/2011 07:58 AM, Avi Kivity wrote: On 03/09/2011 03:48 PM, Anthony Liguori wrote: +[ 'put-event', {'tag': 'int'}, {}, 'none' ] Why is tag an int? +## It's a handle so the type doesn't matter as long as I can make sure values are unique.

[Qemu-devel] [PATCH 01/13] pxa2xx_lcd: name anonymous struct

Signed-off-by: Juan Quintela --- hw/pxa2xx_lcd.c | 28 +++- 1 files changed, 15 insertions(+), 13 deletions(-) diff --git a/hw/pxa2xx_lcd.c b/hw/pxa2xx_lcd.c index 5b2b07e..9a19347 100644 --- a/hw/pxa2xx_lcd.c +++ b/hw/pxa2xx_lcd.c @@ -15,6 +15,20 @@ #include "sysemu.h

[Qemu-devel] [PATCH 12/13] mac_dbdma: create DBDMAState instead of passing one array around

Signed-off-by: Juan Quintela --- hw/mac_dbdma.c | 45 +++-- 1 files changed, 27 insertions(+), 18 deletions(-) diff --git a/hw/mac_dbdma.c b/hw/mac_dbdma.c index 5680fa9..c108aee 100644 --- a/hw/mac_dbdma.c +++ b/hw/mac_dbdma.c @@ -165,6 +165,10 @@ typed

[Qemu-devel] [PATCH 02/13] pxa2xx_lcd: up field is used as a bool and migrated as an uint8_t

Signed-off-by: Juan Quintela --- hw/pxa2xx_lcd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pxa2xx_lcd.c b/hw/pxa2xx_lcd.c index 9a19347..55e95be 100644 --- a/hw/pxa2xx_lcd.c +++ b/hw/pxa2xx_lcd.c @@ -17,7 +17,7 @@ struct DMAChannel { target_phys_addr_t br

[Qemu-devel] [PATCH 04/13] max111x: input field is only used as uint8_t

Signed-off-by: Juan Quintela --- hw/max111x.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/max111x.c b/hw/max111x.c index 2844665..3adc3e4 100644 --- a/hw/max111x.c +++ b/hw/max111x.c @@ -15,7 +15,7 @@ typedef struct { uint8_t tb1, rb2, rb3; int cycle; -

[Qemu-devel] [PATCH 07/13] vmstate: port nand

Signed-off-by: Juan Quintela --- hw/nand.c | 73 1 files changed, 39 insertions(+), 34 deletions(-) diff --git a/hw/nand.c b/hw/nand.c index 9f978d8..37e51d7 100644 --- a/hw/nand.c +++ b/hw/nand.c @@ -66,6 +66,8 @@ struct NANDFlashSt

[Qemu-devel] [PATCH v2 3/3] qemu_next_deadline should not consider host-time timers

It is purely for icount-based virtual timers. And now that we got the code right, rename the function to clarify the intended scope. Signed-off-by: Paolo Bonzini --- cpus.c |4 ++-- qemu-timer.c | 11 +++ qemu-timer.h |2 +- 3 files changed, 6 insertions(+), 11 deletions

[Qemu-devel] [PATCH 09/13] vmstate: port mac_nvram

Signed-off-by: Juan Quintela --- hw/mac_nvram.c | 30 +++--- 1 files changed, 11 insertions(+), 19 deletions(-) diff --git a/hw/mac_nvram.c b/hw/mac_nvram.c index 64f0192..61e53d2 100644 --- a/hw/mac_nvram.c +++ b/hw/mac_nvram.c @@ -105,24 +105,17 @@ static CPUReadMemor

[Qemu-devel] [PATCH 10/13] piix4: create PIIX4State

It only contains a PCIDevice by know, but it makes easy to use migration code Signed-off-by: Juan Quintela --- hw/piix4.c | 29 + 1 files changed, 17 insertions(+), 12 deletions(-) diff --git a/hw/piix4.c b/hw/piix4.c index 72073cd..40cd91a 100644 --- a/hw/piix4.c

[Qemu-devel] [PATCH 15/32] vmstate: port stellaris ssi bus

Signed-off-by: Juan Quintela --- hw/stellaris.c | 31 +++ 1 files changed, 11 insertions(+), 20 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 715e48c..9b83fb4 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -1219,24 +1219,16 @@ static uint32_t

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

On 03/10/2011 02:41 PM, Avi Kivity wrote: I don't think I want to make this sort of change just yet. Also note that the schema that will be exposed over the wire is not directly related to the schema we use for code generation. Right, we have to nail down the format for the former, though.

[Qemu-devel] [PATCH 1/2] sockets: add qemu_socketpair()

Signed-off-by: Corentin Chary --- osdep.c | 83 + qemu_socket.h |1 + 2 files changed, 84 insertions(+), 0 deletions(-) diff --git a/osdep.c b/osdep.c index 327583b..93bfbe0 100644 --- a/osdep.c +++ b/osdep.c @@ -147,6 +147,89 @

[Qemu-devel] [PATCH v2 2/3] Revert wrong fixes for -icount in the iothread case

This reverts commits 225d02cd and c9f7383c. While some parts of the latter could be saved, I preferred a smooth, complete revert. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 66 +++-- 1 files changed, 36 insertions(+), 30 deletions(-) d

[Qemu-devel] [PATCH 13/13] vmstate: port mac_dbdma

Signed-off-by: Juan Quintela --- hw/mac_dbdma.c | 46 ++ 1 files changed, 22 insertions(+), 24 deletions(-) diff --git a/hw/mac_dbdma.c b/hw/mac_dbdma.c index c108aee..ed4458e 100644 --- a/hw/mac_dbdma.c +++ b/hw/mac_dbdma.c @@ -810,30 +810,28 @@ sta

[Qemu-devel] [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread

The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. Using qemu_mutex_lock_iothread() won't work because vnc_dpy_cpy(), which will wait for the current job queue to finish, can be called with the iothread lock held. I

Re: [Qemu-devel] virtio block device and sysfs

On Tue, Sep 14, 2010 at 09:43:22AM +0200, Marc Haber wrote: > On Mon, Sep 13, 2010 at 09:34:24AM -0500, Ryan Harper wrote: > > It'll only be available to guests launched with newer qemu (0.13) as > > virtio-blk serial support is a new feature. > > Thanks for the information, I'll wait for the next

[Qemu-devel] [PATCH 11/13] vmstate: port piix4

Signed-off-by: Juan Quintela --- hw/piix4.c | 25 +++-- 1 files changed, 11 insertions(+), 14 deletions(-) diff --git a/hw/piix4.c b/hw/piix4.c index 40cd91a..71f1f84 100644 --- a/hw/piix4.c +++ b/hw/piix4.c @@ -72,19 +72,16 @@ static void piix4_reset(void *opaque) pci

[Qemu-devel] Re: RFC: emulation of system flash

On 2011-03-10 12:48, Gleb Natapov wrote: > On Thu, Mar 10, 2011 at 12:27:55PM +0100, Jan Kiszka wrote: >> On 2011-03-10 10:47, Gleb Natapov wrote: >>> On Wed, Mar 09, 2011 at 08:51:23PM -0800, Jordan Justen wrote: Hi all, I have documented a simple flash-like device which I think cou

[Qemu-devel] [PATCH v2 1/3] really fix -icount in the iothread case

The correct fix for -icount is to consider the biggest difference between iothread and non-iothread modes. In the traditional model, CPUs run _before_ the iothread calls select (or WaitForMultipleObjects for Win32). In the iothread model, CPUs run while the iothread isn't holding the mutex, i.e.

[Qemu-devel] Re: [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread

On 03/10/2011 01:59 PM, Corentin Chary wrote: Instead, we now store the data in a temporary buffer, and use a socket pair to notify the main thread that new data is available. You can use a bottom half for this instead of a special socket. Signaling a bottom half is async-signal- and thread-sa

[Qemu-devel] Re: RFC: emulation of system flash

On Thu, Mar 10, 2011 at 01:06:14PM +0100, Jan Kiszka wrote: > On 2011-03-10 12:48, Gleb Natapov wrote: > > On Thu, Mar 10, 2011 at 12:27:55PM +0100, Jan Kiszka wrote: > >> On 2011-03-10 10:47, Gleb Natapov wrote: > >>> On Wed, Mar 09, 2011 at 08:51:23PM -0800, Jordan Justen wrote: > Hi all, >

[Qemu-devel] [PATCH 32/32] vmstate: stellaris use unused for placeholder entries

Signed-off-by: Juan Quintela --- hw/stellaris.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 6e31d89..74815ad 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -291,8 +291,7 @@ static const VMStateDescription vmstate_stellaris_

[Qemu-devel] [PATCH 05/13] vmstate: port max111x

Signed-off-by: Juan Quintela --- hw/max111x.c | 49 + 1 files changed, 17 insertions(+), 32 deletions(-) diff --git a/hw/max111x.c b/hw/max111x.c index 3adc3e4..70cd1af 100644 --- a/hw/max111x.c +++ b/hw/max111x.c @@ -94,36 +94,22 @@ static uint3

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

On 03/09/2011 04:47 PM, Anthony Liguori wrote: [ { 'type': 'MyType', fields: [['a', 'str'], ['b', 'int'], ['c', 'AnotherType']] } { 'event': 'MY_EVENT', 'arguments': [ ... ] } { 'command': 'my-command', 'arguments': [ ... ], 'return': ... } ] which leaves us room for additional metainformati

[Qemu-devel] Re: [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread

On 03/10/2011 07:06 AM, Paolo Bonzini wrote: On 03/10/2011 01:59 PM, Corentin Chary wrote: Instead, we now store the data in a temporary buffer, and use a socket pair to notify the main thread that new data is available. You can use a bottom half for this instead of a special socket. Signalin

[Qemu-devel] Re: [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread

On 10.03.2011 13:59, Corentin Chary wrote: The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. Using qemu_mutex_lock_iothread() won't work because vnc_dpy_cpy(), which will wait for the current job queue to finish,

[Qemu-devel] Re: RFC: emulation of system flash

On 2011-03-10 13:17, Gleb Natapov wrote: > On Thu, Mar 10, 2011 at 01:06:14PM +0100, Jan Kiszka wrote: >> On 2011-03-10 12:48, Gleb Natapov wrote: >>> On Thu, Mar 10, 2011 at 12:27:55PM +0100, Jan Kiszka wrote: On 2011-03-10 10:47, Gleb Natapov wrote: > On Wed, Mar 09, 2011 at 08:51:23PM -

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

On 03/10/2011 06:41 AM, Avi Kivity wrote: My preference would be: { 'type': 'MyType', 'fields': { 'a': 'str', 'b': 'int', 'c': 'AnotherType' } } { 'event': 'MY_EVENT', 'arguments': {...} } { 'command': 'my-command', 'arguments': {...}, 'returns': 'int' } I do prefer the dictionary syntax for

[Qemu-devel] Re: [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread

On 03/10/2011 02:45 PM, Anthony Liguori wrote: On 03/10/2011 07:06 AM, Paolo Bonzini wrote: On 03/10/2011 01:59 PM, Corentin Chary wrote: Instead, we now store the data in a temporary buffer, and use a socket pair to notify the main thread that new data is available. You can use a bottom half

[Qemu-devel] Re: [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread

On Thu, Mar 10, 2011 at 1:45 PM, Anthony Liguori wrote: > On 03/10/2011 07:06 AM, Paolo Bonzini wrote: >> >> On 03/10/2011 01:59 PM, Corentin Chary wrote: >>> >>> Instead, we now store the data in a temporary buffer, and use a socket >>> pair to notify the main thread that new data is available. >

[Qemu-devel] [PATCH 11/32] vmstate: port pxa2xx_keypad

Signed-off-by: Juan Quintela --- hw/pxa2xx_keypad.c | 53 --- 1 files changed, 17 insertions(+), 36 deletions(-) diff --git a/hw/pxa2xx_keypad.c b/hw/pxa2xx_keypad.c index d77dbf1..10ef154 100644 --- a/hw/pxa2xx_keypad.c +++ b/hw/pxa2xx_keypad.c

[Qemu-devel] [PATCH 1/3] build: Create tools-obj-y variable

All our tools have to have exactly all this objects, just share them. Signed-off-by: Juan Quintela --- Makefile | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index eca4c76..9e090cb 100644 --- a/Makefile +++ b/Makefile @@ -150,14 +150,18 @@

Re: [Qemu-devel] [PATCH 0/9] VMState infrastructure

On 03/10/2011 05:33 AM, Juan Quintela wrote: Hi This is the infrastructure that I pushed on my previous series. Anthony don't like 58 patches series (why? O:-) And then split the series in three. Yeah, my intention was that you not send all series at once though :-) At any rate this series lo

[Qemu-devel] [PATCH v2 0/3] build: make sharing of objects explicit

Hi Another week, another version. v2: - rename common-obj-y to softmmu-obj-y, so we can use common-obj-y for objects shared between tools and softmmu. v1: - all tools shared the same list of object files, create a variable instead or repeating them (tools-obj-y). - tools and softmmu target

[Qemu-devel] Re: [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread

On 03/10/2011 02:54 PM, Corentin Chary wrote: > > You can use a bottom half for this instead of a special socket. Signaling > > a bottom half is async-signal- and thread-safe. > > Bottom halves are thread safe? > > I don't think so. The bottom halves API is not thread safe, but calling qemu_

[Qemu-devel] [PATCH 3/3] build: Create common-obj-y for objects shared between tools and softmmu

This way we don't have to repeat them in two places. Signed-off-by: Juan Quintela --- Makefile |4 +--- Makefile.objs | 14 +- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index 7811d74..42d2cab 100644 --- a/Makefile +++ b/Makefile @@

[Qemu-devel] [PATCH 2/3] build: Rename common-obj-y to softmmu-obj-y

It really represent object files shared between all softmmu targets. We will use common-obj-y for objects shared between softmmu and tools on next commit Signed-off-by: Juan Quintela --- Makefile|4 +- Makefile.objs | 116 +++--- Mak

Re: [Qemu-devel] [PATCH 19/22] qapi: add QMP put-event command

On 03/10/2011 06:39 AM, Avi Kivity wrote: What I mean is that the client should specify the handle, like it does for everything else it gives a name (netdevs, blockdevs, SCM_RIGHT fds, etc). { execute: listen-event, arguments: { event: blah, id: blah1 } } { execute: unlisten-event argu

[Qemu-devel] [PATCH] get rid of private bitmap functions in block/sheepdog.c, use generic ones

qemu now has generic bitmap functions, so don't redefine them in sheepdog.c, use common header instead. A small cleanup. Here's only one function which is actually used in sheepdog and gets replaced with a generic one (simplified): - static inline int test_bit(int nr, const volatile unsigned lon

  1   2   >