[Qemu-devel] Re: [PATCH 03/15] kvm: Install optimized interrupt handlers

2011-03-07 Thread Jan Kiszka
On 2011-03-06 03:13, Marcelo Tosatti wrote: > On Sat, Mar 05, 2011 at 07:11:53PM +0100, Jan Kiszka wrote: >> On 2011-03-05 16:37, Marcelo Tosatti wrote: >>> On Fri, Mar 04, 2011 at 11:20:00AM +0100, Jan Kiszka wrote: KVM only requires to set the raised IRQ in CPUState and, if the user spa

Re: [Qemu-devel] [PATCH 0/4] ARM additions and fixes

2011-03-07 Thread Aurelien Jarno
On Sat, Mar 05, 2011 at 01:51:41PM +0100, Adam Lackorzynski wrote: > The following patches fix and enhance ARM related functionality. > > Adam Lackorzynski (3): > target-arm: Fix soft interrupt in GIC distributor > target-arm: Implement cp15 VA->PA translation > target-arm: Integrate seconda

Re: [Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE

2011-03-07 Thread Kevin Wolf
Am 06.03.2011 20:26, schrieb Aurelien Jarno: > You should Cc: the IDE maintainer (Kevin Wolf) so that this patch can > get acked. Done with this mail. Thanks. In fact, I saw the patch, but it still needs a review. Can whoever commented on the previous versions give it the review and post an Acked

Re: [Qemu-devel] [PATCH 28/37] Move debug exception handling out of cpu_exec

2011-03-07 Thread Jan Kiszka
On 2011-03-07 02:52, TeLeMan wrote: > This patch breaks the support for x86 hardware breakpoints because > cpu_resume_from_signal() and raise_exception_env() are used in > breakpoint_handler(). Yeah, unfortunately true. The TCG bits of this refactoring have to be moved back. Will fix. Thanks, Jan

Re: [Qemu-devel] [PATCH 0/3] tcg: Support debugging leakage of temporaries

2011-03-07 Thread Aurelien Jarno
On Sun, Mar 06, 2011 at 09:52:56PM +, Peter Maydell wrote: > On 6 March 2011 18:18, Aurelien Jarno wrote: > > On Wed, Feb 23, 2011 at 03:19:33PM +, Peter Maydell wrote: > >> This patchset removes the ad-hoc debug code in target-arm for > >> identifying cases where we leaked TCG temporary v

Re: [Qemu-devel] [PATCH v2 0/3] tcg: Support debugging leakage of temporaries

2011-03-07 Thread Aurelien Jarno
On Sun, Mar 06, 2011 at 09:39:52PM +, Peter Maydell wrote: > This patchset removes the ad-hoc debug code in target-arm for > identifying cases where we leaked TCG temporary variables, in > favour of an implementation in tcg itself. > > Generally any temporaries created by a target while it is

Re: [Qemu-devel] [PATCH] target-arm: Implement a minimal set of cp14 debug registers

2011-03-07 Thread Aurelien Jarno
On Tue, Feb 22, 2011 at 06:19:43PM +, Peter Maydell wrote: > Newer ARM kernels try to probe for whether the CPU has hardware breakpoint > support. For this to work QEMU has to implement a minimal set of the cp14 > debug registers. The architecture requires v7 cores to implement debug > and so t

Re: [Qemu-devel] [PATCH 28/37] Move debug exception handling out of cpu_exec

2011-03-07 Thread Jan Kiszka
On 2011-03-07 09:26, Jan Kiszka wrote: > On 2011-03-07 02:52, TeLeMan wrote: >> This patch breaks the support for x86 hardware breakpoints because >> cpu_resume_from_signal() and raise_exception_env() are used in >> breakpoint_handler(). > > Yeah, unfortunately true. The TCG bits of this refactori

[Qemu-devel] [Bug 730441] Re: NIC doesn't work with "pci=nomsi" in grub.conf

2011-03-07 Thread Yongjie Ren
kvm commit: b35049715d619c9badaea07dec766787b433facf qemu-kvm commit: 27f368604a3d27ca4ddac0f62a6928bb93cdacd5 And the dmesg info of the guest is attached. You may search "Failed to initialize MSI interrupts" in this dmesg. ** Attachment added: "dmesg_nomsi" https://bugs.launchpad.net/qemu/

Re: [Qemu-devel] [PATCH 0/3] tcg: Support debugging leakage of temporaries

2011-03-07 Thread Peter Maydell
On 7 March 2011 08:42, Aurelien Jarno wrote: > On Sun, Mar 06, 2011 at 09:52:56PM +, Peter Maydell wrote: >> In the long term it would be good if we could make the ARM translate.c >> less brittle like this. Can we at least define a rule for where we're >> trying to get to so we can move in the

[Qemu-devel] [PATCH 0/2 V7] add inject-nmi qmp command

2011-03-07 Thread Lai Jiangshan
From: Lai Jiangshan Date: Mon, 7 Mar 2011 17:08:46 +0800 Subject: [PATCH 0/2 V7] qemu,qmp: add inject-nmi qmp command The new qmp command "inject-nmi" is different from the hmp monitor command "nmi". The first one injects an NMI on all CPUs, and the second one injects an NMI to the specified CPU.

[Qemu-devel] [PATCH 1/2] qemu,qmp: QError: New QERR_UNSUPPORTED

2011-03-07 Thread Lai Jiangshan
From: Lai Jiangshan Date: Mon, 7 Mar 2011 17:05:04 +0800 Subject: [PATCH 1/2] qemu,qmp: QError: New QERR_UNSUPPORTED New QERR_UNSUPPORTED for unsupported commands or requests. --- qerror.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qerror.h b/qerror.h index f732d

[Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-03-07 Thread Lai Jiangshan
From: Lai Jiangshan Date: Mon, 7 Mar 2011 17:05:15 +0800 Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command inject-nmi command injects an NMI on all CPUs of guest. It is only supported for x86 guest currently, it will returns "Unsupported" error for non-x86 guest. --- hmp-commands.hx |

[Qemu-devel] [Bug 670776] Re: Build errors on TEGRA2(ubuntu), testandset()

2011-03-07 Thread Peter Maydell
This build error was fixed by this commit: http://git.qemu.org/qemu.git/commit/?id=02615337ef295443daa03233e492194e289a807e ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

[Qemu-devel] [Bug 657006] Re: arm v7M - svc insn doesn't trigger PendSV handler

2011-03-07 Thread Peter Maydell
** Summary changed: - arm - svc instruction + arm v7M - svc insn doesn't trigger PendSV handler -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/657006 Title: arm v7M - svc insn doesn't trigger PendS

Re: [Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 8:28 AM, Kevin Wolf wrote: > Am 06.03.2011 20:26, schrieb Aurelien Jarno: >> You should Cc: the IDE maintainer (Kevin Wolf) so that this patch can >> get acked. Done with this mail. > > Thanks. In fact, I saw the patch, but it still needs a review. Can > whoever commented on

Re: [Qemu-devel] OVMF Google Summer of Code ideas

2011-03-07 Thread Stefan Hajnoczi
On Sun, Mar 6, 2011 at 9:15 PM, Jordan Justen wrote: > On Sun, Mar 6, 2011 at 07:29, Michal Suchanek wrote: >> On 6 March 2011 05:12, Jordan Justen wrote: >>> I know you already have your own ideas to think of. :) >>> http://wiki.qemu.org/Google_Summer_of_Code_2011 >>> >>> But, I am wondering if

Re: [Qemu-devel] [PATCH v5 07/10] softfloat: Drop [u]int32 types in favor of [u]int_fast32_t

2011-03-07 Thread Aurelien Jarno
On Mon, Mar 07, 2011 at 01:34:10AM +0100, Andreas Färber wrote: > v5: > * Initial. > > Cc: Peter Maydell > Signed-off-by: Andreas Färber > --- > fpu/softfloat.c | 132 +++--- > fpu/softfloat.h | 34 +++ > 2 files changed, 82 inserti

Re: [Qemu-devel] [PATCH v5 10/10] softfloat: Use [u]int_fast64_t consistently

2011-03-07 Thread Aurelien Jarno
On Mon, Mar 07, 2011 at 01:34:13AM +0100, Andreas Färber wrote: > v5: > * Initial. > > Signed-off-by: Andreas Färber > --- > fpu/softfloat-native.c | 26 +- > fpu/softfloat-native.h | 28 ++-- > fpu/softfloat.c|4 ++-- > 3 files cha

Re: [Qemu-devel] [PATCH v5 01/10] [RESEND] softfloat: Prepend QEMU-style header with derivation notice

2011-03-07 Thread Aurelien Jarno
On Mon, Mar 07, 2011 at 01:34:04AM +0100, Andreas Färber wrote: > The SoftFloat license requires "prominent notice that the work > is derivative". Having added features like improved 16-bit support > for arm already, add such a notice to the sources. > > softfloat-native.[ch] are not under the Sof

Re: [Qemu-devel] [PATCH v5 02/10] softfloat: Resolve type mismatches between declaration and implementation

2011-03-07 Thread Aurelien Jarno
On Mon, Mar 07, 2011 at 01:34:05AM +0100, Andreas Färber wrote: > The original SoftFloat 2.0b library avoided the use of custom integer types > in its public headers. This requires the definitions of int{8,16,32,64} to > match the assumptions in the declarations. This breaks on BeOS R5 and > Haiku

Re: [Qemu-devel] [PATCH v5 04/10] softfloat: Drop [u]int16 types in favor of [u]int_fast16_t

2011-03-07 Thread Aurelien Jarno
On Mon, Mar 07, 2011 at 01:34:07AM +0100, Andreas Färber wrote: > AIX already didn't use our definition, so let's start ripping out this one: > As pointed out by Peter Maydell, int16 is currently int on most > supported platforms, so let's replace it with int_fast16_t, > allowing the system to use

[Qemu-devel] Re: [PATCH v2] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Kevin Wolf
Am 03.03.2011 14:13, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > In case we cannot open the newly created snapshot image, try to fall > back to the original image file and continue running on that, which > should prevent the guest from aborting. > > This is a corner case which can

[Qemu-devel] [PATCH 1/2] trace: Trace bdrv_aio_flush()

2011-03-07 Thread Stefan Hajnoczi
Add a trace event for bdrv_aio_flush() to complement the existing bdrv_aio_readv() and bdrv_aio_writev() events. Signed-off-by: Stefan Hajnoczi --- block.c |2 ++ trace-events |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index f7d91a2..0559d

Re: [Qemu-devel] OVMF Google Summer of Code ideas

2011-03-07 Thread Peter Maydell
On 6 March 2011 15:29, Michal Suchanek wrote: > I would like to see the ability to run x86 on arm. > > I think there were some attempts to implement this and an outdated? > support for arm on x86 exists but x86 cannot be emulated on arm so > far. ARM on x86 isn't outdated; it has bugs (what code

[Qemu-devel] [PATCH 2/2] trace: Trace posix-aio-compat.c completion and cancellation

2011-03-07 Thread Stefan Hajnoczi
This patch adds paio_complete() and paio_cancel() trace events to complement the paio_submit() event. Signed-off-by: Stefan Hajnoczi --- posix-aio-compat.c |5 + trace-events |2 ++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-co

Re: [Qemu-devel] [PATCH 28/37] Move debug exception handling out of cpu_exec

2011-03-07 Thread TeLeMan
On Mon, Mar 7, 2011 at 16:54, Jan Kiszka wrote: > On 2011-03-07 09:26, Jan Kiszka wrote: >> On 2011-03-07 02:52, TeLeMan wrote: >>> This patch breaks the support for x86 hardware breakpoints because >>> cpu_resume_from_signal() and raise_exception_env() are used in >>> breakpoint_handler(). >> >>

[Qemu-devel] Re: x86 on Arm status Was: OVMF Google Summer of Code ideas

2011-03-07 Thread Michal Suchanek
Hello On 7 March 2011 11:22, Peter Maydell wrote: > On 6 March 2011 15:29, Michal Suchanek wrote: >> I would like to see the ability to run x86 on arm. >> >> I think there were some attempts to implement this and an outdated? >> support for arm on x86 exists but x86 cannot be emulated on arm so

Re: [Qemu-devel] [PATCH 01/22] Add hard build dependency on glib

2011-03-07 Thread Daniel P. Berrange
On Sun, Mar 06, 2011 at 07:22:43PM -0600, Anthony Liguori wrote: > GLib is an extremely common library that has a portable thread implementation > along with tons of other goodies. > > GLib and GObject have a fantastic amount of infrastructure we can leverage in > QEMU including an object oriented

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Daniel P. Berrange
On Sun, Mar 06, 2011 at 07:22:45PM -0600, Anthony Liguori wrote: > The Error class is similar to QError (now deprecated) except that it supports > propagation. This allows for higher quality error handling. It's losely > modeled after glib style GErrors. I know this offers more functionality tha

[Qemu-devel] [PATCH v3 2/2] hw/vexpress.c: Add model of ARM Versatile Express board

2011-03-07 Thread Peter Maydell
Add a model of the ARM Versatile Express board (with A9MPx4 daughterboard). Signed-off-by: Peter Maydell --- Makefile.target |1 + hw/vexpress.c | 224 +++ 2 files changed, 225 insertions(+), 0 deletions(-) create mode 100644 hw/vexpres

Re: [Qemu-devel] [PATCH 02/22] qerror: expose a function to format an error

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > This will let Error share the QError human formatting.  This is only used for > HMP. > > Signed-off-by: Anthony Liguori > > diff --git a/qerror.c b/qerror.c > index 4855604..13d53c9 100644 > --- a/qerror.c > +++ b/qerror.c > @@ -326,12 +326

[Qemu-devel] [PATCH v3 0/2] ARM: Add Versatile Express board model

2011-03-07 Thread Peter Maydell
This patchset adds support for the ARM Versatile Express board with Cortex-A9 daughterboard. It's based on some vexpress modelling work done by Bahadir Balban and Amit Mahajan at B Labs, overhauled and cleaned up by me (thanks to them for making that work available). (The MMC changes this patch de

[Qemu-devel] [PATCH v3 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers

2011-03-07 Thread Peter Maydell
Add support for the Versatile Express SYS_CFG registers, which provide a generic means of reading or writing configuration information from various parts of the board. We only implement shutdown and reset. Also make the RESETCTL register RAZ/WI on Versatile Express rather than reset the board. Oth

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > +struct Error > +{ > +    QDict *obj; > +    const char *fmt; > +    char *msg; > +}; I wonder why fmt is const char * but msg is char *. Users should use error_get_pretty() instead of accessing msg directly and that function returns const

[Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers

2011-03-07 Thread Peter Maydell
On 5 March 2011 17:04, Paolo Bonzini wrote: > On 03/05/2011 05:50 PM, Peter Maydell wrote: >> >> (1) Is there supposed to be any kind of guard on trying to >> do a vmsave on a system with devices that don't implement >> save/load? IME it just produces a snapshot which doesn't >> work when you relo

[Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers

2011-03-07 Thread Jan Kiszka
On 2011-03-07 12:45, Peter Maydell wrote: > On 5 March 2011 17:04, Paolo Bonzini wrote: >> On 03/05/2011 05:50 PM, Peter Maydell wrote: >>> >>> (1) Is there supposed to be any kind of guard on trying to >>> do a vmsave on a system with devices that don't implement >>> save/load? IME it just produc

[Qemu-devel] Implementing Virtual DMA in QEMU

2011-03-07 Thread guna spam
Hi Iam using QEMU emulated ARM Realview board with Linux as guest OS for my application development. This virtual machine is running on x86 Linux host. My application is facing performance issue as memcpy in guest machine is taking lot of time compared to the same memcpy in host machine. To improv

Re: [Qemu-devel] [PATCH 10/22] qapi: add core QMP server support

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > +char *qobject_as_string(QObject *obj) > +{ > +    char buffer[1024]; > + > +    switch (qobject_type(obj)) { > +    case QTYPE_QINT: > +        snprintf(buffer, sizeof(buffer), "%" PRId64, > +                 qint_get_int(qobject_to_qint(ob

Re: [Qemu-devel] [PATCH 00/17 v3] LatticeMico32 target

2011-03-07 Thread Edgar E. Iglesias
On Sun, Mar 06, 2011 at 11:47:55PM +0100, Michael Walle wrote: > Am Dienstag 01 März 2011, 22:31:58 schrieb Edgar E. Iglesias: > > On Fri, Feb 25, 2011 at 12:03:37AM +0100, Michael Walle wrote: > > > Am Donnerstag 17 Februar 2011, 23:45:01 schrieb Michael Walle: > > > > This patchset adds support f

Re: [Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > diff --git a/qmp-core.h b/qmp-core.h > index e3235ec..5ce02f7 100644 > --- a/qmp-core.h > +++ b/qmp-core.h > @@ -21,10 +21,65 @@ typedef struct QmpState QmpState; >  typedef void (QmpCommandFunc)(const QDict *, QObject **, Error **); >  type

Re: [Qemu-devel] [PATCH 13/22] qapi: add code generators for QMP command marshaling

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > +def print_definition(name, required, optional, retval): This function is pretty long. Is there a logical way to split it up into several smaller meaningful functions? Stefan

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Anthony Liguori
On 03/07/2011 05:38 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: +struct Error +{ +QDict *obj; +const char *fmt; +char *msg; +}; I wonder why fmt is const char * but msg is char *. Users should use error_get_pretty() instead of access

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > diff --git a/qmp-schema.json b/qmp-schema.json > index e69de29..b343f5e 100644 > --- a/qmp-schema.json > +++ b/qmp-schema.json > @@ -0,0 +1,38 @@ > +# *-*- Mode: Python -*-* By the way JSON does not seem to support comments (neither /* */ n

Re: [Qemu-devel] [PATCH 02/22] qerror: expose a function to format an error

2011-03-07 Thread Anthony Liguori
On 03/07/2011 05:14 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: This will let Error share the QError human formatting. This is only used for HMP. Signed-off-by: Anthony Liguori diff --git a/qerror.c b/qerror.c index 4855604..13d53c9 100644 --- a/qerr

Re: [Qemu-devel] [PATCH 10/22] qapi: add core QMP server support

2011-03-07 Thread Anthony Liguori
On 03/07/2011 07:09 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: +char *qobject_as_string(QObject *obj) +{ +char buffer[1024]; + +switch (qobject_type(obj)) { +case QTYPE_QINT: +snprintf(buffer, sizeof(buffer), "%" PRId64, +

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

2011-03-07 Thread Anthony Liguori
On 03/07/2011 07:35 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: diff --git a/qmp-schema.json b/qmp-schema.json index e69de29..b343f5e 100644 --- a/qmp-schema.json +++ b/qmp-schema.json @@ -0,0 +1,38 @@ +# *-*- Mode: Python -*-* By the way JSON do

Re: [Qemu-devel] [PATCH 13/22] qapi: add code generators for QMP command marshaling

2011-03-07 Thread Anthony Liguori
On 03/07/2011 07:27 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: +def print_definition(name, required, optional, retval): This function is pretty long. Is there a logical way to split it up into several smaller meaningful functions? It seem

[Qemu-devel] I need Help!

2011-03-07 Thread Hadi Khalil pur
Hello! I'm Hadi khalilpur! I'm majoring in software engineering in MSc level. I'm working on "Automatic bug localization of virtual machines". My investigations are based on a prior researchs that proposed an automatic methodology for testing virtual machines. I like to focus on QEMU as one of m

Re: [Qemu-devel] [PATCH 10/22] qapi: add core QMP server support

2011-03-07 Thread Daniel P. Berrange
On Mon, Mar 07, 2011 at 07:39:41AM -0600, Anthony Liguori wrote: > On 03/07/2011 07:09 AM, Stefan Hajnoczi wrote: > >On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > >>+char *qobject_as_string(QObject *obj) > >>+{ > >>+char buffer[1024]; > >>+ > >>+switch (qobject_type(obj)) { > >>

Re: [Qemu-devel] [PATCH 15/22] qapi: add new QMP server that uses CharDriverState

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > +static void qmp_chr_send_greeting(QmpSession *s) > +{ > +    VersionInfo *info; > +    QObject *vers; > +    QObject *greeting; > +    QString *str; > + > +    info = qmp_query_version(NULL); > +    vers = qmp_marshal_type_VersionInfo(info)

Re: [Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

2011-03-07 Thread Anthony Liguori
On 03/07/2011 07:21 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: diff --git a/qmp-core.h b/qmp-core.h index e3235ec..5ce02f7 100644 --- a/qmp-core.h +++ b/qmp-core.h @@ -21,10 +21,65 @@ typedef struct QmpState QmpState; typedef void (QmpCommandFunc)(co

Re: [Qemu-devel] [PATCH 10/22] qapi: add core QMP server support

2011-03-07 Thread Anthony Liguori
On 03/07/2011 07:46 AM, Daniel P. Berrange wrote: On Mon, Mar 07, 2011 at 07:39:41AM -0600, Anthony Liguori wrote: On 03/07/2011 07:09 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: +char *qobject_as_string(QObject *obj) +{ +char buffe

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:36 PM, Anthony Liguori wrote: > On 03/07/2011 05:38 AM, Stefan Hajnoczi wrote: >> >> On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori >>  wrote: >> >>> >>> +struct Error >>> +{ >>> +    QDict *obj; >>> +    const char *fmt; >>> +    char *msg; >>> +}; >>> >> >> I wonder why

Re: [Qemu-devel] [PATCH 01/22] Add hard build dependency on glib

2011-03-07 Thread Anthony Liguori
On 03/07/2011 04:59 AM, Daniel P. Berrange wrote: On Sun, Mar 06, 2011 at 07:22:43PM -0600, Anthony Liguori wrote: GLib is an extremely common library that has a portable thread implementation along with tons of other goodies. GLib and GObject have a fantastic amount of infrastructure we ca

Re: [Qemu-devel] [PATCH 15/22] qapi: add new QMP server that uses CharDriverState

2011-03-07 Thread Anthony Liguori
On 03/07/2011 07:52 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: +static void qmp_chr_send_greeting(QmpSession *s) +{ +VersionInfo *info; +QObject *vers; +QObject *greeting; +QString *str; + +info = qmp_query_version(NULL); +vers

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Anthony Liguori
On 03/07/2011 05:06 AM, Daniel P. Berrange wrote: On Sun, Mar 06, 2011 at 07:22:45PM -0600, Anthony Liguori wrote: The Error class is similar to QError (now deprecated) except that it supports propagation. This allows for higher quality error handling. It's losely modeled after glib style

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Anthony Liguori
On 03/07/2011 05:06 AM, Daniel P. Berrange wrote: On Sun, Mar 06, 2011 at 07:22:45PM -0600, Anthony Liguori wrote: The Error class is similar to QError (now deprecated) except that it supports propagation. This allows for higher quality error handling. It's losely modeled after glib style

Re: [Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:53 PM, Anthony Liguori wrote: > On 03/07/2011 07:21 AM, Stefan Hajnoczi wrote: >> >> On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori >>  wrote: >> >>> >>> diff --git a/qmp-core.h b/qmp-core.h >>> index e3235ec..5ce02f7 100644 >>> --- a/qmp-core.h >>> +++ b/qmp-core.h >>> @

Re: [Qemu-devel] [PATCH 13/22] qapi: add code generators for QMP command marshaling

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:44 PM, Anthony Liguori wrote: > On 03/07/2011 07:27 AM, Stefan Hajnoczi wrote: >> >> On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori >>  wrote: >> >>> >>> +def print_definition(name, required, optional, retval): >>> >> >> This function is pretty long.  Is there a logical w

Re: [Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

2011-03-07 Thread Anthony Liguori
On 03/07/2011 08:36 AM, Stefan Hajnoczi wrote: Technically void (*)() is an obsolete type in standard C. I can switch to void (*)(void) but it requires casting and requires a typeof() :-/ You're right, void (*)(void) is the proper form for a general function pointer. I think doing this

[Qemu-devel] Re: [PATCH 4/4] i8254: convert to qdev

2011-03-07 Thread Anthony Liguori
On 03/07/2011 01:58 AM, Jan Kiszka wrote: On 2011-03-07 01:32, Anthony Liguori wrote: On 03/06/2011 03:18 PM, Jan Kiszka wrote: It's far from academic as this is user-visible and visible via the command line. I thought it was stated before that there is no guarantee on the

Re: [Qemu-devel] [PATCH 00/22] QAPI Round 1

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > More information about QAPI can be found on the wiki: > > http://wiki.qemu.org/Features/QAPI Thanks for the good documentation. A few thoughts: A "Naming Conventions" section would be a helpful summary of the different entities that .json

[Qemu-devel] Re: [PATCH v2] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Jes Sorensen
On 03/07/11 11:01, Kevin Wolf wrote: > Am 03.03.2011 14:13, schrieb jes.soren...@redhat.com: >> @@ -591,6 +592,12 @@ int do_snapshot_blkdev(Monitor *mon, const QDict >> *qdict, QObject **ret_data) >> goto out; >> } >> >> +strncpy(old_filename, bs->filename, sizeof(old_filename)

[Qemu-devel] [PATCH v3] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Jes . Sorensen
From: Jes Sorensen In case we cannot open the newly created snapshot image, try to fall back to the original image file and continue running on that, which should prevent the guest from aborting. This is a corner case which can happen if the admin by mistake specifies the snapshot file on a virt

Re: [Qemu-devel] Re: [PATCH v2] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Kevin Wolf
Am 07.03.2011 16:24, schrieb Jes Sorensen: > On 03/07/11 11:01, Kevin Wolf wrote: >> Am 03.03.2011 14:13, schrieb jes.soren...@redhat.com: >>> @@ -591,6 +592,12 @@ int do_snapshot_blkdev(Monitor *mon, const QDict >>> *qdict, QObject **ret_data) >>> goto out; >>> } >>> >>> +strn

[Qemu-devel] Re: [PATCH v3] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Kevin Wolf
Am 07.03.2011 16:27, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > In case we cannot open the newly created snapshot image, try to fall > back to the original image file and continue running on that, which > should prevent the guest from aborting. > > This is a corner case which can

[Qemu-devel] Re: [PATCH 4/4] i8254: convert to qdev

2011-03-07 Thread Jan Kiszka
On 2011-03-07 15:57, Anthony Liguori wrote: > On 03/07/2011 01:58 AM, Jan Kiszka wrote: >> On 2011-03-07 01:32, Anthony Liguori wrote: >> >>> On 03/06/2011 03:18 PM, Jan Kiszka wrote: >>> > It's far from academic as this is user-visible and visible via the > command line. >

Re: [Qemu-devel] [PATCH 00/22] QAPI Round 1

2011-03-07 Thread Anthony Liguori
On 03/07/2011 09:08 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: More information about QAPI can be found on the wiki: http://wiki.qemu.org/Features/QAPI Thanks for the good documentation. A few thoughts: A "Naming Conventions" section would be a helpful

[Qemu-devel] [PATCH v2] Do not delete BlockDriverState when deleting the drive

2011-03-07 Thread Ryan Harper
When removing a drive from the host-side via drive_del we currently have the following path: drive_del qemu_aio_flush() bdrv_close() drive_uninit() bdrv_delete() When we bdrv_delete() we end up qemu_free() the BlockDriverState pointer however, the block devices retain a copy of this pointer, see

[Qemu-devel] [PATCH v2] Don't allow multiwrites against a block device without underlying medium

2011-03-07 Thread Ryan Harper
If the block device has been closed, we no longer have a medium to submit IO against, check for this before submitting io. This prevents a segfault further in the code where we dereference elements of the block driver. Signed-off-by: Ryan Harper --- v1->v2: - move bs->drv check to top of fun

[Qemu-devel] Re: kvm crashes with spice while loading qxl

2011-03-07 Thread Marcelo Tosatti
On Sun, Mar 06, 2011 at 12:38:44PM +0200, Avi Kivity wrote: > On 03/05/2011 06:35 PM, Marcelo Tosatti wrote: > >Regarding global mutex, TCG and KVM execution behaviour can become more > >similar wrt locking by dropping qemu_global_mutex during generation and > >execution of TBs. > > How can you do

[Qemu-devel] Re: kvm crashes with spice while loading qxl

2011-03-07 Thread Marcelo Tosatti
On Sun, Mar 06, 2011 at 12:30:59PM +0200, Alon Levy wrote: > On Sat, Mar 05, 2011 at 01:35:58PM -0300, Marcelo Tosatti wrote: > > On Sat, Feb 26, 2011 at 01:29:01PM +0100, Jan Kiszka wrote: > > > > at > > > > /var/tmp/portage/app-emulation/qemu-kvm-0.14.0/work/qemu-kvm-0.14.0/qemu-kvm.c:1466 >

[Qemu-devel] Re: [PATCH v3 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers

2011-03-07 Thread Juan Quintela
Peter Maydell wrote: > Add support for the Versatile Express SYS_CFG registers, which provide > a generic means of reading or writing configuration information from > various parts of the board. We only implement shutdown and reset. > > Also make the RESETCTL register RAZ/WI on Versatile Express r

[Qemu-devel] Qemu 0.9.1

2011-03-07 Thread Marco Cianfriglia
Hi to alll, I'm a student of University Rome Sapienza. I'm working with qemu 0.9.1 for my thesis and I'm trying to understand how a full-emulation (qemu without kvm or kqemu) Virtual Machine works at low level. I studied your smart source code but I don't understand how qemu manages emul

Re: [Qemu-devel] [PATCH v2] Don't allow multiwrites against a block device without underlying medium

2011-03-07 Thread Stefan Hajnoczi
I meant: Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v2] Don't allow multiwrites against a block device without underlying medium

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 4:01 PM, Ryan Harper wrote: > If the block device has been closed, we no longer have a medium to submit > IO against, check for this before submitting io.  This prevents a segfault > further in the code where we dereference elements of the block driver. > > Signed-off-by: Ry

Re: [Qemu-devel] [PATCH v3] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Anthony Liguori
On 03/07/2011 09:27 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen In case we cannot open the newly created snapshot image, try to fall back to the original image file and continue running on that, which should prevent the guest from aborting. This is a corner case which can happen if th

Re: [Qemu-devel] [PATCH v3] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Jes Sorensen
On 03/07/11 17:34, Anthony Liguori wrote: > On 03/07/2011 09:27 AM, jes.soren...@redhat.com wrote: >> if (ret != 0) { >> -abort(); >> +qerror_report(QERR_OPEN_FILE_FAILED, filename); >> +error_printf("do_snapshot_blkdev(): Unable to open newly >> created " >> +

[Qemu-devel] Replacing guest memcpy with host memcpy

2011-03-07 Thread guna spam
Hi Iam using QEMU emulated ARM Realview board with Linux as guest OS for my application development. This virtual machine is running on x86 Linux host. My application is facing performance issue as memcpy in guest machine is taking lot of time compared to the same memcpy in host machine. To improv

Re: [Qemu-devel] [PATCH v3] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Anthony Liguori
On 03/07/2011 10:39 AM, Jes Sorensen wrote: On 03/07/11 17:34, Anthony Liguori wrote: On 03/07/2011 09:27 AM, jes.soren...@redhat.com wrote: if (ret != 0) { -abort(); +qerror_report(QERR_OPEN_FILE_FAILED, filename); +error_printf("do_snapshot_blkdev(): Unable to o

Re: [Qemu-devel] Re: EFI console stopped working in Qemu 0.14.0

2011-03-07 Thread vagran
Yes, you are right, identity_base is 0xfffbc000 in my case and KVM_CAP_SET_IDENTITY_MAP_ADDR is not defined. So, as I understand, the problem is that BIOS size is too large and I have too old KVM module. Also I'm not sure if I can use KVM on 32-bit host for emulating 64-bit guests. Best regards,

[Qemu-devel] [Bug 638955] Re: emulated netcards don't work with recent sunos kernel

2011-03-07 Thread geppz
Stefan, thanks for your work. I tested your patch in comment #29 and it does seem to solve the problem for me for latest openindiana and also for latest nexenta core. Also I checked vanilla rtl8139 and it seems to work for openindiana on qemu-kvm-0.14.0 (with 0.13.0 I think I had problems). Than

[Qemu-devel] Re: KVM call agenda for Mars 8th

2011-03-07 Thread Anthony Liguori
On 03/07/2011 10:18 AM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. - QAPI merge plan Regards, Anthony Liguori Thanks, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More

[Qemu-devel] [Bug 657006] Re: arm v7M - svc insn doesn't trigger PendSV handler

2011-03-07 Thread jb
Issue "solved". In freeRtos, for the first "context switch" (launch the first task), the register pc is written with an adress with le bit0 equal to 1 (thumb). If I change this and set bit0 to 0 (new_pc = task_to_start_pointer & 0xfffe), it is working well. I do not know yet (i will try next w

[Qemu-devel] [PATCH] xen: Add grant reference support to framebuffer/input

2011-03-07 Thread Daniel De Graaf
Request and support using grant references in backends for the keyboard and framebuffer. Signed-off-by: Daniel De Graaf --- hw/xenfb.c | 103 1 files changed, 76 insertions(+), 27 deletions(-) diff --git a/hw/xenfb.c b/hw/xenfb.c ind

[Qemu-devel] [PATCH v2] e1000: Fix multi-descriptor packet checksum offload

2011-03-07 Thread Stefan Hajnoczi
The PCI/PCI-X Family of Gigabit Ethernet Controllers Software Developer’s Manual states the following about the POPTS field: Provides a number of options which control the handling of this packet. This field is ignored except on the first data descriptor of a packet. The current implementa

[Qemu-devel] [RFC][PATCH v7 09/16] virtagent: add va_capabilities HMP/QMP command

2011-03-07 Thread Michael Roth
Signed-off-by: Michael Roth --- hmp-commands.hx | 16 qmp-commands.hx | 33 + 2 files changed, 49 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 372bef4..86817e2 100644 --- a/hmp-commands.hx +++ b/hmp-comma

[Qemu-devel] [RFC][PATCH v7 10/16] virtagent: add "ping" RPC to server

2011-03-07 Thread Michael Roth
Signed-off-by: Michael Roth --- virtagent-server.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index f84546b..b0fc0c4 100644 --- a/virtagent-server.c +++ b/virtagent-server.c @@ -101,15 +101,31 @@ static QDict *

[Qemu-devel] [RFC][PATCH v7 06/16] virtagent: transport definitions

2011-03-07 Thread Michael Roth
This implements an HTTP-like transport for sending UTF-8 encoded RPC requests/responses over the isa/virtio serial channel. Signed-off-by: Michael Roth --- virtagent-transport.c | 432 + 1 files changed, 432 insertions(+), 0 deletions(-) create m

[Qemu-devel] [RFC][PATCH v7 14/16] virtagent: add virtagent chardev

2011-03-07 Thread Michael Roth
Signed-off-by: Michael Roth --- qemu-char.c | 44 1 files changed, 44 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index bd4e944..ffdcadb 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2458,6 +2458,49 @@ fail: return NU

[Qemu-devel] [RFC][PATCH v7 02/16] Add qemu_set_fd_handler() wrappers to qemu-tools.c

2011-03-07 Thread Michael Roth
This adds state information for managing fd handlers to qemu-tools.c so that tools that build against it can implement an I/O loop for interacting with objects that use qemu_set_fd_handler() Signed-off-by: Michael Roth --- qemu-tool.c | 25 - 1 files changed, 24 inserti

[Qemu-devel] [RFC][PATCH v7 01/16] Move code related to fd handlers into utility functions

2011-03-07 Thread Michael Roth
This allows us to implement an i/o loop outside of vl.c that can interact with objects that use qemu_set_fd_handler() Signed-off-by: Michael Roth --- Makefile.objs |2 +- qemu-char.h |4 ++ qemu-ioh.c| 115 + qemu-ioh.h|

[Qemu-devel] [RFC][PATCH v7 11/16] virtagent: add va_ping HMP/QMP command

2011-03-07 Thread Michael Roth
Signed-off-by: Michael Roth --- hmp-commands.hx | 16 qmp-commands.hx | 32 virtagent.c | 45 + virtagent.h |3 +++ 4 files changed, 96 insertions(+), 0 deletions(-) diff --git a/hmp-

[Qemu-devel] [RFC][PATCH v7 07/16] virtagent: base RPC client definitions

2011-03-07 Thread Michael Roth
Signed-off-by: Michael Roth --- monitor.c |1 + qerror.c|8 + qerror.h|6 + virtagent.c | 455 +++ virtagent.h | 46 ++ 5 files changed, 516 insertions(+), 0 deletions(-) create mode 100644 virtagent.c create

[Qemu-devel] [RFC][PATCH v7 13/16] virtagent: add va_shutdown HMP/QMP command

2011-03-07 Thread Michael Roth
Signed-off-by: Michael Roth --- hmp-commands.hx | 16 qmp-commands.hx | 32 virtagent.c | 24 virtagent.h |2 ++ 4 files changed, 74 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-comm

[Qemu-devel] [RFC][PATCH v7 15/16] virtagent: qemu-va, system-level virtagent guest agent

2011-03-07 Thread Michael Roth
Signed-off-by: Michael Roth --- qemu-va.c | 247 + 1 files changed, 247 insertions(+), 0 deletions(-) create mode 100644 qemu-va.c diff --git a/qemu-va.c b/qemu-va.c new file mode 100644 index 000..a9ff56f --- /dev/null +++ b/qem

[Qemu-devel] [RFC][PATCH v7 16/16] virtagent: add bits to build virtagent host/guest components

2011-03-07 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile|4 +++- Makefile.target |2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index eca4c76..46f5730 100644 --- a/Makefile +++ b/Makefile @@ -151,7 +151,7 @@ version-obj-$(CONFIG_WIN32) += version.o ###

[Qemu-devel] [RFC][PATCH v7 12/16] virtagent: add "shutdown" RPC to server

2011-03-07 Thread Michael Roth
Signed-off-by: Michael Roth --- virtagent-server.c | 58 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/virtagent-server.c b/virtagent-server.c index b0fc0c4..3c8c805 100644 --- a/virtagent-server.c +++ b/virtagent-server.c

[Qemu-devel] [RFC][PATCH v7 08/16] virtagnet: base RPC server definitions

2011-03-07 Thread Michael Roth
Signed-off-by: Michael Roth --- virtagent-server.c | 313 virtagent-server.h | 40 +++ 2 files changed, 353 insertions(+), 0 deletions(-) create mode 100644 virtagent-server.c create mode 100644 virtagent-server.h diff --git a/virtag

  1   2   >