Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Peter Maydell
On 10 February 2011 07:47, Anthony Liguori wrote: > So very concretely, I'm suggesting we do the following to target-i386: > 2) get rid of the entire concept of machines.  Creating a i440fx is > essentially equivalent to creating a bare machine. Does that make any sense for anything other than t

[Qemu-devel] Re: [PATCH uq/master -v2 2/2] KVM, MCE, unpoison memory address across reboot

2011-02-10 Thread Jan Kiszka
On 2011-02-10 01:27, Huang Ying wrote: > On Wed, 2011-02-09 at 16:00 +0800, Jan Kiszka wrote: >> On 2011-02-09 04:00, Huang Ying wrote: >>> In Linux kernel HWPoison processing implementation, the virtual >>> address in processes mapping the error physical memory page is marked >>> as HWPoison. So

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Anthony Liguori
On 02/10/2011 09:16 AM, Peter Maydell wrote: On 10 February 2011 07:47, Anthony Liguori wrote: So very concretely, I'm suggesting we do the following to target-i386: 2) get rid of the entire concept of machines. Creating a i440fx is essentially equivalent to creating a bare mach

[Qemu-devel] Re: [PATCH uq/master -v2 2/2] KVM, MCE, unpoison memory address across reboot

2011-02-10 Thread Jan Kiszka
On 2011-02-10 01:27, Huang Ying wrote: >>> @@ -1882,6 +1919,7 @@ int kvm_arch_on_sigbus_vcpu(CPUState *en >>> hardware_memory_error(); >>> } >>> } >>> +kvm_hwpoison_page_add(ram_addr); >>> >>> if (code == BUS_MCEERR_AR) { >>> /*

Re: [Qemu-devel] [PATCH] Make tb_alloc static.

2011-02-10 Thread Tristan Gingold
On Wed, Feb 09, 2011 at 07:52:52PM +0100, Aurelien Jarno wrote: > > What about moving tb_alloc() (with tb_free()) higher in the file? After > all it make sense to have the function creating or destructing a tb > before the function manipulating them. Thanks. Like this ? Tristan. This function

[Qemu-devel] [PATCH] Network functions patches for win32

2011-02-10 Thread Pavel Dovgaluk
This patch contains some fixes for network functions, working in Windows environment, and consists of two parts: 1. net/socket.c fix MSDN includes the following in WSAEALREADY error description for connect() function: "To preserve backward compatibility, this error is reported as WSAEIN

[Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-02-10 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index e950df2..c81fd09 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7 @@ #include "osdep.h" #include "kvm.h

[Qemu-devel] [PATCH 13/18] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async().

2011-02-10 Thread Yoshiaki Tamura
event-tap function is called only when it is on. Signed-off-by: Yoshiaki Tamura --- net.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index 9ba5be2..1176124 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include "qemu-common.h" #include "qe

[Qemu-devel] [PATCH 18/18] Introduce "kemari:" to enable FT migration mode (Kemari).

2011-02-10 Thread Yoshiaki Tamura
When "kemari:" is set in front of URI of migrate command, it will turn on ft_mode to start FT migration mode (Kemari). On the receiver side, the option looks like, -incoming kemari::: Signed-off-by: Yoshiaki Tamura --- hmp-commands.hx |4 +++- migration.c | 12 qmp-comman

[Qemu-devel] [PATCH 04/18] qemu-char: export socket_set_nodelay().

2011-02-10 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index ee4f4ca..7286aeb 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2111,7 +2111,7 @@ static void tcp_chr_telnet_init(int

[Qemu-devel] [PATCH 02/18] Introduce read() to FdMigrationState.

2011-02-10 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Signed-off-by: Yoshiaki Tamura --- migration-tcp.c | 15 +++ migration.c | 13 + migration.h |3 +++ 3 files changed, 31 insertions(+), 0 d

[Qemu-devel] [PATCH 08/18] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-02-10 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura --- hw/hw.h |5 ++ savevm.c | 149 ++ 2 files changed, 154 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h ind

[Qemu-devel] [PATCH 14/18] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush().

2011-02-10 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests were sent from device emulators. Signed-off-by: Yoshiaki Tamura Acked-by: Kevin Wolf --- block.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index b476479..8ddce13 100644

[Qemu-devel] [PATCH 00/18] Kemari for KVM v0.2.10

2011-02-10 Thread Yoshiaki Tamura
Hi, This patch series is a revised version of Kemari for KVM, which applied comments for the previous post. The current code is based on qemu.git f26e5a54f0554798a2e6f7a074b809b13635d007. The changes from v0.2.9 -> v0.2.10 are: - change migrate format to kemari::: (Paolo) The changes from v0.2

[Qemu-devel] [PATCH 03/18] Introduce skip_header parameter to qemu_loadvm_state().

2011-02-10 Thread Yoshiaki Tamura
Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header. Signed-off-by: Yoshiaki Tamura --- migration.c |2 +- savevm.c| 24 +--- sysemu.h|2 +- 3 files changed, 15 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH 15/18] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-02-10 Thread Yoshiaki Tamura
Introduce qemu_savevm_trans_{begin,commit} to send the memory and device info together, while avoiding cancelling memory state tracking. This patch also abstracts common code between qemu_savevm_state_{begin,iterate,commit}. Signed-off-by: Yoshiaki Tamura --- savevm.c | 157

[Qemu-devel] [PATCH 16/18] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on.

2011-02-10 Thread Yoshiaki Tamura
Introduce migrate_ft_trans_put_ready() which kicks the FT transaction cycle. When ft_mode is on, migrate_fd_put_ready() would open ft_trans_file and turn on event_tap. To end or cancel FT transaction, ft_mode and event_tap is turned off. migrate_ft_trans_get_ready() is called to receive ack from

[Qemu-devel] [PATCH 11/18] ioport: insert event_tap_ioport() to ioport_write().

2011-02-10 Thread Yoshiaki Tamura
Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura --- ioport.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index aa4188a..74aebf5 100644 --- a/ioport.c +++ b/ioport.c @@ -27,6 +27,7 @@ #include "ioport.h" #include

[Qemu-devel] [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-10 Thread Yoshiaki Tamura
This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- Makefile.objs

[Qemu-devel] Re: [PATCH] Fix multiple qemu-options.def generation

2011-02-10 Thread Paolo Bonzini
> diff --git a/Makefile.objs b/Makefile.objs > index 4a1eaa1..ee9f190 100755 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -269,10 +269,10 @@ vl.o: QEMU_CFLAGS+=$(GPROF_CFLAGS) > vl.o: QEMU_CFLAGS+=$(SDL_CFLAGS) > -vl.o: qemu-options.def > +vl.o: ../qemu-options.def > os-posix.o: qemu-options.d

[Qemu-devel] Re: [PATCH 18/18] Introduce "kemari:" to enable FT migration mode (Kemari).

2011-02-10 Thread Paolo Bonzini
On 02/10/2011 10:30 AM, Yoshiaki Tamura wrote: When "kemari:" is set in front of URI of migrate command, it will turn on ft_mode to start FT migration mode (Kemari). On the receiver side, the option looks like, -incoming kemari::: Signed-off-by: Yoshiaki Tamura --- hmp-commands.hx |4 +++-

RE: [Qemu-devel] Re: [PATCH] Fix multiple qemu-options.def generation

2011-02-10 Thread Pavel Dovgaluk
> > diff --git a/Makefile.objs b/Makefile.objs > > index 4a1eaa1..ee9f190 100755 > > --- a/Makefile.objs > > +++ b/Makefile.objs > > @@ -269,10 +269,10 @@ vl.o: QEMU_CFLAGS+=$(GPROF_CFLAGS) > > vl.o: QEMU_CFLAGS+=$(SDL_CFLAGS) > > -vl.o: qemu-options.def > > +vl.o: ../qemu-options.def > > os-posix

[Qemu-devel] [PATCH 09/18] Introduce event-tap.

2011-02-10 Thread Yoshiaki Tamura
event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- Makefile.targe

[Qemu-devel] Re: [PATCH] Correct win32 timers deleting v.3

2011-02-10 Thread Paolo Bonzini
On 02/02/2011 12:59 PM, Pavel Dovgaluk wrote: Hello. Anybody interested in this patch? I'm planning to replace the multimedia timer with a queue timer. I'll send the patch soon(ish). Paolo

Re: [Qemu-devel] [PATCH 02/18] Introduce read() to FdMigrationState.

2011-02-10 Thread Yoshiaki Tamura
2011/2/10 Anthony Liguori : > On 02/10/2011 10:30 AM, Yoshiaki Tamura wrote: >> >> Currently FdMigrationState doesn't support read(), and this patch >> introduces it to get response from the other side. >> >> Signed-off-by: Yoshiaki Tamura >> > > Migration is unidirectional.  Changing this is funda

Re: [Qemu-devel] [PATCH 02/18] Introduce read() to FdMigrationState.

2011-02-10 Thread Anthony Liguori
On 02/10/2011 10:30 AM, Yoshiaki Tamura wrote: Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Signed-off-by: Yoshiaki Tamura Migration is unidirectional. Changing this is fundamental and not something to be done lightl

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Anthony Liguori
On 02/10/2011 10:07 AM, Gleb Natapov wrote: So what if it is easier, it doesn't mean it is correct thing to do. If we spend the next 10 years trying to do the "correct thing" for some arbitrary definition of correct, that's not terribly useful. It's really simple actually. Let's do the leas

Re: [Qemu-devel] [RFC][PATCH v6 00/04] qtest: qemu unit testing framework

2011-02-10 Thread Stefan Hajnoczi
On Wed, Feb 9, 2011 at 8:39 PM, Michael Roth wrote: > On 02/09/2011 01:42 PM, Blue Swirl wrote: >> >> On Fri, Feb 4, 2011 at 3:49 PM, Michael Roth >>  wrote: >>> >>> These patches apply to master (2-04-2011), and can also be obtained from: >>> git://repo.or.cz/qemu/mdroth.git qtest_v1 >>> >>> OVER

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Anthony Liguori
On 02/10/2011 10:04 AM, Peter Maydell wrote: On 10 February 2011 08:36, Anthony Liguori wrote: On 02/10/2011 09:16 AM, Peter Maydell wrote: On 10 February 2011 07:47, Anthony Liguoriwrote: 2) get rid of the entire concept of machines. Creating a i440fx is essentially eq

[Qemu-devel] [PATCH 1/2] qdev: Allow hot-plug for lists with pre-filled descriptors

2011-02-10 Thread Amit Shah
This will be needed for hot-plugging chardevs. Signed-off-by: Amit Shah --- monitor.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 7fc311d..f3d7ab3 100644 --- a/monitor.c +++ b/monitor.c @@ -74,8 +74,6 @@ * 'O' option string o

[Qemu-devel] [PATCH 2/2] qdev: Allow chardevs to be hot-plugged

2011-02-10 Thread Amit Shah
This commit enables chardevs to be hot-plugged to a running qemu machine. The syntax is similar to the -chardev command line: (qemu) chardev_add socket,path=/tmp/foo,server,nowait,id=char0 Signed-off-by: Amit Shah --- hmp-commands.hx | 16 hw/qdev.c | 15

Re: [Qemu-devel] [PATCH 02/18] Introduce read() to FdMigrationState.

2011-02-10 Thread Daniel P. Berrange
On Thu, Feb 10, 2011 at 10:54:01AM +0100, Anthony Liguori wrote: > On 02/10/2011 10:30 AM, Yoshiaki Tamura wrote: > >Currently FdMigrationState doesn't support read(), and this patch > >introduces it to get response from the other side. > > > >Signed-off-by: Yoshiaki Tamura > > Migration is unidir

Re: [Qemu-devel] [PATCH 02/18] Introduce read() to FdMigrationState.

2011-02-10 Thread Yoshiaki Tamura
2011/2/10 Daniel P. Berrange : > On Thu, Feb 10, 2011 at 10:54:01AM +0100, Anthony Liguori wrote: >> On 02/10/2011 10:30 AM, Yoshiaki Tamura wrote: >> >Currently FdMigrationState doesn't support read(), and this patch >> >introduces it to get response from the other side. >> > >> >Signed-off-by: Yo

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Avi Kivity
On 02/10/2011 11:07 AM, Gleb Natapov wrote: On Thu, Feb 10, 2011 at 08:47:12AM +0100, Anthony Liguori wrote: > On 02/09/2011 09:15 PM, Blue Swirl wrote: > >On Wed, Feb 9, 2011 at 9:59 PM, Anthony Liguori wrote: > >>On 02/09/2011 06:48 PM, Blue Swirl wrote: > ISASerialState dev; >

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Peter Maydell
On 10 February 2011 10:13, Anthony Liguori wrote: > On 02/10/2011 10:04 AM, Peter Maydell wrote: >> >> On 10 February 2011 08:36, Anthony Liguori  wrote: >>> So you would model arm926ej-s as the chipset and then build up the >>> machines >>> by modifying parameters of the chipset (like the board i

Re: [Qemu-devel] [PATCH 02/18] Introduce read() to FdMigrationState.

2011-02-10 Thread Daniel P. Berrange
On Thu, Feb 10, 2011 at 07:23:33PM +0900, Yoshiaki Tamura wrote: > 2011/2/10 Daniel P. Berrange : > > On Thu, Feb 10, 2011 at 10:54:01AM +0100, Anthony Liguori wrote: > >> On 02/10/2011 10:30 AM, Yoshiaki Tamura wrote: > >> >Currently FdMigrationState doesn't support read(), and this patch > >> >in

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Gleb Natapov
On Thu, Feb 10, 2011 at 11:19:48AM +0100, Anthony Liguori wrote: > On 02/10/2011 11:10 AM, Gleb Natapov wrote: > >On Thu, Feb 10, 2011 at 11:00:50AM +0100, Anthony Liguori wrote: > >>On 02/10/2011 10:07 AM, Gleb Natapov wrote: > >>>So what if it is easier, it doesn't mean it is correct thing to do.

Re: [Qemu-devel] QEMU network probes

2011-02-10 Thread Stefan Hajnoczi
On Wed, Feb 9, 2011 at 7:27 PM, Rayson Ho wrote: > Please review the probe addition in QEMU for the network module, note > that I added probes for send & receive Ethernet frames for rtl8139 so > far but not other network devices. Also for receive, the probe would > only fire when a frame is succes

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Gleb Natapov
On Thu, Feb 10, 2011 at 12:25:38PM +0200, Avi Kivity wrote: > On 02/10/2011 11:07 AM, Gleb Natapov wrote: > >On Thu, Feb 10, 2011 at 08:47:12AM +0100, Anthony Liguori wrote: > >> On 02/09/2011 09:15 PM, Blue Swirl wrote: > >> >On Wed, Feb 9, 2011 at 9:59 PM, Anthony Liguori > >> wrote: > >> >

[Qemu-devel] [PATCH 0.14/master v2 0/4] Error messages for unsupoorted image format features

2011-02-10 Thread Kevin Wolf
With 0.15 we'll most likely get some incompatible image format extensions. This series prepares 0.14 to output more helpful messages if it stumbles over a too new image file. Kevin Wolf (4): qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE qcow2: Report error for version > 2 qed: Report error f

[Qemu-devel] [PATCH v2 3/4] qed: Report error for unsupported features

2011-02-10 Thread Kevin Wolf
Instead of just returning -ENOTSUP, generate a more detailed error. Unfortunately we don't have a helpful text for features that we don't know yet, so just print the feature mask. It might be useful at least if someone asks for help. Signed-off-by: Kevin Wolf --- block/qed.c |9 - 1

[Qemu-devel] [PATCH v2 1/4] qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE

2011-02-10 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qerror.c |5 + qerror.h |3 +++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 9d0cdeb..4855604 100644 --- a/qerror.c +++ b/qerror.c @@ -201,6 +201,11 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH v2 2/4] qcow2: Report error for version > 2

2011-02-10 Thread Kevin Wolf
The qcow2 driver is now declared responsible for any QCOW image that has version 2 or greater (before this, version 3 would be detected as raw). For everything newer than version 2, an error is reported. Signed-off-by: Kevin Wolf --- block/qcow2.c | 13 +++-- 1 files changed, 11 inser

[Qemu-devel] [PATCH v2 4/4] qemu-img: Improve error messages for failed bdrv_open

2011-02-10 Thread Kevin Wolf
Output the error message string of the bdrv_open return code. Also set a non-empty device name for the images because the unknown feature error message includes it. Signed-off-by: Kevin Wolf --- qemu-img.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/qemu-img

[Qemu-devel] [PATCH v3 0/6] target-arm: Fix floating point conversions

2011-02-10 Thread Peter Maydell
This patchset fixes two issues: * default_nan_mode not being honoured for float-to-float conversions * half precision conversions being broken in a number of ways as well as not handling default_nan_mode. With this patchset qemu passes random-instruction-selection tests for VCVT.F32.F16, VCVT

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Gleb Natapov
On Thu, Feb 10, 2011 at 10:38:53AM +, Peter Maydell wrote: > This is the system diagram for the Versatile Express: > http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0447d/I1007683.html > I don't know what you'd want to claim is a "northbridge" there. > Basically there's an FPGA w

[Qemu-devel] [PATCH v3 5/6] target-arm: Silence NaNs resulting from half-precision conversions

2011-02-10 Thread Peter Maydell
Silence the NaNs that may result from half-precision conversion, as we do for the other conversions. Signed-off-by: Peter Maydell --- target-arm/helper.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index d29c42b..

[Qemu-devel] [PATCH v3 4/6] softfloat: Correctly handle NaNs in float16_to_float32()

2011-02-10 Thread Peter Maydell
Correctly handle NaNs in float16_to_float32(), by defining and using a float16ToCommonNaN() function, as we do with the other formats. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h | 17 + fpu/softfloat.c|4 +--- 2 files changed, 18 insertions(+),

[Qemu-devel] [PATCH v3 2/6] softfloat: Honour default_nan_mode for float-to-float conversions

2011-02-10 Thread Peter Maydell
From: Christophe Lyon Honour the default_nan_mode flag when doing conversions between different floating point formats, as well as when returning a NaN from a two-operand floating point function. This corrects the behaviour of float<->double conversions on both ARM and SH4. Signed-off-by: Christ

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-10 Thread Alexander Graf
Scott Wood wrote: > On Wed, 9 Feb 2011 18:21:40 +0100 > Alexander Graf wrote: > > >> On 07.02.2011, at 21:15, Scott Wood wrote: >> >> >>> That's pretty much what the proposed API does -- except it uses a void >>> pointer instead of uint64_t *. >>> >> Oh? Did I miss something there?

[Qemu-devel] [PATCH v3 1/6] softfloat: Add float16 type and float16 NaN handling functions

2011-02-10 Thread Peter Maydell
Add a float16 type to softfloat, rather than using bits16 directly. Also add the missing functions float16_is_quiet_nan(), float16_is_signaling_nan() and float16_maybe_silence_nan(), which are needed for the float16 conversion routines. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h

[Qemu-devel] [PATCH v3 6/6] target-arm: Use standard FPSCR for Neon half-precision operations

2011-02-10 Thread Peter Maydell
The Neon half-precision conversion operations (VCVT.F16.F32 and VCVT.F32.F16) use ARM standard floating-point arithmetic, unlike the VFP versions (VCVTB and VCVTT). Signed-off-by: Peter Maydell --- target-arm/helper.c| 26 ++ target-arm/helpers.h |2 ++ target

[Qemu-devel] [PATCH v3 3/6] softfloat: Fix single-to-half precision float conversions

2011-02-10 Thread Peter Maydell
Fix various bugs in the single-to-half-precision conversion code: * input NaNs not correctly converted in IEEE mode (fixed by defining and using a commonNaNToFloat16()) * wrong values returned when converting NaN/Inf into non-IEEE half precision value * wrong values returned for conversion

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-10 Thread Alexander Graf
Scott Wood wrote: > On Thu, 3 Feb 2011 10:19:06 +0100 > Alexander Graf wrote: > > >> Yeah, that one's tricky. Usually the way the memory resolver in qemu works >> is as follows: >> >> * kvm goes to qemu >> * qemu fetches all mmu and register data from kvm >> * qemu runs its mmu resolution f

[Qemu-devel] Re: [PATCH v2 3/4] qed: Report error for unsupported features

2011-02-10 Thread Stefan Hajnoczi
On Thu, Feb 10, 2011 at 11:18 AM, Kevin Wolf wrote: > Instead of just returning -ENOTSUP, generate a more detailed error. > > Unfortunately we don't have a helpful text for features that we don't know > yet, > so just print the feature mask. It might be useful at least if someone asks > for > he

Re: [Qemu-devel] [PATCH 1/2] qdev: Allow hot-plug for lists with pre-filled descriptors

2011-02-10 Thread Amit Shah
On (Thu) 10 Feb 2011 [12:57:30], Markus Armbruster wrote: > Amit Shah writes: > > > This will be needed for hot-plugging chardevs. > > > > Signed-off-by: Amit Shah > > --- > > monitor.c |4 +--- > > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > diff --git a/monitor.c b/monitor.c

[Qemu-devel] Re: [PATCH 0.14/master v2 0/4] Error messages for unsupoorted image format features

2011-02-10 Thread Anthony Liguori
On 02/10/2011 12:18 PM, Kevin Wolf wrote: With 0.15 we'll most likely get some incompatible image format extensions. This series prepares 0.14 to output more helpful messages if it stumbles over a too new image file. Kevin Wolf (4): qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE qcow2: Repo

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Anthony Liguori
On 02/10/2011 11:49 AM, Gleb Natapov wrote: On Thu, Feb 10, 2011 at 11:19:48AM +0100, Anthony Liguori wrote: On 02/10/2011 11:10 AM, Gleb Natapov wrote: On Thu, Feb 10, 2011 at 11:00:50AM +0100, Anthony Liguori wrote: On 02/10/2011 10:07 AM, Gleb Natapov wrote: So

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Anthony Liguori
On 02/10/2011 12:13 PM, Gleb Natapov wrote: Which spec? Even in this discussion we completely mixed different things. 440FX is not a chipset. Yes, it is. It's a single silicon package with a defined pinout. If you don't believe me, re-read the spec. It's a MCM with the PIIX3 being interna

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Avi Kivity
On 02/10/2011 02:51 PM, Anthony Liguori wrote: On 02/10/2011 12:13 PM, Gleb Natapov wrote: Which spec? Even in this discussion we completely mixed different things. 440FX is not a chipset. Yes, it is. It's a single silicon package with a defined pinout. If you don't believe me, re-read the

[Qemu-devel] [PATCH] spice: update command line help

2011-02-10 Thread Alon Levy
--- qemu-options.hx | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 945edf3..287e910 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -672,7 +672,19 @@ Enable SDL. ETEXI DEF("spice", HAS_ARG, QEMU_OPTION_spice,

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Gleb Natapov
On Thu, Feb 10, 2011 at 01:47:06PM +0100, Anthony Liguori wrote: > On 02/10/2011 11:49 AM, Gleb Natapov wrote: > >On Thu, Feb 10, 2011 at 11:19:48AM +0100, Anthony Liguori wrote: > >>On 02/10/2011 11:10 AM, Gleb Natapov wrote: > >>>On Thu, Feb 10, 2011 at 11:00:50AM +0100, Anthony Liguori wrote: >

[Qemu-devel] Re: [Spice-devel] [PATCH] spice: update command line help

2011-02-10 Thread Alon Levy
On Thu, Feb 10, 2011 at 03:08:56PM +0200, Alon Levy wrote: > --- > qemu-options.hx | 14 +- > 1 files changed, 13 insertions(+), 1 deletions(-) Self NACK, had a typo (extra '['). > > diff --git a/qemu-options.hx b/qemu-options.hx > index 945edf3..287e910 100644 > --- a/qemu-option

[Qemu-devel] Re: [PATCH] vhost: disable on tap link down

2011-02-10 Thread pradeep
On Tue, 8 Feb 2011 17:41:12 +0200 "Michael S. Tsirkin" wrote: > On Tue, Feb 08, 2011 at 05:40:58PM +0530, pradeep wrote: > > On Mon, 7 Feb 2011 15:50:01 +0200 > > "Michael S. Tsirkin" wrote: > > > > > qemu makes it possible to disable link at tap > > > which is not communicated to the guest but

[Qemu-devel] [PATCH] spice: update command line help

2011-02-10 Thread Alon Levy
--- v2, now with matching parenthesis. --- qemu-options.hx | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 945edf3..9ec5b4c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -672,7 +672,19 @@ Enable SDL. ETEXI D

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Gleb Natapov
On Thu, Feb 10, 2011 at 01:51:14PM +0100, Anthony Liguori wrote: > On 02/10/2011 12:13 PM, Gleb Natapov wrote: > > > >Which spec? Even in this discussion we completely mixed different > >things. 440FX is not a chipset. > > Yes, it is. It's a single silicon package with a defined pinout. > If you

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Gleb Natapov
On Thu, Feb 10, 2011 at 03:00:05PM +0200, Avi Kivity wrote: > On 02/10/2011 02:51 PM, Anthony Liguori wrote: > >On 02/10/2011 12:13 PM, Gleb Natapov wrote: > >> > >>Which spec? Even in this discussion we completely mixed different > >>things. 440FX is not a chipset. > > > >Yes, it is. It's a singl

[Qemu-devel] [PATCH 0/2] softfloat: fix USE_SOFTFLOAT_STRUCT_TYPES compile failures

2011-02-10 Thread Peter Maydell
This patchset fixes some compilation failures which happen if you try to enable softfloat's USE_SOFTFLOAT_STRUCT_TYPES type-error-debugging switch. This patchset leaves one error in float16_to_float32, because that is fixed in passing by my half-precision patchset, and I saw no point in deliberate

[Qemu-devel] [PATCH 1/2] softfloat: Fix compilation failures with USE_SOFTFLOAT_STRUCT_TYPES

2011-02-10 Thread Peter Maydell
Make softfloat compile with USE_SOFTFLOAT_STRUCT_TYPES defined, by adding and using new macros const_float32() and const_float64() so you can use array initializers in an array of float32/float64 whether the types are bare or wrapped in the structs. Signed-off-by: Peter Maydell --- fpu/softfloat

[Qemu-devel] [PATCH 2/2] linux-user/arm: fix compilation failures using softfloat's struct types

2011-02-10 Thread Peter Maydell
Add uses of the float32/float64 boxing and unboxing macros so that the ARM linux-user targets will compile with USE_SOFTFLOAT_STRUCT_TYPES enabled. Signed-off-by: Peter Maydell --- linux-user/arm/nwfpe/fpa11_cpdt.c |2 +- linux-user/arm/nwfpe/fpopcode.c | 32 -

Re: [Qemu-devel] [PATCH v3] Fix ATA SMART and CHECK POWER MODE

2011-02-10 Thread Brian Wheeler
On Wed, 2011-02-09 at 17:22 -0600, Ryan Harper wrote: > * Brian Wheeler [2011-02-09 16:13]: > > This patch fixes two things: > > > > 1) CHECK POWER MODE > > > > The error return value wasn't always zero, so it would show up as > > offline. Error is now explicitly set to zero. > > > > 2) SMAR

[Qemu-devel] [PATCH v4] Fix ATA SMART and CHECK POWER MODE

2011-02-10 Thread Brian Wheeler
This patch fixes two things: 1) CHECK POWER MODE The error return value wasn't always zero, so it would show up as offline. Error is now explicitly set to zero. 2) SMART The smart values that were returned were invalid and tools like skdump would not recognize that the smart data was act

[Qemu-devel] [Bug 498107] Re: www.qemu.org and www.nongnu.org/qemu have a lot of bugs

2011-02-10 Thread rowa
qemu 0.14.0 rc1 Not in qemu-doc.html: (qemu) info spice BTW: The qemu instanz crashed with "info spice": kvm ReactOS.img -spice port=12345,disable-ticketing -vga qxl -monitor stdio''' (qemu) info spice Server: address: 0.0.0.0:12345 auth: none qemu: qdict.c:193: qdict_get_obj: As

[Qemu-devel] Re: AHCI in SeaBIOS

2011-02-10 Thread Kevin O'Connor
On Tue, Feb 08, 2011 at 12:57:41AM +0100, Alexander Graf wrote: > Hi Kevin, > > Do you remember why you put AHCI in with default=n? I'd like to see > it enabled in Qemu 0.14 and IIUC we use the default configuration > for that. Hi Alex, Sorry - I've gotten behind on emails. The reason for not e

[Qemu-devel] Re: AHCI in SeaBIOS

2011-02-10 Thread Alexander Graf
Kevin O'Connor wrote: > On Tue, Feb 08, 2011 at 12:57:41AM +0100, Alexander Graf wrote: > >> Hi Kevin, >> >> Do you remember why you put AHCI in with default=n? I'd like to see >> it enabled in Qemu 0.14 and IIUC we use the default configuration >> for that. >> > > Hi Alex, > > Sorry - I've

[Qemu-devel] Re: AHCI in SeaBIOS

2011-02-10 Thread Alexander Graf
Kevin O'Connor wrote: > On Thu, Feb 10, 2011 at 04:25:11PM +0100, Alexander Graf wrote: > >> Kevin O'Connor wrote: >> >>> On Tue, Feb 08, 2011 at 12:57:41AM +0100, Alexander Graf wrote: >>> Do you remember why you put AHCI in with default=n? I'd like to see it enabled in Qe

Re: [Qemu-devel] Re: AHCI in SeaBIOS

2011-02-10 Thread Anthony Liguori
On 02/10/2011 04:25 PM, Alexander Graf wrote: Kevin O'Connor wrote: On Tue, Feb 08, 2011 at 12:57:41AM +0100, Alexander Graf wrote: Hi Kevin, Do you remember why you put AHCI in with default=n? I'd like to see it enabled in Qemu 0.14 and IIUC we use the default configuration for tha

[Qemu-devel] [PATCH 03/11] qcow2: Fix error handling for immediate backing file read failure

2011-02-10 Thread Kevin Wolf
Requests could return success even though they failed when bdrv_aio_readv returned NULL for a backing file read. Reported-by: Chunqiang Tang Signed-off-by: Kevin Wolf --- block/qcow2.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c inde

[Qemu-devel] [PULL 00/11] Block patches for master

2011-02-10 Thread Kevin Wolf
The following changes since commit 6c5f738daec123020d32543fe90a6633a4f6643e: microblaze: Handle singlestepping over direct jmps (2011-02-10 00:46:09 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Chunqiang Tang (1): QCOW2: bug fix - read base

[Qemu-devel] [PATCH 09/11] blockdev: Plug memory leak in drive_uninit()

2011-02-10 Thread Kevin Wolf
From: Markus Armbruster Started leaking in commit 1dae12e6. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index ecfadc1..24d7658 100644 --- a/blockdev.c +++ b/blockdev.

[Qemu-devel] [PATCH 10/11] blockdev: Plug memory leak in drive_init() error paths

2011-02-10 Thread Kevin Wolf
From: Markus Armbruster Should have spotted this when doing commit 319ae529. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 24d7658..0690cc8 100644 --- a

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: Use standard FPSCR for Neon half-precision operations

2011-02-10 Thread Aurelien Jarno
On Wed, Feb 09, 2011 at 04:27:30PM +, Peter Maydell wrote: > The Neon half-precision conversion operations (VCVT.F16.F32 and > VCVT.F32.F16) use ARM standard floating-point arithmetic, unlike > the VFP versions (VCVTB and VCVTT). > > Signed-off-by: Peter Maydell > --- > target-arm/helper.c

[Qemu-devel] [PATCH 02/11] QCOW2: bug fix - read base image beyond its size

2011-02-10 Thread Kevin Wolf
From: Chunqiang Tang This patch fixes the following bug in QCOW2. For a QCOW2 image that is larger than its base image, when handling a read request straddling over the end of the base image, the QCOW2 driver attempts to read beyond the end of the base image and the request would fail. This bug

[Qemu-devel] [PATCH 11/11] qcow2: Fix order in L2 table COW

2011-02-10 Thread Kevin Wolf
When copying L2 tables (this happens only with internal snapshots), the order wasn't completely safe, so that after a crash you could end up with a L2 table that has too low refcount, possibly leading to corruption in the long run. This patch puts the operations in the right order: First allocate

Re: [Qemu-devel] [PATCH 0/2] target-arm: Fix VQMOV(U)N

2011-02-10 Thread Aurelien Jarno
On Wed, Feb 09, 2011 at 03:42:31PM +, Peter Maydell wrote: > This patchset fixes the VQMOV(U)N instructions (saturating narrowing > conversions). Tested by random generation of instructions for > VQMOVN, VQMOVUN, VMOVN. > > Patch 1/2 is the same as the one Christophe sent recently but I have >

[Qemu-devel] [PATCH 01/11] Change snapshot_blkdev hmp to use correct argument type for device

2011-02-10 Thread Kevin Wolf
From: Jes Sorensen Pointed out by Markus Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- hmp-commands.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 38e1eb7..372bef4 100644 --- a/hmp-commands.hx +++ b/hmp-commands

[Qemu-devel] [PATCH 04/11] qcow2: Fix error handling for reading compressed clusters

2011-02-10 Thread Kevin Wolf
When reading a compressed cluster failed, qcow2 falsely returned success. Signed-off-by: Kevin Wolf Reviewed-by: Markus Armbruster --- block/qcow2-cluster.c |4 ++-- block/qcow2.c |4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/block/qcow2-cluster.c b/blo

[Qemu-devel] [PATCH 08/11] qemu-img: Improve error messages for failed bdrv_open

2011-02-10 Thread Kevin Wolf
Output the error message string of the bdrv_open return code. Also set a non-empty device name for the images because the unknown feature error message includes it. Signed-off-by: Kevin Wolf Reviewed-by: Anthony Liguori --- qemu-img.c | 10 +++--- 1 files changed, 7 insertions(+), 3 delet

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-10 Thread Anthony Liguori
On 02/09/2011 06:35 PM, Aurelien Jarno wrote: On Tue, Feb 08, 2011 at 04:08:28PM +0100, Aurelien Jarno wrote: Aurelien Jarno a écrit : Paolo Bonzini a écrit : On 02/08/2011 12:15 PM, Aurelien Jarno wrote: however it should not be done ignoring all the*current* dra

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-10 Thread Anthony Liguori
On 02/10/2011 03:20 PM, Gleb Natapov wrote: Jugging by how well all previous conversion went we will end up with one more way of creating devices. One legacy, another qdev and your new one. And what is the problem with qdev again (not that I am a big qdev fan)? We've really been arguing abo

[Qemu-devel] [PATCH] linux-user: fix compile failure if !CONFIG_USE_GUEST_BASE

2011-02-10 Thread Peter Maydell
If CONFIG_USE_GUEST_BASE is not defined, gcc complains: linux-user/mmap.c:235: error: comparison of unsigned expression >= 0 is always true because RESERVED_VA is #defined to 0. Since mmap_find_vma_reserved() will never be called anyway if RESERVED_VA is always 0, fix this by simply #ifdef'ing a

[Qemu-devel] Re: [PATCH uq/master -v2 2/2] KVM, MCE, unpoison memory address across reboot

2011-02-10 Thread Huang Ying
On Wed, 2011-02-09 at 16:00 +0800, Jan Kiszka wrote: > On 2011-02-09 04:00, Huang Ying wrote: > > In Linux kernel HWPoison processing implementation, the virtual > > address in processes mapping the error physical memory page is marked > > as HWPoison. So that, the further accessing to the virtual

[Qemu-devel] Re: AHCI in SeaBIOS

2011-02-10 Thread Paolo Bonzini
On 02/10/2011 04:37 PM, Anthony Liguori wrote: We're right around the corner from -rc2 so let's wait until after 0.14 is released so we have a full release cycle to test it. And have unusable or only partly usable features (already mentioned multiple times: boot order, AHCI) in 0.14? Paolo

[Qemu-devel] [PATCH 5/7] include qemu-thread.h early

2011-02-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Cc: Stefan Weil Cc: Blue Swirl --- cpus.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 4c9928e..68b3fcb 100644 --- a/cpus.c +++ b/cpus.c @@ -32,6 +32,7 @@ #include "kvm.h" #include "exec-all.h" +#include "qemu-

[Qemu-devel] [PATCH 4/7] add win32 qemu-thread implementation

2011-02-10 Thread Paolo Bonzini
For now, qemu_cond_timedwait and qemu_mutex_timedlock are left as POSIX-only functions. They can be removed later, once the patches that remove their uses are in. Signed-off-by: Paolo Bonzini Cc: Stefan Weil Cc: Blue Swirl --- Makefile.objs|4 +- qemu-thread.c => q

[Qemu-devel] [PATCH 2/7] implement win32 dynticks timer

2011-02-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Cc: Stefan Weil Cc: Blue Swirl --- qemu-timer.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index b0db780..42960de 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -1006,6 +1006,7 @@ static void win32_stop

[Qemu-devel] [PATCH 6/7] add assertions on the owner of a QemuMutex

2011-02-10 Thread Paolo Bonzini
These are already present in the Win32 implementation, add them to the pthread wrappers as well. Signed-off-by: Paolo Bonzini Cc: Stefan Weil Cc: Blue Swirl --- qemu-thread-posix.c | 20 +++- qemu-thread-posix.h |1 + 2 files changed, 20 insertions(+), 1 deletions(-) dif

[Qemu-devel] [PATCH 7/7] remove CONFIG_THREAD

2011-02-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Cc: Stefan Weil Cc: Blue Swirl --- configure |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 598e8e1..46a6389 100755 --- a/configure +++ b/configure @@ -2609,7 +2609,6 @@ if test "$vnc_png" != "no" ; then fi if

[Qemu-devel] [PATCH 1/7] unlock iothread during WaitForMultipleObjects

2011-02-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Cc: Stefan Weil Cc: Blue Swirl --- os-win32.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/os-win32.c b/os-win32.c index 566d5e9..d907c59 100644 --- a/os-win32.c +++ b/os-win32.c @@ -140,7 +140,9 @@ void os_host_main_loop_wait(int *timeo

Re: [Qemu-devel] [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-10 Thread Paolo Bonzini
On 02/09/2011 11:16 PM, Stefan Weil wrote: I decided to create a new directory structure hosts/w32, so files can be moved from the root to hosts/posix, hosts/w32, or hosts/xxx. Include chains reduce code modifications and conditional compilations. And people who don't want to see w32 support can

  1   2   >