[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 08:26 AM, Aurelien Jarno wrote: I forget to remember when we decided that AIO should be implemented on any host OS. Any pointer? To be fair, I/O-heavy workloads are almost unusable without AIO. For Window targets, they also crash under SMP due to the Windows AP watchdog. But t

Re: [Qemu-devel] [trivial PATCH 0.14+] fix compile error on i386

2011-02-08 Thread Michael Tokarev
http://article.gmane.org/gmane.comp.emulators.kvm.devel/67445 -- Ping? qemu (0.14rc1) still can't be compiled on 32bit i386 host due to this. /mjt 05.02.2011 13:48, Jan Kiszka wrote: > On 2011-02-05 10:27, Michael Tokarev wrote: >> When compiling on i386 (32bit) compiler choles on this: >> >> C

Re: [Qemu-devel] [PATCH] tap: minor code cleanup

2011-02-08 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > remove a confusing comment. > TAP_DEFAULT_SNDBUF 0 is later translated to INT_MAX, so > let's set that value directly. > > Signed-off-by: Michael S. Tsirkin > --- > net/tap-linux.c |7 +-- > 1 files changed, 1 insertions(+), 6 deletions(-) > > diff --git a

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Jan Kiszka
On 2011-02-08 09:08, Paolo Bonzini wrote: > On 02/08/2011 08:26 AM, Aurelien Jarno wrote: >> I forget to remember when we decided that AIO should be implemented on >> any host OS. Any pointer? > > To be fair, I/O-heavy workloads are almost unusable without AIO. For > Window targets, they also cr

[Qemu-devel] Re: [PATCH 1/7] io-thread: make sure to initialize qemu_work_cond and qemu_cpu_cond

2011-02-08 Thread Jan Kiszka
On 2011-01-24 22:00, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > > diff --git a/cpus.c b/cpus.c > index 0309189..9cf7e6e 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -412,8 +412,10 @@ int qemu_init_main_loop(void) > if (ret) > return ret; > > -qemu_cond_init(&qemu_p

Re: [Qemu-devel] Re: [PATCH 1/7] io-thread: make sure to initialize qemu_work_cond and qemu_cpu_cond

2011-02-08 Thread Anthony Liguori
On 02/08/2011 02:53 AM, Jan Kiszka wrote: On 2011-01-24 22:00, Anthony Liguori wrote: Signed-off-by: Anthony Liguori diff --git a/cpus.c b/cpus.c index 0309189..9cf7e6e 100644 --- a/cpus.c +++ b/cpus.c @@ -412,8 +412,10 @@ int qemu_init_main_loop(void) if (ret) return ret;

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Jan Kiszka a écrit : > On 2011-02-08 09:08, Paolo Bonzini wrote: >> On 02/08/2011 08:26 AM, Aurelien Jarno wrote: >>> I forget to remember when we decided that AIO should be implemented on >>> any host OS. Any pointer? >> To be fair, I/O-heavy workloads are almost unusable without AIO. For >> Win

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-08 Thread Avi Kivity
On 02/07/2011 07:30 PM, Yoder Stuart-B08248 wrote: > -Original Message- > From: kvm-ppc-ow...@vger.kernel.org [mailto:kvm-ppc-ow...@vger.kernel.org] > On Behalf Of Avi Kivity > Sent: Monday, February 07, 2011 11:14 AM > To: Alexander Graf > Cc: Wood Scott-B07421; Yoder Stuart-B0824

Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-08 Thread Avi Kivity
On 02/07/2011 09:30 PM, Anthony Liguori wrote: For the purposes of this, I think passing an opaque is better because the signature stays the same as the existing timer callback. That makes conversion a bit friendlier. I think it's better to avoid introducing stylistic changes with new inte

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Anthony Liguori
On 02/08/2011 03:05 AM, Aurelien Jarno wrote: Jan Kiszka a écrit : On 2011-02-08 09:08, Paolo Bonzini wrote: On 02/08/2011 08:26 AM, Aurelien Jarno wrote: I forget to remember when we decided that AIO should be implemented on any host OS. Any pointer? To be fair, I

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Stefan Hajnoczi
On Tue, Feb 8, 2011 at 2:29 AM, Lucas Meneghel Rodrigues wrote: > If I understood correctly, a build slave is a machine where the > compilation happens and then the build master can report appropriately > upon failure/pass. The way the kvm autotest jobs are setup nowadays > provides just that, an

[Qemu-devel] Re: KVM call agenda for Feb 8

2011-02-08 Thread Stefan Hajnoczi
On Mon, Feb 7, 2011 at 10:40 PM, Chris Wright wrote: > Please send in any agenda items you are interested in covering. Automated builds and testing: maintainer trees, integrating KVM-Autotest, and QEMU tests we need but don't exist Stefan

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 10:12 AM, Anthony Liguori wrote: The guilty here is IOTHREAD. Windows support predates IOTHREAD concept, QEMU has never "supported" Windows. I think both assertions are false. What's true is that the Win32 port has never evolved beyond "barely functional", at least by the stan

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Jan Kiszka
On 2011-02-08 10:05, Aurelien Jarno wrote: > Jan Kiszka a écrit : >> On 2011-02-08 09:08, Paolo Bonzini wrote: >>> On 02/08/2011 08:26 AM, Aurelien Jarno wrote: I forget to remember when we decided that AIO should be implemented on any host OS. Any pointer? >>> To be fair, I/O-heavy workl

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Jan Kiszka a écrit : > On 2011-02-08 10:05, Aurelien Jarno wrote: >> Jan Kiszka a écrit : >>> On 2011-02-08 09:08, Paolo Bonzini wrote: On 02/08/2011 08:26 AM, Aurelien Jarno wrote: > I forget to remember when we decided that AIO should be implemented on > any host OS. Any pointer? >>>

[Qemu-devel] [PATCH] Handle icount for powerpc tbl/tbu/decr load and store.

2011-02-08 Thread Tristan Gingold
Handle option '-icount X' on powerpc targets. Signed-off-by: Tristan Gingold --- target-ppc/translate_init.c | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 907535e..7ef86

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Jan Kiszka
On 2011-02-08 10:58, Aurelien Jarno wrote: > Jan Kiszka a écrit : >> On 2011-02-08 10:05, Aurelien Jarno wrote: >>> Jan Kiszka a écrit : On 2011-02-08 09:08, Paolo Bonzini wrote: > On 02/08/2011 08:26 AM, Aurelien Jarno wrote: >> I forget to remember when we decided that AIO should be

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 10:58 AM, Aurelien Jarno wrote: And what's the issue with that? People don't always look for performance when using QEMU. They even often try to emulate old machines (and non x86 ones), which anyway only have one CPU. This won't change in 5 years, the only thing is that those machin

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Jan Kiszka a écrit : > On 2011-02-08 10:58, Aurelien Jarno wrote: >> Jan Kiszka a écrit : >>> On 2011-02-08 10:05, Aurelien Jarno wrote: Jan Kiszka a écrit : > On 2011-02-08 09:08, Paolo Bonzini wrote: >> On 02/08/2011 08:26 AM, Aurelien Jarno wrote: >>> I forget to remember when w

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Stefan Hajnoczi
Introducing IOTHREAD made !CONFIG_IOTHREAD platforms second class citizens. I think you'd like people to provide full support when they introduce new features. This is a good motivator to use glib and have a unified code path for TCG/KVM and Linux/Windows. Yes it will require some work and some

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Alexander Graf
On 08.02.2011, at 11:06, Aurelien Jarno wrote: > Jan Kiszka a écrit : >> On 2011-02-08 10:58, Aurelien Jarno wrote: >>> Jan Kiszka a écrit : On 2011-02-08 10:05, Aurelien Jarno wrote: > Jan Kiszka a écrit : >> On 2011-02-08 09:08, Paolo Bonzini wrote: >>> On 02/08/2011 08:26 AM,

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Jan Kiszka
On 2011-02-08 11:06, Aurelien Jarno wrote: > Jan Kiszka a écrit : >> On 2011-02-08 10:58, Aurelien Jarno wrote: >>> Jan Kiszka a écrit : On 2011-02-08 10:05, Aurelien Jarno wrote: > Jan Kiszka a écrit : >> On 2011-02-08 09:08, Paolo Bonzini wrote: >>> On 02/08/2011 08:26 AM, Aureli

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Jan Kiszka
On 2011-02-08 11:26, Aurelien Jarno wrote: > Jan Kiszka a écrit : >> On 2011-02-08 11:06, Aurelien Jarno wrote: >>> Jan Kiszka a écrit : On 2011-02-08 10:58, Aurelien Jarno wrote: > Jan Kiszka a écrit : >> On 2011-02-08 10:05, Aurelien Jarno wrote: >>> Jan Kiszka a écrit :

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Jan Kiszka a écrit : > On 2011-02-08 11:06, Aurelien Jarno wrote: >> Jan Kiszka a écrit : >>> On 2011-02-08 10:58, Aurelien Jarno wrote: Jan Kiszka a écrit : > On 2011-02-08 10:05, Aurelien Jarno wrote: >> Jan Kiszka a écrit : >>> On 2011-02-08 09:08, Paolo Bonzini wrote:

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Stefan Hajnoczi a écrit : > Introducing IOTHREAD made !CONFIG_IOTHREAD platforms second class > citizens. I think you'd like people to provide full support when they > introduce new features. > I think you really pointed the problem here. We should probably add a feature that will make KVM secon

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 11:27 AM, Aurelien Jarno wrote: Stefan Hajnoczi a écrit : Introducing IOTHREAD made !CONFIG_IOTHREAD platforms second class citizens. I think you'd like people to provide full support when they introduce new features. I think you really pointed the problem here. We should probab

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Jan Kiszka
On 2011-02-08 11:27, Aurelien Jarno wrote: > Stefan Hajnoczi a écrit : >> Introducing IOTHREAD made !CONFIG_IOTHREAD platforms second class >> citizens. I think you'd like people to provide full support when they >> introduce new features. >> > > I think you really pointed the problem here. We sh

[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Anthony Liguori
On 02/08/2011 04:06 AM, Aurelien Jarno wrote: Yes, it's slow. But is it a problem? You assume that people use QEMU only for emulating SMP platforms. This is a wrong assumption. Beside the x86 target, only sparc really supports SMP emulation. It's *not* just about performance. TCG requires

[Qemu-devel] [PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2011-02-08 Thread Yoshiaki Tamura
Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Signed-off-by: Yoshiaki Tamura --- hw/hw.h |2 ++ savevm.c | 20 +++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 5e24329..a168a37 100644 --- a/hw/

[Qemu-devel] [PATCH 06/19] virtio: decrement last_avail_idx with inuse before saving.

2011-02-08 Thread Yoshiaki Tamura
For regular migration inuse == 0 always as requests are flushed before save. However, event-tap log when enabled introduces an extra queue for requests which is not being flushed, thus the last inuse requests are left in the event-tap queue. Move the last_avail_idx value sent to the remote back to

[Qemu-devel] [PATCH 12/19] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-02-08 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index e950df2..c81fd09 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7 @@ #include "osdep.h" #include "kvm.h

[Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-02-08 Thread Yoshiaki Tamura
Introduce qemu_savevm_trans_{begin,commit} to send the memory and device info together, while avoiding cancelling memory state tracking. This patch also abstracts common code between qemu_savevm_state_{begin,iterate,commit}. Signed-off-by: Yoshiaki Tamura --- savevm.c | 157

[Qemu-devel] [PATCH 17/19] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled.

2011-02-08 Thread Yoshiaki Tamura
When ft_mode is set in the header, tcp_accept_incoming_migration() sets ft_trans_incoming() as a callback, and call qemu_file_get_notify() to receive FT transaction iteratively. We also need a hack no to close fd before moving to ft_transaction mode, so that we can reuse the fd for it. vm_change_

[Qemu-devel] [PATCH 04/19] qemu-char: export socket_set_nodelay().

2011-02-08 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index ee4f4ca..7286aeb 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2111,7 +2111,7 @@ static void tcp_chr_telnet_init(int

[Qemu-devel] [PATCH 13/19] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async().

2011-02-08 Thread Yoshiaki Tamura
event-tap function is called only when it is on. Signed-off-by: Yoshiaki Tamura --- net.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index 9ba5be2..1176124 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include "qemu-common.h" #include "qe

[Qemu-devel] [PATCH 02/19] Introduce read() to FdMigrationState.

2011-02-08 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Signed-off-by: Yoshiaki Tamura --- migration-tcp.c | 15 +++ migration.c | 13 + migration.h |3 +++ 3 files changed, 31 insertions(+), 0 d

[Qemu-devel] [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.

2011-02-08 Thread Yoshiaki Tamura
The option looks like, -incoming kemari::: Signed-off-by: Yoshiaki Tamura --- migration.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 9d2abff..4dc02a2 100644 --- a/migration.c +++ b/migration.c @@ -48,6 +48,12 @@ int qemu_start_in

[Qemu-devel] [PATCH 11/19] ioport: insert event_tap_ioport() to ioport_write().

2011-02-08 Thread Yoshiaki Tamura
Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura --- ioport.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index aa4188a..74aebf5 100644 --- a/ioport.c +++ b/ioport.c @@ -27,6 +27,7 @@ #include "ioport.h" #include

[Qemu-devel] [PATCH 10/19] Call init handler of event-tap at main() in vl.c.

2011-02-08 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura --- vl.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 00155fb..f4d4abf 100644 --- a/vl.c +++ b/vl.c @@ -162,6 +162,7 @@ int main(int argc, char **argv) #include "qemu-queue.h" #include "cpus.h" #include "arch_init.h

[Qemu-devel] [PATCH 03/19] Introduce skip_header parameter to qemu_loadvm_state().

2011-02-08 Thread Yoshiaki Tamura
Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header. Signed-off-by: Yoshiaki Tamura --- migration.c |2 +- savevm.c| 24 +--- sysemu.h|2 +- 3 files changed, 15 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH 07/19] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-08 Thread Yoshiaki Tamura
This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- Makefile.objs

[Qemu-devel] [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2011-02-08 Thread Yoshiaki Tamura
When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). Signed-off-by: Yoshiaki Tamura --- hmp-commands.hx |7 --- migration.c |4 qmp-commands.hx |7 --- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/h

[Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-02-08 Thread Yoshiaki Tamura
event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- Makefile.targe

[Qemu-devel] [PATCH 00/19] Kemari for KVM v0.2.9

2011-02-08 Thread Yoshiaki Tamura
Hi, This patch series is a revised version of Kemari for KVM, which applied comments for the previous post. The current code is based on qemu.git f26e5a54f0554798a2e6f7a074b809b13635d007. The changes from v0.2.8 -> v0.2.9 are: - abstract common code between qemu_savevm_{state,trans}_* (Paolo) -

[Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush().

2011-02-08 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests were sent from device emulators. Signed-off-by: Yoshiaki Tamura --- block.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index b476479..8ddce13 100644 --- a/block.c +++ b/bl

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Tristan Gingold
On Feb 8, 2011, at 6:58 PM, Anthony Liguori wrote: > On 02/08/2011 04:06 AM, Aurelien Jarno wrote: >> Yes, it's slow. But is it a problem? You assume that people use QEMU >> only for emulating SMP platforms. This is a wrong assumption. Beside the >> x86 target, only sparc really supports SMP emul

[Qemu-devel] [PATCH 16/19] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on.

2011-02-08 Thread Yoshiaki Tamura
Introduce migrate_ft_trans_put_ready() which kicks the FT transaction cycle. When ft_mode is on, migrate_fd_put_ready() would open ft_trans_file and turn on event_tap. To end or cancel FT transaction, ft_mode and event_tap is turned off. migrate_ft_trans_get_ready() is called to receive ack from

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 02/08/2011 04:06 AM, Aurelien Jarno wrote: >> Yes, it's slow. But is it a problem? You assume that people use QEMU >> only for emulating SMP platforms. This is a wrong assumption. Beside the >> x86 target, only sparc really supports SMP emulation. >> > > It's *no

[Qemu-devel] [PATCH 05/19] vl.c: add deleted flag for deleting the handler.

2011-02-08 Thread Yoshiaki Tamura
Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura --- vl.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index ed2cdfa..00155fb 100644 ---

[Qemu-devel] [PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-02-08 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura --- hw/hw.h |5 ++ savevm.c | 149 ++ 2 files changed, 154 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h ind

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Lucas Meneghel Rodrigues
On Tue, 2011-02-08 at 09:23 +, Stefan Hajnoczi wrote: > Public automated qemu.git autotest would be excellent. To be honest I > haven't had much visibility of KVM-Autotest myself as a QEMU/KVM > developer. I suspect many others haven't either but there are big > benefits if we can change this

Re: [Qemu-devel] Re: new->old version migration

2011-02-08 Thread Michael S. Tsirkin
On Tue, Feb 08, 2011 at 01:42:59AM -0600, Anthony Liguori wrote: > On 02/08/2011 12:42 AM, Michael S. Tsirkin wrote: > >On Mon, Feb 07, 2011 at 08:23:08PM -0600, Anthony Liguori wrote: > >>On 02/07/2011 03:52 PM, Michael S. Tsirkin wrote: > >>>How does it? We need to know we are saving in 0.13 > >>

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Anthony Liguori
On 02/08/2011 04:27 AM, Aurelien Jarno wrote: Stefan Hajnoczi a écrit : Introducing IOTHREAD made !CONFIG_IOTHREAD platforms second class citizens. I think you'd like people to provide full support when they introduce new features. I think you really pointed the problem here. We sho

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 02/08/2011 04:27 AM, Aurelien Jarno wrote: >> Stefan Hajnoczi a écrit : >> >>> Introducing IOTHREAD made !CONFIG_IOTHREAD platforms second class >>> citizens. I think you'd like people to provide full support when they >>> introduce new features. >>> >>> >>

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Alexander Graf
On 08.02.2011, at 12:23, Lucas Meneghel Rodrigues wrote: > On Tue, 2011-02-08 at 09:23 +, Stefan Hajnoczi wrote: >> Public automated qemu.git autotest would be excellent. To be honest I >> haven't had much visibility of KVM-Autotest myself as a QEMU/KVM >> developer. I suspect many others h

[Qemu-devel] [PATCH] Make tb_alloc static.

2011-02-08 Thread Tristan Gingold
This function is only used within exec.c, so no need to make it public. Signed-off-by: Tristan Gingold --- exec-all.h |1 - exec.c |4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/exec-all.h b/exec-all.h index 81497c0..c062693 100644 --- a/exec-all.h +++ b/exec

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Stefan Hajnoczi
On Tue, Feb 8, 2011 at 11:23 AM, Lucas Meneghel Rodrigues wrote: > Bottom line, the thing here is to have available hardware externally > accessible, just like the buildbot that was setup, mentioned previously > on this thread. Remember the buildslaves don't need to have incoming TCP ports open a

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Stefan Hajnoczi
On Tue, Feb 8, 2011 at 11:14 AM, Daniel Gollub wrote: > On Monday, February 07, 2011 10:34:03 am Stefan Hajnoczi wrote: >> I have a buildmaster at buildbot.vmsplice.net.  I could share my >> master.cfg with you so that you can take over and merge it into your >> KVM buildmaster.  Then I would take

Re: [Qemu-devel] [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG case

2011-02-08 Thread Jan Kiszka
On 2011-02-08 12:39, Aurelien Jarno wrote: > On Fri, Feb 04, 2011 at 01:47:25PM -0200, Marcelo Tosatti wrote: >> From: Jan Kiszka >> >> When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like >> it is done for KVM. Use the symbolic constants at this chance. >> >> Signed-off-by: Jan

Re: [Qemu-devel] [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG case

2011-02-08 Thread Aurelien Jarno
On Fri, Feb 04, 2011 at 01:47:25PM -0200, Marcelo Tosatti wrote: > From: Jan Kiszka > > When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like > it is done for KVM. Use the symbolic constants at this chance. > > Signed-off-by: Jan Kiszka > Signed-off-by: Marcelo Tosatti > ---

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
On Tue, Feb 08, 2011 at 12:07:02PM +0100, Tristan Gingold wrote: > > On Feb 8, 2011, at 6:58 PM, Anthony Liguori wrote: > > > On 02/08/2011 04:06 AM, Aurelien Jarno wrote: > >> Yes, it's slow. But is it a problem? You assume that people use QEMU > >> only for emulating SMP platforms. This is a wr

[Qemu-devel] Re: [PATCH] vhost: disable on tap link down

2011-02-08 Thread pradeep
On Mon, 7 Feb 2011 15:50:01 +0200 "Michael S. Tsirkin" wrote: > qemu makes it possible to disable link at tap > which is not communicated to the guest but > causes all packets to be dropped. > > Handle this with vhost simply by moving to the userspace emulation. > > Note: it might be a good ide

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 12:15 PM, Aurelien Jarno wrote: however it should not be done ignoring all the*current* drawbacks of the iothread mode. We know them (at least for some of them), so let's try to solve them. Let's also enumerate them. And now, I don't buy the argument "it's been there for years"

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 12:46 PM, Aurelien Jarno wrote: Given the I/O thread is disabled by default, my guess is that nobody really see an interest in looking at that. I had started looking at it in my free time. I stopped because the thread pool series were continuously changing the QemuThread APIs.

[Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2011-02-08 Thread Paolo Bonzini
On 02/08/2011 12:01 PM, Yoshiaki Tamura wrote: When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). This could also use a "kemari:" prefix. Paolo

Re: [Qemu-devel] [V4 PATCH 2/8] Provide chroot environment server side interfaces

2011-02-08 Thread M. Mohan Kumar
Hi, Is it okay to fork the chroot process in the fsdev parameter parsing time? Can we ask other initialization routines to not create threads till chroot process is forked? Following code snippet forks the chroot process during fsdev parameter parsing to avoid the problems associated with fork

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Anthony Liguori
On 02/08/2011 05:15 AM, Aurelien Jarno wrote: Anthony Liguori a écrit : On 02/08/2011 04:06 AM, Aurelien Jarno wrote: Yes, it's slow. But is it a problem? You assume that people use QEMU only for emulating SMP platforms. This is a wrong assumption. Beside the x86 target, only sparc re

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Anthony Liguori
On 02/08/2011 05:46 AM, Aurelien Jarno wrote: On Tue, Feb 08, 2011 at 12:07:02PM +0100, Tristan Gingold wrote: On Feb 8, 2011, at 6:58 PM, Anthony Liguori wrote: On 02/08/2011 04:06 AM, Aurelien Jarno wrote: Yes, it's slow. But is it a problem? You assume that people use QEM

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Alexander Graf
On 08.02.2011, at 12:28, Stefan Hajnoczi wrote: > On Tue, Feb 8, 2011 at 11:23 AM, Lucas Meneghel Rodrigues > wrote: >> Bottom line, the thing here is to have available hardware externally >> accessible, just like the buildbot that was setup, mentioned previously >> on this thread. > > Remembe

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Riku Voipio
On Tue, Feb 08, 2011 at 12:05:31PM -0600, Anthony Liguori wrote: > Aurelien, > Have you actually run QEMU on Windows and tried to use it to do > something useful? I'm not Aurelian, but we do use QEMU on win32 as part of Nokia Qt SDK. While it is second class in many ways compared to Linux QEMU

[Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2011-02-08 Thread Yoshiaki Tamura
2011/2/8 Paolo Bonzini : > On 02/08/2011 12:01 PM, Yoshiaki Tamura wrote: >> >> When -k option is set to migrate command, it will turn on ft_mode to >> start FT migration mode (Kemari). > > This could also use a "kemari:" prefix. Sorry, missed that comment. BTW, the help message would be like pu

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 02/08/2011 05:15 AM, Aurelien Jarno wrote: >> Anthony Liguori a écrit : >> >>> On 02/08/2011 04:06 AM, Aurelien Jarno wrote: >>> Yes, it's slow. But is it a problem? You assume that people use QEMU only for emulating SMP platforms. This is a wrong

[Qemu-devel] Migration of WinXP Guest -> usb+network failure

2011-02-08 Thread Peter Lieven
Hi, is there any known issue when migrating a WinXP SP3 guest with qemu-kvm 0.13.0 or qemu-kvm-0.12.5? If I migrate such a guest with a Realtek rtl8139 Network Device and an USB Mouse Tablet after migration the USB Tablet doesn't work any more and network stalls. I have seen the mouse moving

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Paolo Bonzini a écrit : > On 02/08/2011 12:15 PM, Aurelien Jarno wrote: >> however >> it should not be done ignoring all the*current* drawbacks of the >> iothread mode. We know them (at least for some of them), so let's try to >> solve them. > > Let's also enumerate them. > >From what I know: -

[Qemu-devel] Re: Buildbot for qemu.git/master

2011-02-08 Thread Daniel Gollub
Hi Stefan, On Monday, February 07, 2011 10:34:03 am Stefan Hajnoczi wrote: > I have a buildmaster at buildbot.vmsplice.net. I could share my > master.cfg with you so that you can take over and merge it into your > KVM buildmaster. Then I would take my buildmaster offline. Ok. This would be ver

Re: [Qemu-devel] [PATCH 4/8] target-arm: fiddle decoding of 64 bit shift by imm and narrow

2011-02-08 Thread Peter Maydell
On 31 January 2011 18:06, wrote: > From: Christophe Lyon > > Tweak decoding of the shift-by-imm and narrow 64 bit insns > (VSHRN, VRSHRN, VQSHRN, VQSHRUN, VQRSHRN, VQRSHRUN). > > Signed-off-by: Christophe Lyon > --- >  target-arm/translate.c |   28 ++-- >  1 files change

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Anthony Liguori
On 02/08/2011 07:30 AM, Aurelien Jarno wrote: So the strategy is let's break everything and wait for the maintainer to fix that? This strategy doesn't work, we have seen for example that with the SeaBIOS switch. While it brings nice features, it has broken the isapc machine. And it's still not fi

Re: [Qemu-devel] [PATCH 3/8] target-arm: VQRSHRN related changes

2011-02-08 Thread Peter Maydell
On 31 January 2011 18:06, wrote: > From: Christophe Lyon > > More fixes for VQSHRN and VQSHRUN. > > Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell as far as the code goes, but the commit message is excessively vague. -- PMM

Re: [Qemu-devel] [PATCHv2] e1000: multi-buffer packet support

2011-02-08 Thread Kevin Wolf
Am 03.02.2011 17:49, schrieb Michael S. Tsirkin: > e1000 supports multi-buffer packets larger than rxbuf_size. > > This fixes the following (on linux): > - in guest: ifconfig eth1 mtu 16110 > - in host: ifconfig tap0 mtu 16110 >ping -s 16082 > > Red Hat bugzilla: https://bugzilla.red

[Qemu-devel] [PATCH master+0.14 0/2] blockdev memory leaks

2011-02-08 Thread Markus Armbruster
Markus Armbruster (2): blockdev: Plug memory leak in drive_uninit() blockdev: Plug memory leak in drive_init() error paths blockdev.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) -- 1.7.2.3

[Qemu-devel] [PATCH master+0.14 2/2] blockdev: Plug memory leak in drive_init() error paths

2011-02-08 Thread Markus Armbruster
Should have spotted this when doing commit 319ae529. Signed-off-by: Markus Armbruster --- blockdev.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 24d7658..0690cc8 100644 --- a/blockdev.c +++ b/blockdev.c @@ -526,7 +526,7 @@ Driv

[Qemu-devel] [PATCH master+0.14 1/2] blockdev: Plug memory leak in drive_uninit()

2011-02-08 Thread Markus Armbruster
Started leaking in commit 1dae12e6. Signed-off-by: Markus Armbruster --- blockdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index ecfadc1..24d7658 100644 --- a/blockdev.c +++ b/blockdev.c @@ -182,6 +182,7 @@ static void drive_uninit(DriveI

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Aurelien Jarno a écrit : > Paolo Bonzini a écrit : >> On 02/08/2011 12:15 PM, Aurelien Jarno wrote: >>> however >>> it should not be done ignoring all the*current* drawbacks of the >>> iothread mode. We know them (at least for some of them), so let's try to >>> solve them. >> Let's also enumerate

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-08 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 02/08/2011 07:30 AM, Aurelien Jarno wrote: >> So the strategy is let's break everything and wait for the maintainer to >> fix that? This strategy doesn't work, we have seen for example that with >> the SeaBIOS switch. While it brings nice features, it has broken the >

Re: [Qemu-devel] [PATCH 03/16] qdev-properties: add PROP_TYPE_ENUM

2011-02-08 Thread Alon Levy
On Mon, Feb 07, 2011 at 04:27:21PM +0200, Alon Levy wrote: > On Mon, Feb 07, 2011 at 03:00:25PM +0100, Markus Armbruster wrote: > > Alon Levy writes: > > > > > On Mon, Feb 07, 2011 at 09:53:44AM +0100, Markus Armbruster wrote: > > >> I haven't been able to follow the evolution of this series, my

[Qemu-devel] Re: [PATCH] vhost: disable on tap link down

2011-02-08 Thread Michael S. Tsirkin
On Tue, Feb 08, 2011 at 05:40:58PM +0530, pradeep wrote: > On Mon, 7 Feb 2011 15:50:01 +0200 > "Michael S. Tsirkin" wrote: > > > qemu makes it possible to disable link at tap > > which is not communicated to the guest but > > causes all packets to be dropped. > > > > Handle this with vhost simpl

Re: [Qemu-devel] [PATCH 03/16] qdev-properties: add PROP_TYPE_ENUM

2011-02-08 Thread Markus Armbruster
Alon Levy writes: > On Mon, Feb 07, 2011 at 04:27:21PM +0200, Alon Levy wrote: >> On Mon, Feb 07, 2011 at 03:00:25PM +0100, Markus Armbruster wrote: [...] >> > Sounds like what I have in mind. Care to explore it? >> > >> > One EnumTable should do, just make its member value wide enough. >> > >

[Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Chris Wright
Automated builds and testing - found broken 32-bit - luiz suggested running against maintainer trees - daniel gollub offered to take on maintenance - integration with kvm-autotest? - lucas, daniel, stefan... - testing each git commit is probably overkill and too expensive - current autotest r

Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-08 Thread Peter Maydell
On 7 February 2011 17:00, Christophe Lyon wrote: > > Some CPUs have a status flag imposing to return floatxx_default_nan > whatever the input value, when converting from one FP format to > another. Implement this, using the already existing default_nan_mode > status flag (currently used on ARM and

Re: [Qemu-devel] [PATCHv2] e1000: multi-buffer packet support

2011-02-08 Thread Michael S. Tsirkin
On Tue, Feb 08, 2011 at 03:07:58PM +0100, Kevin Wolf wrote: > Am 03.02.2011 17:49, schrieb Michael S. Tsirkin: > > e1000 supports multi-buffer packets larger than rxbuf_size. > > > > This fixes the following (on linux): > > - in guest: ifconfig eth1 mtu 16110 > > - in host: ifconfig tap0 mtu 16110

[Qemu-devel] Re: KVM call minutes for Feb 8

2011-02-08 Thread Stefan Hajnoczi
On Tue, Feb 8, 2011 at 3:55 PM, Chris Wright wrote: > Automated builds and testing > - found broken 32-bit The broken build was found (and fixed?) before automated qemu.git builds. It's a good motivator though. Stefan

[Qemu-devel] [PATCHv2] vhost: disable on tap link down

2011-02-08 Thread Michael S. Tsirkin
qemu makes it possible to disable link at tap which is not communicated to the guest but causes all packets to be dropped. Handle this with vhost simply by moving to the userspace emulation. Note: it might be a good idea to make peer link status match tap in this case, so the guest gets an event

[Qemu-devel] Re: [V4 PATCH 3/8] Add client side interfaces for chroot environment

2011-02-08 Thread M. Mohan Kumar
On Wednesday 02 February 2011 3:24:16 pm Stefan Hajnoczi wrote: > On Tue, Feb 1, 2011 at 5:26 AM, M. Mohan Kumar wrote: > > +/* Receive file descriptor and error status from chroot process */ > > +static int v9fs_receivefd(int sockfd, int *error) > > The return value and int *error overlap in fun

[Qemu-devel] [ANNOUNCE] QEMU 0.14.0-rc1 is available

2011-02-08 Thread Anthony Liguori
The QEMU team is pleased to announce the availability of the 0.14.0-rc1 release. This is the second release candidate for the 0.14.0 release. A detailed changelog is at the end of this message. Download instructions are available at http://wiki.qemu.org/Download You can help test this relea

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Anthony Liguori
On 02/08/2011 09:55 AM, Chris Wright wrote: Automated builds and testing - found broken 32-bit - luiz suggested running against maintainer trees - daniel gollub offered to take on maintenance - integration with kvm-autotest? - lucas, daniel, stefan... - testing each git commit is probably o

[Qemu-devel] [PATCH] qcow2: Fix error handling for immediate backing file read failure

2011-02-08 Thread Kevin Wolf
Requests could return success even though they failed when bdrv_aio_readv returned NULL for a backing file read. Reported-by: Chunqiang Tang Signed-off-by: Kevin Wolf --- block/qcow2.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c inde

Re: [Qemu-devel] [PATCH 02/17] lm32: translation routines

2011-02-08 Thread Richard Henderson
On 01/30/2011 04:30 PM, Michael Walle wrote: > +if (dc->format == OP_FMT_RI) { > +tcg_gen_brcondi_tl(cond, cpu_R[rY], sign_extend(dc->imm16, 16), l1); > +} else { > +tcg_gen_brcond_tl(cond, cpu_R[rY], cpu_R[rZ], l1); > +} > +tcg_gen_movi_tl(cpu_R[rX], 0); > +tcg_

[Qemu-devel] [PATCH v2] target-arm: implement vsli.64, vsri.64

2011-02-08 Thread Christophe Lyon
Signed-off-by: Christophe Lyon --- Submitted as a standalone patch as suggested by Peter, along with his corrections. target-arm/translate.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index e4649e6..b69

Re: [Qemu-devel] [PATCH] qcow2: Fix error handling for immediate backing file read failure

2011-02-08 Thread Markus Armbruster
Kevin Wolf writes: > Requests could return success even though they failed when bdrv_aio_readv > returned NULL for a backing file read. > > Reported-by: Chunqiang Tang > Signed-off-by: Kevin Wolf > --- > block/qcow2.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --g

[Qemu-devel] [CFT PATCH 08/12] do not use timedwait on qemu_halt_cond

2011-02-08 Thread Paolo Bonzini
The following conditions can cause cpu_has_work(env) to become true: - env->queued_work_first: run_on_cpu is already kicking the VCPU - env->stop = 1: pause_all_vcpus is already kicking the VCPU - env->stopped = 0: resume_all_vcpus is already kicking the VCPU - vm_running = 1: vm_start is calli

  1   2   >