Amit Shah writes:
> Hello,
>
> This is yet another rebase of the patchset I'd sent earlier.
>
> The usual notes apply: this is just the start, just getting the
> framework in place and a few examples so that people can then pick up
> and start documenting their devices and options. We want to se
agraf reported that qemu_mutex_destroy(vs->output_mutex) while failing
in vnc_disconnect_finish().
It's because vnc_worker_thread_loop() tries to unlock the mutex while
not locked. The unlocking call doesn't fail (pthread bug ?), but
the destroy call does.
Signed-off-by: Corentin Chary
---
ui/v
From: Corentin Chary
Hi,
Since v2:
- Fixed some styles issues
- Rebased to current master
- Fixed a Makefile issue (using .c instead of .o)
I rebased the series against current master, it contains:
- Adaptive Tight Encoding: send lossy or lossless updates depending on the
update frequency of
Blue Swirl writes:
> Disabling some devices from build is a frequently requested feature.
> Provide means to disable vmware_vga, vmmouse and HPET.
Long patch series without proper threading are a PITA to review.
git-send-email adds the necessary headers automatically. Could you try
using it? T
These two helpers are needed for zrle and zywrle.
Signed-off-by: Corentin Chary
---
ui/vnc-palette.c | 32
ui/vnc-palette.h |3 +++
2 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
index f93250b..c478060 10
If an adaptive encoding has choosen to send a lossy update
based on the result of vnc_update_freq(), then it should advertise
it with vnc_sent_lossy_rect(). This will allow to automatically refresh
this rect once it's static again.
Signed-off-by: Corentin Chary
---
ui/vnc-jobs-async.c |2 +
This should not change the current behavior, but if any new
encoding try to use the tight quality, it will always be set
to -1 when lossy encodings are disabled.
Signed-off-by: Corentin Chary
---
ui/vnc.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/ui/vnc.c b/ui/v
This patch compute the update frequency (in Hz) for each 64x64 rects.
Any adaptive encoding can get this value using vnc_update_freq(), and
switch to a lossy encoding if the value is too high.
The frequency is pre-calculated every 500ms, based on the last 10
updates per 64x64 rect.
If a 64x64 rec
** Changed in: linux (Gentoo Linux)
Importance: Unknown => Medium
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/181561
Title:
Hardy alpha [2-6] daily-live i386 don't boot
Status in The Linux Ke
We now that the palette will never have more than 256
elements. Let's use a pool to reduce malloc calls.
Signed-off-by: Corentin Chary
---
ui/vnc-palette.c | 18 ++
ui/vnc-palette.h |3 ++-
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/ui/vnc-palette.c b/u
Use the new update frequency infrastructure to use jpeg for regions with
high update frequency.
Signed-off-by: Corentin Chary
---
ui/vnc-enc-tight.c | 75 +++-
1 files changed, 62 insertions(+), 13 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/
This allow to use palette on the stack instead of always
allocating them.
Signed-off-by: Corentin Chary
---
ui/vnc-palette.c |8 +++-
ui/vnc-palette.h |1 +
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
index c47420b..f93250b 10064
Add most used bitmap and bitops functions into bitmap.c and bitops.c.
Theses functions are mostly copied from Linux kernel source.
Some of these functions are already redefined in the VNC server. Some
of them could be used for some block stuff. The yet yo be submitted
NUMA work also need bitmaps.
Signed-off-by: Corentin Chary
---
ui/vnc-enc-tight.c |4 ++--
ui/vnc-enc-zrle.c |3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index ad9a9a8..81024d5 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -1546,7 +1546,
The for loop in send_lossy_rect was totally wrong, and we can't
call vnc_set_bits() because it does not really do what it should.
Use vnc_set_bit() directly instead.
Signed-off-by: Corentin Chary
---
ui/vnc.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/ui/
From: Jes Sorensen
Pointed out by Markus
Signed-off-by: Jes Sorensen
---
hmp-commands.hx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 38e1eb7..372bef4 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -822,7 +822,7 @@ ETE
Respect client size if it doesn't not support desktop resizing.
Signed-off-by: Corentin Chary
---
ui/vnc.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 6c57b0e..86c23207 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -795,12 +795,11 @@ stat
This option allow to disable adaptive behaviors in some encodings.
Signed-off-by: Corentin Chary
---
qemu-options.hx|9 +
ui/vnc-enc-tight.c |2 +-
ui/vnc.c | 13 +
ui/vnc.h |1 +
4 files changed, 20 insertions(+), 5 deletions(-)
diff --
** Changed in: linux
Importance: Unknown => Medium
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/181561
Title:
Hardy alpha [2-6] daily-live i386 don't boot
Status in The Linux Kernel:
Fix Rel
This can happen if a port gets unplugged before guest has chance to
initialise vqs.
Reported-by: Juan Quintela
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 09e
Anthony Liguori writes:
> On 02/03/2011 11:02 AM, Daniel P. Berrange wrote:
>> On Thu, Feb 03, 2011 at 10:35:51AM -0600, Anthony Liguori wrote:
>>
>>> On 02/03/2011 10:29 AM, Daniel P. Berrange wrote:
>>>
On Mon, Jan 31, 2011 at 02:43:19PM -0600, Anthony Liguori wrote:
On 2011-02-04 03:06, Anthony Liguori wrote:
> On 02/03/2011 03:24 PM, Jan Kiszka wrote:
>> On 2011-02-03 21:07, Anthony Liguori wrote:
>>
>>> On 02/03/2011 09:28 AM, Jan Kiszka wrote:
>>>
On 2011-02-03 14:43, Ulrich Obergfell wrote:
> Hi,
>
> I am observing
Switch to bitmap.h and bitops.h instead of redefining our own bitmap
helpers.
Signed-off-by: Corentin Chary
---
ui/vnc.c | 91 ++---
ui/vnc.h |7 +++--
2 files changed, 25 insertions(+), 73 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc
The force_jpeg threshold was too low.
Signed-off-by: Corentin Chary
---
ui/vnc-enc-tight.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 81024d5..82c1e96 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc
Anthony,
in reply to:
> My point is that there's really low hanging fruit and while for some
> curious reason I don't actually see this patch, I believe that a patch
> like this probably can help us quite a lot in the short term.
I've sent the patch in two separate emails:
- code part 1 (intro
Thanks for your help. I've subscribed to these mailing list. Have i do
report the bug in these mailing list too ? (or is it a useless other
duplication ?)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs
On Fri, Feb 4, 2011 at 8:22 AM, wrote:
> From: Jes Sorensen
>
> Pointed out by Markus
>
> Signed-off-by: Jes Sorensen
> ---
> hmp-commands.hx | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Reviewed-by: Stefan Hajnoczi
On Thu, Jan 27, 2011 at 11:45:55AM -0600, Anthony Liguori wrote:
> On 01/27/2011 09:52 AM, Kevin Wolf wrote:
> >This adds a preallocation=full mode to qcow2 image creation, which does not
> >only allocate metadata for the whole image, but also writes zeros to it,
> >creating a non-sparse image file
On 24 January 2011 12:41, Christophe Lyon wrote:
> Here is an updated patch with these minor fixes.
> +uint64_t HELPER(neon_qadd_u64)(CPUState *env, uint64_t src1, uint64_t src2)
> +{
> + uint64_t res;
> +
> + res = src1 + src2;
> + if (res < src1) {
> + SET_QC();
> + res = ~(uint64_t)0;
To help make the stable branch more active than it has been in the past,
I'd like to split the stable branch into a separate tree to allow the
tree to develop a life of its own over time.
I'd like to begin this process with 0.14 and as such, have created a new
stable tree at git://git.qemu.org
From: Jes Sorensen
Hi
This is a first attempt to add fsfreeze support to virtagent. The idea
is for the guest agent to walk the list of locally mounted file
systems in the guest, and issuing an ioctl to freeze them. The host
can then do a live snapshot of the guest, obtaining stable file
systems
On 02/03/11 18:41, Michael Roth wrote:
> On 02/02/2011 02:48 AM, Jes Sorensen wrote:
>> Yes very much so[1] - one reason why it would be nice to have virtagent
>> use threads to execute the actual commands. We should probably add a
>> flag to agent commands indicating whether they issue disk I/O or
On 02/02/2011 01:28 PM, Stefan Weil wrote:
Hello,
these are some patches which I found on my stack of open patches.
All of them should go into 0.14, and at least some of them could also
be applied to 0.13.
This need the following Acks:
[PATCH] hw/fmopl: Fix buffer access out-of-bounds err
From: Jes Sorensen
This patch adds the following monitor commands:
agent_fsfreeze:
- Freezes all local file systems in the guest. Command will print
the number of file systems that were frozen.
agent_fsthaw:
- Thaws all local file systems in the guest. Command will print
the number of fi
On 25 January 2011 17:18, Christophe Lyon wrote:
> This patch fixes the errors reported by my tests in VSRA.
>
> Signed-off-by: Christophe Lyon
Reviewed-by: Peter Maydell
Amit Shah wrote:
> This can happen if a port gets unplugged before guest has chance to
> initialise vqs.
>
> Reported-by: Juan Quintela
> Signed-off-by: Amit Shah
> ---
> hw/virtio-serial-bus.c |3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/virtio-serial-bus.
On 02/03/11 19:11, Michael Roth wrote:
>> @@ -217,6 +221,186 @@ static xmlrpc_value *va_hello(xmlrpc_env *env,
>> return result;
>> }
>>
>> +
>> +/*
>> + * Walk the mount table and build a list of local file systems
>> + */
>> +
>> +struct direntry {
>> +char *dirname;
>> +char *dev
Tested-by: Artyom Tarasenko
> There's two bugs in phys_page_find_alloc(). When the bottom level L2
> table is populated with IO_MEM_UNASSIGNED, region_offset is then used
> for reporting the physical address. First, region_offset may not be
> aligned to the base address of the L2 region. And s
On 02/04/2011 01:30 PM, Anthony Liguori wrote:
[PATCH 3/3] w64: Fix problem with missing sigset_t
(http://patchwork.ozlabs.org/patch/79947/)
We don't support w64...
AFAIK mingw-w64 supports both 32-bit and 64-bit compilation, so the
patch subject is misleading.
Paolo
From: Jes Sorensen
Implement freeze/thaw support in the guest, allowing the host to
request the guest freezes all it's file systems before a live snapshot
is performed.
- fsfreeze(): Walk the list of mounted local real file systems,
and freeze them.
- fsthaw(): Walk the list of
I've also updated http://wiki.qemu.org/Planning/0.14
No dates were changed, but I've put in dates for two release
candidates. I'll be travelling over the next week but I don't expect
that to be a problem here.
Please note that the dates are targets for tagging. Formal
announcements will la
On 02/02/2011 10:34 PM, Yoshiaki Tamura wrote:
Although it's rare to happen in live migration, when the head of a
byte stream contains 0x05 which is the marker of subsection, the
loader gets corrupted because vmstate_subsection_load() continues even
the device doesn't require it. This patch adds
On 02/03/2011 07:48 AM, Paolo Bonzini wrote:
Suggested by Aurelien Jarno.
Signed-off-by: Paolo Bonzini
Applied to master, Thanks.
Regards,
Anthony Liguori
---
qemu-timer.c | 30 +++---
1 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/qemu-tim
On 02/03/2011 03:54 PM, Jan Kiszka wrote:
From: Jan Kiszka
Add the missing EOI broadcast from local APIC to the IOAPICs on
completion of level-triggered IRQs. This ensures that a still asserted
IRQ source properly re-triggers an APIC IRQ.
Signed-off-by: Jan Kiszka
Applied to master, Thank
On 02/04/2011 02:54 AM, Amit Shah wrote:
This can happen if a port gets unplugged before guest has chance to
initialise vqs.
Reported-by: Juan Quintela
Signed-off-by: Amit Shah
Applied to master, Thanks.
Regards,
Anthony Liguori
---
hw/virtio-serial-bus.c |3 +++
1 files changed,
On 02/03/2011 03:35 PM, Stefan Weil wrote:
Starting with SDL version 1.2.14, caps lock and num lock keys
will send a SDL_KEYUP when SDL_DISABLE_LOCK_KEYS=1 is set in
the environment.
The new code sets the environment unconditionally
(it won't harm old versions which do not know it).
The workaro
On 02/04/2011 02:05 AM, Corentin Chary wrote:
agraf reported that qemu_mutex_destroy(vs->output_mutex) while failing
in vnc_disconnect_finish().
It's because vnc_worker_thread_loop() tries to unlock the mutex while
not locked. The unlocking call doesn't fail (pthread bug ?), but
the destroy call
Hi,
I am trying to install kvm on ppc64 system (imac G5). I have built
kernel with kvm module. When I try to install qemu, I am getting this
error
$ ./configure --enable-kvm --target-list="ppc-softmmu"
$ make
[...]
CCslirp/tftp.o
CClibdis/ppc-dis.o
GEN config-target.h
CCpp
Hi all,
I'm Initializing the Local and IO APIC for a propeitary operating
system running in Virtualized Environment .
Im facing some problem with qemu-kvm but the code runs fine with qemu.
when i run my kernel image with qemu-kvm it gives emulation error failure
trying to execute the code outs
These patches apply to master (2-04-2011), and can also be obtained from:
git://repo.or.cz/qemu/mdroth.git qtest_v1
OVERVIEW:
QEMU currently lacks a standard means to do targeted unit testing of the device
model. Frameworks like kvm-autotest interact via guest OS, which provide a
highly abstrac
Signed-off-by: Michael Roth
---
Makefile.objs |4 +++-
Makefile.target |1 +
configure | 20
qemu-options.hx |9 +
vl.c| 11 +++
5 files changed, 44 insertions(+), 1 deletions(-)
diff --git a/Makefile.objs b/Makefile.objs
Signed-off-by: Michael Roth
---
qtest/qtest.c | 65 +
qtest/qtest.h | 37
vl.c | 24 +
3 files changed, 126 insertions(+), 0 deletions(-)
create mode 100644 qtest/qtest.c
This test module initializes a basic system with an ISA bus, a PIC
(currently not used in the test), and an RTC. Currently only drift
testing is performed at various frequencies. This is currently more
of a proof of concept than a rigorous test, and will be improved
over time.
Signed-off-by: Micha
Signed-off-by: Michael Roth
---
module.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/module.h b/module.h
index 9263f1c..d2bf34d 100644
--- a/module.h
+++ b/module.h
@@ -24,12 +24,15 @@ typedef enum {
MODULE_INIT_BLOCK,
MODULE_INIT_DEVICE,
MODULE_IN
On 2011-02-04 14:35, Ravi Kumar Kulkarni wrote:
> Hi all,
> I'm Initializing the Local and IO APIC for a propeitary operating
> system running in Virtualized Environment .
> Im facing some problem with qemu-kvm but the code runs fine with qemu.
Does it also run fine with qemu-kvm and -no-kvm-i
Some CPUs have a status flag imposing to return floatxx_default_nan
whatever the input value, when converting from one FP format to
another. Implement this, using the already existing default_nan_mode
status flag, only for ARM at the moment, though other architectures
may have the same feature. Thi
Signed-off-by: Christophe Lyon
---
target-arm/helpers.h | 12 --
target-arm/neon_helper.c | 89 ++
target-arm/op_helper.c | 49 -
target-arm/translate.c | 18 -
4 files changed, 105 insertions(+), 63
On Wed, Feb 02, 2011 at 09:35:26PM +0100, Jan Kiszka wrote:
> On 2011-02-02 20:05, Blue Swirl wrote:
> > Signed-off-by: Blue Swirl
> > ---
> > target-i386/helper.c |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/target-i386/helper.c b/target-i386/helper.c
> >
On Tue, Feb 01, 2011 at 10:15:40PM +0100, Jan Kiszka wrote:
> Version 2 of part II. Changes:
> - Fixed "Unconditionally reenter kernel after IO exits" to take
>self-INIT into account
> - Fixed misplaced hunk in "Fix race between timer signals and vcpu
>entry under !IOTHREAD" (rebase artif
On 04.02.2011, at 13:30, Anthony Liguori wrote:
> On 02/02/2011 01:28 PM, Stefan Weil wrote:
>> Hello,
>>
>> these are some patches which I found on my stack of open patches.
>>
>> All of them should go into 0.14, and at least some of them could also be
>> applied to 0.13.
>
> This need t
On 4 February 2011 14:01, Christophe Lyon wrote:
> Some CPUs have a status flag imposing to return floatxx_default_nan
> whatever the input value, when converting from one FP format to
> another. Implement this, using the already existing default_nan_mode
> status flag, only for ARM at the moment,
On 4 February 2011 14:17, Christophe Lyon wrote:
>
> Signed-off-by: Christophe Lyon
Reviewed-by: Peter Maydell
-- PMM
Stefan Weil wrote:
> Am 01.02.2011 17:53, schrieb Eduardo Habkost:
>> This reverts part of commit a992fe3d0fc185112677286f7a02204d8245b61e.
>>
>> We do have code that needs #ifdefs depending on the list of enabled devices,
>> but currently that code breaks when we try to disable a feature that is
On 04.02.2011, at 14:25, "Dushyant Bansal" wrote:
> Hi,
> I am trying to install kvm on ppc64 system (imac G5). I have built
> kernel with kvm module. When I try to install qemu, I am getting this
> error
>
> $ ./configure --enable-kvm --target-list="ppc-softmmu"
> $ make
>
> [...]
> CCs
Quoting khetzal (712...@bugs.launchpad.net):
> Thanks for your help. I've subscribed to these mailing list. Have i do
> report the bug in these mailing list too ? (or is it a useless other
> duplication ?)
It will not be duplication. These are development lists, not support
lists, so you won't be
Anthony Liguori writes:
> On 02/02/2011 01:28 PM, Stefan Weil wrote:
[...]
>> [PATCH 1/3] tests: Fix two memory leaks
>> (http://patchwork.ozlabs.org/patch/79945/)
>> [PATCH 2/3] check-qdict: Fix possible crash
>> (http://patchwork.ozlabs.org/patch/79946/)
>
> Luiz
I wouldn't bother with the se
On 02/04/2011 09:27 AM, Markus Armbruster wrote:
Anthony Liguori writes:
On 02/02/2011 01:28 PM, Stefan Weil wrote:
[...]
[PATCH 1/3] tests: Fix two memory leaks
(http://patchwork.ozlabs.org/patch/79945/)
[PATCH 2/3] check-qdict: Fix possible crash
(http://patchwor
On Fri, 4 Feb 2011, Anthony Liguori wrote:
> On 02/02/2011 01:28 PM, Stefan Weil wrote:
> > Hello,
> >
> > these are some patches which I found on my stack of open patches.
> >
> > All of them should go into 0.14, and at least some of them could also be
> > applied to 0.13.
>
> This need the fo
From: Jan Kiszka
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo Tosatti
---
kvm-all.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 2ec9e09..55f6ac3 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -219,6 +219,7 @@ int kvm_init_vcpu(CPUState *e
From: Jan Kiszka
The reset we issue on KVM_EXIT_SHUTDOWN implies that we should also
leave the VCPU loop. As we now check for exit_request which is set by
qemu_system_reset_request, this bug is no longer critical. Still it's an
unneeded extra turn.
Signed-off-by: Jan Kiszka
Signed-off-by: Marce
From: Jan Kiszka
KVM requires to reenter the kernel after IO exits in order to complete
instruction emulation. Failing to do so will leave the kernel state
inconsistently behind. To ensure that we will get back ASAP, we issue a
self-signal that will cause KVM_RUN to return once the pending
operat
From: Jan Kiszka
Introduce qemu_cpu_kick_self to send SIG_IPI to the calling VCPU
context. First user will be kvm.
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo Tosatti
---
cpus.c| 21 +
qemu-common.h |1 +
2 files changed, 22 insertions(+), 0 deletions(-)
From: Glauber Costa
If the machine is stopped, we should not record two different tsc values
upon a save operation. The same problem happens with kvmclock.
But kvmclock is taking a different diretion, being now seen as a separate
device. Since this is unlikely to happen with the tsc, I am taking
The following changes since commit bfddb47a343b4718e5768aa80bce8adead0f7fca:
Open up the 0.15 development branch (2011-02-02 08:39:28 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
Glauber Costa (1):
kvm: make tsc stable over
From: Jan Kiszka
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo Tosatti
---
cpus.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index 5dfc54e..312c7a2 100644
--- a/cpus.c
+++ b/cpus.c
@@ -607,8 +607,8 @@ static void *kvm_cpu_thread_fn(void *arg)
From: Jan Kiszka
We do not use the timeout, so drop its logic. As we always poll our
signals, we do not need to drop the global lock. Removing those calls
allows some further simplifications. Also fix the error processing of
sigpending at this chance.
Signed-off-by: Jan Kiszka
Reviewed-by: Paol
From: Jan Kiszka
If there is any pending request that requires us to leave the inner loop
if main_loop, makes sure we do this as soon as possible by enforcing
non-blocking IO processing.
At this change, move variable definitions out of the inner loop to
improve readability.
Signed-off-by: Jan K
From: Jan Kiszka
First of all, vm_can_run is a misnomer, it actually means "no request
pending". Moreover, there is no need to check all pending requests
twice, the first time via the inner loop check and then again when
actually processing the requests. We can simply remove the inner loop
and do
From: Jan Kiszka
Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between
checking for exit_request on vcpu entry and timer signals arriving
before KVM starts to catch them. Plug it by blocking both timer related
signals also on !CONFIG_IOTHREAD and process those via signalfd.
As this f
From: Jan Kiszka
When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like
it is done for KVM. Use the symbolic constants at this chance.
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo Tosatti
---
target-i386/helper.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(
From: Jan Kiszka
Block SIG_IPI, unblock it during KVM_RUN, just like in io-thread mode.
It's unused so far, but this infrastructure will be required for
self-IPIs and to process SIGBUS plus, in KVM mode, SIGIO and SIGALRM. As
Windows doesn't support signal services, we need to provide a stub for
From: Jan Kiszka
If some I/O operation ends up calling qemu_system_reset_request in VCPU
context, we record this and inform the io-thread, but we do not
terminate the VCPU loop. This can lead to fairly unexpected behavior if
the triggering reset operation is supposed to work synchronously.
Fix t
From: Jan Kiszka
If we call qemu_cpu_kick more than once before the target was able to
process the signal, pthread_kill will fail, and qemu will abort. Prevent
this by avoiding the redundant signal.
This logic can be found in qemu-kvm as well.
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo T
From: Jan Kiszka
Improve the readability of the exit dispatcher by moving the static
return value of kvm_handle_io to its caller.
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo Tosatti
---
kvm-all.c | 17 -
1 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/kvm
From: Jan Kiszka
Except for timer events, we currently do not leave the loop over all
VCPUs if an IO event was filed. That may cause unexpected IO latencies
under !CONFIG_IOTHREAD in SMP scenarios. Fix it by setting the global
exit_request which breaks the loop.
Signed-off-by: Jan Kiszka
Signed
From: Jan Kiszka
Provide arch-independent kvm_on_sigbus* stubs to remove the #ifdef'ery
from cpus.c. This patch also fixes --disable-kvm build by providing the
missing kvm_on_sigbus_vcpu kvm-stub.
Signed-off-by: Jan Kiszka
Reviewed-by: Paolo Bonzini
Acked-by: Alexander Graf
Signed-off-by: Mar
From: Jan Kiszka
Currently, we only configure and process MCE-related SIGBUS events if
CONFIG_IOTHREAD is enabled. The groundwork is laid, we just need to
factor out the required handler registration and system configuration.
Signed-off-by: Jan Kiszka
CC: Huang Ying
CC: Hidetoshi Seto
CC: Jin
From: Jan Kiszka
Will be required for SIGBUS handling. For obvious reasons, this will
remain a nop on Windows hosts.
Signed-off-by: Jan Kiszka
Reviewed-by: Paolo Bonzini
Signed-off-by: Marcelo Tosatti
---
Makefile.objs |2 +-
cpus.c| 117 +++--
From: Jan Kiszka
Move qemu_kvm_eat_signals around and call it also when the IO-thread is
not used. Do not yet process SIGBUS, will be armed in a separate step.
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo Tosatti
---
cpus.c | 90 +-
From: Jan Kiszka
Move {tcg,kvm}_init_ipi and block_io_signals to avoid prototypes, rename
the former two to clarify that they deal with more than SIG_IPI. No
functional changes - except for the tiny fixup of strerror usage.
The forward declaration of sigbus_handler is just temporarily, it will
b
From: Jan Kiszka
Do not ignore errors of kvm_init_vcpu, they are fatal.
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo Tosatti
---
cpus.c | 19 +++
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/cpus.c b/cpus.c
index 312c7a2..8475757 100644
--- a/cpus.c
++
From: Jan Kiszka
A pending vmstop request is also a reason to leave the inner main loop.
So far we ignored it, and pending stop requests issued over VCPU threads
were simply ignored.
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo Tosatti
---
vl.c | 14 +-
1 files changed, 5 in
On 02/04/2011 12:13 AM, Stefan Hajnoczi wrote:
On Thu, Feb 3, 2011 at 5:41 PM, Michael Roth wrote:
For things like logging and i/o on a frozen system...I agree we'd need some
flag for these kinds of situations. Maybe a disable_logging() flagi
really don't like this though... I'd imagine eve
On 2011-02-04 14:54, Marcelo Tosatti wrote:
> On Tue, Feb 01, 2011 at 10:15:40PM +0100, Jan Kiszka wrote:
>> Version 2 of part II. Changes:
>> - Fixed "Unconditionally reenter kernel after IO exits" to take
>>self-INIT into account
>> - Fixed misplaced hunk in "Fix race between timer signals
On Fri, 04 Feb 2011 16:27:46 +0100
Markus Armbruster wrote:
> Anthony Liguori writes:
>
> > On 02/02/2011 01:28 PM, Stefan Weil wrote:
> [...]
> >> [PATCH 1/3] tests: Fix two memory leaks
> >> (http://patchwork.ozlabs.org/patch/79945/)
>
> >> [PATCH 2/3] check-qdict: Fix possible crash
> >> (h
On Fri, Feb 04, 2011 at 05:29:00PM +0100, Jan Kiszka wrote:
> On 2011-02-04 14:54, Marcelo Tosatti wrote:
> > On Tue, Feb 01, 2011 at 10:15:40PM +0100, Jan Kiszka wrote:
> >> Version 2 of part II. Changes:
> >> - Fixed "Unconditionally reenter kernel after IO exits" to take
> >>self-INIT into
On 02/04/2011 05:03 AM, Jes Sorensen wrote:
On 02/03/11 18:41, Michael Roth wrote:
On 02/02/2011 02:48 AM, Jes Sorensen wrote:
Yes very much so[1] - one reason why it would be nice to have virtagent
use threads to execute the actual commands. We should probably add a
flag to agent commands indi
On Fri, Feb 4, 2011 at 4:27 PM, Michael Roth wrote:
>> Aborting an RPC handler could leave the system in an inconsistent
>> state unless we are careful. For example, aborting freeze requires
>> thawing those file systems that have been successfully frozen so far.
>> For other handlers it might le
Hi,
What about these patches?
--
With best wishes
Dmitry
Am 04.02.2011 16:27, schrieb Markus Armbruster:
Anthony Liguori writes:
On 02/02/2011 01:28 PM, Stefan Weil wrote:
[...]
[PATCH 1/3] tests: Fix two memory leaks
(http://patchwork.ozlabs.org/patch/79945/)
[PATCH 2/3] check-qdict: Fix possible crash
(http://patchwork.ozlabs.org/patch/79946/
1 - 100 of 131 matches
Mail list logo
