Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-03 Thread Avi Kivity
On 02/02/2011 05:52 PM, Jan Kiszka wrote: >> > If there is no problem in the logic of this commit (and I do not see > one yet) then we somewhere miss kicking vcpu when interrupt, that should be > handled, arrives? I'm not yet confident about the logic of the kernel patch: mov to cr8 is serial

[Qemu-devel] [PING 0.14] Missing vnc patch

2011-02-03 Thread Corentin Chary
vnc: qemu can die if the client is disconnected while updating screen http://patchwork.ozlabs.org/patch/80334/ (what about a "stable" alias instead of [PING x.x] ? Like sta...@kernel.org) Thanks, -- Corentin Chary http://xf.iksaif.net

[Qemu-devel] Support for BMIPS4380 CPU?

2011-02-03 Thread xeros
Hi, I'd like to ask about support for newer CPUs in QEMU, like this one: system type : BCM3556C0 DTV platform processor : 0 cpu model : Broadcom BMIPS4380 V4.4 FPU V0.1 BogoMIPS: 403.45 wait instruction: yes microsecond timers :

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-03 Thread Alexander Graf
On 02.02.2011, at 23:08, Scott Wood wrote: > On Wed, 2 Feb 2011 22:33:41 +0100 > Alexander Graf wrote: > >> >> On 02.02.2011, at 21:33, Yoder Stuart-B08248 wrote: >> >>> Below is a proposal for a new API for PPC to allow KVM clients >>> to set MMU state in a vcpu. >>> >>> BookE processors ha

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-03 Thread Alexander Graf
On 02.02.2011, at 23:34, Yoder Stuart-B08248 wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Wednesday, February 02, 2011 3:34 PM >> To: Yoder Stuart-B08248 >> Cc: kvm-...@vger.kernel.org; k...@vger.kernel.org; qemu-devel@nongnu.org >> Subject: R

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-03 Thread Jan Kiszka
On 2011-02-03 08:42, Gleb Natapov wrote: > On Wed, Feb 02, 2011 at 05:51:32PM +0100, Jan Kiszka wrote: Just did so, and I can no longer reproduce the problem. Hmm... >>> If there is no problem in the logic of this commit (and I do not see >>> one yet) then we somewhere mis

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-03 Thread Jan Kiszka
On 2011-02-03 09:18, Avi Kivity wrote: > On 02/02/2011 05:52 PM, Jan Kiszka wrote: >>> If there is no problem in the logic of this commit (and I do not see >>> one yet) then we somewhere miss kicking vcpu when interrupt, that should be >>> handled, arrives? >> >> I'm not yet confident about

[Qemu-devel] [Bug 712337] [NEW] connecthon basic test5 failed with qemu 0.14 on Virtfs path in guest

2011-02-03 Thread Madhuri
Public bug reported: connecthon basic test named test5 is failing with bigfile write failed bad address on .L passthru and .L mapped Virtfs path in guest. with fedora12 Bug is with latest qemu-0.14.0-rc0 connecthon tarball /root/project_CI/client/tests/connecthon/cthon04.tgz 02/03 08:55:09 INFO

[Qemu-devel] RFC: usb redirection protocol v0.2

2011-02-03 Thread Hans de Goede
Hi All, Attached is version 0.2 of the protocol for the usb redirection stuff I've been working on. This contains a number of changes based on Gerd Hoffmann's recommendations and some things which I noticed while actually implementing things. Note that this version still is missing a packet type

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-03 Thread Avi Kivity
On 02/03/2011 11:32 AM, Jan Kiszka wrote: On 2011-02-03 09:18, Avi Kivity wrote: > On 02/02/2011 05:52 PM, Jan Kiszka wrote: >>> If there is no problem in the logic of this commit (and I do not see >>> one yet) then we somewhere miss kicking vcpu when interrupt, that should be >>> ha

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-03 Thread Marcelo Tosatti
On Thu, Feb 03, 2011 at 10:32:25AM +0100, Jan Kiszka wrote: > On 2011-02-03 09:18, Avi Kivity wrote: > > On 02/02/2011 05:52 PM, Jan Kiszka wrote: > > >>> If there is no problem in the logic of this commit (and I do not see > >>> one yet) then we somewhere miss kicking vcpu when interrupt, t

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-03 Thread Markus Armbruster
Also: From: Gleb Natapov Subject: [Qemu-devel] [PATCH] do not pass NULL to strdup. Date: Wed, 2 Feb 2011 17:34:34 +0200 Message-ID: <20110202153434.gp14...@redhat.com>

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-03 Thread Jan Kiszka
On 2011-02-03 11:04, Marcelo Tosatti wrote: > On Thu, Feb 03, 2011 at 10:32:25AM +0100, Jan Kiszka wrote: >> On 2011-02-03 09:18, Avi Kivity wrote: >>> On 02/02/2011 05:52 PM, Jan Kiszka wrote: >> > If there is no problem in the logic of this commit (and I do not see > one yet) then w

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-03 Thread Jan Kiszka
On 2011-02-03 11:01, Avi Kivity wrote: > On 02/03/2011 11:32 AM, Jan Kiszka wrote: >> On 2011-02-03 09:18, Avi Kivity wrote: >>> On 02/02/2011 05:52 PM, Jan Kiszka wrote: >> > If there is no problem in the logic of this commit (and I do not see > one yet) then we somewhere miss kic

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-03 Thread Marcelo Tosatti
On Tue, Feb 01, 2011 at 06:34:50PM +0100, Jan Kiszka wrote: > On 2011-02-01 18:20, Anthony Liguori wrote: > > On 02/01/2011 11:03 AM, Jan Kiszka wrote: > >> On 2011-02-01 17:53, Anthony Liguori wrote: > >> > >>> On 02/01/2011 10:36 AM, Jan Kiszka wrote: > >>> > On 2011-02-01 16:54, C

RE: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-03 Thread Laurent Vivier
>On Wed, Feb 02, 2011 at 08:28:15PM +0100, Stefan Weil wrote: >> [PATCH] linux-user: Fix possible realloc memory leak >> (http://patchwork.ozlabs.org/patch/79217/) > >Looks ok for me. And this one ? linux-user: correct core dump format http://patchwork.ozlabs.org/patch/78464/ Laurent -- ---

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-03 Thread Marcelo Tosatti
On Tue, Feb 01, 2011 at 12:53:36PM -0500, Christoph Hellwig wrote: > On Tue, Feb 01, 2011 at 05:36:13PM +0100, Jan Kiszka wrote: > > kvm_cpu_exec/kvm_run, and start wondering "What needs to be done to > > upstream so that qemu-kvm could use that implementation?". If they > > differ, the reasons nee

Re: [Qemu-devel] [PATCH 01/20] qdev: add print_options callback

2011-02-03 Thread Alon Levy
Please ignore, duplicate of 01/20 already on the list. It took so long for 01/20 to appear on the list that I thought it was lost. Alon On Wed, Feb 02, 2011 at 11:46:07PM +0200, Alon Levy wrote: > another callback added to PropertyInfo, for later use by PROP_TYPE_ENUM. > Allows printing of runtim

[Qemu-devel] Re: [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-03 Thread Jan Kiszka
On 2011-02-02 15:39, Alexander Graf wrote: > When using level based interrupts, the interrupt is treated the same as an > edge triggered one: leaving the line up does not retrigger the interrupt. > > In fact, when not lowering the line, we won't ever get a new interrupt inside > the guest. So let'

[Qemu-devel] Re: [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-03 Thread Alexander Graf
On 03.02.2011, at 11:30, Jan Kiszka wrote: > On 2011-02-02 15:39, Alexander Graf wrote: >> When using level based interrupts, the interrupt is treated the same as an >> edge triggered one: leaving the line up does not retrigger the interrupt. >> >> In fact, when not lowering the line, we won't e

[Qemu-devel] Re: [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-03 Thread Jan Kiszka
On 2011-02-03 11:38, Alexander Graf wrote: > > On 03.02.2011, at 11:30, Jan Kiszka wrote: > >> On 2011-02-02 15:39, Alexander Graf wrote: >>> When using level based interrupts, the interrupt is treated the same as an >>> edge triggered one: leaving the line up does not retrigger the interrupt. >>

[Qemu-devel] [Bug 712416] [NEW] kvm_intel kernel module crash with via nano vmx

2011-02-03 Thread khetzal
Public bug reported: kvm module for hardware virtualisation not work properly on via nano processors. Tested with processor: VIA Nano processor U2250. Processors flags (visible in /proc/cpuinfo): fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat clflush acpi mmx fxsr sse sse2 ss

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-03 Thread Paolo Bonzini
On 02/01/2011 06:53 PM, Christoph Hellwig wrote: I'd really prefer to let you finish up all the major work that way before starting massive revamping like the glib main loop. Yes, the glib main loop is not going to go anywhere if it cannot be applied to both qemu and qemu-kvm. (And, I believ

Re: [Qemu-devel] [ANNOUNCE] QEMU 0.14.0-rc0.tar.gz is available

2011-02-03 Thread Miguel Di Ciurcio Filho
On Wed, Feb 2, 2011 at 11:27 PM, Anthony Liguori wrote: > > An in progress detailed change log is available at > http://wiki.qemu.org/Changelog/0.14 > I still need some help to list the changes, bug fixes and improvements for i386/x86_64. - What is the status of nested SVM/VMX? - Are we using an

[Qemu-devel] Re: [PATCH 0.14] savevm: fix corruption in vmstate_subsection_load().

2011-02-03 Thread Juan Quintela
Yoshiaki Tamura wrote: > Although it's rare to happen in live migration, when the head of a > byte stream contains 0x05 which is the marker of subsection, the > loader gets corrupted because vmstate_subsection_load() continues even > the device doesn't require it. This patch adds a checker whethe

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2011-02-03 Thread Matthieu CERDA
I confirm that. Same dmesg log all over the place trying to use KVM with a VIA Nano U2250. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/712416 Title: kvm_intel kernel module crash with via nano vm

Re: [Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-03 Thread Anthony Liguori
On 02/03/2011 04:11 AM, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 06:34:50PM +0100, Jan Kiszka wrote: On 2011-02-01 18:20, Anthony Liguori wrote: On 02/01/2011 11:03 AM, Jan Kiszka wrote: On 2011-02-01 17:53, Anthony Liguori wrote: On 02/01/2011 10:36 AM, Jan

[Qemu-devel] [PATCH v2 2/3] Correct alarm deadline computation

2011-02-03 Thread Paolo Bonzini
When the QEMU_CLOCK_HOST clock was added, computation of its deadline was added to qemu_next_deadline, which is correct but incomplete. I noticed this by reading the very convoluted rules whereby qemu_next_deadline_dyntick is computed, which miss QEMU_CLOCK_HOST when use_icount is true. This patc

[Qemu-devel] [PATCH v2 0/3] Simplify and fix alarm deadline computation

2011-02-03 Thread Paolo Bonzini
This is a rebased and updated version of the series to fix alarm deadline computation. I adopted Aurelien's suggestion to change everything to nanoseconds. I also did more testing than just compiling, by booting with -icount. And it wasn't enough. Patch 1 was broken due to a mistake in converti

[Qemu-devel] [PATCH v2 3/3] Unify alarm deadline computation

2011-02-03 Thread Paolo Bonzini
This patch shows how using the correct formula for qemu_next_deadline_dyntick can simplify the code of host_alarm_handler and eliminate useless duplication. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 28 +++- 2 files changed, 11 insertions(+), 17 deletions(-) diff

[Qemu-devel] [PATCH v2 1/3] use nanoseconds everywhere for timeout computation

2011-02-03 Thread Paolo Bonzini
Suggested by Aurelien Jarno. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index db1ec49..60283a8 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -197,8 +197,8 @@ s

[Qemu-devel] Help initializing a hw module

2011-02-03 Thread Juan Antonio Moya Vicén
Hi list, I'm new to qemu, and developing a new hw module. And I'll appreciate any help or link any of you can provide relating to the following problem I'm experiencing, that I'm certain it is because of inexperience: I'm getting ENODEV error codes each time I load the kernel module for my specif

[Qemu-devel] x86: No 64-bit Windows bootable in emulations mode

2011-02-03 Thread Jan Kiszka
Just a heads up in case someone want's to run Windows 7 x64 on an Android phone or some other crazy host without x86 KVM support: Our current emulation is not able to boot any 64-bit Windows version I found. Already the installations DVDs bail out with STOP 0x005D, which means something like "

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-03 Thread Gleb Natapov
On Thu, Feb 03, 2011 at 11:11:23AM +0100, Jan Kiszka wrote: > On 2011-02-03 11:04, Marcelo Tosatti wrote: > > On Thu, Feb 03, 2011 at 10:32:25AM +0100, Jan Kiszka wrote: > >> On 2011-02-03 09:18, Avi Kivity wrote: > >>> On 02/02/2011 05:52 PM, Jan Kiszka wrote: > >> > > If there is no prob

Re: [Qemu-devel] Help initializing a hw module

2011-02-03 Thread Juan Antonio Moya Vicén
I'm sorry I made a typo. The code in the kernel module that makes the call REALLY IS: iobase = ioremap(0xFED4, 0x5000); if(ioread8(iobase) == 0) return -ENODEV; On 03/02/11 14:58, Juan Antonio Moya Vicén wrote: > Hi list, > I'm new to qemu, and developing a new

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-03 Thread Jan Kiszka
On 2011-02-03 15:15, Gleb Natapov wrote: > On Thu, Feb 03, 2011 at 11:11:23AM +0100, Jan Kiszka wrote: >> On 2011-02-03 11:04, Marcelo Tosatti wrote: >>> On Thu, Feb 03, 2011 at 10:32:25AM +0100, Jan Kiszka wrote: On 2011-02-03 09:18, Avi Kivity wrote: > On 02/02/2011 05:52 PM, Jan Kiszka

[Qemu-devel] checkpatch.pl complains about untouched tab'ed lines

2011-02-03 Thread Jan Kiszka
Hi, just a note, I can't look into this ATM: I get complaints from checkpatch when my patch includes lines with tabs only in the hunk's untouched context. Maybe someone feels like fixing this. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-03 Thread Anthony Liguori
On 02/03/2011 06:36 AM, Paolo Bonzini wrote: On 02/01/2011 06:53 PM, Christoph Hellwig wrote: I'd really prefer to let you finish up all the major work that way before starting massive revamping like the glib main loop. Yes, the glib main loop is not going to go anywhere if it cannot be appli

[Qemu-devel] [0.14?][PATCH 1/4] ioapic: Implement EOI handling for level-triggered IRQs

2011-02-03 Thread Jan Kiszka
Add the missing EOI broadcast from local APIC to the IOAPICs on completion of level-triggered IRQs. This ensures that a still asserted IRQ source properly re-triggers an APIC IRQ. Signed-off-by: Jan Kiszka --- hw/apic.c |9 ++--- hw/ioapic.c | 43 +

[Qemu-devel] [0.14?][PATCH 0/4] IOAPIC fixes

2011-02-03 Thread Jan Kiszka
This series fixes the re-injection of level-triggered IRQs that are still raised on APIC EOI, adds a must-have field to the vmstate of the IOAPIC, and also aligns that vmstate with qemu-kvm. I would recommend the whole series for 0.14, but at least patch 1 should be applied. Jan Kiszka (4): i

[Qemu-devel] [0.14?][PATCH 4/4] ioapic: Style & magics cleanup

2011-02-03 Thread Jan Kiszka
Fix a few style issues and convert magic numbers into prober symbolic constants, also fixing the wrong but unused IOAPIC_DM_SIPI value. Signed-off-by: Jan Kiszka --- hw/ioapic.c | 177 +++--- 1 files changed, 107 insertions(+), 70 deletions(-)

[Qemu-devel] [0.14?][PATCH 2/4] ioapic: Save/restore irr

2011-02-03 Thread Jan Kiszka
This is a guest modifiable state that must be saved/restored properly. Signed-off-by: Jan Kiszka --- hw/ioapic.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/hw/ioapic.c b/hw/ioapic.c index 443c579..c7019f5 100644 --- a/hw/ioapic.c +++ b/hw/ioapic.c @@ -2

[Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Jan Kiszka
The registers of real IOAPICs can be relocated during runtime (via chipset registers). We don't support this yet, but qemu-kvm carries the current base address in its version 2 vmstate. To align both implementations for migratability, add the proper infrastructure to accept initial as well as upda

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2011-02-03 Thread Serge Hallyn
Thanks for reporting this bug and helping to make Ubuntu better. A bit of searching suggests that VIA Nano was until recently very little tested and supported. The kernels you are working with are rather old compared to upstream. So in order to see whether you should be talking to us or kvm ups

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2011-02-03 Thread Serge Hallyn
Note that this appears to be a dup of http://bugs.debian.org/cgi- bin/bugreport.cgi?bug=570244. See also thread at http://www.spinics.net/lists/kvm/msg41122.html. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

[Qemu-devel] [PATCH] QCOW2: bug fix - read base image beyond its size

2011-02-03 Thread Chunqiang Tang
This patch fixes the following bug in QCOW2. For a QCOW2 image that is larger than its base image, when handling a read request straddling over the end of the base image, the QCOW2 driver attempts to read beyond the end of the base image and the request would fail. This bug was found by Fast Virtu

[Qemu-devel] [Bug 670776] Re: Build errors on TEGRA2(ubuntu), testandset()

2011-02-03 Thread Peter Maydell
This patch which I proposed would fix this bug: http://patchwork.ozlabs.org/patch/81205/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/670776 Title: Build errors on TEGRA2(ubuntu), testandset() St

[Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

2011-02-03 Thread Jan Kiszka
On 2011-02-03 14:43, Ulrich Obergfell wrote: > > Hi, > > I am observing severe backward time drift in a MS Windows Vista(tm) > guest running on a Fedora 14 KVM host. I can reproduce the problem > with the following steps: > > 1. Use 'vncviewer' to connect to the guest's desktop. > 2. Click on th

[Qemu-devel] [PATCH] e1000: multi-buffer packet support

2011-02-03 Thread Michael S. Tsirkin
e1000 supports multi-buffer packets larger than rxbuf_size. This fixes the following (on linux): - in guest: ifconfig eth1 mtu 16110 - in host: ifconfig tap0 mtu 16110 ping -s 16082 Red Hat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=602205 Signed-off-by: Michael S. Tsirkin

[Qemu-devel] Re: [PATCH v2] make tsc stable over migration and machine start

2011-02-03 Thread Marcelo Tosatti
On Wed, Feb 02, 2011 at 07:16:20AM -0500, Glauber Costa wrote: > If the machine is stopped, we should not record two different tsc values > upon a save operation. The same problem happens with kvmclock. > > But kvmclock is taking a different diretion, being now seen as a separate > device. Since t

[Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc ""'

2011-02-03 Thread Daniel P. Berrange
On Mon, Jan 31, 2011 at 02:43:19PM -0600, Anthony Liguori wrote: > commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the > change vnc password command that changed the behavior of setting the VNC > password to an empty string from disabling login to disabling authentication

Re: [Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc ""'

2011-02-03 Thread Anthony Liguori
On 02/03/2011 10:29 AM, Daniel P. Berrange wrote: On Mon, Jan 31, 2011 at 02:43:19PM -0600, Anthony Liguori wrote: commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the change vnc password command that changed the behavior of setting the VNC password to an empty stri

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2011-02-03 Thread khetzal
yes this appears to be a duplication but the original bugreport has been posted one year ago and there is no evolution. Moreover, it's not posted on the officiel qemu / kvm bugtracker ;). I'm waiting that my current installation complete and i test the new kernel / kvm, but i've tested one week ag

[Qemu-devel] [PATCH] tap: minor code cleanup

2011-02-03 Thread Michael S. Tsirkin
remove a confusing comment. TAP_DEFAULT_SNDBUF 0 is later translated to INT_MAX, so let's set that value directly. Signed-off-by: Michael S. Tsirkin --- net/tap-linux.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/net/tap-linux.c b/net/tap-linux.c index 00f84d4.

[Qemu-devel] Re: [PATCH] e1000: multi-buffer packet support

2011-02-03 Thread Alex Williamson
On Thu, 2011-02-03 at 17:38 +0200, Michael S. Tsirkin wrote: > e1000 supports multi-buffer packets larger than rxbuf_size. > > This fixes the following (on linux): > - in guest: ifconfig eth1 mtu 16110 > - in host: ifconfig tap0 mtu 16110 >ping -s 16082 > > Red Hat bugzilla: https://

[Qemu-devel] Re: [PATCH] e1000: multi-buffer packet support

2011-02-03 Thread Stefan Hajnoczi
On Thu, Feb 03, 2011 at 05:38:35PM +0200, Michael S. Tsirkin wrote: > @@ -654,7 +656,7 @@ e1000_receive(VLANClientState *nc, const uint8_t *buf, > size_t size) > size = sizeof(min_buf); > } > > -if (size > s->rxbuf_size) { > +if (0 && size > s->rxbuf_size) { > DBGOU

Re: [Qemu-devel] [PATCH 01/20] qdev: add print_options callback

2011-02-03 Thread Anthony Liguori
On 02/02/2011 02:28 PM, Alon Levy wrote: another callback added to PropertyInfo, for later use by PROP_TYPE_ENUM. Allows printing of runtime computed options when doing: qemu -device foo,? --- hw/qdev.c | 10 +- hw/qdev.h |1 + 2 files changed, 10 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH 03/20] qdev-properties: add PROP_TYPE_ENUM

2011-02-03 Thread Anthony Liguori
On 02/02/2011 02:28 PM, Alon Levy wrote: Example usage: EnumTable foo_enum_table[] = { {"bar", 1}, {"buz", 2}, {NULL, 0}, }; DEFINE_PROP_ENUM("foo", State, foo, 1, foo_enum_table) When using qemu -device foodev,? it will appear as: foodev.foo=bar/buz --- hw/qdev-properties.c

[Qemu-devel] Re: [PATCH] e1000: multi-buffer packet support

2011-02-03 Thread Michael S. Tsirkin
On Thu, Feb 03, 2011 at 09:36:57AM -0700, Alex Williamson wrote: > On Thu, 2011-02-03 at 17:38 +0200, Michael S. Tsirkin wrote: > > e1000 supports multi-buffer packets larger than rxbuf_size. > > > > This fixes the following (on linux): > > - in guest: ifconfig eth1 mtu 16110 > > - in host: ifconf

Re: [Qemu-devel] [PATCH 05/20] usb-ccid: add CCID bus

2011-02-03 Thread Anthony Liguori
On 02/02/2011 02:28 PM, Alon Levy wrote: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/de

Re: [Qemu-devel] [PATCH 06/20] usb-ccid: review fixes (v15-v16)

2011-02-03 Thread Anthony Liguori
On 02/02/2011 02:28 PM, Alon Levy wrote: I'll fold it before submitting the version to be applied, but I hope keeping it as a separate patch will make reviewing easier. Hrm, can you just send out the new patches? It's actually harder to review like this. Regards, Anthony Liguori Beh

[Qemu-devel] [PATCH] QCOW2: fix bug - report read success on failure

2011-02-03 Thread Chunqiang Tang
This patch fixes bugs in QCOW2's error handling paths of read operations. When an I/O operation fails, the QCOW2 driver mistakenly reports it as success to the uper layer. This bug was found by Fast Virtual Disk (FVD)'s fully automated testing tool, when it injected failures. Specifically, the fol

[Qemu-devel] [PATCHv2] e1000: multi-buffer packet support

2011-02-03 Thread Michael S. Tsirkin
e1000 supports multi-buffer packets larger than rxbuf_size. This fixes the following (on linux): - in guest: ifconfig eth1 mtu 16110 - in host: ifconfig tap0 mtu 16110 ping -s 16082 Red Hat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=602205 Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc ""'

2011-02-03 Thread Daniel P. Berrange
On Thu, Feb 03, 2011 at 10:35:51AM -0600, Anthony Liguori wrote: > On 02/03/2011 10:29 AM, Daniel P. Berrange wrote: > >On Mon, Jan 31, 2011 at 02:43:19PM -0600, Anthony Liguori wrote: > >>commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in > >>the > >>change vnc password co

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 2:55 PM, Jan Kiszka wrote: > The registers of real IOAPICs can be relocated during runtime (via > chipset registers). We don't support this yet, but qemu-kvm carries the > current base address in its version 2 vmstate. > > To align both implementations for migratability, add

[Qemu-devel] Re: [PATCH] QCOW2: fix bug - report read success on failure

2011-02-03 Thread Chunqiang Tang
> Oops, thanks for catching this. I thought this was fixed long ago, but > apparently it wasn't. Not me, the testing tool caught it without my supervision. :-) > > @@ -495,8 +497,10 @@ static void qcow2_aio_read_cb(void *opaque, int ret) > > } > > } else if (acb->cluster_offset & Q

[Qemu-devel] Re: [PATCH] QCOW2: fix bug - report read success on failure

2011-02-03 Thread Kevin Wolf
Am 03.02.2011 17:53, schrieb Chunqiang Tang: > This patch fixes bugs in QCOW2's error handling paths of read operations. > When an I/O operation fails, the QCOW2 driver mistakenly reports it as success > to the uper layer. > > This bug was found by Fast Virtual Disk (FVD)'s fully automated testing

[Qemu-devel] Re: QCOW2 bugs releated to qcow2_aio_cancel()

2011-02-03 Thread Kevin Wolf
Am 03.02.2011 18:21, schrieb Chunqiang Tang: > Hi Kevin, > > Fast Virtual Disk (FVD) has an automated testing tool (see > http://wiki.qemu.org/Features/FVD/Engineering). For a long time, I knew > that QCOW2 could not pass the automated tests. Today I finally sit down to > look into those bugs.

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Jan Kiszka
On 2011-02-03 18:36, Blue Swirl wrote: > On Thu, Feb 3, 2011 at 5:18 PM, Jan Kiszka wrote: >> On 2011-02-03 18:03, Blue Swirl wrote: >>> On Thu, Feb 3, 2011 at 2:55 PM, Jan Kiszka wrote: The registers of real IOAPICs can be relocated during runtime (via chipset registers). We don't supp

[Qemu-devel] [PATCH] checkpatch.pl: don't complain about old lines with tabs

2011-02-03 Thread Blue Swirl
Don't complain when the patch includes lines with tabs only in the hunk's untouched context. Signed-off-by: Blue Swirl --- scripts/checkpatch.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4fa06c0..075b614 100755 -

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Jan Kiszka
On 2011-02-03 18:03, Blue Swirl wrote: > On Thu, Feb 3, 2011 at 2:55 PM, Jan Kiszka wrote: >> The registers of real IOAPICs can be relocated during runtime (via >> chipset registers). We don't support this yet, but qemu-kvm carries the >> current base address in its version 2 vmstate. >> >> To ali

[Qemu-devel] Re: [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-03 Thread Michael Roth
On 02/02/2011 02:42 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed. - fsfreeze(): Walk the list of mounted local real file systems,

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Jan Kiszka
On 2011-02-03 18:54, Blue Swirl wrote: > On Thu, Feb 3, 2011 at 5:43 PM, Jan Kiszka wrote: >> On 2011-02-03 18:36, Blue Swirl wrote: >>> On Thu, Feb 3, 2011 at 5:18 PM, Jan Kiszka wrote: On 2011-02-03 18:03, Blue Swirl wrote: > On Thu, Feb 3, 2011 at 2:55 PM, Jan Kiszka wrote: >> Th

[Qemu-devel] Re: [PATCH v2 0/2] virtagent - fsfreeze support

2011-02-03 Thread Michael Roth
Hi Jes, Can you add Badari (CC'd) to the next round? He's looked at potentially using virtagent for snapshots in the past and might have some insights here. Thanks. On 02/02/2011 02:42 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen Hi This is a first attempt to add fsfreeze support

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-03 Thread Michael Roth
On 02/02/2011 02:48 AM, Jes Sorensen wrote: On 02/02/11 08:57, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 10:58 AM, wrote: From: Jes Sorensen Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed

[Qemu-devel] problem with -vga std

2011-02-03 Thread Serge E. Hallyn
Hi, When I grabbed the latest qemu (up to commit bfddb47a343b4718e5768aa80bce8adead0f7fca) from git://git.qemu.org/qemu.git and did: ./qemu-system-x86_64 -net user -net nic -vga std -usb -usbdevice tablet -m 512 -hda /home/serge/disk.img -boot c -monitor stdio -vnc :1 -L /opt/qemu/share/qemu/

[Qemu-devel] QCOW2 bugs releated to qcow2_aio_cancel()

2011-02-03 Thread Chunqiang Tang
Hi Kevin, Fast Virtual Disk (FVD) has an automated testing tool (see http://wiki.qemu.org/Features/FVD/Engineering). For a long time, I knew that QCOW2 could not pass the automated tests. Today I finally sit down to look into those bugs. I already submitted multiple patches for different bugs,

[Qemu-devel] [0.14?][PATCH v2 0/4] IOAPIC fixes

2011-02-03 Thread Jan Kiszka
Second round, addressing review comments and fixing (still unused) code: - pass IOAPIC default address as property - properly update MMIO mapping after vmload - switch post_load callback for all fix-ups Jan Kiszka (4): ioapic: Implement EOI handling for level-triggered IRQs ioapic: Save/r

[Qemu-devel] [0.14?][PATCH v2 4/4] ioapic: Style & magics cleanup

2011-02-03 Thread Jan Kiszka
Fix a few style issues and convert magic numbers into prober symbolic constants, also fixing the wrong but unused IOAPIC_DM_SIPI value. Signed-off-by: Jan Kiszka --- hw/ioapic.c | 177 +++--- 1 files changed, 107 insertions(+), 70 deletions(-)

[Qemu-devel] [0.14?][PATCH v2 1/4] ioapic: Implement EOI handling for level-triggered IRQs

2011-02-03 Thread Jan Kiszka
Add the missing EOI broadcast from local APIC to the IOAPICs on completion of level-triggered IRQs. This ensures that a still asserted IRQ source properly re-triggers an APIC IRQ. Signed-off-by: Jan Kiszka --- hw/apic.c |9 ++--- hw/ioapic.c | 43 +

Re: [Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc ""'

2011-02-03 Thread Anthony Liguori
On 02/03/2011 11:02 AM, Daniel P. Berrange wrote: On Thu, Feb 03, 2011 at 10:35:51AM -0600, Anthony Liguori wrote: On 02/03/2011 10:29 AM, Daniel P. Berrange wrote: On Mon, Jan 31, 2011 at 02:43:19PM -0600, Anthony Liguori wrote: commit 52c18be9e99dabe295321153fda7fce9f76647a

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 5:18 PM, Jan Kiszka wrote: > On 2011-02-03 18:03, Blue Swirl wrote: >> On Thu, Feb 3, 2011 at 2:55 PM, Jan Kiszka wrote: >>> The registers of real IOAPICs can be relocated during runtime (via >>> chipset registers). We don't support this yet, but qemu-kvm carries the >>> cu

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 5:43 PM, Jan Kiszka wrote: > On 2011-02-03 18:36, Blue Swirl wrote: >> On Thu, Feb 3, 2011 at 5:18 PM, Jan Kiszka wrote: >>> On 2011-02-03 18:03, Blue Swirl wrote: On Thu, Feb 3, 2011 at 2:55 PM, Jan Kiszka wrote: > The registers of real IOAPICs can be relocated d

[Qemu-devel] [0.14?][PATCH v2 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Jan Kiszka
The registers of real IOAPICs can be relocated during runtime (via chipset registers). We don't support this yet, but qemu-kvm carries the current base address in its version 2 vmstate. To align both implementations for migratability, add the proper infrastructure to accept initial as well as upda

[Qemu-devel] [0.14?][PATCH v2 2/4] ioapic: Save/restore irr

2011-02-03 Thread Jan Kiszka
This is a guest modifiable state that must be saved/restored properly. Signed-off-by: Jan Kiszka --- hw/ioapic.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/hw/ioapic.c b/hw/ioapic.c index 443c579..edf99cc 100644 --- a/hw/ioapic.c +++ b/hw/ioapic.c @@

[Qemu-devel] Re: [PATCHv2] e1000: multi-buffer packet support

2011-02-03 Thread Alex Williamson
On Thu, 2011-02-03 at 18:49 +0200, Michael S. Tsirkin wrote: > e1000 supports multi-buffer packets larger than rxbuf_size. > > This fixes the following (on linux): > - in guest: ifconfig eth1 mtu 16110 > - in host: ifconfig tap0 mtu 16110 >ping -s 16082 > > Red Hat bugzilla: https://

Re: [Qemu-devel] [PATCH 06/20] usb-ccid: review fixes (v15-v16)

2011-02-03 Thread Alon Levy
On Thu, Feb 03, 2011 at 10:48:03AM -0600, Anthony Liguori wrote: > On 02/02/2011 02:28 PM, Alon Levy wrote: > >I'll fold it before submitting the version to be applied, but > >I hope keeping it as a separate patch will make reviewing easier. > > Hrm, can you just send out the new patches? It's a

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2011-02-03 Thread khetzal
Confirmation: totaly crash with latest build. Nothing in logs. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/712416 Title: kvm_intel kernel module crash with via nano vmx Status in QEMU: New Sta

Re: [Qemu-devel] [PATCH 05/20] usb-ccid: add CCID bus

2011-02-03 Thread Alon Levy
On Thu, Feb 03, 2011 at 10:46:59AM -0600, Anthony Liguori wrote: > On 02/02/2011 02:28 PM, Alon Levy wrote: > >A CCID device is a smart card reader. It is a USB device, defined at [1]. > >This patch introduces the usb-ccid device that is a ccid bus. Next patches > >will > >introduce two card types

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 6:01 PM, Jan Kiszka wrote: > On 2011-02-03 18:54, Blue Swirl wrote: >> On Thu, Feb 3, 2011 at 5:43 PM, Jan Kiszka wrote: >>> On 2011-02-03 18:36, Blue Swirl wrote: On Thu, Feb 3, 2011 at 5:18 PM, Jan Kiszka wrote: > On 2011-02-03 18:03, Blue Swirl wrote: >> On

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Jan Kiszka
On 2011-02-03 20:01, Blue Swirl wrote: > On Thu, Feb 3, 2011 at 6:01 PM, Jan Kiszka wrote: >> On 2011-02-03 18:54, Blue Swirl wrote: >>> On Thu, Feb 3, 2011 at 5:43 PM, Jan Kiszka wrote: On 2011-02-03 18:36, Blue Swirl wrote: > On Thu, Feb 3, 2011 at 5:18 PM, Jan Kiszka wrote: >> On

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 7:06 PM, Jan Kiszka wrote: > On 2011-02-03 20:01, Blue Swirl wrote: >> On Thu, Feb 3, 2011 at 6:01 PM, Jan Kiszka wrote: >>> On 2011-02-03 18:54, Blue Swirl wrote: On Thu, Feb 3, 2011 at 5:43 PM, Jan Kiszka wrote: > On 2011-02-03 18:36, Blue Swirl wrote: >> On

[Qemu-devel] [PATCH v3] make tsc stable over migration and machine start

2011-02-03 Thread Glauber Costa
If the machine is stopped, we should not record two different tsc values upon a save operation. The same problem happens with kvmclock. But kvmclock is taking a different diretion, being now seen as a separate device. Since this is unlikely to happen with the tsc, I am taking the approach here of

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Jan Kiszka
On 2011-02-03 20:11, Blue Swirl wrote: > On Thu, Feb 3, 2011 at 7:06 PM, Jan Kiszka wrote: >> On 2011-02-03 20:01, Blue Swirl wrote: >>> On Thu, Feb 3, 2011 at 6:01 PM, Jan Kiszka wrote: On 2011-02-03 18:54, Blue Swirl wrote: > On Thu, Feb 3, 2011 at 5:43 PM, Jan Kiszka wrote: >> On

[Qemu-devel] [PATCH 1/4] target-arm: Add CPU feature flag for v7MP

2011-02-03 Thread Peter Maydell
Add a CPU feature flag for v7MP (the multiprocessing extensions); some instructions exist only for v7MP and not for the base v7 architecture. Signed-off-by: Peter Maydell --- target-arm/cpu.h|3 ++- target-arm/helper.c |6 ++ 2 files changed, 8 insertions(+), 1 deletions(-) diff

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 7:25 PM, Jan Kiszka wrote: > On 2011-02-03 20:11, Blue Swirl wrote: >> On Thu, Feb 3, 2011 at 7:06 PM, Jan Kiszka wrote: >>> On 2011-02-03 20:01, Blue Swirl wrote: On Thu, Feb 3, 2011 at 6:01 PM, Jan Kiszka wrote: > On 2011-02-03 18:54, Blue Swirl wrote: >> On

[Qemu-devel] Re: [RFC][PATCH] apic: Fix relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 7:32 PM, Jan Kiszka wrote: > When the guest remaps an APIC by modifying MSR_IA32_APICBASE, we need to > update its mmio mapping. This is a bit tricky as multiple APICs might be > mapped to the same address. So walk through the full list to avoid > unmapping a region that is

[Qemu-devel] [RFC][PATCH] apic: Fix relocation

2011-02-03 Thread Jan Kiszka
When the guest remaps an APIC by modifying MSR_IA32_APICBASE, we need to update its mmio mapping. This is a bit tricky as multiple APICs might be mapped to the same address. So walk through the full list to avoid unmapping a region that is still in use. Signed-off-by: Jan Kiszka --- RFC as I did

[Qemu-devel] [PATCH 0/4] target-arm: Fix decoding of preload and hint insns

2011-02-03 Thread Peter Maydell
The primary aim of this patch series is to fix the decoding of the preload and hint instruction space (PLD, PLDW, PLI). Some of these instructions (PLDW and some unallocated space which should NOP) are v7MP only, so we introduce a feature flag for cores with the v7MP extensions. The flag also lets

[Qemu-devel] [PATCH 2/4] target-arm: Clean up handling of MPIDR

2011-02-03 Thread Peter Maydell
The ARM cp15 register 0,c0,c0,5 is standardised in the v7 architecture as the MPIDR. Clean up its implementation to remove A9 specific handling. This commit includes fixing an error in the value returned for the MPIDR on A9, where we were erroneously claiming a cluster ID of 9. Signed-off-by: Pet

  1   2   >