[Qemu-devel] [PATCH v2] linux-user: implement sched_{g, s}etaffinity

2011-02-01 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- v2 - handle host/target size mismatches (32 on a 64) linux-user/syscall.c | 67 ++ 1 files changed, 67 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 64ba768

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 05:19, Mike Frysinger wrote: > On Mon, Jan 31, 2011 at 09:00, Edgar E. Iglesias wrote: >> * Some operations seem to translate to large amounts of tcg code, >> maybe you should consider using helpers for those. An example >> is gen_rot_tl. > > seems like generated native code

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Peter Maydell
On 1 February 2011 09:38, Alexander Graf wrote: > On 01.02.2011, at 05:19, Mike Frysinger wrote: >> On Mon, Jan 31, 2011 at 09:00, Edgar E. Iglesias wrote: >>> * cpu_get_tb_cpu_state() doesn't define any tb flags? >> >> no idea what this func is supposed to do > > Qemu uses the tb flags as identif

Re: [Qemu-devel] [V4 PATCH 2/8] Provide chroot environment server side interfaces

2011-02-01 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 10:55:39AM +0530, M. Mohan Kumar wrote: > Implement chroot server side interfaces like sending the file > descriptor to qemu process, reading the object request from socket etc. > Also add chroot main function and other helper routines. > > Signed-off-by: M. Mohan Kumar >

[Qemu-devel] [PATCH 0/2] virtagent - fsfreeze support

2011-02-01 Thread Jes . Sorensen
From: Jes Sorensen Hi This is a first attempt to add fsfreeze support to virtagent. The idea is for the guest agent to walk the list of locally mounted file systems in the guest, and issuing an ioctl to freeze them. The host can then do a live snapshot of the guest, obtaining stable file systems

[Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Jes . Sorensen
From: Jes Sorensen Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed. - fsfreeze(): Walk the list of mounted local real file systems, and freeze them. - fsthaw(): Walk the list of

[Qemu-devel] [PATCH 2/2] Add monitor commands for fsfreeze support

2011-02-01 Thread Jes . Sorensen
From: Jes Sorensen This patch adds the following monitor commands: agent_fsfreeze: - Freezes all local file systems in the guest. Command will print the number of file systems that were frozen. agent_fsthaw: - Thaws all local file systems in the guest. Command will print the number of fi

Re: [Qemu-devel] [PATCH 0/2] virtagent - fsfreeze support

2011-02-01 Thread Vasiliy G Tolstov
On Tue, 2011-02-01 at 11:58 +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Hi > > This is a first attempt to add fsfreeze support to virtagent. The idea > is for the guest agent to walk the list of locally mounted file > systems in the guest, and issuing an ioctl to freeze them.

Re: [Qemu-devel] Re: [PATCH][RFC] Add stdio char device on windows

2011-02-01 Thread Fabien Chouteau
On 01/31/2011 06:43 PM, Paolo Bonzini wrote: On 01/31/2011 06:09 PM, Fabien Chouteau wrote: Simple implementation of an stdio char device on Windows. Signed-off-by: Fabien Chouteau --- qemu-char.c | 171 +++ 1 files changed, 171 inse

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 11:31, Peter Maydell wrote: > On 1 February 2011 09:38, Alexander Graf wrote: >> On 01.02.2011, at 05:19, Mike Frysinger wrote: >>> On Mon, Jan 31, 2011 at 09:00, Edgar E. Iglesias wrote: * cpu_get_tb_cpu_state() doesn't define any tb flags? >>> >>> no idea what this func

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Peter Maydell
On 1 February 2011 11:46, Alexander Graf wrote: > Ouch. Yes. General rule: never access env from translate.c :). With the arm target I was tempted to restructure translate.c so that we copied the handful of "safe" bits of env that we used into the disas context struct right at the start, and the

Re: [Qemu-devel] [V4 PATCH 2/8] Provide chroot environment server side interfaces

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 10:32 AM, Daniel P. Berrange wrote: > There is a subtle problem with using fork() in a multi-threaded > program that I was recently made aware of in libvirt. In short > if you have a multi-threaded program that calls fork(), then > the child process must only use POSIX funct

[Qemu-devel] [PATCH 0.14] tap: safe sndbuf default

2011-02-01 Thread Michael S. Tsirkin
With current sndbuf default value, a blocked target guest can prevent another guest from transmitting any packets. While current sndbuf value (1M) is reported to help some UDP based workloads, the default should be safe (0). Signed-off-by: Michael S. Tsirkin --- I think this should go into 0.14.

[Qemu-devel] Re: [PATCH][RFC] Add stdio char device on windows

2011-02-01 Thread Paolo Bonzini
On 02/01/2011 12:24 PM, Fabien Chouteau wrote: Otherwise looks good, can you wait for http://permalink.gmane.org/gmane.comp.emulators.qemu/88490 to be merged so that you can add the set_echo implementation too? OK, I can wait. When do you expect your patches to be ready? They are, I'm waiting

[Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Paolo Bonzini
On 01/31/2011 10:39 PM, Anthony Liguori wrote: On 01/31/2011 12:10 PM, Jan Kiszka wrote: On 2011-01-31 11:02, Juan Quintela wrote: Please send in any agenda items you are interested incovering. o KVM upstream merge: status, plans, coordination o QMP support status for 0.14. Luiz and I alrea

Re: [Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Luiz Capitulino
On Mon, 31 Jan 2011 15:39:22 -0600 Anthony Liguori wrote: > On 01/31/2011 12:10 PM, Jan Kiszka wrote: > > On 2011-01-31 11:02, Juan Quintela wrote: > > > >> Please send in any agenda items you are interested incovering. > >> > >> > > o KVM upstream merge: status, plans, coordination >

Re: [Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Luiz Capitulino
On Tue, 1 Feb 2011 10:53:21 -0200 Luiz Capitulino wrote: > On Mon, 31 Jan 2011 15:39:22 -0600 > Anthony Liguori wrote: > > > On 01/31/2011 12:10 PM, Jan Kiszka wrote: > > > On 2011-01-31 11:02, Juan Quintela wrote: > > > > > >> Please send in any agenda items you are interested incovering.

[Qemu-devel] Re: [PATCH 2/3] Correct alarm deadline computation

2011-02-01 Thread Jan Kiszka
On 2011-01-31 22:51, Paolo Bonzini wrote: > When the QEMU_CLOCK_HOST clock was added, computation of its > deadline was added to qemu_next_deadline, which is correct but > incomplete. > > I noticed this by reading the very convoluted rules whereby > qemu_next_deadline_dyntick is computed, which mi

Re: [Qemu-devel] [PATCH 0/2] virtagent - fsfreeze support

2011-02-01 Thread Jes Sorensen
On 02/01/11 12:25, Vasiliy G Tolstov wrote: > Hello. Very nice feature. Sorry for offropic, but can this feature can > be used to modify partiotion table on already mounted device (for > example root on ext3? ) > Thank You. > No it cannot, that would be a totally different issue that wouldn't be

[Qemu-devel] Re: [PATCH 2/3] Correct alarm deadline computation

2011-02-01 Thread Paolo Bonzini
On 02/01/2011 02:01 PM, Jan Kiszka wrote: Looks good to me. I guess this applies without the first patch? Then it should go in (unless you are working on a new version for 1/3). It's wrong without the first patch (micro instead of nanoseconds). However, I read Anthony's message as a suggestion

[Qemu-devel] Re: [PATCH 2/3] Correct alarm deadline computation

2011-02-01 Thread Jan Kiszka
On 2011-02-01 14:04, Paolo Bonzini wrote: > On 02/01/2011 02:01 PM, Jan Kiszka wrote: >> Looks good to me. I guess this applies without the first patch? Then it >> should go in (unless you are working on a new version for 1/3). > > It's wrong without the first patch (micro instead of nanoseconds).

[Qemu-devel] Re: [PATCH 12/22] kvm: Call qemu_kvm_eat_signals also under !CONFIG_IOTHREAD

2011-02-01 Thread Marcelo Tosatti
On Thu, Jan 27, 2011 at 02:09:56PM +0100, Jan Kiszka wrote: > Move qemu_kvm_eat_signals around and call it also when the IO-thread is > not used. Do not yet process SIGBUS, will be armed in a separate step. > > Signed-off-by: Jan Kiszka > --- > cpus.c | 88 -

[Qemu-devel] Re: [PATCH 12/22] kvm: Call qemu_kvm_eat_signals also under !CONFIG_IOTHREAD

2011-02-01 Thread Marcelo Tosatti
On Tue, Feb 01, 2011 at 10:38:35AM -0200, Marcelo Tosatti wrote: > > @@ -943,7 +951,11 @@ bool cpu_exec_all(void) > > if (qemu_alarm_pending()) > > break; > > if (cpu_can_run(env)) { > > -if (qemu_cpu_exec(env) == EXCP_DEBUG) { > > +r = qemu_cp

[Qemu-devel] Re: [PATCH 16/22] Introduce VCPU self-signaling service

2011-02-01 Thread Marcelo Tosatti
On Thu, Jan 27, 2011 at 02:10:00PM +0100, Jan Kiszka wrote: > Introduce qemu_cpu_kick_self to send SIG_IPI to the calling VCPU > context. First user will be kvm. > > Signed-off-by: Jan Kiszka > --- > cpus.c| 21 + > qemu-common.h |1 + > 2 files changed, 22 inse

[Qemu-devel] Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Marcelo Tosatti
On Thu, Jan 27, 2011 at 02:09:58PM +0100, Jan Kiszka wrote: > Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between > checking for exit_request on vcpu entry and timer signals arriving > before KVM starts to catch them. Plug it by blocking both timer related > signals also on !CONFIG_IO

[Qemu-devel] Re: [PATCH 12/22] kvm: Call qemu_kvm_eat_signals also under !CONFIG_IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 13:38, Marcelo Tosatti wrote: > On Thu, Jan 27, 2011 at 02:09:56PM +0100, Jan Kiszka wrote: >> Move qemu_kvm_eat_signals around and call it also when the IO-thread is >> not used. Do not yet process SIGBUS, will be armed in a separate step. >> >> Signed-off-by: Jan Kiszka >> --- >>

Re: [Qemu-devel] [RFC][PATCH 00/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-02-01 Thread Kevin Wolf
Am 24.01.2011 00:31, schrieb Anthony Liguori: > On 01/22/2011 03:29 AM, Stefan Hajnoczi wrote: >> This patch series prototypes making QCOW2 fully asynchronous to eliminate the >> timing jitter and poor performance that has been observed. QCOW2 has >> asynchronous I/O code paths for some of the rea

[Qemu-devel] Re: [PATCH V6 1/4] nmi: convert cpu_index to cpu-index

2011-02-01 Thread Luiz Capitulino
On Thu, 27 Jan 2011 16:20:27 +0800 Lai Jiangshan wrote: > "cpu-index" which uses hyphen is better name. > > Signed-off-by: Lai Jiangshan It looks ok from a quick pass, but I can't apply it on current master, what commit HEAD did you? Btw, please, do include the patch 0/0 with a general descr

[Qemu-devel] [Bug 550863] Re: MicroBlaze QEMU skips jumps when using single steps in GDB

2011-02-01 Thread Christophe
I'm having a similar issue with Qemu 0.13.0, program counter is just incremented by 4 when single stepping. I am using GDB 7.2. Stephan, did you get it to work in single step mode? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

[Qemu-devel] Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 13:47, Marcelo Tosatti wrote: > On Thu, Jan 27, 2011 at 02:09:58PM +0100, Jan Kiszka wrote: >> Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between >> checking for exit_request on vcpu entry and timer signals arriving >> before KVM starts to catch them. Plug it by blockin

[Qemu-devel] Re: [PATCH 16/22] Introduce VCPU self-signaling service

2011-02-01 Thread Jan Kiszka
On 2011-02-01 14:14, Marcelo Tosatti wrote: > On Thu, Jan 27, 2011 at 02:10:00PM +0100, Jan Kiszka wrote: >> Introduce qemu_cpu_kick_self to send SIG_IPI to the calling VCPU >> context. First user will be kvm. >> >> Signed-off-by: Jan Kiszka >> --- >> cpus.c| 21 + >>

Re: [Qemu-devel] [PATCH] qcow2: Really use cache=unsafe for image creation

2011-02-01 Thread Stefan Hajnoczi
On Thu, Jan 27, 2011 at 3:50 PM, Kevin Wolf wrote: > For cache=unsafe we also need to set BDRV_O_CACHE_WB, otherwise we have some > strange unsafe writethrough mode. > > Signed-off-by: Kevin Wolf > --- >  block/qcow2.c |    3 ++- >  1 files changed, 2 insertions(+), 1 deletions(-) Reviewed-by: S

[Qemu-devel] Re: [PATCH 16/22] Introduce VCPU self-signaling service

2011-02-01 Thread Marcelo Tosatti
On Tue, Feb 01, 2011 at 02:33:45PM +0100, Jan Kiszka wrote: > >> +++ b/cpus.c > >> @@ -531,6 +531,17 @@ void qemu_cpu_kick(void *env) > >> return; > >> } > >> > >> +void qemu_cpu_kick_self(void) > >> +{ > >> +#ifndef _WIN32 > >> +assert(cpu_single_env); > >> + > >> +raise(SIG_IPI);

Re: [Qemu-devel] [PATCH 1/3] FVD: Added support for 'qemu-img update'

2011-02-01 Thread Stefan Hajnoczi
On Mon, Jan 31, 2011 at 2:49 PM, Chunqiang Tang wrote: > The paper [2] below from VMware is informative but cannot be adopted by us > directly, as the problem domain is different. I previously had a paper on > general congestion control, > https://sites.google.com/site/tangchq/papers/NCI-USENIX09.

[Qemu-devel] Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 14:48, Marcelo Tosatti wrote: > On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: >> On 2011-02-01 13:47, Marcelo Tosatti wrote: >>> On Thu, Jan 27, 2011 at 02:09:58PM +0100, Jan Kiszka wrote: Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between checki

[Qemu-devel] Re: [PATCH 16/22] Introduce VCPU self-signaling service

2011-02-01 Thread Jan Kiszka
On 2011-02-01 14:50, Marcelo Tosatti wrote: > On Tue, Feb 01, 2011 at 02:33:45PM +0100, Jan Kiszka wrote: +++ b/cpus.c @@ -531,6 +531,17 @@ void qemu_cpu_kick(void *env) return; } +void qemu_cpu_kick_self(void) +{ +#ifndef _WIN32 +assert(cpu_

[Qemu-devel] Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Marcelo Tosatti
On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: > On 2011-02-01 13:47, Marcelo Tosatti wrote: > > On Thu, Jan 27, 2011 at 02:09:58PM +0100, Jan Kiszka wrote: > >> Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between > >> checking for exit_request on vcpu entry and timer sig

[Qemu-devel] Re: [PATCH 2/8] ahci: split ICH and AHCI even more

2011-02-01 Thread Alexander Graf
On 18.01.2011, at 13:19, Kevin Wolf wrote: > Am 20.12.2010 22:13, schrieb Alexander Graf: >> Sebastian's patch already did a pretty good job at splitting up ICH-9 >> AHCI code and the AHCI core. We need some more though. Copyright was missing, >> the lspci dump belongs to ICH-9, we don't need the

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 10:58 AM, wrote: > From: Jes Sorensen > > Implement freeze/thaw support in the guest, allowing the host to > request the guest freezes all it's file systems before a live snapshot > is performed. >  - fsfreeze(): Walk the list of mounted local real file systems, >        

[Qemu-devel] Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Marcelo Tosatti
On Tue, Feb 01, 2011 at 02:58:02PM +0100, Jan Kiszka wrote: > On 2011-02-01 14:48, Marcelo Tosatti wrote: > > On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: > >> On 2011-02-01 13:47, Marcelo Tosatti wrote: > >>> On Thu, Jan 27, 2011 at 02:09:58PM +0100, Jan Kiszka wrote: > Found b

Re: [Qemu-devel] [PATCH 0/2] virtagent - fsfreeze support

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 10:58 AM, wrote: > From: Jes Sorensen > This is a first attempt to add fsfreeze support to virtagent. The idea > is for the guest agent to walk the list of locally mounted file > systems in the guest, and issuing an ioctl to freeze them. The host > can then do a live snaps

[Qemu-devel] Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 15:10, Marcelo Tosatti wrote: > On Tue, Feb 01, 2011 at 02:58:02PM +0100, Jan Kiszka wrote: >> On 2011-02-01 14:48, Marcelo Tosatti wrote: >>> On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: On 2011-02-01 13:47, Marcelo Tosatti wrote: > On Thu, Jan 27, 2011 at 02:

[Qemu-devel] Re: [V4 PATCH 5/8] Create support in chroot environment

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 5:27 AM, M. Mohan Kumar wrote: > +    if (setfsuid(request->data.uid) < 0) { > +        fd_info->fi_error = errno; > +        return; > +    } > +    if (setfsgid(request->data.gid) < 0) { > +        fd_info->fi_error = errno; > +        goto unset_uid; > +    } fsuid is Li

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Jes Sorensen
On 02/01/11 15:12, Stefan Hajnoczi wrote: > On Tue, Feb 1, 2011 at 10:58 AM, wrote: >> From: Jes Sorensen >> >> Implement freeze/thaw support in the guest, allowing the host to >> request the guest freezes all it's file systems before a live snapshot >> is performed. >> - fsfreeze(): Walk the l

Re: [Qemu-devel] [PATCH 0/2] virtagent - fsfreeze support

2011-02-01 Thread Jes Sorensen
On 02/01/11 15:16, Stefan Hajnoczi wrote: > On Tue, Feb 1, 2011 at 10:58 AM, wrote: >> From: Jes Sorensen >> This is a first attempt to add fsfreeze support to virtagent. The idea >> is for the guest agent to walk the list of locally mounted file >> systems in the guest, and issuing an ioctl to

Re: [Qemu-devel] [V4 PATCH 6/8] Support for creating special files

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 5:27 AM, M. Mohan Kumar wrote: > +static int passthrough_mknod(FsContext *fs_ctx, const char *path, FsCred > *credp) > +{ > +    V9fsFileObjectRequest request; > +    int retval, error = 0; > + > +    fill_request(&request, path, credp); > +    request.data.type = T_MKNOD;

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen wrote: > On 02/01/11 15:12, Stefan Hajnoczi wrote: >> On Tue, Feb 1, 2011 at 10:58 AM,   wrote: >>> From: Jes Sorensen >>> >>> Implement freeze/thaw support in the guest, allowing the host to >>> request the guest freezes all it's file systems before a

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Jes Sorensen
On 02/01/11 15:34, Stefan Hajnoczi wrote: > On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen wrote: >> I have to admit you lost me here, where do you get that 500ms time from? >> Is that the XMLRPC polling time or? I just used the example code from >> other agent calls. > > 500 ms is made up. I was

Re: [Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 13:56, Luiz Capitulino wrote: > On Tue, 1 Feb 2011 10:53:21 -0200 > Luiz Capitulino wrote: > >> On Mon, 31 Jan 2011 15:39:22 -0600 >> Anthony Liguori wrote: >> >>> On 01/31/2011 12:10 PM, Jan Kiszka wrote: On 2011-01-31 11:02, Juan Quintela wrote: > Please sen

[Qemu-devel] Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 15:21, Jan Kiszka wrote: > On 2011-02-01 15:10, Marcelo Tosatti wrote: >> On Tue, Feb 01, 2011 at 02:58:02PM +0100, Jan Kiszka wrote: >>> On 2011-02-01 14:48, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: > On 2011-02-01 13:47, Marcelo Tos

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 2:36 PM, Jes Sorensen wrote: > On 02/01/11 15:34, Stefan Hajnoczi wrote: >> On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen wrote: >>> I have to admit you lost me here, where do you get that 500ms time from? >>> Is that the XMLRPC polling time or? I just used the example code

[Qemu-devel] Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 15:37, Jan Kiszka wrote: > On 2011-02-01 15:21, Jan Kiszka wrote: >> On 2011-02-01 15:10, Marcelo Tosatti wrote: >>> On Tue, Feb 01, 2011 at 02:58:02PM +0100, Jan Kiszka wrote: On 2011-02-01 14:48, Marcelo Tosatti wrote: > On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka

[Qemu-devel] Re: [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Adam Litke
On Tue, 2011-02-01 at 11:58 +0100, jes.soren...@redhat.com wrote: > +/* > + * va_fsfreeze(): Walk list of mounted file systems in the guest, and > + * freeze the ones which are real local file systems. > + * rpc return values: Number of file systems frozen, -1 on error. > + */ > +static xmlrpc_va

[Qemu-devel] [PATCH 0/7] Some more AHCI work v2

2011-02-01 Thread Alexander Graf
Clearly, AHCI as is is not perfect yet (intentionally, release early, release often, remember?). This patch set makes it work with SeaBIOS so booting Windows 7 works flawlessly for me. it also adds some speedups and fixes a level based interrupts, rendering ahci useful on PPC targets. In preparati

[Qemu-devel] [PATCH 4/7] ahci: send init d2h fis on fis enable

2011-02-01 Thread Alexander Graf
The drive sends a d2h init fis on initialization. Usually, the guest doesn't receive fises yet at that point though, so the delivery is deferred. Let's reflect that by sending the init fis on fis receive enablement. Signed-off-by: Alexander Graf --- v1 -> v2: - add comment on d2h delay hack

[Qemu-devel] [PATCH 5/7] ahci: Implement HBA reset

2011-02-01 Thread Alexander Graf
The ahci code was missing its soft reset functionality. This wasn't really an issue for Linux guests, but Windows gets confused when the controller doesn't reset when it tells it so. Using this patch I can now successfully boot Windows 7 from AHCI using AHCI enabled SeaBIOS. Signed-off-by: Alexan

[Qemu-devel] [PATCH 6/7] ahci: make number of ports runtime determined

2011-02-01 Thread Alexander Graf
Different AHCI controllers have a different number of ports, so the core shouldn't care about the amount of ports available. This patch makes the number of ports available to the AHCI core runtime configurable, allowing us to have multiple different AHCI implementations with different amounts of p

[Qemu-devel] [PATCH 3/7] ahci: split ICH and AHCI even more

2011-02-01 Thread Alexander Graf
Sebastian's patch already did a pretty good job at splitting up ICH-9 AHCI code and the AHCI core. We need some more though. Copyright was missing, the lspci dump belongs to ICH-9, we don't need the AHCI core to have its own qdev device duplicate. So let's split them a bit more in this patch, maki

[Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Alexander Graf
When using level based interrupts, the interrupt is treated the same as an edge triggered one: leaving the line up does not retrigger the interrupt. In fact, when not lowering the line, we won't ever get a new interrupt inside the guest. So let's always retrigger an interrupt as soon as the OS ack

[Qemu-devel] [PATCH 2/7] ahci: add license header in ahci.h

2011-02-01 Thread Alexander Graf
Due to popular request, this patch adds a license header to ahci.h Signed-off-by: Alexander Graf --- hw/ide/ahci.h | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h index 63ef785..d65b5e3 100644 --- a/hw/ide/ahci.h +++ b

[Qemu-devel] Re: [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Jes Sorensen
On 02/01/11 15:48, Adam Litke wrote: > On Tue, 2011-02-01 at 11:58 +0100, jes.soren...@redhat.com wrote: >> +/* >> + * va_fsfreeze(): Walk list of mounted file systems in the guest, and >> + * freeze the ones which are real local file systems. >> + * rpc return values: Number of file systems froz

Re: [Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Anthony Liguori
On 02/01/2011 08:37 AM, Alexander Graf wrote: o SeaBIOS update for 0.14 - I'd like to see an AHCI boot capable version there I'll update to the latest release before I fork today. Regards, Anthony Liguori Alex

Re: [Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 16:05, Anthony Liguori wrote: > On 02/01/2011 08:37 AM, Alexander Graf wrote: >> >> o SeaBIOS update for 0.14 - I'd like to see an AHCI boot capable version >> there >> > > I'll update to the latest release before I fork today. Last time I checked, AHCI was disabled by de

[Qemu-devel] [PATCH] Make spice dummy functions inline to fix calls not checking return values

2011-02-01 Thread Jes . Sorensen
From: Jes Sorensen qemu_spice_set_passwd() and qemu_spice_set_pw_expire() dummy functions needs to be inline, in order to handle the case where they are called without checking the return value. Signed-off-by: Jes Sorensen --- ui/qemu-spice.h | 12 ++-- 1 files changed, 10 insertions

[Qemu-devel] [PATCH 1/7] ahci: split ICH9 from core

2011-02-01 Thread Alexander Graf
From: Sebastian Herbszt There are multiple ahci devices out there. The currently implemented ich-9 is only one of the many. So let's split that one out into a separate file to stress the difference. Signed-off-by: Sebastian Herbszt Signed-off-by: Alexander Graf --- Makefile.objs |1 + hw/

[Qemu-devel] KVM call minutes for Feb 1

2011-02-01 Thread Chris Wright
KVM upstream merge: status, plans, coordination - Jan has a git tree, consolidating - qemu-kvm io threading is still an issue - Anthony wants to just merge - concerns with non-x86 arch and merge - concerns with big-bang patch merge and following stability - post 0.14 conversion to glib mainloop

[Qemu-devel] [PATCH] linux-user: avoid gcc array overrun warning for sparc

2011-02-01 Thread Peter Maydell
Suppress a gcc array bounds overrun warning when filling in the SPARC signal frame by adjusting our definition of the structure so that the fp and callers_pc membes are part of the ins[] array rather than separate fields; since qemu has no need to access the fields individually there is no need to

Re: [Qemu-devel] [PATCH 0.14] tap: safe sndbuf default

2011-02-01 Thread Anthony Liguori
On 02/01/2011 06:25 AM, Michael S. Tsirkin wrote: With current sndbuf default value, a blocked target guest can prevent another guest from transmitting any packets. While current sndbuf value (1M) is reported to help some UDP based workloads, the default should be safe (0). Can you be more

Re: [Qemu-devel] [PATCH] linux-user: avoid gcc array overrun warning for sparc

2011-02-01 Thread Peter Maydell
On 1 February 2011 15:54, Peter Maydell wrote: > --- a/linux-user/signal.c > +++ b/linux-user/signal.c > @@ -1817,9 +1817,10 @@ struct target_sigcontext { >  /* A Sparc stack frame */ >  struct sparc_stackf { >         abi_ulong locals[8]; > -        abi_ulong ins[6]; > -        struct sparc_stack

Re: [Qemu-devel] [PATCH 0/2] virtagent - fsfreeze support

2011-02-01 Thread Richard W.M. Jones
On Tue, Feb 01, 2011 at 02:25:12PM +0300, Vasiliy G Tolstov wrote: > On Tue, 2011-02-01 at 11:58 +0100, jes.soren...@redhat.com wrote: > > From: Jes Sorensen > > > > Hi > > > > This is a first attempt to add fsfreeze support to virtagent. The idea > > is for the guest agent to walk the list of l

[Qemu-devel] Re: [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Michael Roth
On 02/01/2011 04:58 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed. - fsfreeze(): Walk the list of mounted local real file systems,

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Aurelien Jarno
On Tue, Feb 01, 2011 at 03:51:32PM +0100, Alexander Graf wrote: > When using level based interrupts, the interrupt is treated the same as an > edge triggered one: leaving the line up does not retrigger the interrupt. > > In fact, when not lowering the line, we won't ever get a new interrupt inside

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Aurelien Jarno
On Tue, Feb 01, 2011 at 05:53:43PM +0100, Alexander Graf wrote: > > On 01.02.2011, at 17:34, Aurelien Jarno wrote: > > > On Tue, Feb 01, 2011 at 03:51:32PM +0100, Alexander Graf wrote: > >> When using level based interrupts, the interrupt is treated the same as an > >> edge triggered one: leaving

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 18:06, Aurelien Jarno wrote: > On Tue, Feb 01, 2011 at 05:53:43PM +0100, Alexander Graf wrote: >> >> On 01.02.2011, at 17:34, Aurelien Jarno wrote: >> >>> On Tue, Feb 01, 2011 at 03:51:32PM +0100, Alexander Graf wrote: When using level based interrupts, the interrupt is t

[Qemu-devel] [PATCH 4/4] add CONFIG_VMPORT option

2011-02-01 Thread Eduardo Habkost
This allows vmport to be easily enabled or disabled at build time. Signed-off-by: Eduardo Habkost --- Makefile.target|3 ++- default-configs/i386-softmmu.mak |2 ++ default-configs/x86_64-softmmu.mak |2 ++ hw/pc_piix.c |2 ++ 4 files c

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Jan Kiszka
On 2011-02-01 17:53, Anthony Liguori wrote: > On 02/01/2011 10:36 AM, Jan Kiszka wrote: >> On 2011-02-01 16:54, Chris Wright wrote: >> >>> KVM upstream merge: status, plans, coordination >>> - Jan has a git tree, consolidating >>> - qemu-kvm io threading is still an issue >>> - Anthony wants to

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 17:34, Aurelien Jarno wrote: > On Tue, Feb 01, 2011 at 03:51:32PM +0100, Alexander Graf wrote: >> When using level based interrupts, the interrupt is treated the same as an >> edge triggered one: leaving the line up does not retrigger the interrupt. >> >> In fact, when not lowe

[Qemu-devel] [PATCH 0/4] fix/add CONFIG_* options for VMWare device emulation

2011-02-01 Thread Eduardo Habkost
Hi, This series makes CONFIG_VMWARE_VGA actually work (today we can't disable the option without getting a build error). It also add two new options: CONFIG_VMMOUSE and CONFIG_VMPORT, for vmmouse.o and vmport.o. Eduardo Habkost (4): Add config-devices.h again skip pci_vmsvga_init() calls if

[Qemu-devel] [PATCH 3/4] add CONFIG_VMMOUSE option

2011-02-01 Thread Eduardo Habkost
This will allow vmmouse to be disabled at build time if necessary. Signed-off-by: Eduardo Habkost --- Makefile.target|5 - default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 + hw/pc.c|2 ++ 4 files c

[Qemu-devel] [PATCH 2/4] skip pci_vmsvga_init() calls if CONFIG_VMWARE_VGA is disabled

2011-02-01 Thread Eduardo Habkost
I was planning to add the check for CONFIG_VMWARE to the command-line parsing code in vl.c, but vl.c is not built by Makefile.target, so we can't test for a per-target config option there. It is not the best solution, but it is better than simply having a CONFIG_VMWARE_VGA option that doesn't work

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Aurelien Jarno
On Tue, Feb 01, 2011 at 06:10:56PM +0100, Alexander Graf wrote: > > On 01.02.2011, at 18:06, Aurelien Jarno wrote: > > > On Tue, Feb 01, 2011 at 05:53:43PM +0100, Alexander Graf wrote: > >> > >> On 01.02.2011, at 17:34, Aurelien Jarno wrote: > >> > >>> On Tue, Feb 01, 2011 at 03:51:32PM +0100,

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Christoph Hellwig
On Tue, Feb 01, 2011 at 05:36:13PM +0100, Jan Kiszka wrote: > kvm_cpu_exec/kvm_run, and start wondering "What needs to be done to > upstream so that qemu-kvm could use that implementation?". If they > differ, the reasons need to be understood and patched away, either by > fixing/enhancing upstream

[Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-01 Thread Jan Kiszka
Hi, testing my KVM patches, I noticed that none of the 64-bit Windows versions I have around (early Win7 & 2003 server) boot in KVM mode when using 2 or more VCPUs and the user space irqchip. This applies to both upstream KVM and qemu-kvm, with our without any of my current patches. A subtle diffe

[Qemu-devel] Re: [PATCH] hw/slavio_intctl.c: fix gcc warning about array bounds overrun

2011-02-01 Thread Blue Swirl
Thanks, applied. On Mon, Jan 31, 2011 at 10:42 AM, Peter Maydell wrote: > The Ubuntu 10.10 gcc for ARM complains that we might be overrunning > the cpu_irqs[][] array: silence this by correcting the bounds on the > loop. (In fact we would not have overrun the array because bit > MAX_PILS in pil_p

Re: [Qemu-devel] [PATCH] linux-user: avoid gcc array overrun warning for sparc

2011-02-01 Thread Blue Swirl
On Tue, Feb 1, 2011 at 4:00 PM, Peter Maydell wrote: > On 1 February 2011 15:54, Peter Maydell wrote: >> --- a/linux-user/signal.c >> +++ b/linux-user/signal.c >> @@ -1817,9 +1817,10 @@ struct target_sigcontext { >>  /* A Sparc stack frame */ >>  struct sparc_stackf { >>         abi_ulong locals[

Re: [Qemu-devel] [PATCH v2] SPARC: Fix Leon3 cache control

2011-02-01 Thread Blue Swirl
Thanks, applied. On Mon, Jan 31, 2011 at 10:36 AM, Fabien Chouteau wrote: > The "leon3_cache_control_int" (op_helper.c) function is called within leon3.c > which leads to segfault error with the global "env". > > Now cache control is a CPU feature and everything is handled in op_helper.c. > > Sig

[Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-02-01 Thread Yoshiaki Tamura
Paolo, I refactored the savevm functions. Could you give me your comments? Thanks, Yoshi diff --git a/savevm.c b/savevm.c index 5418280..90aae55 100644 --- a/savevm.c +++ b/savevm.c @@ -1602,29 +1602,68 @@ bool qemu_savevm_state_blocked(Monitor *mon) return false; } -int qemu_savevm_sta

[Qemu-devel] Re: [PATCH] linux-user: avoid gcc array overrun warning for sparc

2011-02-01 Thread Blue Swirl
Thanks, applied. On Tue, Feb 1, 2011 at 3:54 PM, Peter Maydell wrote: > Suppress a gcc array bounds overrun warning when filling in the SPARC > signal frame by adjusting our definition of the structure so that the > fp and callers_pc membes are part of the ins[] array rather than > separate field

Re: [Qemu-devel] [PATCH 1/4] Add config-devices.h again

2011-02-01 Thread Stefan Weil
Am 01.02.2011 17:53, schrieb Eduardo Habkost: This reverts part of commit a992fe3d0fc185112677286f7a02204d8245b61e. We do have code that needs #ifdefs depending on the list of enabled devices, but currently that code breaks when we try to disable a feature that is enabled by default. For exampl

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Mike Frysinger
On Tue, Feb 1, 2011 at 12:30, Peter Maydell wrote: > On 1 February 2011 17:20, Mike Frysinger wrote: >> On Tue, Feb 1, 2011 at 05:31, Peter Maydell wrote: >>> I suspect that this check of pc against the lbreg[] >>> values should be being done in the generated code, >>> not at translate time. >> >>

[Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Alexander Graf
When using level based interrupts, the interrupt is treated the same as an edge triggered one: leaving the line up does not retrigger the interrupt. In fact, when not lowering the line, we won't ever get a new interrupt inside the guest. So let's always retrigger an interrupt as soon as the OS ack

Re: [Qemu-devel] [PATCH 1/3] use nanoseconds everywhere for timeout computation

2011-02-01 Thread Aurelien Jarno
On Mon, Jan 31, 2011 at 10:51:17PM +0100, Paolo Bonzini wrote: > Suggested by Aurelien Jarno. > > Signed-off-by: Paolo Bonzini > --- > qemu-timer.c | 30 +++--- > 1 files changed, 15 insertions(+), 15 deletions(-) Reviewed-by: Aurelien Jarno > diff --git a/qemu-timer

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Peter Maydell
On 1 February 2011 18:16, Mike Frysinger wrote: > On Tue, Feb 1, 2011 at 12:30, Peter Maydell wrote: >> That's OK too, that would fall into my category (3). > > so the TB invalidation checking can be taken care of implicitly if i > handled things in cpu_get_tb_cpu_state() ?  that would be nice. I

Re: [Qemu-devel] [PATCH 1/3] use nanoseconds everywhere for timeout computation

2011-02-01 Thread Aurelien Jarno
On Mon, Jan 31, 2011 at 04:17:52PM -0600, Anthony Liguori wrote: > On 01/31/2011 03:51 PM, Paolo Bonzini wrote: >> Suggested by Aurelien Jarno. >> >> Signed-off-by: Paolo Bonzini >> > > Something I've found is that we have a lot of bugs that are the result > of unit conversions when the unit

[Qemu-devel] [PATCH 1/4] Add config-devices.h again

2011-02-01 Thread Eduardo Habkost
This reverts part of commit a992fe3d0fc185112677286f7a02204d8245b61e. We do have code that needs #ifdefs depending on the list of enabled devices, but currently that code breaks when we try to disable a feature that is enabled by default. For example, if we try to disable CONFIG_VMWARE_VGA, we ge

Re: [Qemu-devel] [PATCH 0/4] fix/add CONFIG_* options for VMWare device emulation

2011-02-01 Thread Blue Swirl
On Tue, Feb 1, 2011 at 4:53 PM, Eduardo Habkost wrote: > Hi, > > This series makes CONFIG_VMWARE_VGA actually work (today we can't disable the > option without getting a build error). > > It also add two new options: CONFIG_VMMOUSE and CONFIG_VMPORT, for vmmouse.o > and vmport.o. Nack, see the li

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Michael Roth
On 02/01/2011 08:41 AM, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 2:36 PM, Jes Sorensen wrote: On 02/01/11 15:34, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen wrote: I have to admit you lost me here, where do you get that 500ms time from? Is that the XMLRPC polling

[Qemu-devel] [PATCH] make tsc stable over migration and machine start

2011-02-01 Thread Glauber Costa
If the machine is stopped, we should not record two different tsc values upon a save operation. The same problem happens with kvmclock. But kvmclock is taking a different diretion, being now seen as a separate device. Since this is unlikely to happen with the tsc, I am taking the approach here of

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Jan Kiszka
On 2011-02-01 18:20, Anthony Liguori wrote: > On 02/01/2011 11:03 AM, Jan Kiszka wrote: >> On 2011-02-01 17:53, Anthony Liguori wrote: >> >>> On 02/01/2011 10:36 AM, Jan Kiszka wrote: >>> On 2011-02-01 16:54, Chris Wright wrote: > KVM upstream merge: status, pla

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Anthony Liguori
On 02/01/2011 10:36 AM, Jan Kiszka wrote: On 2011-02-01 16:54, Chris Wright wrote: KVM upstream merge: status, plans, coordination - Jan has a git tree, consolidating - qemu-kvm io threading is still an issue - Anthony wants to just merge - concerns with non-x86 arch and merge - concer

  1   2   >