[Qemu-devel] [PATCH] Correct win32 timers deleting v.3

2011-01-26 Thread Pavel Dovgaluk
This patch fixes resource leaks caused by quitting qemu with exit() function on win32 host. Timer object should be freed not only at the end of the main function, but by every of the application exits. v.3: Fixed all the issues found in previous messages with patch. Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] Re: [PATCH 07/18] kvm: Add MCE signal support for !CONFIG_IOTHREAD

2011-01-26 Thread Jan Kiszka
On 2011-01-24 13:36, Jan Kiszka wrote: > On 2011-01-24 12:17, Marcelo Tosatti wrote: >> On Mon, Jan 10, 2011 at 09:32:00AM +0100, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Currently, we only configure and process MCE-related SIGBUS events if >>> CONFIG_IOTHREAD is enabled. Fix this by factori

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Jan Kiszka
On 2011-01-25 17:49, Stefan Berger wrote: > On 01/25/2011 02:26 AM, Jan Kiszka wrote: >> >> Do you see a chance to look closer at the issue yourself? E.g. >> instrument the kernel's irqchip models and dump their states once your >> guest is stuck? > The device runs on iRQ 3. So I applied this patch

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Edgar E. Iglesias
On Tue, Jan 25, 2011 at 02:07:15PM -0800, Richard Henderson wrote: > On 01/25/2011 08:48 AM, Edgar E. Iglesias wrote: > > OK, I see. Maybe we should try to emit an insn sequence more similar > > to what tcg was emitting (for the non 8 & 16-bit deposits)? > > That ought too at least give similar res

Re: [Qemu-devel] [PATCH][RFC] New trace-event backend: stdio

2011-01-26 Thread Fabien Chouteau
On 01/24/2011 06:33 PM, Fabien Chouteau wrote: This backend sends trace events to standard output during the emulation. Any comments? -- Fabien Chouteau

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Alexander Graf
On 26.01.2011, at 09:53, Edgar E. Iglesias wrote: > On Tue, Jan 25, 2011 at 02:07:15PM -0800, Richard Henderson wrote: >> On 01/25/2011 08:48 AM, Edgar E. Iglesias wrote: >>> OK, I see. Maybe we should try to emit an insn sequence more similar >>> to what tcg was emitting (for the non 8 & 16-bit

Re: [Qemu-devel] [PATCH] ahci: Fix cpu_physical_memory_unmap() argument ordering

2011-01-26 Thread Kevin Wolf
Am 23.12.2010 09:53, schrieb Stefan Hajnoczi: > The len and is_write arguments to cpu_physical_memory_unmap() were > swapped. This patch changes calls to use the correct argument ordering. > > Signed-off-by: Stefan Hajnoczi > --- > This patch applies to agraf's ahci tree at git://repo.or.cz/qemu

[Qemu-devel] [PATCH 03/19] Introduce skip_header parameter to qemu_loadvm_state().

2011-01-26 Thread Yoshiaki Tamura
Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header. Signed-off-by: Yoshiaki Tamura --- migration.c |2 +- savevm.c| 24 +--- sysemu.h|2 +- 3 files changed, 15 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH 02/19] Introduce read() to FdMigrationState.

2011-01-26 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Signed-off-by: Yoshiaki Tamura --- migration-tcp.c | 15 +++ migration.c | 13 + migration.h |3 +++ 3 files changed, 31 insertions(+), 0 d

[Qemu-devel] [PATCH 2/3] pci: use devfn for pci_find_device() instead of (slot, fn) pair

2011-01-26 Thread Isaku Yamahata
(slot, fn) pair is somewhat confusing because of ARI. So use devfn for pci_find_device() instead of (slot, fn). Signed-off-by: Isaku Yamahata --- hw/pci-hotplug.c |5 +++-- hw/pci.c |5 +++-- hw/pci.h |2 +- hw/pci_host.c|2 +- hw/pcie_host.c |3 +-- 5 f

[Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-26 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests sent from device emulators. Signed-off-by: Yoshiaki Tamura --- block.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index ff2795b..e4df9b6 100644 --- a/block.c +++ b/block.c

[Qemu-devel] [PATCH 13/19] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async().

2011-01-26 Thread Yoshiaki Tamura
event-tap function is called only when it is on. Signed-off-by: Yoshiaki Tamura --- net.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index 9ba5be2..1176124 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include "qemu-common.h" #include "qe

[Qemu-devel] [PATCH 10/19] Call init handler of event-tap at main() in vl.c.

2011-01-26 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura --- vl.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 8bbb785..9faeb27 100644 --- a/vl.c +++ b/vl.c @@ -162,6 +162,7 @@ int main(int argc, char **argv) #include "qemu-queue.h" #include "cpus.h" #include "arch_init.h

[Qemu-devel] [PATCH 06/19] virtio: decrement last_avail_idx with inuse before saving.

2011-01-26 Thread Yoshiaki Tamura
For regular migration inuse == 0 always as requests are flushed before save. However, event-tap log when enabled introduces an extra queue for requests which is not being flushed, thus the last inuse requests are left in the event-tap queue. Move the last_avail_idx value sent to the remote back to

[Qemu-devel] [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2011-01-26 Thread Yoshiaki Tamura
When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). Signed-off-by: Yoshiaki Tamura --- hmp-commands.hx |7 --- migration.c |4 qmp-commands.hx |7 --- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/h

[Qemu-devel] [PATCH 00/19] Kemari for KVM v0.2.7

2011-01-26 Thread Yoshiaki Tamura
Hi, This patch series is a revised version of Kemari for KVM, which applied comments for the previous post. The current code is based on qemu.git 0bfe006c5380c5f8a485a55ded3329fbbc224396. The changes from v0.2.6 -> v0.2.7 are: - add AIOCB, AIOPool and cancel functions (Kevin) - insert event-tap

[Qemu-devel] [PATCH 16/19] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on.

2011-01-26 Thread Yoshiaki Tamura
Introduce migrate_ft_trans_put_ready() which kicks the FT transaction cycle. When ft_mode is on, migrate_fd_put_ready() would open ft_trans_file and turn on event_tap. To end or cancel FT transaction, ft_mode and event_tap is turned off. migrate_ft_trans_get_ready() is called to receive ack from

[Qemu-devel] [PATCH 11/19] ioport: insert event_tap_ioport() to ioport_write().

2011-01-26 Thread Yoshiaki Tamura
Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura --- ioport.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index aa4188a..74aebf5 100644 --- a/ioport.c +++ b/ioport.c @@ -27,6 +27,7 @@ #include "ioport.h" #include

[Qemu-devel] [PATCH 17/19] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled.

2011-01-26 Thread Yoshiaki Tamura
When ft_mode is set in the header, tcp_accept_incoming_migration() sets ft_trans_incoming() as a callback, and call qemu_file_get_notify() to receive FT transaction iteratively. We also need a hack no to close fd before moving to ft_transaction mode, so that we can reuse the fd for it. vm_change_

[Qemu-devel] [PATCH 07/19] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-01-26 Thread Yoshiaki Tamura
This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- Makefile.objs

[Qemu-devel] [PATCH 05/19] vl.c: add deleted flag for deleting the handler.

2011-01-26 Thread Yoshiaki Tamura
Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura --- vl.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 0292184..8bbb785 100644 ---

[Qemu-devel] [PATCH 0/3] pci/pcie: implement ARI enable bit correctly

2011-01-26 Thread Isaku Yamahata
This patch series implements ARI enable bit in root/downstream port correctly. Isaku Yamahata (3): pci: replace the magic, 256, for the maximum of devfn pci: use devfn for pci_find_device() instead of (slot, fn) pair pci/pcie: make pci_find_device() ARI aware. hw/pci-hotplug.c |5 +++

[Qemu-devel] [PATCH 12/19] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-01-26 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index e950df2..c81fd09 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7 @@ #include "osdep.h" #include "kvm.h

[Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-26 Thread Yoshiaki Tamura
event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- Makefile.targe

Re: [Qemu-devel] [PATCH][RFC] New trace-event backend: stdio

2011-01-26 Thread Stefan Hajnoczi
On Mon, Jan 24, 2011 at 5:33 PM, Fabien Chouteau wrote: > diff --git a/docs/tracing.txt b/docs/tracing.txt > index 963c504..de033ad 100644 > --- a/docs/tracing.txt > +++ b/docs/tracing.txt > @@ -133,6 +133,11 @@ source tree.  It may not be as powerful as > platform-specific or third-party >  trac

[Qemu-devel] [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.

2011-01-26 Thread Yoshiaki Tamura
The option looks like, -incoming ::,ft_mode Signed-off-by: Yoshiaki Tamura --- migration.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 1752cf4..29d4fb1 100644 --- a/migration.c +++ b/migration.c @@ -45,6 +45,12 @@ int qemu_start_i

[Qemu-devel] [PATCH 3/3] pci/pcie: make pci_find_device() ARI aware.

2011-01-26 Thread Isaku Yamahata
make pci_find_device() ARI aware. Signed-off-by: Isaku Yamahata --- hw/pci.c |6 ++ hw/pcie.c | 33 + hw/pcie.h |2 +- 3 files changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index ac16029..daba310 100644 --- a/hw/pci.c +

Re: [Qemu-devel] [PATCH][RFC] New trace-event backend: stdio

2011-01-26 Thread Stefan Hajnoczi
On Mon, Jan 24, 2011 at 5:33 PM, Fabien Chouteau wrote: > @@ -236,6 +237,55 @@ linetoc_end_simple() >  EOF >  } > > +#STDIO > +linetoh_begin_stdio() > +{ > +    return > +} > + > +linetoh_stdio() > +{ > +    local name args argnamess argc fmt > +    name=$(get_name "$1") > +    args=$(get_args "$1

[Qemu-devel] [PATCH 04/19] qemu-char: export socket_set_nodelay().

2011-01-26 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index edc9ad6..737d347 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2116,7 +2116,7 @@ static void tcp_chr_telnet_init(int

[Qemu-devel] [PATCH] pci: w1cmask[PCI_BRIDGE_CONTROL] initialized incorrectly

2011-01-26 Thread Isaku Yamahata
pci_init_wmask_bridge() incorrectly set w1cmask[PCI_BRIDGE_CONTROL]. This patch removes the line otherwise the assert(!(wmask & w1cmask)) in pci_default_write_config() is hit. Signed-off-by: Isaku Yamahata --- hw/pci.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/h

[Qemu-devel] [PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2011-01-26 Thread Yoshiaki Tamura
Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Signed-off-by: Yoshiaki Tamura --- hw/hw.h |2 ++ savevm.c | 20 +++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index dd993de..7f05830 100644 --- a/hw/

[Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-01-26 Thread Yoshiaki Tamura
Introduce qemu_savevm_state_{begin,commit} to send the memory and device info together, while avoiding cancelling memory state tracking. Signed-off-by: Yoshiaki Tamura --- savevm.c | 93 ++ sysemu.h |2 + 2 files changed, 95 inser

[Qemu-devel] [PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-01-26 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura --- hw/hw.h |5 ++ savevm.c | 149 ++ 2 files changed, 154 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h ind

[Qemu-devel] [PATCH] ahci: Fix cpu_physical_memory_unmap() argument ordering

2011-01-26 Thread Stefan Hajnoczi
The len and is_write arguments to cpu_physical_memory_unmap() were swapped. This patch changes calls to use the correct argument ordering. Signed-off-by: Stefan Hajnoczi --- hw/ide/ahci.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) Rebased on qemu.git/master. diff --gi

[Qemu-devel] [PATCH] kvm: Prevent dynticks race condition for !CONFIG_IOTHREAD

2011-01-26 Thread Stefan Hajnoczi
The dynticks timer arranges for SIGALRM to be raised when the next pending timer expires. When building with !CONFIG_IOTHREAD, we need to check whether a request to exit the vcpu is pending before re-entering the guest. Unfortunately there is a race condition here because SIGALRM may be raised af

Re: [Qemu-devel] [PATCH 0/3 v3] allow online resizing of block devices

2011-01-26 Thread Stefan Hajnoczi
On Mon, Jan 24, 2011 at 12:32 PM, Christoph Hellwig wrote: > The second patch adds a way to tell drivers about a resize, and the > third one adds a guest notification for config changes to virtio-blk > which allows the guest to pick it up without a rescan.  I've just sent > the corresponding Linux

[Qemu-devel] [PATCH] Add documentation for STRTOSZ_DEFSUFFIX_ macros

2011-01-26 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- qemu-common.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qemu-common.h b/qemu-common.h index c766b99..505e576 100644 --- a/qemu-common.h +++ b/qemu-common.h @@ -153,6 +153,13 @@ int qemu_fls(int i); int qemu

[Qemu-devel] [PATCH 1/3] pci: replace the magic, 256, for the maximum of devfn

2011-01-26 Thread Isaku Yamahata
Introduce symbol PCI_DEVFN_MAX for the maximum of devfn and replace the magic, 256. Signed-off-by: Isaku Yamahata --- hw/pci.h |2 ++ hw/pci_internals.h |2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index 0d2753f..ffb04e8 100644 --- a

[Qemu-devel] [PATCH] savevm: unbreak register_savevm_live()/vmstate_register_with_alias_id()

2011-01-26 Thread Isaku Yamahata
This patch unbreaks 7685ee6abcb939104801f84b3fe9645412528088. With the changeset, more than one instances of same device on bus that provides get_dev_path method can't be created because it hits the assertion. This patch removes the assertion whose assumption isn't correct. Cc: Alex Williamson Si

[Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-26 Thread Avi Kivity
On 01/25/2011 04:35 PM, Stefan Hajnoczi wrote: On Tue, Jan 25, 2011 at 2:26 PM, Avi Kivity wrote: > On 01/25/2011 12:06 AM, Anthony Liguori wrote: >> >> On 01/24/2011 07:25 AM, Chris Wright wrote: >>> >>> Please send in any agenda items you are interested in covering. >> >> - coroutines for

Re: [Qemu-devel] [PATCH] ahci: Fix cpu_physical_memory_unmap() argument ordering

2011-01-26 Thread Alexander Graf
Kevin Wolf wrote: > Am 23.12.2010 09:53, schrieb Stefan Hajnoczi: > >> The len and is_write arguments to cpu_physical_memory_unmap() were >> swapped. This patch changes calls to use the correct argument ordering. >> >> Signed-off-by: Stefan Hajnoczi >> --- >> This patch applies to agraf's ahci

Re: [Qemu-devel] [PATCH] ahci: Fix cpu_physical_memory_unmap() argument ordering

2011-01-26 Thread Kevin Wolf
Am 26.01.2011 11:10, schrieb Alexander Graf: > Kevin Wolf wrote: >> Am 23.12.2010 09:53, schrieb Stefan Hajnoczi: >> >>> The len and is_write arguments to cpu_physical_memory_unmap() were >>> swapped. This patch changes calls to use the correct argument ordering. >>> >>> Signed-off-by: Stefan H

[Qemu-devel] [PATCH v2] New trace-event backend: stderr

2011-01-26 Thread Fabien Chouteau
This backend sends trace events to standard error output during the emulation. Signed-off-by: Fabien Chouteau --- configure |2 +- docs/tracing.txt |5 + scripts/tracetool | 53 - 3 files changed, 58 insertions(+), 2 dele

[Qemu-devel] Re: [PATCH v3] virtio-pci: Disable virtio-ioeventfd when !CONFIG_IOTHREAD

2011-01-26 Thread Kevin Wolf
Am 25.01.2011 18:42, schrieb Michael S. Tsirkin: > On Tue, Jan 25, 2011 at 04:17:14PM +, Stefan Hajnoczi wrote: >> It is not possible to use virtio-ioeventfd when building without an I/O >> thread. We rely on a signal to kick us out of vcpu execution. Timers >> and AIO use SIGALRM and SIGUSR2

Re: [Qemu-devel] [PATCH 6/7] Teach vnc server to use GThread directly

2011-01-26 Thread Stefan Hajnoczi
On Mon, Jan 24, 2011 at 9:00 PM, Anthony Liguori wrote: > +#ifdef _WIN32 > +GThread *q_thread_create_nosignal(GThreadFunc func, > +                                  gpointer data, > +                                  gboolean joinable, > +                                  GError **error) Let's no

[Qemu-devel] Re: [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately

2011-01-26 Thread Jan Kiszka
On 2010-12-17 15:58, Jan Kiszka wrote: > By default, we base the mc146818 RTC on the host clock (CLOCK_REALTIME). > This works fine if only the frequency of the host clock is tuned (e.g. > by NTP) or if it is set to a future time. However, if the host is tuned > backward, e.g. because NTP obtained

Re: [Qemu-devel] [PATCH 0/3 v3] allow online resizing of block devices

2011-01-26 Thread Kevin Wolf
Am 24.01.2011 13:32, schrieb Christoph Hellwig: > This patchset adds support for online resizing of block devices. > > The first patch adds a new resize monitor command which call into > the existing image resize code. This is the meat of the series > and probably needs quite a bit of review and

Re: [Qemu-devel] [PATCH] Add documentation for STRTOSZ_DEFSUFFIX_ macros

2011-01-26 Thread Kevin Wolf
Am 26.01.2011 12:53, schrieb Markus Armbruster: > jes.soren...@redhat.com writes: > >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen >> --- >> qemu-common.h |7 +++ >> 1 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/qemu-common.h b/qemu-common.h >> index c766b

[Qemu-devel] Re: [PATCH 07/18] kvm: Add MCE signal support for !CONFIG_IOTHREAD

2011-01-26 Thread Marcelo Tosatti
On Wed, Jan 26, 2011 at 09:09:25AM +0100, Jan Kiszka wrote: > On 2011-01-24 13:36, Jan Kiszka wrote: > > On 2011-01-24 12:17, Marcelo Tosatti wrote: > >> On Mon, Jan 10, 2011 at 09:32:00AM +0100, Jan Kiszka wrote: > >>> From: Jan Kiszka > >>> > >>> Currently, we only configure and process MCE-rela

Re: [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command

2011-01-26 Thread Marcelo Tosatti
On Tue, Jan 25, 2011 at 07:05:37PM +0100, Christoph Hellwig wrote: > On Tue, Jan 25, 2011 at 01:01:04PM +0100, Kevin Wolf wrote: > > > Can't resize if block migration is in progress. Don't see a problem > > > with simply disallowing resize in that case. > > > > Then we should add a check to bdrv_

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-26 Thread Stefano Bonifazi
On 01/25/2011 02:36 AM, Richard Henderson wrote: On 01/24/2011 01:44 PM, Stefano Bonifazi wrote: Wow wonderful! So you fixed the code for PIC (ET_DYN) support? Yes. how can I get your sources? I was mistaken -- a later version of the patch set was in fact merged. I simply forgot to delete my

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Stefan Berger
On 01/26/2011 03:14 AM, Jan Kiszka wrote: On 2011-01-25 17:49, Stefan Berger wrote: On 01/25/2011 02:26 AM, Jan Kiszka wrote: Do you see a chance to look closer at the issue yourself? E.g. instrument the kernel's irqchip models and dump their states once your guest is stuck? The device runs on

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Jan Kiszka
On 2011-01-26 13:05, Stefan Berger wrote: > On 01/26/2011 03:14 AM, Jan Kiszka wrote: >> On 2011-01-25 17:49, Stefan Berger wrote: >>> On 01/25/2011 02:26 AM, Jan Kiszka wrote: Do you see a chance to look closer at the issue yourself? E.g. instrument the kernel's irqchip models and dump t

[Qemu-devel] Re: [PATCH] pci: w1cmask[PCI_BRIDGE_CONTROL] initialized incorrectly

2011-01-26 Thread Michael S. Tsirkin
On Wed, Jan 26, 2011 at 06:45:27PM +0900, Isaku Yamahata wrote: > pci_init_wmask_bridge() incorrectly set w1cmask[PCI_BRIDGE_CONTROL]. > This patch removes the line otherwise the assert(!(wmask & w1cmask)) in > pci_default_write_config() is hit. > > Signed-off-by: Isaku Yamahata Maybe clear in w

Re: [Qemu-devel] [PATCH] Add documentation for STRTOSZ_DEFSUFFIX_ macros

2011-01-26 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > qemu-common.h |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/qemu-common.h b/qemu-common.h > index c766b99..505e576 100644 > --- a/qemu-common.h > +++ b/qemu-common.

[Qemu-devel] Re: [PATCH] ahci: Fix cpu_physical_memory_unmap() argument ordering

2011-01-26 Thread Kevin Wolf
Am 26.01.2011 11:24, schrieb Stefan Hajnoczi: > The len and is_write arguments to cpu_physical_memory_unmap() were > swapped. This patch changes calls to use the correct argument ordering. > > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin

[Qemu-devel] Re: [PATCH 07/18] kvm: Add MCE signal support for !CONFIG_IOTHREAD

2011-01-26 Thread Jan Kiszka
On 2011-01-26 13:01, Marcelo Tosatti wrote: > On Wed, Jan 26, 2011 at 09:09:25AM +0100, Jan Kiszka wrote: >> On 2011-01-24 13:36, Jan Kiszka wrote: >>> On 2011-01-24 12:17, Marcelo Tosatti wrote: On Mon, Jan 10, 2011 at 09:32:00AM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Cu

[Qemu-devel] [PATCH] lsi53c895a: Update dnad when skipping MSGOUT bytes

2011-01-26 Thread Stefan Hajnoczi
Update not only dbc but also dnad when skipping bytes during the MSGOUT phase. Previously only dbc was updated which is probably wrong and could lead to bogus message codes being read. Tested on Linux and Windows Server 2003. Signed-off-by: Stefan Hajnoczi --- hw/lsi53c895a.c | 11 +-

Re: [Qemu-devel] [PATCH v2] New trace-event backend: stderr

2011-01-26 Thread Stefan Hajnoczi
On Wed, Jan 26, 2011 at 11:34 AM, Fabien Chouteau wrote: > +linetoh_stderr() > +{ > +    local name args argnamess argc fmt s/argnamess/argnames/ Stefan

Re: [Qemu-devel] [PATCH v2] New trace-event backend: stderr

2011-01-26 Thread Peter Maydell
On 26 January 2011 11:34, Fabien Chouteau wrote: > -echo "  --enable-trace-backend=B Trace backend nop simple ust dtrace" > +echo "  --enable-trace-backend=B Trace backend nop simple stderr ust dtrace" This is a bit cryptic, especially since there's no punctuation. Maybe it would be better to hav

Re: [Qemu-devel] [PATCH 1/2] Add bootindex handling into usb storage device.

2011-01-26 Thread Gleb Natapov
ping? On Sun, Jan 02, 2011 at 05:07:30PM +0200, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- > hw/usb-msd.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/hw/usb-msd.c b/hw/usb-msd.c > index 0a95d8d..46642a8 100644 > --- a/hw/usb-msd.c > +++ b/hw/us

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-26 Thread Richard W.M. Jones
I posted my thoughts about how this could work here: https://www.redhat.com/archives/libguestfs/2011-January/msg00066.html Rich. PS. You don't need to be a subscriber to post to that list -- I manually triage any messages sent by non-subscribers. -- Richard Jones, Virtualization Group, Red Ha

Re: [Qemu-devel] [PATCH v2] New trace-event backend: stderr

2011-01-26 Thread Fabien Chouteau
On 01/26/2011 01:34 PM, Stefan Hajnoczi wrote: On Wed, Jan 26, 2011 at 11:34 AM, Fabien Chouteau wrote: +linetoh_stderr() +{ +local name args argnamess argc fmt s/argnamess/argnames/ Fixed. Thanks, -- Fabien Chouteau

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Stefan Berger
On 01/26/2011 07:09 AM, Jan Kiszka wrote: On 2011-01-26 13:05, Stefan Berger wrote: On 01/26/2011 03:14 AM, Jan Kiszka wrote: On 2011-01-25 17:49, Stefan Berger wrote: On 01/25/2011 02:26 AM, Jan Kiszka wrote: Do you see a chance to look closer at the issue yourself? E.g. instrument the kerne

[Qemu-devel] Re: [PATCH] kvm: Prevent dynticks race condition for !CONFIG_IOTHREAD

2011-01-26 Thread Jan Kiszka
On 2011-01-26 10:39, Stefan Hajnoczi wrote: > The dynticks timer arranges for SIGALRM to be raised when the next > pending timer expires. When building with !CONFIG_IOTHREAD, we need to > check whether a request to exit the vcpu is pending before re-entering > the guest. > > Unfortunately there i

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Jan Kiszka
On 2011-01-26 14:08, Stefan Berger wrote: > On 01/26/2011 07:09 AM, Jan Kiszka wrote: >> On 2011-01-26 13:05, Stefan Berger wrote: >>> On 01/26/2011 03:14 AM, Jan Kiszka wrote: On 2011-01-25 17:49, Stefan Berger wrote: > On 01/25/2011 02:26 AM, Jan Kiszka wrote: >> Do you see a chance

[Qemu-devel] Re: [PATCH] pci: w1cmask[PCI_BRIDGE_CONTROL] initialized incorrectly

2011-01-26 Thread Isaku Yamahata
The bit should be writable, not w1c. 3.2.5.18 bridge control register bit 11 Discard Timer SERR# Enable When set to 1, this bit enables the bridge to assert SERR# on the primary interface when either the Primary Discard Timer or Secondary Discard Timer expires and a Delayed Transaction is

Re: [Qemu-devel] [PATCH v2] New trace-event backend: stderr

2011-01-26 Thread Fabien Chouteau
On 01/26/2011 01:56 PM, Peter Maydell wrote: On 26 January 2011 11:34, Fabien Chouteau wrote: -echo " --enable-trace-backend=B Trace backend nop simple ust dtrace" +echo " --enable-trace-backend=B Trace backend nop simple stderr ust dtrace" This is a bit cryptic, especially since there's no

Re: [Qemu-devel] [PATCH v2] target-sh4: update PTEH upon MMU exception

2011-01-26 Thread Aurelien Jarno
On Wed, Jan 26, 2011 at 11:57:53AM +0900, Alexandre Courbot wrote: > Update the PTEH register to contain the VPN at which an MMU > exception occured as specified by the SH4 reference. > > Signed-off-by: Alexandre Courbot > --- > target-sh4/helper.c |4 > 1 files changed, 4 insertions(+)

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Jan Kiszka
On 2011-01-26 14:15, Jan Kiszka wrote: > On 2011-01-26 14:08, Stefan Berger wrote: >> On 01/26/2011 07:09 AM, Jan Kiszka wrote: >>> On 2011-01-26 13:05, Stefan Berger wrote: On 01/26/2011 03:14 AM, Jan Kiszka wrote: > On 2011-01-25 17:49, Stefan Berger wrote: >> On 01/25/2011 02:26 AM,

Re: [Qemu-devel] [PATCH] Support saturation with shift=0.

2011-01-26 Thread Aurelien Jarno
On Wed, Jan 19, 2011 at 05:10:52PM +0100, Christophe Lyon wrote: > > This patch fixes corner-case saturations, when the target range is > zero. It merely removes the guard against (sh == 0), and makes: > __ssat(0x87654321, 1) return 0x and set the saturation flag > __usat(0x87654321, 0) re

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-26 Thread Aurelien Jarno
On Wed, Jan 19, 2011 at 03:37:58PM +0100, Christophe Lyon wrote: > Here is an updated patch which will hopefully not be mangled by my mailer. > > Fix garbage collection of temporaries in Neon emulation. > > > Signed-off-by: Christophe Lyon > --- > target-arm/translate.c | 18 +---

Re: [Qemu-devel] [PATCH] target-arm: Fix loading of scalar value for Neon multiply-by-scalar

2011-01-26 Thread Aurelien Jarno
On Wed, Jan 19, 2011 at 07:29:53PM +, Peter Maydell wrote: > Fix the register and part of register we get the scalar from in > the various "multiply vector by scalar" ops (VMUL by scalar > and friends). > > Signed-off-by: Peter Maydell > --- > target-arm/translate.c | 12 ++-- > 1

[Qemu-devel] [PATCH v3] New trace-event backend: stderr

2011-01-26 Thread Fabien Chouteau
This backend sends trace events to standard error output during the emulation. Also add a "--list-backends" option to tracetool, so configure script can display the list of available backends. Signed-off-by: Fabien Chouteau --- configure |3 +- docs/tracing.txt |5 scripts

[Qemu-devel] Re: [PATCH 1/3] pci: replace the magic, 256, for the maximum of devfn

2011-01-26 Thread Michael S. Tsirkin
On Wed, Jan 26, 2011 at 06:45:18PM +0900, Isaku Yamahata wrote: > Introduce symbol PCI_DEVFN_MAX for the maximum of devfn > and replace the magic, 256. > > Signed-off-by: Isaku Yamahata > --- > hw/pci.h |2 ++ > hw/pci_internals.h |2 +- > 2 files changed, 3 insertions(+), 1 de

[Qemu-devel] Re: [PATCH 3/3] pci/pcie: make pci_find_device() ARI aware.

2011-01-26 Thread Michael S. Tsirkin
On Wed, Jan 26, 2011 at 06:45:20PM +0900, Isaku Yamahata wrote: > make pci_find_device() ARI aware. > > Signed-off-by: Isaku Yamahata > --- > hw/pci.c |6 ++ > hw/pcie.c | 33 + > hw/pcie.h |2 +- > 3 files changed, 36 insertions(+), 5 deletions(-)

[Qemu-devel] Re: [PATCH 2/3] pci: use devfn for pci_find_device() instead of (slot, fn) pair

2011-01-26 Thread Michael S. Tsirkin
On Wed, Jan 26, 2011 at 06:45:19PM +0900, Isaku Yamahata wrote: > (slot, fn) pair is somewhat confusing because of ARI. > So use devfn for pci_find_device() instead of (slot, fn). > > Signed-off-by: Isaku Yamahata I'd prefer using uint8_t for devfn. This way we don't need to bother to range-chec

[Qemu-devel] Re: [PATCH] kvm: Prevent dynticks race condition for !CONFIG_IOTHREAD

2011-01-26 Thread Jan Kiszka
On 2011-01-26 14:12, Jan Kiszka wrote: > On 2011-01-26 10:39, Stefan Hajnoczi wrote: >> The dynticks timer arranges for SIGALRM to be raised when the next >> pending timer expires. When building with !CONFIG_IOTHREAD, we need to >> check whether a request to exit the vcpu is pending before re-ente

Re: [Qemu-devel] Re: [PATCH] kvm: Prevent dynticks race condition for !CONFIG_IOTHREAD

2011-01-26 Thread Stefan Hajnoczi
On Wed, Jan 26, 2011 at 1:56 PM, Jan Kiszka wrote: > Looks like this should also include SIGIO in case hpet is selected as > host timer. Yeah that can't hurt although since hpet is periodic we don't risk forgetting to rearm the timer. Can you explain the signalfd idea a little more? I'm not sur

[Qemu-devel] [Bug 702885] Re: "Internal resource leak" error with ARM NEON vmull.s32 insn

2011-01-26 Thread Aurelien Jarno
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/702885 Title: "Internal resource leak" error with ARM NEON vmull.s32 insn Status in QEMU: Fi

[Qemu-devel] [patch 5/5] block: enable in_use flag

2011-01-26 Thread Marcelo Tosatti
Set block device in use during block migration, disallow drive_del and bdrv_truncate for in use devices. Signed-off-by: Marcelo Tosatti Index: qemu/blockdev.c === --- qemu.orig/blockdev.c +++ qemu/blockdev.c @@ -690,6 +690,10 @@ int

[Qemu-devel] [patch 1/5] block-migration: actually disable dirty tracking on cleanup

2011-01-26 Thread Marcelo Tosatti
Call to set_dirty_tracking() is misplaced. Signed-off-by: Marcelo Tosatti Index: qemu/block-migration.c === --- qemu.orig/block-migration.c +++ qemu/block-migration.c @@ -528,6 +528,8 @@ static void blk_mig_cleanup(Monitor *mon

[Qemu-devel] [patch 3/5] block-migration: add reference to target DriveInfo

2011-01-26 Thread Marcelo Tosatti
So that ejection of attached device by guest does not free data in use by block migration instance. Signed-off-by: Marcelo Tosatti CC: Markus Armbruster Index: qemu/block-migration.c === --- qemu.orig/block-migration.c +++ qemu/blo

[Qemu-devel] Re: [PATCH] pci: w1cmask[PCI_BRIDGE_CONTROL] initialized incorrectly

2011-01-26 Thread Michael S. Tsirkin
On Wed, Jan 26, 2011 at 10:17:48PM +0900, Isaku Yamahata wrote: > The bit should be writable, not w1c. > > 3.2.5.18 bridge control register > bit 11 Discard Timer SERR# Enable > > When set to 1, this bit enables the bridge to assert SERR# on > the primary interface when either the Primary Dis

[Qemu-devel] Re: [PATCH] pci: w1cmask[PCI_BRIDGE_CONTROL] initialized incorrectly

2011-01-26 Thread Michael S. Tsirkin
On Wed, Jan 26, 2011 at 10:53:42PM +0900, Isaku Yamahata wrote: > On Wed, Jan 26, 2011 at 03:46:01PM +0200, Michael S. Tsirkin wrote: > > On Wed, Jan 26, 2011 at 10:17:48PM +0900, Isaku Yamahata wrote: > > > The bit should be writable, not w1c. > > > > > > 3.2.5.18 bridge control register > > > bi

Re: [Qemu-devel] Re: [PATCH] kvm: Prevent dynticks race condition for !CONFIG_IOTHREAD

2011-01-26 Thread Jan Kiszka
On 2011-01-26 15:01, Stefan Hajnoczi wrote: > On Wed, Jan 26, 2011 at 1:56 PM, Jan Kiszka wrote: >> Looks like this should also include SIGIO in case hpet is selected as >> host timer. > > Yeah that can't hurt although since hpet is periodic we don't risk > forgetting to rearm the timer. > > Can

Re: [Qemu-devel] [PATCH V9 16/16] acpi-piix4: Add Xen hypercall for sleep state.

2011-01-26 Thread Anthony PERARD
On Wed, 26 Jan 2011, Isaku Yamahata wrote: > On Tue, Jan 25, 2011 at 02:29:20PM +, anthony.per...@citrix.com wrote: > > From: Anthony PERARD > > > > Signed-off-by: Anthony PERARD > > --- > > hw/acpi_piix4.c |4 > > hw/xen.h|2 ++ > > xen-all.c |7 +++ > >

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Stefan Berger
On 01/26/2011 08:31 AM, Jan Kiszka wrote: On 2011-01-26 14:15, Jan Kiszka wrote: On 2011-01-26 14:08, Stefan Berger wrote: On 01/26/2011 07:09 AM, Jan Kiszka wrote: On 2011-01-26 13:05, Stefan Berger wrote: On 01/26/2011 03:14 AM, Jan Kiszka wrote: On 2011-01-25 17:49, Stefan Berger wrote:

[Qemu-devel] Re: [PATCH] savevm: unbreak register_savevm_live()/vmstate_register_with_alias_id()

2011-01-26 Thread Alex Williamson
On Wed, 2011-01-26 at 18:45 +0900, Isaku Yamahata wrote: > This patch unbreaks 7685ee6abcb939104801f84b3fe9645412528088. > With the changeset, more than one instances of same device on bus > that provides get_dev_path method can't be created because it hits > the assertion. > This patch removes the

[Qemu-devel] Re: [PATCH] pci: w1cmask[PCI_BRIDGE_CONTROL] initialized incorrectly

2011-01-26 Thread Isaku Yamahata
On Wed, Jan 26, 2011 at 03:46:01PM +0200, Michael S. Tsirkin wrote: > On Wed, Jan 26, 2011 at 10:17:48PM +0900, Isaku Yamahata wrote: > > The bit should be writable, not w1c. > > > > 3.2.5.18 bridge control register > > bit 11 Discard Timer SERR# Enable > > > > When set to 1, this bit enables t

[Qemu-devel] [patch 0/5] block migration interaction fixes

2011-01-26 Thread Marcelo Tosatti
See individual patches for details.

[Qemu-devel] Re: [PATCH V9 16/16] xen: Add Xen hypercall for sleep state in the cmos_s3 callback.

2011-01-26 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/xen_machine_fv.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/xen_machine_fv.c b/hw/xen_machine_fv.c index 0a90312..f48b978 100644 --- a/hw/xen_machine_fv.c +++ b/hw/xen_machine_fv.c @@ -38,9 +38

[Qemu-devel] [patch 2/5] blockdev: add refcount to DriveInfo

2011-01-26 Thread Marcelo Tosatti
The host part of a block device can be deleted with in progress block migration. To fix this, add a reference count to DriveInfo, freeing resources on last reference. Signed-off-by: Marcelo Tosatti CC: Markus Armbruster Index: qemu/blockdev.c ===

Re: [Qemu-devel] [PATCH v3] New trace-event backend: stderr

2011-01-26 Thread Stefan Hajnoczi
On Wed, Jan 26, 2011 at 1:37 PM, Fabien Chouteau wrote: > This backend sends trace events to standard error output during the emulation. > > Also add a "--list-backends" option to tracetool, so configure script can > display the list of available backends. > > Signed-off-by: Fabien Chouteau > ---

[Qemu-devel] [patch 4/5] Add flag to indicate external users to block device

2011-01-26 Thread Marcelo Tosatti
Certain operations such as drive_del or resize cannot be performed while external users (eg. block migration) reference the block device. Add a flag to indicate that. Signed-off-by: Marcelo Tosatti Index: qemu/block.c === --- qemu.

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-26 Thread Richard Henderson
On 01/26/2011 03:07 AM, Stefano Bonifazi wrote: > P.S. Please just answer that last question, whether it is possible to > have a variable showing the upper bound of heap (some brk_end) for a > target process No, the heap grows until it reaches some other memory mapped entity. r~

Re: [Qemu-devel] [PATCH v3] New trace-event backend: stderr

2011-01-26 Thread Peter Maydell
On 26 January 2011 13:37, Fabien Chouteau wrote: > +echo "                           Available backends:" > $($source_path/scripts/tracetool --list-backends) Not enough quoting -- this will break if $source_path has a space in it. Try: echo " Available backends: $("$s

Re: [Qemu-devel] [RFC][PATCH 01/12] coroutine: Add gtk-vnc coroutines library

2011-01-26 Thread Avi Kivity
On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Asynchronous image format code is becoming very complex. Let's try using coroutines to write sequential code without callbacks but use coroutines to switch stacks under the hood. + +int cc_swap(struct continuation *from, struct continuation *to) +

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Richard Henderson
On 01/26/2011 01:23 AM, Alexander Graf wrote: > agraf@toonie:/studio/s390/qemu-s390> grep deposit target-s390x/translate.c > tcg_gen_deposit_i64(regs[reg], regs[reg], tmp, 0, 32); > tcg_gen_deposit_i64(regs[reg], regs[reg], v, 0, 32); > tcg_gen_deposit_i64(regs[reg], regs[reg], tmp, 0,

Re: [Qemu-devel] [RFC][PATCH 05/12] coroutine: Add coroutines

2011-01-26 Thread Avi Kivity
On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Add functions to create coroutines and transfer control into a coroutine and back out again. + +struct Coroutine { +struct coroutine co; +}; + +/** + * Coroutine entry point + * + * When the coroutine is entered for the first time, opaque is p

  1   2   >