Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Pierre Riteau
Le 20 janv. 2011 à 17:18, Yoshiaki Tamura a écrit : > 2011/1/20 Pierre Riteau : >> On 20 janv. 2011, at 03:06, Yoshiaki Tamura wrote: >> >>> 2011/1/19 Pierre Riteau : b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return value of bdrv_write and aborts migration when it

Re: [Qemu-devel] Qemu signal handling

2011-01-21 Thread Peter Maydell
On 21 January 2011 03:34, maheen butt wrote: > In QEMU code almost every signal is handled then why this warning is > generated from syscall.c > #elif defined(TARGET_ABI_MIPSN64) > > # warning signal handling not implemented This is in the Linux user-mode code, which has to correctly emulate cal

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Gerd Hoffmann
On 01/20/11 20:39, Anthony Liguori wrote: On 01/20/2011 02:44 AM, Gerd Hoffmann wrote: Hi, For (2), you cannot use bus=X,addr=Y because it makes assumptions about the PCI topology which may change in newer -M pc's. Why should the PCI topology for 'pc' ever change? We'll probably get q35 sup

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Gerd Hoffmann
Hi, By the way, we don't have a QEMUState but instead use globals. /me wants to underline this. IMO it is absolutely pointless to worry about ways to pass around kvm_state. There never ever will be a serious need for that. We can stick with the current model of keeping global state in g

Re: [Qemu-devel] [PATCH 0/5] -drive/drive_add fixes

2011-01-21 Thread Stefan Hajnoczi
On Mon, Jan 17, 2011 at 07:31:25PM +0100, Markus Armbruster wrote: > Note: PATCH 3/5 makes -drive reject duplicate definitions instead of > ignoring all but the first silently. If this isn't sufficiently > bug-compatible for you, we need to talk. > > Markus Armbruster (5): > blockdev: Fix error

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Kevin Wolf
Am 21.01.2011 09:08, schrieb Pierre Riteau: > Le 20 janv. 2011 à 17:18, Yoshiaki Tamura a > écrit : > >> 2011/1/20 Pierre Riteau : >>> On 20 janv. 2011, at 03:06, Yoshiaki Tamura wrote: >>> 2011/1/19 Pierre Riteau : > b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Kevin Wolf
Am 19.01.2011 15:59, schrieb Pierre Riteau: > b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return > value of bdrv_write and aborts migration when it fails. However, if the > size of the block device to migrate is not a multiple of BLOCK_SIZE > (currently 1 MB), the last bdrv_write

[Qemu-devel] [PATCH] docs: Document simple trace backend thread-safety limitation

2011-01-21 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index 963c504..d2499d9 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -133,6 +133,11 @@ source tree. It may not be as powe

Re: [Qemu-devel] [PATCH 1/3] make path_has_protocol() to return pointer instead of bool

2011-01-21 Thread Kevin Wolf
Am 12.01.2011 11:57, schrieb Michael Tokarev: > Currently protocol: parsing in filenames is ad-hoc and scattered all around > block.c. This is a first step to prepare for common parsing. > > Signed-off-by: Michael Tokarev > --- > block.c | 18 +++--- > 1 files changed, 15 insertio

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-21 Thread Michael S. Tsirkin
On Thu, Jan 20, 2011 at 06:23:36PM -0600, Anthony Liguori wrote: > On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote: > >On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony Liguori wrote: > >>On 01/20/2011 09:35 AM, Michael S. Tsirkin wrote: > >>>When MSI is off, each interrupt needs to be bounced thr

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-21 Thread Michael S. Tsirkin
On Thu, Jan 20, 2011 at 06:35:46PM -0700, Alex Williamson wrote: > On Thu, 2011-01-20 at 18:23 -0600, Anthony Liguori wrote: > > On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote: > > > On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony Liguori wrote: > > > > > >> On 01/20/2011 09:35 AM, Michael

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Markus Armbruster
Gerd Hoffmann writes: > On 01/20/11 20:39, Anthony Liguori wrote: >> On 01/20/2011 02:44 AM, Gerd Hoffmann wrote: >>> Hi, >>> For (2), you cannot use bus=X,addr=Y because it makes assumptions about the PCI topology which may change in newer -M pc's. >>> >>> Why should the PCI topology f

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> By the way, we don't have a QEMUState but instead use globals. > > /me wants to underline this. > > IMO it is absolutely pointless to worry about ways to pass around > kvm_state. There never ever will be a serious need for that. > > We can stick with the curren

Re: [Qemu-devel] [PATCH 3/3] make path_combine() especially for filenames, not URLs

2011-01-21 Thread Kevin Wolf
Am 12.01.2011 11:57, schrieb Michael Tokarev: > Currently the two routines tries to "understand" and skip : > prefix in path arguments are path_combine() and path_is_absolute() > (the latter isn't used anywhere but in the former). This is wrong, > since notion of absolute path is, at least, protoc

[Qemu-devel] [PATCH 3/5] spitz: make sl-nand emulation use qdev infrastructure

2011-01-21 Thread Dmitry Eremin-Solenikov
Switch sl-nand emulation to use qdev and vmstate. Also drop ecc_get/_put functions as sl-nand was the only user of that code. Signed-off-by: Dmitry Eremin-Solenikov --- hw/ecc.c | 27 +++- hw/flash.h |3 +- hw/onenand.c |1 + hw/spitz.c | 97 ++

[Qemu-devel] [PATCH 5/5] pxa2xx_gpio: switch to using qdev

2011-01-21 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/gumstix.c |4 +- hw/pxa.h | 10 +--- hw/pxa2xx.c |4 +- hw/pxa2xx_gpio.c | 151 ++ hw/spitz.c | 34 ++-- hw/tosa.c| 12 ++-- 6 files changed, 102

[Qemu-devel] [PATCH 4/5] spitz: make spitz-keyboard to use qdev infrastructure

2011-01-21 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/spitz.c | 127 ++-- 1 files changed, 72 insertions(+), 55 deletions(-) diff --git a/hw/spitz.c b/hw/spitz.c index c69a121..5f95bab 100644 --- a/hw/spitz.c +++ b/hw/spitz.c @@ -219,11 +219,10 @@

[Qemu-devel] [ARM] Contributing tests for Neon

2011-01-21 Thread Christophe Lyon
Hi all, I have developed some tests for ARM-Neon in the form of C sources files calling ARM Neon intrinsics, and comparing the results of the resulting program with a known reference (eg execution on actual CPU) shows if the execution engine is follows the spec. These tests currently represent

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-21 Thread Markus Armbruster
Anthony Liguori writes: > On 01/20/2011 11:12 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >> >>> On 01/18/2011 02:16 PM, Markus Armbruster wrote: >>> The problem: you want to do serious scalability testing (1000s of VMs) of your management stack. If each guest

Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-21 Thread Kevin Wolf
Am 19.01.2011 18:02, schrieb Christoph Hellwig: > Extend the change_cb callback with a reason argument, and use it > to tell drivers about size changes. > > Signed-off-by: Christoph Hellwig > > Index: qemu/block.c > === > --- qemu.o

[Qemu-devel] Re: [PATCH] pci/pcie: make pci_find_device() ARI aware.

2011-01-21 Thread Isaku Yamahata
On Thu, Jan 20, 2011 at 04:15:48PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 20, 2011 at 03:57:39PM +0900, Isaku Yamahata wrote: > > make pci_find_device() ARI aware. > > > > Signed-off-by: Isaku Yamahata > > --- > > hw/pci.c |7 +++ > > 1 files changed, 7 insertions(+), 0 deletions

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-21 Thread Daniel P. Berrange
On Thu, Jan 20, 2011 at 01:50:33PM -0600, Anthony Liguori wrote: > On 01/20/2011 11:12 AM, Markus Armbruster wrote: > >Anthony Liguori writes: > > > >>On 01/18/2011 02:16 PM, Markus Armbruster wrote: > >>>The problem: you want to do serious scalability testing (1000s of VMs) > >>>of your managemen

[Qemu-devel] [PATCH] audio: consolidate audio_init()

2011-01-21 Thread Isaku Yamahata
consolidate audio_init() and remove references to shoundhw. Cc: Blue Swirl Signed-off-by: Isaku Yamahata --- arch_init.c | 35 ++- arch_init.h |1 + hw/mips_jazz.c | 24 ++-- hw/mips_malta.c | 23 ++- hw/

[Qemu-devel] [PATCH] mips_fulong: remove bogus HAS_AUDIO

2011-01-21 Thread Isaku Yamahata
remove bogus HAS_AUDIO according to 738012bec4c67e697e766edadab3f522c552a04d. Cc: Blue Swirl Cc: Huacai Chen Cc: Aurelien Jarno Signed-off-by: Isaku Yamahata --- hw/mips_fulong2e.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/mips_fulong2e.c b/hw/mips_fulong2

Re: [Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY removable bit

2011-01-21 Thread Stefan Hajnoczi
On Tue, Jan 18, 2011 at 12:06 PM, Stefan Hajnoczi wrote: > On Tue, Jan 18, 2011 at 11:39 AM, Kevin Wolf wrote: >> Am 18.01.2011 11:10, schrieb Stefan Hajnoczi: >>> Provide the "removable" qdev property bit to override the SCSI INQUIRY >>> removable (RMB) bit for non-CDROM devices.  This will be u

[Qemu-devel] [PATCH v3 3/4] usb-msd: Propagate removable bit to SCSI device

2011-01-21 Thread Stefan Hajnoczi
USB Mass Storage Devices sometimes have the RMB (removable) bit set in the SCSI INQUIRY response. Thumbdrives tend to have the bit set whereas hard disks do not. Operating systems differentiate between removable devices and fixed devices. Under Linux, the anaconda installer looks for removable d

[Qemu-devel] [PATCH] monitor: use after free in do_wav_capture()

2011-01-21 Thread Isaku Yamahata
use after free in do_wav_capture() on the error path. Signed-off-by: Isaku Yamahata --- monitor.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index d291158..cab5f20 100644 --- a/monitor.c +++ b/monitor.c @@ -2511,6 +2511,7 @@ static void do_wav_

[Qemu-devel] [PATCH v3 1/4] scsi-disk: Allow overriding SCSI INQUIRY removable bit

2011-01-21 Thread Stefan Hajnoczi
Provide the "removable" qdev property bit to override the SCSI INQUIRY removable (RMB) bit for non-CDROM devices. This will be used by USB Mass Storage Devices, which sometimes have this guest-visible bit set and sometimes do not. They therefore requires a means for user configuration. Signed-of

[Qemu-devel] [PATCH v3 4/4] docs: Document scsi-disk and usb-storage removable parameter

2011-01-21 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- docs/qdev-device-use.txt | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index f2f9b75..e43 100644 --- a/docs/qdev-device-use.txt +++ b/docs/qdev-device-use.txt @@ -80,

[Qemu-devel] [PATCH v3 2/4] scsi: Allow SCSI devices to override the removable bit

2011-01-21 Thread Stefan Hajnoczi
Some SCSI devices may wish to override the removable bit. Add support for a qdev property on the SCSI device. Signed-off-by: Stefan Hajnoczi --- hw/pci-hotplug.c |2 +- hw/scsi-bus.c|8 ++-- hw/scsi.h|3 ++- hw/usb-msd.c |2 +- 4 files changed, 10 insertions(

[Qemu-devel] [PATCH v3 0/4] usb-msd: Add usb-storage, removable=on|off property

2011-01-21 Thread Stefan Hajnoczi
Allow overriding the SCSI INQUIRY removable (RMB) bit for scsi-disk and usb-msd devices. In particular this addresses the problem that some usb-msd devices have the bit set while other do not have it set. Now the user can choose and get desired guest behavior. qemu -usb -drive if=none,file=

Re: [Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY removable bit

2011-01-21 Thread Kevin Wolf
Am 21.01.2011 11:45, schrieb Stefan Hajnoczi: > On Tue, Jan 18, 2011 at 12:06 PM, Stefan Hajnoczi wrote: >> On Tue, Jan 18, 2011 at 11:39 AM, Kevin Wolf wrote: >>> Am 18.01.2011 11:10, schrieb Stefan Hajnoczi: Provide the "removable" qdev property bit to override the SCSI INQUIRY remova

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Pierre Riteau
On 21 janv. 2011, at 10:16, Kevin Wolf wrote: > Am 19.01.2011 15:59, schrieb Pierre Riteau: >> b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return >> value of bdrv_write and aborts migration when it fails. However, if the >> size of the block device to migrate is not a multiple of

[Qemu-devel] [PATCH v2] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Pierre Riteau
b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return value of bdrv_write and aborts migration when it fails. However, if the size of the block device to migrate is not a multiple of BLOCK_SIZE (currently 1 MB), the last bdrv_write will fail with -EIO. Fixed by calling bdrv_write wi

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Kevin Wolf
Am 21.01.2011 12:38, schrieb Pierre Riteau: > On 21 janv. 2011, at 10:16, Kevin Wolf wrote: > >> Am 19.01.2011 15:59, schrieb Pierre Riteau: >>> b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return >>> value of bdrv_write and aborts migration when it fails. However, if the >>> size

[Qemu-devel] Re: [PATCH v2] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Kevin Wolf
Am 21.01.2011 12:42, schrieb Pierre Riteau: > b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return > value of bdrv_write and aborts migration when it fails. However, if the > size of the block device to migrate is not a multiple of BLOCK_SIZE > (currently 1 MB), the last bdrv_write

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Yoshiaki Tamura
2011/1/21 Pierre Riteau : > Le 20 janv. 2011 à 17:18, Yoshiaki Tamura a > écrit : > >> 2011/1/20 Pierre Riteau : >>> On 20 janv. 2011, at 03:06, Yoshiaki Tamura wrote: >>> 2011/1/19 Pierre Riteau : > b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return > value of bdrv

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Yoshiaki Tamura
2011/1/21 Kevin Wolf : > Am 21.01.2011 09:08, schrieb Pierre Riteau: >> Le 20 janv. 2011 à 17:18, Yoshiaki Tamura a >> écrit : >> >>> 2011/1/20 Pierre Riteau : On 20 janv. 2011, at 03:06, Yoshiaki Tamura wrote: > 2011/1/19 Pierre Riteau : >> b02bea3a85cc939f09aa674a3f1e4f36d418c

[Qemu-devel] Re: [PATCH 0/5] -drive/drive_add fixes

2011-01-21 Thread Kevin Wolf
Am 17.01.2011 19:31, schrieb Markus Armbruster: > Note: PATCH 3/5 makes -drive reject duplicate definitions instead of > ignoring all but the first silently. If this isn't sufficiently > bug-compatible for you, we need to talk. > > Markus Armbruster (5): > blockdev: Fix error message for invali

[Qemu-devel] Re: [PATCH v3 0/4] usb-msd: Add usb-storage, removable=on|off property

2011-01-21 Thread Kevin Wolf
Am 21.01.2011 12:00, schrieb Stefan Hajnoczi: > Allow overriding the SCSI INQUIRY removable (RMB) bit for scsi-disk and > usb-msd > devices. In particular this addresses the problem that some usb-msd devices > have the bit set while other do not have it set. Now the user can choose and > get des

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Kevin Wolf
Am 21.01.2011 13:15, schrieb Yoshiaki Tamura: > 2011/1/21 Pierre Riteau : >> Le 20 janv. 2011 à 17:18, Yoshiaki Tamura a >> écrit : >> >>> 2011/1/20 Pierre Riteau : On 20 janv. 2011, at 03:06, Yoshiaki Tamura wrote: > 2011/1/19 Pierre Riteau : >> b02bea3a85cc939f09aa674a3f1e4f36

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Yoshiaki Tamura
2011/1/21 Kevin Wolf : > Am 21.01.2011 13:15, schrieb Yoshiaki Tamura: >> 2011/1/21 Pierre Riteau : >>> Le 20 janv. 2011 à 17:18, Yoshiaki Tamura a >>> écrit : >>> 2011/1/20 Pierre Riteau : > On 20 janv. 2011, at 03:06, Yoshiaki Tamura wrote: > >> 2011/1/19 Pierre Riteau : >>

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Pierre Riteau
On 21 janv. 2011, at 13:36, Yoshiaki Tamura wrote: > 2011/1/21 Kevin Wolf : >> Am 21.01.2011 13:15, schrieb Yoshiaki Tamura: >>> 2011/1/21 Pierre Riteau : Le 20 janv. 2011 à 17:18, Yoshiaki Tamura a écrit : > 2011/1/20 Pierre Riteau : >> On 20 janv. 2011, at 03:06, Yoshia

Re: [Spice-devel] [Qemu-devel] usb redirection status report

2011-01-21 Thread Hans de Goede
Hi, On 01/20/2011 09:11 PM, David Mansfield wrote: H i, On 01/20/2011 12:27 PM, Christoph Hellwig wrote: On Wed, Jan 19, 2011 at 07:15:47PM +0100, Hans de Goede wrote: Hi All, As most of you know I'm working on usb redirection (making client usb devices accessible in guests over the network)

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-21 Thread Alex Williamson
On Fri, 2011-01-21 at 11:55 +0200, Michael S. Tsirkin wrote: > On Thu, Jan 20, 2011 at 06:35:46PM -0700, Alex Williamson wrote: > > On Thu, 2011-01-20 at 18:23 -0600, Anthony Liguori wrote: > > > On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote: > > > > On Thu, Jan 20, 2011 at 09:43:57AM -0600, Ant

Re: [Spice-devel] [Qemu-devel] usb redirection status report

2011-01-21 Thread Alexander Graf
On 21.01.2011, at 14:23, Hans de Goede wrote: > Hi, > > On 01/20/2011 09:11 PM, David Mansfield wrote: >>> H >>> i, >>> >>> On 01/20/2011 12:27 PM, Christoph Hellwig wrote: On Wed, Jan 19, 2011 at 07:15:47PM +0100, Hans de Goede wrote: > Hi All, > > As most of you know I'm wor

RE: [Qemu-devel] [PATCH] target-arm: Fix loading of scalar value forNeon multiply-by-scalar

2011-01-21 Thread Schildbach, Wolfgang
> -Original Message- > From: qemu-devel-bounces+wschi=dolby@nongnu.org > [mailto:qemu-devel-bounces+wschi=dolby@nongnu.org] On > Behalf Of Peter Maydell > Sent: Wednesday, January 19, 2011 11:30 AM > To: qemu-devel@nongnu.org > Cc: Christophe Lyon; patc...@linaro.org > Subject: [Q

Re: [Spice-devel] [Qemu-devel] usb redirection status report

2011-01-21 Thread Gerd Hoffmann
Hi, Unfortunately there has been little response to this patch set, so I've no idea when it will get merged. (this seems to be the story with a lot of qemu patch sets here on the list, like Gerd's usb descriptor rehandling patches, maybe we need to review how qemu's patch merging processes wo

Re: [Spice-devel] [Qemu-devel] usb redirection status report

2011-01-21 Thread Alexander Graf
On 21.01.2011, at 14:33, Gerd Hoffmann wrote: > Hi, > >>> Unfortunately there has been little response to this patch set, so >>> I've no idea when it will get merged. >>> >>> (this seems to be the story with a lot of qemu patch sets here on >>> the list, like Gerd's usb descriptor rehandling p

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-21 Thread Michael S. Tsirkin
On Fri, Jan 21, 2011 at 06:19:13AM -0700, Alex Williamson wrote: > On Fri, 2011-01-21 at 11:55 +0200, Michael S. Tsirkin wrote: > > On Thu, Jan 20, 2011 at 06:35:46PM -0700, Alex Williamson wrote: > > > On Thu, 2011-01-20 at 18:23 -0600, Anthony Liguori wrote: > > > > On 01/20/2011 10:07 AM, Michae

Re: [Qemu-devel] [PATCH] target-arm: Fix loading of scalar value forNeon multiply-by-scalar

2011-01-21 Thread Peter Maydell
On 21 January 2011 13:32, Schildbach, Wolfgang wrote: > FWIW, on the two test cases that I have, this patch (together with > Christophe's) does not improve behaviour (see > https://bugs.launchpad.net/bugs/702885). Hrm. Can you attached the compiled ARM binaries to that bug report, to save me the

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Yoshiaki Tamura
2011/1/21 Pierre Riteau : > On 21 janv. 2011, at 13:36, Yoshiaki Tamura wrote: > >> 2011/1/21 Kevin Wolf : >>> Am 21.01.2011 13:15, schrieb Yoshiaki Tamura: 2011/1/21 Pierre Riteau : > Le 20 janv. 2011 à 17:18, Yoshiaki Tamura > a écrit : > >> 2011/1/20 Pierre Riteau : >>

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Kevin Wolf
Am 21.01.2011 14:59, schrieb Yoshiaki Tamura: > 2011/1/21 Pierre Riteau : >> On 21 janv. 2011, at 13:36, Yoshiaki Tamura wrote: >> >>> 2011/1/21 Kevin Wolf : Am 21.01.2011 13:15, schrieb Yoshiaki Tamura: > 2011/1/21 Pierre Riteau : >> Le 20 janv. 2011 à 17:18, Yoshiaki Tamura >>

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Pierre Riteau
On 21 janv. 2011, at 14:59, Yoshiaki Tamura wrote: > 2011/1/21 Pierre Riteau : >> On 21 janv. 2011, at 13:36, Yoshiaki Tamura wrote: >> >>> 2011/1/21 Kevin Wolf : Am 21.01.2011 13:15, schrieb Yoshiaki Tamura: > 2011/1/21 Pierre Riteau : >> Le 20 janv. 2011 à 17:18, Yoshiaki Tamura >

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Yoshiaki Tamura
2011/1/21 Kevin Wolf : > Am 21.01.2011 14:59, schrieb Yoshiaki Tamura: >> 2011/1/21 Pierre Riteau : >>> On 21 janv. 2011, at 13:36, Yoshiaki Tamura wrote: >>> 2011/1/21 Kevin Wolf : > Am 21.01.2011 13:15, schrieb Yoshiaki Tamura: >> 2011/1/21 Pierre Riteau : >>> Le 20 janv. 2011 à

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Yoshiaki Tamura
2011/1/21 Pierre Riteau : > On 21 janv. 2011, at 14:59, Yoshiaki Tamura wrote: > >> 2011/1/21 Pierre Riteau : >>> On 21 janv. 2011, at 13:36, Yoshiaki Tamura wrote: >>> 2011/1/21 Kevin Wolf : > Am 21.01.2011 13:15, schrieb Yoshiaki Tamura: >> 2011/1/21 Pierre Riteau : >>> Le 20 jan

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Pierre Riteau
On 21 janv. 2011, at 15:21, Yoshiaki Tamura wrote: > 2011/1/21 Pierre Riteau : >> On 21 janv. 2011, at 14:59, Yoshiaki Tamura wrote: >> >>> 2011/1/21 Pierre Riteau : On 21 janv. 2011, at 13:36, Yoshiaki Tamura wrote: > 2011/1/21 Kevin Wolf : >> Am 21.01.2011 13:15, schrieb Yosh

[Qemu-devel] Re: [PATCH] pci/pcie: make pci_find_device() ARI aware.

2011-01-21 Thread Michael S. Tsirkin
On Fri, Jan 21, 2011 at 07:44:16PM +0900, Isaku Yamahata wrote: > On Thu, Jan 20, 2011 at 04:15:48PM +0200, Michael S. Tsirkin wrote: > > On Thu, Jan 20, 2011 at 03:57:39PM +0900, Isaku Yamahata wrote: > > > make pci_find_device() ARI aware. > > > > > > Signed-off-by: Isaku Yamahata > > > --- > >

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Yoshiaki Tamura
2011/1/21 Pierre Riteau : > On 21 janv. 2011, at 15:21, Yoshiaki Tamura wrote: > >> 2011/1/21 Pierre Riteau : >>> On 21 janv. 2011, at 14:59, Yoshiaki Tamura wrote: >>> 2011/1/21 Pierre Riteau : > On 21 janv. 2011, at 13:36, Yoshiaki Tamura wrote: > >> 2011/1/21 Kevin Wolf : >>

[Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions for the same drive

2011-01-21 Thread Kevin Wolf
Am 17.01.2011 19:31, schrieb Markus Armbruster: > For reasons lost in the mist of time, we silently ignore multiple > definitions for the same drive: > > $ qemu-system-x86_64 -nodefaults -vnc :1 -S -monitor stdio -drive > if=ide,index=1,file=tmp.qcow2 -drive if=ide,index=1,file=nonexistant >

Re: [Spice-devel] [Qemu-devel] usb redirection status report

2011-01-21 Thread Gerd Hoffmann
On 01/21/11 14:41, Alexander Graf wrote: On 21.01.2011, at 14:33, Gerd Hoffmann wrote: Hi, Unfortunately there has been little response to this patch set, so I've no idea when it will get merged. (this seems to be the story with a lot of qemu patch sets here on the list, like Gerd's usb des

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-21 Thread Anthony Liguori
On 01/21/2011 03:48 AM, Michael S. Tsirkin wrote: On Thu, Jan 20, 2011 at 06:23:36PM -0600, Anthony Liguori wrote: On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote: On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony Liguori wrote: On 01/20/2011 09:35 AM, Michael S. Tsirkin wro

Re: [Qemu-devel] [PATCH] vhost: force vhost off for non-MSI guests

2011-01-21 Thread Anthony Liguori
On 01/21/2011 03:55 AM, Michael S. Tsirkin wrote: On Thu, Jan 20, 2011 at 06:35:46PM -0700, Alex Williamson wrote: On Thu, 2011-01-20 at 18:23 -0600, Anthony Liguori wrote: On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote: On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony Lig

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-21 Thread Anthony Liguori
On 01/21/2011 04:43 AM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 01:50:33PM -0600, Anthony Liguori wrote: On 01/20/2011 11:12 AM, Markus Armbruster wrote: Anthony Liguori writes: On 01/18/2011 02:16 PM, Markus Armbruster wrote: The problem: you want to

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-21 Thread Daniel P. Berrange
On Fri, Jan 21, 2011 at 08:43:20AM -0600, Anthony Liguori wrote: > On 01/21/2011 04:43 AM, Daniel P. Berrange wrote: > >On Thu, Jan 20, 2011 at 01:50:33PM -0600, Anthony Liguori wrote: > >>On 01/20/2011 11:12 AM, Markus Armbruster wrote: > >>>Anthony Liguori writes: > >>> > On 01/18/2011 02:1

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-21 Thread Pierre Riteau
On 21 janv. 2011, at 15:30, Yoshiaki Tamura wrote: > 2011/1/21 Pierre Riteau : >> On 21 janv. 2011, at 15:21, Yoshiaki Tamura wrote: >> >>> 2011/1/21 Pierre Riteau : On 21 janv. 2011, at 14:59, Yoshiaki Tamura wrote: > 2011/1/21 Pierre Riteau : >> On 21 janv. 2011, at 13:36, Yo

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-21 Thread Anthony Liguori
On 01/21/2011 04:38 AM, Markus Armbruster wrote: Anthony Liguori writes: On 01/20/2011 11:12 AM, Markus Armbruster wrote: Anthony Liguori writes: On 01/18/2011 02:16 PM, Markus Armbruster wrote: The problem: you want to do serious scalability testing (1000s

[Qemu-devel] [Bug 702885] Re: "Internal resource leak" error with ARM NEON vmull.s32 insn

2011-01-21 Thread Wolfgang Schildbach
** Attachment added: "Binary to reproduce bug" https://bugs.launchpad.net/qemu/+bug/702885/+attachment/1801849/+files/main.axf -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/702885 Title: "Inte

[Qemu-devel] Re: [PATCH v4 00/32] usb descriptor overhaul + more

2011-01-21 Thread Gerd Hoffmann
On 01/12/11 12:19, Gerd Hoffmann wrote: Hi, Here is a update of the usb descriptor patches and a bunch of improvements on top of that. This patch series features: [ ... ] The following changes since commit 05bf441eb69a813d3893174d54faa6afa8c0d39b: cris: Remove unused orig_flags (2011

Re: [Spice-devel] [Qemu-devel] usb redirection status report

2011-01-21 Thread Alexander Graf
On 21.01.2011, at 15:33, Gerd Hoffmann wrote: > On 01/21/11 14:41, Alexander Graf wrote: >> >> On 21.01.2011, at 14:33, Gerd Hoffmann wrote: >> >>> Hi, >>> > Unfortunately there has been little response to this patch set, > so I've no idea when it will get merged. > > (this se

[Qemu-devel] [Bug 705931] Re: make ui sdl error 1 on git devel

2011-01-21 Thread qalbi mr
** Attachment added: "konsole.txt" https://bugs.launchpad.net/bugs/705931/+attachment/1801911/+files/konsole.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/705931 Title: make ui sdl error 1

[Qemu-devel] [Bug 705931] [NEW] make ui sdl error 1 on git devel

2011-01-21 Thread qalbi mr
Public bug reported: after clone git devel, try compile on slackware 13.1 32 bit machine got error: ui/sdl.c:809:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token ui/sdl.c:815:36: error: expected ')' before '*' token /usr/include/X11/Xlib.h:3575:14: error: old-style par

Re: [Qemu-devel] [PATCH 4/5] spitz: make spitz-keyboard to use qdev infrastructure

2011-01-21 Thread Markus Armbruster
Does this patch preserve the screen rotation feature?

[Qemu-devel] [Bug 702885] Re: "Internal resource leak" error with ARM NEON vmull.s32 insn

2011-01-21 Thread Peter Maydell
That binary executes OK for me with no resource leak messages with: qemu master as of commit b646968336 http://patchwork.ozlabs.org/patch/79728/ http://patchwork.ozlabs.org/patch/79581/ (i386 host.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

[Qemu-devel] Re: [RFC][PATCH v6 03/23] Make qemu timers available for tools

2011-01-21 Thread Jes Sorensen
On 01/17/11 14:14, Michael Roth wrote: > diff --git a/qemu-ioh.c b/qemu-ioh.c > index cc71470..001e7a2 100644 > --- a/qemu-ioh.c > +++ b/qemu-ioh.c > @@ -22,7 +22,11 @@ > * THE SOFTWARE. > */ > #include "qemu-ioh.h" > +#include "qemu-char.h" > #include "qlist.h" > +#ifdef CONFIG_EVENTFD > +#i

Re: [Qemu-devel] [PATCH 5/5] pxa2xx_gpio: switch to using qdev

2011-01-21 Thread Markus Armbruster
Dmitry Eremin-Solenikov writes: > Signed-off-by: Dmitry Eremin-Solenikov > --- > hw/gumstix.c |4 +- > hw/pxa.h | 10 +--- > hw/pxa2xx.c |4 +- > hw/pxa2xx_gpio.c | 151 > ++ > hw/spitz.c | 34 ++--

Re: [Qemu-devel] [PATCH 1/5] SharpSL scoop device - convert to qdev

2011-01-21 Thread Markus Armbruster
Dmitry Eremin-Solenikov writes: > Convert SharpSL scoop device to qdev, remove lots of supporting code, as > lot of init and gpio related things can now be done automagically. Bonus: conversion to vmstate. I don't know the device, but the conversion looks sane to me. Same for 2/5 and 3/5.

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Blue Swirl
On Fri, Jan 21, 2011 at 8:46 AM, Gerd Hoffmann wrote: >  Hi, > >> By the way, we don't have a QEMUState but instead use globals. > > /me wants to underline this. > > IMO it is absolutely pointless to worry about ways to pass around kvm_state. >  There never ever will be a serious need for that. >

[Qemu-devel] Re: [RFC][PATCH v6 07/23] virtagent: base server definitions

2011-01-21 Thread Jes Sorensen
> diff --git a/virtagent-server.h b/virtagent-server.h > new file mode 100644 > index 000..9f68921 > --- /dev/null > +++ b/virtagent-server.h > @@ -0,0 +1,34 @@ > +/* > + * virt-agent - host/guest RPC daemon functions > + * > + * Copyright IBM Corp. 2010 > + * > + * Authors: > + * Michael Roth

[Qemu-devel] Re: [PATCH] pci/pcie: make pci_find_device() ARI aware.

2011-01-21 Thread Isaku Yamahata
On Fri, Jan 21, 2011 at 04:29:41PM +0200, Michael S. Tsirkin wrote: > On Fri, Jan 21, 2011 at 07:44:16PM +0900, Isaku Yamahata wrote: > > On Thu, Jan 20, 2011 at 04:15:48PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Jan 20, 2011 at 03:57:39PM +0900, Isaku Yamahata wrote: > > > > make pci_find_d

[Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-21 Thread Jes Sorensen
On 01/17/11 14:15, Michael Roth wrote: > Add RPC to retrieve a guest file. This interface is intended > for smaller reads like peeking at logs and /proc and such. > > Signed-off-by: Michael Roth > --- > virtagent-server.c | 59 > > 1 files

[Qemu-devel] Re: [RFC][PATCH v6 09/23] virtagent: add agent_viewfile qmp/hmp command

2011-01-21 Thread Jes Sorensen
On 01/17/11 14:15, Michael Roth wrote: > Utilize the getfile RPC to provide a means to view text files in the > guest. Getfile can handle binary files as well but we don't advertise > that here due to the special handling requiring to store it and provide > it back to the user (base64 encoding it f

Re: [Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-21 Thread Markus Armbruster
Anthony Liguori writes: > On 01/21/2011 04:38 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >> >>> On 01/20/2011 11:12 AM, Markus Armbruster wrote: >>> Anthony Liguori writes: > On 01/18/2011 02:16 PM, Markus Armbruster wrote: > >

[Qemu-devel] [PATCH 4/5] spitz: make spitz-keyboard to use qdev infrastructure

2011-01-21 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/spitz.c | 127 ++-- 1 files changed, 72 insertions(+), 55 deletions(-) diff --git a/hw/spitz.c b/hw/spitz.c index c69a121..e3ece05 100644 --- a/hw/spitz.c +++ b/hw/spitz.c @@ -219,11 +219,10 @@

[Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions for the same drive

2011-01-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.01.2011 19:31, schrieb Markus Armbruster: >> For reasons lost in the mist of time, we silently ignore multiple >> definitions for the same drive: >> >> $ qemu-system-x86_64 -nodefaults -vnc :1 -S -monitor stdio -drive >> if=ide,index=1,file=tmp.qcow2 -drive if=ide

[Qemu-devel] [PATCH 5/5] pxa2xx_gpio: switch to using qdev

2011-01-21 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/gumstix.c |4 +- hw/pxa.h | 10 +--- hw/pxa2xx.c |4 +- hw/pxa2xx_gpio.c | 150 ++ hw/spitz.c | 34 ++-- hw/tosa.c| 12 ++-- 6 files changed, 103

[Qemu-devel] [PATCH v3 5/5] SPARC: Add asr17 register support

2011-01-21 Thread Fabien Chouteau
This register is activated by CPU_FEATURE_ASR17 in the feature field. Signed-off-by: Fabien Chouteau --- target-sparc/cpu.h |1 + target-sparc/helper.c|3 ++- target-sparc/translate.c | 11 +++ 3 files changed, 14 insertions(+), 1 deletions(-) diff --git a/target-spa

[Qemu-devel] [PATCH v3 3/5] SPARC: Emulation of GRLIB APB UART

2011-01-21 Thread Fabien Chouteau
This device exposes one parameter: - chardev (ptr) : Pointer to a qemu character device Emulation of GrLib devices is base on the GRLIB IP Core User's Manual: http://www.gaisler.com/products/grlib/grip.pdf Signed-off-by: Fabien Chouteau --- hw/grlib.h | 23 ++ hw/grlib_apbuart.c

[Qemu-devel] [PATCH v3 0/5][RFC] New SPARC machine: Leon3

2011-01-21 Thread Fabien Chouteau
Hello Qemu-devel, Here is the third version of Leon3 emulation patch-set. Modifications since v2: - Tracepoints - DEFINE_PROP_* macros - New interface to trigger interrupts on Leon3 (set_pil_in:leon3.c) - Minor reformating Please feel free to comment. Regards, -

[Qemu-devel] [PATCH v3 2/5] SPARC: Emulation of GRLIB IRQMP

2011-01-21 Thread Fabien Chouteau
This device exposes two parameters: - set_pil_in(ptr) : A function to set the pil_in of the SPARC CPU - set_pil_in_opaque (ptr) : Opaque argument of the set_pil_in function Emulation of GrLib devices is base on the GRLIB IP Core User's Manual: http://www.gaisler.com/products/grlib/grip.p

Re: [Qemu-devel] Re: [PATCH v4 00/32] usb descriptor overhaul + more

2011-01-21 Thread Aurelien Jarno
On Fri, Jan 21, 2011 at 04:00:47PM +0100, Gerd Hoffmann wrote: > On 01/12/11 12:19, Gerd Hoffmann wrote: >>Hi, >> >> Here is a update of the usb descriptor patches and a bunch of >> improvements on top of that. This patch series features: > > [ ... ] > >> The following changes since commit 05b

[Qemu-devel] [PATCH v3 1/5] SPARC: Emulation of GRLIB GPTimer

2011-01-21 Thread Fabien Chouteau
This device exposes three parameters: - frequency (uint32) : The system frequency - irq-line (uint32) : IRQ line number for the first timer (others use irq-line + 1, irq-line + 2...) - nr-timers (uint32) : Number of timers Emulation of GrLib devices is base on the GRLIB

[Qemu-devel] [PATCH v3 4/5] SPARC: Emulation of Leon3

2011-01-21 Thread Fabien Chouteau
Leon3 is an open-source VHDL System-On-Chip, well known in space industry (more information on http://www.gaisler.com). Leon3 is made of multiple components available in the GrLib VHDL library. Three devices are implemented: uart, timers and IRQ manager. You can find code for these peripherals in

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Jan Kiszka
On 2011-01-21 17:37, Blue Swirl wrote: > On Fri, Jan 21, 2011 at 8:46 AM, Gerd Hoffmann wrote: >> Hi, >> >>> By the way, we don't have a QEMUState but instead use globals. >> >> /me wants to underline this. >> >> IMO it is absolutely pointless to worry about ways to pass around kvm_state. >> The

[Qemu-devel] [PATCH] checkpatch: Fix bracing false positives on #else

2011-01-21 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- scripts/checkpatch.pl |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 55ef439..4fa06c0 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2536,7 +2536,8 @@ sub process {

[Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions for the same drive

2011-01-21 Thread Kevin Wolf
Am 21.01.2011 17:58, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 17.01.2011 19:31, schrieb Markus Armbruster: >>> For reasons lost in the mist of time, we silently ignore multiple >>> definitions for the same drive: >>> >>> $ qemu-system-x86_64 -nodefaults -vnc :1 -S -monitor stdi

[Qemu-devel] Re: [PATCH] checkpatch: Fix bracing false positives on #else

2011-01-21 Thread Blue Swirl
Thanks, applied. On Fri, Jan 21, 2011 at 5:19 PM, Jan Kiszka wrote: > Signed-off-by: Jan Kiszka > --- >  scripts/checkpatch.pl |    3 ++- >  1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 55ef439..4fa06c0 100755 > --- a/scr

Re: [Qemu-devel] [PATCH v3 2/4] scsi: Allow SCSI devices to override the removable bit

2011-01-21 Thread Markus Armbruster
Stefan Hajnoczi writes: > Some SCSI devices may wish to override the removable bit. Add support > for a qdev property on the SCSI device. I find this description a bit misleading. The qdev property is added in 1/4. Here, you merely extend scsi_bus_legacy_add_drive() to provide access to it.

[Qemu-devel] RE: [Bug 702885] Re: "Internal resource leak" error with ARM NEONvmull.s32 insn

2011-01-21 Thread Wolfgang Schildbach
Duh. I had missed the greater part of Christophe's patch (I am still having trouble with my mail client; applying patches off the list is manual for me). With both patches applied, indeed the bug filed on launchpad seems fixed. On my second test case, behaviour is much improved. Thanks much! - Wo

[Qemu-devel] Re: [RFC][PATCH v6 03/23] Make qemu timers available for tools

2011-01-21 Thread Michael Roth
On 01/21/2011 10:30 AM, Jes Sorensen wrote: On 01/17/11 14:14, Michael Roth wrote: diff --git a/qemu-ioh.c b/qemu-ioh.c index cc71470..001e7a2 100644 --- a/qemu-ioh.c +++ b/qemu-ioh.c @@ -22,7 +22,11 @@ * THE SOFTWARE. */ #include "qemu-ioh.h" +#include "qemu-char.h" #include "qlist.h"

  1   2   >