Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Stefan Hajnoczi
On Wed, Jan 19, 2011 at 1:12 AM, Jamie Lokier wrote: > Chunqiang Tang wrote: >> Moreover, using a host file system not only adds overhead, but >> also introduces data integrity issues. Specifically, if I/Os uses O_DSYNC, >> it may be too slow. If I/Os use O_DIRECT, it cannot guarantee data >> inte

[Qemu-devel] [PATCH 0/1] add spicevmc chardev

2011-01-19 Thread Alon Levy
In additional to the description in the patch, see following email for uses: http://lists.nongnu.org/archive/html/qemu-devel/2011-01/msg01208.html In particular it would/could be used for: current vdagent of spice uses this for mouse, copy paste proposed smartcard device for qemu uses this with

[Qemu-devel] [PATCH 1/1] spice: add chardev (v5)

2011-01-19 Thread Alon Levy
Adding a chardev backend for spice, where spice determines what to do with it based on the name attribute given during chardev creation. For usage by spice vdagent in conjunction with a properly named virtio-serial device, and future smartcard channel usage. Example usage: qemu -device virtio-ser

Re: [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: > event-tap function is called only when it is on, and requests sent > from device emulators. > > Signed-off-by: Yoshiaki Tamura > --- > block.c | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/block.c b/block

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: > event-tap controls when to start FT transaction, and provides proxy > functions to called from net/block devices. While FT transaction, it > queues up net/block requests, and flush them when the transaction gets > completed. > > Signed-off-by: Yoshi

Re: [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: > event-tap function is called only when it is on, and requests sent > from device emulators. > > Signed-off-by: Yoshiaki Tamura > --- > block.c | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/block.c b/block

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Gerd Hoffmann
On 01/18/11 18:09, Anthony Liguori wrote: On 01/18/2011 10:56 AM, Jan Kiszka wrote: The device model topology is 100% a hidden architectural detail. This is true for the sysbus, it is obviously not the case for PCI and similarly discoverable buses. There we have a guest-explorable topology th

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-19 Thread Jes Sorensen
On 01/18/11 21:39, Anthony Liguori wrote: > On 01/18/2011 02:36 PM, Jes Sorensen wrote: >> On 01/18/11 21:30, Anthony Liguori wrote: >>> On 01/18/2011 10:53 AM, Eric Blake wrote: And it does, via the toupper() added earlier in the series (and which has separately been pointed out

Re: [Qemu-devel] [V3 PATCH 5/8] virtio-9p: Create support in chroot environment

2011-01-19 Thread M. Mohan Kumar
Hi Blue Swirl, Thanks for your review comments. I will address these in my next version of patchset. M. Mohan Kumar On Tuesday 18 January 2011 10:38:21 pm Blue Swirl wrote: > On Tue, Jan 18, 2011 at 6:25 AM, M. Mohan Kumar wrote: > > Add both server & client side interfaces to create regu

Re: [Qemu-devel] [sparc] Floating point exception issue

2011-01-19 Thread Mateusz Loskot
On 18/01/11 21:51, Blue Swirl wrote: On Tue, Jan 18, 2011 at 6:00 PM, Mateusz Loskot wrote: On 18/01/11 17:36, Blue Swirl wrote: On Tue, Jan 18, 2011 at 3:27 PM, Mateusz Loskot wrote: Hi, Recently, I have reported mysterious issues on NetBSD 5.1 emulated on SPARC. The whole first thread

Re: [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-19 Thread Yoshiaki Tamura
2011/1/19 Kevin Wolf : > Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: >> event-tap function is called only when it is on, and requests sent >> from device emulators. >> >> Signed-off-by: Yoshiaki Tamura >> --- >>  block.c |   11 +++ >>  1 files changed, 11 insertions(+), 0 deletions(-) >>

[Qemu-devel] [PATCH 0/7] virtio-serial: Don't copy guest buf to host, flow control

2011-01-19 Thread Amit Shah
Hello, This series is now separated from the chardev flow control series. The virtio-serial code now does not copy over data from the guest to the host. It instead keeps track of how far we are in consuming the data and maintains this state. For flow control, when a user of the virtio-serial por

[Qemu-devel] [PATCH 2/7] virtio-console: Remove unnecessary braces

2011-01-19 Thread Amit Shah
Remove unnecessary braces around a case statement. Signed-off-by: Amit Shah --- hw/virtio-console.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index d7fe68b..d0b9354 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console

[Qemu-devel] [PATCH 3/7] virtio-serial-bus: separate out discard logic in a separate function

2011-01-19 Thread Amit Shah
Instead of combining flush logic into the discard case and not discard case, have one function doing discard case. This will help later when adding flow control logic to the do_flush_queued_data() function. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 47 +

[Qemu-devel] [PATCH 1/7] virtio-console: Factor out common init between console and generic ports

2011-01-19 Thread Amit Shah
The initialisation for generic ports and console ports is similar. Factor out the parts that are the same in a different function that can be called from each of the initfns. Signed-off-by: Amit Shah --- hw/virtio-console.c | 31 ++- 1 files changed, 14 insertions(+

[Qemu-devel] [PATCH 4/7] virtio-serial: Don't copy over guest buffer to host

2011-01-19 Thread Amit Shah
When the guest writes something to a host, we copied over the entire buffer first into the host and then processed it. Do away with that, it could result in a malicious guest causing a DoS on the host. Reported-by: Paul Brook Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 15 -

[Qemu-devel] [PATCH 5/7] virtio-serial: Let virtio-serial-bus know if all data was consumed

2011-01-19 Thread Amit Shah
The have_data() API to hand off guest data to apps using virtio-serial so far assumed all the data was consumed. Relax this assumption. Future commits will allow for incomplete writes. Signed-off-by: Amit Shah --- hw/virtio-console.c |4 ++-- hw/virtio-serial.h |7 --- 2 files chan

[Qemu-devel] [PATCH 6/7] virtio-serial: Add support for flow control

2011-01-19 Thread Amit Shah
This commit lets apps signal an incomplete write. When that happens, stop sending out any more data to the app and wait for it to unthrottle the port. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 49 +-- hw/virtio-serial.h | 17 ++

[Qemu-devel] [PATCH 7/7] virtio-serial: save/restore new fields in port struct

2011-01-19 Thread Amit Shah
The new fields that got added as part of not copying over the guest buffer to the host need to be saved/restored across migration. Do that and bump up the version number. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 42 -- 1 files changed, 40 i

[Qemu-devel] Missing roms/seabios/Makefile and roms/vgabios/Makefile

2011-01-19 Thread Mateusz Loskot
Hi, Running ./configure (under MinGW/MSYS) and symlink gives up trying to create links to non-existing Makefiles in roms/seabios/Makefile roms/vgabios/Makefile Quick fix is to remove those Makefiles from the FILES list: diff --git a/configure b/configure index d68f862..92e2527 100755 --- a/conf

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-19 Thread Yoshiaki Tamura
2011/1/19 Kevin Wolf : > Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: >> event-tap controls when to start FT transaction, and provides proxy >> functions to called from net/block devices.  While FT transaction, it >> queues up net/block requests, and flush them when the transaction gets >> complet

[Qemu-devel] [Bug 702885] Re: "Internal resource leak" error with ARM NEON vmull.s32 insn

2011-01-19 Thread Wolfgang Schildbach
This bug is fixed on HEAD in the qemu-meego tree (commit 8493a687d54e542ac4eec8b2f8326415edf37ec4 A) - Wolfgang -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/702885 Title: "Internal resource leak"

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Markus Armbruster
Anthony Liguori writes: > On 01/18/2011 10:56 AM, Jan Kiszka wrote: >> >>> The device model topology is 100% a hidden architectural detail. >>> >> This is true for the sysbus, it is obviously not the case for PCI and >> similarly discoverable buses. There we have a guest-explorable topology

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Markus Armbruster
Gerd Hoffmann writes: > On 01/18/11 18:09, Anthony Liguori wrote: >> On 01/18/2011 10:56 AM, Jan Kiszka wrote: >>> The device model topology is 100% a hidden architectural detail. >>> This is true for the sysbus, it is obviously not the case for PCI and >>> similarly discoverable buses. Ther

Re: [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-19 Thread Yoshiaki Tamura
2011/1/19 Kevin Wolf : > Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: >> event-tap function is called only when it is on, and requests sent >> from device emulators. >> >> Signed-off-by: Yoshiaki Tamura >> --- >>  block.c |   11 +++ >>  1 files changed, 11 insertions(+), 0 deletions(-) >>

Re: [Qemu-devel] [Bug 702885] Re: "Internal resource leak" error with ARM NEON vmull.s32 insn

2011-01-19 Thread Peter Maydell
On 19 January 2011 12:42, Wolfgang Schildbach <702...@bugs.launchpad.net> wrote: > This bug is fixed on HEAD in the qemu-meego tree (commit > 8493a687d54e542ac4eec8b2f8326415edf37ec4 > A) Note that the qemu-meego tree disables these warnings using an #ifdef, so even if the message is not printed

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Markus Armbruster
Anthony Liguori writes: > On 01/18/2011 09:43 AM, Jan Kiszka wrote: >> On 2011-01-18 16:04, Anthony Liguori wrote: >> >>> On 01/18/2011 08:28 AM, Jan Kiszka wrote: >>> On 2011-01-12 11:31, Jan Kiszka wrote: > Am 12.01.2011 11:22, Avi Kivity wrote: > >

[Qemu-devel] Re: [PATCH V5 2/4] nmi: make cpu-index argument optional

2011-01-19 Thread Luiz Capitulino
Sorry for the long delay on this one, in general looks good, I have just a few small comments. On Mon, 10 Jan 2011 17:27:51 +0800 Lai Jiangshan wrote: > When the argument "cpu-index" is not given, > then "nmi" command will inject NMI on all CPUs. Please, state that we're changing the human mon

[Qemu-devel] Re: [PATCH V5 3/4] qmp, nmi: convert do_inject_nmi() to QObject

2011-01-19 Thread Luiz Capitulino
On Mon, 10 Jan 2011 17:28:14 +0800 Lai Jiangshan wrote: > Make we can inject NMI via qemu-monitor-protocol. > We use "inject-nmi" for the qmp command name, the meaning is clearer. > > Signed-off-by: Lai Jiangshan > --- > diff --git a/hmp-commands.hx b/hmp-commands.hx > index a49fcd4..4db413d 1

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 14:04, schrieb Yoshiaki Tamura: >>> +static void event_tap_blk_flush(EventTapBlkReq *blk_req) >>> +{ >>> +BlockDriverState *bs; >>> + >>> +bs = bdrv_find(blk_req->device_name); >> >> Please store the BlockDriverState in blk_req. This code loops over all >> block devices and do

[Qemu-devel] [PATCH 2/5] qemu and qemu-xen: fix segfault on con_disconnect

2011-01-19 Thread Stefano Stabellini
The test on xendev->gnttabdev in con_disconnect is wrong: what differentiates the consoles is the dev number. Signed-off-by: Stefano Stabellini diff --git a/hw/xen_console.c b/hw/xen_console.c index d7099c4..0a2374c 100644 --- a/hw/xen_console.c +++ b/hw/xen_console.c @@ -258,7 +258,7 @@ static

Re: [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 14:16, schrieb Yoshiaki Tamura: > 2011/1/19 Kevin Wolf : >> Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: >>> event-tap function is called only when it is on, and requests sent >>> from device emulators. >>> >>> Signed-off-by: Yoshiaki Tamura >>> --- >>> block.c | 11 +++ >

[Qemu-devel] [Bug 704904] [NEW] No rule to make target ../libhw32/virtio.o

2011-01-19 Thread Mateusz Łoskot
Public bug reported: Building qemu from current git using 32-bit MinGW (installer from 2010-11-07) on Windows Vista (64-bit) fails with the following error: make[1]: *** No rule to make target `../libhw32/virtio.o', needed by `qemu.exe'. Stop. make: *** [subdir-i386-softmmu] Error 2 Here is my

RE: [Qemu-devel] [Bug 702885] Re: "Internal resource leak" error withARM NEON vmull.s32 insn

2011-01-19 Thread Schildbach, Wolfgang
> From: qemu-devel-bounces+wschi=dolby@nongnu.org > [mailto:qemu-devel-bounces+wschi=dolby@nongnu.org] On > Behalf Of Peter Maydell > Sent: Wednesday, January 19, 2011 5:16 AM > To: Bug 702885 > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [Bug 702885] Re: "Internal resource > l

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-19 Thread Christophe Lyon
Here is an updated patch which will hopefully not be mangled by my mailer. Fix garbage collection of temporaries in Neon emulation. Signed-off-by: Christophe Lyon --- target-arm/translate.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/target-arm/tr

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Chunqiang Tang
> > Doing both fault injection and verification together introduces some > > subtlety. For example, even under the random failure mode, two disk writes > > triggered by one VM-issued write must either fail together or succeed > > together. Otherwise, the truth image and the test image will dive

[Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-19 Thread Pierre Riteau
b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return value of bdrv_write and aborts migration when it fails. However, if the size of the block device to migrate is not a multiple of BLOCK_SIZE (currently 1 MB), the last bdrv_write will fail with -EIO. Fixed by calling bdrv_write wi

Re: [Qemu-devel] [PULL] piix, pci, qdev

2011-01-19 Thread Christoph Hellwig
> > pci: fix migration path for devices behind bridges This patch breaks starting qemu for me on 32-bit x86 with the following assert: qemu-system-x86_64: savevm.c:1129: register_savevm_live: Assertion `!se->compat || se->instance_id == 0' failed. my qemu command line is: /opt/qemu/bin/qe

Re: [Qemu-devel] [PULL] piix, pci, qdev

2011-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2011 at 04:14:48PM +0100, Christoph Hellwig wrote: > > > pci: fix migration path for devices behind bridges > > This patch breaks starting qemu for me on 32-bit x86 with the following > assert: > > qemu-system-x86_64: savevm.c:1129: register_savevm_live: Assertion > `!se->c

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Chunqiang Tang
> >> Moreover, using a host file system not only adds overhead, but > >> also introduces data integrity issues. Specifically, if I/Os uses O_DSYNC, > >> it may be too slow. If I/Os use O_DIRECT, it cannot guarantee data > >> integrity in the event of a host crash. See > >> http://lwn.net/Articles/

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Christoph Hellwig
On Wed, Jan 19, 2011 at 10:17:47AM -0500, Chunqiang Tang wrote: > Thank both of you for the explanation, which is very helpful to me. With > FVD's capability of eliminating the host file system and storing the image > on a logical volume, then perhaps we can always use O_DSYNC, because there > i

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-19 Thread Christoph Hellwig
On Mon, Jan 17, 2011 at 06:36:15PM +0100, Kevin Wolf wrote: > > +.args_type = "id:s,size:l", > > size should be 'o' instead of 'l'. The latter may be too small on 32 bit > hosts and doesn't support convenient suffixes: o actually fails for 2GB or more for me: (qemu) resize scratch 2047

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 16:35, schrieb Christoph Hellwig: > On Mon, Jan 17, 2011 at 06:36:15PM +0100, Kevin Wolf wrote: >>> +.args_type = "id:s,size:l", >> >> size should be 'o' instead of 'l'. The latter may be too small on 32 bit >> hosts and doesn't support convenient suffixes: > > o actually fa

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Christoph Hellwig
On Fri, Jan 14, 2011 at 03:56:00PM -0500, Chunqiang Tang wrote: > P2) Overhead of storing an image on a host file system. Specifically, a > RAW image stored on ext3 is 50-63% slower than a RAW image stored on a raw > partition. Sorry, benchmarking this against ext3 really doesn't matter. Benchm

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-19 Thread Christoph Hellwig
On Wed, Jan 19, 2011 at 04:49:04PM +0100, Kevin Wolf wrote: > > (qemu) resize scratch 2047 > > resize scratch 2047 > > (qemu) > > (qemu) resize scrarch 2048 > > resize scrarch 2048 > > invalid size > > > > for l these worked fine. > > Hm, yeah, 'o' uses ssize_t instead of int64_t, so it's brok

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-19 Thread Kevin Wolf
Am 19.01.2011 16:52, schrieb Christoph Hellwig: > On Wed, Jan 19, 2011 at 04:49:04PM +0100, Kevin Wolf wrote: >>> (qemu) resize scratch 2047 >>> resize scratch 2047 >>> (qemu) >>> (qemu) resize scrarch 2048 >>> resize scrarch 2048 >>> invalid size >>> >>> for l these worked fine. >> >> Hm, yeah,

[Qemu-devel] [PATCH] Support saturation with shift=0.

2011-01-19 Thread Christophe Lyon
This patch fixes corner-case saturations, when the target range is zero. It merely removes the guard against (sh == 0), and makes: __ssat(0x87654321, 1) return 0x and set the saturation flag __usat(0x87654321, 0) return 0 and set the saturation flag Signed-off-by: Christophe Lyon --- ta

Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-19 Thread Christoph Hellwig
On Wed, Jan 19, 2011 at 05:01:19PM +0100, Kevin Wolf wrote: > Oh, okay, then it makes perfect sense. We should fix 'o' then to use > int64_t. The patch below should do it. > > strtosz (which is used by 'o') has the same problem in git master. > There's a fix by Jes, so be sure to test this on the

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Chunqiang Tang
> It's something filesystems have to deal with. Real storage is getting > increasingly virtualized. While this didn't matter for the real high > end storage which has been doing this for a long time it's getting more > and more exposed to the filesystem. That includes LVM layouts and > thinly pr

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Christoph Hellwig
On Wed, Jan 19, 2011 at 11:21:07AM -0500, Chunqiang Tang wrote: > Yes, a fundamental and optimal solution would be changing guest file > systems, but it would take a much much longer route to introduce > virtualization awareness into all guest file systems and its also requires > changing the in

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 07:15 AM, Markus Armbruster wrote: So they interact with KVM (need kvm_state), and they interact with the emulated PCI bus. Could you elaborate on the fundamental difference between the two interactions that makes you choose the (hypothetical) KVM bus over the PCI bus as device par

Re: [Qemu-devel] [PATCH] Support saturation with shift=0.

2011-01-19 Thread Peter Maydell
On 19 January 2011 16:10, Christophe Lyon wrote: > > This patch fixes corner-case saturations, when the target range is > zero. It merely removes the guard against (sh == 0), and makes: > __ssat(0x87654321, 1) return 0x and set the saturation flag did you mean __ssat(0x87654321, 0) here?

[Qemu-devel] [PATCH 1/3] block: add resize monitor command

2011-01-19 Thread Christoph Hellwig
Add a monitor command that allows resizing of block devices while qemu is running. It uses the existing bdrv_truncate method already used by qemu-img to do it's work. Compared to qemu-img the size parsing is very simplicistic, but I think having a properly numering object is more useful for non-h

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Daniel P. Berrange
On Wed, Jan 19, 2011 at 10:53:30AM -0600, Anthony Liguori wrote: > On 01/19/2011 03:48 AM, Gerd Hoffmann wrote: > >On 01/18/11 18:09, Anthony Liguori wrote: > >>On 01/18/2011 10:56 AM, Jan Kiszka wrote: > >>> > The device model topology is 100% a hidden architectural detail. > >>>This is true f

[Qemu-devel] [PATCH 3/3] virtio-blk: tell the guest about size changes

2011-01-19 Thread Christoph Hellwig
Raise a config change interrupt when the size changed. This allows virtio-blk guest drivers to read-read the information from the config space once it got the config chaged interrupt. Signed-off-by: Christoph Hellwig Index: qemu/hw/virtio-blk.c ==

[Qemu-devel] [PATCH 0/3 v2] allow online resizing of block devices

2011-01-19 Thread Christoph Hellwig
This patchset adds support for online resizing of block devices. The first patch adds a new resize monitor command which call into the existing image resize code. This is the meat of the series and probably needs quite a bit of review and help as I'm not sure about how to implement the error hand

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 07:11 AM, Markus Armbruster wrote: Gerd Hoffmann writes: On 01/18/11 18:09, Anthony Liguori wrote: On 01/18/2011 10:56 AM, Jan Kiszka wrote: The device model topology is 100% a hidden architectural detail. This is true for the sysbus, it

[Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-19 Thread Christoph Hellwig
Extend the change_cb callback with a reason argument, and use it to tell drivers about size changes. Signed-off-by: Christoph Hellwig Index: qemu/block.c === --- qemu.orig/block.c 2011-01-18 20:54:45.246021572 +0100 +++ qemu/block

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Chunqiang Tang
> Actually current filesystems do pretty well on thinly provisioned > storage, as long as your extent size is not too small. Starting from > extent size in the 64M to 256M range there's almost no difference to > non-virtualized storage. > > Again, sparse images with a large enough allocation size

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Daniel P. Berrange
On Wed, Jan 19, 2011 at 10:54:10AM -0600, Anthony Liguori wrote: > On 01/19/2011 07:11 AM, Markus Armbruster wrote: > >Gerd Hoffmann writes: > > > >>On 01/18/11 18:09, Anthony Liguori wrote: > >>>On 01/18/2011 10:56 AM, Jan Kiszka wrote: > >The device model topology is 100% a hidden architectu

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 03:48 AM, Gerd Hoffmann wrote: On 01/18/11 18:09, Anthony Liguori wrote: On 01/18/2011 10:56 AM, Jan Kiszka wrote: The device model topology is 100% a hidden architectural detail. This is true for the sysbus, it is obviously not the case for PCI and similarly discoverable buses

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Jan Kiszka
On 2011-01-19 17:57, Anthony Liguori wrote: > On 01/19/2011 07:15 AM, Markus Armbruster wrote: >> So they interact with KVM (need kvm_state), and they interact with the >> emulated PCI bus. Could you elaborate on the fundamental difference >> between the two interactions that makes you choose the

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Christoph Hellwig
On Wed, Jan 19, 2011 at 12:08:41PM -0500, Chunqiang Tang wrote: > These numbers are very interesting and I would like to read more. Are > your detailed results accessible on the Internet? Do you have numbers on > the impact of using a large extent size (64-256MB) on thin provisioning > (since

[Qemu-devel] Re: [PATCH 0/3 v2] allow online resizing of block devices

2011-01-19 Thread Juan Quintela
Christoph Hellwig wrote: > This patchset adds support for online resizing of block devices. > > The first patch adds a new resize monitor command which call into > the existing image resize code. This is the meat of the series > and probably needs quite a bit of review and help as I'm not sure >

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Daniel P. Berrange
On Wed, Jan 19, 2011 at 10:53:30AM -0600, Anthony Liguori wrote: > On 01/19/2011 03:48 AM, Gerd Hoffmann wrote: > >On 01/18/11 18:09, Anthony Liguori wrote: > >>On 01/18/2011 10:56 AM, Jan Kiszka wrote: > >>> > The device model topology is 100% a hidden architectural detail. > >>>This is true f

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 11:35 AM, Daniel P. Berrange wrote: On Wed, Jan 19, 2011 at 10:53:30AM -0600, Anthony Liguori wrote: On 01/19/2011 03:48 AM, Gerd Hoffmann wrote: On 01/18/11 18:09, Anthony Liguori wrote: On 01/18/2011 10:56 AM, Jan Kiszka wrote: The devic

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 11:19 AM, Daniel P. Berrange wrote: In our past experiance though, *not* specifying attributes like these has also been pretty bad from a forward compatibility perspective too. We're kind of damned either way, so on balance we decided we'd specify every attribute in qdev that's rel

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 11:01 AM, Daniel P. Berrange wrote: The reason we specify 'bus' is that we wanted to be flexible wrt upgrades of libvirt, without needing restarts of QEMU instances it manages. That way we can introduce new functionality into libvirt that relies on it having previously set 'bus' on

Re: [Qemu-devel] Missing roms/seabios/Makefile and roms/vgabios/Makefile

2011-01-19 Thread Blue Swirl
On Wed, Jan 19, 2011 at 12:44 PM, Mateusz Loskot wrote: > Hi, > > Running ./configure (under MinGW/MSYS) and symlink gives up trying to > create links to non-existing Makefiles in > roms/seabios/Makefile > roms/vgabios/Makefile Those directiories are actually git submodules, when you run 'git sub

[Qemu-devel] libcacard as a git submodule

2011-01-19 Thread Alon Levy
Any objections? Alon

[Qemu-devel] usb redirection status report

2011-01-19 Thread Hans de Goede
Hi All, As most of you know I'm working on usb redirection (making client usb devices accessible in guests over the network). I thought it would be a good idea to write a short status report. So fat the following has been done: * written and posted a network protocol for usb redir. over the ne

[Qemu-devel] Re: libcacard as a git submodule

2011-01-19 Thread Anthony Liguori
On 01/19/2011 12:11 PM, Alon Levy wrote: Any objections? My primary concern is that it is easy to make changes to QEMU that impact the interface between QEMU and libcacard so I'd actually prefer it not be a submodule. Regards, Anthony Liguori Alon

[Qemu-devel] Re: MIPS, io-thread, icount and wfi

2011-01-19 Thread Marcelo Tosatti
On Tue, Jan 18, 2011 at 11:00:57AM +0100, Jan Kiszka wrote: > On 2011-01-18 01:19, Edgar E. Iglesias wrote: > > On Mon, Jan 17, 2011 at 11:03:08AM +0100, Edgar E. Iglesias wrote: > >> Hi, > >> > >> I'm running an io-thread enabled qemu-system-mipsel with icount. > >> When the guest (linux) goes to

Re: [Qemu-devel] [Bug 704904] [NEW] No rule to make target ../libhw32/virtio.o

2011-01-19 Thread Blue Swirl
On Wed, Jan 19, 2011 at 1:57 PM, Mateusz Łoskot wrote: > Public bug reported: > > Building qemu from current git using 32-bit MinGW (installer from > 2010-11-07) on Windows Vista (64-bit) fails with the following error: > > make[1]: *** No rule to make target `../libhw32/virtio.o', needed by > `q

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Daniel P. Berrange
On Wed, Jan 19, 2011 at 11:51:58AM -0600, Anthony Liguori wrote: > On 01/19/2011 11:01 AM, Daniel P. Berrange wrote: > > > >The reason we specify 'bus' is that we wanted to be flexible wrt > >upgrades of libvirt, without needing restarts of QEMU instances > >it manages. That way we can introduce ne

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Daniel P. Berrange
On Wed, Jan 19, 2011 at 11:42:18AM -0600, Anthony Liguori wrote: > On 01/19/2011 11:35 AM, Daniel P. Berrange wrote: > >On Wed, Jan 19, 2011 at 10:53:30AM -0600, Anthony Liguori wrote: > >>On 01/19/2011 03:48 AM, Gerd Hoffmann wrote: > >>>On 01/18/11 18:09, Anthony Liguori wrote: > On 01/18/201

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Anthony Liguori
On 01/19/2011 12:52 PM, Daniel P. Berrange wrote: On Wed, Jan 19, 2011 at 11:51:58AM -0600, Anthony Liguori wrote: On 01/19/2011 11:01 AM, Daniel P. Berrange wrote: The reason we specify 'bus' is that we wanted to be flexible wrt upgrades of libvirt, without needing restarts of QEMU i

[Qemu-devel] IDE development

2011-01-19 Thread steven765
Hello, For a project we're slowly making our own operating system. My task is the file system. We plan on using the FatFs file system. My question is how to link FatFs to the IDE Hard Drive QEMU emulates? I cannot find any documentation on how to access the disk, API, calls, ect. Any se

[Qemu-devel] Re: MIPS, io-thread, icount and wfi

2011-01-19 Thread Edgar E. Iglesias
On Wed, Jan 19, 2011 at 03:02:26PM -0200, Marcelo Tosatti wrote: > On Tue, Jan 18, 2011 at 11:00:57AM +0100, Jan Kiszka wrote: > > On 2011-01-18 01:19, Edgar E. Iglesias wrote: > > > On Mon, Jan 17, 2011 at 11:03:08AM +0100, Edgar E. Iglesias wrote: > > >> Hi, > > >> > > >> I'm running an io-thread

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-19 Thread Peter Maydell
On 19 January 2011 14:37, Christophe Lyon wrote: > Here is an updated patch which will hopefully not be mangled by my mailer. > > Fix garbage collection of temporaries in Neon emulation. I've tested this patch and it does indeed fix the problems with VMULL and friends (I was seeing assertions/han

Re: [Qemu-devel] [PULL] piix, pci, qdev

2011-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2011 at 04:14:48PM +0100, Christoph Hellwig wrote: > > > pci: fix migration path for devices behind bridges > > This patch breaks starting qemu for me on 32-bit x86 with the following > assert: Yes, sorry about that. I sent a fix, could you check out it please? > qemu-syst

[Qemu-devel] [PATCH] target-arm: Fix loading of scalar value for Neon multiply-by-scalar

2011-01-19 Thread Peter Maydell
Fix the register and part of register we get the scalar from in the various "multiply vector by scalar" ops (VMUL by scalar and friends). Signed-off-by: Peter Maydell --- target-arm/translate.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target-arm/transla

[Qemu-devel] [PATCH] pci: fix device paths

2011-01-19 Thread Michael S. Tsirkin
Patch a6a7005d14b3c32d4864a718fb1cb19c789f58a5 generated broken device paths. We snprintf with a length shorter than the output, so the last character is discarded and replaced by the null byte. Fix it up by snprintf to a buffer which is larger by 1 byte and then memcpy the data (without the null b

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Blue Swirl
On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori wrote: > On 01/19/2011 07:15 AM, Markus Armbruster wrote: >> >> So they interact with KVM (need kvm_state), and they interact with the >> emulated PCI bus.  Could you elaborate on the fundamental difference >> between the two interactions that makes

[Qemu-devel] Re: [PATCH 1/2] prep: Remove bogus BIOS size check

2011-01-19 Thread Andreas Färber
Am 18.01.2011 um 22:43 schrieb Hervé Poussineau: From: Andreas Färber r3480 added this check to account for the entry vector 0xfff00100 to be available for CPUs that need it. Today however, the NIP is not yet initialized at this point (zero), so the check always triggers. Moreover, BIOS si

[Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1

2011-01-19 Thread Chunqiang Tang
Part 1 of the block device driver for the proposed FVD image format. Multiple patches are used in order to manage the size of each patch. This patch includes existing files that are modified by FVD. See the related discussions at http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg00426.html .

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Jamie Lokier
Chunqiang Tang wrote: > > >> Moreover, using a host file system not only adds overhead, but > > >> also introduces data integrity issues. Specifically, if I/Os uses > O_DSYNC, > > >> it may be too slow. If I/Os use O_DIRECT, it cannot guarantee data > > >> integrity in the event of a host crash. S

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-19 Thread Yoshiaki Tamura
2011/1/19 Pierre Riteau : > b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return > value of bdrv_write and aborts migration when it fails. However, if the > size of the block device to migrate is not a multiple of BLOCK_SIZE > (currently 1 MB), the last bdrv_write will fail with -EI

Re: [Qemu-devel] [PATCH] savevm: fix corruption in vmstate_subsection_load().

2011-01-19 Thread Yoshiaki Tamura
2010/12/14 Yoshiaki Tamura : > Although it's rare to happen in live migration, when the head of a > byte stream contains 0x05 which is the marker of subsection, the > loader gets corrupted because vmstate_subsection_load() continues even > the device doesn't require it.  This patch adds a checker w

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-19 Thread Chunqiang Tang
> when I tried to use your patch, I found several problems: > > * The patch does apply cleanly to latest QEMU. >This is caused by recent changes in QEMU git master. > > * The new code uses tabs instead of spaces (QEMU coding rules). > > * Some lines of the new code end with blank characters.

[Qemu-devel] [PATCH] linux-user: Add support for -version option

2011-01-19 Thread Peter Maydell
Add support to the linux-user qemu for the -version command line option, bringing it into line with the system emulation qemu. Signed-off-by: Peter Maydell --- linux-user/main.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/linux-user/main.c b/linux-us

Re: [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-19 Thread Yoshiaki Tamura
2011/1/19 Kevin Wolf : > Am 19.01.2011 14:16, schrieb Yoshiaki Tamura: >> 2011/1/19 Kevin Wolf : >>> Am 19.01.2011 06:44, schrieb Yoshiaki Tamura: event-tap function is called only when it is on, and requests sent from device emulators. Signed-off-by: Yoshiaki Tamura --- >

Re: [Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-19 Thread Yoshiaki Tamura
2011/1/19 Kevin Wolf : > Am 19.01.2011 14:04, schrieb Yoshiaki Tamura: +static void event_tap_blk_flush(EventTapBlkReq *blk_req) +{ +    BlockDriverState *bs; + +    bs = bdrv_find(blk_req->device_name); >>> >>> Please store the BlockDriverState in blk_req. This code loops

Re: [Qemu-devel] [PATCH] Fix block migration when the device size is not a multiple of 1 MB

2011-01-19 Thread Pierre Riteau
On 20 janv. 2011, at 03:06, Yoshiaki Tamura wrote: > 2011/1/19 Pierre Riteau : >> b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return >> value of bdrv_write and aborts migration when it fails. However, if the >> size of the block device to migrate is not a multiple of BLOCK_SIZE >

[Qemu-devel] [PATCH] pci/pcie: make pci_find_device() ARI aware.

2011-01-19 Thread Isaku Yamahata
make pci_find_device() ARI aware. Signed-off-by: Isaku Yamahata --- hw/pci.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 8d0e3df..851f350 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1596,11 +1596,18 @@ PCIBus *pci_find_bus(PCIBus *bus, in

[Qemu-devel] [PATCH] pci: use qemu_malloc() in pcibus_get_dev_path()

2011-01-19 Thread Isaku Yamahata
use qemu_malloc() instead of direct use of malloc(). Signed-off-by: Isaku Yamahata --- hw/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 851f350..86af0ee 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -2053,7 +2053,7 @@ static char *pcibus_get_

[Qemu-devel] [PATCH] pci: make pci_bus_new() aware of pci domain

2011-01-19 Thread Isaku Yamahata
This patch makes pci bus creation aware of pci domain. Signed-off-by: Isaku Yamahata --- hw/pci.c | 19 ++- hw/pci.h |7 --- hw/piix_pci.c |2 +- 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 86af0ee..e1e7b25 100

[Qemu-devel] [PATCH 1/3] pci: deassert intx on reset.

2011-01-19 Thread Isaku Yamahata
deassert intx on device reset. So far pci_device_reset() is used for system reset. In that case, interrupt controller is reset at the same time so that all irq is are deasserted. But now pci bus reset/flr is supported, and in that case irq needs to be disabled explicitly. Signed-off-by: Isaku Yama

[Qemu-devel] [PATCH 2/3] msi: simply write config a bit.

2011-01-19 Thread Isaku Yamahata
use pci_device_deassert_intx(). Signed-off-by: Isaku Yamahata --- hw/msi.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index f03f519..3dc3a24 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -255,7 +255,6 @@ void msi_write_config(PCIDevice *dev, uint32

[Qemu-devel] [PATCH 0/3] pci: disable intx on flr/bus reset

2011-01-19 Thread Isaku Yamahata
So far pci_device_reset() is used for system reset. In that case, interrupt controller is also reset so that all irq is are deasserted. But now pci bus reset/flr is supported, and in that case irq needs to be disabled explicitly. Isaku Yamahata (3): pci: deassert intx on reset. msi: simply wri

  1   2   >