On Wed, Jan 19, 2011 at 1:12 AM, Jamie Lokier wrote:
> Chunqiang Tang wrote:
>> Moreover, using a host file system not only adds overhead, but
>> also introduces data integrity issues. Specifically, if I/Os uses O_DSYNC,
>> it may be too slow. If I/Os use O_DIRECT, it cannot guarantee data
>> inte
In additional to the description in the patch, see following email for uses:
http://lists.nongnu.org/archive/html/qemu-devel/2011-01/msg01208.html
In particular it would/could be used for:
current vdagent of spice uses this for mouse, copy paste
proposed smartcard device for qemu uses this with
Adding a chardev backend for spice, where spice determines what
to do with it based on the name attribute given during chardev creation.
For usage by spice vdagent in conjunction with a properly named
virtio-serial device, and future smartcard channel usage.
Example usage:
qemu -device virtio-ser
Am 19.01.2011 06:44, schrieb Yoshiaki Tamura:
> event-tap function is called only when it is on, and requests sent
> from device emulators.
>
> Signed-off-by: Yoshiaki Tamura
> ---
> block.c | 11 +++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/block.c b/block
Am 19.01.2011 06:44, schrieb Yoshiaki Tamura:
> event-tap controls when to start FT transaction, and provides proxy
> functions to called from net/block devices. While FT transaction, it
> queues up net/block requests, and flush them when the transaction gets
> completed.
>
> Signed-off-by: Yoshi
Am 19.01.2011 06:44, schrieb Yoshiaki Tamura:
> event-tap function is called only when it is on, and requests sent
> from device emulators.
>
> Signed-off-by: Yoshiaki Tamura
> ---
> block.c | 11 +++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/block.c b/block
On 01/18/11 18:09, Anthony Liguori wrote:
On 01/18/2011 10:56 AM, Jan Kiszka wrote:
The device model topology is 100% a hidden architectural detail.
This is true for the sysbus, it is obviously not the case for PCI and
similarly discoverable buses. There we have a guest-explorable topology
th
On 01/18/11 21:39, Anthony Liguori wrote:
> On 01/18/2011 02:36 PM, Jes Sorensen wrote:
>> On 01/18/11 21:30, Anthony Liguori wrote:
>>> On 01/18/2011 10:53 AM, Eric Blake wrote:
And it does, via the toupper() added earlier in the series (and which
has separately been pointed out
Hi Blue Swirl,
Thanks for your review comments. I will address these in my next version of
patchset.
M. Mohan Kumar
On Tuesday 18 January 2011 10:38:21 pm Blue Swirl wrote:
> On Tue, Jan 18, 2011 at 6:25 AM, M. Mohan Kumar wrote:
> > Add both server & client side interfaces to create regu
On 18/01/11 21:51, Blue Swirl wrote:
On Tue, Jan 18, 2011 at 6:00 PM, Mateusz Loskot wrote:
On 18/01/11 17:36, Blue Swirl wrote:
On Tue, Jan 18, 2011 at 3:27 PM, Mateusz Loskot
wrote:
Hi,
Recently, I have reported mysterious issues on NetBSD 5.1
emulated on SPARC. The whole first thread
2011/1/19 Kevin Wolf :
> Am 19.01.2011 06:44, schrieb Yoshiaki Tamura:
>> event-tap function is called only when it is on, and requests sent
>> from device emulators.
>>
>> Signed-off-by: Yoshiaki Tamura
>> ---
>> block.c | 11 +++
>> 1 files changed, 11 insertions(+), 0 deletions(-)
>>
Hello,
This series is now separated from the chardev flow control series.
The virtio-serial code now does not copy over data from the guest to
the host. It instead keeps track of how far we are in consuming the
data and maintains this state.
For flow control, when a user of the virtio-serial por
Remove unnecessary braces around a case statement.
Signed-off-by: Amit Shah
---
hw/virtio-console.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index d7fe68b..d0b9354 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console
Instead of combining flush logic into the discard case and not discard
case, have one function doing discard case. This will help later when
adding flow control logic to the do_flush_queued_data() function.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 47 +
The initialisation for generic ports and console ports is similar.
Factor out the parts that are the same in a different function that can
be called from each of the initfns.
Signed-off-by: Amit Shah
---
hw/virtio-console.c | 31 ++-
1 files changed, 14 insertions(+
When the guest writes something to a host, we copied over the entire
buffer first into the host and then processed it. Do away with that, it
could result in a malicious guest causing a DoS on the host.
Reported-by: Paul Brook
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 15 -
The have_data() API to hand off guest data to apps using virtio-serial
so far assumed all the data was consumed. Relax this assumption.
Future commits will allow for incomplete writes.
Signed-off-by: Amit Shah
---
hw/virtio-console.c |4 ++--
hw/virtio-serial.h |7 ---
2 files chan
This commit lets apps signal an incomplete write. When that happens,
stop sending out any more data to the app and wait for it to unthrottle
the port.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 49 +--
hw/virtio-serial.h | 17 ++
The new fields that got added as part of not copying over the guest
buffer to the host need to be saved/restored across migration. Do that
and bump up the version number.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 42 --
1 files changed, 40 i
Hi,
Running ./configure (under MinGW/MSYS) and symlink gives up trying to
create links to non-existing Makefiles in
roms/seabios/Makefile
roms/vgabios/Makefile
Quick fix is to remove those Makefiles from the FILES list:
diff --git a/configure b/configure
index d68f862..92e2527 100755
--- a/conf
2011/1/19 Kevin Wolf :
> Am 19.01.2011 06:44, schrieb Yoshiaki Tamura:
>> event-tap controls when to start FT transaction, and provides proxy
>> functions to called from net/block devices. While FT transaction, it
>> queues up net/block requests, and flush them when the transaction gets
>> complet
This bug is fixed on HEAD in the qemu-meego tree (commit
8493a687d54e542ac4eec8b2f8326415edf37ec4
A)
- Wolfgang
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/702885
Title:
"Internal resource leak"
Anthony Liguori writes:
> On 01/18/2011 10:56 AM, Jan Kiszka wrote:
>>
>>> The device model topology is 100% a hidden architectural detail.
>>>
>> This is true for the sysbus, it is obviously not the case for PCI and
>> similarly discoverable buses. There we have a guest-explorable topology
Gerd Hoffmann writes:
> On 01/18/11 18:09, Anthony Liguori wrote:
>> On 01/18/2011 10:56 AM, Jan Kiszka wrote:
>>>
The device model topology is 100% a hidden architectural detail.
>>> This is true for the sysbus, it is obviously not the case for PCI and
>>> similarly discoverable buses. Ther
2011/1/19 Kevin Wolf :
> Am 19.01.2011 06:44, schrieb Yoshiaki Tamura:
>> event-tap function is called only when it is on, and requests sent
>> from device emulators.
>>
>> Signed-off-by: Yoshiaki Tamura
>> ---
>> block.c | 11 +++
>> 1 files changed, 11 insertions(+), 0 deletions(-)
>>
On 19 January 2011 12:42, Wolfgang Schildbach <702...@bugs.launchpad.net> wrote:
> This bug is fixed on HEAD in the qemu-meego tree (commit
> 8493a687d54e542ac4eec8b2f8326415edf37ec4
> A)
Note that the qemu-meego tree disables these warnings using
an #ifdef, so even if the message is not printed
Anthony Liguori writes:
> On 01/18/2011 09:43 AM, Jan Kiszka wrote:
>> On 2011-01-18 16:04, Anthony Liguori wrote:
>>
>>> On 01/18/2011 08:28 AM, Jan Kiszka wrote:
>>>
On 2011-01-12 11:31, Jan Kiszka wrote:
> Am 12.01.2011 11:22, Avi Kivity wrote:
>
>
Sorry for the long delay on this one, in general looks good, I have just
a few small comments.
On Mon, 10 Jan 2011 17:27:51 +0800
Lai Jiangshan wrote:
> When the argument "cpu-index" is not given,
> then "nmi" command will inject NMI on all CPUs.
Please, state that we're changing the human mon
On Mon, 10 Jan 2011 17:28:14 +0800
Lai Jiangshan wrote:
> Make we can inject NMI via qemu-monitor-protocol.
> We use "inject-nmi" for the qmp command name, the meaning is clearer.
>
> Signed-off-by: Lai Jiangshan
> ---
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index a49fcd4..4db413d 1
Am 19.01.2011 14:04, schrieb Yoshiaki Tamura:
>>> +static void event_tap_blk_flush(EventTapBlkReq *blk_req)
>>> +{
>>> +BlockDriverState *bs;
>>> +
>>> +bs = bdrv_find(blk_req->device_name);
>>
>> Please store the BlockDriverState in blk_req. This code loops over all
>> block devices and do
The test on xendev->gnttabdev in con_disconnect is wrong: what
differentiates the consoles is the dev number.
Signed-off-by: Stefano Stabellini
diff --git a/hw/xen_console.c b/hw/xen_console.c
index d7099c4..0a2374c 100644
--- a/hw/xen_console.c
+++ b/hw/xen_console.c
@@ -258,7 +258,7 @@ static
Am 19.01.2011 14:16, schrieb Yoshiaki Tamura:
> 2011/1/19 Kevin Wolf :
>> Am 19.01.2011 06:44, schrieb Yoshiaki Tamura:
>>> event-tap function is called only when it is on, and requests sent
>>> from device emulators.
>>>
>>> Signed-off-by: Yoshiaki Tamura
>>> ---
>>> block.c | 11 +++
>
Public bug reported:
Building qemu from current git using 32-bit MinGW (installer from
2010-11-07) on Windows Vista (64-bit) fails with the following error:
make[1]: *** No rule to make target `../libhw32/virtio.o', needed by
`qemu.exe'. Stop.
make: *** [subdir-i386-softmmu] Error 2
Here is my
> From: qemu-devel-bounces+wschi=dolby@nongnu.org
> [mailto:qemu-devel-bounces+wschi=dolby@nongnu.org] On
> Behalf Of Peter Maydell
> Sent: Wednesday, January 19, 2011 5:16 AM
> To: Bug 702885
> Cc: qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [Bug 702885] Re: "Internal resource
> l
Here is an updated patch which will hopefully not be mangled by my mailer.
Fix garbage collection of temporaries in Neon emulation.
Signed-off-by: Christophe Lyon
---
target-arm/translate.c | 18 +-
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/target-arm/tr
> > Doing both fault injection and verification together introduces some
> > subtlety. For example, even under the random failure mode, two disk
writes
> > triggered by one VM-issued write must either fail together or succeed
> > together. Otherwise, the truth image and the test image will dive
b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return
value of bdrv_write and aborts migration when it fails. However, if the
size of the block device to migrate is not a multiple of BLOCK_SIZE
(currently 1 MB), the last bdrv_write will fail with -EIO.
Fixed by calling bdrv_write wi
> > pci: fix migration path for devices behind bridges
This patch breaks starting qemu for me on 32-bit x86 with the following assert:
qemu-system-x86_64: savevm.c:1129: register_savevm_live: Assertion
`!se->compat || se->instance_id == 0' failed.
my qemu command line is:
/opt/qemu/bin/qe
On Wed, Jan 19, 2011 at 04:14:48PM +0100, Christoph Hellwig wrote:
> > > pci: fix migration path for devices behind bridges
>
> This patch breaks starting qemu for me on 32-bit x86 with the following
> assert:
>
> qemu-system-x86_64: savevm.c:1129: register_savevm_live: Assertion
> `!se->c
> >> Moreover, using a host file system not only adds overhead, but
> >> also introduces data integrity issues. Specifically, if I/Os uses
O_DSYNC,
> >> it may be too slow. If I/Os use O_DIRECT, it cannot guarantee data
> >> integrity in the event of a host crash. See
> >> http://lwn.net/Articles/
On Wed, Jan 19, 2011 at 10:17:47AM -0500, Chunqiang Tang wrote:
> Thank both of you for the explanation, which is very helpful to me. With
> FVD's capability of eliminating the host file system and storing the image
> on a logical volume, then perhaps we can always use O_DSYNC, because there
> i
On Mon, Jan 17, 2011 at 06:36:15PM +0100, Kevin Wolf wrote:
> > +.args_type = "id:s,size:l",
>
> size should be 'o' instead of 'l'. The latter may be too small on 32 bit
> hosts and doesn't support convenient suffixes:
o actually fails for 2GB or more for me:
(qemu) resize scratch 2047
Am 19.01.2011 16:35, schrieb Christoph Hellwig:
> On Mon, Jan 17, 2011 at 06:36:15PM +0100, Kevin Wolf wrote:
>>> +.args_type = "id:s,size:l",
>>
>> size should be 'o' instead of 'l'. The latter may be too small on 32 bit
>> hosts and doesn't support convenient suffixes:
>
> o actually fa
On Fri, Jan 14, 2011 at 03:56:00PM -0500, Chunqiang Tang wrote:
> P2) Overhead of storing an image on a host file system. Specifically, a
> RAW image stored on ext3 is 50-63% slower than a RAW image stored on a raw
> partition.
Sorry, benchmarking this against ext3 really doesn't matter. Benchm
On Wed, Jan 19, 2011 at 04:49:04PM +0100, Kevin Wolf wrote:
> > (qemu) resize scratch 2047
> > resize scratch 2047
> > (qemu)
> > (qemu) resize scrarch 2048
> > resize scrarch 2048
> > invalid size
> >
> > for l these worked fine.
>
> Hm, yeah, 'o' uses ssize_t instead of int64_t, so it's brok
Am 19.01.2011 16:52, schrieb Christoph Hellwig:
> On Wed, Jan 19, 2011 at 04:49:04PM +0100, Kevin Wolf wrote:
>>> (qemu) resize scratch 2047
>>> resize scratch 2047
>>> (qemu)
>>> (qemu) resize scrarch 2048
>>> resize scrarch 2048
>>> invalid size
>>>
>>> for l these worked fine.
>>
>> Hm, yeah,
This patch fixes corner-case saturations, when the target range is
zero. It merely removes the guard against (sh == 0), and makes:
__ssat(0x87654321, 1) return 0x and set the saturation flag
__usat(0x87654321, 0) return 0 and set the saturation flag
Signed-off-by: Christophe Lyon
---
ta
On Wed, Jan 19, 2011 at 05:01:19PM +0100, Kevin Wolf wrote:
> Oh, okay, then it makes perfect sense. We should fix 'o' then to use
> int64_t. The patch below should do it.
>
> strtosz (which is used by 'o') has the same problem in git master.
> There's a fix by Jes, so be sure to test this on the
> It's something filesystems have to deal with. Real storage is getting
> increasingly virtualized. While this didn't matter for the real high
> end storage which has been doing this for a long time it's getting more
> and more exposed to the filesystem. That includes LVM layouts and
> thinly pr
On Wed, Jan 19, 2011 at 11:21:07AM -0500, Chunqiang Tang wrote:
> Yes, a fundamental and optimal solution would be changing guest file
> systems, but it would take a much much longer route to introduce
> virtualization awareness into all guest file systems and its also requires
> changing the in
On 01/19/2011 07:15 AM, Markus Armbruster wrote:
So they interact with KVM (need kvm_state), and they interact with the
emulated PCI bus. Could you elaborate on the fundamental difference
between the two interactions that makes you choose the (hypothetical)
KVM bus over the PCI bus as device par
On 19 January 2011 16:10, Christophe Lyon wrote:
>
> This patch fixes corner-case saturations, when the target range is
> zero. It merely removes the guard against (sh == 0), and makes:
> __ssat(0x87654321, 1) return 0x and set the saturation flag
did you mean __ssat(0x87654321, 0) here?
Add a monitor command that allows resizing of block devices while
qemu is running. It uses the existing bdrv_truncate method already
used by qemu-img to do it's work. Compared to qemu-img the size
parsing is very simplicistic, but I think having a properly numering
object is more useful for non-h
On Wed, Jan 19, 2011 at 10:53:30AM -0600, Anthony Liguori wrote:
> On 01/19/2011 03:48 AM, Gerd Hoffmann wrote:
> >On 01/18/11 18:09, Anthony Liguori wrote:
> >>On 01/18/2011 10:56 AM, Jan Kiszka wrote:
> >>>
> The device model topology is 100% a hidden architectural detail.
> >>>This is true f
Raise a config change interrupt when the size changed. This allows
virtio-blk guest drivers to read-read the information from the
config space once it got the config chaged interrupt.
Signed-off-by: Christoph Hellwig
Index: qemu/hw/virtio-blk.c
==
This patchset adds support for online resizing of block devices.
The first patch adds a new resize monitor command which call into
the existing image resize code. This is the meat of the series
and probably needs quite a bit of review and help as I'm not sure
about how to implement the error hand
On 01/19/2011 07:11 AM, Markus Armbruster wrote:
Gerd Hoffmann writes:
On 01/18/11 18:09, Anthony Liguori wrote:
On 01/18/2011 10:56 AM, Jan Kiszka wrote:
The device model topology is 100% a hidden architectural detail.
This is true for the sysbus, it
Extend the change_cb callback with a reason argument, and use it
to tell drivers about size changes.
Signed-off-by: Christoph Hellwig
Index: qemu/block.c
===
--- qemu.orig/block.c 2011-01-18 20:54:45.246021572 +0100
+++ qemu/block
> Actually current filesystems do pretty well on thinly provisioned
> storage, as long as your extent size is not too small. Starting from
> extent size in the 64M to 256M range there's almost no difference to
> non-virtualized storage.
>
> Again, sparse images with a large enough allocation size
On Wed, Jan 19, 2011 at 10:54:10AM -0600, Anthony Liguori wrote:
> On 01/19/2011 07:11 AM, Markus Armbruster wrote:
> >Gerd Hoffmann writes:
> >
> >>On 01/18/11 18:09, Anthony Liguori wrote:
> >>>On 01/18/2011 10:56 AM, Jan Kiszka wrote:
> >The device model topology is 100% a hidden architectu
On 01/19/2011 03:48 AM, Gerd Hoffmann wrote:
On 01/18/11 18:09, Anthony Liguori wrote:
On 01/18/2011 10:56 AM, Jan Kiszka wrote:
The device model topology is 100% a hidden architectural detail.
This is true for the sysbus, it is obviously not the case for PCI and
similarly discoverable buses
On 2011-01-19 17:57, Anthony Liguori wrote:
> On 01/19/2011 07:15 AM, Markus Armbruster wrote:
>> So they interact with KVM (need kvm_state), and they interact with the
>> emulated PCI bus. Could you elaborate on the fundamental difference
>> between the two interactions that makes you choose the
On Wed, Jan 19, 2011 at 12:08:41PM -0500, Chunqiang Tang wrote:
> These numbers are very interesting and I would like to read more. Are
> your detailed results accessible on the Internet? Do you have numbers on
> the impact of using a large extent size (64-256MB) on thin provisioning
> (since
Christoph Hellwig wrote:
> This patchset adds support for online resizing of block devices.
>
> The first patch adds a new resize monitor command which call into
> the existing image resize code. This is the meat of the series
> and probably needs quite a bit of review and help as I'm not sure
>
On Wed, Jan 19, 2011 at 10:53:30AM -0600, Anthony Liguori wrote:
> On 01/19/2011 03:48 AM, Gerd Hoffmann wrote:
> >On 01/18/11 18:09, Anthony Liguori wrote:
> >>On 01/18/2011 10:56 AM, Jan Kiszka wrote:
> >>>
> The device model topology is 100% a hidden architectural detail.
> >>>This is true f
On 01/19/2011 11:35 AM, Daniel P. Berrange wrote:
On Wed, Jan 19, 2011 at 10:53:30AM -0600, Anthony Liguori wrote:
On 01/19/2011 03:48 AM, Gerd Hoffmann wrote:
On 01/18/11 18:09, Anthony Liguori wrote:
On 01/18/2011 10:56 AM, Jan Kiszka wrote:
The devic
On 01/19/2011 11:19 AM, Daniel P. Berrange wrote:
In our past experiance though, *not* specifying attributes like
these has also been pretty bad from a forward compatibility
perspective too. We're kind of damned either way, so on balance
we decided we'd specify every attribute in qdev that's rel
On 01/19/2011 11:01 AM, Daniel P. Berrange wrote:
The reason we specify 'bus' is that we wanted to be flexible wrt
upgrades of libvirt, without needing restarts of QEMU instances
it manages. That way we can introduce new functionality into
libvirt that relies on it having previously set 'bus' on
On Wed, Jan 19, 2011 at 12:44 PM, Mateusz Loskot wrote:
> Hi,
>
> Running ./configure (under MinGW/MSYS) and symlink gives up trying to
> create links to non-existing Makefiles in
> roms/seabios/Makefile
> roms/vgabios/Makefile
Those directiories are actually git submodules, when you run 'git
sub
Any objections?
Alon
Hi All,
As most of you know I'm working on usb redirection (making client usb devices
accessible in guests over the network).
I thought it would be a good idea to write a short status report.
So fat the following has been done:
* written and posted a network protocol for usb redir. over the ne
On 01/19/2011 12:11 PM, Alon Levy wrote:
Any objections?
My primary concern is that it is easy to make changes to QEMU that
impact the interface between QEMU and libcacard so I'd actually prefer
it not be a submodule.
Regards,
Anthony Liguori
Alon
On Tue, Jan 18, 2011 at 11:00:57AM +0100, Jan Kiszka wrote:
> On 2011-01-18 01:19, Edgar E. Iglesias wrote:
> > On Mon, Jan 17, 2011 at 11:03:08AM +0100, Edgar E. Iglesias wrote:
> >> Hi,
> >>
> >> I'm running an io-thread enabled qemu-system-mipsel with icount.
> >> When the guest (linux) goes to
On Wed, Jan 19, 2011 at 1:57 PM, Mateusz Łoskot wrote:
> Public bug reported:
>
> Building qemu from current git using 32-bit MinGW (installer from
> 2010-11-07) on Windows Vista (64-bit) fails with the following error:
>
> make[1]: *** No rule to make target `../libhw32/virtio.o', needed by
> `q
On Wed, Jan 19, 2011 at 11:51:58AM -0600, Anthony Liguori wrote:
> On 01/19/2011 11:01 AM, Daniel P. Berrange wrote:
> >
> >The reason we specify 'bus' is that we wanted to be flexible wrt
> >upgrades of libvirt, without needing restarts of QEMU instances
> >it manages. That way we can introduce ne
On Wed, Jan 19, 2011 at 11:42:18AM -0600, Anthony Liguori wrote:
> On 01/19/2011 11:35 AM, Daniel P. Berrange wrote:
> >On Wed, Jan 19, 2011 at 10:53:30AM -0600, Anthony Liguori wrote:
> >>On 01/19/2011 03:48 AM, Gerd Hoffmann wrote:
> >>>On 01/18/11 18:09, Anthony Liguori wrote:
> On 01/18/201
On 01/19/2011 12:52 PM, Daniel P. Berrange wrote:
On Wed, Jan 19, 2011 at 11:51:58AM -0600, Anthony Liguori wrote:
On 01/19/2011 11:01 AM, Daniel P. Berrange wrote:
The reason we specify 'bus' is that we wanted to be flexible wrt
upgrades of libvirt, without needing restarts of QEMU i
Hello,
For a project we're slowly making our own operating system. My task is the
file system. We plan on using the FatFs file system.
My question is how to link FatFs to the IDE Hard Drive QEMU emulates? I
cannot find any documentation on how to access the disk, API, calls, ect. Any
se
On Wed, Jan 19, 2011 at 03:02:26PM -0200, Marcelo Tosatti wrote:
> On Tue, Jan 18, 2011 at 11:00:57AM +0100, Jan Kiszka wrote:
> > On 2011-01-18 01:19, Edgar E. Iglesias wrote:
> > > On Mon, Jan 17, 2011 at 11:03:08AM +0100, Edgar E. Iglesias wrote:
> > >> Hi,
> > >>
> > >> I'm running an io-thread
On 19 January 2011 14:37, Christophe Lyon wrote:
> Here is an updated patch which will hopefully not be mangled by my mailer.
>
> Fix garbage collection of temporaries in Neon emulation.
I've tested this patch and it does indeed fix the problems with VMULL
and friends (I was seeing assertions/han
On Wed, Jan 19, 2011 at 04:14:48PM +0100, Christoph Hellwig wrote:
> > > pci: fix migration path for devices behind bridges
>
> This patch breaks starting qemu for me on 32-bit x86 with the following
> assert:
Yes, sorry about that.
I sent a fix, could you check out it please?
> qemu-syst
Fix the register and part of register we get the scalar from in
the various "multiply vector by scalar" ops (VMUL by scalar
and friends).
Signed-off-by: Peter Maydell
---
target-arm/translate.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/target-arm/transla
Patch a6a7005d14b3c32d4864a718fb1cb19c789f58a5 generated
broken device paths. We snprintf with a length shorter
than the output, so the last character is discarded and replaced
by the null byte. Fix it up by snprintf to a buffer
which is larger by 1 byte and then memcpy the data (without
the null b
On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori
wrote:
> On 01/19/2011 07:15 AM, Markus Armbruster wrote:
>>
>> So they interact with KVM (need kvm_state), and they interact with the
>> emulated PCI bus. Could you elaborate on the fundamental difference
>> between the two interactions that makes
Am 18.01.2011 um 22:43 schrieb Hervé Poussineau:
From: Andreas Färber
r3480 added this check to account for the entry vector 0xfff00100 to
be
available for CPUs that need it. Today however, the NIP is not yet
initialized at this point (zero), so the check always triggers.
Moreover, BIOS si
Part 1 of the block device driver for the proposed FVD image format.
Multiple patches are used in order to manage the size of each patch.
This patch includes existing files that are modified by FVD.
See the related discussions at
http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg00426.html .
Chunqiang Tang wrote:
> > >> Moreover, using a host file system not only adds overhead, but
> > >> also introduces data integrity issues. Specifically, if I/Os uses
> O_DSYNC,
> > >> it may be too slow. If I/Os use O_DIRECT, it cannot guarantee data
> > >> integrity in the event of a host crash. S
2011/1/19 Pierre Riteau :
> b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return
> value of bdrv_write and aborts migration when it fails. However, if the
> size of the block device to migrate is not a multiple of BLOCK_SIZE
> (currently 1 MB), the last bdrv_write will fail with -EI
2010/12/14 Yoshiaki Tamura :
> Although it's rare to happen in live migration, when the head of a
> byte stream contains 0x05 which is the marker of subsection, the
> loader gets corrupted because vmstate_subsection_load() continues even
> the device doesn't require it. This patch adds a checker w
> when I tried to use your patch, I found several problems:
>
> * The patch does apply cleanly to latest QEMU.
>This is caused by recent changes in QEMU git master.
>
> * The new code uses tabs instead of spaces (QEMU coding rules).
>
> * Some lines of the new code end with blank characters.
Add support to the linux-user qemu for the -version command line
option, bringing it into line with the system emulation qemu.
Signed-off-by: Peter Maydell
---
linux-user/main.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/linux-user/main.c b/linux-us
2011/1/19 Kevin Wolf :
> Am 19.01.2011 14:16, schrieb Yoshiaki Tamura:
>> 2011/1/19 Kevin Wolf :
>>> Am 19.01.2011 06:44, schrieb Yoshiaki Tamura:
event-tap function is called only when it is on, and requests sent
from device emulators.
Signed-off-by: Yoshiaki Tamura
---
>
2011/1/19 Kevin Wolf :
> Am 19.01.2011 14:04, schrieb Yoshiaki Tamura:
+static void event_tap_blk_flush(EventTapBlkReq *blk_req)
+{
+ BlockDriverState *bs;
+
+ bs = bdrv_find(blk_req->device_name);
>>>
>>> Please store the BlockDriverState in blk_req. This code loops
On 20 janv. 2011, at 03:06, Yoshiaki Tamura wrote:
> 2011/1/19 Pierre Riteau :
>> b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return
>> value of bdrv_write and aborts migration when it fails. However, if the
>> size of the block device to migrate is not a multiple of BLOCK_SIZE
>
make pci_find_device() ARI aware.
Signed-off-by: Isaku Yamahata
---
hw/pci.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 8d0e3df..851f350 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -1596,11 +1596,18 @@ PCIBus *pci_find_bus(PCIBus *bus, in
use qemu_malloc() instead of direct use of malloc().
Signed-off-by: Isaku Yamahata
---
hw/pci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 851f350..86af0ee 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -2053,7 +2053,7 @@ static char *pcibus_get_
This patch makes pci bus creation aware of pci domain.
Signed-off-by: Isaku Yamahata
---
hw/pci.c | 19 ++-
hw/pci.h |7 ---
hw/piix_pci.c |2 +-
3 files changed, 19 insertions(+), 9 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 86af0ee..e1e7b25 100
deassert intx on device reset.
So far pci_device_reset() is used for system reset.
In that case, interrupt controller is reset at the same time so that
all irq is are deasserted.
But now pci bus reset/flr is supported, and in that case irq needs to be
disabled explicitly.
Signed-off-by: Isaku Yama
use pci_device_deassert_intx().
Signed-off-by: Isaku Yamahata
---
hw/msi.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/hw/msi.c b/hw/msi.c
index f03f519..3dc3a24 100644
--- a/hw/msi.c
+++ b/hw/msi.c
@@ -255,7 +255,6 @@ void msi_write_config(PCIDevice *dev, uint32
So far pci_device_reset() is used for system reset.
In that case, interrupt controller is also reset so that
all irq is are deasserted.
But now pci bus reset/flr is supported, and in that case irq needs to be
disabled explicitly.
Isaku Yamahata (3):
pci: deassert intx on reset.
msi: simply wri
1 - 100 of 101 matches
Mail list logo