[Qemu-devel] Re: [PATCH 2/3] pci: introduce a parser for fw device path to pci device

On Fri, Dec 24, 2010 at 10:57:56AM +0900, Isaku Yamahata wrote: > On Wed, Dec 22, 2010 at 02:03:55PM +0200, Michael S. Tsirkin wrote: > > On Wed, Dec 22, 2010 at 08:36:40PM +0900, Isaku Yamahata wrote: > > > On Wed, Dec 22, 2010 at 01:04:43PM +0200, Michael S. Tsirkin wrote: > > > > On Wed, Dec 22,

[Qemu-devel] Re: [PATCH v11 0/5] pcie/aer: glue inject aer error into hmp

On Fri, Dec 24, 2010 at 12:14:10PM +0900, Isaku Yamahata wrote: > This patch series introduces hmp command to inject aer error. > Now fw device path is used to specify pci function. > > Changes v10 -> v11: > - use qdev id and use fw dev path as fallback > > Isaku Yamahata (5): > qdev: export qd

[Qemu-devel] [PATCH repost] pci: fix migration device path for devices behind nested bridges

We were using bus number in the device path, which is clearly broken as this number is guest-assigned for all devices except the root. Replace this by a hierarchical list of slot/function numbers, walking the path from root down to device. Add :00 after the domain number so that if there are no ne

[Qemu-devel] Re: [PATCH repost] pci: fix migration device path for devices behind nested bridges

The code looks good. Regarding to the format itself, I don't have strong opinion about it. What cames into my mind while I'm looking at the code is, Does BusInfo have to have two path functions? get_dev_path and get_fw_dev_path. Right now only pci supplies get_dev_path, on the other hand get_fw_de

[Qemu-devel] Re: [PATCH 06/19] virtio: update last_avail_idx when inuse is decreased.

On Fri, Dec 24, 2010 at 12:18:15PM +0900, Yoshiaki Tamura wrote: > virtio save/load is currently sending last_avail_idx, but inuse isn't. > This causes inconsistent state when using Kemari which replays > outstanding requests on the secondary. By letting last_avail_idx to > be updated after inuse

[Qemu-devel] Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

On Fri, Dec 17, 2010 at 12:59:58AM +0900, Yoshiaki Tamura wrote: > 2010/12/16 Michael S. Tsirkin : > > On Thu, Dec 16, 2010 at 11:28:46PM +0900, Yoshiaki Tamura wrote: > >> 2010/12/16 Michael S. Tsirkin : > >> > On Thu, Dec 16, 2010 at 04:36:16PM +0900, Yoshiaki Tamura wrote: > >> >> 2010/12/3 Yosh

[Qemu-devel] Re: [PATCH 06/19] virtio: update last_avail_idx when inuse is decreased.

2010/12/24 Michael S. Tsirkin : > On Fri, Dec 24, 2010 at 12:18:15PM +0900, Yoshiaki Tamura wrote: >> virtio save/load is currently sending last_avail_idx, but inuse isn't. >> This causes inconsistent state when using Kemari which replays >> outstanding requests on the secondary.  By letting last_a

[Qemu-devel] Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010/12/24 Michael S. Tsirkin : > On Fri, Dec 17, 2010 at 12:59:58AM +0900, Yoshiaki Tamura wrote: >> 2010/12/16 Michael S. Tsirkin : >> > On Thu, Dec 16, 2010 at 11:28:46PM +0900, Yoshiaki Tamura wrote: >> >> 2010/12/16 Michael S. Tsirkin : >> >> > On Thu, Dec 16, 2010 at 04:36:16PM +0900, Yoshiak

[Qemu-devel] Re: [PATCH repost] pci: fix migration device path for devices behind nested bridges

On Fri, Dec 24, 2010 at 06:26:42PM +0900, Isaku Yamahata wrote: > The code looks good. > Regarding to the format itself, I don't have strong opinion about it. > > What cames into my mind while I'm looking at the code is, > Does BusInfo have to have two path functions? get_dev_path and > get_fw_de

[Qemu-devel] Re: [PATCH 06/19] virtio: update last_avail_idx when inuse is decreased.

On Fri, Dec 24, 2010 at 08:22:00PM +0900, Yoshiaki Tamura wrote: > 2010/12/24 Michael S. Tsirkin : > > On Fri, Dec 24, 2010 at 12:18:15PM +0900, Yoshiaki Tamura wrote: > >> virtio save/load is currently sending last_avail_idx, but inuse isn't. > >> This causes inconsistent state when using Kemari w

[Qemu-devel] Re: [PATCH 06/19] virtio: update last_avail_idx when inuse is decreased.

2010/12/24 Michael S. Tsirkin : > On Fri, Dec 24, 2010 at 08:22:00PM +0900, Yoshiaki Tamura wrote: >> 2010/12/24 Michael S. Tsirkin : >> > On Fri, Dec 24, 2010 at 12:18:15PM +0900, Yoshiaki Tamura wrote: >> >> virtio save/load is currently sending last_avail_idx, but inuse isn't. >> >> This causes

[Qemu-devel] Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

On Fri, Dec 24, 2010 at 08:42:19PM +0900, Yoshiaki Tamura wrote: > 2010/12/24 Michael S. Tsirkin : > > On Fri, Dec 17, 2010 at 12:59:58AM +0900, Yoshiaki Tamura wrote: > >> 2010/12/16 Michael S. Tsirkin : > >> > On Thu, Dec 16, 2010 at 11:28:46PM +0900, Yoshiaki Tamura wrote: > >> >> 2010/12/16 Mic

[Qemu-devel] Re: [PATCH 06/19] virtio: update last_avail_idx when inuse is decreased.

On Fri, Dec 24, 2010 at 10:14:50PM +0900, Yoshiaki Tamura wrote: > 2010/12/24 Michael S. Tsirkin : > > On Fri, Dec 24, 2010 at 08:22:00PM +0900, Yoshiaki Tamura wrote: > >> 2010/12/24 Michael S. Tsirkin : > >> > On Fri, Dec 24, 2010 at 12:18:15PM +0900, Yoshiaki Tamura wrote: > >> >> virtio save/lo

Re: [Qemu-devel] Re: [PATCH 06/19] virtio: update last_avail_idx when inuse is decreased.

2010/12/24 Michael S. Tsirkin : > On Fri, Dec 24, 2010 at 10:14:50PM +0900, Yoshiaki Tamura wrote: >> 2010/12/24 Michael S. Tsirkin : >> > On Fri, Dec 24, 2010 at 08:22:00PM +0900, Yoshiaki Tamura wrote: >> >> 2010/12/24 Michael S. Tsirkin : >> >> > On Fri, Dec 24, 2010 at 12:18:15PM +0900, Yoshiak