Re: [Qemu-devel] [PATCH 3/3] Fail if detecting an unknown option

2010-12-06 Thread Jes Sorensen
On 12/03/10 12:46, Stefan Hajnoczi wrote: > On Thu, Dec 2, 2010 at 5:46 PM, wrote: >> From: Jes Sorensen >> >> This patch changes qemu-img to exit if an unknown option is detected, >> instead of trying to continue with a set of arguments which may be >> incorrect. >> >> Signed-off-by: Jes Sorens

[Qemu-devel] Re: [PATCH 3/3] Fail if detecting an unknown option

2010-12-06 Thread Jes Sorensen
On 12/03/10 13:30, Kevin Wolf wrote: > Am 02.12.2010 18:46, schrieb jes.soren...@redhat.com: >> diff --git a/qemu-img.c b/qemu-img.c >> index d0dc445..f2e1c94 100644 >> --- a/qemu-img.c >> +++ b/qemu-img.c >> @@ -304,6 +304,12 @@ static int img_create(int argc, char **argv) >> flags = 0; >>

[Qemu-devel] [PATCH v2 0/3] Cleanup qemu-img code

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Hi, These patches moves the handling of block help printing to shared code, which allows the "?" detection to happen early in the parsing, instead of half way down img_create() and img_convert(). I would like to see this happen as I would like to pull some of the code out of i

[Qemu-devel] [PATCH 3/3] Fail if detecting an unknown option

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen This patch changes qemu-img to exit if an unknown option is detected, instead of trying to continue with a set of arguments which may be incorrect. Signed-off-by: Jes Sorensen --- qemu-img.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qemu

[Qemu-devel] [PATCH 2/3] Fix formatting and missing braces in qemu-img.c

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen Reviewed-by: Stefan Hajnoczi --- qemu-img.c | 77 +++ 1 files changed, 51 insertions(+), 26 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 7863835..2a54ae2 100644 --- a/qemu-img.c

[Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen This consolidates the printing of block driver options in print_block_option_help() which is called from both img_create() and img_convert(). This allows for the "?" detection to be done just after the parsing of options and the filename, instead of half way down the codepath

Re: [Qemu-devel] implementation of Vmul instruction in QEMU that seems to be illogical

2010-12-06 Thread Paul Brook
> Logically, implementation of Vmull.s32 and vmul.u32 is just similar to the > 8 and 16 bit cases. For example: > case 4: gen_helper_neon_mull_s32(dest, a, b); break; > case 5: gen_helper_neon_mull_u32(dest, a, b); break; > I implemented in this way and tested. It is OK. So I can't understa

Re: [Qemu-devel] [PATCH 3/3] Fail if detecting an unknown option

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 6, 2010 at 8:17 AM, wrote: > From: Jes Sorensen > > This patch changes qemu-img to exit if an unknown option is detected, > instead of trying to continue with a set of arguments which may be > incorrect. > > Signed-off-by: Jes Sorensen > --- >  qemu-img.c |    8 >  1 files

[Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual.

2010-12-06 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- hw/grlib_gptimer.c | 448 1 files changed, 448 insertions(+), 0 deletions(-) diff --git a/hw/grlib_gptimer.c b/hw/grlib_gptimer.c new file mode 100644 index 000..41edbe4 --- /dev/null +++ b/hw/grlib_gpt

[Qemu-devel] [PATCH 2/6] [RFC] Emulation of GRLIB IRQMP as defined in GRLIB IP Core User's Manual.

2010-12-06 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- hw/grlib_irqmp.c | 416 ++ 1 files changed, 416 insertions(+), 0 deletions(-) diff --git a/hw/grlib_irqmp.c b/hw/grlib_irqmp.c new file mode 100644 index 000..69e1553 --- /dev/null +++ b/hw/grlib_irqmp.c

[Qemu-devel] [PATCH 6/6] [RFC] SPARCV8 asr17 register support.

2010-12-06 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- hw/leon3.c |6 ++ target-sparc/cpu.h |1 + target-sparc/machine.c |2 ++ target-sparc/translate.c | 10 ++ 4 files changed, 19 insertions(+), 0 deletions(-) diff --git a/hw/leon3.c b/hw/leon3.c index ba61081..960

[Qemu-devel] [PATCH 0/6] [RFC] New SPARC machine: Leon3

2010-12-06 Thread Fabien Chouteau
Hi everyone, I'm glad to submit my first patches to the Qemu-devel list. This patch set introduces a new SPARC V8 machine: Leon3. It's an open-source VHDL System-On-Chip, well known in space industry (more information on http://www.gaisler.com). Leon3 is made of multiple components available in t

[Qemu-devel] [PATCH 5/6] [RFC] Emulation of Leon3.

2010-12-06 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- Makefile.target |5 +- hw/leon3.c | 310 ++ target-sparc/cpu.h | 10 ++ target-sparc/helper.c|2 +- target-sparc/op_helper.c | 30 - 5 files changed, 353 insertions(+)

[Qemu-devel] [PATCH 4/6] [RFC] Header file for the GRLIB components.

2010-12-06 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- hw/grlib.h | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/hw/grlib.h b/hw/grlib.h new file mode 100644 index 000..eab7974 --- /dev/null +++ b/hw/grlib.h @@ -0,0 +1,27 @@ +#ifndef _GRLIB_H_ +#define _GRLIB

[Qemu-devel] [PATCH 3/6] [RFC] Emulation of GRLIB APB UART as defined in GRLIB IP Core User's Manual.

2010-12-06 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- hw/grlib_apbuart.c | 231 1 files changed, 231 insertions(+), 0 deletions(-) diff --git a/hw/grlib_apbuart.c b/hw/grlib_apbuart.c new file mode 100644 index 000..32a5362 --- /dev/null +++ b/hw/grlib_apb

Re: [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 6, 2010 at 8:17 AM, wrote: > @@ -694,6 +721,11 @@ static int img_convert(int argc, char **argv) > >     out_filename = argv[argc - 1]; > > +    if (options && !strcmp(options, "?")) { > +        ret = print_block_option_help(out_filename, out_fmt); > +        goto out2; > +    } > + >

[Qemu-devel] Re: [PATCH 3/3] Fail if detecting an unknown option

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 09:02, schrieb Jes Sorensen: > On 12/03/10 13:30, Kevin Wolf wrote: >> Am 02.12.2010 18:46, schrieb jes.soren...@redhat.com: >>> diff --git a/qemu-img.c b/qemu-img.c >>> index d0dc445..f2e1c94 100644 >>> --- a/qemu-img.c >>> +++ b/qemu-img.c >>> @@ -304,6 +304,12 @@ static int img_cre

Re: [Qemu-devel] [PATCH v8 7/7] virtio-console: Enable port throttling when chardev is slow to consume data

2010-12-06 Thread Paul Brook
> On (Thu) Dec 02 2010 [17:31:36], Paul Brook wrote: > > > > > when there's a partial write, it tries to do a write again, which > > > > > will fail with -EAGAIN. > > > > > > > > Doesn't that cause the first partial chunk to be incorrectly > > > > transmitted twice? You may only return EAGAIN if n

Re: [Qemu-devel] [PATCH v8 7/7] virtio-console: Enable port throttling when chardev is slow to consume data

2010-12-06 Thread Amit Shah
On (Mon) Dec 06 2010 [09:35:10], Paul Brook wrote: > > On (Thu) Dec 02 2010 [17:31:36], Paul Brook wrote: > > > > > > when there's a partial write, it tries to do a write again, which > > > > > > will fail with -EAGAIN. > > > > > > > > > > Doesn't that cause the first partial chunk to be incorrect

[Qemu-devel] Re: [PATCH 3/3] Fail if detecting an unknown option

2010-12-06 Thread Jes Sorensen
On 12/06/10 10:37, Kevin Wolf wrote: > Am 06.12.2010 09:02, schrieb Jes Sorensen: >> On 12/03/10 13:30, Kevin Wolf wrote: >> There is a perfectly logical explanation for that. Doing that would >> require for me to have clue, which is a bit much to expect :) >> >> That said, we should really do the

Re: [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options

2010-12-06 Thread Jes Sorensen
On 12/06/10 10:32, Stefan Hajnoczi wrote: > On Mon, Dec 6, 2010 at 8:17 AM, wrote: >> @@ -694,6 +721,11 @@ static int img_convert(int argc, char **argv) >> >> out_filename = argv[argc - 1]; >> >> +if (options && !strcmp(options, "?")) { >> +ret = print_block_option_help(out_filena

Re: [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 6, 2010 at 10:20 AM, Jes Sorensen wrote: > On 12/06/10 10:32, Stefan Hajnoczi wrote: >> On Mon, Dec 6, 2010 at 8:17 AM,   wrote: >>> @@ -694,6 +721,11 @@ static int img_convert(int argc, char **argv) >>> >>>     out_filename = argv[argc - 1]; >>> >>> +    if (options && !strcmp(options

Re: [Qemu-devel] [PATCH 0/6] [RFC] New SPARC machine: Leon3

2010-12-06 Thread Artyom Tarasenko
On Mon, Dec 6, 2010 at 10:26 AM, Fabien Chouteau wrote: > Hi everyone, > I'm glad to submit my first patches to the Qemu-devel list. > > This patch set introduces a new SPARC V8 machine: Leon3. It's an open-source > VHDL System-On-Chip, well known in space industry (more information on > http://ww

Re: [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options

2010-12-06 Thread Jes Sorensen
On 12/06/10 11:37, Stefan Hajnoczi wrote: > On Mon, Dec 6, 2010 at 10:20 AM, Jes Sorensen wrote: >> On 12/06/10 10:32, Stefan Hajnoczi wrote: >>> On Mon, Dec 6, 2010 at 8:17 AM, wrote: >>> Why goto out2 and not just return like the bs > 1 && out_baseimg check? >> >> It is cleaner, I'd rather con

Re: [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 6, 2010 at 10:47 AM, Jes Sorensen wrote: > On 12/06/10 11:37, Stefan Hajnoczi wrote: >> On Mon, Dec 6, 2010 at 10:20 AM, Jes Sorensen >> wrote: >>> On 12/06/10 10:32, Stefan Hajnoczi wrote: On Mon, Dec 6, 2010 at 8:17 AM,   wrote: Why goto out2 and not just return like the

Re: [Qemu-devel] [PATCH, RFT] monitor: implement x86 info tlb for PAE and long modes

2010-12-06 Thread Alexander Graf
On 05.12.2010, at 17:25, Blue Swirl wrote: > 'info tlb' didn't show correct information for PAE mode and > x86_64 long mode. > > Implement the missing modes. Also print NX bit for PAE and long modes. > Fix off-by-one error in 32 bit mode mask. > > Signed-off-by: Blue Swirl > --- > > I didn't

[Qemu-devel] qemu bug report?

2010-12-06 Thread Witold Paluszynski
I am running qemu from a qcow virtual disk with Windows XP installed trying various network options. Qemu is running on a Ubuntu x86_64 machine to which I am connected remotely by ssh from a Sun Ray terminal on a Solaris Sun SPARC machine. Upon starting, qemu says on the terminal: unknown keycode

[Qemu-devel] Re: Block device resize detection

2010-12-06 Thread Alexander Graf
Hi Vandeir, On 06.12.2010, at 11:49, Vandeir Eduardo wrote: > Hi guys, > > I have a KVM guest machine, lets name it VMTEST, > using an iSCSI LUN as a virtio device. Something like this: > > > >dev='/dev/disk/by-path/ip-w.x.y.z:3260-iscsi-iqn.2010-10.br.furb.inf:disk0-lun-4'/> > >

[Qemu-devel] Re: Block device resize detection

2010-12-06 Thread Vandeir Eduardo
Humm, unfortunately I'm not a developer, only a sys admin, but this would be a nice feature to avoid restarting vm guests. I didn't want, but I think I will have to add another software layer (LVM) inside the guest vm. This way, when I need more space, I hot-add another device and add it to the v

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-12-06 Thread Kevin Wolf
Am 17.11.2010 22:42, schrieb Christian Brunner: > Here is another update for the ceph storage driver. It includes changes > for the annotations Stefan made last week and a bit more things Sage > discovered while looking over the driver again. > > I really hope that this time we are not only close,

Re: [Qemu-devel] [PATCH, RFT] monitor: implement x86 info tlb for PAE and long modes

2010-12-06 Thread Ian Campbell
On Mon, 2010-12-06 at 12:12 +0100, Alexander Graf wrote: > On 05.12.2010, at 17:25, Blue Swirl wrote: > > > 'info tlb' didn't show correct information for PAE mode and > > x86_64 long mode. > > > > Implement the missing modes. Also print NX bit for PAE and long modes. > > Fix off-by-one error in

[Qemu-devel] Re: Block device resize detection

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 12:29, schrieb Alexander Graf: > On 06.12.2010, at 11:49, Vandeir Eduardo wrote: >> >> I have a KVM guest machine, lets name it VMTEST, >> using an iSCSI LUN as a virtio device. Something like this: >> >> >> >> > dev='/dev/disk/by-path/ip-w.x.y.z:3260-iscsi-iqn.2010-10.br.furb.i

Re: [Qemu-devel] [PATCH v8 7/7] virtio-console: Enable port throttling when chardev is slow to consume data

2010-12-06 Thread Paul Brook
> > As with the DMA interface added a while ago, I believe it's important to > > get these APIs right. Quick hacks to support limited use-cases just end > > up needing a complete rewrite (or even worse multiple concurrent > > APIs/implementations) once we actually start using them seriously. > >

Re: [Qemu-devel] [PULL 00/16] Block patches

2010-12-06 Thread Anthony Liguori
On 11/30/2010 11:58 AM, Kevin Wolf wrote: The following changes since commit f711df67d611e4762966a249742a5f7499e19f99: microblaze: target-ify target_ucontext (2010-11-23 10:04:30 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony I see: commi

Re: [Qemu-devel] [PULL 00/16] Block patches

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 14:32, schrieb Anthony Liguori: > On 11/30/2010 11:58 AM, Kevin Wolf wrote: >> The following changes since commit f711df67d611e4762966a249742a5f7499e19f99: >> >>microblaze: target-ify target_ucontext (2010-11-23 10:04:30 +0100) >> >> are available in the git repository at: >>g

[Qemu-devel] [PATCHv7 04/16] Add get_fw_dev_path callback to ISA bus in qdev.

2010-12-06 Thread Gleb Natapov
Use device ioports to create unique device path. Signed-off-by: Gleb Natapov --- hw/isa-bus.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index c0ac7e9..c423c1b 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -31,11 +31,13

[Qemu-devel] [PATCHv7 06/16] Add get_fw_dev_path callback to IDE bus.

2010-12-06 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/ide/qdev.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 88ff657..01a181b 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -24,9 +24,12 @@ /* - */

[Qemu-devel] [PATCHv7 00/16] boot order specification

2010-12-06 Thread Gleb Natapov
I am using open firmware naming scheme to specify device path names. Changes from last version: rebase to master, added pointers to OF specs, added bootindex parameter documentation. Gleb Natapov (16): Introduce fw_name field to DeviceInfo structure. Introduce new Bu

[Qemu-devel] [PATCHv7 03/16] Keep track of ISA ports ISA device is using in qdev.

2010-12-06 Thread Gleb Natapov
Store all io ports used by device in ISADevice structure. Signed-off-by: Gleb Natapov --- hw/cs4231a.c |1 + hw/fdc.c |3 +++ hw/gus.c |4 hw/ide/isa.c |2 ++ hw/isa-bus.c | 25 + hw/isa.h |4 hw/m48t59.c

[Qemu-devel] [PATCHv7 10/16] Add get_fw_dev_path callback for usb bus.

2010-12-06 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/usb-bus.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 256b881..8b4583c 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -5,11 +5,13 @@ #include "monitor.h"

[Qemu-devel] [PATCHv7 01/16] Introduce fw_name field to DeviceInfo structure.

2010-12-06 Thread Gleb Natapov
Add "fw_name" to DeviceInfo to use in device path building. In contrast to "name" "fw_name" should refer to functionality device provides instead of particular device model like "name" does. Signed-off-by: Gleb Natapov --- hw/fdc.c|1 + hw/ide/isa.c|1 + hw/ide/qdev.c |

[Qemu-devel] [PATCHv7 09/16] Record which USBDevice USBPort belongs too.

2010-12-06 Thread Gleb Natapov
Ports on root hub will have NULL here. This is needed to reconstruct path from device to its root hub to build device path. Signed-off-by: Gleb Natapov --- hw/usb-bus.c |3 ++- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |2 +- hw/usb-uhci.c |2 +- hw/usb.h

[Qemu-devel] [PATCHv7 11/16] Add get_fw_dev_path callback to scsi bus.

2010-12-06 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/scsi-bus.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 93f0e9a..7febb86 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -5,9 +5,12 @@ #include "qdev.h" #include "blockde

[Qemu-devel] [PATCHv7 02/16] Introduce new BusInfo callback get_fw_dev_path.

2010-12-06 Thread Gleb Natapov
New get_fw_dev_path callback will be used for build device path usable by firmware in contrast to qdev qemu internal device path. Signed-off-by: Gleb Natapov --- hw/qdev.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index bc71110..f72fbde

[Qemu-devel] [PATCHv7 13/16] Change fw_cfg_add_file() to get full file path as a parameter.

2010-12-06 Thread Gleb Natapov
Change fw_cfg_add_file() to get full file path as a parameter instead of building one internally. Two reasons for that. First caller may need to know how file is named. Second this moves policy of file naming out from fw_cfg. Platform may want to use more then two levels of directories for instance

[Qemu-devel] [PATCH v2 2/2] make kvmclock value idempotent for stopped machine

2010-12-06 Thread Glauber Costa
Although we never made such commitment clear (well, to the best of my knowledge), some people expect that two savevm issued in sequence in a stopped machine will yield the same results. This is not a crazy requirement, since we don't expect a stopped machine to be updating its state, for any device

[Qemu-devel] [PATCHv7 05/16] Store IDE bus id in IDEBus structure for easy access.

2010-12-06 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/ide/cmd646.c |4 ++-- hw/ide/internal.h |3 ++- hw/ide/isa.c |2 +- hw/ide/piix.c |4 ++-- hw/ide/qdev.c |3 ++- hw/ide/via.c |4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/ide/cmd646.c b/

[Qemu-devel] [PATCHv7 08/16] Add get_fw_dev_path callback for pci bus.

2010-12-06 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/pci.c | 108 - 1 files changed, 85 insertions(+), 23 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 0c15b13..e7ea907 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -43,6 +43,7 @@ static void pcibus_

[Qemu-devel] [PATCHv7 15/16] Add notifier that will be called when machine is fully created.

2010-12-06 Thread Gleb Natapov
Action that depends on fully initialized device model should register with this notifier chain. Signed-off-by: Gleb Natapov --- sysemu.h |2 ++ vl.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index 48f8eee..c42f33a 100644 -

[Qemu-devel] [PATCHv7 16/16] Pass boot device list to firmware.

2010-12-06 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/fw_cfg.c | 14 ++ sysemu.h|1 + vl.c| 48 3 files changed, 63 insertions(+), 0 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index 7b9434f..20a816f 100644 --- a/hw/fw_cfg.c

[Qemu-devel] [PATCHv7 12/16] Add bootindex parameter to net/block/fd device

2010-12-06 Thread Gleb Natapov
If bootindex is specified on command line a string that describes device in firmware readable way is added into sorted list. Later this list will be passed into firmware to control boot order. Signed-off-by: Gleb Natapov --- block_int.h |4 +++- hw/e1000.c |4 hw/eepro100.c

[Qemu-devel] [PATCH v2 0/2] savevm odness related to kvmclock

2010-12-06 Thread Glauber Costa
Some users told me that savevm path is behaving oddly wrt kvmclock. The first oddness is that a guarantee we never made (AFAIK) is being broken: two consecutive "savevm" operations, with the machine stopped in between produces different results, due to the call to KVM_GET_CLOCK ioctl. I believe the

[Qemu-devel] [PATCHv7 14/16] Add bootindex for option roms.

2010-12-06 Thread Gleb Natapov
Extend -option-rom command to have additional parameter ,bootindex=. Signed-off-by: Gleb Natapov --- hw/loader.c| 16 +++- hw/loader.h|8 hw/multiboot.c |3 ++- hw/ne2000.c|2 +- hw/nseries.c |4 ++-- hw/palm.c |6 +++--- hw/pc.c

[Qemu-devel] Re: [PATCH v2 0/2] savevm odness related to kvmclock

2010-12-06 Thread Paolo Bonzini
On 12/06/2010 03:03 PM, Glauber Costa wrote: Some users told me that savevm path is behaving oddly wrt kvmclock. The first oddness is that a guarantee we never made (AFAIK) is being broken: two consecutive "savevm" operations, with the machine stopped in between produces different results, due to

[Qemu-devel] [PATCHv7 07/16] Add get_fw_dev_path callback for system bus.

2010-12-06 Thread Gleb Natapov
Prints out mmio or pio used to access child device. Signed-off-by: Gleb Natapov --- hw/pci_host.c |2 ++ hw/sysbus.c | 30 ++ hw/sysbus.h |4 3 files changed, 36 insertions(+), 0 deletions(-) diff --git a/hw/pci_host.c b/hw/pci_host.c index bc5b771

[Qemu-devel] [PATCH v2 1/2] Do not register kvmclock savevm section if kvmclock is disabled.

2010-12-06 Thread Glauber Costa
Usually nobody usually thinks about that scenario (me included and specially), but kvmclock can be actually disabled in the host. It happens in two scenarios: 1. host too old. 2. we passed -kvmclock to our -cpu parameter. In both cases, we should not register kvmclock savevm section. This patch

Re: [Qemu-devel] [PULL 00/16] Block patches

2010-12-06 Thread Anthony Liguori
On 12/06/2010 07:41 AM, Kevin Wolf wrote: I see: commit 393f398b69f9baadc3f29d822a0b5b74ca63b919 Author: Richard Henderson Date: Mon Nov 22 14:57:58 2010 -0800 tcg-ia64: Fix warning in qemu_ld. The usermode version of qemu_ld doesn't used mem_index, leading to set-but-not

[Qemu-devel] [PATCH v3 0/7] Cleanup qemu-img code

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Hi, These patches applies a number of cleanups to qemu-img.c as well as a minor bug in qemu-malloc.c. The handling of block help printing is moved to shared code, which allows the "?" detection to happen early in the parsing, instead of half way down img_create() and img_con

[Qemu-devel] [PATCH 1/7] Add missing tracing to qemu_mallocz()

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- qemu-malloc.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/qemu-malloc.c b/qemu-malloc.c index 28fb05a..b9b3851 100644 --- a/qemu-malloc.c +++ b/qemu-malloc.c @@ -64,10 +64,13 @@ void *qemu_realloc(void *ptr, siz

[Qemu-devel] [PATCH 2/7] Use qemu_mallocz() instead of calloc() in img_convert()

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- qemu-img.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index fa77ac0..eca99c4 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -699,11 +699,7 @@ static int img_convert(int argc, char **argv

[Qemu-devel] [PATCH 5/7] Consolidate printing of block driver options

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen This consolidates the printing of block driver options in print_block_option_help() which is called from both img_create() and img_convert(). This allows for the "?" detection to be done just after the parsing of options and the filename, instead of half way down the codepath

[Qemu-devel] [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- qemu-img.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index aded72d..7f4939e 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -314,13 +314,15 @@ static int img_create(int argc, char **

[Qemu-devel] [PATCH 6/7] Fix formatting and missing braces in qemu-img.c

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen Reviewed-by: Stefan Hajnoczi --- qemu-img.c | 77 +++ 1 files changed, 51 insertions(+), 26 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index c7d0ca8..d812db0 100644 --- a/qemu-img.c

[Qemu-devel] [PATCH 3/7] img_convert(): Only try to free bs[] entries if bs is valid.

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen This allows for jumping to 'out:' consistently for error exit. Signed-off-by: Jes Sorensen --- qemu-img.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index eca99c4..aded72d 100644 --- a/qemu-img.c +++ b/qemu-im

[Qemu-devel] [PATCH 7/7] Fail if detecting an unknown option

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen This patch changes qemu-img to exit if an unknown option is detected, instead of trying to continue with a set of arguments which may be incorrect. Signed-off-by: Jes Sorensen --- qemu-img.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qemu

[Qemu-devel] [PULL 0/4]: Monitor queue

2010-12-06 Thread Luiz Capitulino
Anthony, QMP fixes pull request. The changes (since 2c90fe2b71df2534884bce96d90cbfcc93aeedb8) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git for-anthony Luiz Capitulino (3): QMP: Fix default response regression QMP: Drop dead code QMP: Si

[Qemu-devel] [PATCH 3/4] QMP: Simplify monitor_json_emitter()

2010-12-06 Thread Luiz Capitulino
Use the ternary operator instead of an if (also fixes bad indentation). Signed-off-by: Luiz Capitulino --- monitor.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 1e8b1fc..f1aebc1 100644 --- a/monitor.c +++ b/monitor.c @@ -351,10 +351,8

[Qemu-devel] [PATCH 2/4] QMP: Drop dead code

2010-12-06 Thread Luiz Capitulino
The first if/else clause in handler_audit() makes no sense for two reasons: 1. this function is now called only by QMP code, so testing if it's a QMP call makes no sense anymore 2. the else clause first asserts that there's no error in the monitor object, then it tries to free it!

[Qemu-devel] [PATCH 4/4] correct migrate_set_speed's args_type

2010-12-06 Thread Luiz Capitulino
From: Wen Congyang The args_type of migrate_set_speed in qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped. This bug was caused by 07de3e60b05 and hence affects master only. Signed-off-by: Wen Congyang Signed-off-by: Luiz Capitulino --- qmp-commands.hx |

[Qemu-devel] Re: [PATCH 1/7] Add missing tracing to qemu_mallocz()

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 06, 2010 at 03:25:34PM +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > qemu-malloc.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) Reviewed-by: Stefan Hajnoczi

[Qemu-devel] Re: [PATCH 2/7] Use qemu_mallocz() instead of calloc() in img_convert()

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 06, 2010 at 03:25:35PM +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > qemu-img.c |8 ++-- > 1 files changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Stefan Hajnoczi

[Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 06, 2010 at 03:25:37PM +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > qemu-img.c | 12 > 1 files changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Stefan Hajnoczi

[Qemu-devel] Re: [PATCH 5/7] Consolidate printing of block driver options

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 06, 2010 at 03:25:38PM +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > This consolidates the printing of block driver options in > print_block_option_help() which is called from both img_create() and > img_convert(). > > This allows for the "?" detection to be done jus

[Qemu-devel] Re: [PATCH 6/7] Fix formatting and missing braces in qemu-img.c

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 06, 2010 at 03:25:39PM +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > Reviewed-by: Stefan Hajnoczi > --- > qemu-img.c | 77 +++ > 1 files changed, 51 insertions(+), 26 deletions(

[Qemu-devel] [PATCH 1/4] QMP: Fix default response regression

2010-12-06 Thread Luiz Capitulino
Commit 030db6e89d dropped do_info() usage from QMP and introduced qmp_call_query_cmd(). However, the new function doesn't emit QMP's default OK response when the handler doesn't return data. Fix that by also calling monitor_protocol_emitter() when ret_data == NULL, so that the default response is

[Qemu-devel] [PATCH 1/2] Fix commandline handling for ARM semihosted executables

2010-12-06 Thread Peter Maydell
From: Wolfgang Schildbach Use the copy of the command line that loader_build_argptr() sets up in guest memory as the command line to return from the ARM SYS_GET_CMDLINE semihosting call. Previously we were using a pointer to memory which had already been freed before the guest program started. T

[Qemu-devel] Re: [PATCH 3/7] img_convert(): Only try to free bs[] entries if bs is valid.

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 06, 2010 at 03:25:36PM +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > This allows for jumping to 'out:' consistently for error exit. > > Signed-off-by: Jes Sorensen > --- > qemu-img.c | 13 - > 1 files changed, 8 insertions(+), 5 deletions(-) Reviewed

[Qemu-devel] Re: [PATCH 7/7] Fail if detecting an unknown option

2010-12-06 Thread Stefan Hajnoczi
On Mon, Dec 06, 2010 at 03:25:40PM +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > This patch changes qemu-img to exit if an unknown option is detected, > instead of trying to continue with a set of arguments which may be > incorrect. > > Signed-off-by: Jes Sorensen > --- > qemu

[Qemu-devel] [PATCH 0/2] ARM: fix commandline handling for semihosted executables

2010-12-06 Thread Peter Maydell
This patchset fixes the commandline handling for ARM semihosted executables run under linux-user mode, and cleans up the resulting unused variable in the linux-user image_info struct. The code is all by Wolfgang but he is having difficulty sending properly formatted patches to the list so I am retr

Re: [Qemu-devel] [PATCH 0/6] [RFC] New SPARC machine: Leon3

2010-12-06 Thread Fabien Chouteau
On 12/06/2010 11:44 AM, Artyom Tarasenko wrote: On Mon, Dec 6, 2010 at 10:26 AM, Fabien Chouteau wrote: Hi everyone, I'm glad to submit my first patches to the Qemu-devel list. This patch set introduces a new SPARC V8 machine: Leon3. It's an open-source VHDL System-On-Chip, well known in space

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-12-06 Thread Avi Kivity
On 12/01/2010 11:34 PM, Stefan Hajnoczi wrote: >> The guest CPU utilization numbers include an efficiency metric: %vcpu >> per MB/sec. Here we see significant improvements too. Guests that >> previously couldn't get more CPU work done now have regained some >> breathing space. > > Thanks f

[Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 15:25, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > qemu-img.c | 12 > 1 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index aded72d..7f4939e 100644 > --- a/qemu-img.c > ++

[Qemu-devel] [PATCH 2/2] Remove dead code for ARM semihosting commandline handling

2010-12-06 Thread Peter Maydell
From: Wolfgang Schildbach There are some bits in the code which were used to store the commandline for the semihosting call. These bits are now write-only and can be removed. Signed-off-by: Wolfgang Schildbach Reviewed-by: Peter Maydell --- bsd-user/bsdload.c |2 -- bsd-user/qemu.h

[Qemu-devel] Re: [PATCH v3 0/7] Cleanup qemu-img code

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 15:25, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Hi, > > These patches applies a number of cleanups to qemu-img.c as well as a > minor bug in qemu-malloc.c. > > The handling of block help printing is moved to shared code, which > allows the "?" detection to happen

[Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Jes Sorensen
On 12/06/10 16:25, Kevin Wolf wrote: >> } >> n = get_option_parameter(param, BLOCK_OPT_SIZE)->value.n; >> free_option_parameters(param); >> >> bs = bdrv_new_open(filename, fmt, BDRV_O_FLAGS | BDRV_O_RDWR); >> if (!bs) { >> -return 1; >> +ret = -1; >> +

[Qemu-devel] [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- qemu-img.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index aded72d..2deac67 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -314,13 +314,15 @@ static int img_create(int argc, char

[Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 16:45, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > qemu-img.c | 14 +- > 1 files changed, 9 insertions(+), 5 deletions(-) > @@ -1432,7 +1434,7 @@ static int img_resize(int argc, char **argv) > int c, ret, relati

[Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Jes Sorensen
On 12/06/10 16:57, Kevin Wolf wrote: > bdrv_delete doesn't check for NULL, so this still isn't enough. Try > something like "qemu-img resize -f vmdx foo +0" and you'll get a segfault. G :( It's a bummer things are so inconsistent throughout QEMU, most of the free() functions can handle it. U

[Qemu-devel] [PATCH v6 1/5] docs: Add QED image format specification

2010-12-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- docs/specs/qed_spec.txt | 130 +++ 1 files changed, 130 insertions(+), 0 deletions(-) create mode 100644 docs/specs/qed_spec.txt diff --git a/docs/specs/qed_spec.txt b/docs/specs/qed_spec.txt new file mode 100644 in

[Qemu-devel] [PATCH v6 5/5] qed: Consistency check support

2010-12-06 Thread Stefan Hajnoczi
This patch adds support for the qemu-img check command. It also introduces a dirty bit in the qed header to mark modified images as needing a check. This bit is cleared when the image file is closed cleanly. If an image file is opened and it has the dirty bit set, a consistency check will run an

[Qemu-devel] [PATCH v6 0/5] qed: Add QEMU Enhanced Disk format

2010-12-06 Thread Stefan Hajnoczi
For a changelog against v5, see below. QEMU Enhanced Disk format is a disk image format that forgoes features found in qcow2 in favor of better levels of performance and data integrity. Due to its simpler on-disk layout, it is possible to safely perform metadata updates more efficiently. Install

[Qemu-devel] [PATCH v5 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- qemu-img.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index aded72d..6b2b18b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -314,13 +314,15 @@ static int img_create(int argc,

[Qemu-devel] [PATCH v6 2/5] qed: Add QEMU Enhanced Disk image format

2010-12-06 Thread Stefan Hajnoczi
This patch introduces the qed on-disk layout and implements image creation. Later patches add read/write and other functionality. Signed-off-by: Stefan Hajnoczi --- Makefile.objs |1 + block/qed.c | 554 + block/qed.h | 148 +

[Qemu-devel] [PATCH v6 4/5] qed: Read/write support

2010-12-06 Thread Stefan Hajnoczi
This patch implements the read/write state machine. Operations are fully asynchronous and multiple operations may be active at any time. Allocating writes lock tables to ensure metadata updates do not interfere with each other. If two allocating writes need to update the same L2 table they will

[Qemu-devel] [PATCH v6 3/5] qed: Table, L2 cache, and cluster functions

2010-12-06 Thread Stefan Hajnoczi
This patch adds code to look up data cluster offsets in the image via the L1/L2 tables. The L2 tables are writethrough cached in memory for performance (each read/write requires a lookup so it is essential to cache the tables). With cluster lookup code in place it is possible to implement bdrv_is

Re: [Qemu-devel] [PATCH 01/14] ./block/iscsi/init.c

2010-12-06 Thread Kevin Wolf
Am 03.12.2010 22:23, schrieb ronnie sahlberg: > Thankyou. > > On Sat, Dec 4, 2010 at 7:32 AM, Stefan Hajnoczi wrote: >> >> You want the library to be GPL, not LGPL? > > I have changed it to LGPLv3 for next submission. Please use "LGPL 2.1 or later". IIRC, qemu has some parts that are GPL 2 only

[Qemu-devel] Re: [PATCH v5 4/7] Make error handling more consistent in img_create() and img_resize()

2010-12-06 Thread Kevin Wolf
Am 06.12.2010 17:08, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 1/8] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed

2010-12-06 Thread Nathan Froyd
On Thu, Nov 11, 2010 at 06:23:55PM +, Peter Maydell wrote: > Correct the decoding of source and destination registers > for the VFP forms of the VCVT instructions which convert > between floating point and integer or fixed-point. > > Signed-off-by: Peter Maydell Reviewed-by: Nathan Froyd I

Re: [Qemu-devel] [PATCH 1/8] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed

2010-12-06 Thread Peter Maydell
On 6 December 2010 16:30, Nathan Froyd wrote: > On Thu, Nov 11, 2010 at 06:23:55PM +, Peter Maydell wrote: >> Correct the decoding of source and destination registers >> for the VFP forms of the VCVT instructions which convert >> between floating point and integer or fixed-point. >> >> Signed-

Re: [Qemu-devel] [PATCH 1/8] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed

2010-12-06 Thread Nathan Froyd
On Mon, Dec 06, 2010 at 04:48:25PM +, Peter Maydell wrote: > I'm not sure how well it would fit into being committed to qemu (yet): > it works as a program where you run half of it on real ARM hardware > and the other half under qemu (or valgrind) and it compares register > results after execut

  1   2   >