Hi,
+static void ahci_trigger_irq(AHCIState *s, AHCIDevice *d,
+ int irq_type)
+static void ahci_check_irq(AHCIState *s)
MSI support would be nice to have.
+#ifndef min
+#define min(a, b) ((a)< (b) ? (a) : (b))
+#endif
osdep.h has MIN/MAX macros.
+static
On 11/18/10 01:41, Hidetoshi Seto wrote:
> This patch introduce a fallback mechanism for old systems that do not
> support utimensat(). This fix build failure with following warnings:
>
> hw/virtio-9p-local.c: In function 'local_utimensat':
> hw/virtio-9p-local.c:479: warning: implicit declaratio
On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote:
> > >> If so: does qemu
> > >>emulate this correctly?
> > >
> > >It mostly does.
> >
> > I doubt it actually enables/disables the legacy vga ports.
>
> I'll check when I have the time. We can fix it if it doesn't,
>
So many gue
On Wed, Nov 17, 2010 at 04:06:38PM +0200, Michael S. Tsirkin wrote:
> On Tue, Nov 16, 2010 at 05:26:09PM +0900, Isaku Yamahata wrote:
> > This patch implements helper functions for pcie aer capability
> > which will be used later.
> >
> > Signed-off-by: Isaku Yamahata
>
> OK, I applied this and
On 11/18/10 09:09, Gleb Natapov wrote:
On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote:
If so: does qemu
emulate this correctly?
It mostly does.
I doubt it actually enables/disables the legacy vga ports.
I'll check when I have the time. We can fix it if it doesn't,
S
On Thu, Nov 18, 2010 at 09:02:35AM +0200, Michael S. Tsirkin wrote:
> > +/*
> > + * TODO:
> > + * each device should know what to do on RST#.
> > + * move pci_device_reset_default() into each callback.
> > + */
>
> Is this doing anything besides give devices
On Thu, Nov 18, 2010 at 04:29:10PM +0900, Isaku Yamahata wrote:
> On Thu, Nov 18, 2010 at 09:05:30AM +0200, Michael S. Tsirkin wrote:
> > On Wed, Nov 17, 2010 at 01:50:27PM +0900, Isaku Yamahata wrote:
> > > Emulates secondary bus reset when secondary bus reset bit
> > > is written from 0 to 1.
> >
(2010/11/18 17:02), Jes Sorensen wrote:
> On 11/18/10 01:41, Hidetoshi Seto wrote:
>> This patch introduce a fallback mechanism for old systems that do not
>> support utimensat(). This fix build failure with following warnings:
>>
>> hw/virtio-9p-local.c: In function 'local_utimensat':
>> hw/virti
On Thu, Nov 18, 2010 at 05:11:17PM +0900, Isaku Yamahata wrote:
> On Wed, Nov 17, 2010 at 04:06:38PM +0200, Michael S. Tsirkin wrote:
> > On Tue, Nov 16, 2010 at 05:26:09PM +0900, Isaku Yamahata wrote:
> > > This patch implements helper functions for pcie aer capability
> > > which will be used lat
On Thu, Nov 18, 2010 at 05:22:50PM +0900, Isaku Yamahata wrote:
> On Thu, Nov 18, 2010 at 09:02:35AM +0200, Michael S. Tsirkin wrote:
> > > +/*
> > > + * TODO:
> > > + * each device should know what to do on RST#.
> > > + * move pci_device_reset_default() into each c
On Thu, Nov 18, 2010 at 10:09:35AM +0200, Gleb Natapov wrote:
> On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote:
> > > >> If so: does qemu
> > > >>emulate this correctly?
> > > >
> > > >It mostly does.
> > >
> > > I doubt it actually enables/disables the legacy vga ports.
> >
On Thu, Nov 18, 2010 at 09:22:02AM +0100, Gerd Hoffmann wrote:
> On 11/18/10 09:09, Gleb Natapov wrote:
> >On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote:
> > If so: does qemu
> >emulate this correctly?
>
> It mostly does.
> >>>
> >>>I doubt it actually enables
On 11/18/10 09:48, Hidetoshi Seto wrote:
> (2010/11/18 17:02), Jes Sorensen wrote:
>> Hi Hidetoshi,
>>
>> I think the idea of the patch is good, but please move qemu_utimensat()
>> to oslib-posix.c and provide a wrapper for oslib-win32.c. It is
>> emulation for a system library function, so it does
On Thu, Nov 18, 2010 at 11:03:21AM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 18, 2010 at 10:09:35AM +0200, Gleb Natapov wrote:
> > On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote:
> > > > >> If so: does qemu
> > > > >>emulate this correctly?
> > > > >
> > > > >It mostly doe
On Thu, Nov 18, 2010 at 11:11:49AM +0200, Gleb Natapov wrote:
> On Thu, Nov 18, 2010 at 11:03:21AM +0200, Michael S. Tsirkin wrote:
> > On Thu, Nov 18, 2010 at 10:09:35AM +0200, Gleb Natapov wrote:
> > > On Wed, Nov 17, 2010 at 08:00:08PM +0200, Michael S. Tsirkin wrote:
> > > > > >> If so: does q
Am 17.11.2010 17:23, schrieb Stefan Hajnoczi:
> On Wed, Nov 17, 2010 at 1:41 PM, Kevin Wolf wrote:
>> Am 17.11.2010 13:43, schrieb Stefan Hajnoczi:
A typical sequence in qcow2 (simple cluster allocation) looks like this:
1. Update refcount table
2. bdrv_flush
3. Update L2
On Thu, Nov 18, 2010 at 11:30:27AM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 18, 2010 at 11:11:49AM +0200, Gleb Natapov wrote:
> > On Thu, Nov 18, 2010 at 11:03:21AM +0200, Michael S. Tsirkin wrote:
> > > On Thu, Nov 18, 2010 at 10:09:35AM +0200, Gleb Natapov wrote:
> > > > On Wed, Nov 17, 201
The changes make sense. Looks good.
Stefan
On Tue, Nov 16, 2010 at 1:15 AM, Michael Roth wrote:
> Daemon to be run in guest, or on host in standalone mode.
> (re-)implements some qemu utility functions used by core virtproxy.c
> code via wrapper functions. For built-in virtproxy code we will define
> these wrapper functions in terms of qem
Hello,
Could you please provide more data, what kinda of system and version are
you running on?
Jes
--
Silently fail with wrong vde socket dir
https://bugs.launchpad.net/bugs/676029
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Stat
> +static int vp_channel_send_all(VPDriver *drv, uint8_t *buf, int count)
> +{
> +int ret;
> +CharDriverState *chr = drv->chr;
> +
> +if (drv->chr != NULL) {
> +/* send data to guest via channel device's read handler */
> +vp_chr_read(chr, buf, count);
> +/* TODO
As a side-note to the larger control flow questions:
Why not read() into &drv->buf[drv->buflen] and use it directly with
vp_handle_packet(). I don't think we need memcpy or temporary buffers
since we already have a buffer in drv.
There are extra buffers and memcpys here which make the code more
On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote:
> 2010/11/16 Gleb Natapov :
> > On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote:
> >> >> Perhaps the FW path should use device class names if no name is
> >> >> specified.
> >> > What do you mean by "device class name". We can
This patch adds a field to DeviceInfo to tag devices as being not
hotpluggable. Any attempt to plug-in or -out such a device will
throw an error.
This check is done in addition to the check whenever the bus supports
hotplug, i.e. there is no need to tag devices which sit on busses
without hotplug
This patch tags all pci devices which belong to the piix3/4 chipsets as
not hotpluggable (Host bridge, ISA bridge, IDE controller, ACPI bridge).
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c |2 ++
hw/ide/piix.c |2 ++
hw/piix4.c |1 +
hw/piix_pci.c |2 ++
4 files cha
This patch tags all vga cards as not hotpluggable. The qemu
standard vga will never ever be hotpluggable. For cirrus + vmware
it might be possible to get that work some day. Todays we can't
handle that for a number of reasons though.
Signed-off-by: Gerd Hoffmann
---
hw/cirrus_vga.c |1 +
Hi,
This patch series adds a qdev flag which allows devices being tagged as
not hotpluggable. It also sets this flag for a number of devices.
Gerd Hoffmann (3):
qdev: allow devices being tagged as not hotpluggable.
piix: tag as non-hotpluggable.
vga: tag as not hotplugable.
hw/acpi_pii
Hi,
I still think that vga cards should simply be flagged to be not
hot-pluggable.
Send a patch.
[x] done.
cheers,
Gerd
Reviewed-by: Stefan Hajnoczi
On Thu, Nov 18, 2010 at 11:45:15AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> This patch series adds a qdev flag which allows devices being tagged as
> not hotpluggable. It also sets this flag for a number of devices.
>
Do we want to be able to mark device as not hot-unpluggable from command
like t
On 11/16/10 02:15, Michael Roth wrote:
> Daemon to be run in guest, or on host in standalone mode.
> (re-)implements some qemu utility functions used by core virtproxy.c
> code via wrapper functions. For built-in virtproxy code we will define
> these wrapper functions in terms of qemu's built-in im
On 11/16/10 02:15, Michael Roth wrote:
> Signed-off-by: Michael Roth
> ---
> virtproxy.c | 136
> +++
> virtproxy.h | 34 +++
> 2 files changed, 170 insertions(+), 0 deletions(-)
> create mode 100644 virtproxy.c
> create mo
On 11/16/10 02:15, Michael Roth wrote:
> Signed-off-by: Michael Roth
> ---
> virtproxy.c | 17 +
> 1 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/virtproxy.c b/virtproxy.c
> index 8f18d83..3686c77 100644
> --- a/virtproxy.c
> +++ b/virtproxy.c
> @@ -13,6 +13
On 11/18/10 12:01, Gleb Natapov wrote:
On Thu, Nov 18, 2010 at 11:45:15AM +0100, Gerd Hoffmann wrote:
Hi,
This patch series adds a qdev flag which allows devices being tagged as
not hotpluggable. It also sets this flag for a number of devices.
Do we want to be able to mark device as not h
Public bug reported:
It would be a nice feature (simplifying access control for example) to
be able to do something like:
qemu -net socket,listen=unix:/tmp/qemunet
qemu -net socket,connect=unix:/tmp/qemunet
For now one has to use TCP connections even for guests running on the
same host, which in
This patch makes sure the audio timer gets disabled when no voice is
active by adding a call to audio_timer_reset() to the output voice
disable code path.
That alone isn't enouth though as this might be called via audio_timer()
and audio_timer() unconditionally re-arms the timer before exiting. F
On Thu, Nov 18, 2010 at 12:13:21PM +0100, Gerd Hoffmann wrote:
> On 11/18/10 12:01, Gleb Natapov wrote:
> >On Thu, Nov 18, 2010 at 11:45:15AM +0100, Gerd Hoffmann wrote:
> >> Hi,
> >>
> >>This patch series adds a qdev flag which allows devices being tagged as
> >>not hotpluggable. It also sets t
On 11/16/10 02:16, Michael Roth wrote:
> +if (pkt->type == VP_PKT_CLIENT) {
> +TRACE("recieved client packet, client fd: %d, server fd: %d",
> + pkt->payload.proxied.client_fd,
> pkt->payload.proxied.server_fd);
> +fd = pkt->payload.proxied.server_fd;
> +} else
On 11/18/10 12:20, Gleb Natapov wrote:
On Thu, Nov 18, 2010 at 12:13:21PM +0100, Gerd Hoffmann wrote:
On 11/18/10 12:01, Gleb Natapov wrote:
On Thu, Nov 18, 2010 at 11:45:15AM +0100, Gerd Hoffmann wrote:
Hi,
This patch series adds a qdev flag which allows devices being tagged as
not hotplu
On Thu, Nov 18, 2010 at 11:57:51AM +0200, Gleb Natapov wrote:
> On Thu, Nov 18, 2010 at 11:30:27AM +0200, Michael S. Tsirkin wrote:
> > On Thu, Nov 18, 2010 at 11:11:49AM +0200, Gleb Natapov wrote:
> > > On Thu, Nov 18, 2010 at 11:03:21AM +0200, Michael S. Tsirkin wrote:
> > > > On Thu, Nov 18, 201
On 11/16/10 02:16, Michael Roth wrote:
> Process control packets coming in over the channel. This entails setting
> up/tearing down connections to local services initiated from the other
> end of the channel.
>
> Signed-off-by: Michael Roth
> ---
> virtproxy.c | 154
> +
On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote:
> On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote:
> > 2010/11/16 Gleb Natapov :
> > > On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote:
> > >> >> Perhaps the FW path should use device class names if no name is
> >
On Thu, Nov 18, 2010 at 12:29:07PM +0100, Gerd Hoffmann wrote:
> On 11/18/10 12:20, Gleb Natapov wrote:
> >On Thu, Nov 18, 2010 at 12:13:21PM +0100, Gerd Hoffmann wrote:
> >>On 11/18/10 12:01, Gleb Natapov wrote:
> >>>On Thu, Nov 18, 2010 at 11:45:15AM +0100, Gerd Hoffmann wrote:
> Hi,
> >>>
On Thu, Nov 18, 2010 at 11:09 AM, Jes Sorensen wrote:
> On 11/16/10 02:15, Michael Roth wrote:
>> Signed-off-by: Michael Roth
>> ---
>> virtproxy.c | 17 +
>> 1 files changed, 17 insertions(+), 0 deletions(-)
>>
>> diff --git a/virtproxy.c b/virtproxy.c
>> index 8f18d83..3686c7
On 11/16/10 02:16, Michael Roth wrote:
> +/* utility function to parse iforward/oforward options for qemu-vp
> + * or virtproxy chardev and put them into QemuOpts
> + */
> +int vp_parse(QemuOpts *opts, const char *str, bool is_channel)
> +{
> +/* TODO: use VP_SERVICE_ID_LEN, bring it into virtp
On 11/16/10 02:16, Michael Roth wrote:
> +/* read handler for proxied connections */
> +static void vp_conn_read(void *opaque)
> +{
> +VPConn *conn = opaque;
> +VPDriver *drv = conn->drv;
> +VPPacket pkt;
> +char buf[VP_CONN_DATA_LEN];
> +int fd, count, ret;
> +bool client;
On 11/16/10 02:16, Michael Roth wrote:
> Virtproxy relies on routines defined within qemu-vp which mirror various
> i/o related operations in qemu to provide similar functionality for the
> guest daemon. When building virtproxy as part of qemu rather than
> qemu-vp we need these definitions to prov
On 11/16/10 02:16, Michael Roth wrote:
> This allows us to create a virtproxy instance via a chardev. It can now
> be created with something like:
>
> qemu -chardev virtproxy,id=vp1 \
> -device virtio-serial \
> -device virtserialport,chardev=vp1
>
> In the future the ability to add ofo
On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote:
> > On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote:
> > > 2010/11/16 Gleb Natapov :
> > > > On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote:
> >
On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote:
> On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote:
> > On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote:
> > > On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote:
> > > > 2010/11/16 Gleb Natapov :
>
On Thu, Nov 18, 2010 at 01:33:08PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 18, 2010 at 11:57:51AM +0200, Gleb Natapov wrote:
> > On Thu, Nov 18, 2010 at 11:30:27AM +0200, Michael S. Tsirkin wrote:
> > > On Thu, Nov 18, 2010 at 11:11:49AM +0200, Gleb Natapov wrote:
> > > > On Thu, Nov 18, 201
There's no need to add any more specific information. The bug's in the
code in qemu.
net/vde.c:
static int net_vde_init(VLANState *vlan, const char *model,
const char *name, const char *sock,
int port, const char *group, int mode)
{
...
vde = v
Hi,
What is missing for multiple pci buses is
- a simple P2P bridge emulator for pc architecture
- seabios support
- DSDT for a new machine which has multi pci buses(IRQ routing)
Is this really needed?
IIRC there are (used to be?) multiport nic pci cards which are simply
multiple eth
On 18.11.2010 14:42, Gleb Natapov wrote:
[]
>> For *that* use case well have to do a bit more like dynamically
>> building the acpi table which indicates which slots are
>> hot-pluggable and which are not. Which indeed would be useful and
>> would fix the windows xp offering me to unplug the piix
On Thu, Nov 18, 2010 at 01:55:29PM +0200, Gleb Natapov wrote:
> On Thu, Nov 18, 2010 at 01:33:08PM +0200, Michael S. Tsirkin wrote:
> > On Thu, Nov 18, 2010 at 11:57:51AM +0200, Gleb Natapov wrote:
> > > On Thu, Nov 18, 2010 at 11:30:27AM +0200, Michael S. Tsirkin wrote:
> > > > On Thu, Nov 18, 201
On Thu, Nov 18, 2010 at 01:52:30PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote:
> > On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote:
> > > On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote:
> > > > On Wed, Nov 17, 201
On Thu, Nov 18, 2010 at 03:07:48PM +0300, Michael Tokarev wrote:
> On 18.11.2010 14:42, Gleb Natapov wrote:
> []
> >> For *that* use case well have to do a bit more like dynamically
> >> building the acpi table which indicates which slots are
> >> hot-pluggable and which are not. Which indeed woul
On Thu, Nov 18, 2010 at 02:16:05PM +0200, Gleb Natapov wrote:
> On Thu, Nov 18, 2010 at 01:52:30PM +0200, Michael S. Tsirkin wrote:
> > On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote:
> > > On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote:
> > > > On Thu, Nov 18, 201
On Thu, Nov 18, 2010 at 02:03:11PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 18, 2010 at 01:55:29PM +0200, Gleb Natapov wrote:
> > On Thu, Nov 18, 2010 at 01:33:08PM +0200, Michael S. Tsirkin wrote:
> > > On Thu, Nov 18, 2010 at 11:57:51AM +0200, Gleb Natapov wrote:
> > > > On Thu, Nov 18, 201
On Thu, Nov 18, 2010 at 02:23:20PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 18, 2010 at 02:16:05PM +0200, Gleb Natapov wrote:
> > On Thu, Nov 18, 2010 at 01:52:30PM +0200, Michael S. Tsirkin wrote:
> > > On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote:
> > > > On Thu, Nov 18, 201
On Thu, Nov 18, 2010 at 02:37:08PM +0200, Gleb Natapov wrote:
> > So that's unavoidable if we think paths are correct.
> > But if we know they are wrong, we are better off
> > correcting them first IMO.
> >
> They are correct for x86. My patch set does not even tries to cover all
> HW. If sparc wa
On Thu, Nov 18, 2010 at 03:12:02PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 18, 2010 at 02:37:08PM +0200, Gleb Natapov wrote:
> > > So that's unavoidable if we think paths are correct.
> > > But if we know they are wrong, we are better off
> > > correcting them first IMO.
> > >
> > They are
Hi Alex,
Am 18.11.2010 04:27, schrieb Alexander Graf:
> This patch adds support for AHCI emulation. I have tested and verified it
> works
> in Linux, OpenBSD, Windows Vista and Windows 7. This AHCI emulation supports
> NCQ, so multiple read or write requests can be outstanding at the same time.
>
On Mon, Nov 15, 2010 at 08:29:24PM +, Blue Swirl wrote:
> 2010/11/15 Gleb Natapov :
> > On Sun, Nov 14, 2010 at 10:50:13PM +, Blue Swirl wrote:
> >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote:
> >> >
> >> > Signed-off-by: Gleb Natapov
> >> > ---
> >> > hw/fw_cfg.c | 14 +++
On 11/16/10 17:01, Michael Roth wrote:
> This set of patches is meant to be applied on top of the recently submitted
> Virtproxy v3 patchset. It can also be obtained at:
>
> git://repo.or.cz/qemu/mdroth.git virtproxy_v3
>
> OVERVIEW:
>
> There are a wide range of use cases motivating the need f
On 11/16/10 17:01, Michael Roth wrote:
> +#define DEBUG_VA
> +
> +#ifdef DEBUG_VA
> +#define TRACE(msg, ...) do { \
> +fprintf(stderr, "%s:%s():L%d: " msg "\n", \
> +__FILE__, __FUNCTION__, __LINE__, ## __VA_ARGS__); \
> +} while(0)
> +#else
> +#define TRACE(msg, ...) \
> +do {
Given that you know what the problem is, it would probably have been
faster to post a patch than just updating the bug and marking it
confirmed
--
Silently fail with wrong vde socket dir
https://bugs.launchpad.net/bugs/676029
You received this bug notification because you are a member of qemu
On 11/16/10 17:01, Michael Roth wrote:
> +#include
> +#include "qemu_socket.h"
> +#include "virtagent-daemon.h"
> +#include "virtagent-common.h"
> +#include "virtagent.h"
> +
> +static bool va_enable_syslog = false; /* enable syslog'ing of RPCs */
> +
> +#define SLOG(msg, ...) do { \
> +char m
On 11/16/10 17:01, Michael Roth wrote:
> +bool enable_virtagent;
>
> chr->opaque = drv;
> chr->chr_write = vp_chr_write;
> @@ -2025,9 +2029,31 @@ static CharDriverState
> *qemu_chr_open_virtproxy(QemuOpts *opts)
> /* parse socket forwarding options */
> qemu_opt_foreach(o
On Thu, Nov 18, 2010 at 02:27:26PM +0200, Gleb Natapov wrote:
> On Thu, Nov 18, 2010 at 02:03:11PM +0200, Michael S. Tsirkin wrote:
> > On Thu, Nov 18, 2010 at 01:55:29PM +0200, Gleb Natapov wrote:
> > > On Thu, Nov 18, 2010 at 01:33:08PM +0200, Michael S. Tsirkin wrote:
> > > > On Thu, Nov 18, 201
On 11/16/10 17:01, Michael Roth wrote:
> diff --git a/monitor.c b/monitor.c
> index 8cee35d..cb81cd7 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -42,6 +42,7 @@
> #include "audio/audio.h"
> #include "disas.h"
> #include "balloon.h"
> +#include "virtagent.h"
> #include "qemu-timer.h"
> #incl
On 11/16/10 17:01, Michael Roth wrote:
> Utilize the getfile RPC to provide a means to view text files in the
> guest. Getfile can handle binary files as well but we don't advertise
> that here due to the special handling requiring to store it and provide
> it back to the user (base64 encoding it f
On 11/16/10 17:01, Michael Roth wrote:
> RPC to initiate guest shutdown/reboot/powerdown
Do we really need this? After all those events can be passed down via ACPI?
Cheers,
Jes
On 11/16/10 17:01, Michael Roth wrote:
> Provide monitor command to initiate guest shutdown/reboot/powerdown
> +int do_agent_shutdown(Monitor *mon, const QDict *mon_params,
> + MonitorCompletion cb, void *opaque)
> +{
> +xmlrpc_env env;
> +xmlrpc_value *params;
> +
On 11/16/10 17:01, Michael Roth wrote:
> Non-monitor version of agent_capabilities monitor function. This is
> called by the local RPC server when it gets a "hello" from the guest
> agent to re-negotiate guest agent capabilities.
>
> Signed-off-by: Michael Roth
> ---
> virtagent.c | 34 +++
On 11/16/10 17:01, Michael Roth wrote:
> Make the hello call on guest agent startup so QEMU can do whatever init
> it needs (currently, capabilities negotiation). Temporarilly commented
> due to this tending to induce a virtio bug in RHEL 6.0. As a result
> capabilities negotiation must be invoked
Due to popular demand here is now the LSI Megaraid HBA emulation.
And an update to the SCSI stack to bring it more in line with
modern standards.
For the SCSI update there are three key points:
- Improved sense code handling: the SCSI standard specifies several
sense codes to be returned on com
qemu_malloc doesn't check for zero argument, so we need to
check ourselves.
Signed-off-by: Hannes Reinecke
---
dma-helpers.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/dma-helpers.c b/dma-helpers.c
index 712ed89..877b2c3 100644
--- a/dma-helpers.c
+++ b/dma-hel
The SCSI parallel interface has a limite of 8 devices, but
not the SCSI stack in general. So we should be removing the
hard-coded limit and use MAX_SCSI_DEVS instead.
And we only need to scan those devices which are allocated
by the bus.
Signed-off-by: Hannes Reinecke
---
blockdev.h|2 +
The SCSI emulation is supposed to return status codes as defined
by SAM, not the linux ones which are shifted by one.
Signed-off-by: Hannes Reinecke
---
hw/scsi-defs.h| 20 +++-
hw/scsi-generic.c | 10 +-
2 files changed, 16 insertions(+), 14 deletions(-)
diff -
We should announce and support the block device characterics page
only on block devices, not on CDROMs. And the VPD page 0x83 has
an off-by-one error.
Signed-off-by: Hannes Reinecke
---
hw/scsi-disk.c | 18 ++
1 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/hw/
The SCSI spec has a quite detailed list of sense codes available.
It even mandates the use of specific ones for some failure cases.
The current implementation just has one type of 'generic' error
which is actually a violation of the spec in certain cases.
This patch introduces various predefined s
We parse the CDB twice, which is completely unnecessary.
Signed-off-by: Hannes Reinecke
---
hw/scsi-disk.c | 74
1 files changed, 21 insertions(+), 53 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index da6c3f0..58e5f5b 100
Rather than to access a SCSIRequest via an abstract 'tag' we can
as well use it directly and save us the lookup.
Signed-off-by: Hannes Reinecke
---
hw/esp.c | 20 ---
hw/lsi53c895a.c | 25 +
hw/scsi-bus.c | 15 +-
hw/scsi-disk.c| 147 ---
Rather than have the iovec part of the structure with a fixed size
of '1' we should be allocating it dynamically. This will allow us
to pass in SGLs directly.
Signed-off-by: Hannes Reinecke
---
hw/scsi-disk.c | 112 +++-
1 files changed, 70 i
The current sense handling in scsi-bus is only used by the
scsi-disk driver; the scsi-generic driver is using its own.
So we should move the current sense handling into the
scsi-disk driver.
Signed-off-by: Hannes Reinecke
---
hw/scsi-bus.c | 10 --
hw/scsi-disk.c | 33 +
The 'bus' argument is now pointless, as we already pass the
request itself and the bus can be derived from it.
Signed-off-by: Hannes Reinecke
---
hw/esp.c |5 ++---
hw/lsi53c895a.c |5 ++---
hw/scsi-bus.c |3 +--
hw/scsi-disk.c|8
hw/scsi-generic.c |
aio_ioctl is emulated anyway and currently broken.
So better use 'normal' ioctl here as there are no benefits
on using the emulated async I/O call.
Signed-off-by: Hannes Reinecke
---
hw/scsi-generic.c | 21 +++--
1 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/
The 'sense' field in the HBA status structure is misnamed, as it
actually carries the SCSI status. Rename it.
Signed-off-by: Hannes Reinecke
---
hw/lsi53c895a.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index f973
scsi_req_parse() already provides for a data direction setting,
so we should be using it to check for correct direction.
Signed-off-by: Hannes Reinecke
---
hw/scsi-disk.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index f
Add callback to create a request with a predefined iovec.
Signed-off-by: Hannes Reinecke
---
hw/scsi-disk.c| 25 +
hw/scsi-generic.c | 44 ++--
hw/scsi.h |2 ++
3 files changed, 57 insertions(+), 14 deletions(-)
On Thu, Nov 18, 2010 at 04:04:14PM +0200, Michael S. Tsirkin wrote:
> > > What do you want to know?
> > How it claims access to framebuffer. Legacy VGA has not only IO space
> > but MMIO space too.
>
> There's a separate bit to enable memory is that is what you
> are asking about.
>
> The spec sp
On 11/18/2010 01:42 AM, Anthony Liguori wrote:
Gack. For the benefit of those that want to join the fun without
digging up the spec, these magic flippable segments the i440fx can
toggle are 12 fixed 16k segments from 0xc to 0xe and a single
64k segment from 0xf to 0xf. There are
The get_sense callback copies existing sense information into
the provided buffer. Required if sense information should be
transferred together with the command response.
Signed-off-by: Hannes Reinecke
---
hw/scsi-disk.c|9 +
hw/scsi-generic.c | 17 +
hw/scsi.h
On Thu, Nov 18, 2010 at 04:57:55PM +0200, Gleb Natapov wrote:
> On Thu, Nov 18, 2010 at 04:04:14PM +0200, Michael S. Tsirkin wrote:
> > > > What do you want to know?
> > > How it claims access to framebuffer. Legacy VGA has not only IO space
> > > but MMIO space too.
> >
> > There's a separate bit
Hi,
+static size_t scsi_req_iov_len(SCSIDiskReq *r)
+{
+size_t iov_len = 0;
+int i;
+
+for (i = 0; i< r->iov_num; i++)
+iov_len += r->iov[i].iov_len;
+
+return iov_len;
+}
You are aware that there is a QEMUIOVector type with helper functions
which keeps track of bot
On 11/18/2010 05:06 AM, Jes Sorensen wrote:
On 11/16/10 02:15, Michael Roth wrote:
Signed-off-by: Michael Roth
---
virtproxy.c | 136 +++
virtproxy.h | 34 +++
2 files changed, 170 insertions(+), 0 deletions(-)
create m
On 11/18/2010 08:17 AM, Jes Sorensen wrote:
On 11/16/10 17:01, Michael Roth wrote:
RPC to initiate guest shutdown/reboot/powerdown
Do we really need this? After all those events can be passed down via ACPI?
Reboot can't be passed by ACPI. This is why virDomainReboot is still
n
On 11/18/2010 09:35 AM, Michael Roth wrote:
+/* listening fd, one for each service we're forwarding to remote
end */
+typedef struct VPOForward {
+VPDriver *drv;
+int listen_fd;
+char service_id[VP_SERVICE_ID_LEN];
+QLIST_ENTRY(VPOForward) next;
+} VPOForward;
I am really not a
On 11/18/10 16:35, Anthony Liguori wrote:
> On 11/18/2010 08:17 AM, Jes Sorensen wrote:
>> On 11/16/10 17:01, Michael Roth wrote:
>>
>>> RPC to initiate guest shutdown/reboot/powerdown
>>>
>> Do we really need this? After all those events can be passed down via
>> ACPI?
>>
>
> Reboot
1 - 100 of 160 matches
Mail list logo
