Re: [Qemu-devel] [Bug 671831] [NEW] Sparc guest assert error

2010-11-08 Thread Nigel Horne
Stefan, > You can grab the code like this: > git clone -b scsi_assert git://repo.or.cz/qemu/stefanha.git > > If the assert triggers in that world then data corruption was > previously possible but hidden (a SCSI request has a one data buffer > and concurrent reads are being issued to the same buffe

Re: [Qemu-devel] [PATCH 1/2] rtl8139: add vlan tag insertion

2010-11-08 Thread Benjamin Poirier
On 08/11/10 11:34 AM, Stefan Hajnoczi wrote: > On Sun, Nov 7, 2010 at 9:25 PM, Benjamin Poirier > wrote: >> Add support to the emulated hardware to add vlan tags in packets going >> from the guest to the network. >> >> Signed-off-by: Benjamin Poirier >> Cc: Igor V. Kovalenko >> --- >> hw/rtl813

[Qemu-devel] [PATCH v2 1/2] rtl8139: add vlan tag insertion

2010-11-08 Thread Benjamin Poirier
Add support to the emulated hardware to add vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirier Cc: Igor V. Kovalenko --- Changes since v1: * moved the debug print statement inside the if block and reworded accordingly. (as suggested by Igor) hw/rtl8139.

[Qemu-devel] [PATCH v2 2/2] rtl8139: add vlan tag extraction

2010-11-08 Thread Benjamin Poirier
Add support to the emulated hardware to remove vlan tags in packets going from the network to the guest. Signed-off-by: Benjamin Poirier Cc: Igor V. Kovalenko --- Changes since v1: * moved the debug print statement inside the if block and reworded accordingly. (as suggested by Igor) AFAIK, e

[Qemu-devel] [PATCH 2/2] Add qmp version of drive_del

2010-11-08 Thread Ryan Harper
Signed-off-by: Ryan Harper --- qmp-commands.hx | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..1e0d4e9 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -338,6 +338,35 @@ Example: EQMP

[Qemu-devel] [PATCH 0/2] v6 Decouple block device removal from device removal

2010-11-08 Thread Ryan Harper
After *much* discussion, here's version 6. This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some cases, the guest may not respond le

[Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

2010-11-08 Thread Ryan Harper
Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not happen synchronously with the device removal command This series aims to close a gap where by mgmt applications that assume the block resource has been removed without confirming that the guest h

Re: [Qemu-devel] Re: [PATCH] PCI: Bus number from the bridge, not the device

2010-11-08 Thread Isaku Yamahata
On Mon, Nov 08, 2010 at 06:26:33PM +0200, Michael S. Tsirkin wrote: > Replace bus number with slot numbers of parent bridges up to the root. > This works for root bridge in a compatible way because bus number there > is hard-coded to 0. > IMO nested bridges are broken anyway, no way to be compatibl

[Qemu-devel] Re: [patch 0/3] block migration fixes

2010-11-08 Thread Yoshiaki Tamura
Marcelo Tosatti wrote: > Following patchset fixes block migration corruption issues. Hi Marcelo, Thanks for looking into this issue. Although we tried your patches, we're still seeing the corruption. If we execute block migration while copying a file locally, md5sum of the copied file doesn't m

Re: [Qemu-devel] [PATCH 3/3] Add helper functions to enable virtio-9p make use of the threadlets

2010-11-08 Thread Venkateswararao Jujjuri (JV)
On 11/8/2010 2:47 AM, Arun R Bharadwaj wrote: > From: Gautham R Shenoy > > infrastructure for offloading blocking tasks such as making posix calls on > to the helper threads and handle the post_posix_operations() from the > context of the iothread. This frees the vcpu thread to process any other

[Qemu-devel] Re: [SeaBIOS] [PATCH] fix virtio-blk failure after reboot

2010-11-08 Thread Gleb Natapov
On Mon, Nov 08, 2010 at 06:59:37PM -0500, Kevin O'Connor wrote: > On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote: > > vring_virtqueue should be zeroed otherwise old values will be reused > > after reboot. > > > > Signed-off-by: Gleb Natapov > > diff --git a/src/virtio-blk.c b/src/vi

Re: [Qemu-devel] smp: linux guest only sees 1 CPU when not using KVM

2010-11-08 Thread Gleb Natapov
On Mon, Nov 08, 2010 at 11:30:52PM +0100, Lluís wrote: > Lennart Sorensen writes: > > > On Mon, Nov 08, 2010 at 10:57:19PM +0100, Lluís wrote: > >> Well, thre's nothing more to add than the contents in the subject. > >> > >> I tried booting up with -smp 2, and /proc/cpuinfo on the linux guest > >

[Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-08 Thread Gleb Natapov
Properly check array bounds before accessing array element. Signed-off-by: Gleb Natapov diff --git a/hw/usb-net.c b/hw/usb-net.c index 70f9263..84e2d79 100644 --- a/hw/usb-net.c +++ b/hw/usb-net.c @@ -1142,7 +1142,7 @@ static int usb_net_handle_control(USBDevice *dev, int request, int value,

<    1   2