[Qemu-devel] [Bug 658152] [NEW] jp106 keyboard cannot input "_" key

2010-10-11 Thread seiichi nakashima
Public bug reported: My environment are cpu model = AMD Phenom II X2 545 kvm version = Virtual Machine Manager 0.8.5 host kernel version = vmlinuz-2.6.34.7-56.fc13.x86_64 host kernel arch = x86_64 guest you are using = CentOS-5.5, slackware-13.1 qemu command = not use I do not use -no-kvm-irqchip

Re: [Qemu-devel] [PATCH] monitor: add usb_detach

2010-10-11 Thread Gerd Hoffmann
On 10/10/10 13:12, Alon Levy wrote: - "Anthony Liguori" wrote: How is this different than usb_del? Is it that it detaches it but does not delete the device? yes. There is no usb_attach command because it was harder to write (can't use the bus.addr since a detached device doesn't have t

[Qemu-devel] Re: [PATCH 01/12] block: avoid a write only variable

2010-10-11 Thread Kevin Wolf
Am 08.10.2010 23:23, schrieb Blue Swirl: > Compiling with GCC 4.6.0 20100925 produced a warning: > /src/qemu/block/qcow2-refcount.c: In function 'update_refcount': > /src/qemu/block/qcow2-refcount.c:552:13: error: variable 'dummy' set > but not used [-Werror=unused-but-set-variable] > > Fix by add

[Qemu-devel] [PATCH 1/4] target-arm: Add support for PKHxx in thumb2

2010-10-11 Thread Johan Bengtsson
The PKHxx instructions were not recognized by the thumb2 decoder. The solution provided in this changeset is identical to the arm-mode implementation. Signed-off-by: Johan Bengtsson --- target-arm/translate.c | 63 ++- 1 files changed, 45 insertions(

[Qemu-devel] [PATCH 2/4] target-arm: Fix mixup in decoding of saturating add and sub

2010-10-11 Thread Johan Bengtsson
The thumb2 decoder contained a mixup between the bit controlling doubling and the bit controlling if the operation was an add or a sub. Signed-off-by: Johan Bengtsson --- target-arm/translate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/t

[Qemu-devel] [PATCH 4/4] target-arm: Fix problems with VCVT fixpoint conversion

2010-10-11 Thread Johan Bengtsson
There were two problems with VCVT fixpoint conversion. The most grave was that the micro-ops sequence generated by the instruction triggered a failed assertion in tcg. The second problem was that the extraction of the fraction field from the opcode was erroneous. Signed-off-by: Johan Bengtsson --

Re: [Qemu-devel] [PATCH 1/7] Introduce strtosz() library function to convert a string to a byte count.

2010-10-11 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > strtosz() returns -1 on error. > > v2 renamed from strtobytes() to strtosz() as suggested by Markus. > > Signed-off-by: Jes Sorensen > --- > cutils.c | 39 +++ > qemu-common.h |1 + > vl.c

Re: [Qemu-devel] [PATCH, RFC] Sparc: convert some debug printf statements to tracepoints

2010-10-11 Thread Stefan Hajnoczi
On Sat, Oct 9, 2010 at 8:41 PM, Blue Swirl wrote: > On Sat, Oct 9, 2010 at 6:33 PM, Andreas Färber wrote: >> Am 09.10.2010 um 18:00 schrieb Andreas Färber: >> >>> Am 09.10.2010 um 17:46 schrieb Blue Swirl: >>> On Sat, Oct 9, 2010 at 3:35 PM, Andreas Färber wrote: > > Am 09.10.2

[Qemu-devel] [PATCH v2] trace: Adapt trace file name for Haiku

2010-10-11 Thread Stefan Hajnoczi
Acked-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' argument rather than a float.

2010-10-11 Thread Markus Armbruster
[cc: Anthony, please review the proposed incompatible change of the human monitor] jes.soren...@redhat.com writes: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > hmp-commands.hx |2 +- > migration.c |4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' argument rather than a float.

2010-10-11 Thread Paolo Bonzini
On 10/11/2010 11:03 AM, Markus Armbruster wrote: As noted before, this is an incompatible change of the human monitor command: unit now defaults to 'M'. This must be noted*prominently* in the commit message. Best in the subject. Incompatible changes can break tools. Quick grep of libvirt: s

[Qemu-devel] Re: [PATCH] trace: print a warning if user tries to enable an unknown trace event

2010-10-11 Thread Stefan Hajnoczi
On Sat, Oct 09, 2010 at 03:48:18PM +, Blue Swirl wrote: > There was no warning if a bad trace event name was given to > 'trace-event' command, thus the user could think that the command > was successful even if this was not the case. > > Print a warning if the user tries to enable a trace even

[Qemu-devel] Re: [PATCH] net: provide a friendly message when a user passes a bad -net tap, fd=X

2010-10-11 Thread Daniel P. Berrange
On Fri, Oct 08, 2010 at 05:04:56PM -0500, Anthony Liguori wrote: > A lot of people copy libvirt's command line from ps -ef and then wonder why > the > VM isn't working correctly. Let's be kind and tell them what they should do > instead. > > Without this patch, if you run with an invalid -net ta

Re: [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' argument rather than a float.

2010-10-11 Thread Jes Sorensen
On 10/11/10 11:03, Markus Armbruster wrote: > > As noted before, this is an incompatible change of the human monitor > command: unit now defaults to 'M'. This must be noted *prominently* in > the commit message. Best in the subject. > > Incompatible changes can break tools. Quick grep of libvi

[Qemu-devel] virtio_cleanup() missing in virtio-{blk, balloon, 9p}-pci

2010-10-11 Thread Markus Armbruster
Pattern: FOO's PCIDeviceInfo method exit is virtio_FOO_exit_pci(), which calls virtio_FOO_exit() and virtio_exit_pci(). virtio_{net,serial}_exit() call virtio_cleanup(). virtio_blk_exit() doesn't. Why? virtio-balloon-pci uses virtio_exit_pci() as exit method. No virtio_cleanup()? virtio-9p-p

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Stefan Hajnoczi
On Sun, Oct 10, 2010 at 11:20:09AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >Signed-off-by: Stefan Hajnoczi > >--- > > docs/specs/qed_spec.txt | 94 > > +++ > > 1 files changed, 94 insertions(+), 0 deletions(-) > >

[Qemu-devel] Re: virtio_cleanup() missing in virtio-{blk, balloon, 9p}-pci

2010-10-11 Thread Kevin Wolf
Am 11.10.2010 12:00, schrieb Markus Armbruster: > Pattern: > > FOO's PCIDeviceInfo method exit is virtio_FOO_exit_pci(), which calls > virtio_FOO_exit() and virtio_exit_pci(). > > virtio_{net,serial}_exit() call virtio_cleanup(). > > virtio_blk_exit() doesn't. Why? > > virtio-balloon-pci uses

[Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
Currently if VM is started with multiple disks it is almost impossible to guess which one of them will be used as boot device especially if there is a mix of ATA/virtio/SCSI devices. Essentially BIOS decides the order and without looking into the code you can't tell what the order will be (and in q

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Kevin Wolf
Am 11.10.2010 12:18, schrieb Gleb Natapov: > Currently if VM is started with multiple disks it is almost impossible to > guess which one of them will be used as boot device especially if there > is a mix of ATA/virtio/SCSI devices. Essentially BIOS decides the order > and without looking into the c

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-11 Thread Stefan Hajnoczi
On Sun, Oct 10, 2010 at 11:10:15AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >This patch implements the read/write state machine. Operations are > >fully asynchronous and multiple operations may be active at any time. > > > >Allocating writes lock tables to ensur

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 12:32:48PM +0200, Kevin Wolf wrote: > Am 11.10.2010 12:18, schrieb Gleb Natapov: > > Currently if VM is started with multiple disks it is almost impossible to > > guess which one of them will be used as boot device especially if there > > is a mix of ATA/virtio/SCSI devices.

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Kevin Wolf
Am 11.10.2010 12:43, schrieb Gleb Natapov: > On Mon, Oct 11, 2010 at 12:32:48PM +0200, Kevin Wolf wrote: >> Am 11.10.2010 12:18, schrieb Gleb Natapov: >>> Currently if VM is started with multiple disks it is almost impossible to >>> guess which one of them will be used as boot device especially if

Re: [Qemu-devel] [PATCH] monitor: add usb_detach

2010-10-11 Thread Alon Levy
- "Gerd Hoffmann" wrote: > On 10/10/10 13:12, Alon Levy wrote: > > > > - "Anthony Liguori" wrote: > > > >> How is this different than usb_del? Is it that it detaches it but > >> does > >> not delete the device? > > > > yes. There is no usb_attach command because it was harder to write

[Qemu-devel] Re: [PATCH v2 2/7] cutils: Add bytes_to_str() to format byte values

2010-10-11 Thread Kevin Wolf
Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: > From: Anthony Liguori > > This common function converts byte counts to human-readable strings with > proper units. > > Signed-off-by: Anthony Liguori > Signed-off-by: Stefan Hajnoczi I wonder how many similar implementations we have in the tree.

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Bernhard Kohl
Am 11.10.2010 12:18, schrieb ext Gleb Natapov: Currently if VM is started with multiple disks it is almost impossible to guess which one of them will be used as boot device especially if there is a mix of ATA/virtio/SCSI devices. Essentially BIOS decides the order and without looking into the cod

Re: [Qemu-devel] request help enabling both serial0 and parallel0 to emulate 2 distinct ports on beagle

2010-10-11 Thread Gabi Voiculescu
Can anybody tell me if I can use parallel0 and serial0 simultaneously as distinct input interfaces, please? Is this allowed by the qemu design or not? Thank you, Gabi Voiculescu --- On Fri, 10/8/10, Gabi Voiculescu wrote: > From: Gabi Voiculescu > Subject: [Qemu-devel] request help enabling

Re: [Qemu-devel] 9p crash bugs

2010-10-11 Thread Markus Armbruster
"Venkateswararao Jujjuri (JV)" writes: > Markus, thanks for looking into it. > > Will look into the errors and fix them asap..at least it should fail > gracefully > if the arguments > are not correct/insufficient. Thanks! > BTW, we added a setup help page under QEMU documentation..and it can g

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gerd Hoffmann
Hi, Floppy? Yes, I think we do. And *one* floppy controllers can actually have *two* drives connected, although booting from 'b' doesn't work IIRC. and since one PCI device may control more then one disk (ATA slave/master, SCSI LUNs). We can do what EDD specification does. Describe disk

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 01:16:00PM +0200, Bernhard Kohl wrote: > Am 11.10.2010 12:18, schrieb ext Gleb Natapov: > >Currently if VM is started with multiple disks it is almost impossible to > >guess which one of them will be used as boot device especially if there > >is a mix of ATA/virtio/SCSI devi

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 02:07:14PM +0200, Gerd Hoffmann wrote: > Hi, > > >Floppy? Yes, I think we do. > > And *one* floppy controllers can actually have *two* drives > connected, although booting from 'b' doesn't work IIRC. > > >>and since one PCI device may > >>control more then one disk (ATA

[Qemu-devel] [PATCH 2/4] Add support for 'o' octet (bytes) format as monitor parameter.

2010-10-11 Thread Jes . Sorensen
From: Jes Sorensen Octet format relies on strtosz which supports K/k, M/m, G/g, T/t suffixes and unit support for humans, like 1.3G Signed-off-by: Jes Sorensen --- monitor.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor

[Qemu-devel] [PATCH 3/4] Switch migrate_set_speed() to take an 'o' argument rather than a float. Clarify default value of MB in migration speed argument in monitor, if no suffix is specified. This dif

2010-10-11 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- hmp-commands.hx |5 +++-- migration.c |4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 81999aa..1dc651d 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -754,9 +754

[Qemu-devel] [PATCH 4/4] Remove obsolete 'f' double parameter type

2010-10-11 Thread Jes . Sorensen
From: Jes Sorensen 'f' double is no longer used, and we should be using floating point variables to store byte sizes. Remove it. Signed-off-by: Jes Sorensen --- monitor.c | 18 +- 1 files changed, 1 insertions(+), 17 deletions(-) diff --git a/monitor.c b/monitor.c index 6dd1

[Qemu-devel] [PATCH v5 0/4] Introduce strtosz and make use of it

2010-10-11 Thread Jes . Sorensen
From: Jes Sorensen This patch introduces cutils.c: strtosz() and gets rid of the multiple custom hacks for parsing byte sizes. In addition it adds supports for specifying human style sizes such as 1.5G. Last it eliminates the horrible abuse of a float to store the byte size for migrate_set_speed

[Qemu-devel] [PATCH] Suppress warning: zero-length gnu_printf format string

2010-10-11 Thread Markus Armbruster
Warns about this line in check-qjson.c: QObject *obj = qobject_from_json(""); The obvious fix (add -Wno-format-zero-length to gcc_flags) doesn't work, because -Wall switches it on again. Fix by putting configured flags last. Signed-off-by: Markus Armbruster --- configure |5 +++-- 1 fi

[Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-11 Thread Jes . Sorensen
From: Jes Sorensen strtosz() returns -1 on error. It now supports human unit formats in eg. 1.0G, with better error handling. Signed-off-by: Jes Sorensen --- cutils.c | 61 + qemu-common.h |1 + vl.c | 31 +--

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl wrote: > Am 11.10.2010 12:18, schrieb ext Gleb Natapov: >> >> Currently if VM is started with multiple disks it is almost impossible to >> guess which one of them will be used as boot device especially if there >> is a mix of ATA/virtio/SCSI devices.

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 12:09 PM, Stefan Hajnoczi wrote: On Sun, Oct 10, 2010 at 11:20:09AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >Signed-off-by: Stefan Hajnoczi > >--- > > docs/specs/qed_spec.txt | 94 +++ > > 1

[Qemu-devel] Re: [PATCH] Suppress warning: zero-length gnu_printf format string

2010-10-11 Thread Paolo Bonzini
On 10/11/2010 02:52 PM, Markus Armbruster wrote: Warns about this line in check-qjson.c: QObject *obj = qobject_from_json(""); The obvious fix (add -Wno-format-zero-length to gcc_flags) doesn't work, because -Wall switches it on again. Fix by putting configured flags last. Signed-off-by:

Re: [Qemu-devel] [PATCH 1/7] Introduce strtosz() library function to convert a string to a byte count.

2010-10-11 Thread Jes Sorensen
On 10/11/10 10:51, Markus Armbruster wrote: > jes.soren...@redhat.com writes: >> +/* >> + * Convert string to bytes, allowing either K/k for KB, M/m for MB, >> + * G/g for GB or T/t for TB. Default without any postfix is MB. >> + * End pointer will be returned in *end, if end is valid. >> + * Retur

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-11 Thread Avi Kivity
On 10/11/2010 12:37 PM, Stefan Hajnoczi wrote: On Sun, Oct 10, 2010 at 11:10:15AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >This patch implements the read/write state machine. Operations are > >fully asynchronous and multiple operations may be active at an

[Qemu-devel] Re: [PATCH v2 0/7] qed: Add QEMU Enhanced Disk format

2010-10-11 Thread Kevin Wolf
Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: > This code is also available from git: > > http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/qed This doesn't seem to be the same as the latest patches you posted to qemu-devel. Forgot to push? Kevin

Re: [Qemu-devel] [PATCH] CMOS file support

2010-10-11 Thread Markus Armbruster
Maybe Kevin or Christoph (cc'ed) can help. Mathias Krause writes: > On 24.09.2010 14:47, Markus Armbruster wrote: >> Mathias Krause writes: >> >>> On 17.09.2010 15:27, Anthony Liguori wrote: On 09/17/2010 01:50 AM, Mathias Krause wrote: > Am 16.09.2010 19:20 schrieb Anthony Liguori: >

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 03:04:03PM +0200, Avi Kivity wrote: > On 10/11/2010 12:09 PM, Stefan Hajnoczi wrote: > >On Sun, Oct 10, 2010 at 11:20:09AM +0200, Avi Kivity wrote: > >> On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >> >Signed-off-by: Stefan Hajnoczi > >> >--- > >> > docs/specs/qe

Re: [Qemu-devel] [PATCH 1/7] Introduce strtosz() library function to convert a string to a byte count.

2010-10-11 Thread Markus Armbruster
Jes Sorensen writes: > On 10/11/10 10:51, Markus Armbruster wrote: >> jes.soren...@redhat.com writes: >>> +/* >>> + * Convert string to bytes, allowing either K/k for KB, M/m for MB, >>> + * G/g for GB or T/t for TB. Default without any postfix is MB. >>> + * End pointer will be returned in *end,

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-11 Thread Anthony Liguori
On 10/11/2010 08:10 AM, Avi Kivity wrote: On 10/11/2010 12:37 PM, Stefan Hajnoczi wrote: On Sun, Oct 10, 2010 at 11:10:15AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >This patch implements the read/write state machine. Operations are > >fully asynchronous an

Re: [Qemu-devel] [PATCH 07/12] mips_fulong2e: Delete write only variables

2010-10-11 Thread Markus Armbruster
Blue Swirl writes: > Compiling with GCC 4.6.0 20100925 produced warnings like: > /src/qemu/hw/mips_fulong2e.c: In function 'mips_fulong2e_init': > /src/qemu/hw/mips_fulong2e.c:274:16: error: variable 'rtc_state' set > but not used [-Werror=unused-but-set-variable] > /src/qemu/hw/mips_fulong2e.c:2

Re: [Qemu-devel] Re: [PATCH v2 0/7] qed: Add QEMU Enhanced Disk format

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 2:21 PM, Kevin Wolf wrote: > Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: >> This code is also available from git: >> >> http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/qed > > This doesn't seem to be the same as the latest patches you posted to > qemu-devel. For

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 05:02 PM, Anthony Liguori wrote: On 10/11/2010 08:44 AM, Avi Kivity wrote: On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > > A leak is acceptable (it won't grow; it's just an unused, incorrect > freelist), but data corruption is not. The alternative is for the freelist to be

[Qemu-devel] Re: [PATCH v2 4/7] qed: Add QEMU Enhanced Disk image format

2010-10-11 Thread Kevin Wolf
Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: > This patch introduces the qed on-disk layout and implements image > creation. Later patches add read/write and other functionality. > > Signed-off-by: Stefan Hajnoczi > --- > Makefile.objs |1 + > block/qed.c | 530 > ++

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 04:54 PM, Anthony Liguori wrote: On 10/11/2010 08:04 AM, Avi Kivity wrote: On 10/11/2010 12:09 PM, Stefan Hajnoczi wrote: On Sun, Oct 10, 2010 at 11:20:09AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >Signed-off-by: Stefan Hajnoczi > >--- > >

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 08:44 AM, Avi Kivity wrote: On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > > A leak is acceptable (it won't grow; it's just an unused, incorrect > freelist), but data corruption is not. The alternative is for the freelist to be a non-compat feature bit. That means older QEMU

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 08:04 AM, Avi Kivity wrote: On 10/11/2010 12:09 PM, Stefan Hajnoczi wrote: On Sun, Oct 10, 2010 at 11:20:09AM +0200, Avi Kivity wrote: > On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >Signed-off-by: Stefan Hajnoczi > >--- > > docs/specs/qed_spec.txt | 94

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 05:39:01PM +0200, Avi Kivity wrote: > On 10/11/2010 05:30 PM, Stefan Hajnoczi wrote: > >> > >> It was discussed before, but I don't think we came to a conclusion. Are > >> there any circumstances under which you don't want to set the > >> QED_CF_BACKING_FORMAT flag? > >

[Qemu-devel] Re: [SeaBIOS] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 05:42:30PM +0200, Avi Kivity wrote: > On 10/11/2010 05:39 PM, Gleb Natapov wrote: > >On Mon, Oct 11, 2010 at 05:09:22PM +0200, Avi Kivity wrote: > >> On 10/11/2010 12:18 PM, Gleb Natapov wrote: > >> >Currently if VM is started with multiple disks it is almost impossible

Re: [Qemu-devel] [PATCH 03/12] eepro100: initialize a variable in all cases

2010-10-11 Thread Markus Armbruster
Blue Swirl writes: > Compiling with GCC 4.6.0 20100925 produced warnings: > /src/qemu/hw/eepro100.c: In function 'eepro100_read4': > /src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used > uninitialized in this function [-Werror=uninitialized] > /src/qemu/hw/eepro100.c: In function 'eepro100_

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 09:58 AM, Avi Kivity wrote: A leak is unacceptable. It means an image can grow to an unbounded size. If you are a server provider offering multitenancy, then a malicious guest can potentially grow the image beyond it's allotted size causing a Denial of Service attack against ano

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 03:44:38PM +0200, Avi Kivity wrote: > On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > >> > >> A leak is acceptable (it won't grow; it's just an unused, incorrect > >> freelist), but data corruption is not. > > > >The alternative is for the freelist to be a non-compat fea

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 03:58:07PM +0200, Kevin Wolf wrote: > Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: > > Signed-off-by: Stefan Hajnoczi > > --- > > docs/specs/qed_spec.txt | 94 > > +++ > > 1 files changed, 94 insertions(+), 0 deletions(-) > >

[Qemu-devel] Re: [SeaBIOS] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 05:09:22PM +0200, Avi Kivity wrote: > On 10/11/2010 12:18 PM, Gleb Natapov wrote: > >Currently if VM is started with multiple disks it is almost impossible to > >guess which one of them will be used as boot device especially if there > >is a mix of ATA/virtio/SCSI devices.

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 05:30 PM, Stefan Hajnoczi wrote: > > It was discussed before, but I don't think we came to a conclusion. Are > there any circumstances under which you don't want to set the > QED_CF_BACKING_FORMAT flag? I suggest the following: QED_CF_BACKING_FORMAT_RAW = 0x1 When set, the ba

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Kevin Wolf
Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: > Signed-off-by: Stefan Hajnoczi > --- > docs/specs/qed_spec.txt | 94 > +++ > 1 files changed, 94 insertions(+), 0 deletions(-) > create mode 100644 docs/specs/qed_spec.txt > > diff --git a/docs/specs/

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 05:49 PM, Anthony Liguori wrote: On 10/11/2010 09:58 AM, Avi Kivity wrote: A leak is unacceptable. It means an image can grow to an unbounded size. If you are a server provider offering multitenancy, then a malicious guest can potentially grow the image beyond it's allotted si

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 10:24 AM, Avi Kivity wrote: On 10/11/2010 05:02 PM, Anthony Liguori wrote: On 10/11/2010 08:44 AM, Avi Kivity wrote: On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > > A leak is acceptable (it won't grow; it's just an unused, incorrect > freelist), but data corruption is not.

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Stefan Hajnoczi
2010/10/11 Gleb Natapov : > On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: >> On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl >> wrote: >> > Am 11.10.2010 12:18, schrieb ext Gleb Natapov: >> >> >> >> Currently if VM is started with multiple disks it is almost impossible to >> >>

[Qemu-devel] [PATCH V5 00/14] xen device model support

2010-10-11 Thread anthony . perard
From: Anthony PERARD Hi all, This is the fifth version of the patch series that adds Xen device model support in QEMU. The change we have made on the last version are: - We removed the Xen specific ACPI PIIX4 implementation and added a Xen call in acpi_piix4.c for the sleep state. - W

Re: [Qemu-devel] [PATCH 03/12] eepro100: initialize a variable in all cases

2010-10-11 Thread Stefan Weil
Am 11.10.2010 16:53, schrieb Markus Armbruster: Blue Swirl writes: Compiling with GCC 4.6.0 20100925 produced warnings: /src/qemu/hw/eepro100.c: In function 'eepro100_read4': /src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used uninitialized in this function [-Werror=uninitialized] /src/q

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 05:41 PM, Anthony Liguori wrote: On 10/11/2010 10:24 AM, Avi Kivity wrote: On 10/11/2010 05:02 PM, Anthony Liguori wrote: On 10/11/2010 08:44 AM, Avi Kivity wrote: On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > > A leak is acceptable (it won't grow; it's just an unused, i

[Qemu-devel] [PATCH V5 02/14] xen: Support new libxc calls from xen unstable.

2010-10-11 Thread anthony . perard
From: Anthony PERARD Update the libxenctrl calls in Qemu to use the new interface, otherwise Qemu wouldn't be able to build against new versions of the library. We also check libxenctrl version in configure, from Xen 3.3.0 to Xen unstable. Signed-off-by: Anthony PERARD Signed-off-by: Stefano S

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 10:46 AM, Stefan Hajnoczi wrote: On Mon, Oct 11, 2010 at 05:39:01PM +0200, Avi Kivity wrote: On 10/11/2010 05:30 PM, Stefan Hajnoczi wrote: It was discussed before, but I don't think we came to a conclusion. Are there any circumstances under which you don't want to

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Kevin Wolf
Am 11.10.2010 17:30, schrieb Stefan Hajnoczi: > On Mon, Oct 11, 2010 at 03:58:07PM +0200, Kevin Wolf wrote: >> Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: >>> Signed-off-by: Stefan Hajnoczi >>> --- >>> docs/specs/qed_spec.txt | 94 >>> +++ >>> 1 fi

[Qemu-devel] [PATCH V5 04/14] Introduce -accel command option.

2010-10-11 Thread anthony . perard
From: Anthony PERARD This option gives the ability to switch one "accelerator" like kvm, xen or the default one tcg. We can specify more than one accelerator by separate them by a comma. QEMU will try each one and use the first whose works. So, -accel xen,kvm,tcg which would try Xen support fi

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 04:06 PM, Stefan Hajnoczi wrote: On Mon, Oct 11, 2010 at 03:44:38PM +0200, Avi Kivity wrote: > On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > >> > >> A leak is acceptable (it won't grow; it's just an unused, incorrect > >> freelist), but data corruption is not. > > > >

[Qemu-devel] [PATCH V5 03/14] xen: Add xen_machine_fv

2010-10-11 Thread anthony . perard
From: Anthony PERARD Add the Xen FV (Fully Virtualized) machine to Qemu; this is groundwork to add Xen device model support in Qemu. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- Makefile.target |3 + hw/xen_common.h |5 ++ hw/xen_machine_fv.c | 158

[Qemu-devel] [PATCH V5 01/14] xen: Replace some tab-indents with spaces (clean-up).

2010-10-11 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/xen_backend.c | 308 hw/xen_disk.c| 412 +++--- hw/xen_nic.c | 222 +++--- 3 files changed, 471 insertions(+), 47

[Qemu-devel] [PATCH V5 07/14] piix_pci: Introduces Xen specific call for irq.

2010-10-11 Thread anthony . perard
From: Anthony PERARD This patch introduces Xen specific call in piix_pci. The specific part for Xen is in write_config, set_irq and get_pirq. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/piix_pci.c | 28 ++-- hw/xen.h |6 ++ xe

[Qemu-devel] [PATCH V5 06/14] xen: Add the Xen platform pci device

2010-10-11 Thread anthony . perard
From: Anthony PERARD Introduce a new emulated PCI device, specific to fully virtualized Xen guests. The device is necessary for PV on HVM drivers to work. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- Makefile.target |1 + hw/hw.h |3 + hw/pci_id

[Qemu-devel] [PATCH V5 08/14] xen: add a 8259 Interrupt Controller

2010-10-11 Thread anthony . perard
From: Anthony PERARD Introduce a 8259 Interrupt Controller for target-xen; every set_irq call makes a Xen hypercall. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/xen_common.h |2 ++ hw/xen_machine_fv.c |5 ++--- xen-all.c | 12 3

[Qemu-devel] [PATCH V5 13/14] xen: Set running state in xenstore.

2010-10-11 Thread anthony . perard
From: Anthony PERARD This tells to the xen management tool that the machine can begin run. Signed-off-by: Anthony PERARD --- xen-all.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index a0d1b9b..fc862cb 100644 --- a/x

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 04:52:31PM +0100, Stefan Hajnoczi wrote: > 2010/10/11 Gleb Natapov : > > On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: > >> On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl > >> wrote: > >> > Am 11.10.2010 12:18, schrieb ext Gleb Natapov: > >> >> > >> >>

[Qemu-devel] [PATCH V5 10/14] Introduce qemu_ram_ptr_unlock.

2010-10-11 Thread anthony . perard
From: Anthony PERARD This function allows to unlock a ram_ptr give by qemu_get_ram_ptr. After a call to qemu_ram_ptr_unlock, the pointer may be unmap from QEMU when used with Xen. Signed-off-by: Anthony PERARD --- cpu-common.h |1 + exec.c | 10 ++ xen-mapcache.c | 34

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: > On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl wrote: > > Am 11.10.2010 12:18, schrieb ext Gleb Natapov: > >> > >> Currently if VM is started with multiple disks it is almost impossible to > >> guess which one of them will be used

[Qemu-devel] [PATCH V5 12/14] xen: Initialize event channels and io rings

2010-10-11 Thread anthony . perard
From: Anthony PERARD Open and bind event channels; map ioreq and buffered ioreq rings. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/xen_common.h |3 + xen-all.c | 407 +++ 2 files changed, 410 insertions(

[Qemu-devel] [PATCH V5 11/14] vl.c: Introduce getter for shutdown_requested and reset_requested.

2010-10-11 Thread anthony . perard
From: Anthony PERARD Introduce two functions qemu_shutdown_requested_get and qemu_reset_requested_get to get the value of shutdown/reset_requested without reset it. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- sysemu.h |2 ++ vl.c | 10 ++ 2 files chan

[Qemu-devel] [PATCH V5 05/14] xen: Add xen in -accel option.

2010-10-11 Thread anthony . perard
From: Anthony PERARD This come with the initialisation of Xen. Signed-off-by: Anthony PERARD --- Makefile.target |5 + hw/xen.h| 10 ++ vl.c|2 ++ xen-all.c | 25 + xen-stub.c | 17 + 5 files chang

Re: [Qemu-devel] [RFC] Can we remove special handling of standard headers (introduced for dyngen / OSX?)

2010-10-11 Thread Stefan Weil
Am 10.10.2010 00:46, schrieb Andreas Färber: Am 04.10.2010 um 21:29 schrieb Stefan Weil: Am 25.09.2010 09:46, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 8:44 PM, Stefan Weil wrote: Am 23.09.2010 22:33, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 7:28 PM, Stefan Weil wrote: Replace the

[Qemu-devel] [PATCH V5 14/14] acpi-piix4: Add Xen hypercall for sleep state.

2010-10-11 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/acpi_piix4.c |4 hw/xen.h|2 ++ xen-all.c |7 +++ xen-stub.c |4 4 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index c8733e5..058bd5f 10

[Qemu-devel] [PATCH V5 09/14] xen: Introduce the Xen mapcache

2010-10-11 Thread anthony . perard
From: Anthony PERARD The mapcache maps chucks of guest memory on demand, unmaps them when they are not needed anymore. Each call to qemu_get_ram_ptr makes a call to qemu_map_cache with the lock option, so mapcache will not unmap these ram_ptr. Signed-off-by: Anthony PERARD Signed-off-by: Stefa

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-11 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 03:10:16PM +0200, Avi Kivity wrote: > On 10/11/2010 12:37 PM, Stefan Hajnoczi wrote: > >On Sun, Oct 10, 2010 at 11:10:15AM +0200, Avi Kivity wrote: > >> On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: > >> >This patch implements the read/write state machine. Operations a

[Qemu-devel] Re: [SeaBIOS] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Avi Kivity
On 10/11/2010 05:39 PM, Gleb Natapov wrote: On Mon, Oct 11, 2010 at 05:09:22PM +0200, Avi Kivity wrote: > On 10/11/2010 12:18 PM, Gleb Natapov wrote: > >Currently if VM is started with multiple disks it is almost impossible to > >guess which one of them will be used as boot device especially

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 11:02 AM, Avi Kivity wrote: On 10/11/2010 05:49 PM, Anthony Liguori wrote: On 10/11/2010 09:58 AM, Avi Kivity wrote: A leak is unacceptable. It means an image can grow to an unbounded size. If you are a server provider offering multitenancy, then a malicious guest can potentia

[Qemu-devel] Re: [SeaBIOS] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Avi Kivity
On 10/11/2010 12:18 PM, Gleb Natapov wrote: Currently if VM is started with multiple disks it is almost impossible to guess which one of them will be used as boot device especially if there is a mix of ATA/virtio/SCSI devices. Essentially BIOS decides the order and without looking into the code

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Anthony Liguori
On 10/11/2010 11:18 AM, Anthony Liguori wrote: On 10/11/2010 10:46 AM, Stefan Hajnoczi wrote: On Mon, Oct 11, 2010 at 05:39:01PM +0200, Avi Kivity wrote: On 10/11/2010 05:30 PM, Stefan Hajnoczi wrote: It was discussed before, but I don't think we came to a conclusion. Are there any circ

Re: [Qemu-devel] [PATCH 03/12] eepro100: initialize a variable in all cases

2010-10-11 Thread Markus Armbruster
Stefan Weil writes: > Am 11.10.2010 16:53, schrieb Markus Armbruster: >> Blue Swirl writes: >> >>> Compiling with GCC 4.6.0 20100925 produced warnings: >>> /src/qemu/hw/eepro100.c: In function 'eepro100_read4': >>> /src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used >>> uninitialized in th

[Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-11 Thread Avi Kivity
On 10/11/2010 03:42 PM, Stefan Hajnoczi wrote: > > A leak is acceptable (it won't grow; it's just an unused, incorrect > freelist), but data corruption is not. The alternative is for the freelist to be a non-compat feature bit. That means older QEMU binaries cannot use a QED image that has en

[Qemu-devel] [Bug 485251] Re: qemu 0.11.50: Guest boot failed when the drive interface is scsi

2010-10-11 Thread Michael Tokarev
The crashes were most likely fixed by commit e8637c9013609271772cc0c3436cb1240cd6b034 , which is a part of 0.13 and while it applies to 0.12 just fine, it didn't went into 0.12-stable. -- qemu 0.11.50: Guest boot failed when the drive interface is scsi https://bugs.launchpad.net/bugs/485251 You r

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Anthony Liguori
On 10/11/2010 10:52 AM, Stefan Hajnoczi wrote: 2010/10/11 Gleb Natapov: On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl wrote: Am 11.10.2010 12:18, schrieb ext Gleb Natapov: Currently if VM is starte

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-11 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 12:01:58PM -0500, Anthony Liguori wrote: > On 10/11/2010 10:52 AM, Stefan Hajnoczi wrote: > >2010/10/11 Gleb Natapov: > >>On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: > >>>On Mon, Oct 11, 2010 at 12:16 PM, Bernhard Kohl > >>>wrote: > Am 11.10.2010 1

Re: [Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-11 Thread Markus Armbruster
Jes, I feel a bit bad finding still more faults, but here goes... jes.soren...@redhat.com writes: > From: Jes Sorensen > > strtosz() returns -1 on error. It now supports human unit formats in > eg. 1.0G, with better error handling. > > Signed-off-by: Jes Sorensen > --- > cutils.c | 61

[Qemu-devel] [patch 0/8] port qemu-kvm's MCE support (v3)

2010-10-11 Thread Marcelo Tosatti
Port qemu-kvm's KVM MCE (Machine Check Exception) handling to qemu. It allows qemu to propagate MCEs to the guest. v2: - rename do_qemu_ram_addr_from_host. - fix kvm_on_sigbus/kvm_on_sigbus_vcpu naming. - fix bank register restoration (Dean Nelson). v3: - condition MCE generation on MCE_SEG_P bit

  1   2   >