[Qemu-devel] [PATCH 00/14] pcie port switch emulators

2010-09-06 Thread Isaku Yamahata
This patch series implements pcie port switch emulators which is basic part for pcie/q35 support. This is for mst/pci tree. some random comments - pci bus reset As Anthony is cleaning up qdev reset stuff, so pci bus reset code is commented out. Once the qdev clean up is done, the patch that

[Qemu-devel] [PATCH 01/14] RESEND apb: fix typo.

2010-09-06 Thread Isaku Yamahata
fix typo. Signed-off-by: Isaku Yamahata --- hw/apb_pci.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/apb_pci.c b/hw/apb_pci.c index 10a5baa..c619112 100644 --- a/hw/apb_pci.c +++ b/hw/apb_pci.c @@ -362,7 +362,7 @@ PCIBus *pci_apb_init(target_phys_addr_t speci

[Qemu-devel] [PATCH 06/14] pci_ids.h: add vendor id of Texus Intesruments.

2010-09-06 Thread Isaku Yamahata
add vendor id of Texus Intesruments. Signed-off-by: Isaku Yamahata --- hw/pci_ids.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index 39e9f1d..82cba7e 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -57,6 +57,8 @@ #define PCI_VENDOR_ID_A

[Qemu-devel] [PATCH 14/14] pcie/aer: glue aer error injection into qemu monitor.

2010-09-06 Thread Isaku Yamahata
glue aer error injection into qemu monitor. Signed-off-by: Isaku Yamahata Conflicts: hw/pcie.c --- hw/pcie.c | 85 +++ qemu-monitor.hx | 22 ++ sysemu.h|5 +++ 3 files changed, 112 insertions(+), 0 de

[Qemu-devel] [PATCH 10/14] pcie root port: implement pcie root port.

2010-09-06 Thread Isaku Yamahata
pcie root port. Signed-off-by: Isaku Yamahata --- Makefile.objs |2 +- hw/pcie_root.c | 247 hw/pcie_root.h | 32 +++ 3 files changed, 280 insertions(+), 1 deletions(-) create mode 100644 hw/pcie_root.c create mode 100644 hw/

[Qemu-devel] [PATCH 04/14] pci: call hotplug callback even when not hotplug case for later use.

2010-09-06 Thread Isaku Yamahata
call hotplug callback even when not hotplug case for later use. And move hotplug check into hotplug callback. PCIE slot needs this for card presence detection. Signed-off-by: Isaku Yamahata --- hw/acpi_piix4.c |3 +++ hw/pci.c|3 ++- 2 files changed, 5 insertions(+), 1 deletions(

[Qemu-devel] [PATCH 02/14] pci: consolidate pci_add_capability_at_offset() into pci_add_capability().

2010-09-06 Thread Isaku Yamahata
By making pci_add_capability() the special case of pci_add_capability_at_offset() of offset = 0, consolidate pci_add_capability_at_offset() into pci_add_capability(). Cc: Stefan Weil Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/eepro100.c |4 ++-- hw/msix.c |3 ++- h

[Qemu-devel] [PATCH 03/14] pci bridge: add helper function for ssvid capability.

2010-09-06 Thread Isaku Yamahata
helper function to add ssvid capability. Signed-off-by: Isaku Yamahata --- hw/pci_bridge.c | 19 +++ hw/pci_bridge.h |3 +++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/hw/pci_bridge.c b/hw/pci_bridge.c index 198c3c7..638e3b3 100644 --- a/hw/pci_bridge.c

[Qemu-devel] [PATCH 05/14] pci: make pci_parse_devfn() aware of func.

2010-09-06 Thread Isaku Yamahata
make pci_parse_devfn() aware of func. With func = NULL it behave as before. This will be used later. Signed-off-by: Isaku Yamahata --- hw/pci.c | 34 ++ hw/pci.h |2 ++ 2 files changed, 28 insertions(+), 8 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index

[Qemu-devel] [PATCH 11/14] pcie upstream port: pci express switch upstream port.

2010-09-06 Thread Isaku Yamahata
pci express switch upstream port. Signed-off-by: Isaku Yamahata --- Makefile.objs |2 +- hw/pcie_upstream.c | 206 hw/pcie_upstream.h | 32 3 files changed, 239 insertions(+), 1 deletions(-) create mode 100644 hw/pcie_ups

[Qemu-devel] [PATCH 07/14] msi: implemented msi.

2010-09-06 Thread Isaku Yamahata
implemented msi support functions. Signed-off-by: Isaku Yamahata --- Makefile.objs |2 +- hw/msi.c | 362 + hw/msi.h | 41 +++ hw/pci.h |5 + 4 files changed, 409 insertions(+), 1 deletions(-) create mode 1006

[Qemu-devel] [PATCH 13/14] pcie/hotplug: glue pushing attention button command. pcie_abp

2010-09-06 Thread Isaku Yamahata
glue to pcie_abp monitor command. Signed-off-by: Isaku Yamahata --- hw/pcie_port.c | 82 +++ qemu-monitor.hx | 14 + sysemu.h|4 +++ 3 files changed, 100 insertions(+), 0 deletions(-) diff --git a/hw/pcie_port.c b/hw/p

[Qemu-devel] [PATCH 12/14] pcie downstream port: pci express switch downstream port.

2010-09-06 Thread Isaku Yamahata
pcie switch downstream port. Signed-off-by: Isaku Yamahata --- Makefile.objs|1 + hw/pcie_downstream.c | 224 ++ hw/pcie_downstream.h | 33 3 files changed, 258 insertions(+), 0 deletions(-) create mode 100644 hw/pcie_downs

[Qemu-devel] [PATCH 09/14] pcie port: define struct PCIEPort/PCIESlot and helper functions

2010-09-06 Thread Isaku Yamahata
define struct PCIEPort which represents common part of pci express port.(root, upstream and downstream.) add a helper function for pcie port which can be used commonly by root/upstream/downstream port. define struct PCIESlot which represents common part of pcie slot.(root and downstream.) and helpe

[Qemu-devel] Re: [PATCH 02/14] pci: consolidate pci_add_capability_at_offset() into pci_add_capability().

2010-09-06 Thread Michael S. Tsirkin
On Mon, Sep 06, 2010 at 04:46:16PM +0900, Isaku Yamahata wrote: > By making pci_add_capability() the special case of > pci_add_capability_at_offset() of offset = 0, > consolidate pci_add_capability_at_offset() into pci_add_capability(). > > Cc: Stefan Weil > Cc: Michael S. Tsirkin > Signed-off-b

[Qemu-devel] Re: Unmaintained QEMU builds

2010-09-06 Thread Paolo Bonzini
On 09/05/2010 06:05 PM, Avi Kivity wrote: I'm perfectly fine with dropping it. btw, there are other features in qemu that seem to be academic exercises - *-user for example. What is it useful for? Most open source stuff is multiplatform, and serious commercial work needs something faster than tcg

[Qemu-devel] Re: [PATCH] scsi-disk: add some optional scsi commands

2010-09-06 Thread Bernhard Kohl
Am 03.09.2010 17:41, schrieb ext Kevin Wolf: Am 02.09.2010 15:11, schrieb Bernhard Kohl: I use a legacy OS which depends on some optional SCSI commands. In fact this implementation does nothing special, but provides minimum support for the following commands: REZERO UNIT WRITE AND VERIFY(10

[Qemu-devel] [PATCH v2] scsi-disk: add some optional scsi commands

2010-09-06 Thread Bernhard Kohl
I use a legacy OS which depends on some optional SCSI commands. In fact this implementation does nothing special, but provides minimum support for the following commands: REZERO UNIT WRITE AND VERIFY(10) WRITE AND VERIFY(12) WRITE AND VERIFY(16) MODE SELECT(6) MODE SELECT(10) SEEK(6) SEEK(10) Si

Re: [Qemu-devel] PCIe Qemu changes for Q35

2010-09-06 Thread Isaku Yamahata
On Sun, Sep 05, 2010 at 08:09:18PM -0700, Adhyas Avasthi wrote: > Hi Isaku > > I believe you were working on the Q35 chipset and PCIe emulation for > the same, and planned to check your code in to the main git. I can use > some of that work for something I am working on. > I have not been too acti

Re: [Qemu-devel] [PATCH] lsi53c895a: avoid calling a NULL function

2010-09-06 Thread Bernhard Kohl
Am 02.09.2010 16:45, schrieb ext Kevin Wolf: I suspect the real fix is to add a reset handler to scsi-generic. It should probably remove the requests like it's currently done in scsi_destroy. The same change was made for scsi-disk in e9447f35. Yes, I agree. Let's skip this patch. I'll send

[Qemu-devel] Re: [PATCH v2] scsi-disk: add some optional scsi commands

2010-09-06 Thread Kevin Wolf
Am 06.09.2010 11:25, schrieb Bernhard Kohl: > I use a legacy OS which depends on some optional SCSI commands. > In fact this implementation does nothing special, but provides minimum > support for the following commands: > > REZERO UNIT > WRITE AND VERIFY(10) > WRITE AND VERIFY(12) > WRITE AND VER

Re: [Qemu-devel] Re: Unmaintained QEMU builds

2010-09-06 Thread Corentin Chary
On Mon, Sep 6, 2010 at 10:59 AM, Paolo Bonzini wrote: > On 09/05/2010 06:05 PM, Avi Kivity wrote: > >> I'm perfectly fine with dropping it. btw, there are other features in >> qemu that seem to be academic exercises - *-user for example. What is it >> useful for? Most open source stuff is multipl

[Qemu-devel] Re: [PATCH v2] scsi-disk: add some optional scsi commands

2010-09-06 Thread Bernhard Kohl
Am 06.09.2010 11:33, schrieb ext Kevin Wolf: Sorry to request another version, but this patch is corrupted by line wraps. I think it was right when you sent the first version, did you change anything? No I didn't change anything. I did 'git commit -s --amend' and 'git format-patch' and then

[Qemu-devel] Re: [PATCH 07/14] msi: implemented msi.

2010-09-06 Thread Michael S. Tsirkin
On Mon, Sep 06, 2010 at 04:46:21PM +0900, Isaku Yamahata wrote: > implemented msi support functions. > > Signed-off-by: Isaku Yamahata Good stuff. Below I suggest a couple of minor correctness issues, and a couple of API changes. Below are also some suggestions to improve readability a bit: mo

[Qemu-devel] [PATCH v3] scsi-disk: add some optional scsi commands

2010-09-06 Thread Bernhard Kohl
I use a legacy OS which depends on some optional SCSI commands. In fact this implementation does nothing special, but provides minimum support for the following commands: REZERO UNIT WRITE AND VERIFY(10) WRITE AND VERIFY(12) WRITE AND VERIFY(16) MODE SELECT(6) MODE SELECT(10) SEEK(6) SEEK(10) Sig

[Qemu-devel] Re: [PATCH 01/14] RESEND apb: fix typo.

2010-09-06 Thread Michael S. Tsirkin
On Mon, Sep 06, 2010 at 04:46:15PM +0900, Isaku Yamahata wrote: > fix typo. > > Signed-off-by: Isaku Yamahata This is separate from the express patches, right? I'll appply this. Thanks! > --- > hw/apb_pci.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/

[Qemu-devel] Re: [PATCH v2] scsi-disk: add some optional scsi commands

2010-09-06 Thread Kevin Wolf
Am 06.09.2010 11:41, schrieb Bernhard Kohl: > Am 06.09.2010 11:33, schrieb ext Kevin Wolf: >> Sorry to request another version, but this patch is corrupted by line >> wraps. I think it was right when you sent the first version, did you >> change anything? >> > > No I didn't change anything. I

[Qemu-devel] Re: [PATCH v3] scsi-disk: add some optional scsi commands

2010-09-06 Thread Kevin Wolf
Am 06.09.2010 11:50, schrieb Bernhard Kohl: > I use a legacy OS which depends on some optional SCSI commands. > In fact this implementation does nothing special, but provides minimum > support for the following commands: > > REZERO UNIT > WRITE AND VERIFY(10) > WRITE AND VERIFY(12) > WRITE AND VER

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Alexander Graf
On 06.09.2010, at 12:04, Stefan Hajnoczi wrote: > QEMU Enhanced Disk format is a disk image format that forgoes features > found in qcow2 in favor of better levels of performance and data > integrity. Due to its simpler on-disk layout, it is possible to safely > perform metadata updates more eff

[Qemu-devel] Re: [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Kevin Wolf
Am 06.09.2010 12:04, schrieb Stefan Hajnoczi: > QEMU Enhanced Disk format is a disk image format that forgoes features > found in qcow2 in favor of better levels of performance and data > integrity. Due to its simpler on-disk layout, it is possible to safely > perform metadata updates more efficie

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Stefan Hajnoczi
On Mon, Sep 6, 2010 at 11:25 AM, Alexander Graf wrote: > Should be an extra patch - it doesn't hurt to send an RFC patch set. This > thing is so big that it's no fun to review :). I'll start consolidating commits so the next round will be easier to review. Stefan

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Daniel P. Berrange
On Mon, Sep 06, 2010 at 11:04:38AM +0100, Stefan Hajnoczi wrote: > QEMU Enhanced Disk format is a disk image format that forgoes features > found in qcow2 in favor of better levels of performance and data > integrity. Due to its simpler on-disk layout, it is possible to safely > perform metadata u

[Qemu-devel] Re: [PATCH] qemu: e1000 fix TOR math

2010-09-06 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > Patch b0b900070c7cb29bbefb732ec00397abe5de6d73 made > TOR valuer incorrect: the spec says it should always > include the CRC field, while size does not include CRC now. > No one seems to use TOR field (which is likely why > current code works fine), but better to stic

Re: [Qemu-devel] Re: [PATCH] vl.c: set NULL upon deleting handlers in qemu_set_fd_handler2()

2010-09-06 Thread Yoshiaki Tamura
2010/8/23 Corentin Chary : > On Mon, Aug 23, 2010 at 2:55 AM, Yoshiaki Tamura > wrote: >> Currently qemu_set_fd_handler2() is only setting ioh->deleted upon >> deleting.  This may cause a crash when a read handler calls >> qemu_set_fd_handler2() to delete handlers, but a write handler is >> still

[Qemu-devel] Re: [PATCH] qemu: e1000 fix TOR math

2010-09-06 Thread Michael S. Tsirkin
On Mon, Sep 06, 2010 at 01:29:27PM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > Patch b0b900070c7cb29bbefb732ec00397abe5de6d73 made > > TOR valuer incorrect: the spec says it should always > > include the CRC field, while size does not include CRC now. > > No one seems to use TOR

[Qemu-devel] [PATCH] hpet: check no_hpet when adding fw_cfg entry.

2010-09-06 Thread Gerd Hoffmann
We should only pass the hpet config entry in case we actually create a hpet device. Signed-off-by: Gerd Hoffmann --- hw/pc.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 0c31db1..c96f1fc 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -517,8 +517,10

[Qemu-devel] [PATCHv2] qemu: e1000 fix TOR math

2010-09-06 Thread Michael S. Tsirkin
Patch b0b900070c7cb29bbefb732ec00397abe5de6d73 made TOR valuer incorrect: the spec says it should always include the CRC field. No one seems to use this field, but better to stick to spec. Signed-off-by: Michael S. Tsirkin --- Changes from v1: minor refactoring to avoid += within if stat

Re: [Qemu-devel] Re: [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Stefan Hajnoczi
On Mon, Sep 6, 2010 at 11:27 AM, Kevin Wolf wrote: > Am 06.09.2010 12:04, schrieb Stefan Hajnoczi: >> QEMU Enhanced Disk format is a disk image format that forgoes features >> found in qcow2 in favor of better levels of performance and data >> integrity.  Due to its simpler on-disk layout, it is p

Re: [Qemu-devel] Re: [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Anthony Liguori
On 09/06/2010 05:27 AM, Kevin Wolf wrote: Okay, so before I actually look at the patch longer than a couple of seconds let me just ask the obvious question... Before inventing yet another image format, you certainly have checked the existing ones. Obviously, yes. Here are the issues: cow.c:

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Anthony Liguori
On 09/06/2010 06:18 AM, Daniel P. Berrange wrote: I agree with ditching compression, but encryption is an important capability which cannot be satisfactorily added at other layers in the stack. While block devices / local filesystems can layer in dm-crypt in the host, this is not possible with ne

Re: [Qemu-devel] Re: [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Anthony Liguori
On 09/06/2010 07:40 AM, Stefan Hajnoczi wrote: On Mon, Sep 6, 2010 at 11:27 AM, Kevin Wolf wrote: Am 06.09.2010 12:04, schrieb Stefan Hajnoczi: QEMU Enhanced Disk format is a disk image format that forgoes features found in qcow2 in favor of better levels of performance and data inte

Re: [Qemu-devel] Re: [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Stefan Hajnoczi
On Mon, Sep 6, 2010 at 1:57 PM, Anthony Liguori wrote: > On 09/06/2010 07:40 AM, Stefan Hajnoczi wrote: >> >> On Mon, Sep 6, 2010 at 11:27 AM, Kevin Wolf  wrote: >> >>> >>> Am 06.09.2010 12:04, schrieb Stefan Hajnoczi: >>> QEMU Enhanced Disk format is a disk image format that forgoes fea

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-06 Thread Kevin Wolf
Am 04.09.2010 23:07, schrieb Blue Swirl: > On Sat, Sep 4, 2010 at 8:30 PM, andrzej zaborowski wrote: >> Hi, >> >> On 4 September 2010 21:45, Blue Swirl wrote: >>> On Sat, Sep 4, 2010 at 5:57 PM, andrzej zaborowski >>> wrote: > -if (event < 0 || event >= BLKDBG_EVENT_MAX) { > +

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Anthony Liguori
On 09/06/2010 05:04 AM, Stefan Hajnoczi wrote: QEMU Enhanced Disk format is a disk image format that forgoes features found in qcow2 in favor of better levels of performance and data integrity. Due to its simpler on-disk layout, it is possible to safely perform metadata updates more efficiently.

Re: [Qemu-devel] Re: [PATCH 00/14] trace: Add static tracing to QEMU

2010-09-06 Thread Stefan Hajnoczi
On Sun, Sep 5, 2010 at 8:30 AM, Michael S. Tsirkin wrote: > On Thu, Aug 12, 2010 at 11:36:21AM +0100, Stefan Hajnoczi wrote: >> 2. The built-in 'simple' trace backend writes binary traces to >>    /tmp/trace-. > > Saving files with predictable names in /tmp is usually not a good idea, > see e.g. h

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Daniel P. Berrange
On Mon, Sep 06, 2010 at 07:52:41AM -0500, Anthony Liguori wrote: > On 09/06/2010 06:18 AM, Daniel P. Berrange wrote: > >I agree with ditching compression, but encryption is an important > >capability which cannot be satisfactorily added at other layers > >in the stack. While block devices / local f

[Qemu-devel] [PATCH] scsi-generic: add missing reset handler

2010-09-06 Thread Bernhard Kohl
Ensure that pending requests of a SCSI generic device are purged on system reset. This also avoids calling a NULL function in lsi53c895a. The lsi code was recently changed to call the .qdev.reset function. Signed-off-by: Bernhard Kohl --- hw/scsi-generic.c | 21 +++-- 1 files c

Re: [Qemu-devel] Re: [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Kevin Wolf
Am 06.09.2010 14:57, schrieb Anthony Liguori: > On 09/06/2010 07:40 AM, Stefan Hajnoczi wrote: >> On Mon, Sep 6, 2010 at 11:27 AM, Kevin Wolf wrote: >> >>> Am 06.09.2010 12:04, schrieb Stefan Hajnoczi: >>> QEMU Enhanced Disk format is a disk image format that forgoes features f

[Qemu-devel] [rfc 1/3] arm : raise an error if the kernel size will overlap the initrd

2010-09-06 Thread Daniel Lezcano
If the kernel size is too big, it overwrite the initrd image in memory without detecting the problem. Let't detect this error and exit gracefully. Signed-off-by: Daniel Lezcano --- hw/arm_boot.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/arm_boot.c b/hw/arm

[Qemu-devel] [rfc 0/3] arm : dynamically choose initrd load address

2010-09-06 Thread Daniel Lezcano
Hi all, after compiling my kernel on the arm architecture I was not able to start it because qemu was segfaulting or going to an infinite loop. After google'ing I found on launchpad the bug: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/524893 Following the indications, I rebuilt qemu wi

[Qemu-devel] [rfc 2/3] arm : factor out set_kernel_args[_old]

2010-09-06 Thread Daniel Lezcano
'initrd_size' and 'base' are already present in the 'info' structure, passing them as parameter is redundant with the first parameter. Signed-off-by: Daniel Lezcano --- hw/arm_boot.c | 26 ++ 1 files changed, 10 insertions(+), 16 deletions(-) diff --git a/hw/arm_boot.c

[Qemu-devel] [rfc 3/3] arm : make initrd load address dynamic

2010-09-06 Thread Daniel Lezcano
Instead of hardcoding a default value for initrd, let's compute dynamically from the kernel load address and its size. We go one page after the end of the kernel. Signed-off-by: Daniel Lezcano --- hw/arm-misc.h |1 + hw/arm_boot.c | 19 --- 2 files changed, 9 insertions(+),

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Luca Tettamanti
On Mon, Sep 6, 2010 at 12:25 PM, Alexander Graf wrote: > On 06.09.2010, at 12:04, Stefan Hajnoczi wrote: >> + >> +const char *bytes_to_str(uint64_t size) >> +{ >> +    static char buffer[64]; >> + >> +    if (size < (1ULL << 10)) { >> +        snprintf(buffer, sizeof(buffer), "%" PRIu64 " byte(s)"

[Qemu-devel] [PATCH] lsi53c895a: add support for ABORT messages

2010-09-06 Thread Bernhard Kohl
If these messages are not handled correctly the guest driver may hang. Always mandatory: - ABORT - BUS DEVICE RESET Mandatory if tagged queuing is implemented (which disks usually do): - ABORT TAG - CLEAR QUEUE Signed-off-by: Bernhard Kohl --- hw/lsi53c895a.c | 57 +++

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Alexander Graf
On 06.09.2010, at 16:21, Luca Tettamanti wrote: > On Mon, Sep 6, 2010 at 12:25 PM, Alexander Graf wrote: >> On 06.09.2010, at 12:04, Stefan Hajnoczi wrote: >>> + >>> +const char *bytes_to_str(uint64_t size) >>> +{ >>> +static char buffer[64]; >>> + >>> +if (size < (1ULL << 10)) { >>> +

[Qemu-devel] [PATCH] scsi_bus: fix length and xfer_mode for RESERVE and RELEASE commands

2010-09-06 Thread Bernhard Kohl
For the RESERVE and RELEASE commands the length must be zero and xfer_mode must be SCSI_XFER_NONE. Signed-off-by: Bernhard Kohl --- hw/scsi-bus.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 7aa0bcd..5a3fd4b 100644 --- a/hw/scsi-b

[Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices

2010-09-06 Thread Bernhard Kohl
From: Bernhard Kohl Allow symbolic links which point to /dev/sgX devices. Signed-off-by: Bernhard Kohl --- block/raw-posix.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 72fb8ce..4544a57 100644 --- a/block/raw-pos

Re: [Qemu-devel] [PULL 00/10] Block patches

2010-09-06 Thread Kevin Wolf
Am 30.08.2010 18:32, schrieb Kevin Wolf: > The following changes since commit 02a89b219039621c940863aa5a9da4fec81a1546: > > isapc: fix segfault. (2010-08-28 08:50:40 +) > > are available in the git repository at: > git://repo.or.cz/qemu/kevin.git for-anthony > > Andrew de Quincey (1): >

[Qemu-devel] [PATCH 14/14] trace: Trace entry point of balloon request handler

2010-09-06 Thread Stefan Hajnoczi
From: Prerna Saxena Signed-off-by: Prerna Saxena Signed-off-by: Stefan Hajnoczi --- balloon.c|2 ++ trace-events |4 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/balloon.c b/balloon.c index 8e0b7f1..0021fef 100644 --- a/balloon.c +++ b/balloon.c @@ -29,6 +29,

[Qemu-devel] [PATCH 08/14] trace: Add LTTng Userspace Tracer backend

2010-09-06 Thread Stefan Hajnoczi
This patch adds LTTng Userspace Tracer (UST) backend support. The UST system requires no kernel support but libust and liburcu must be installed. $ ./configure --trace-backend ust $ make Start the UST daemon: $ ustd & List available tracepoints and enable some: $ ustctl --list-markers $(pgrep q

[Qemu-devel] [PATCH 05/14] trace: Specify trace file name

2010-09-06 Thread Stefan Hajnoczi
From: Prerna Saxena Allow users to specify a file for trace-outputs at configuration. Also, allow trace files to be annotated by so each qemu instance has unique traces. The trace file name can be passed as a config option: --trace-file=/path/to/file (Default: trace ) At runtime, the pid of the

[Qemu-devel] [PATCH 03/14] trace: Support for dynamically enabling/disabling trace events

2010-09-06 Thread Stefan Hajnoczi
From: Prerna Saxena This patch adds support for dynamically enabling/disabling of trace events. This is done by internally maintaining each trace event's state, and permitting logging of data from a trace event only if it is in an 'active' state. Monitor commands added : 1) info trace-events

[Qemu-devel] [PATCH 10/14] trace: Trace qemu_malloc() and qemu_vmalloc()

2010-09-06 Thread Stefan Hajnoczi
It is often useful to instrument memory management functions in order to find leaks or performance problems. This patch adds trace events for the memory allocation primitives. Signed-off-by: Stefan Hajnoczi --- osdep.c | 24 ++-- qemu-malloc.c | 12 ++-- tr

[Qemu-devel] [PATCH 13/14] trace: Trace port IO

2010-09-06 Thread Stefan Hajnoczi
From: Prerna Saxena Signed-off-by: Prerna Saxena Signed-off-by: Stefan Hajnoczi --- ioport.c |7 +++ trace-events |4 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index 53dd87a..ec3dc65 100644 --- a/ioport.c +++ b/ioport.c @@ -26,6 +2

[Qemu-devel] [PATCH 12/14] trace: Trace virtqueue operations

2010-09-06 Thread Stefan Hajnoczi
This patch adds trace events for virtqueue operations including adding/removing buffers, notifying the guest, and receiving a notify from the guest. Signed-off-by: Stefan Hajnoczi --- hw/virtio.c |8 trace-events |8 2 files changed, 16 insertions(+), 0 deletions(-) d

[Qemu-devel] [PATCH 09/14] trace: Add user documentation

2010-09-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt | 177 ++ 1 files changed, 177 insertions(+), 0 deletions(-) create mode 100644 docs/tracing.txt diff --git a/docs/tracing.txt b/docs/tracing.txt new file mode 100644 index 000..ae01ff1

[Qemu-devel] [PATCH 06/14] trace: Add trace-file command to open/close/flush trace file

2010-09-06 Thread Stefan Hajnoczi
This patch adds the trace-file command: trace-file [on|off|flush] Open, close, or flush the trace file. If no argument is given, the status of the trace file is displayed. The trace file is turned on by default but is only written out when the trace buffer becomes full. The flush operati

[Qemu-devel] [PATCH 11/14] trace: Trace virtio-blk, multiwrite, and paio_submit

2010-09-06 Thread Stefan Hajnoczi
This patch adds trace events that make it possible to observe virtio-blk. Signed-off-by: Stefan Hajnoczi --- block.c|8 hw/virtio-blk.c|7 +++ posix-aio-compat.c |2 ++ trace-events | 14 ++ 4 files changed, 31 insertions(+), 0 deletio

[Qemu-devel] [PATCH v3 00/14] trace: Add static tracing to QEMU

2010-09-06 Thread Stefan Hajnoczi
This patch series adds static tracing to QEMU. It can be used to instrument QEMU code by means of lightweight logging called trace events. Prerna and I are now posting the entire patch series with a serious eye towards checking we meet users' and developers' tracing needs and with the goal of get

[Qemu-devel] [PATCH 07/14] trace: Add trace file name command-line option

2010-09-06 Thread Stefan Hajnoczi
From: Prerna Saxena This patch adds an optional command line switch '-trace' to specify the filename to write traces to, when qemu starts. Eg, If compiled with the 'simple' trace backend, [t...@system]$ qemu -trace FILENAME IMAGE Allows the binary traces to be written to FILENAME instead of the o

[Qemu-devel] [PATCH 04/14] trace: Support disabled events in trace-events

2010-09-06 Thread Stefan Hajnoczi
Sometimes it is useful to disable a trace event. Removing the event from trace-events is not enough since source code will call the trace_*() function for the event. This patch makes it easy to build without specific trace events by marking them disabled in trace-events: disable multiwrite_cb(vo

[Qemu-devel] [PATCH 01/14] trace: Add trace-events file for declaring trace events

2010-09-06 Thread Stefan Hajnoczi
This patch introduces the trace-events file where trace events can be declared like so: qemu_malloc(size_t size) "size %zu" qemu_free(void *ptr) "ptr %p" These trace event declarations are processed by a new tool called tracetool to generate code for the trace events. Trace event declarations ar

[Qemu-devel] [PATCH 02/14] trace: Add simple built-in tracing backend

2010-09-06 Thread Stefan Hajnoczi
This patch adds a simple tracer which produces binary trace files. To try out the simple backend: $ ./configure --trace-backend=simple $ make After running QEMU you can pretty-print the trace: $ ./simpletrace.py trace-events trace.log The output of simpletrace.py looks like this: qemu_reall

Re: [Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices

2010-09-06 Thread Alexander Graf
On 06.09.2010, at 17:06, Bernhard Kohl wrote: > From: Bernhard Kohl > > Allow symbolic links which point to /dev/sgX devices. Couldn't you send an SG_IO test ioctl over and see if it works? I really dislike the whole file name magic matching. Alex

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Anthony Liguori
On 09/06/2010 09:24 AM, Alexander Graf wrote: Oh - I missed the static there. Yeah, it's even worse. This is racy. It's easy to refactor away so I'll just do that but it's not actually racy. It's just not re-entrant and the lifetime of the returned result is only until the next call. R

Re: [Qemu-devel] Guest cannot handle a PCI BAR > 1GB

2010-09-06 Thread Cam Macdonell
On Sun, Sep 5, 2010 at 10:50 AM, Avi Kivity wrote: > On 09/04/2010 01:22 AM, Cam Macdonell wrote: > >> Hi, >> >> I'm trying to test 2 GB (and eventually larger) BARs with ivshmem and >> I get an error in the guest that it is able to find a mem resource for >> a BAR larger than 1GB. I'm using 64

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Anthony Liguori
On 09/06/2010 08:35 AM, Daniel P. Berrange wrote: On Mon, Sep 06, 2010 at 07:52:41AM -0500, Anthony Liguori wrote: On 09/06/2010 06:18 AM, Daniel P. Berrange wrote: I agree with ditching compression, but encryption is an important capability which cannot be satisfactorily added at oth

Re: [Qemu-devel] Re: [RFC] qed: Add QEMU Enhanced Disk format

2010-09-06 Thread Anthony Liguori
On 09/06/2010 09:10 AM, Kevin Wolf wrote: If you implement a subset of functionality for an existing on-disk format, I think you damage user's expectations. I don't really buy that implementing compression/encryption wouldn't have been possible if it was the only problem. Of course, if y

Re: [Qemu-devel] [PATCH v3 00/14] trace: Add static tracing to QEMU

2010-09-06 Thread Daniel P. Berrange
On Mon, Sep 06, 2010 at 04:13:57PM +0100, Stefan Hajnoczi wrote: > This patch series adds static tracing to QEMU. It can be used to instrument > QEMU code by means of lightweight logging called trace events. > > Prerna and I are now posting the entire patch series with a serious eye > towards >

[Qemu-devel] Re: [PATCH 00/14] pcie port switch emulators

2010-09-06 Thread Wei Xu
Isaku, Thanks! Last week I did some merging to qemu-kvm and found similar issues (qdev reset) and also ioapic/apic needs many changes. I may ask your help this week... Wei On 9/6/10 12:46 AM, "Isaku Yamahata" wrote: > This patch series implements pcie port switch emulators > which is basic pa

Re: [Qemu-devel] [PATCH v3 00/14] trace: Add static tracing to QEMU

2010-09-06 Thread Anthony Liguori
On 09/06/2010 11:51 AM, Daniel P. Berrange wrote: On Mon, Sep 06, 2010 at 04:13:57PM +0100, Stefan Hajnoczi wrote: This patch series adds static tracing to QEMU. It can be used to instrument QEMU code by means of lightweight logging called trace events. Prerna and I are now posting the ent

Re: [Qemu-devel] Guest cannot handle a PCI BAR > 1GB

2010-09-06 Thread Cam Macdonell
On Mon, Sep 6, 2010 at 10:37 AM, Cam Macdonell wrote: > > > On Sun, Sep 5, 2010 at 10:50 AM, Avi Kivity wrote: >> >>  On 09/04/2010 01:22 AM, Cam Macdonell wrote: >>> >>> Hi, >>> >>> I'm trying to test 2 GB (and eventually larger) BARs with ivshmem and >>> I get an error in the guest that it is a

Re: [Qemu-devel] Re: [PATCH 01/14] RESEND apb: fix typo.

2010-09-06 Thread Blue Swirl
On Mon, Sep 6, 2010 at 9:46 AM, Michael S. Tsirkin wrote: > On Mon, Sep 06, 2010 at 04:46:15PM +0900, Isaku Yamahata wrote: >> fix typo. >> >> Signed-off-by: Isaku Yamahata > > This is separate from the express patches, right? > I'll appply this. Thanks! Since the patch that introduces the build

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-06 Thread Blue Swirl
On Sun, Sep 5, 2010 at 10:33 PM, andrzej zaborowski wrote: > On 5 September 2010 23:44, Blue Swirl wrote: >> The problem case is when BLKDBG_EVENT_MAX > 0x8000 and the type of >> enum is unsigned. Then the first check is ignored by the compiler and >> the second does not catch values which ar

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-06 Thread Blue Swirl
On Mon, Sep 6, 2010 at 1:04 PM, Kevin Wolf wrote: > Am 04.09.2010 23:07, schrieb Blue Swirl: >> On Sat, Sep 4, 2010 at 8:30 PM, andrzej zaborowski wrote: >>> Hi, >>> >>> On 4 September 2010 21:45, Blue Swirl wrote: On Sat, Sep 4, 2010 at 5:57 PM, andrzej zaborowski wrote: >>  -  

Re: [Qemu-devel] Re: [PATCH 01/14] RESEND apb: fix typo.

2010-09-06 Thread Michael S. Tsirkin
On Mon, Sep 06, 2010 at 05:54:25PM +, Blue Swirl wrote: > On Mon, Sep 6, 2010 at 9:46 AM, Michael S. Tsirkin wrote: > > On Mon, Sep 06, 2010 at 04:46:15PM +0900, Isaku Yamahata wrote: > >> fix typo. > >> > >> Signed-off-by: Isaku Yamahata > > > > This is separate from the express patches, rig

[Qemu-devel] KVM call agenda for September 7

2010-09-06 Thread Juan Quintela
Please send in any agenda items you are interested in covering. thanks, Juan.

[Qemu-devel] Re: Irregular response times

2010-09-06 Thread Pascal J. Bourguignon
p...@informatimago.com (Pascal J. Bourguignon) writes: > Mulyadi Santosa writes: > >> On Sun, Jul 4, 2010 at 06:42, Pascal J. Bourguignon >> wrote: >>> p...@informatimago.com (Pascal J. Bourguignon) writes: >>> I've got various Qemu running linux (gentoo or debian, all running the same

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-06 Thread Andreas Färber
Am 05.09.2010 um 17:57 schrieb Anthony Liguori: On 09/05/2010 10:10 AM, Avi Kivity wrote: As a baby step, is there any chance of publishing an automatic nightly Windows (cross-)build as a .zip file on qemu.org? That might give more users a chance of detecting runtime faults during the deve

Re: [Qemu-devel] Re: [PATCH 01/14] RESEND apb: fix typo.

2010-09-06 Thread Isaku Yamahata
On Mon, Sep 06, 2010 at 10:55:19PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 06, 2010 at 05:54:25PM +, Blue Swirl wrote: > > On Mon, Sep 6, 2010 at 9:46 AM, Michael S. Tsirkin wrote: > > > On Mon, Sep 06, 2010 at 04:46:15PM +0900, Isaku Yamahata wrote: > > >> fix typo. > > >> > > >> Signe

Re: [Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices

2010-09-06 Thread Christoph Hellwig
On Mon, Sep 06, 2010 at 05:39:00PM +0200, Alexander Graf wrote: > > On 06.09.2010, at 17:06, Bernhard Kohl wrote: > > > From: Bernhard Kohl > > > > Allow symbolic links which point to /dev/sgX devices. > > Couldn't you send an SG_IO test ioctl over and see if it works? I really > dislike the

[Qemu-devel] Fwd: Guest hangs when I do general operation.

2010-09-06 Thread Amos Kong
-- Forwarded message -- From: Amos Kong Date: Tue, Sep 7, 2010 at 7:49 AM Subject: Guest hangs when I do general operation. To: 王箫 kvm upstream: 43e413f7db1a4a90671dda0b1d6c1f8cb30673ed KVM: Whitespace changes to remove differences wrt kvm-updates/2.6.37 qemu upstream: cb93bbdd7

[Qemu-devel] Re: KVM call agenda for September 7

2010-09-06 Thread Avi Kivity
On 09/06/2010 11:00 PM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. 0.13? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.