On Sat, Aug 14, 2010 at 2:27 PM, Andreas Färber wrote:
> Am 13.08.2010 um 18:56 schrieb Blue Swirl:
>
+Use parenthesis when checking if a macro is defined, and use
+indentation to track nesting:
+
+#if defined(HAVE_POSIX_FALLOCATE) && !defined(HAVE_FALLOCATE)
+# define fal
Am 15.08.2010 um 09:46 schrieb Blue Swirl:
On Sat, Aug 14, 2010 at 2:27 PM, Andreas Färber > wrote:
While indentation is nice to read, it is patch-unfriendly.
Consider:
#ifdef SOMETHINGNEW
yay
#else // previous stuff follows
#if defined(OLDONE)
# define one
#endif
foo
bar
#if defined(OLDTWO)
Greetings Hannes, hch and Co,
The lastest code from upstream qemu-kvm.git v0.12.5 has been merged into
the megasas HBA emulation friendly qemu-kvm.git/master and scsi-bsg
branches at:
http://git.kernel.org/?p=virt/kvm/nab/qemu-kvm.git;a=summary
The merge commitdiffs for master and scsi-bsg can b
Thanks, applied.
On Sat, Aug 14, 2010 at 11:47 PM, Cam Macdonell wrote:
> Signed-off-by: Cam Macdonell
> ---
> kvm-stub.c | 5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/kvm-stub.c b/kvm-stub.c
> index 3378bd3..d45f9fa 100644
> --- a/kvm-stub.c
> +++ b/kvm-stub
Thanks, applied.
On Sat, Aug 14, 2010 at 11:47 PM, Cam Macdonell wrote:
> Signed-off-by: Cam Macdonell
> ---
> Makefile.target | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index b791492..c8281e9 100644
> --- a/Makefile.target
Thanks, applied both.
On Wed, Aug 11, 2010 at 7:37 PM, Stefan Weil wrote:
> Am 11.08.2010 21:19, schrieb Blue Swirl:
>>
>> On Wed, Aug 11, 2010 at 6:51 PM, Blue Swirl wrote:
>>
>>>
>>> On Wed, Aug 11, 2010 at 6:18 PM, Stefan Weil
>>> wrote:
>>>
Am 11.08.2010 18:34, schrieb Blue Swirl:
On Fri, Aug 13, 2010 at 8:29 PM, Artyom Tarasenko
wrote:
> 2010/8/6 Artyom Tarasenko :
>> 2010/8/2 Artyom Tarasenko :
>>> Btw, it would be nice to get this patch applied for 0.13: it's a pure
>>> fix, and it allows running the OBP v2.10 for LX and some older OBP
>>> versions for SS-20 too.
>>
>> p
Correct the calculation of the offset in the msrpm
for the MSR range 0 - 0x1fff.
Signed-off-by: Adam Lackorzynski
---
target-i386/op_helper.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index c50e818..ec6b3e9 100644
According to scc_escc_um.pdf:
- Reset Highest IUS must update irq status to allow processing
of the next priority interrupt.
- rx interrupt has always higher priority than tx on same channel
The documentation only explicitly says that Reset Highest IUS
command (0x38) clears IUS bits, not that
On 08/13/2010 02:53 PM, Anthony Liguori wrote:
On 08/12/2010 09:09 AM, stefano.stabell...@eu.citrix.com wrote:
From: Anthony PERARD
Introduce functions to read and write the state of the VM in xenstore.
This basically creates a new management interface for QEMU via the
xenstore.
Our manageme
On 08/12/2010 02:56 PM, malc wrote:
On Thu, 12 Aug 2010, Blue Swirl wrote:
Add a few rules, based loosely on libvirt HACKING.
Blue Swirl (5):
CODING_STYLE: add preprocessor rules
CODING_STYLE: add C type rules
CODING_STYLE: add memory management rules
CODING_STYLE: add string manag
On 08/14/2010 10:52 AM, Andreas Färber wrote:
Well, this is not coding style but architectural guide. We could
introduce a new document, rename CODING_STYLE or bury this to
qemu-tech.texi. But I still (optimistically) think that some kind of
READ_ME_BEFORE_CODING would help.
I agree that we sh
On 08/11/2010 04:49 AM, Hao, Xudong wrote:
Hi,
Recently I build qemu-kvm on 32bit RHEL5u4/RHEL5u5, it will fail on fuction
"vhost_dev_sync_region". But RHEL5u1 system is fine to build.
Did anyone meet similar issue?
qemu-kvm commit: 59d71ddb432db04b57ee2658ce50a3e35d7db97e
build error:
...
On 08/14/2010 12:01 AM, malc wrote:
This is all perfectly reasonable, but begs one question, where do we stop
codifying self-evident truths (or who is the ultimiate judge of what is
self-evident and what isn't), since taking the above to extreme we will
end up adding stuff like: you must use cl
Hi,
This patch adds a usb CCID device, a common standard for smart cards that is
supported by linux and windows (and probably others that I didn't test).
It is intended to be used by SPICE and RHEV-M, but of course it is valuable
independently from those. Uses include usage of client smartcard
pci_bios_alloc() can be used to allocate space in the PCI region for
other purposes. This is needed by the AMD IOMMU support code.
Signed-off-by: Eduard - Gabriel Munteanu
---
src/pciinit.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/src/pciinit.c b/
This initializes the AMD IOMMU and creates ACPI tables for it.
Signed-off-by: Eduard - Gabriel Munteanu
---
Makefile |2 +-
src/acpi.c | 79
src/iommu.c| 64 +
src/iommu.h
PCI devices should access memory through pci_memory_*() instead of
cpu_physical_memory_*(). This also provides support for translation and
access checking in case an IOMMU is emulated.
Memory maps are treated as remote IOTLBs (that is, translation caches
belonging to the IOMMU-aware device itself)
This allows the device to work properly with an emulated IOMMU.
Signed-off-by: Eduard - Gabriel Munteanu
---
hw/ac97.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/ac97.c b/hw/ac97.c
index 4319bc8..9ee4894 100644
--- a/hw/ac97.c
+++ b/hw/ac97.c
@@ -223,7 +223,
This allows the device to work properly with an emulated IOMMU.
Signed-off-by: Eduard - Gabriel Munteanu
---
hw/rtl8139.c | 99 -
1 files changed, 56 insertions(+), 43 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index 72e2242..
This helper function allows map invalidation code to determine which
maps must be invalidated.
Signed-off-by: Eduard - Gabriel Munteanu
---
hw/pci.h | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/hw/pci.h b/hw/pci.h
index 4bd8a1a..5a6cdb5 100644
--- a/hw/pci.h
This allows the device to work properly with an emulated IOMMU.
Signed-off-by: Eduard - Gabriel Munteanu
---
hw/eepro100.c | 78 ++---
1 files changed, 41 insertions(+), 37 deletions(-)
diff --git a/hw/eepro100.c b/hw/eepro100.c
index 97afa2
Hi,
Please have a look at these and merge if you wish. I hope I've addressed the
issues people have raised.
Some changes from the previous RFC:
- included and updated the other two device patches
- moved map registration and invalidation management into PCI code
- AMD IOMMU emulation is always en
This introduces emulation for the AMD IOMMU, described in "AMD I/O
Virtualization Technology (IOMMU) Specification".
Signed-off-by: Eduard - Gabriel Munteanu
---
Makefile.target |2 +
hw/amd_iommu.c | 688 +++
hw/pc.c |2 +
hw
Add memory management rules, somewhat like libvirt HACKING.
Signed-off-by: Blue Swirl
---
HACKING | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/HACKING b/HACKING
index 7c6b49e..e0342df 100644
--- a/HACKING
+++ b/HACKING
@@ -68,3 +68,14 @@ it points to, or it
Emulated PCI IDE controllers now use the memory access interface. This
also allows an emulated IOMMU to translate and check accesses.
Map invalidation results in cancelling DMA transfers. Since the guest OS
can't properly recover the DMA results in case the mapping is changed,
this is a fairly goo
Create a new file HACKING and add a few rules.
Blue Swirl (5):
HACKING: add preprocessor rules
HACKING: add C type rules
HACKING: add memory management rules
HACKING: add string management rules
HACKING: add rules for printf-like functions
CODING_STYLE |3 -
HACKING | 118 +++
Add a new file, HACKING, in order to collect recurring
issues with submitted patches.
Start with preprocessor rules, adapted from libvirt HACKING.
Signed-off-by: Blue Swirl
---
HACKING |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
create mode 100644 HACKING
diff --git a/HACK
On 15/08/10 00:44, Cam Macdonell wrote:
Yup, it was my patch. Sorry about that. Patches are in the list,
just need to be merged.
It works now - thanks!
Cam
-Nigel
On Sun, 15 Aug 2010, Eduard - Gabriel Munteanu wrote:
> This allows the device to work properly with an emulated IOMMU.
Fine with me.
[..snip..]
--
mailto:av1...@comtv.ru
Add rules for printf-like functions, based on libvirt HACKING.
Signed-off-by: Blue Swirl
---
HACKING | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/HACKING b/HACKING
index 54bd2fd..8e2a298 100644
--- a/HACKING
+++ b/HACKING
@@ -103,3 +103,16 @@ so instead o
Add string management rules, somewhat like libvirt HACKING.
Signed-off-by: Blue Swirl
---
HACKING | 24
1 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/HACKING b/HACKING
index e0342df..54bd2fd 100644
--- a/HACKING
+++ b/HACKING
@@ -79,3 +79,27 @@ qemu_v
Add C type rules, adapted from libvirt HACKING. Also include
a description of special QEMU scalar types.
Move typedef rule from CODING_STYLE rule 3 to HACKING rule 6
where it belongs.
Signed-off-by: Blue Swirl
---
CODING_STYLE |3 --
HACKING | 64 +
Blue Swirl writes:
> +For variadic macros, stick with C99 syntax:
> +
> +#define DPRINTF(fmt, ...) \
> +do { printf("IRQ: " fmt, ## __VA_ARGS__); } while (0)
That's not C99 syntax, the combination with ## is a gcc extension. In
C99 you cannot have an em
Hi Blue,
Thanks for putting this document together. It should be quiet helpful!
On 08/15/2010 12:50 PM, Blue Swirl wrote:
Add C type rules, adapted from libvirt HACKING. Also include
a description of special QEMU scalar types.
Move typedef rule from CODING_STYLE rule 3 to HACKING rule 6
where
Isn't it the case that's fixed by commit
d9812b033a17c82f9e933757c1c3ef364e3ba62d as shown in
http://comments.gmane.org/gmane.comp.emulators.qemu/72593 which is
actually this very bugreport mirrored to qemu-devel mailinglist?
--
sound broken in qemu 0.12.x
https://bugs.launchpad.net/bugs/510612
Y
On 08/11/2010 11:34 AM, Blue Swirl wrote:
On Wed, Aug 11, 2010 at 10:58 AM, Stefan Weil wrote:
Hi,
since several months, QEMU for Windows (and mingw32 cross builds)
no longer builds without error.
Not true for mingw32, it was building fine here until the latest commit.
I suspe
Avi Kivity wrote:
> On 08/11/2010 04:49 AM, Hao, Xudong wrote:
>> Hi,
>> Recently I build qemu-kvm on 32bit RHEL5u4/RHEL5u5, it will fail on
>> fuction "vhost_dev_sync_region". But RHEL5u1 system is fine to
>> build. Did anyone meet similar issue?
>>
>> qemu-kvm commit: 59d71ddb432db04b57ee2658
On 08/15/2010 02:27 PM, Eduard - Gabriel Munteanu wrote:
Hi,
Please have a look at these and merge if you wish. I hope I've addressed the
issues people have raised.
It's looking pretty good so far. I'm very happy with the modifications
to the PCI layer.
It looks like given the helpers
39 matches
Mail list logo
