Current QMP's argument checker is more complex than it should be
and has (at least) one serious bug: it ignores unknown arguments.
To solve both problems we introduce a new argument checker. It's
added on top of the existing one, so that there are no regressions
during the transition.
This commit
Historically, user monitor arguments beginning with '-' (eg. '-f')
were passed as integers down to handlers.
I've maintained this behavior in the new monitor because we didn't
have a boolean type at the very beginning of QMP. Today we have it
and this behavior is causing trouble to QMP's argument
Signed-off-by: Luiz Capitulino
---
qdict.c | 18 ++
qdict.h |1 +
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/qdict.c b/qdict.c
index a28a0a9..dee0fb4 100644
--- a/qdict.c
+++ b/qdict.c
@@ -308,6 +308,24 @@ int64_t qdict_get_try_int(const QDict *qdict, co
Previous commit added qmp_check_input_obj(), it does all the
checking we need.
Signed-off-by: Luiz Capitulino
---
monitor.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index a24a152..c558cc7 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4239,9
Just a note that the 0.8.1 release available in maverick gives me about
a 50-second save for a 512M memory image (producing 100M outfile). The
patch listed above and suspected of speeding the saves is not in 0.8.1.
When I hand-apply just that patch, saves take about 8 seconds, but
restore fails.
Public bug reported:
== overview ==
When booting guests in snapshot mode qemu never calls unlink()
on the files storing changes to the images. This results in large amounts of
disk space being used over time.
This bug seems to have been introduced by qemu git commit
b6ce07aa83bdee3cfd2610f270a0c
2010/6/22 陈宇飞 :
>
> On 2010-6-22, at 下午1:46, Artyom Tarasenko wrote:
>
>> 2010/4/28 陈宇飞 :
>>> I've tested the latest git HEAD version. But still has the problem.
>>>
>>> Investigating Linux kernel execution shows that the function which will
>>> clear the interrupt is not executed.
>>>
>>> Here's
On 06/01/2010 03:30 PM, Venkateswararao Jujjuri (JV) wrote:
This patch rearranges the fileop structures by moving the structure definitions
from virtio-9p.c to virtio-9p.h file. No functional changes.
Signed-off-by: Venkateswararao Jujjuri
---
Applied. Thanks.
Regards,
Anthony Liguori
On 06/01/2010 10:32 PM, Bernhard M. Wiedemann wrote:
The code comes from
http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02788.html
Without this patch it is not possible to send at least 10 special
characters (\|'"`~:;[]{}) via the monitor sendkey command.
Signed-off-by: Bernhard M. Wie
On 06/02/2010 10:24 AM, Venkateswararao Jujjuri (JV) wrote:
This patch fluesh the debug messages to the log file at the end of each
debug message.
Changes from V1:
Used fflush instead fseek for the flush.
Signed-off-by: Venkateswararao Jujjuri
Applied. Thanks.
Regards,
Anthony Liguori
On 06/09/2010 07:10 AM, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Applied 1&2 as we discussed. Thanks.
Regards,
Anthony Liguori
---
migration.c | 16 ++--
migration.h |2 +-
vl.c|7 ++-
3 files changed, 17 insertions(+), 8 deletions(-)
dif
On 06/02/2010 12:33 PM, Luiz Capitulino wrote:
From: Michael Tokarev
In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
(with fprintf) something like this:
warning: could not open /dev/net/tun: no virtual network emulation
this has 2 issues:
1) it is not a warning real
On 06/14/2010 03:34 PM, Venkateswararao Jujjuri (JV) wrote:
The new option is:
-fsdev fstype,id=myid,path=/share_path/,security_model=[mapped|passthrough]
-virtfs fstype,path=/share_path/,security_model=[mapped|passthrough],mnt_tag=tag
In the case of mapped security model, files are created wit
On 06/17/2010 10:15 AM, Alex Williamson wrote:
The comment suggests we're checking for the driver in the ready
state and bus master disabled, but the code is checking that it's
not in the ready state.
Signed-off-by: Alex Williamson
Found-by: Amit Shah
Applied. Thanks.
Regards,
Anthony L
From: Jan Kiszka
This fixes a regression of 0e26b7b892: Reset halted also on INIT.
Signed-off-by: Jan Kiszka
---
target-i386/helper.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 718394c..e134340 100644
--- a/target-
From: Jan Kiszka
Signed-off-by: Jan Kiszka
---
hw/pc.c | 22 --
1 files changed, 4 insertions(+), 18 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 1848151..8b9e70a 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -812,20 +812,12 @@ void pc_acpi_smi_interrupt(void *opaque, int ir
101 - 116 of 116 matches
Mail list logo