Set PCI multi-function bit appropriately.
PCI address, devfn ,is exported to users as addr property,
so users can populate pci function(PCIDevice in qemu)
at arbitrary devfn.
It means each function(PCIDevice) don't know whether pci device
(PCIDevice[8]) is multi function or not.
So this patch makes
Changes v2 -> v3:
Make this bug fix patch independent.
added test description.
patch description:
When pci devices are populated as multi-function,
OS can fail to probe function > 0. It's because multi function
bit of header type register in configuration space isn't set,
so OS probes only functi
replace PCIDeviceInfo::header_type with is_bridge
as suggested by Michael S. Tsirkin
Signed-off-by: Isaku Yamahata
---
hw/apb_pci.c |2 +-
hw/dec_pci.c |2 +-
hw/pci.c | 15 ---
hw/pci.h |8 ++--
4 files changed, 16 insertions(+), 11 deletions(-)
diff --gi
Don't overwrite pci header type.
Otherwise, multi function bit which pci_init_header_type() sets
appropriately is lost.
Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero
which is already zero cleared.
how to test:
run qemu and issue info pci to see whether a device in question is
Anthony Liguori writes:
> On 06/17/2010 03:20 AM, Kevin Wolf wrote:
>> Am 16.06.2010 20:07, schrieb Anthony Liguori:
>>
But it requires that
everything that -blockdev provides is accessible with -drive, too (or
that we're okay with users hating us).
>>> I'm
Stefan Hajnoczi writes:
> On Thu, Jun 17, 2010 at 1:49 PM, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>>> On Wed, Jun 16, 2010 at 6:27 PM, Markus Armbruster
>>> wrote:
blockdev_add
Add host block device.
Arguments:
- "id": the h
Hi,
For some reason, the display is extremely slow when using vnc and
fbdev at the same time.
Gotcha. Didn't notice, but it probably depends on the hardware. Very
likely the reason is that graphic cards usually are optimized for write
access and reads might be slow as hell. vnc must re
Hi,
Bus names are chosen by the system as follows:
* If the driver of the parent device model provides a name, use that.
* Else, if the parent device has id ID, use ID.NUM, where NUM is the bus
number, counting from zero in creation order.
* Else, use TYPE.NUM, where TYPE is derived from
On 06/17/2010 08:05 PM, Anthony Liguori wrote:
On 06/17/2010 05:09 AM, Paolo Bonzini wrote:
+ while (QTAILQ_EMPTY(&(queue->request_list))&&
+ (ret != ETIMEDOUT)) {
+ ret = qemu_cond_timedwait(&(queue->cond),
+ &(queue->lock), 10*10);
+ }
Using qemu_cond_timedwait is a hack for not properly
Am 17.06.2010 21:47, schrieb Stefan Hajnoczi:
> On Thu, Jun 17, 2010 at 3:39 PM, Kevin Wolf wrote:
>> Am 17.06.2010 16:19, schrieb Stefan Hajnoczi:
>>> On Thu, Jun 17, 2010 at 1:03 PM, Kevin Wolf wrote:
Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash.
>>>
>>> Any perfo
On Fri, Jun 18, 2010 at 09:54:24AM +0200, Kevin Wolf wrote:
> qcow2 files are expected to grow, so this probably doesn't help us. At
> best we could try to detect if the file grows and decide if to use
> sync_file_range or fdatasync.
No. sync_file_range is always unsafe for use with a real filesy
On Fri, Jun 18, 2010 at 8:27 AM, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>> On Thu, Jun 17, 2010 at 1:49 PM, Markus Armbruster wrote:
>>> Stefan Hajnoczi writes:
On Wed, Jun 16, 2010 at 6:27 PM, Markus Armbruster
wrote:
>>> To let users ask for this explicitely, we could
Kevin Wolf writes:
> Am 17.06.2010 15:01, schrieb Anthony Liguori:
>> On 06/17/2010 03:20 AM, Kevin Wolf wrote:
>>> Am 16.06.2010 20:07, schrieb Anthony Liguori:
>>>
>But it requires that
> everything that -blockdev provides is accessible with -drive, too (or
> that we're okay
Alex Williamson wrote:
> On Wed, 2010-06-16 at 10:23 +0200, Markus Armbruster wrote:
>> Alex Williamson writes:
>>
>>> On Tue, 2010-06-15 at 12:28 +0100, Paul Brook wrote:
>> Alex proposed to disambiguate by adding "identified properties of the
>> immediate parent bus and device" to the pa
Stefan Hajnoczi writes:
> On Fri, Jun 18, 2010 at 8:27 AM, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>> On Thu, Jun 17, 2010 at 1:49 PM, Markus Armbruster
>>> wrote:
Stefan Hajnoczi writes:
> On Wed, Jun 16, 2010 at 6:27 PM, Markus Armbruster
> wrote:
To let us
Am 18.06.2010 10:20, schrieb Markus Armbruster:
> -blockdev should be optimized for config files, not single
> argument input. IOW:
>
> [blockdev "blk2"]
>format = "raw"
>file = "/path/to/base.img"
>cache = "writeback"
>
> [blockdev "blk1"]
>
Am 17.06.2010 21:05, schrieb Christian Brunner:
> Hi Simone,
>
> sorry for the late reply. I've been on vacation for a week.
>
> Thanks for sending the patch. At first sight your patch looks good.
> I'll do some testing by the weekend.
>
> Kevin also sent me a note about the missing aio support,
From: Volker Ruppert
---
ChangeLog | 35 +++
README|6 ++
2 files changed, 41 insertions(+), 0 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 75be5bd..35bf00a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,38 @@
+2009-01-25 16:46 vruppert
From: Volker Ruppert
---
clext.c | 51 ++-
vbe.c | 59 ---
vgabios.c | 58 ++
3 files changed, 92 insertions(+), 76 deletion
From: Volker Ruppert
---
vgabios.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/vgabios.c b/vgabios.c
index fbc3588..ea3aae8 100644
--- a/vgabios.c
+++ b/vgabios.c
@@ -2039,7 +2039,9 @@ Bit8u car;Bit8u page;Bit8u attr;Bit8u flag;
{
if(vga_modes[line].class
From: Volker Ruppert
---
vbe.c | 31 ++--
vbe.h | 70 --
vbetables-gen.c | 43 +
3 files changed, 91 insertions(+), 53 deletions(-)
diff --git a/vbe.c b/vbe.c
index
From: Volker Ruppert
---
ChangeLog | 12
README|3 ++-
2 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 35bf00a..dbaed5d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2009-04-07 20:18 vruppert
+
+ * vgabios.c (1.
Hi,
This patch series updates the vgabios git tree at
git://git.qemu.org/vgabios.git to vgabios v0.6c.
Patches are creates using 'git cvsimport' with some cleanups afterwards:
drop binary updates, drop cvs $Id$ changes from commits. Replace
'vruppert' with Volkers real name.
Note that vgabios
Public bug reported:
All variants of the ADDSUBX/SUBADDX instructions seem to be implemented
incorrectly, i.e.
MOV r12, #0
LDR r0, =0x18004800
LDR r1, =0x30006000
QADDSUBX r12, r0, r1; Should give 0x78001800 - gives 0x4800e800
This happens with latest git HEAD.
** Affects: q
On 06/18/2010 08:32 AM, Gerd Hoffmann wrote:
>Hi,
>
>> For some reason, the display is extremely slow when using vnc and
>> fbdev at the same time.
>
> Gotcha. Didn't notice, but it probably depends on the hardware. Very
> likely the reason is that graphic cards usually are optimized for w
Hi Stefan, Jan,
Thanks for taking a look.
On 06/17/2010 08:38 PM, Stefan Hajnoczi wrote:
On Wed, Jun 16, 2010 at 06:12:06PM +0530, Prerna Saxena wrote:
diff --git a/simpletrace.c b/simpletrace.c
index 2fec4d3..239ae3f 100644
--- a/simpletrace.c
+++ b/simpletrace.c
@@ -62,3 +62,16 @@ void trace4
Hi,
I would like to remind people about the Virtualization track at Linux
Plumbers Conference 2010, held in Cambridge, MA, November 3-5, 2010.
Please note the deadline for submissions is July 19, 2010.
LPC is particular well suited for technical presentations, work in
progress and subjects that
On 06/17/2010 09:33 PM, Stefan Hajnoczi wrote:
On Wed, Jun 16, 2010 at 06:14:35PM +0530, Prerna Saxena wrote:
This patch adds support for dynamically enabling/disabling of tracepoints.
This is done by internally maintaining each tracepoint's state, and
permitting logging of data from a tracepoin
On Fri, Jun 18, 2010 at 12:58 PM, Prerna Saxena
wrote:
> Hi Stefan, Jan,
> Thanks for taking a look.
>
> On 06/17/2010 08:38 PM, Stefan Hajnoczi wrote:
>>
>> On Wed, Jun 16, 2010 at 06:12:06PM +0530, Prerna Saxena wrote:
>>>
>>> diff --git a/simpletrace.c b/simpletrace.c
>>> index 2fec4d3..239ae3f
On Fri, Jun 18, 2010 at 1:24 PM, Prerna Saxena
wrote:
> On 06/17/2010 09:33 PM, Stefan Hajnoczi wrote:
>>> +}
>>> +
>>> +static Tracepoint* find_tracepoint_by_name(const char *tname)
>>> +{
>>> + unsigned int i, name_hash;
>>> +
>>> + if (!tname) {
>>> + return NULL;
>>> + }
>>> +
On Fri, Jun 18, 2010 at 11:40:57AM +0900, Isaku Yamahata wrote:
> On Thu, Jun 17, 2010 at 12:37:21PM +0300, Michael S. Tsirkin wrote:
> > On Thu, Jun 17, 2010 at 03:15:51PM +0900, Isaku Yamahata wrote:
> > > set PCI multi-function bit appropriately.
> > >
> > > Signed-off-by: Isaku Yamahata
> > >
On Fri, Jun 18, 2010 at 12:26:10PM +0900, Isaku Yamahata wrote:
> On Thu, Jun 17, 2010 at 02:57:16PM +0300, Michael S. Tsirkin wrote:
> > On Thu, Jun 17, 2010 at 01:02:43PM +0300, Michael S. Tsirkin wrote:
> > > For example, forcing all devices to call pci_reset_default
> > > in their reset routine
The code is pretty confused about format vs. protocol, and so are we.
Let's try to figure them out.
>From cruising altitude, all this format, protocol, stacking business
doesn't matter. We provide a bunch of arguments, and get an image.
If you look more closely, providing that image involves sub
On Fri, 18 Jun 2010 14:00:36 +0200
Jes Sorensen wrote:
> - QMP and Spice
I think we're going to discuss most QMP related subjects in the KVM forum,
but I'm open to suggestions.
On Fri, Jun 18, 2010 at 03:44:04PM +0300, Michael S. Tsirkin wrote:
> > > If I understand correctly what this does, it goes over
> > > other functions of the same device, and sets the MULTI_FUNCTION bit
> > > for them if there's more than one function.
> > > Instead, why don't we just set PCI_HEADE
Alex Williamson writes:
> On Wed, 2010-06-16 at 10:23 +0200, Markus Armbruster wrote:
>> Alex Williamson writes:
>>
>> > On Tue, 2010-06-15 at 12:28 +0100, Paul Brook wrote:
>> >> > > Alex proposed to disambiguate by adding "identified properties of the
>> >> > > immediate parent bus and device
Markus Armbruster wrote:
> Alex Williamson writes:
>
>> On Wed, 2010-06-16 at 10:23 +0200, Markus Armbruster wrote:
>>> Alex Williamson writes:
>>>
On Tue, 2010-06-15 at 12:28 +0100, Paul Brook wrote:
>>> Alex proposed to disambiguate by adding "identified properties of the
>>> imme
Markus Armbruster writes:
> A number of changes to qdev paths have been proposed in various threads.
> It's becoming harder to keep track of them, so let me sum them up in one
> place. Please correct me if I misrepresent your ideas.
>
> I'm going to describe the current state of things, and the
On Fri, 2010-06-18 at 11:16 +0200, Jan Kiszka wrote:
> Alex Williamson wrote:
> > On Wed, 2010-06-16 at 10:23 +0200, Markus Armbruster wrote:
> >> Alex Williamson writes:
> >>
> >>> On Tue, 2010-06-15 at 12:28 +0100, Paul Brook wrote:
> >> Alex proposed to disambiguate by adding "identified pr
This addresses the data integrity problems which are described for qcow at
http://wiki.qemu.org/Features/Qcow2DataIntegrity#Metadata_update_ordering.2C_Part_2
These problems are the same for all writable image formats, so this series
contains a patch for each of them.
The only exception is VDI whi
Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash.
Signed-off-by: Kevin Wolf
---
block/qcow.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 449858f..816103d 100644
--- a/block/qcow.c
+++ b/block/q
Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash.
While at it, correct the wrong usage of errno.
Signed-off-by: Kevin Wolf
---
block/cow.c | 20 +++-
1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/block/cow.c b/block/cow.c
index d146434..e
Add new functions that write and flush the written data to disk immediately.
This is what needs to be used for image format metadata to maintain integrity
for cache=... modes that don't use O_DSYNC. (Actually, we only need barriers,
and therefore the functions are defined as such, but flushes is wh
Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash.
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index e659908..2d4ba42 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@
Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 24
block/qcow2-refcount.c | 24
block/qcow2-snapshot.c | 23 +++
block/qcow2.c |
Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash.
Signed-off-by: Kevin Wolf
---
block/vpc.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index f1f73e2..e50509e 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -261,7
On Fri, Jun 18, 2010 at 10:38:20PM +0900, Isaku Yamahata wrote:
> On Fri, Jun 18, 2010 at 03:44:04PM +0300, Michael S. Tsirkin wrote:
> > > > If I understand correctly what this does, it goes over
> > > > other functions of the same device, and sets the MULTI_FUNCTION bit
> > > > for them if there'
On Fri, 2010-06-18 at 16:03 +0200, Markus Armbruster wrote:
> Alex Williamson writes:
> > On Wed, 2010-06-16 at 10:23 +0200, Markus Armbruster wrote:
> >> Alex Williamson writes:
> >> >
> >> > (A): /i440FX-pcihost/pci.0/e1000.05.0
> >> >
> >> > vs
> >> >
> >> > (B): /pci.0/05.0
> >> >
> >> > (rem
Isaku Yamahata wrote:
> On Fri, Jun 18, 2010 at 03:44:04PM +0300, Michael S. Tsirkin wrote:
> > If we really want the ability to put unrelated devices
> > as functions in a single one, let's just add
> > a 'multifunction' qdev property, and validate that
> > it is set appropriately.
>
> I think "u
Alex Williamson wrote:
> On Fri, 2010-06-18 at 11:16 +0200, Jan Kiszka wrote:
>> Alex Williamson wrote:
>>> On Wed, 2010-06-16 at 10:23 +0200, Markus Armbruster wrote:
Alex Williamson writes:
> On Tue, 2010-06-15 at 12:28 +0100, Paul Brook wrote:
Alex proposed to disambiguat
I have been able to reproduce this issue using the attached C file on a
custom arm1136-based qemu device, with latest git HEAD as of about 15
minutes ago. Running my test program on real hardware -- an
arm1176-based board, and a cortex-a8-based board -- produces the desired
result (0x78001800).
I'
Am 15.06.2010 19:53, schrieb MORITA Kazutaka:
> Some block drivers use an aio handler and do I/O completion routines
> in it. However, the handler is not invoked if we only do
> aio_read/write, because registered fds are not checked at all.
>
> This patch registers a command processing function a
scanf calls must not use PRI constants, they have probably the wrong size and
corrupt memory. We could replace them by SCN ones, but strtol is simpler than
scanf here anyway. While at it, also fix the parsers to reject garbage after
the number ("4096xyz" was accepted before).
Signed-off-by: Kevin
These commands show the information about active backend network devices.
Signed-off-by: Miguel Di Ciurcio Filho
---
qemu-monitor.hx | 105 +++
1 files changed, 105 insertions(+), 0 deletions(-)
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
Hi,
looks like SMP in emulation mode is broken once --enable-io-thread is
turned on. Linux SMP guests lock up early during boot, often the whole
QEMU process becomes uncontrollable after a while. That's at least the
case here with x86 targets. The problem disappears when using
-enable-kvm or build
> $ qemu-system-arm -semihosting -cpu cortex-a9 -nographic -kernel
> ./input.exe
-nographic implies -monitor stdio -serial stdio. Don't do that if you want to
access stdio via semihosting.
Paul
The addsub/subadd implemetation is incorrect. The patch can fixed it
and is verified by Chris's test case
** Patch added: "target-arm: fix addsub/subadd implementation"
http://launchpadlibrarian.net/50552359/0001-target-arm-fix-addsub-subadd-implementation.patch
--
[ARM] All variants of AD
I tested Chih-Min's patch with my local git clone, and I can verify that
it appears to fix the issue.
--
[ARM] All variants of ADDSUBX,SUBADDX give incorrect results
https://bugs.launchpad.net/bugs/595906
You received this bug notification because you are a member of qemu-
devel-ml, which is subs
Create a new attribute for virtio-blk devices that will fetch the serial number
of the block device. This attribute can be used by udev to create disk/by-id
symlinks for devices that don't have a UUID (filesystem) associated with them.
ATA_IDENTIFY strings are special in that they can be up to 20
With the availablility of a sysfs device attribute for examining disk serial
numbers the ioctl is no longer needed. The user-space changes for this aren't
upstream yet so we don't have any users to worry about.
Signed-off-by: Ryan Harper
---
drivers/block/virtio_blk.c | 10 --
1 files
Hi All,
I am a newbie to QEMU. Could anybody tell me how to run an emulation with
255 CPUs? I am talking about the PC target with linux. Any advise will be
greatly appreciated.
Thanks!
-Sheng Li
On Thu, Jun 17, 2010 at 03:18:12PM +0800, Sheng Yang wrote:
> Notice the first three patches applied to uq/master branch of qemu-kvm, the
> last one
> applied to qemu-kvm master branch. And the last one would only apply after the
> first three merged in master branch.
Applied, thanks.
On 06/18/2010 11:37 AM, Jan Kiszka wrote:
Hi,
looks like SMP in emulation mode is broken once --enable-io-thread is
turned on. Linux SMP guests lock up early during boot, often the whole
QEMU process becomes uncontrollable after a while. That's at least the
case here with x86 targets. The proble
On Fri, 18 Jun 2010 15:28:42 -0500
Anthony Liguori wrote:
> On 06/18/2010 11:26 AM, Miguel Di Ciurcio Filho wrote:
> > These commands show the information about active backend network devices.
> >
> > Signed-off-by: Miguel Di Ciurcio Filho
> > ---
> > qemu-monitor.hx | 105
> > +++
On Wed, 02 Jun 2010 09:31:24 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
[...]
> > static void check_mandatory_args(const char *cmd_arg_name,
> > @@ -4344,6 +4413,9 @@ out:
> > * Client argument checking rules:
> > *
> > * 1. Client must provide all mandatory arguments
> >
On 06/18/2010 11:26 AM, Miguel Di Ciurcio Filho wrote:
These commands show the information about active backend network devices.
Signed-off-by: Miguel Di Ciurcio Filho
---
qemu-monitor.hx | 105 +++
1 files changed, 105 insertions(+), 0 del
On Fri, Jun 18, 2010 at 5:28 PM, Anthony Liguori wrote:
> On 06/18/2010 11:26 AM, Miguel Di Ciurcio Filho wrote:
>>
>> These commands show the information about active backend network devices.
>>
>> Signed-off-by: Miguel Di Ciurcio Filho
>> ---
>> qemu-monitor.hx | 105
>> +++
On 06/18/2010 04:15 PM, Miguel Di Ciurcio Filho wrote:
On Fri, Jun 18, 2010 at 5:28 PM, Anthony Liguori wrote:
On 06/18/2010 11:26 AM, Miguel Di Ciurcio Filho wrote:
These commands show the information about active backend network devices.
Signed-off-by: Miguel Di Ciurcio Filho
---
Public bug reported:
i wish kvm can run 64bit guest os on 32bit host just like qemu does.
** Affects: qemu
Importance: Undecided
Status: New
** Tags: kvm
** Tags added: kvm
--
kvm to emulate 64 bit cpu on 32 bit host
https://bugs.launchpad.net/bugs/596106
You received this bug
KVM isn't an emulator. It virtualizes the CPU. A 32bit CPU can't be
forced to run as a 64bit cpu. This is a wontfix.
--
kvm to emulate 64 bit cpu on 32 bit host
https://bugs.launchpad.net/bugs/596106
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribe
Thanks for the request. It's certainly possible with most modern
distributions to just install a 64-bit kernel with a 32-bit userspace.
Technically speaking, 64-bit guests in a 32-bit kernel is prohibitively
difficult.
** Changed in: qemu
Status: New => Won't Fix
--
kvm to emulate 64 bit
71 matches
Mail list logo