[Qemu-devel] Underlätta ditt höstarbete

2010-06-15 Thread DokuMera Nyhetsbrev
Om du har problem med att läsa detta e-postmeddelande, klicka här (http://www.anp.se/newsletterweb/742046/444059437941455D4B7142445C43) för en webb-version. Vårt nyhetsbrev skickas automatiskt till våra kunder och intressenter. Vill du inte ha detta nyhetsbrev framöver, klicka här för att avpre

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-15 Thread Avi Kivity
On 06/14/2010 10:33 PM, Anthony Liguori wrote: On 06/14/2010 02:27 PM, Glauber Costa wrote: This patch fixes a bug that happens with kvm, irqchip-in-kernel, while adding a netdev. Despite the situations of reproduction being specific to kvm, I believe this fix is pretty generic, and fits here. S

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-15 Thread Avi Kivity
On 06/14/2010 10:42 PM, Glauber Costa wrote: I do agree that this is most likely a kernel bug. But as with any other kernel bugs, I believe this is a easy workaround to have things working even in older kernels until we fix it. That's what -stable is for. We fix it upstream and backport it

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-15 Thread Avi Kivity
On 06/15/2010 09:14 AM, Daniel P. Berrange wrote: Hmm, could this problem be hitting other places where we fork() besides the netdev helper script ? I have seen a intermittent bug[1] with migration, where using exec: migration will freeze the entire guest and setting -no-kvm-irqchip fixes the pr

[Qemu-devel] Re: [PATCH] block: fix a warning and possible truncation

2010-06-15 Thread Kevin Wolf
Am 14.06.2010 20:55, schrieb Blue Swirl: > Fix a warning from OpenBSD gcc (3.3.5 (propolice)): > /src/qemu/block.c: In function `bdrv_info_stats_bs': > /src/qemu/block.c:1548: warning: long long int format, long unsigned > int arg (arg 6) > > There may be also truncation effects. > > Signed-off-b

[Qemu-devel] [PATCH] net: Fix VM start with '-net none'

2010-06-15 Thread Amit Shah
Commit 50e32ea8f31035877decc10f1075aa0e619e09cb changed the behaviour for the return type of net_client_init() when a nic type with no init method was specified. 'none' is one such nic type. Instead of returning 0, which gets interpreted as an index into the nd_table[] array, we switched to returni

Re: [Qemu-devel] [PATCH v2] net: Fix hotplug with pci_add

2010-06-15 Thread Amit Shah
On (Wed) Jun 09 2010 [15:28:11], Amit Shah wrote: > > Let me rephrase: Behavior changes for -net types without an init() > > method. The only one without an init() method is "none". Before, > > net_client_init() succeeded for it. Now it fails. What's the impact of > > that change? And why does

Re: [Qemu-devel] Re: [PATCH] block: fix a warning and possible truncation

2010-06-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.06.2010 20:55, schrieb Blue Swirl: >> Fix a warning from OpenBSD gcc (3.3.5 (propolice)): >> /src/qemu/block.c: In function `bdrv_info_stats_bs': >> /src/qemu/block.c:1548: warning: long long int format, long unsigned >> int arg (arg 6) >> >> There may be also truncati

Re: [Qemu-devel] [RfC PATCH] Fix vnc memory corruption with width = 1400

2010-06-15 Thread Markus Armbruster
Gerd Hoffmann writes: > vnc assumes that the screen width is a multiple of 16 in several places. > If this is not the case vnc will overrun buffers, corrupt memory, make > qemu crash. > > This is the minimum fix for this bug. It makes sure we don't overrun the > scanline, thereby fixing the segfa

Re: [Qemu-devel] [PATCH v2 7/7] apic: qdev conversion cleanup

2010-06-15 Thread Markus Armbruster
Blue Swirl writes: > On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster wrote: >> Blue Swirl writes: >> >>> Make APICState completely private to apic.c by using DeviceState >>> in external APIs. >> >> Could you explain why this is an improvement? > > Outside of apic.c, there is no need to acces

[Qemu-devel] Re: [PATCH v5] block: add sheepdog driver for distributed storage support

2010-06-15 Thread Kevin Wolf
Am 14.06.2010 21:48, schrieb MORITA Kazutaka: >> 3) qemu-io aio_read/write doesn't seem to work well with it. I only get >> the result of the AIO request when I exit qemu-io. This may be a qemu-io >> problem or a Sheepdog one. We need to look into this, qemu-io is >> important for testing and debug

Re: [Qemu-devel] [PATCH v2] add pflib: PixelFormat conversion library.

2010-06-15 Thread Gerd Hoffmann
+++ b/pflib.h @@ -0,0 +1,6 @@ Missing #if guards and missing license/copyright. Will add. Are you planning on using this somewhere? Yes, for both fbdev and spice. I'd prefer to merge this with some code to use it somewhere as right now, it's dead code. Ok, I'll resend it with fbdev the

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-15 Thread Gerd Hoffmann
Hi, If the guest is stopped while unplugging the device the unplug should happen as soon as the guest is unpaused. This is a case where the fundamental problem is that the pci_del command should block until the guest has actually responded to the request. You can't block. Unplug might nev

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Markus Armbruster
Paul Brook writes: > Alex Williamson writes: > >> On Mon, 2010-06-14 at 08:39 +0200, Markus Armbruster wrote: >> > Could you explain why you add "identified properties of the immediate >> > parent bus and device"? They make the result ver much *not* a "dev >> > path" in the qdev sense... >> >>

Re: [Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device hierarchy string

2010-06-15 Thread Markus Armbruster
Alex Williamson writes: > On Mon, 2010-06-14 at 09:02 +0200, Gerd Hoffmann wrote: >> Hi, >> >> > My premise with this attempt is that we walk the hierarchy and use the >> > names to create the base of the path. As we get to the device, >> > particularly to the parent bus of the device, we need

[Qemu-devel] Re: [PATCH] pci hotplug: make pci hotplug return value to caller.

2010-06-15 Thread Gerd Hoffmann
On 06/15/10 05:47, Isaku Yamahata wrote: Make pci hotplug callback return value to caller. There is no reason to discard return value. Acked-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [PATCH] xen: Fix build error due to missing include

2010-06-15 Thread Markus Armbruster
Jan Kiszka writes: > From: Jan Kiszka > > Signed-off-by: Jan Kiszka > --- > hw/xen_backend.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/xen_backend.h b/hw/xen_backend.h > index f07f7d4..cc25f9d 100644 > --- a/hw/xen_backend.h > +++ b/hw/xen_backend.h > @@

[Qemu-devel] Re: [PATCH] pci hotplug: staticfy pci_device_hot_remove().

2010-06-15 Thread Gerd Hoffmann
On 06/15/10 05:48, Isaku Yamahata wrote: staticfy pci_device_hot_remove(). Acked-by: Gerd Hoffmann cheers, Gerd

[Qemu-devel] Re: [PATCH] xen: Fix build error due to missing include

2010-06-15 Thread Kevin Wolf
Am 14.06.2010 23:11, schrieb Jan Kiszka: > From: Jan Kiszka > > Signed-off-by: Jan Kiszka Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] xen: Fix build error due to missing include

2010-06-15 Thread Jan Kiszka
Markus Armbruster wrote: > Jan Kiszka writes: > >> From: Jan Kiszka >> >> Signed-off-by: Jan Kiszka >> --- >> hw/xen_backend.h |1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/hw/xen_backend.h b/hw/xen_backend.h >> index f07f7d4..cc25f9d 100644 >> --- a/hw/xen_b

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-15 Thread Markus Armbruster
Anthony Liguori writes: > On 06/09/2010 09:27 AM, Gerd Hoffmann wrote: >> Hi, >> >>> This make sense when you mistakenly add a pci device on a -s -S >>> scenario, like the scenario described on the following bug: >>> https://bugs.launchpad.net/qemu/+bug/544367. >> >> It doesn't IMHO. >> >>> Whe

Re: [Qemu-devel] RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-15 Thread Avi Kivity
On 06/10/2010 08:45 PM, Markus Armbruster wrote: QMP command docs blockdev_add Add host block device. Arguments: - "id": the host block device's ID, must be unique (json-string) - "format": image format (json-string, optional) - Possible values: "raw", "qcow

[Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device hierarchy string

2010-06-15 Thread Gerd Hoffmann
ISA: serial/parallel = iobase, others?? ne2k_isa has iobase too. I think all remaining isa devices (timer, kbd, vga, ...) have a fixed i/o base and can be only once in the system. ide-drive: unit I2C: address virtio-serial doesn't seem to make a DeviceState per port, so I think it can be s

[Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-15 Thread Michael S. Tsirkin
On Tue, Jun 15, 2010 at 02:06:46PM +0900, Isaku Yamahata wrote: > Don't overwrite pci header type. > Otherwise, multi function bit which pci_init_header_type() sets > appropriately is lost. > Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero > which is already zero cleared. > > S

Re: [Qemu-devel] [PATCH 0/5] Add '-device help' output for device params and help text

2010-06-15 Thread Markus Armbruster
Anthony Liguori writes: > On 06/08/2010 12:21 AM, Amit Shah wrote: >> On (Mon) Jun 07 2010 [11:09:32], Anthony Liguori wrote: >> >>> On 05/31/2010 07:41 AM, Amit Shah wrote: >>> Hello, This patch series adds support to specify some descriptive help text to qdev devic

Re: [Qemu-devel] [PATCH] xen: Fix build error due to missing include

2010-06-15 Thread Markus Armbruster
Jan Kiszka writes: > Markus Armbruster wrote: >> Jan Kiszka writes: >> >>> From: Jan Kiszka >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> hw/xen_backend.h |1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/hw/xen_backend.h b/hw/xen_backend.h >>> index f07f7d4

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Jan Kiszka
Markus Armbruster wrote: > Paul Brook writes: > >> Alex Williamson writes: >> >>> On Mon, 2010-06-14 at 08:39 +0200, Markus Armbruster wrote: Could you explain why you add "identified properties of the immediate parent bus and device"? They make the result ver much *not* a "dev p

Re: [Qemu-devel] [PATCH 2/2] pci: don't overwrite pci header type.

2010-06-15 Thread malc
On Tue, 15 Jun 2010, Isaku Yamahata wrote: > Don't overwrite pci header type. > Otherwise, multi function bit which pci_init_header_type() sets > appropriately is lost. > Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero > which is already zero cleared. ac97 changes are fine wit

Re: [Qemu-devel] [PATCH] block: fix a warning and possible truncation

2010-06-15 Thread Alexander Graf
Am 14.06.2010 um 20:55 schrieb Blue Swirl : Fix a warning from OpenBSD gcc (3.3.5 (propolice)): /src/qemu/block.c: In function `bdrv_info_stats_bs': /src/qemu/block.c:1548: warning: long long int format, long unsigned int arg (arg 6) There may be also truncation effects. Signed-off-by: Blue S

Re: [Qemu-devel] [PATCH] block: fix a warning and possible truncation

2010-06-15 Thread Kevin Wolf
Am 15.06.2010 11:52, schrieb Alexander Graf: > > Am 14.06.2010 um 20:55 schrieb Blue Swirl : > >> Fix a warning from OpenBSD gcc (3.3.5 (propolice)): >> /src/qemu/block.c: In function `bdrv_info_stats_bs': >> /src/qemu/block.c:1548: warning: long long int format, long unsigned >> int arg (arg 6)

[Qemu-devel] [PATCH 2/5] add unregister_displaychangelistener

2010-06-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- console.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/console.h b/console.h index 2263971..3f77661 100644 --- a/console.h +++ b/console.h @@ -228,6 +228,11 @@ static inline void register_displaychangelistener(DisplayState *ds, Di

[Qemu-devel] [PATCH 0/5] fbdev display driver + misc bits

2010-06-15 Thread Gerd Hoffmann
Hi, This patch series features the linux fbdev display driver and a few more patches the fbdev driver depends on. Most of the patches have been on the list before. If you wondered what they are good for -- here is the big picture ;) As usual the individual patches carry more verbose descripti

[Qemu-devel] [PATCH 4/5] add pflib: PixelFormat conversion library.

2010-06-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- Makefile.objs |1 + pflib.c | 213 + pflib.h | 20 ++ 3 files changed, 234 insertions(+), 0 deletions(-) create mode 100644 pflib.c create mode 100644 pflib.h diff --git a/Makefile.

[Qemu-devel] [PATCH 3/5] Fix and simplify gui timer logic.

2010-06-15 Thread Gerd Hoffmann
Kill the nographic and gui timers. Add a single periodic_timer to replace them. We have a timer running anyway, so so the gui/nographic separation is pretty pointless, we can just drive everything we need from the single periodic timer. Don't allocate the timer twice in case we have two display

Re: [Qemu-devel] [PATCH 1/2] qcow2: Simplify image creation

2010-06-15 Thread Stefan Hajnoczi
On Mon, Jun 14, 2010 at 3:43 PM, Kevin Wolf wrote: > Instead of doing lots of magic for setting up initial refcount blocks and > stuff > create a minimal (inconsistent) image, open it and initialize the rest with > regular qcow2 functions. Nice idea. > +    ret = bdrv_pwrite(bs, 0, &header, siz

[Qemu-devel] [PATCH 1/5] QLIST-ify display change listeners.

2010-06-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- console.h | 72 +++ hw/xenfb.c |2 +- vl.c |9 ++- 3 files changed, 42 insertions(+), 41 deletions(-) diff --git a/console.h b/console.h index aafb031..2263971 100644 --- a/console.h ++

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2010-06-15 Thread Chris Bainbridge
Do you have a link for the qemu-devel thread? I had a look at http://lists.gnu.org/archive/html/qemu-devel/ but couldn't see anything. -- virsh save is very slow https://bugs.launchpad.net/bugs/524447 You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

[Qemu-devel] [PATCH 5/5] linux fbdev display driver.

2010-06-15 Thread Gerd Hoffmann
Display works, requires truecolor framebuffer with 16 or 32 bpp on the host. 32bpp is recommended. The framebuffer is used as-is, qemu doesn't try to switch modes. With LCD displays mode switching is pretty pointless IMHO, also it wouldn't work anyway with the most common fbdev drivers (vesafb,

Re: [Qemu-devel] [RESENT PATCH] Add exit notifiers.

2010-06-15 Thread Stefan Hajnoczi
Looks good. Stefan

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-15 Thread Juan Quintela
Anthony Liguori wrote: > On 06/14/2010 02:54 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >>> What makes migration important and not savevm? >>> >> That is the reason why I insist to have the events "both" in source and >> destination. About how to integrate savevm on the whole pict

Re: [Qemu-devel] [PATCH 1/2] qcow2: Simplify image creation

2010-06-15 Thread Kevin Wolf
Am 15.06.2010 12:14, schrieb Stefan Hajnoczi: > On Mon, Jun 14, 2010 at 3:43 PM, Kevin Wolf wrote: >> Instead of doing lots of magic for setting up initial refcount blocks and >> stuff >> create a minimal (inconsistent) image, open it and initialize the rest with >> regular qcow2 functions. > >

[Qemu-devel] [PATCH v2 1/2] qcow2: Simplify image creation

2010-06-15 Thread Kevin Wolf
Instead of doing lots of magic for setting up initial refcount blocks and stuff create a minimal (inconsistent) image, open it and initialize the rest with regular qcow2 functions. This is a complete rewrite of the image creation function. The old implementating is #ifdef'd out and will be removed

[Qemu-devel] Re: Unusual physical address when using 64-bit BAR

2010-06-15 Thread Avi Kivity
On 06/11/2010 08:31 PM, Cam Macdonell wrote: On Mon, Apr 19, 2010 at 10:41 AM, Cam Macdonell wrote: Hi, I'm trying to use a 64-bit BAR for my shared memory device. In simply changing the memory type in pci_register_bar() to PCI_BASE_ADDRESS_MEM_TYPE_64 I get an unusual physical address fo

[Qemu-devel] [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen No need for kvm_init() stub in kvm-stub.c as already defined in qemu-kvm.h Signed-off-by: Jes Sorensen --- kvm-stub.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index 7be5f5d..645fa1d 100644 --- a/kvm-stub.c +++ b/kvm

[Qemu-devel] [PATCH 4/7] Build certain drivers for MIPS as well.

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen pcspk.o i8254.o acpi.o acpi_piix4.o are all required for MIPS as well, add them to Makefile.target accordingly. Signed-off-by: Jes Sorensen --- Makefile.target |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Makefile.target b/Makefile.target index a

[Qemu-devel] [PATCH 1/7] Only call kvm_set_irqfd() if CONFIG_KVM is defined

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen Only call kvm_set_irqfd() if CONFIG_KVM is defined to avoid breaking the build for non x86. Signed-off-by: Jes Sorensen --- hw/virtio-pci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index c3c1fcd..926b8e1 10

[Qemu-devel] [PATCH 3/7] time_drift_fix is x86 only, rather than !ia64

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen time_drift_fix is x86 only, rather than !ia64, to allow the code to build for other archs, like MIPS. Signed-off-by: Jes Sorensen --- hw/i8259.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index a8ae069..e89d831 100644 --

[Qemu-devel] [PATCH 5/7] Only export phys_mem create functions for !CONFIG_USER_ONLY builds

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen Only export phys_mem create functions for !CONFIG_USER_ONLY builds Signed-off-by: Jes Sorensen --- qemu-kvm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-kvm.h b/qemu-kvm.h index 6f6c6d8..9adbc58 100644 --- a/qemu-kvm.h +++ b/qemu-kvm.h @@

[Qemu-devel] [PATCH 6/7] Only treat KVM specific cmdline options for KVM enabled builds

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen Only treat KVM specific cmdline options for KVM enabled builds. This fixes build breakage for target MIPS etc. Signed-off-by: Jes Sorensen --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 9e9c176..e4a9aa9 100644 --- a/vl.c

[Qemu-devel] [PATCH 0/7] Fix building qemu-kvm for non KVM target

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen Hi, This set of patches fixes building qemu-kvm for non KVM targets, as reported in http://sourceforge.net/tracker/?func=detail&atid=893831&aid=2984626&group_id=180599 One of the main problem is that we have a tendency to move things from Makefile.objs to Makefile.target in o

[Qemu-devel] [PATCH 7/7] Only accept -no-hpet for i386 targets

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen Only accept -no-hpet for i386 targets Signed-off-by: Jes Sorensen --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index e4a9aa9..1977409 100644 --- a/vl.c +++ b/vl.c @@ -3328,9 +3328,11 @@ int main(int argc, char **argv, char **

[Qemu-devel] Re: [PATCH v2 1/2] qcow2: Simplify image creation

2010-06-15 Thread Stefan Hajnoczi
On Tue, Jun 15, 2010 at 11:36 AM, Kevin Wolf wrote: > +    /* > +     * And now open the image and make it consistent first (i.e. increase the > +     * refcount of the cluster that is occupied by the header and the > refcount > +     * table) > +     */ > +    BlockDriver* drv = bdrv_find_format

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Paul Brook
> > In fact what you really want to do is transfer the device tree > > (including properties), and create the machine from scratch, not load > > state into a pre-supplied device tree. > > Well, I agree, but that's a lot more of an overhaul, and once again > we're changing the problem. I think it'

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Paul Brook
> > Alex proposed to disambiguate by adding "identified properties of the > > immediate parent bus and device" to the path component. For PCI, these > > are dev.fn. Likewise for any other bus where devices have unambigous > > bus address. The driver name carries no information! > > From user PO

[Qemu-devel] [Bug 568228] Re: /home/qemu-0.12.3/tcg/tcg.c:1367: tcg fatal error

2010-06-15 Thread Deckhartz
I have compiled the qemu 0.12.4 src on Debian 5.0.3 and I have the same problem on my Sun Ultra45. $ uname -a Linux workstation 2.6.26-2-sparc64 #1 Wed May 12 20:39:46 UTC 2010 sparc64 GNU/Linux $ qemu --version QEMU PC emulator version 0.12.4, Copyright (c) 2003-2008 Fabrice Bellard $ qemu

Re: [Qemu-devel] Re: [PATCH v2 1/2] qcow2: Simplify image creation

2010-06-15 Thread Kevin Wolf
Am 15.06.2010 13:08, schrieb Stefan Hajnoczi: > On Tue, Jun 15, 2010 at 11:36 AM, Kevin Wolf wrote: >> +/* >> + * And now open the image and make it consistent first (i.e. increase >> the >> + * refcount of the cluster that is occupied by the header and the >> refcount >> + * tab

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Markus Armbruster
Jan Kiszka writes: > Markus Armbruster wrote: >> Paul Brook writes: >> >>> Alex Williamson writes: >>> On Mon, 2010-06-14 at 08:39 +0200, Markus Armbruster wrote: > Could you explain why you add "identified properties of the immediate > parent bus and device"? They make the resul

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Jan Kiszka
Paul Brook wrote: >>> Alex proposed to disambiguate by adding "identified properties of the >>> immediate parent bus and device" to the path component. For PCI, these >>> are dev.fn. Likewise for any other bus where devices have unambigous >>> bus address. The driver name carries no information!

Re: [Qemu-devel] Re: [PATCH v2 1/2] qcow2: Simplify image creation

2010-06-15 Thread Stefan Hajnoczi
On Tue, Jun 15, 2010 at 12:31 PM, Kevin Wolf wrote: > Am 15.06.2010 13:08, schrieb Stefan Hajnoczi: >> On Tue, Jun 15, 2010 at 11:36 AM, Kevin Wolf wrote: >>> +    /* >>> +     * And now open the image and make it consistent first (i.e. increase >>> the >>> +     * refcount of the cluster that i

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Jan Kiszka
Markus Armbruster wrote: > Jan Kiszka writes: > >> Markus Armbruster wrote: >>> Paul Brook writes: >>> Alex Williamson writes: > On Mon, 2010-06-14 at 08:39 +0200, Markus Armbruster wrote: >> Could you explain why you add "identified properties of the immediate >> parent b

[Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target

2010-06-15 Thread Avi Kivity
On 06/15/2010 02:04 PM, jes.soren...@redhat.com wrote: From: Jes Sorensen Hi, This set of patches fixes building qemu-kvm for non KVM targets, as reported in http://sourceforge.net/tracker/?func=detail&atid=893831&aid=2984626&group_id=180599 One of the main problem is that we have a tendency t

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Paul Brook
> >> From user POV, driver names are very handly to address a device > >> intuitively - except for the case you have tones of devices on the same > >> bus that are handled by the same driver. For that case we need to > >> augment the device name with a useful per-bus ID, derived from the bus > >> a

[Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target

2010-06-15 Thread Avi Kivity
On 06/15/2010 03:04 PM, Avi Kivity wrote: On 06/15/2010 02:04 PM, jes.soren...@redhat.com wrote: From: Jes Sorensen Hi, This set of patches fixes building qemu-kvm for non KVM targets, as reported in http://sourceforge.net/tracker/?func=detail&atid=893831&aid=2984626&group_id=180599 One of

[Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target

2010-06-15 Thread Jes Sorensen
On 06/15/10 14:04, Avi Kivity wrote: > It's the other way round. Upstream keeps moving stuff out of > Makefile.target, and I move them back during merges, because the only > thing I can think of during a merge is "how quickly can I complete this > merge". > > Thanks for tackling this. I see. I f

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Jan Kiszka
Paul Brook wrote: From user POV, driver names are very handly to address a device intuitively - except for the case you have tones of devices on the same bus that are handled by the same driver. For that case we need to augment the device name with a useful per-bus ID, derived f

[Qemu-devel] Re: [PATCH 7/7] Only accept -no-hpet for i386 targets

2010-06-15 Thread Jan Kiszka
jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Only accept -no-hpet for i386 targets > > Signed-off-by: Jes Sorensen > --- > vl.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/vl.c b/vl.c > index e4a9aa9..1977409 100644 > --- a/vl.c > +++ b/vl.c > @@

Re: [Qemu-devel] RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-15 Thread Markus Armbruster
Avi Kivity writes: > On 06/10/2010 08:45 PM, Markus Armbruster wrote: >> QMP command docs >> >> >> blockdev_add >> >> >> Add host block device. >> >> Arguments: >> >> - "id": the host block device's ID, must be unique (json-string) >> - "format": image format (json-s

[Qemu-devel] [PATCH 0/7] initial spice support.

2010-06-15 Thread Gerd Hoffmann
Hi, /me wants getting the spice support merging started, here is the first batch of patches. It brings just the very basic bits: * Detect spice in configure, Makefile windup. * Support for keyboard, mouse and tablet. * Support for simple display output (works as DisplayChangeListener, pl

[Qemu-devel] [PATCH 2/7] add spice into the configure file

2010-06-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 8220226..ca0942a 100755 --- a/configure +++ b/configure @@ -314,6 +314,7 @@ pkgversion="" check_utests="no" user_p

[Qemu-devel] [PATCH 4/7] spice: add keyboard

2010-06-15 Thread Gerd Hoffmann
Open keyboard channel. Now you can type into the spice client and the keyboard events are sent to your guest. You'll need some other display like vnc to actually see the guest responding to them though. Signed-off-by: Gerd Hoffmann --- Makefile.objs |2 +- qemu-spice.h |1 + spice-inp

[Qemu-devel] [PATCH 1/7] configure: add logging

2010-06-15 Thread Gerd Hoffmann
Write compile commands and messages to config.log. Useful for debugging configure. Signed-off-by: Gerd Hoffmann --- configure |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/configure b/configure index c0d8aa5..8220226 100755 --- a/configure +++ b/configure @@ -16,

[Qemu-devel] [PATCH 7/7] spice: add tablet support

2010-06-15 Thread Gerd Hoffmann
Add support for the spice tablet interface. The tablet interface will be registered (and then used by the spice client) as soon as a absolute pointing device is available and used by the guest, i.e. you'll have to configure your guest with '-usbdevice tablet'. Signed-off-by: Gerd Hoffmann --- s

[Qemu-devel] [PATCH 3/7] spice: core bits

2010-06-15 Thread Gerd Hoffmann
Add -spice command line switch. Has support setting passwd and port for now. With this patch applied the spice client can successfully connect to qemu. You can't do anything useful yet though. Signed-off-by: Gerd Hoffmann --- Makefile.objs |2 + qemu-config.c | 23 qemu-con

[Qemu-devel] [PATCH 5/7] spice: add mouse

2010-06-15 Thread Gerd Hoffmann
Open mouse channel. Now you can move the guests mouse pointer. No tablet / absolute positioning (yet) though. Signed-off-by: Gerd Hoffmann --- spice-input.c | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/spice-input.c b/spice-input.c inde

[Qemu-devel] [PATCH 6/7] spice: simple display

2010-06-15 Thread Gerd Hoffmann
With that patch applied you'll actually see the guests screen in the spice client. This does *not* bring qxl and full spice support though. This is basically the qxl vga mode made more generic, so it plays together with any qemu-emulated gfx card. You can display stdvga or cirrus via spice client

[Qemu-devel] Re: [PATCH v5] block: add sheepdog driver for distributed storage support

2010-06-15 Thread MORITA Kazutaka
At Tue, 15 Jun 2010 10:24:14 +0200, Kevin Wolf wrote: > > Am 14.06.2010 21:48, schrieb MORITA Kazutaka: > >> 3) qemu-io aio_read/write doesn't seem to work well with it. I only get > >> the result of the AIO request when I exit qemu-io. This may be a qemu-io > >> problem or a Sheepdog one. We need

[Qemu-devel] Re: [PATCH 7/7] Only accept -no-hpet for i386 targets

2010-06-15 Thread Jes Sorensen
On 06/15/10 14:20, Jan Kiszka wrote: >> @@ -3328,9 +3328,11 @@ int main(int argc, char **argv, char **envp) >> case QEMU_OPTION_no_acpi: >> acpi_enabled = 0; >> break; >> +#ifdef TARGET_I386 >> case QEMU_OPTION_no_hpet: >>

[Qemu-devel] Re: [PATCH 7/7] Only accept -no-hpet for i386 targets

2010-06-15 Thread Jes Sorensen
On 06/15/10 14:37, Jan Kiszka wrote: >> Upstream seems to have removed the TARGET_I386 around 'int no_hpet = 0;' >> but to be honest, I think the correct solution is to not expose no_hpet >> to non x86 targets in upstream. > > Then I would suggest to address this upstream first. The goal should be

[Qemu-devel] Re: [PATCH 7/7] Only accept -no-hpet for i386 targets

2010-06-15 Thread Jan Kiszka
Jes Sorensen wrote: > On 06/15/10 14:20, Jan Kiszka wrote: >>> @@ -3328,9 +3328,11 @@ int main(int argc, char **argv, char **envp) >>> case QEMU_OPTION_no_acpi: >>> acpi_enabled = 0; >>> break; >>> +#ifdef TARGET_I386 >>> case QEMU_OPTION_

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Paul Brook
> Paul Brook wrote: > From user POV, driver names are very handly to address a device > intuitively - except for the case you have tones of devices on the > same bus that are handled by the same driver. For that case we need > to augment the device name with a useful per-bus ID,

[Qemu-devel] [PATCH] block: fix physical_block_size calculation

2010-06-15 Thread Christoph Hellwig
Both SCSI and virtio expect the physical block size relative to the logical block size. So get the factor first before calculating the log2. Reported-by: Mike Cao Signed-off-by: Christoph Hellwig Index: qemu/block_int.h === ---

[Qemu-devel] [PATCH 1/7] Only call kvm_set_irqfd() if CONFIG_KVM is defined

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen Only call kvm_set_irqfd() if CONFIG_KVM is defined to avoid breaking the build for non x86. Signed-off-by: Jes Sorensen --- hw/virtio-pci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index c3c1fcd..926b8e1 10

[Qemu-devel] [PATCH 3/7] time_drift_fix is x86 only, rather than !ia64

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen time_drift_fix is x86 only, rather than !ia64, to allow the code to build for other archs, like MIPS. Signed-off-by: Jes Sorensen --- hw/i8259.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index a8ae069..e89d831 100644 --

[Qemu-devel] [PATCH 4/7] Build certain drivers for MIPS as well.

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen pcspk.o i8254.o acpi.o acpi_piix4.o are all required for MIPS as well, add them to Makefile.target accordingly. Signed-off-by: Jes Sorensen --- Makefile.target |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Makefile.target b/Makefile.target index a

Re: [Qemu-devel] RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-15 Thread Avi Kivity
On 06/15/2010 03:23 PM, Markus Armbruster wrote: media_insert/remove seem to duplicate blockdev_add/del. Perhaps we don't need them? To change media, tell the guest device to eject, blockdev_del, blockdev_add, reassociate the guest and host parts. Device model code is not prepared to h

[Qemu-devel] [PATCH 6/7] Only treat KVM specific cmdline options for KVM enabled builds

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen Only treat KVM specific cmdline options for KVM enabled builds. This fixes build breakage for target MIPS etc. Signed-off-by: Jes Sorensen --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 9e9c176..e4a9aa9 100644 --- a/vl.c

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Jan Kiszka
Paul Brook wrote: >> Paul Brook wrote: >> From user POV, driver names are very handly to address a device >> intuitively - except for the case you have tones of devices on the >> same bus that are handled by the same driver. For that case we need >> to augment the device name with a

[Qemu-devel] [PATCH v2 0/7] Fix building qemu-kvm for non KVM target

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen Hi, This set of patches fixes building qemu-kvm for non KVM targets, as reported in http://sourceforge.net/tracker/?func=detail&atid=893831&aid=2984626&group_id=180599 One of the main problem is that we have a tendency to move things from Makefile.objs to Makefile.target in o

[Qemu-devel] [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen No need for kvm_init() stub in kvm-stub.c as already defined in qemu-kvm.h Signed-off-by: Jes Sorensen --- kvm-stub.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index 7be5f5d..645fa1d 100644 --- a/kvm-stub.c +++ b/kvm

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Markus Armbruster
Jan Kiszka writes: > Markus Armbruster wrote: >> Jan Kiszka writes: >> >>> Markus Armbruster wrote: Paul Brook writes: > Alex Williamson writes: > >> On Mon, 2010-06-14 at 08:39 +0200, Markus Armbruster wrote: >>> Could you explain why you add "identified properties

[Qemu-devel] [PATCH 5/7] Only export phys_mem create functions for !CONFIG_USER_ONLY builds

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen Only export phys_mem create functions for !CONFIG_USER_ONLY builds Signed-off-by: Jes Sorensen --- qemu-kvm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-kvm.h b/qemu-kvm.h index 6f6c6d8..9adbc58 100644 --- a/qemu-kvm.h +++ b/qemu-kvm.h @@

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Paul Brook
> >> Works for serial, but fails for ISA devices not occupying an address. > > > > An ISA device without an IO/MMIO capabilities seems extremely unlikely. > > What exactly would such a device do? > > Inject interrupts via that bus (while exposing registers in some other > way). The m48t59 seems t

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Markus Armbruster
Jan Kiszka writes: > Paul Brook wrote: Alex proposed to disambiguate by adding "identified properties of the immediate parent bus and device" to the path component. For PCI, these are dev.fn. Likewise for any other bus where devices have unambigous bus address. The driver n

[Qemu-devel] [PATCH 7/7] Declare no_hpet variable for all targets

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen We need to declare 'int no_hpet' for all targets to avoid build failure on no x86 builds. Signed-off-by: Jes Sorensen --- vl.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index e4a9aa9..b9a9a76 100644 --- a/vl.c +++ b/vl.c @@ -214,9

Re: [Qemu-devel] RFC v2: blockdev_add & friends, brief rationale, QMP docs

2010-06-15 Thread Markus Armbruster
Avi Kivity writes: > On 06/15/2010 03:23 PM, Markus Armbruster wrote: >> >>> media_insert/remove seem to duplicate blockdev_add/del. Perhaps we >>> don't need them? >>> >>> To change media, tell the guest device to eject, blockdev_del, >>> blockdev_add, reassociate the guest and host parts. >>>

Re: [Qemu-devel] [Bug 524447] Re: virsh save is very slow

2010-06-15 Thread Laine Stump
Bug description: As reported here: http://www.redhat.com/archives/libvir-list/2009-December/msg00203.html "virsh save" is very slow - it writes the image at around 1MB/sec on my test system. (I think I saw a bug report for this issue on Fedora's bugzilla, but I can't find it now...) Here's

[Qemu-devel] Re: KVM call agenda for June 15

2010-06-15 Thread Anthony Liguori
On 06/15/2010 12:48 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - Page cache controls (Balbir/Dave) Regards, Anthony Liguori If we have a lack of agenda items I'll cancel the week's call. thanks, -chris -- To unsubscribe from this list: send

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-15 Thread Paul Brook
> > Every hotplug-capable bus must have a proper addressing scheme, I think > > this is a reasonable and achievable requirement. Then we don't need > > instance numbers for those buses. > > What about USB? USB has useful device addresses (physical ports). These aren't used by most of the higher-l

[Qemu-devel] [PATCH 2/5] Revert "ide save/restore current transfer fields"

2010-06-15 Thread Juan Quintela
This reverts commit 42ee76fe82093ba914f0dc83d2decbcf68866144. Signed-off-by: Juan Quintela --- hw/ide/pci.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 4d95cc5..780fc5f 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -123,7 +1

[Qemu-devel] [PATCH 3/5] vmstate: add subsections code

2010-06-15 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/hw.h |6 savevm.c | 90 +- 2 files changed, 95 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index a49d866..f3a7a5a 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -311,6 +311,11 @@

  1   2   3   >