Re: [Qemu-devel] 9p: [RFC] [PATCH 02/02] Make use of iounit for read/write

2010-06-04 Thread Sripathi Kodi
On Tue, 1 Jun 2010 19:47:49 +0530 "M. Mohan Kumar" wrote: > Change the v9fs_file_readn function to limit the maximum transfer size > based on the iounit instead of msize. > > Also remove the redundant check for limiting the transfer size in > v9fs_file_write. This check is done by p9_client_wri

[Qemu-devel] Qemu-mips

2010-06-04 Thread Ehsan Ul haq
Hi, What part of the QEMU source code generates translation blocks for mips user emulation? Thanks,

[Qemu-devel] [Bug 589564] [NEW] Windows host tap (tap-win32) is not working on QEMU ver 0.12.X

2010-06-04 Thread Ibrahim Umar
Public bug reported: To reproduce the bug: 1) Install tap driver from openvpn (either v8/v9). Rename the tap connection to "mytap" and set the IP to 192.168.1.1 (or any ip) 2) use any QEMU 0.12.X and issue the following command c:\qemu> qemu -net nic -net tap,ifname=mytap -cdrom ../linux.iso 3

Re: [Qemu-devel] [PATCH 08/16] Move main signal handler setup to os specificfiles.

2010-06-04 Thread Markus Armbruster
Jes Sorensen writes: > On 06/03/10 22:52, Richard Henderson wrote: >> On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote: >>> --- a/qemu-os-win32.h >>> +++ b/qemu-os-win32.h >>> @@ -41,4 +41,7 @@ int qemu_add_wait_object(HANDLE handle, WaitObjectFunc >>> *func, void *opaque); >>> void qemu_d

[Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension

2010-06-04 Thread Paolo Bonzini
On 06/03/2010 09:59 PM, Igor Kovalenko wrote: On Thu, Jun 3, 2010 at 7:42 PM, Paolo Bonzini wrote: On 06/03/2010 05:25 PM, Alexander Graf wrote: Am 03.06.2010 um 15:18 schrieb Paolo Bonzini: On 06/01/2010 10:12 PM, Igor V. Kovalenko wrote: From: Igor V. Kovalenko - change return type of

[Qemu-devel] [Bug 562107] Re: QEmu GDB stub uses IPv6 instead of v4 (or both)

2010-06-04 Thread Ibrahim Umar
There is an alternative way to force gdbserver to use ipv4 instead ipv6 without changing the source code. Use this command: c:\>qemu -S -gdb tcp::1234,ipv4 <...other parameters> Works for me until there is a bugfix for this. Thanks. -- QEmu GDB stub uses IPv6 instead of v4 (or both) https://b

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > Introduce OS specific cmdline argument handling by calling > os_parse_cmd_args() at the end of switch() statement. > > In addition move SMB argument to os-posix.c > > Signed-off-by: Jes Sorensen > --- > os-posix.c | 34 +

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-04 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > Hi, > > I have been working on a set of patches to clean up the vl.c code, by > separating out OS specific code into OS specific files. Basically it > introduces two header files: qemu-os-win32.h and qemu-os-posix.h as > well as os-win32.c

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes Sorensen
On 06/04/10 10:15, Markus Armbruster wrote: > jes.soren...@redhat.com writes: >> + * Parse OS specific command line options. >> + * return 0 if option handled, -1 otherwise >> + */ >> +int os_parse_cmd_args(const QEMUOption *popt, const char *optarg) >> +{ >> +int ret = 0; >> +switch (popt-

[Qemu-devel] Re: [PATCH 08/13] qdev: Decouple qdev_prop_drive from DriveInfo

2010-06-04 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> +static void free_drive(DeviceState *dev, Property *prop) >> +{ >> +BlockDriverState **ptr = qdev_get_prop_ptr(dev, prop); >> + >> +if (*ptr) { >> +blockdev_detach(*ptr, dev); >> +} >> +} > >> @@ -1043,26 +1043,26 @@ static void scsi_destroy(

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-04 Thread Jes Sorensen
On 06/04/10 10:21, Markus Armbruster wrote: > jes.soren...@redhat.com writes: >> I have tried to be as careful as I can to not break non Linux support, >> but as I only have a Linux build environment handy, I would appreciate >> it if people with other OSes could check that I didn't break anything

Re: [Qemu-devel] [PATCH 13/13] blockdev: New -blockdev to define a host block device

2010-06-04 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jun 02, 2010 at 06:55:29PM +0200, Markus Armbruster wrote: >> Existing -drive defines both host and guest part. To make it work >> with -device, we created if=none. But all this does is peel off guest >> device selection. The other guest properties such as g

[Qemu-devel] Re: [V9fs-developer] [PATCH] virtio-9p: getattr server implementation for 9P2000.L protocol.

2010-06-04 Thread Aneesh Kumar K. V
On Thu, 3 Jun 2010 18:29:02 +0530, Sripathi Kodi wrote: > On Wed, 02 Jun 2010 19:49:24 +0530 > "Aneesh Kumar K. V" wrote: > > > On Fri, 28 May 2010 16:08:43 +0530, Sripathi Kodi > > wrote: > > > From: M. Mohan Kumar > > > > > > SYNOPSIS > > > > > > size[4] Tgetattr tag[2] fid[4] > > >

[Qemu-devel] [PATCH v3 2/7] MIPS: Initial support of vt82686b south bridge used by fulong mini pc

2010-06-04 Thread Huacai Chen
Signed-off-by: Huacai Chen --- Makefile.target |2 +- hw/pci_ids.h|8 + hw/vt82c686.c | 579 +++ hw/vt82c686.h | 11 + 4 files changed, 599 insertions(+), 1 deletions(-) create mode 100644 hw/vt82c686.c create mode 100644 hw

[Qemu-devel] [PATCH v3 4/7] MIPS: Initial support of VIA USB controller used by fulong mini pc

2010-06-04 Thread Huacai Chen
Signed-off-by: Huacai Chen --- hw/usb-uhci.c | 20 hw/usb-uhci.h |1 + 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 624d55b..feb44e6 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@ -1152,6 +1152,16 @@ static int u

[Qemu-devel] [PATCH v3 5/7] MIPS: Initial support of fulong mini pc (CPU definition)

2010-06-04 Thread Huacai Chen
Signed-off-by: Huacai Chen --- target-mips/mips-defs.h |4 target-mips/translate_init.c | 35 +++ 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/target-mips/mips-defs.h b/target-mips/mips-defs.h index c57de02..38594da 100644 --- a/t

[Qemu-devel] [PATCH v3 6/7] MIPS: Initial support of fulong mini pc (machine construction)

2010-06-04 Thread Huacai Chen
Signed-off-by: Huacai Chen --- Makefile.target|2 +- hw/mips_fulong2e.c | 402 2 files changed, 403 insertions(+), 1 deletions(-) create mode 100644 hw/mips_fulong2e.c diff --git a/Makefile.target b/Makefile.target index 92ba282..f20

[Qemu-devel] [PATCH v3 3/7] MIPS: Initial support of VIA IDE controller used by fulong mini pc

2010-06-04 Thread Huacai Chen
Signed-off-by: Huacai Chen --- Makefile.objs|1 + default-configs/mips64el-softmmu.mak |1 + hw/ide.h |1 + hw/ide/via.c | 176 ++ 4 files changed, 179 insertions(+), 0 deletio

[Qemu-devel] [PATCH v3 1/7] MIPS: Initial support of bonito north bridge used by fulong mini pc

2010-06-04 Thread Huacai Chen
Signed-off-by: Huacai Chen --- Makefile.target |1 + default-configs/mips64el-softmmu.mak |1 + hw/bonito.c | 816 ++ hw/mips.h|3 + 4 files changed, 821 insertions(+), 0 deletio

Re: [Qemu-devel] [PATCH v3 1/7] MIPS: Initial support of bonito north bridge used by fulong mini pc

2010-06-04 Thread Isaku Yamahata
On Fri, Jun 04, 2010 at 04:37:43PM +0800, Huacai Chen wrote: > Signed-off-by: Huacai Chen > --- > Makefile.target |1 + > default-configs/mips64el-softmmu.mak |1 + > hw/bonito.c | 816 > ++ > hw/mips.h

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-06-04 Thread Adam Lackorzynski
Handle smc as undefined instruction instead of having it wrongly interpreted as some other instruction. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index

Re: [Qemu-devel] [PATCH v3 2/7] MIPS: Initial support of vt82686b south bridge used by fulong mini pc

2010-06-04 Thread Isaku Yamahata
On Fri, Jun 04, 2010 at 04:38:30PM +0800, Huacai Chen wrote: > Signed-off-by: Huacai Chen > --- > Makefile.target |2 +- > hw/pci_ids.h|8 + > hw/vt82c686.c | 579 > +++ > hw/vt82c686.h | 11 + > 4 files changed, 599 insertio

Re: [Qemu-devel] [PATCH v3 3/7] MIPS: Initial support of VIA IDE controller used by fulong mini pc

2010-06-04 Thread Isaku Yamahata
On Fri, Jun 04, 2010 at 04:39:01PM +0800, Huacai Chen wrote: > Signed-off-by: Huacai Chen > --- > Makefile.objs|1 + > default-configs/mips64el-softmmu.mak |1 + > hw/ide.h |1 + > hw/ide/via.c | 176 > +

[Qemu-devel] [PATCH] Add exit notifiers.

2010-06-04 Thread Gerd Hoffmann
Hook up any cleanup work which needs to be done here. Advantages over using atexit(3): (1) You get passed in a pointer to the notifier. If you embed that into your state struct you can use container_of() to get get your state info. (2) You can unregister, say when un-plugging a d

[Qemu-devel] [PATCH] vpc: Read/write multiple sectors at once

2010-06-04 Thread Kevin Wolf
This changes the vpc block driver (for VHD) to read/write multiple sectors at once instead of doing a request for each single sector. Before this, running qemu-iotests for VPC took ages, now it's actually quite reasonable to run it always (down from ~1 hour to 40 seconds for me). Signed-off-by: K

[Qemu-devel] [Bug 156085] Re: Could not open /proc/bus/usb/devices

2010-06-04 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/fxload -- Could not open /proc/bus/usb/devices https://bugs.launchpad.net/bugs/156085 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Fix Released Status in Virtualbox: Fix Released Status in

[Qemu-devel] Re: [PATCH] block: Fix serial number assignment

2010-06-04 Thread Kevin Wolf
Am 02.06.2010 22:46, schrieb Luiz Capitulino: > We should use 'dinfo->serial' length, 'serial' is a pointer, so > the serial number length is currently limited to the pointer size. > > This fixes https://bugs.launchpad.net/qemu/+bug/584143 and is also > valid for stable. > > Signed-off-by: Luiz C

Re: [Qemu-devel] [PATCH] Add exit notifiers.

2010-06-04 Thread Stefan Hajnoczi
On Fri, Jun 4, 2010 at 10:35 AM, Gerd Hoffmann wrote: > Hook up any cleanup work which needs to be done here.  Advantages over > using atexit(3): > >  (1) You get passed in a pointer to the notifier.  If you embed that >      into your state struct you can use container_of() to get get your >    

[Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension

2010-06-04 Thread Paolo Bonzini
On 06/04/2010 09:53 AM, Paolo Bonzini wrote: On 06/03/2010 09:59 PM, Igor Kovalenko wrote: On Thu, Jun 3, 2010 at 7:42 PM, Paolo Bonzini wrote: On 06/03/2010 05:25 PM, Alexander Graf wrote: Am 03.06.2010 um 15:18 schrieb Paolo Bonzini: On 06/01/2010 10:12 PM, Igor V. Kovalenko wrote: From

[Qemu-devel] [PATCH 0/3] qcow2: More error handling fixes

2010-06-04 Thread Kevin Wolf
Three more cases of ignored or mutated error codes. Kevin Wolf (3): qcow2: Allow get_refcount to return errors qcow2: Allow alloc_clusters_noref to return errors qcow2: Return real error code in load_refcount_block block/qcow2-refcount.c | 70 +

[Qemu-devel] [PATCH 1/3] qcow2: Allow get_refcount to return errors

2010-06-04 Thread Kevin Wolf
get_refcount might need to load a refcount block from disk, so errors may happen. Return the error code instead of assuming a refcount of 1 and change the callers to respect error return values. Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 41 +

[Qemu-devel] [PATCH 2/3] qcow2: Allow alloc_clusters_noref to return errors

2010-06-04 Thread Kevin Wolf
Currently it would consider blocks for which get_refcount fails used. However, it's unlikely that get_refcount would succeed for the next cluster, so it's not really helpful. Return an error instead. Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 18 +++--- 1 files changed,

[Qemu-devel] [PATCH 3/3] qcow2: Return real error code in load_refcount_block

2010-06-04 Thread Kevin Wolf
This fixes load_refcount_block which completely ignored the return value of write_refcount_block and always returned -EIO for bdrv_pwrite failure. Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/block/qcow2-r

[Qemu-devel] Re: [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Paolo Bonzini
+/* + * Duplicate definition from vl.c to avoid messing up the entire build + */ +enum { +#define DEF(option, opt_arg, opt_enum, opt_help, arch_mask) \ +opt_enum, +#define DEFHEADING(text) +#include "qemu-options.h" +#undef DEF +#undef DEFHEADING +#undef GEN_DOCS +}; I agree with Richa

[Qemu-devel] Re: [PATCH 3/3] blockdev: Collect block device code in new blockdev.c

2010-06-04 Thread Kevin Wolf
Am 02.06.2010 18:16, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 02.06.2010 13:31, schrieb Markus Armbruster: >>> Anything that moves hundreds of lines out of vl.c can't be all bad. >>> >>> Signed-off-by: Markus Armbruster >> >> New files need a license header, otherwise it looks ok.

[Qemu-devel] Re: [PATCHv3 1/2] virtio: support layout with avail ring before idx

2010-06-04 Thread Michael S. Tsirkin
On Fri, Jun 04, 2010 at 12:04:57PM +0930, Rusty Russell wrote: > On Wed, 2 Jun 2010 12:17:12 am Michael S. Tsirkin wrote: > > This adds an (unused) option to put available ring before control (avail > > index, flags), and adds padding between index and flags. This avoids > > cache line sharing betw

[Qemu-devel] Re: [RFC PATCH v4 3/3] block: add sheepdog driver for distributed storage support

2010-06-04 Thread Kevin Wolf
Am 03.06.2010 18:23, schrieb MORITA Kazutaka: >>> +static void sd_aio_cancel(BlockDriverAIOCB *blockacb) >>> +{ >>> + SheepdogAIOCB *acb = (SheepdogAIOCB *)blockacb; >>> + >>> + acb->canceled = 1; >>> +} >> >> Does this provide the right semantics? You haven't really cancelled the >> request, b

[Qemu-devel] Re: [PATCHv3 1/2] virtio: support layout with avail ring before idx

2010-06-04 Thread Rusty Russell
On Fri, 4 Jun 2010 08:05:43 pm Michael S. Tsirkin wrote: > On Fri, Jun 04, 2010 at 12:04:57PM +0930, Rusty Russell wrote: > > On Wed, 2 Jun 2010 12:17:12 am Michael S. Tsirkin wrote: > > > This adds an (unused) option to put available ring before control (avail > > > index, flags), and adds padding

[Qemu-devel] Re: [PATCHv3 1/2] virtio: support layout with avail ring before idx

2010-06-04 Thread Michael S. Tsirkin
On Fri, Jun 04, 2010 at 08:46:49PM +0930, Rusty Russell wrote: > On Fri, 4 Jun 2010 08:05:43 pm Michael S. Tsirkin wrote: > > On Fri, Jun 04, 2010 at 12:04:57PM +0930, Rusty Russell wrote: > > > On Wed, 2 Jun 2010 12:17:12 am Michael S. Tsirkin wrote: > > > > This adds an (unused) option to put ava

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-04 Thread Markus Armbruster
Jes Sorensen writes: > On 06/04/10 10:21, Markus Armbruster wrote: >> jes.soren...@redhat.com writes: >>> I have tried to be as careful as I can to not break non Linux support, >>> but as I only have a Linux build environment handy, I would appreciate >>> it if people with other OSes could check

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-04 Thread Jes Sorensen
On 06/04/10 13:54, Markus Armbruster wrote: > Jes Sorensen writes: > >> On 06/04/10 10:21, Markus Armbruster wrote: >>> I like moving stuff out of vl.c in general. Your moves of entire >>> functions look like a win to me. I have doubts about spreading the >>> option switch over three files, tho

[Qemu-devel] [PATCH] qemu:virtio-9p: Send iounit to client for read/write operations

2010-06-04 Thread M. Mohan Kumar
Compute iounit based on the host filesystem block size and pass it to client with open/create response. Also return iounit as statfs's f_bsize for optimal block size transfers. Signed-off-by: M. Mohan Kumar Reviewd-by: Sripathi Kodi --- hw/virtio-9p.c | 69 +++

[Qemu-devel] Re: [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes Sorensen
On 06/04/10 12:39, Paolo Bonzini wrote: >>> I agree with Richard: this is gross. >> >> The enum creation is gross by itself. Only way to get around not >> duplicating it is to create a new header file to hold just that? > > I don't think it's particularly gross. At least you don't have two > file

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Markus Armbruster
Jes Sorensen writes: > On 06/04/10 10:15, Markus Armbruster wrote: >> jes.soren...@redhat.com writes: >>> + * Parse OS specific command line options. >>> + * return 0 if option handled, -1 otherwise >>> + */ >>> +int os_parse_cmd_args(const QEMUOption *popt, const char *optarg) >>> +{ >>> +in

[Qemu-devel] [PATCH] 9p: Make use of iounit for read/write

2010-06-04 Thread M. Mohan Kumar
Change the v9fs_file_readn function to limit the maximum transfer size based on the iounit or msize. Also remove the redundant check for limiting the transfer size in v9fs_file_write. This check is done by p9_client_write. Signed-off-by: M. Mohan Kumar --- fs/9p/vfs_file.c | 13 +++--

[Qemu-devel] [PATCH] Add exit notifiers.

2010-06-04 Thread Gerd Hoffmann
Hook up any cleanup work which needs to be done here. Advantages over using atexit(3): (1) You get passed in a pointer to the notifier. If you embed that into your state struct you can use container_of() to get get your state info. (2) You can unregister, say when un-plugging a d

Re: [Qemu-devel] [PATCH] Add exit notifiers.

2010-06-04 Thread Gerd Hoffmann
--- a/roms/seabios +++ b/roms/seabios @@ -1 +1 @@ -Subproject commit 8f469b9676127ba6bb52609d89ec774e61db0ee1 +Subproject commit 7d09d0e3ba11310e973d4302c7fcc3fc2184e04c This hunk seems unrelated to your commit. Damn. Yea. These seem to creap in now and then, I think when rebasing to a new

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes Sorensen
On 06/04/10 14:04, Markus Armbruster wrote: > Jes Sorensen writes: > >> On 06/04/10 10:15, Markus Armbruster wrote: >> What do you mean? The real ugh! here is that it was created as a >> typedef. I can change the function to pass in just the index, but I >> don't know if we will have cases where

[Qemu-devel] Re: [PATCH 3/3] blockdev: Collect block device code in new blockdev.c

2010-06-04 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.06.2010 18:16, schrieb Markus Armbruster: >> Kevin Wolf writes: >> >>> Am 02.06.2010 13:31, schrieb Markus Armbruster: Anything that moves hundreds of lines out of vl.c can't be all bad. Signed-off-by: Markus Armbruster >>> >>> New files need a license

[Qemu-devel] [Bug 587993] Re: qemu-kvm 0.12.4+dfsg-1 from debian squeeze crashes "BUG: unable to handle kernel NULL pointer" (sym53c8xx)

2010-06-04 Thread Maciek
** Description changed: I use eucalyptus software (1.6.2) on debian squeeze with kvm - 0.12.4+dfsg-1. Kernel 2.6.32-3-amd64. After a few days machines crash. - There are no logs in host system. Guest is the same kernel and OS as - host. The kvm process use 100% of cpu time. I can not even ping t

Re: [Qemu-devel] Re: [PATCH V3 1/3] qemu: Add qemu-wrappers for pthread_attr_t

2010-06-04 Thread Anthony Liguori
On 06/03/2010 07:31 AM, Paolo Bonzini wrote: On 06/03/2010 10:56 AM, Gautham R Shenoy wrote: Add qemu wrappers for pthread_attr_t handling. The point of these wrappers AFAIU is not only to add error_exit, but also to be portable to Windows in the future. Is it necessary to create the thread

[Qemu-devel] [PATCH 3/5] vnc: add lossless option

2010-06-04 Thread Corentin Chary
The lossless option can be used to force lossless compression by disabling all lossy encodings like gradient or jpeg. Signed-off-by: Corentin Chary --- qemu-options.hx |5 + vnc-encoding-tight.c |4 vnc.c|2 ++ vnc.h|2 ++ 4 files cha

[Qemu-devel] [PATCH 0/5] vnc updates and ui move

2010-06-04 Thread Corentin Chary
Hi, This set starts by adding JPEG and gradient to tight, then move all ui code in the ui/ subdirectory. Thanks, Corentin Chary (5): vnc: tight: add JPEG and gradient subencoding with smooth image detection vnc: JPEG should be disabled if the client don't set tight quality vnc: add lossl

[Qemu-devel] [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-04 Thread Corentin Chary
Disable JPEG compression by default and only enable it if the VNC client has sent the requested quality. Signed-off-by: Corentin Chary --- vnc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vnc.c b/vnc.c index ed0e096..9cf38d1 100644 --- a/vnc.c +++ b/vnc.c @@ -1644,

[Qemu-devel] [PATCH 1/5] vnc: tight: add JPEG and gradient subencoding with smooth image detection

2010-06-04 Thread Corentin Chary
Add gradient filter and JPEG compression with an heuristic to detect how lossy the comppression will be. This code has been adapted from libvncserver/tight.c. JPEG support can be enabled/disabled at compile time with --enable-vnc-jpeg and --disable-vnc-jpeg. Signed-off-by: Corentin Chary --- Ma

Re: [Qemu-devel] [PATCH V3 2/3] qemu: Generic asynchronous threading framework to offload tasks

2010-06-04 Thread Anthony Liguori
On 06/03/2010 03:56 AM, Gautham R Shenoy wrote: From: Aneesh Kumar K.V This patch creates a generic asynchronous-task-offloading infrastructure. It's extracted out of the threading framework that is being used by paio. The reason for extracting out this generic infrastructure of the posix-aio-c

[Qemu-devel] Re: [PATCH 3/5] vnc: add lossless option

2010-06-04 Thread Alexander Graf
On 04.06.2010, at 15:18, Corentin Chary wrote: > The lossless option can be used to force lossless compression > by disabling all lossy encodings like gradient or jpeg. I think this should be reverse. Be lossless by default, but have a lossy option. Alex

[Qemu-devel] [PATCH v2 1/2] qemu-thread: add qemu_mutex/cond_destroy and qemu_mutex_exit

2010-06-04 Thread Corentin Chary
Add some missing functions in qemu-thread. Currently qemu-thread is only used for io-thread but it will used by the vnc server soon and we need those functions instead of calling pthread directly. Signed-off-by: Corentin Chary --- qemu-thread.c | 22 ++ qemu-thread.h |4

[Qemu-devel] Re: [PATCH 4/5] ui: move all ui components in ui/

2010-06-04 Thread Alexander Graf
On 04.06.2010, at 15:18, Corentin Chary wrote: > Move sdl, vnc, curses and cocoa UI into ui/ to cleanup > the root directory. Also remove some unnecessary explicit > targets from Makefile. There's a magic command to tell git to indicate moves as moves. I guess that'd be a good idea here :) Ale

[Qemu-devel] [PATCH v2 0/2] Threaded VNC server

2010-06-04 Thread Corentin Chary
Hi, This series add a threaded VNC server and should be applied on top on my previous patch set (adding tight encoding). The first patch add some functions to qemu-thread. The last oneis the threaded VNC server. Thanks Since v1: * Moved locks from VncState to VncDisplay because it's only used i

[Qemu-devel] Re: [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-04 Thread Alexander Graf
On 04.06.2010, at 15:18, Corentin Chary wrote: > Disable JPEG compression by default and only enable it if the > VNC client has sent the requested quality. > > Signed-off-by: Corentin Chary > --- > vnc.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/vnc.c b/vnc.

Re: [Qemu-devel] Re: [PATCH V3 1/3] qemu: Add qemu-wrappers for pthread_attr_t

2010-06-04 Thread Corentin Chary
On Fri, Jun 4, 2010 at 3:07 PM, Anthony Liguori wrote: > On 06/03/2010 07:31 AM, Paolo Bonzini wrote: >> >> On 06/03/2010 10:56 AM, Gautham R Shenoy wrote: >>> >>> Add qemu wrappers for pthread_attr_t handling. >> >> The point of these wrappers AFAIU is not only to add error_exit, but also >> to b

[Qemu-devel] Re: [PATCH 5/5] vnc: rename vnc-encoding-* vnc-enc-*

2010-06-04 Thread Alexander Graf
On 04.06.2010, at 15:18, Corentin Chary wrote: > For the same reason that we don't use vnc-authentication-sasl.c but > vnc-auth-sals.c. Because it's to long. This patch would certainly also benefit from the move detection. Alex

[Qemu-devel] [PATCH 01/17] vl.c: Remove double include of netinet/in.h for Solaris

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen vl.c: netinet/in.h is already included once above for the generic POSIX case. Signed-off-by: Jes Sorensen --- vl.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 417554f..7c4298a 100644 --- a/vl.c +++ b/vl.c @@ -70,7 +70,6 @@ #inc

[Qemu-devel] [PATCH v2 00/17] clean up vl.c code

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Hi, This is the second version of my vl.c cleanup patch. I have tried to fix it up based on the feedback I received on yesterday's version. I should pretty much have covered everything that was suggested. The patches try to clean up the vl.c code by separating out OS specific

[Qemu-devel] [PATCH 02/17] Create qemu-os-win32.h and move WIN32 specific declarations there

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Create qemu-os-win32.h for WIN32 specific declarations. Move polling handling declaration into this file from sysemu.h Signed-off-by: Jes Sorensen --- qemu-os-win32.h | 43 +++ sysemu.h| 17 + 2 files change

[Qemu-devel] Re: [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-04 Thread Alexander Graf
On 04.06.2010, at 15:19, Anthony Liguori wrote: > On 06/04/2010 08:16 AM, Alexander Graf wrote: >> On 04.06.2010, at 15:18, Corentin Chary wrote: >> >> >>> Disable JPEG compression by default and only enable it if the >>> VNC client has sent the requested quality. >>> >>> Signed-off-by: Core

[Qemu-devel] [PATCH 07/17] Rename os_setup_signal_handling() to os_setup_early_signal_handling()

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Rename os_setup_signal_handling() to os_setup_early_signal_handling() Signed-off-by: Jes Sorensen --- os-posix.c |2 +- os-win32.c |2 +- qemu-os-posix.h |2 +- qemu-os-win32.h |2 +- vl.c|2 +- 5 files changed, 5 insertions(+), 5 de

[Qemu-devel] [PATCH 08/17] Move main signal handler setup to os specificfiles.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Move main signal handler setup to os specific files. Signed-off-by: Jes Sorensen --- os-posix.c | 27 +++ qemu-os-posix.h |1 + qemu-os-win32.h |3 +++ vl.c| 33 + 4 files changed, 32 insert

[Qemu-devel] [PATCH 00/17] *** SUBJECT HERE ***

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen *** BLURB HERE *** Jes Sorensen (17): vl.c: Remove double include of netinet/in.h for Solaris Create qemu-os-win32.h and move WIN32 specific declarations there Introduce os-win32.c and move polling functions from vl.c vl.c: Move host_main_loop_wait() to OS specific fil

[Qemu-devel] [PATCH 10/17] Rename qemu-options.h to qemu-options.def

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Rename qemu-options.h to qemu-options.def as it is not a header file for general use and this leaves space for a proper qemu-options.h Signed-off-by: Jes Sorensen --- Makefile.objs |4 ++-- vl.c |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) di

[Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Move daemonize handling from vl.c to OS specific files. Provide dummy stubs for Win32. Signed-off-by: Jes Sorensen --- os-posix.c | 102 os-win32.c |5 +++ qemu-os-posix.h |2 + qemu-os-win32.h |2 +

[Qemu-devel] [PATCH 15/17] Make os_change_process_uid and os_change_root os-posix.c local

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen os_change_process_uid() and os_change_root() are now only called from os-posix.c, so no need to keep win32 stubs for them. Signed-off-by: Jes Sorensen --- os-posix.c |8 qemu-os-posix.h |2 -- qemu-os-win32.h |2 -- 3 files changed, 4 insertions(+),

[Qemu-devel] [PATCH 16/17] Move line-buffering setup to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Move line-buffering setup to OS specific files. Signed-off-by: Jes Sorensen --- os-posix.c |5 + qemu-os-posix.h |1 + qemu-os-win32.h |2 ++ vl.c|5 + 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/os-posix.c b/os-pos

[Qemu-devel] Re: [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-04 Thread Alexander Graf
On 04.06.2010, at 15:48, Corentin Chary wrote: >> >> The tight quality level is a slider on most clients. A user doesn't know >> when it starts being lossy. He also can only choose 0 as the lowest (iirc). >> And IIRC the X tightvnc client also always sent the quality level. >> >> Alex >> >>

[Qemu-devel] Re: [PATCH] Fix and simplify gui timer logic.

2010-06-04 Thread Gerd Hoffmann
On 06/04/10 15:44, Gerd Hoffmann wrote: Kill nographic timer. Have a global gui_timer instead. Have the gui timer enabled unconditionally. We need a timer running anyway for mmio flush, so the whole have-gui-timer-only-when-needed logic is pretty pointless. It also simplifies displaylisteners

[Qemu-devel] [PATCH 12/17] Move runas handling from vl.c to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Move code to handle runas, ie. change of user id of QEMU process to OS specific files and provide dummy stub for Win32. Signed-off-by: Jes Sorensen --- os-posix.c | 28 qemu-os-posix.h |1 + qemu-os-win32.h |1 + vl.c|

[Qemu-devel] [PATCH 05/17] Introduce os-posix.c and create os_setup_signal_handling()

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Introcuce os-posix.c and move posix specific signal handling there. Add dummy stub for win32. Signed-off-by: Jes Sorensen --- Makefile.objs |1 + os-posix.c | 41 + qemu-os-posix.h |2 ++ qemu-os-win32.h |1 + vl.c

Re: [Qemu-devel] Re: [PATCH V3 1/3] qemu: Add qemu-wrappers for pthread_attr_t

2010-06-04 Thread Paolo Bonzini
On 06/04/2010 03:19 PM, Corentin Chary wrote: The point of these wrappers AFAIU is not only to add error_exit, but also to be portable to Windows in the future. This is historical because the code was largely inspired by glibc's implementation of posix-aio. It doesn't need to be detached and s

[Qemu-devel] [PATCH 06/17] Move win32 early signal handling setup to os_setup_signal_handling()

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Move win32 early signal handling setup to os_setup_signal_handling() Signed-off-by: Jes Sorensen --- os-win32.c | 29 + vl.c | 30 -- 2 files changed, 29 insertions(+), 30 deletions(-) diff --git a/os-win32.c

[Qemu-devel] [PATCH 17/17] Move set_proc_name() to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Move handling to change process name to POSIX specific files plus add a better error message to cover the case where the feature isn't supported. Signed-off-by: Jes Sorensen --- os-posix.c | 24 qemu-os-posix.h |1 + qemu-os-win32.h |1

[Qemu-devel] [PATCH] [V4] 9p: readdir implementation for 9p2000.L

2010-06-04 Thread Sripathi Kodi
This patch implements the kernel part of readdir() implementation for 9p2000.L Change from V3: Instead of inode, server now sends qids for each dirent SYNOPSIS size[4] Treaddir tag[2] fid[4] offset[8] count[4] size[4] Rreaddir tag[2] count[4] data[count] DESCRIPTION The

[Qemu-devel] [PATCH v2 2/2] vnc: threaded VNC server

2010-06-04 Thread Corentin Chary
Implement a threaded VNC server using the producer-consumer model. The main thread will push encoding jobs (a list a rectangles to update) in a queue, and the VNC worker thread will consume that queue and send framebuffer updates to the output buffer. The threaded VNC server can be enabled with ./

[Qemu-devel] [PATCH 09/17] Move find_datadir to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen This moves the win32 and POSIX versions of find_datadir() to OS specific files, and removes some #ifdef clutter from vl.c Signed-off-by: Jes Sorensen --- os-posix.c | 64 +++ os-win32.c | 23 ++ sysemu.h |3 ++ vl.c

[Qemu-devel] [PATCH 04/17] vl.c: Move host_main_loop_wait() to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Move host_main_loop_wait() to OS specific files. Create qemu-os-posix.h and provide empty inline for the POSIX case. Signed-off-by: Jes Sorensen --- os-win32.c | 43 +++ qemu-os-posix.h | 33 +

[Qemu-devel] Re: [PATCH 00/17] *** SUBJECT HERE ***

2010-06-04 Thread Jes Sorensen
On 06/04/10 15:24, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > *** BLURB HERE *** > ARGH, someone needs to learn about temp files please ignore this one :(

[Qemu-devel] [PATCH 2/2] machine: pass all init options as a single QemuOpts

2010-06-04 Thread Anthony Liguori
The current method of passing arguments to machine init functions is haphazard. We pass some arguments as via the init function. We pass a lot of other arguments as global variables some that are supported by a lot of boards and others that are only supported by one board. It's very difficult to

[Qemu-devel] [PATCH 13/17] Move chroot handling to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Move chroot handling to OS specific files. Signed-off-by: Jes Sorensen --- os-posix.c | 19 +++ qemu-os-posix.h |1 + qemu-os-win32.h |1 + vl.c| 18 +- 4 files changed, 22 insertions(+), 17 deletions(-) diff --gi

[Qemu-devel] [PATCH] [V4] virtio-9p: readdir implementation for 9p2000.L

2010-06-04 Thread Sripathi Kodi
This patch implements the server part of readdir() implementation for 9p2000.L Change from V3: Instead of inode, server now sends qids for each dirent SYNOPSIS size[4] Treaddir tag[2] fid[4] offset[8] count[4] size[4] Rreaddir tag[2] count[4] data[count] DESCRIPTION

[Qemu-devel] [PATCH] [V4] 9p: readdir implementation for 9p2000.L

2010-06-04 Thread Sripathi Kodi
This patch implements the kernel part of readdir() implementation for 9p2000.L Change from V3: Instead of inode, server now sends qids for each dirent SYNOPSIS size[4] Treaddir tag[2] fid[4] offset[8] count[4] size[4] Rreaddir tag[2] count[4] data[count] DESCRIPTION The

[Qemu-devel] Re: RFC: blockdev_add & friends, brief rationale, QMP docs

2010-06-04 Thread Markus Armbruster
Discussion with Christoph and Kevin uncovered yet another issue: protocols. I find it pretty confusing, but let me try to describe it anyway; Christoph and Kevin, please correct my errors. A host block device has a format. A format has a name. Below the format, it has a stack of protocols. A p

[Qemu-devel] [PATCH 1/2] machine: package all init arguments into a QemuOpts

2010-06-04 Thread Anthony Liguori
This patch creates a QemuOpts structure and stores all of the machine init arguments in that structure. It introduces a temporary list of QemuOptDescs in vl.c such that the current common options can be validated. The long term vision is that that list becomes a #define and that each machine can

[Qemu-devel] [RFC] QMP: Introduce query-netdevices documentation

2010-06-04 Thread Miguel Di Ciurcio Filho
This introduces the protocol specification for querying information about network devices available on a VM and a new monitor command that show the same information. Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx | 69 +++ 1 files

[Qemu-devel] Re: [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-04 Thread Corentin Chary
> > The tight quality level is a slider on most clients. A user doesn't know when > it starts being lossy. He also can only choose 0 as the lowest (iirc). And > IIRC the X tightvnc client also always sent the quality level. > > Alex > > You can use -nojpeg for that. Most vnc clients have this op

[Qemu-devel] Re: [PATCH 4/5] ui: move all ui components in ui/

2010-06-04 Thread Corentin Chary
On Fri, Jun 4, 2010 at 3:18 PM, Alexander Graf wrote: > > On 04.06.2010, at 15:18, Corentin Chary wrote: > >> Move sdl, vnc, curses and cocoa UI into ui/ to cleanup >> the root directory. Also remove some unnecessary explicit >> targets from Makefile. > > There's a magic command to tell git to ind

[Qemu-devel] Re: [PATCH v2 2/2] vnc: threaded VNC server

2010-06-04 Thread Alexander Graf
On 04.06.2010, at 15:20, Corentin Chary wrote: > Implement a threaded VNC server using the producer-consumer model. > The main thread will push encoding jobs (a list a rectangles to update) > in a queue, and the VNC worker thread will consume that queue and send > framebuffer updates to the outpu

[Qemu-devel] Re: [PATCH v3] savevm: Really verify if a drive supports snapshots

2010-06-04 Thread Kevin Wolf
Am 03.06.2010 21:52, schrieb Miguel Di Ciurcio Filho: > Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. > > First issue: Their names implies different porpouses, but they do the same > thing > and have exactly the same code. Maybe copied and pasted and forgotten? > b

[Qemu-devel] Re: [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-04 Thread Corentin Chary
> Phew - I didn't even know of that option until now. I guess that's a bad > sign? :) > > One way I thought of it was to start being lossy as of quality level 6 or so. > That way people who accidently enable jpeg still know "high quality means > lossless". I'm not sure Anthony agrees on this tho

[Qemu-devel] Re: RFC: blockdev_add & friends, brief rationale, QMP docs

2010-06-04 Thread Kevin Wolf
Am 04.06.2010 16:16, schrieb Markus Armbruster: > Discussion with Christoph and Kevin uncovered yet another issue: > protocols. I find it pretty confusing, but let me try to describe it > anyway; Christoph and Kevin, please correct my errors. > > A host block device has a format. A format has a

[Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-04 Thread Kevin Wolf
Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: > From: Nicholas Bellinger > > This patch updates hw/scsi-bus.c to add PERSISTENT_RESERVE_OUT and > PERSISTENT_RESERVE_IN > case in scsi_req_length() to extra the incoming buffer length into > SCSIRequest->cmd.xfer, > and adds a second PERSIST

  1   2   3   >