[Qemu-devel] [PATCH] add some tests for invalid JSON

2010-05-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- check-qjson.c | 98 - 1 files changed, 97 insertions(+), 1 deletions(-) diff --git a/check-qjson.c b/check-qjson.c index 109e777..a04e334 100644 --- a/check-qjson.c +++ b/check-qjson.c @@ -628,11 +628,90 @

[Qemu-devel] [PATCH] do not require lookahead in json-lexer.c if not necessary

2010-05-21 Thread Paolo Bonzini
> Having look ahead operate differently for different states > really complicates the lexer. I don't see this as a big > problem in practice. I also don't see this as a big problem in practice, except maybe for a quit command. However, WRT the complication of the lexer, it is really not so bad.

Re: [Qemu-devel] [PATCH 13/22] tcg-i386: Tidy push/pop.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 10:59:48AM -0700, Richard Henderson wrote: > Move tcg_out_push/pop up in the file so that they can be used > by qemu_ld/st. Define a tcg_out_pushi to be used as well. > > Signed-off-by: Richard Henderson > --- > tcg/i386/tcg-target.c | 50 ++

Re: [Qemu-devel] [PATCH 10/22] tcg-i386: Tidy immediate arithmetic operations.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 08:38:34AM -0700, Richard Henderson wrote: > Define OPC_ARITH_EvI[bz]; use throughout. Use tcg_out_ext8u > directly in setcond. Use tgen_arithi in qemu_ld/st. > > Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno > --- > tcg/i386/tcg-target.c | 28 +

Re: [Qemu-devel] [PATCH 11/22] tcg-i386: Tidy non-immediate arithmetic operations.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 10:16:33AM -0700, Richard Henderson wrote: > Add more OPC values, and tgen_arithr. Use the later throughout. > > Note that normal reg/reg arithmetic now uses the Gv,Ev opcode form > instead of the Ev,Gv opcode form used previously. Both forms > disassemble properly, and s

Re: [Qemu-devel] [PATCH 14/22] tcg-i386: Tidy calls.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 11:02:32AM -0700, Richard Henderson wrote: > Define OPC_CALL_Jz, generated by tcg_out_calli; use the later > throughout. Unify the calls within qemu_st; adjust the stack > with a single pop if applicable. > > Define and use EXT_CALLN_Ev for indirect calls. > > Signed-off-

Re: [Qemu-devel] [PATCH 12/22] tcg-i386: Tidy movi.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 10:20:08AM -0700, Richard Henderson wrote: > Define and use OPC_MOVL_Iv. > > Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno > --- > tcg/i386/tcg-target.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/tcg/i386/tcg-target.c b

[Qemu-devel] [PATCH] qemu-io: Add multiwrite command

2010-05-21 Thread Kevin Wolf
The new multiwrite commands allows to use qemu-io for testing bdrv_aio_multiwrite. Signed-off-by: Kevin Wolf --- qemu-io.c | 192 + 1 files changed, 192 insertions(+), 0 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 8517b90..e

Re: [Qemu-devel] [PATCH 17/22] tcg-i386: Tidy unary arithmetic.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 11:22:39AM -0700, Richard Henderson wrote: > Define OPC_GRP3 and EXT3_FOO to match. Use them instead of > bare constants. > > Define OPC_GRP5 and rename the existing EXT_BAR to EXT5_BAR to > make it clear which extension should be used with which opcode. > > Signed-off-by

Re: [Qemu-devel] [PATCH 18/22] tcg-i386: Tidy multiply.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 11:29:31AM -0700, Richard Henderson wrote: > Define and use OPC_IMUL_GvEv{,Ib,Iz}. > > Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno > --- > tcg/i386/tcg-target.c |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tcg/i38

[Qemu-devel] [PATCH] block: Fix multiwrite with overlapping requests

2010-05-21 Thread Kevin Wolf
With overlapping requests, the total number of sectors is smaller than the sum of the nb_sectors of both requests. Signed-off-by: Kevin Wolf --- block.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 72d9441..1586b79 100644 --- a/block.c +++ b/b

Re: [Qemu-devel] [PATCH 16/22] tcg-i386: Tidy setcc.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 11:07:27AM -0700, Richard Henderson wrote: > Define and use OPC_SETCC. > > Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno > --- > tcg/i386/tcg-target.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tcg/i386/tcg-target.c b/

[Qemu-devel] [PATCH 2/2] trace: Trace write requests in virtio-blk, multiwrite, and paio_submit

2010-05-21 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- block.c|7 +++ hw/virtio-blk.c|6 ++ posix-aio-compat.c |2 ++ trace.h| 42 +- trace.py |8 5 files changed, 64 insertions(+), 1 deletions(-) diff -

Re: [Qemu-devel] [PATCH 2/2] qcow2: Fix error handling in l2_allocate

2010-05-21 Thread Stefan Hajnoczi
On Thu, May 20, 2010 at 3:48 PM, Kevin Wolf wrote: > l2_allocate has some intermediate states in which the image is inconsistent. > Change the order to write to the L1 table only after the new L2 table has > successfully been initialized. Looks good. Stefan

[Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Stefan Hajnoczi
Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember to add events to trace.py for pretty-printing. Signed-off-by: Stefan Hajnoczi --- Makefile.objs |2 +- trace.c | 64

Re: [Qemu-devel] [PATCH 15/22] tcg-i386: Tidy ret.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 11:04:14AM -0700, Richard Henderson wrote: > Define and use OPC_RET. > > Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno > --- > tcg/i386/tcg-target.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/tcg/i386/tcg-target.c b/tcg

Re: [Qemu-devel] [PATCH 19/22] tcg-i386: Tidy xchg.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 11:32:24AM -0700, Richard Henderson wrote: > Define and use OPC_XCHG_ax_r32. > > Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno > --- > tcg/i386/tcg-target.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/tcg/i386/tcg-targe

Re: [Qemu-devel] [PATCH 21/22] tcg-i386: Use lea for three-operand add.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 01:29:27PM -0700, Richard Henderson wrote: > The result is shorter than the mov+add that TCG would > otherwise generate for us. > > Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno > --- > tcg/i386/tcg-target.c | 23 --- > 1 files changed

[Qemu-devel] {PING}[PATCH 0/4] Support NPTL support for ColdFire and related fixes

2010-05-21 Thread Maxim Kuvyrkov
On 3/1/10 10:19 PM, Maxim Kuvyrkov wrote: The following series of 4 patches adds NPTL support for ColdFire user-mode emulation and fixes several related issues, mainly in signal handling. 0001-Add-NPTL-support-for-ColdFire.patch Implement new kernel syscalls to support TLS storage and synchroniz

Re: [Qemu-devel] [PATCH 20/22] tcg-i386: Tidy lea.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 14, 2010 at 12:08:28PM -0700, Richard Henderson wrote: > Implement full modrm+sib addressing mode processing. > Use that in qemu_ld/st to output the LEA. > > Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno > --- > tcg/i386/tcg-target.c | 91 > +

[Qemu-devel] Re: [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Stefan Hajnoczi
I should have used the "[RFC]" tag to make it clear that I'm not proposing these patches for merge, sorry. Stefan

[Qemu-devel] [PATCH 0/3] cursor patches

2010-05-21 Thread Gerd Hoffmann
Hi, Respin of the cursor patches, now using xpm for the builtin pointers. cheers, Gerd Gerd Hoffmann (3): cursor: add cursor functions. use new cursor struct + functions for vmware vga and sdl. vnc: rich cursor support. Makefile.objs |3 +- console.h | 24 ++

Re: [Qemu-devel] [PATCH 22/22] tcg-i386: Tidy data16 prefixes.

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 28, 2010 at 11:23:19AM -0700, Richard Henderson wrote: > Include it in the opcode as an extension, as with P_EXT > or the REX bits in the x86-64 port. > > Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno > --- > tcg/i386/tcg-target.c | 21 + > 1 file

[Qemu-devel] [PATCH 1/3] cursor: add cursor functions.

2010-05-21 Thread Gerd Hoffmann
Add a new cursor type to console.h and a bunch of functions to deal with cursors the (new) cursor.c file. Signed-off-by: Gerd Hoffmann --- Makefile.objs |3 +- console.h | 24 ++- cursor.c| 210 +++ cursor_hid

Re: [Qemu-devel] [PATCH 00/22] tcg-i386 cleanup and improvement, v2

2010-05-21 Thread Aurelien Jarno
On Wed, Apr 28, 2010 at 11:24:33AM -0700, Richard Henderson wrote: > Changes v1->v2: > * Dropped controversial bswap changes; bswap16 continues to use rolw. > * Tidy data16 as the last of the hard-coded constants. > I have applied 1-2 and 5-9, but I can't apply the other without patches 3 an

[Qemu-devel] [PATCH 3/3] vnc: rich cursor support.

2010-05-21 Thread Gerd Hoffmann
Uses VNC_ENCODING_RICH_CURSOR. Adding XCURSOR support should be possible without much trouble. Shouldn't be needed though as RICH_CURSOR is a superset of XCURSOR. Signed-off-by: Gerd Hoffmann --- vnc.c| 70 +++-- vnc.h|8

[Qemu-devel] [PATCH] do not require lookahead for escapes too

2010-05-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- json-lexer.c | 21 - roms/seabios |2 +- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/json-lexer.c b/json-lexer.c index b9250c1..bc9dfae 100644 --- a/json-lexer.c +++ b/json-lexer.c @@ -56,7 +56,6 @@ enum json_lexer_sta

[Qemu-devel] [PATCH 2/3] use new cursor struct + functions for vmware vga and sdl.

2010-05-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/vmware_vga.c | 40 +++- sdl.c | 52 +--- 2 files changed, 48 insertions(+), 44 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index e709369..bf2a699

Re: [Qemu-devel] [PATCH 1/2] arm_timer: reload timer when enabled

2010-05-21 Thread Aurelien Jarno
On Sun, May 02, 2010 at 03:20:51PM +0530, Rabin Vincent wrote: > Reload the timer when TimerControl is written, if the timer is to be > enabled. Otherwise, if an earlier write to TimerLoad was done while > periodic mode was not set, s->delta may incorrectly still have the value > of the maximum li

Re: [Qemu-devel] [PATCH 2/2] arm_timer: fix oneshot mode

2010-05-21 Thread Aurelien Jarno
On Sun, May 02, 2010 at 03:20:52PM +0530, Rabin Vincent wrote: > In oneshot mode, the delta needs to come from the TimerLoad register, > not the maximum limit. > > Signed-off-by: Rabin Vincent Thanks, applied. > --- > hw/arm_timer.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)

[Qemu-devel] Re: [[RfC PATCH]] linux fbdev display driver prototype.

2010-05-21 Thread Stefano Stabellini
On Thu, 20 May 2010, Gerd Hoffmann wrote: > Display works with 32 bpp (both host + guest) only. > Which surprisingly didn't cause much problems so far in my testing. > Host runs with kms and inteldrmfb. > > Mouse support isn't available yet. > I've cheated by passed through the hosts usb mouse

[Qemu-devel] Re: [[RfC PATCH]] linux fbdev display driver prototype.

2010-05-21 Thread Gerd Hoffmann
Hi, Does qemu->qemu switching work when running multiple VMs? Yes. cheers, Gerd

Re: [Qemu-devel] [PATCH] pflash_cfi01: add device ID read command

2010-05-21 Thread Aurelien Jarno
On Sat, May 01, 2010 at 07:34:06PM +0200, Michael Walle wrote: > Add support to read manufacturer and device ID. For everything else (eg. > lock bits) 0 is returned. > > Signed-off-by: Michael Walle Thanks, applied. > --- > hw/pflash_cfi01.c | 20 > 1 files changed, 20 i

[Qemu-devel] [RFC 0/2] Tracing

2010-05-21 Thread Stefan Hajnoczi
Trace events in QEMU/KVM can be very useful for debugging and performance analysis. I'd like to discuss tracing support and hope others have an interest in this feature, too. Following this email are patches I am using to debug virtio-blk and storage. The patches provide trivial tracing support,

[Qemu-devel] [PATCH] Add support for depth 15 to qemu_default_pixelformat()

2010-05-21 Thread Gerd Hoffmann
Makes qemu_default_pixelformat(15) return pixelformat filled for 15 bit color depth (16 bpp, 5 bits for red,green,blue each, 1 bit unused). Signed-off-by: Gerd Hoffmann --- console.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/console.c b/console.c in

[Qemu-devel] Re: [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Stefan Hajnoczi wrote: > Trace events should be defined in trace.h. Events are written to > /tmp/trace.log and can be formatted using trace.py. Remember to add > events to trace.py for pretty-printing. When already writing to a file, why not reusing QEMU's logging infrastructure ("log " / "-d fo

Re: [Qemu-devel] [PATCH] virtio-blk: Avoid zeroing every request structure

2010-05-21 Thread Stefan Hajnoczi
On Tue, May 18, 2010 at 9:43 PM, Stefan Hajnoczi wrote: > I'll rerun with profiling tomorrow to see if calloc() makes a > difference for general qemu_mallocz() usage. The results are unchanged for direct calloc() instead of malloc+memset. The memset() symbol is still at the top of the profile be

Re: [Qemu-devel] [RFC 0/2] Tracing

2010-05-21 Thread Prerna Saxena
Hi Stefan, Nice to see the patchset. I am working on something similar, on the lines of static trace events for QEMU, that collect traces in a qemu-internal buffer. This would employ monitor commands to read traces, as well as enable/disable trace events at runtime. I plan to post a prototype

[Qemu-devel] Re: [PATCH] add support for protocol driver create_options

2010-05-21 Thread Kevin Wolf
Am 20.05.2010 07:36, schrieb MORITA Kazutaka: > This patch enables protocol drivers to use their create options which > are not supported by the format. For example, protcol drivers can use > a backing_file option with raw format. > > Signed-off-by: MORITA Kazutaka Hm, this is not stackable, ri

Re: [Qemu-devel] [PATCH] fix curses update - v2

2010-05-21 Thread andrzej zaborowski
Hi, I pushed a modified patch to preserve attributes such as background colour. Please check if this works for you. Cheers

[Qemu-devel] [Bug 453617] Re: kvm hangs at 100% cpu when connecting to forwarded ports (when listed incorrectly on the command line)

2010-05-21 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/qemu-kvm -- kvm hangs at 100% cpu when connecting to forwarded ports (when listed incorrectly on the command line) https://bugs.launchpad.net/bugs/453617 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Statu

Re: [Qemu-devel] [PATCH 1/3] cursor: add cursor functions.

2010-05-21 Thread Anthony Liguori
On 05/21/2010 04:54 AM, Gerd Hoffmann wrote: Add a new cursor type to console.h and a bunch of functions to deal with cursors the (new) cursor.c file. Signed-off-by: Gerd Hoffmann I like this implementation. Blue, are you happy with it? Regards, Anthony Liguori --- Makefile.objs

[Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client

2010-05-21 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/qemu-kvm -- does not pass pressed caps lock to client https://bugs.launchpad.net/bugs/427612 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Status in “libsdl1.2” package in Ubuntu: Invali

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Anthony Liguori
On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember to add events to trace.py for pretty-printing. Signed-off-by: Stefan Hajnoczi --- Makefile.objs |2 +- trace.c

Re: [Qemu-devel] [PATCH] fix curses update - v2

2010-05-21 Thread Bernhard Kauer
On Fri, May 21, 2010 at 02:02:43PM +0200, andrzej zaborowski wrote: > I pushed a modified patch to preserve attributes such as background > colour. Good idea. > Please check if this works for you. Yes, this works. Thanks, Bernhard Kauer

Re: [Qemu-devel] forking i386 binaries on arm linux user mode

2010-05-21 Thread Damion Yates
On Tue, 11 May 2010, Richard Henderson wrote: > On 05/11/2010 10:08 AM, Damion Yates wrote: > > Also is there some magic in gnemul-x86 beyond being a set of x86 > > libs? > > No. Okay, good to know. > > Does it do any shortcutting to system calls in native rather than > > sticking with the lib

[Qemu-devel] [PATCH] resent: x86/cpuid: Add kvm32 CPU model

2010-05-21 Thread Andre Przywara
Create a kvm32 CPU model that describes a least common denominator for KVM capable guest CPUs. Useful for migration purposes. Signed-off-by: Andre Przywara --- target-i386/cpuid.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/target-i386/cpuid.c b/target-

[Qemu-devel] Re: [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Stefan Hajnoczi wrote: > On Fri, May 21, 2010 at 12:13 PM, Jan Kiszka wrote: >> Stefan Hajnoczi wrote: >>> Trace events should be defined in trace.h. Events are written to >>> /tmp/trace.log and can be formatted using trace.py. Remember to add >>> events to trace.py for pretty-printing. >> When

[Qemu-devel] Re: [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Stefan Hajnoczi
On Fri, May 21, 2010 at 12:13 PM, Jan Kiszka wrote: > Stefan Hajnoczi wrote: >> Trace events should be defined in trace.h.  Events are written to >> /tmp/trace.log and can be formatted using trace.py.  Remember to add >> events to trace.py for pretty-printing. > > When already writing to a file, w

[Qemu-devel] Re: vgabios plans ( Re: [PATCH 1/5] Makefile cleanup)

2010-05-21 Thread Gerd Hoffmann
On 05/20/10 15:04, Anthony Liguori wrote: Hmm. No response for weeks from vgabios folks on this patch series. How to go forward best with vgabios bits? Just upgrade http://git.qemu.org/vgabios.git/ to 0.6c, then apply patches there? Yeah, I think the long term goal should be to move to SeaBIOS

[Qemu-devel] linux-user mmap bug

2010-05-21 Thread Edgar E. Iglesias
Hi I ran into an mmap problem linux-user emulating CRIS (32bit) on x86_64 hosts. Guest asks for a non fixed mmap, QEMU tries the mmap but the kernel returns a high 64bit address. QEMU notices that it wont fit in the guests 32bit ptr size and retries with a low address but doesn't set the MAP_FIXED

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Anthony Liguori wrote: > On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: >> Trace events should be defined in trace.h. Events are written to >> /tmp/trace.log and can be formatted using trace.py. Remember to add >> events to trace.py for pretty-printing. >> >> Signed-off-by: Stefan Hajnoczi >> ---

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Anthony Liguori
On 05/21/2010 08:46 AM, Jan Kiszka wrote: Anthony Liguori wrote: On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember to add events to trace.py for pretty-printing

[Qemu-devel] [PATCH] resent: x86/cpuid: propagate further CPUID leafs when -cpu host

2010-05-21 Thread Andre Przywara
-cpu host currently only propagates the CPU's family/model/stepping, the brand name and the feature bits. Add a whitelist of safe CPUID leafs to let the guest see the actual CPU's cache details and other things. Signed-off-by: Andre Przywara --- target-i386/cpu.h |6 +- target-i386/cpu

[Qemu-devel] [PATCH 00/15] tcg-i386 cleanup and improvement, v3

2010-05-21 Thread Richard Henderson
Changes v2->v3: * ext8u and ext8s operate on 'q' register inputs only. * pushi is inline and loses the ifdef. * trailing whitespace cleanup r~ Richard Henderson (15): tcg-i386: Tidy ext8u and ext16u operations. tcg-i386: Tidy ext8s and ext16s operations. tcg-i386: Tidy immediate ari

[Qemu-devel] [PATCH 01/15] tcg-i386: Tidy ext8u and ext16u operations.

2010-05-21 Thread Richard Henderson
Define OPC_MOVZBL and OPC_MOVZWL. Factor opcode emission to separate functions. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 57 ++-- 1 files changed, 31 insertions(+), 26 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/t

[Qemu-devel] [PATCH 06/15] tcg-i386: Tidy push/pop.

2010-05-21 Thread Richard Henderson
Move tcg_out_push/pop up in the file so that they can be used by qemu_ld/st. Define a tcg_out_pushi to be used as well. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 48 ++-- 1 files changed, 30 insertions(+), 18 deletions(-) diff --

[Qemu-devel] [PATCH 03/15] tcg-i386: Tidy immediate arithmetic operations.

2010-05-21 Thread Richard Henderson
Define OPC_ARITH_EvI[bz]; use throughout. Use tcg_out_ext8u directly in setcond. Use tgen_arithi in qemu_ld/st. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 26 ++ 1 files changed, 10 insertions(+), 16 deletions(-) diff --git a/tcg/i386/tcg-target.c b

[Qemu-devel] [PATCH 02/15] tcg-i386: Tidy ext8s and ext16s operations.

2010-05-21 Thread Richard Henderson
Define OPC_MOVSBL and OPC_MOVSWL. Factor opcode emission to separate functions. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 35 --- 1 files changed, 24 insertions(+), 11 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c i

[Qemu-devel] [PATCH 09/15] tcg-i386: Tidy setcc.

2010-05-21 Thread Richard Henderson
Define and use OPC_SETCC. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index c258775..a43dbfb 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@

[Qemu-devel] [PATCH 04/15] tcg-i386: Tidy non-immediate arithmetic operations.

2010-05-21 Thread Richard Henderson
Add more OPC values, and tgen_arithr. Use the later throughout. Note that normal reg/reg arithmetic now uses the Gv,Ev opcode form instead of the Ev,Gv opcode form used previously. Both forms disassemble properly, and so there's no visible change when diffing log files before and after the chang

[Qemu-devel] [PATCH 07/15] tcg-i386: Tidy calls.

2010-05-21 Thread Richard Henderson
Define OPC_CALL_Jz, generated by tcg_out_calli; use the later throughout. Unify the calls within qemu_st; adjust the stack with a single pop if applicable. Define and use EXT_CALLN_Ev for indirect calls. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 49

[Qemu-devel] [PATCH 05/15] tcg-i386: Tidy movi.

2010-05-21 Thread Richard Henderson
Define and use OPC_MOVL_Iv. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index bc5985f..1d227db 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@

[Qemu-devel] [PATCH 14/15] tcg-i386: Use lea for three-operand add.

2010-05-21 Thread Richard Henderson
The result is shorter than the mov+add that TCG would otherwise generate for us. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 6562a5d.

[Qemu-devel] [PATCH 08/15] tcg-i386: Tidy ret.

2010-05-21 Thread Richard Henderson
Define and use OPC_RET. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 28a01f3..c258775 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@ -18

[Qemu-devel] [PATCH 12/15] tcg-i386: Tidy xchg.

2010-05-21 Thread Richard Henderson
Define and use OPC_XCHG_ax_r32. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 8eb88da..09a56e8 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target

[Qemu-devel] [PATCH 10/15] tcg-i386: Tidy unary arithmetic.

2010-05-21 Thread Richard Henderson
Define OPC_GRP3 and EXT3_FOO to match. Use them instead of bare constants. Define OPC_GRP5 and rename the existing EXT_BAR to EXT5_BAR to make it clear which extension should be used with which opcode. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 38 +-

[Qemu-devel] [PATCH 13/15] tcg-i386: Tidy lea.

2010-05-21 Thread Richard Henderson
Implement full modrm+sib addressing mode processing. Use that in qemu_ld/st to output the LEA. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 91 - 1 files changed, 60 insertions(+), 31 deletions(-) diff --git a/tcg/i386/tcg-target

Re: [Qemu-devel] [Bug 453617] Re: kvm hangs at 100% cpu when connecting to forwarded ports (when listed incorrectly on the command line)

2010-05-21 Thread Gleb Natapov
> ProblemType: Bug > Architecture: amd64 > Date: Fri Oct 16 17:19:59 2009 > DistroRelease: Ubuntu 9.10 What is the point forwarding distro bugs here? Can we have upstream bug tracker to report upstream issues? -- Gleb.

[Qemu-devel] [PATCH 11/15] tcg-i386: Tidy multiply.

2010-05-21 Thread Richard Henderson
Define and use OPC_IMUL_GvEv{,Ib,Iz}. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 07da8c7..8eb88da 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386

[Qemu-devel] Re: lsi: Handle removal of selected devices

2010-05-21 Thread Aurelien Jarno
This patch: 64d564094cac5f72eeaeb950c442b773a00d3586 is the first bad commit commit 64d564094cac5f72eeaeb950c442b773a00d3586 Author: Jan Kiszka Date: Tue May 4 14:21:03 2010 +0200 lsi: Handle removal of selected devices We must not store references to selected devices as they may be

[Qemu-devel] [PATCH 15/15] tcg-i386: Nuke trailing whitespace.

2010-05-21 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 52 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index fc61e80..396a2f1 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i3

[Qemu-devel] [PATCH 0/5] tcg-i386: tidy softmmu code

2010-05-21 Thread Richard Henderson
This is sort-of part 2 of the patch series that I just edited and re-posted for you. The majority of the patch series deals with the SOFTMMU code. I think you saw a patch about the data16 prefix before, but this one's different. It's written the way it is here because I have a third patch serie

Re: [Qemu-devel] Problems changing dvdrom iso during execution

2010-05-21 Thread Adnan Khaleel
So do you have any idea whats causing the problem? Is there any other way I can mount a dvd in Qemu? Adnan _ From: David S. Ahern [mailto:daah...@cisco.com] To: ad...@khaleel.us Cc: Qemu-devel@nongnu.org Sent: Thu, 20 May 2010 17:45:11 -0500 Subject: Re: [Qemu-devel] Problems changing d

[Qemu-devel] [PATCH 3/5] tcg-i386: Swap order of TLB hit and miss paths.

2010-05-21 Thread Richard Henderson
Make fallthru be TLB hit and branch be TLB miss. Doing this both improves branch prediction and will allow further cleanup. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 172 +++-- 1 files changed, 80 insertions(+), 92 deletions(-) di

[Qemu-devel] Re: lsi: Handle removal of selected devices

2010-05-21 Thread Jan Kiszka
Aurelien Jarno wrote: > This patch: > > 64d564094cac5f72eeaeb950c442b773a00d3586 is the first bad commit > commit 64d564094cac5f72eeaeb950c442b773a00d3586 > Author: Jan Kiszka > Date: Tue May 4 14:21:03 2010 +0200 > > lsi: Handle removal of selected devices > > We must not store refer

[Qemu-devel] [PATCH 2/5] tcg-i386: Split out TLB Hit path from qemu_ld/st.

2010-05-21 Thread Richard Henderson
Splitting out these functions will allow further cleanups. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 197 + 1 files changed, 102 insertions(+), 95 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 92

[Qemu-devel] [PATCH 1/5] tcg-i386: Tidy data16 prefixes.

2010-05-21 Thread Richard Henderson
Include it in the opcode as an extension, as with P_EXT or the REX bits in the x86-64 port. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 28 ++-- 1 files changed, 18 insertions(+), 10 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target

[Qemu-devel] [PATCH 5/5] tcg-i386: Remove some ifdefs in qemu_ld/st.

2010-05-21 Thread Richard Henderson
Tidy some code by replacing ifdefs by C ifs. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 85 ++--- 1 files changed, 38 insertions(+), 47 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index cf621da..8a9122c

Re: [Qemu-devel] Re: lsi: Handle removal of selected devices

2010-05-21 Thread Jan Kiszka
Jan Kiszka wrote: > Jan Kiszka wrote: >> Aurelien Jarno wrote: >>> On Fri, May 21, 2010 at 05:49:26PM +0200, Aurelien Jarno wrote: This patch: 64d564094cac5f72eeaeb950c442b773a00d3586 is the first bad commit commit 64d564094cac5f72eeaeb950c442b773a00d3586 Author: Jan Kiszka

Re: [Qemu-devel] Re: lsi: Handle removal of selected devices

2010-05-21 Thread Jan Kiszka
Jan Kiszka wrote: > Aurelien Jarno wrote: >> On Fri, May 21, 2010 at 05:49:26PM +0200, Aurelien Jarno wrote: >>> This patch: >>> >>> 64d564094cac5f72eeaeb950c442b773a00d3586 is the first bad commit >>> commit 64d564094cac5f72eeaeb950c442b773a00d3586 >>> Author: Jan Kiszka >>> Date: Tue May 4 14:

[Qemu-devel] [Bug 583462] Re: qemu disables screensaver

2010-05-21 Thread Michael Tokarev
Debian bugreport about this: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578672 (#578672). I tried it here again, with your program (using 0.12.4 from debian) - and it works as expected for me, no resets every 4 secs, screen saver triggers after configured time even if the input is grabbed

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-21 Thread Aurelien Jarno
On Tue, May 11, 2010 at 06:23:32PM +0200, Alexander Graf wrote: > On S390 we don't have a real TCG implementation but use a stub instead. This > stub obviously doesn't call any of the TCG helper functions that are usually > used by the other TCG targets. > > If such a helper function is static tho

Re: [Qemu-devel] [Bug 453617] Re: kvm hangs at 100% cpu when connecting to forwarded ports (when listed incorrectly on the command line)

2010-05-21 Thread Michael Tokarev
21.05.2010 19:42, Gleb Natapov wrote: ProblemType: Bug Architecture: amd64 Date: Fri Oct 16 17:19:59 2009 DistroRelease: Ubuntu 9.10 What is the point forwarding distro bugs here? Can we have upstream bug tracker to report upstream issues? Um, this _is_ upstream issue, as far as I can see. It

[Qemu-devel] [PATCH 4/5] tcg-i386: Split out tlb load function.

2010-05-21 Thread Richard Henderson
Share some code between qemu_ld and qemu_st. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 203 +++- 1 files changed, 97 insertions(+), 106 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 0d85ec0..cf621da

Re: [Qemu-devel] [PATCH] linux-user: do not warn for missing pselect6

2010-05-21 Thread Aurelien Jarno
On Fri, May 07, 2010 at 12:28:05PM +, Riku Voipio wrote: > Libc will fallback gracefully if pselect6 is not available. Thus put > pselect6 to nowarn until the atomicity issues of the original pselect6 > patch are dealt with. > > Signed-off-by: Riku Voipio > Cc: Michael Casadevall Thanks, ap

Re: [Qemu-devel] [PATCH 0/7] alpha-linux syscall fixes

2010-05-21 Thread Aurelien Jarno
On Mon, May 03, 2010 at 10:07:48AM -0700, Richard Henderson wrote: > I've been doing a bit of testing of the alpha TCG port by running > QEMU compiled for alpha on QEMU compiled for x86-64. Which is an > interesting challenge for the linux-user code, and has found a > few bugs. > > > r~ > > >

Re: [Qemu-devel] [PATCH 0/5] tcg: Initialize prologue after guest_base fixed

2010-05-21 Thread Aurelien Jarno
On Thu, May 06, 2010 at 08:50:40AM -0700, Richard Henderson wrote: > By doing this we can make any number of decisions about code generation > during the prologue. For instance, we can decide whether or not to > reserve a register to hold the value of GUEST_BASE. > > This fixes a latent bug in th

Re: [Qemu-devel] [PATCH 0/5] tcg-i386: tidy softmmu code

2010-05-21 Thread Richard Henderson
On 05/21/2010 09:02 AM, Richard Henderson wrote: > This is sort-of part 2 of the patch series that I just edited and > re-posted for you. The majority of the patch series deals with > the SOFTMMU code. Gah. Sorry for the re-post of parts 10-15 of the previous series. r~

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-21 Thread Richard Henderson
On 05/21/2010 09:46 AM, Aurelien Jarno wrote: >> +tcg_out_reloc(NULL, NULL, 0, 0, 0); >> } >> > > What about declaring tcg_out_reloc static inline? I think we're not far away from a mergable s390 port. I think the smallest local change is best in the interim. r~

Re: [Qemu-devel] Re: lsi: Handle removal of selected devices

2010-05-21 Thread Aurelien Jarno
On Fri, May 21, 2010 at 05:49:26PM +0200, Aurelien Jarno wrote: > This patch: > > 64d564094cac5f72eeaeb950c442b773a00d3586 is the first bad commit > commit 64d564094cac5f72eeaeb950c442b773a00d3586 > Author: Jan Kiszka > Date: Tue May 4 14:21:03 2010 +0200 > > lsi: Handle removal of selecte

[Qemu-devel] Re: [PATCH] add support for protocol driver create_options

2010-05-21 Thread Kevin Wolf
Am 20.05.2010 07:36, schrieb MORITA Kazutaka: > This patch enables protocol drivers to use their create options which > are not supported by the format. For example, protcol drivers can use > a backing_file option with raw format. > > Signed-off-by: MORITA Kazutaka > --- > block.c |7

[Qemu-devel] [PATCH] lsi: Fix value overflow in request tag processing

2010-05-21 Thread Jan Kiszka
This fixes a mismerge of 64d564094cac5f72eeaeb950c442b773a00d3586 (wrong patch version): We need to mask the tag value properly to obtain its device ID. Signed-off-by: Jan Kiszka --- hw/lsi53c895a.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/

Re: [Qemu-devel] Re: lsi: Handle removal of selected devices

2010-05-21 Thread Aurelien Jarno
Jan Kiszka a écrit : > Aurelien Jarno wrote: >> On Fri, May 21, 2010 at 05:49:26PM +0200, Aurelien Jarno wrote: >>> This patch: >>> >>> 64d564094cac5f72eeaeb950c442b773a00d3586 is the first bad commit >>> commit 64d564094cac5f72eeaeb950c442b773a00d3586 >>> Author: Jan Kiszka >>> Date: Tue May 4

[Qemu-devel] [PATCH] alpha-linux-user: Fill in SI_CODE for SIGSEGV.

2010-05-21 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index b240f29..de1076b 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -2433,7 +2433,8 @@ void cpu_loop (CPUState *env)

Re: [Qemu-devel] Re: lsi: Handle removal of selected devices

2010-05-21 Thread Jan Kiszka
Aurelien Jarno wrote: > On Fri, May 21, 2010 at 05:49:26PM +0200, Aurelien Jarno wrote: >> This patch: >> >> 64d564094cac5f72eeaeb950c442b773a00d3586 is the first bad commit >> commit 64d564094cac5f72eeaeb950c442b773a00d3586 >> Author: Jan Kiszka >> Date: Tue May 4 14:21:03 2010 +0200 >> >>

[Qemu-devel] [PATCH] Fix --enable-user-pie compilation.

2010-05-21 Thread Richard Henderson
We forgot to propagate -fpie to the libdis-user directory. Signed-off-by: Richard Henderson --- configure |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 3cd2c5f..ba3aaac 100755 --- a/configure +++ b/configure @@ -2355,6 +2355,9 @@ for d in

Re: [Qemu-devel] linux-user mmap bug

2010-05-21 Thread Richard Henderson
On 05/21/2010 06:28 AM, Edgar E. Iglesias wrote: > ptr = mmap(g2h(addr), size, PROT_NONE, > - MAP_ANONYMOUS|MAP_PRIVATE|MAP_NORESERVE, -1, 0); > + /* When the kernel returns addresses that the guest > + cannot use we might need to fa

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Anthony Liguori wrote: > On 05/21/2010 08:46 AM, Jan Kiszka wrote: >> Anthony Liguori wrote: >> >>> On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: >>> Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember

Re: [Qemu-devel] [PATCH 00/15] tcg-i386 cleanup and improvement, v3

2010-05-21 Thread Aurelien Jarno
On Fri, May 21, 2010 at 08:30:20AM -0700, Richard Henderson wrote: > Changes v2->v3: > * ext8u and ext8s operate on 'q' register inputs only. > * pushi is inline and loses the ifdef. > * trailing whitespace cleanup > > > r~ > > > Richard Henderson (15): > tcg-i386: Tidy ext8u and ext16u

  1   2   >