Re: [Qemu-devel] [PATCH] Fix cross compilation

2010-05-19 Thread Aurelien Jarno
On Tue, May 18, 2010 at 10:12:54PM +0200, Stefan Weil wrote: > Am 18.05.2010 19:43, schrieb Aurelien Jarno: > >On Sun, Apr 11, 2010 at 06:44:18PM +0200, Stefan Weil wrote: > >>This patch enhances the algorithm which finds the correct settings for SDL. > >>For cross compilations (when cross_prefix i

[Qemu-devel] Re: [PATCH 2/3] Fix __VA__ARGS__ typo in cris mmu.c

2010-05-19 Thread Edgar E. Iglesias
On Wed, May 19, 2010 at 06:49:29PM +0200, Riccardo Magliocchetti wrote: > Fix compilation with DEBUG defined > > Signed-off-by: Riccardo Magliocchetti Thanks, applied. Cheers > --- > target-cris/mmu.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-cri

[Qemu-devel] [PATCH v2] Release usb devices on shutdown and usb_del command

2010-05-19 Thread Shahar Havivi
When closig Vm or removing usb on guest via usb_del monitor command, qemu does not return the control to the host, the user have to unplug and plug the device in order to use it on the host. v2: added empty methods to usb-bsd and usb-stub. release usb devices when main is out. Signed-off-by: Shah

Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operations.

2010-05-19 Thread Richard Henderson
On 05/18/2010 11:47 PM, Aurelien Jarno wrote: > The reg allocator is able to issue move if needed, so the only > improvement this patch is for doing a ext8u on both "q" registers. > > OTOH the reg allocator knows this situation and will try to avoid this > situation during the allocation. Cheating

[Qemu-devel] [PATCH 0/3] Cleanup usage of DEBUG name

2010-05-19 Thread Riccardo Magliocchetti
Some files use DEBUG as a preprocessor conditionals to enable debug code and i find handy to pass -DDEBUG as extra cflags at configure time. Unfortunately this cannot be done if DEBUG name is used for other purposes. Riccardo Magliocchetti (3): Rename DEBUG field to TC_DEBUG to avoid name clashe

[Qemu-devel] [PATCH 3/3] Rename DEBUG define to E1000_DEBUG to avoid name clashes

2010-05-19 Thread Riccardo Magliocchetti
Some files use DEBUG as a preprocessor conditionals to enable debug code and i find handy to pass -DDEBUG as extra cflags at configure time. Unfortunately this cannot be done if DEBUG name is used for other purposes. Signed-off-by: Riccardo Magliocchetti --- hw/e1000.c |4 ++-- 1 files chang

[Qemu-devel] [PATCH 2/3] Rename DEBUG macro to MSIX_LOG to avoid name clashes

2010-05-19 Thread Riccardo Magliocchetti
Some files use DEBUG as a preprocessor conditionals to enable debug code and i find handy to pass -DDEBUG as extra cflags at configure time. Unfortunately this cannot be done if DEBUG name is used for other purposes. Signed-off-by: Riccardo Magliocchetti --- hw/msix.c |4 ++-- 1 files change

[Qemu-devel] [PATCH 1/3] Rename DEBUG field to TC_DEBUG to avoid name clashes

2010-05-19 Thread Riccardo Magliocchetti
Some files use DEBUG as a preprocessor conditionals to enable debug code and i find handy to pass -DDEBUG as extra cflags at configure time. Unfortunately this cannot be done if DEBUG name is used for other purposes. Signed-off-by: Riccardo Magliocchetti --- hw/tc6393xb.c |8 1 file

Re: [Qemu-devel] [PATCH v2] Release usb devices on shutdown and usb_del command

2010-05-19 Thread David S. Ahern
On 05/19/2010 12:10 PM, Shahar Havivi wrote: > When closig Vm or removing usb on guest via usb_del monitor command, > qemu does not return the control to the host, the user have to > unplug and plug the device in order to use it on the host. > > v2: > added empty methods to usb-bsd and usb-stub.

[Qemu-devel] [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Christoph Hellwig
The difference between the start sectors of two requests can be larger than the size of the "int" type, which can lead to a not correctly sorted multiwrite array and thus spurious I/O errors and filesystem corruption due to incorrect request merges. So instead of doing the cute sector arithmetics

[Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-19 Thread Blue Swirl
On 5/19/10, Gerd Hoffmann wrote: > > > > > > > > > Then there would be no need of parsing. > > > > > > > > > > You would need _two_ bitmaps (e.g. mask and cursor, so that mask=1 > gives > > > transparent, mask=0 cursor=0 gives black and mask=0 cursor=1 gives > white). > > > > > > > Yes, but it's

Re: [Qemu-devel] Latest git does not compile target_to_host_rlim()

2010-05-19 Thread Riccardo Magliocchetti
Il 19/05/2010 19:19, Aurelien Jarno ha scritto: On Wed, May 19, 2010 at 07:09:55PM +0200, Riccardo Magliocchetti wrote: Il 19/05/2010 18:38, Aurelien Jarno ha scritto: On Wed, May 19, 2010 at 01:51:35PM +0200, Riccardo Magliocchetti wrote: Hello, latest git does not compile on debian sid 32 b

[Qemu-devel] Re: [PATCH 0/3] Fix ADDX compilation plus improvements, v2

2010-05-19 Thread Blue Swirl
On 5/19/10, Richard Henderson wrote: > http://lists.nongnu.org/archive/html/qemu-devel/2010-05/msg00922.html > > I would appreciate it if you would at least apply the first patch > from this series. The sparc target has been broken for a week. Okay. My setups don't have any problems and I was

Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-19 Thread Anthony Liguori
On 05/19/2010 01:57 PM, Blue Swirl wrote: On 5/19/10, Gerd Hoffmann wrote: Then there would be no need of parsing. You would need _two_ bitmaps (e.g. mask and cursor, so that mask=1 gives transparent, mask=0 cursor=0 gives black and mask=0

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-05-19 Thread Blue Swirl
On 5/19/10, Daniel P. Berrange wrote: > The system emulators for each arch are using inconsistent > naming for the default PCI bus "pci" vs "pci.0". Since it > is conceivable we'll have multiple PCI buses in the future > standardize on "pci.0" for all architectures. This ensures > mgmt apps ca

Re: [Qemu-devel] [PATCH 1/3] Fix %lld or %llx printf format use

2010-05-19 Thread Blue Swirl
On 5/17/10, Markus Armbruster wrote: > Blue Swirl writes: > > > Signed-off-by: Blue Swirl > > --- > > audio/audio_template.h |2 +- > > block/curl.c|9 --- > > block/parallels.c |7 - > > block/qcow2.c |8 -- > > darwin-user/commpa

[Qemu-devel] [PATCH] Fix %lld or %llx printf format use

2010-05-19 Thread Blue Swirl
Signed-off-by: Blue Swirl --- audio/audio_template.h |2 +- block/curl.c| 14 ++- block/qcow2.c |8 -- darwin-user/commpage.c |2 +- darwin-user/syscall.c |2 +- hw/vga.c|2 +- hw/vhost_net.c |2 +- ia64-dis.

[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Michael Tokarev
19.05.2010 22:53, Christoph Hellwig wrote: The difference between the start sectors of two requests can be larger than the size of the "int" type, which can lead to a not correctly sorted multiwrite array and thus spurious I/O errors and filesystem corruption due to incorrect request merges. So

[Qemu-devel] [RFC PATCH 0/1] ceph/rbd block driver for qemu-kvm

2010-05-19 Thread Christian Brunner
Hi, this patch is a block driver for the distributed file system Ceph (http://ceph.newdream.net/). Ceph was included in the Linux v2.6.34 kernel. However, this driver uses librados (which is part of the Ceph server) for direct access to the Ceph object store and is running entirely in userspace. T

[Qemu-devel] [Bug 575887] Re: VNC heap corruption at 1400x1050 (with % 16 != 0)

2010-05-19 Thread Anthony Liguori
Marking this invalid against qemu as it doesn't support that non- standard VESA resolution. ** Changed in: qemu Status: New => Confirmed ** Changed in: qemu Importance: Undecided => High ** Changed in: qemu Status: Confirmed => Invalid -- VNC heap corruption at 1400x1050 (with

[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Christoph Hellwig
On Wed, May 19, 2010 at 11:26:58PM +0400, Michael Tokarev wrote: > Now the question is if the previous patch by Avi is actually > worth to apply -- I mean this one: > [Qemu-devel] [PATCH +stable] block: don't attempt to merge overlapping > requests No, that was just a hack, it shouldn't be appl

[Qemu-devel] Re: kvm: network problem with Solaris 10u8 guest

2010-05-19 Thread Michael Tokarev
19.05.2010 21:09, Avi Kivity wrote: On 05/19/2010 04:46 PM, Harald Dunkel wrote: I am trying to run Solaris 10u8 as a guest in kvm (kernel 2.6.33.2). Problem: The virtual network devices don't work with this Solaris version. e1000 and pcnet work just by chance, as it seems. I can ping the guest

[Qemu-devel] [Bug 583025] [NEW] test bug

2010-05-19 Thread Anthony Liguori
Public bug reported: asdf ** Affects: qemu Importance: Undecided Status: New -- test bug https://bugs.launchpad.net/bugs/583025 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Bug description: asdf

[Qemu-devel] [Bug 521994] Re: Windows 98 doesn't detect mouse on qemu and SeaBIOS.

2010-05-19 Thread Anthony Liguori
** Changed in: qemu Status: New => Confirmed -- Windows 98 doesn't detect mouse on qemu and SeaBIOS. https://bugs.launchpad.net/bugs/521994 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Confirmed Bug descriptio

[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Michael Tokarev
19.05.2010 23:38, Christoph Hellwig wrote: On Wed, May 19, 2010 at 11:26:58PM +0400, Michael Tokarev wrote: Now the question is if the previous patch by Avi is actually worth to apply -- I mean this one: [Qemu-devel] [PATCH +stable] block: don't attempt to merge overlapping requests No, th

[Qemu-devel] Bug mail

2010-05-19 Thread Anthony Liguori
I've set up launchpad to automatically mail the list for bug traffic. If this gets to be too much traffic, I can make a separate list. Regards, Anthony Liguori

[Qemu-devel] Re: KVM call agenda for May 18

2010-05-19 Thread Anthony Liguori
On 05/19/2010 03:20 AM, Christoph Hellwig wrote: On Tue, May 18, 2010 at 08:52:36AM -0500, Anthony Liguori wrote: This should be filed in launchpad as a qemu bug and it should be tested against the latest git. This bug sounds like we're using an int to represent sector offset somewhere but

Re: [Qemu-devel] Re: [PATCH 0/3] Fix ADDX compilation plus improvements, v2

2010-05-19 Thread Artyom Tarasenko
2010/5/19 Blue Swirl : > On 5/19/10, Richard Henderson wrote: >> http://lists.nongnu.org/archive/html/qemu-devel/2010-05/msg00922.html >> >>  I would appreciate it if you would at least apply the first patch >>  from this series.  The sparc target has been broken for a week. > > Okay. My setups do

[Qemu-devel] [Bug 583025] Re: test bug

2010-05-19 Thread Anthony Liguori
** Changed in: qemu Status: New => Invalid -- test bug https://bugs.launchpad.net/bugs/583025 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Invalid Bug description: asdf

[Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-19 Thread Christian Brunner
The attached patch is a block driver for the distributed file system Ceph (http://ceph.newdream.net/). This driver uses librados (which is part of the Ceph server) for direct access to the Ceph object store and is running entirely in userspace. Therefore it is called "rbd" - rados block device. To

[Qemu-devel] [PATCH] linux-user: Fix compilation with DEBUG defined

2010-05-19 Thread Riccardo Magliocchetti
Signed-off-by: Riccardo Magliocchetti --- linux-user/flatload.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/flatload.c b/linux-user/flatload.c index 6a2c3f9..914de1f 100644 --- a/linux-user/flatload.c +++ b/linux-user/flatload.c @@ -338,7 +338,7 @@ failed:

[Qemu-devel] [Bug 393430] Re: kvm: use PulseAudio instead of ALSA

2010-05-19 Thread Dustin Kirkland
Hmm, I think upstream does prioritize pa over alsa. Marking incomplete, need to check that. ** Changed in: qemu Status: New => Incomplete -- kvm: use PulseAudio instead of ALSA https://bugs.launchpad.net/bugs/393430 You received this bug notification because you are a member of qemu- dev

[Qemu-devel] Re: [PATCH 10/12] kvm: enable smp > 1

2010-05-19 Thread Udo Lembke
Avi Kivity schrieb: On 05/19/2010 12:57 PM, Udo Lembke wrote: Jan Kiszka schrieb: ... --enable-io-thread? If you had it disabled, it would also answer my question if -smp works without problems without that feature. Jan Hi, i have a dumb question: what is the "--enable-io-thread"? Is this a

[Qemu-devel] [Bug 521994] Re: Windows 98 doesn't detect mouse on qemu and SeaBIOS.

2010-05-19 Thread Natalia Portillo
I confirm this same bug appears in Windows 95, Windows Me and several XFree86 and X.Org versions, as well as DOS based Microsoft Mouse drivers. -- Windows 98 doesn't detect mouse on qemu and SeaBIOS. https://bugs.launchpad.net/bugs/521994 You received this bug notification because you are a membe

[Qemu-devel] [Bug 393430] Re: kvm: use PulseAudio instead of ALSA

2010-05-19 Thread Dustin Kirkland
Hmm, I think upstream does prioritize pa over alsa. Marking incomplete, need to check that. -- kvm: use PulseAudio instead of ALSA https://bugs.launchpad.net/bugs/393430 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: I

[Qemu-devel] [Bug 393430] Re: kvm: use PulseAudio instead of ALSA

2010-05-19 Thread Arie Skliarouk
KVM on lucid appears to prioritize pa: #kvm -audio-help | grep ^Name Name: pa Name: alsa Name: sdl Name: oss Name: none Name: wav but in effect alsa is still used... could it be related to the fact that by default pulse-audio daemon is started per user, whereas kvm starts the virtual machines befo

[Qemu-devel] [PATCH] block: Fix compilation with DEBUG defined

2010-05-19 Thread Riccardo Magliocchetti
gcc does not like passing a NULL where an int value is expected: block/vvfat.c: In function ‘checkpoint’: block/vvfat.c:2868: error: passing argument 2 of ‘remove_mapping’ makes integer from pointer without a cast Signed-off-by: Riccardo Magliocchetti --- block/vvfat.c |2 +- 1 files chan

Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Kevin Wolf
Am Mittwoch, 19. Mai 2010 21:42 schrieb Michael Tokarev: > 19.05.2010 23:38, Christoph Hellwig wrote: > > On Wed, May 19, 2010 at 11:26:58PM +0400, Michael Tokarev wrote: > >> Now the question is if the previous patch by Avi is actually > >> worth to apply -- I mean this one: > >> [Qemu-devel] [P

[Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-19 Thread Luiz Capitulino
Hi Anthony, While investigating a QMP bug reported by a user, I've found a few issues in our parser/lexer. The patches in this series fix the problems I was able to solve, but we still have the following issues: 1. Our 'private extension' is open to the public Eg. The following input issu

[Qemu-devel] [PATCH 1/6] json-lexer: Initialize 'x' and 'y'

2010-05-19 Thread Luiz Capitulino
The 'lexer' variable is passed by the caller, it can contain anything (eg. garbage). Signed-off-by: Luiz Capitulino --- json-lexer.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/json-lexer.c b/json-lexer.c index 9d64920..0b145d1 100644 --- a/json-lexer.c +++ b/json-le

[Qemu-devel] [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-19 Thread Luiz Capitulino
The JSON escape sequence "\/" and "\\" are valid and should be handled. Signed-off-by: Luiz Capitulino --- json-lexer.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/json-lexer.c b/json-lexer.c index 0b145d1..5cc7e6c 100644 --- a/json-lexer.c +++ b/json-lexer.c @@ -

[Qemu-devel] [PATCH 4/6] check-qjson: Add more escape tests

2010-05-19 Thread Luiz Capitulino
While there make the fail_unless() calls print error messages. IMPORTANT: The test for "\/" is failing, don't know why. Signed-off-by: Luiz Capitulino --- check-qjson.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/check-qjson.c b/check-qjson.c index 109

[Qemu-devel] [PATCH 3/6] qjson: Handle "\f"

2010-05-19 Thread Luiz Capitulino
It's valid JSON and should be handled. Signed-off-by: Luiz Capitulino --- json-parser.c |4 qjson.c |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/json-parser.c b/json-parser.c index b55d763..83212bc 100644 --- a/json-parser.c +++ b/json-parser.c @@ -20

[Qemu-devel] [PATCH 6/6] json-streamer: Don't use qdict_put_obj()

2010-05-19 Thread Luiz Capitulino
It's not needed, use qobject_put() instead and get a cleaner code. Signed-off-by: Luiz Capitulino --- json-streamer.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/json-streamer.c b/json-streamer.c index 610ffea..f7e7a68 100644 --- a/json-streamer.c +++ b/json-s

[Qemu-devel] [PATCH 5/6] json-lexer: Drop 'buf'

2010-05-19 Thread Luiz Capitulino
QString supports adding a single char, 'buf' is unneeded. Signed-off-by: Luiz Capitulino --- json-lexer.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/json-lexer.c b/json-lexer.c index 5cc7e6c..1d9b81f 100644 --- a/json-lexer.c +++ b/json-lexer.c @@ -284,8 +284,

Re: [Qemu-devel] [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-19 Thread Anthony Liguori
On 05/19/2010 04:15 PM, Luiz Capitulino wrote: The JSON escape sequence "\/" and "\\" are valid and should be handled. Signed-off-by: Luiz Capitulino Good catch. --- json-lexer.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/json-lexer.c b/json-lexer.c in

Re: [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-19 Thread Anthony Liguori
On 05/19/2010 04:15 PM, Luiz Capitulino wrote: Hi Anthony, While investigating a QMP bug reported by a user, I've found a few issues in our parser/lexer. The patches in this series fix the problems I was able to solve, but we still have the following issues: 1. Our 'private extension' is

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-19 Thread Andre Przywara
Michael Tokarev wrote: ... Also, thanks to Andre Przywara, whole winNT thing works but it requires -cpu qemu64,level=1 (or level=2 or =3), -- _not_ with default CPU. This is also testing, but it's not obvious what to do witht the result... Can't we use the file based CPU models for that? Actual

[Qemu-devel] [PATCH] kvm: Switch kvm_update_guest_debug to run_on_cpu

2010-05-19 Thread Jan Kiszka
From: Jan Kiszka Guest debugging under KVM is currently broken once io-threads are enabled. Easily fixable by switching the fake on_vcpu to the real run_on_cpu implementation. Signed-off-by: Jan Kiszka --- kvm-all.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-) diff -

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-19 Thread Anthony Liguori
On 05/19/2010 05:29 PM, Andre Przywara wrote: Michael Tokarev wrote: ... Also, thanks to Andre Przywara, whole winNT thing works but it requires -cpu qemu64,level=1 (or level=2 or =3), -- _not_ with default CPU. This is also testing, but it's not obvious what to do witht the result... Can't we

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-19 Thread Michael S. Tsirkin
On Wed, May 19, 2010 at 11:06:42AM +0300, Avi Kivity wrote: > On 05/19/2010 10:39 AM, Rusty Russell wrote: >> >> I think we're talking about the last 2 entries of the avail ring. That means >> the worst case is 1 false bounce every time around the ring. > > It's low, but why introduce an inefficie

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-19 Thread Rusty Russell
On Wed, 19 May 2010 05:36:42 pm Avi Kivity wrote: > > Note that this is a exclusive->shared->exclusive bounce only, too. > > > > A bounce is a bounce. I tried to measure this to show that you were wrong, but I was only able to show that you're right. How annoying. Test code below. > Virtio

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-19 Thread Rusty Russell
On Thu, 20 May 2010 02:31:50 pm Rusty Russell wrote: > On Wed, 19 May 2010 05:36:42 pm Avi Kivity wrote: > > > Note that this is a exclusive->shared->exclusive bounce only, too. > > > > > > > A bounce is a bounce. > > I tried to measure this to show that you were wrong, but I was only able >

[Qemu-devel] [PATCH] add support for protocol driver create_options

2010-05-19 Thread MORITA Kazutaka
This patch enables protocol drivers to use their create options which are not supported by the format. For example, protcol drivers can use a backing_file option with raw format. Signed-off-by: MORITA Kazutaka --- block.c |7 +++ block.h |1 + qemu-img.c| 49 ++

[Qemu-devel] Kvm device passthrough

2010-05-19 Thread Mu Lin
Hi, Folks: Could you provide pointer to the kvm device passthrough howto/FAQ? I have two questions: 1. my host os, the Linux doesn't have the native device driver for some home grown pci devices, the driver is in the guest os, does device passthrough work in this case? Assuming I have VT-d. 2

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-19 Thread Michael Tokarev
20.05.2010 02:30, Anthony Liguori wrote: On 05/19/2010 05:29 PM, Andre Przywara wrote: Michael Tokarev wrote: ... Also, thanks to Andre Przywara, whole winNT thing works but it requires -cpu qemu64,level=1 (or level=2 or =3), -- _not_ with default CPU. This [] It'd be nice if we had more fle

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-19 Thread Avi Kivity
On 05/20/2010 01:33 AM, Michael S. Tsirkin wrote: Virtio is already way too bouncy due to the indirection between the avail/used rings and the descriptor pool. A device with out of order completion (like virtio-blk) will quickly randomize the unused descriptor indexes, so every descriptor fetc

Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Avi Kivity
On 05/20/2010 12:09 AM, Kevin Wolf wrote: Actually it's not that obvious. If the actual problem here (besides the mis-comparison) is due to missing barriers or flushes. Avi asked a good question in that thread. It's obvious that it's a hack. It doesn't fix anything, it just disables a

[Qemu-devel] Re: [PATCH 10/12] kvm: enable smp > 1

2010-05-19 Thread Avi Kivity
On 05/19/2010 11:02 PM, Udo Lembke wrote: Unrelated, what are your smp issues? If i use one cpu i got a good io-performance: e.g. over 500MB/s at the profile "install" of the io-benchmark h2benchw.exe. ( aio=threads | SAS-Raid-0 | ftp://ftp.heise.de/pub/ct/ctsi/h2benchw.zip | hwbenchw.exe -p

[Qemu-devel] [PATCH] pc: fix segfault introduced by 3d53f5c36ff6

2010-05-19 Thread Eduard - Gabriel Munteanu
Commit 3d53f5c36ff6 introduced a segfault by erroneously making fw_cfg a 'void **' and passing it around in different ways. Signed-off-by: Eduard - Gabriel Munteanu --- hw/pc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index fee08c9..4a4a706 10

<    1   2