[Qemu-devel] Re: [PATCH 2/2][qemu-iotests] test bdrv_truncate()

2010-04-26 Thread Kevin Wolf
Am 24.04.2010 10:20, schrieb Stefan Hajnoczi: > This patch adds an image resize grow test to ensure that existing data > is not lost during grow and new space is zeroed. > > Signed-off-by: Stefan Hajnoczi > --- > 025 | 73 > +++ >

[Qemu-devel] About mips r3000 support

2010-04-26 Thread Michael Qiu
Hi guys, Seems there is no r3000 support since qemu use tcg. Unfortunately, I want to build a vm for a r3000 based soc these days, and I don't want to use older qemu versions which depends on a certain gcc version. Can anyone tell me how to port r3000 support back to new qemu versions? Or there is

[Qemu-devel] Re: [PATCH 1/2][qemu-iotests] explicitly use bash interpreter

2010-04-26 Thread Christoph Hellwig
On Sat, Apr 24, 2010 at 09:20:18AM +0100, Stefan Hajnoczi wrote: > The tests use bash language features like 'let', which aren't supported > by /bin/sh on systems that use a conservative shell like dash. This > patch changes the interpreter to /bin/bash. > > Signed-off-by: Stefan Hajnoczi Thank

[Qemu-devel] Re: [PATCH 2/2][qemu-iotests] test bdrv_truncate()

2010-04-26 Thread Christoph Hellwig
On Sat, Apr 24, 2010 at 09:20:19AM +0100, Stefan Hajnoczi wrote: > This patch adds an image resize grow test to ensure that existing data > is not lost during grow and new space is zeroed. Look good, but I'll wait for the qcow2 truncate support to hit mainline to apply this.

Re: [Qemu-devel] [PATCH] target-ppc: exception model of 603e inherits from 603

2010-04-26 Thread Thomas Monjalon
Andreas Färber wrote: > Am 23.04.2010 um 11:44 schrieb Thomas Monjalon: > > It appears that the exception handling of 603e is the same as 603. > > So it could be removed safely. > > Are you referring to some ppc manual or to the current code base? I'm referring to the current code base. I don't t

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Daniel P. Berrange
On Sun, Apr 25, 2010 at 08:53:17PM -0500, Anthony Liguori wrote: > On 04/25/2010 06:51 AM, Avi Kivity wrote: > > Qemu is special due to the nonexistence of qemud. > > > >Why is sVirt implemented in libvirt? it's not the logical place for > >it; rather the logical place doesn't exist. > > sVirt

[Qemu-devel] [PATCH v2][qemu-iotests] test bdrv_truncate()

2010-04-26 Thread Stefan Hajnoczi
This patch adds an image resize grow test to ensure that existing data is not lost during grow and new space is zeroed. Signed-off-by: Stefan Hajnoczi --- v2: * Check length before and after truncate operation on opened image 025 | 77 +

[Qemu-devel] Re: [RFC PATCH 04/20] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2010-04-26 Thread Yoshiaki Tamura
Avi Kivity wrote: On 04/23/2010 12:59 PM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Why is this needed? The real buffering is in the kernel anyways; this is only us

[Qemu-devel] Re: [RFC PATCH 07/20] Introduce qemu_put_vector() and qemu_put_vector_prepare() to use put_vector() in QEMUFile.

2010-04-26 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/22/2010 11:02 PM, Yoshiaki Tamura wrote: Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: For fool proof purpose, qemu_put_vector_parepare should be called before qemu_put_vector. Then, if qemu_put_* functions except this is called after qemu_p

[Qemu-devel] Re: [PATCH v4 0/4] Introduce bit-based phys_ram_dirty, and bit-based dirty page checker.

2010-04-26 Thread Yoshiaki Tamura
Hi, Here are some numbers on bit-based phys_ram_dirty. Test Environment: CPU: 4x Intel Xeon Quad Core 2.66GHz Mem size: 96GB Host OS: CentOS (kernel 2.6.33) Guest OS: Debian/GNU Linux lenny (kernel 2.6.26) Guest Mem size: 512MB Conditions of experiments are as follows: Cond1: Guest OS periodic

[Qemu-devel] Re: [RFC PATCH 05/20] Introduce put_vector() and get_vector to QEMUFile and qemu_fopen_ops().

2010-04-26 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/22/2010 10:37 PM, Yoshiaki Tamura wrote: Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: QEMUFile currently doesn't support writev(). For sending multiple data, such as pages, using writev() should be more efficient. Signed-off-by: Yoshiaki T

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-26 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/22/2010 08:53 PM, Yoshiaki Tamura wrote: Anthony Liguori wrote: On 04/22/2010 08:16 AM, Yoshiaki Tamura wrote: 2010/4/22 Dor Laor: On 04/22/2010 01:35 PM, Yoshiaki Tamura wrote: Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Hi all, We have bee

[Qemu-devel] Re: [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-26 Thread Yoshiaki Tamura
Avi Kivity wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Kemari starts synchronizing VMs when QEMU handles I/O requests. Without this patch VCPU state is already proceeded before synchronization, and after failover to the VM on the receiver, it hangs because of this. We discussed movin

[Qemu-devel] Re: [PATCH 2/2] qcow2: Implement bdrv_truncate() for growing images

2010-04-26 Thread Kevin Wolf
Am 24.04.2010 10:12, schrieb Stefan Hajnoczi: > This patch adds the ability to grow qcow2 images in-place using > bdrv_truncate(). This enables qemu-img resize command support for > qcow2. > > Snapshots are not supported and bdrv_truncate() will return -ENOTSUP. > The notion of resizing an image

Re: [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number

2010-04-26 Thread Jamie Lokier
Michael Tokarev wrote: > 24.04.2010 17:05, Andreas Färber wrote: > >Am 22.04.2010 um 11:40 schrieb Michael Tokarev: > > > >>11.03.2010 18:34, Michael Tokarev wrote: > >>[] > On version 0.12.3, -drive serial=XXX option does not work. > Below patch fixes it. 'serial' is pointer, not array. >

[Qemu-devel] Re: [PATCH 1/2] qemu-img: Add 'resize' command to grow/shrink disk images

2010-04-26 Thread Kevin Wolf
Am 24.04.2010 10:12, schrieb Stefan Hajnoczi: > This patch adds a 'resize' command to grow/shrink disk images. This > allows changing the size of disk images without copying to a new image > file. Currently only raw files support resize. > > Signed-off-by: Stefan Hajnoczi Thanks, applied to th

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-26 Thread Jamie Lokier
Daniel P. Berrange wrote: > > Much better to exact a commitment from libvirt to track all QMP (and > > command line) capabilities. Instead of adding cleverness to QMP, add > > APIs to libvirt. > > Agreed. Despite adding this monitor / XML passthrough capability, we still > do not want apps to b

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/26/2010 04:59 AM, Daniel P. Berrange wrote: On Sun, Apr 25, 2010 at 08:53:17PM -0500, Anthony Liguori wrote: On 04/25/2010 06:51 AM, Avi Kivity wrote: Qemu is special due to the nonexistence of qemud. Why is sVirt implemented in libvirt? it's not the logical place for it; ra

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/25/2010 09:50 AM, Avi Kivity wrote: On 04/23/2010 09:33 PM, Anthony Liguori wrote: This is a different ambiguity, about the semantic results of the commands, where as I'm refering to the execution order. If I look at a libvirt log file and see a set of JSON commands logged, I want to know

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/26/2010 12:56 AM, Avi Kivity wrote: On 04/26/2010 04:53 AM, Anthony Liguori wrote: On 04/25/2010 06:51 AM, Avi Kivity wrote: It depends on what things you think are important. A lot of libvirt's complexity is based on the fact that it uses a daemon and needs to deal with the security im

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Daniel P. Berrange
On Mon, Apr 26, 2010 at 08:13:03AM -0500, Anthony Liguori wrote: > On 04/26/2010 04:59 AM, Daniel P. Berrange wrote: > >On Sun, Apr 25, 2010 at 08:53:17PM -0500, Anthony Liguori wrote: > > > >>On 04/25/2010 06:51 AM, Avi Kivity wrote: > >> > >>> Qemu is special due to the nonexistence of q

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Avi Kivity
On 04/26/2010 04:14 PM, Anthony Liguori wrote: IOW, libvirt does not run guests as separate users which is why it needs to deal with security in the first place. What if one user has multiple guests? isolation is still needed. Don't confuse a management application's concept of users with

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/26/2010 08:31 AM, Daniel P. Berrange wrote: What you describe is not inherant to the daemon model. This is why we have two separate models in libvirt. The system instance is pre-spawned with high privileges, to allow use of hosts resources which require high privileges to access. The sessio

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/26/2010 08:41 AM, Avi Kivity wrote: Today, you have to make changes to libvirt whereas in a direct launch model, you get all of the neat security features linux supports for free. But you lose tap networking, unless you have a privileged helper. And how is the privileged helper to auth

[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots

2010-04-26 Thread Marcelo Tosatti
On Sun, Apr 25, 2010 at 05:17:55PM +0300, Avi Kivity wrote: > On 04/25/2010 04:57 PM, Jan Kiszka wrote: > > > >>It's still a good idea. The current API assumes that there will be only > >>one slot-based client (or that multiple clients will keep the refcount > >>themselves). > >> > >>After the byt

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Avi Kivity
On 04/26/2010 04:46 PM, Anthony Liguori wrote: (3) The system management application can certainly create whatever context it wants to launch a vm from. It's comes down to who's responsible for creating the context the guest runs under. I think doing that at the libvirt level takes away a ton

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Daniel P. Berrange
On Mon, Apr 26, 2010 at 08:46:46AM -0500, Anthony Liguori wrote: > On 04/26/2010 08:41 AM, Avi Kivity wrote: > > >>(3) The system management application can certainly create whatever > >>context it wants to launch a vm from. It's comes down to who's > >>responsible for creating the context the

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Avi Kivity
On 04/26/2010 04:43 PM, Anthony Liguori wrote: The reason I lean toward the direct launch model is that it gives the user a lot of flexibility in terms of using things like namespaces, DAC, cgroups, capabilities, etc. A lot of potential features are lost when you do indirect launch because you

Re: [Qemu-devel] Re: [PATCH 2/2] qcow2: Implement bdrv_truncate() for growing images

2010-04-26 Thread Stefan Hajnoczi
On Mon, Apr 26, 2010 at 12:46 PM, Kevin Wolf wrote: > Am 24.04.2010 10:12, schrieb Stefan Hajnoczi: >> This patch adds the ability to grow qcow2 images in-place using >> bdrv_truncate().  This enables qemu-img resize command support for >> qcow2. >> >> Snapshots are not supported and bdrv_truncate

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/26/2010 09:01 AM, Avi Kivity wrote: On 04/26/2010 04:43 PM, Anthony Liguori wrote: The reason I lean toward the direct launch model is that it gives the user a lot of flexibility in terms of using things like namespaces, DAC, cgroups, capabilities, etc. A lot of potential features are l

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Avi Kivity
On 04/26/2010 05:19 PM, Anthony Liguori wrote: On 04/26/2010 09:01 AM, Avi Kivity wrote: On 04/26/2010 04:43 PM, Anthony Liguori wrote: The reason I lean toward the direct launch model is that it gives the user a lot of flexibility in terms of using things like namespaces, DAC, cgroups, capabi

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/26/2010 08:58 AM, Daniel P. Berrange wrote: On Mon, Apr 26, 2010 at 08:46:46AM -0500, Anthony Liguori wrote: On 04/26/2010 08:41 AM, Avi Kivity wrote: (3) The system management application can certainly create whatever context it wants to launch a vm from. It's comes down to w

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-26 Thread Chris Lalancette
On 04/26/2010 08:54 AM, Jamie Lokier wrote: > All the features? The qemu API is quite large already (look at all > the command line options and monitor commands). I'll be very > surprised if libvirt provides all of it that obscure apps may use. > > I'm thinking of features which are relatively o

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/26/2010 09:25 AM, Avi Kivity wrote: On 04/26/2010 05:19 PM, Anthony Liguori wrote: On 04/26/2010 09:01 AM, Avi Kivity wrote: On 04/26/2010 04:43 PM, Anthony Liguori wrote: The reason I lean toward the direct launch model is that it gives the user a lot of flexibility in terms of using th

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Daniel P. Berrange
On Mon, Apr 26, 2010 at 09:26:55AM -0500, Anthony Liguori wrote: > On 04/26/2010 08:58 AM, Daniel P. Berrange wrote: > >On Mon, Apr 26, 2010 at 08:46:46AM -0500, Anthony Liguori wrote: > > > >>On 04/26/2010 08:41 AM, Avi Kivity wrote: > >> > >> > (3) The system management application ca

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-26 Thread Avi Kivity
On 04/26/2010 05:25 PM, Chris Lalancette wrote: Right, and you are probably one of the users this work targets. But in general, for those not very familiar with virtualization/qemu, we want to steer them far clear of this API. That goes doubly true for application developers; we want them to be

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Avi Kivity
On 04/26/2010 05:28 PM, Anthony Liguori wrote: Or a library that the user-written launcher calls. Or a plugin that qemud calls. A plugin would lose the security context. It could attempt to recreate it that seems like a lot of unnecessary complexity. A plugin would create the security c

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/26/2010 09:38 AM, Avi Kivity wrote: On 04/26/2010 05:28 PM, Anthony Liguori wrote: Or a library that the user-written launcher calls. Or a plugin that qemud calls. A plugin would lose the security context. It could attempt to recreate it that seems like a lot of unnecessary complexit

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-26 Thread Avi Kivity
On 04/26/2010 05:48 PM, Anthony Liguori wrote: We could easily reuse that. Any other security context code would be custom written; so it can be written as a qemud plugin instead of a bit of code that goes before a qemu launch. I think we're mostly in agreement with respect to the need to

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-26 Thread Daniel P. Berrange
On Mon, Apr 26, 2010 at 05:34:22PM +0300, Avi Kivity wrote: > On 04/26/2010 05:25 PM, Chris Lalancette wrote: > >Right, and you are probably one of the users this work targets. But in > >general, for those not very familiar with virtualization/qemu, we want > >to steer them far clear of this API.

Re: [Qemu-devel] Re: [PATCH 2/2] qcow2: Implement bdrv_truncate() for growing images

2010-04-26 Thread Kevin Wolf
Am 26.04.2010 16:01, schrieb Stefan Hajnoczi: > From qcow_open(): > > /* read the level 1 table */ > s->l1_size = header.l1_size; > shift = s->cluster_bits + s->l2_bits; > s->l1_vm_state_index = (header.size + (1LL << shift) - 1) >> shift; > /* the L1 table must contain at least enough entries to

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/26/2010 09:54 AM, Daniel P. Berrange wrote: On Mon, Apr 26, 2010 at 05:34:22PM +0300, Avi Kivity wrote: On 04/26/2010 05:25 PM, Chris Lalancette wrote: Right, and you are probably one of the users this work targets. But in general, for those not very familiar with virtualizatio

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-26 Thread Daniel P. Berrange
On Mon, Apr 26, 2010 at 10:08:33AM -0500, Anthony Liguori wrote: > On 04/26/2010 09:54 AM, Daniel P. Berrange wrote: > >On Mon, Apr 26, 2010 at 05:34:22PM +0300, Avi Kivity wrote: > > > >>On 04/26/2010 05:25 PM, Chris Lalancette wrote: > >> > >>>Right, and you are probably one of the users

Re: [Qemu-devel] [PATCH 2/2] target-ppc: fix interrupt vectors for MPC603 and e300

2010-04-26 Thread Segher Boessenkool
970 may be a bad example in that it can't actually bring itself up -- it requires an external controller to configure it at power-up. So whatever the external controller programs into the PC is where it starts. 970 always starts at HIOR|0x00100. I don't see any mention of an initial PC value i

Re: [Qemu-devel] [PATCH 2/2] target-ppc: fix interrupt vectors for MPC603 and e300

2010-04-26 Thread Segher Boessenkool
It is explained in [e300CORERM] at chapters 5.2.3, 5.5.1.1 and 8.3.3. Clearly, the vector offset is 0x100 and the exception prefix can be 0 or 0xFFF0, depending of the MSR[IP] bit. So, yes, I'm sure the value of hreset_vector must be 0x100. But hreset_excp_prefix can change. It could be an

[Qemu-devel] [PATCH 0/9][PULL]: QMP/Monitor queue

2010-04-26 Thread Luiz Capitulino
Hi Anthony, The following QMP/Monitor patches have been sent to the list and look good to me. I have also tested most of them. The changes (since a303f9e37b87ced34e966dc2c0b7f86bc5e74035) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git for-anthony Jan Ki

[Qemu-devel] [PATCH 1/9] QError: New QERR_QMP_BAD_INPUT_OBJECT_MEMBER

2010-04-26 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 8d885cd..b6aaec7 100644 --- a/qerror.c +++ b/qerror.c @@ -173,6 +173,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 2/9] QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER

2010-04-26 Thread Luiz Capitulino
The QERR_QMP_BAD_INPUT_OBJECT error is going to be used only for two problems: the input is not an object or the "execute" key is missing. Signed-off-by: Luiz Capitulino --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index c25d551..0

[Qemu-devel] [PATCH 3/9] QError: Improve QERR_QMP_BAD_INPUT_OBJECT desc

2010-04-26 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qerror.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qerror.c b/qerror.c index b6aaec7..034c7de 100644 --- a/qerror.c +++ b/qerror.c @@ -170,7 +170,7 @@ static const QErrorStringTable qerror_table[] = { }, { .erro

[Qemu-devel] [PATCH 4/9] QMP: Check "arguments" member's type

2010-04-26 Thread Luiz Capitulino
Otherwise the following input crashes QEMU: { "execute": "migrate", "arguments": "tcp:0:4446" } Signed-off-by: Luiz Capitulino --- monitor.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 0611b29..ef84298 100644 --- a/monitor.c +++ b/monit

[Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
The 'quit' Monitor command (implemented by do_quit()) calls exit() directly, this is problematic under QMP because QEMU exits before having a chance to send the ok response. Clients don't know if QEMU exited because of a problem or because the 'quit' command has been executed. This commit fixes t

[Qemu-devel] [PATCH 6/9] monitor: Cleanup ID assignment for compat switch

2010-04-26 Thread Luiz Capitulino
From: Jan Kiszka Canonicalize the ID assignment when creating monitor devices via the legacy switch and use less easily colliding names. Signed-off-by: Jan Kiszka Signed-off-by: Luiz Capitulino --- vl.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.

[Qemu-devel] [PATCH 7/9] monitor: Reorder intialization to drop initial mux focus

2010-04-26 Thread Luiz Capitulino
From: Jan Kiszka So far a multiplexed monitor started disabled. Restore this property for the new way of configuring by moving the monitor initialization before all devices (the last one to attach to a char-mux will gain the focus). Once we have a real use case for that, we may also consider ass

[Qemu-devel] [PATCH 8/9] chardev: Document mux option

2010-04-26 Thread Luiz Capitulino
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Luiz Capitulino --- qemu-options.hx | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index f4b3bfe..83b54c3 100644 --- a/qemu-options.hx +++ b

[Qemu-devel] [PATCH 9/9] stash away SCM_RIGHTS fd until a getfd command arrives

2010-04-26 Thread Luiz Capitulino
From: Paolo Bonzini If there is already a fd in s->msgfd before recvmsg it is closed by parts that this patch does not touch. So, only one descriptor can be "leaked" by attaching it to a command other than getfd. Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- monitor.c |

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-26 Thread Anthony Liguori
On 04/26/2010 10:20 AM, Daniel P. Berrange wrote: For the sake of my analogy, I'd still group cairo in with gtk, not x11. It is really just a re-implmentation of the GDK drawing layer from GTK. It still provides a portable higher level abstraction over underlying graphics & rendering systems it

Re: [Qemu-devel] [PATCH 2/2] target-ppc: fix interrupt vectors for MPC603 and e300

2010-04-26 Thread Blue Swirl
On 4/26/10, Segher Boessenkool wrote: > > > > > It is explained in [e300CORERM] at chapters 5.2.3, 5.5.1.1 and 8.3.3. > > > Clearly, the vector offset is 0x100 and the exception prefix can be 0 or > > > 0xFFF0, depending of the MSR[IP] bit. > > > > > > So, yes, I'm sure the value of hreset_vec

[Qemu-devel] [PATCH] target-sparc: Fix -singlestep.

2010-04-26 Thread Richard Henderson
Single-stepping was not properly updating npc, resulting in some instructions being executed twice. In addition, we were emitting dead code at the end of the TB. Fix both by teaching gen_goto_tb to avoid goto_tb for single-step and removing the special-case code in gen_intermediate_code_internal.

[Qemu-devel] KVM call agenda for Apr 27

2010-04-26 Thread Chris Wright
Please send in any agenda items you are interested in covering. While I don't expect it to be the case this week, if we have a lack of agenda items I'll cancel the week's call. thanks, -chris

[Qemu-devel] [PATCH] linux-user: Fix sparc32plus stat64 syscalls.

2010-04-26 Thread Richard Henderson
Check TARGET_ABI_BITS, not TARGET_LONG_BITS, when deciding whether or not the guest needs special 64-bit stat translation. Signed-off-by: Richard Henderson --- linux-user/syscall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall

[Qemu-devel] Re: [PATCH] target-sparc: Fix -singlestep.

2010-04-26 Thread Blue Swirl
Thanks, applied. On 4/26/10, Richard Henderson wrote: > Single-stepping was not properly updating npc, resulting in some > instructions being executed twice. In addition, we were emitting > dead code at the end of the TB. > > Fix both by teaching gen_goto_tb to avoid goto_tb for single-step >

[Qemu-devel] Re: [PATCH] linux-user: Fix sparc32plus stat64 syscalls.

2010-04-26 Thread Blue Swirl
Thanks, applied. On 4/26/10, Richard Henderson wrote: > Check TARGET_ABI_BITS, not TARGET_LONG_BITS, when deciding > whether or not the guest needs special 64-bit stat translation. > > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c |2 +- > 1 files changed, 1 insertions(

[Qemu-devel] [PATCH] Revert "PCI: Convert pci_device_hot_add() to QObject"

2010-04-26 Thread Markus Armbruster
We don't want pci_add in QMP. Use device_add instead. This reverts commit 7a344f7ac7bb651d0556a933ed8060d3a9e5d949. Conflicts: hw/pci-hotplug.c sysemu.h Signed-off-by: Markus Armbruster --- hw/pci-hotplug.c | 46 +- qemu-monitor.h

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Anthony Liguori
On 04/26/2010 10:47 AM, Luiz Capitulino wrote: The 'quit' Monitor command (implemented by do_quit()) calls exit() directly, this is problematic under QMP because QEMU exits before having a chance to send the ok response. Clients don't know if QEMU exited because of a problem or because the 'quit

[Qemu-devel] Re: KVM call agenda for Apr 27

2010-04-26 Thread Anthony Liguori
On 04/26/2010 12:26 PM, Chris Wright wrote: Please send in any agenda items you are interested in covering. While I don't expect it to be the case this week, if we have a lack of agenda items I'll cancel the week's call. - qemu management interface (and libvirt) - stable tree policy (push

[Qemu-devel] [PATCH 09/10] kvm: port qemu-kvm's bitmap scanning

2010-04-26 Thread Marcelo Tosatti
Which is significantly faster. Signed-off-by: Marcelo Tosatti --- kvm-all.c | 53 + 1 files changed, 37 insertions(+), 16 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index eabb097..ef45418 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -26,6

[Qemu-devel] [PATCH 02/10] target-i386: print EFER in cpu_dump_state

2010-04-26 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- target-i386/helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 3835835..c9508a8 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -356,6 +35

[Qemu-devel] [PATCH 06/10] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu

2010-04-26 Thread Marcelo Tosatti
This is now done via the initialization's qemu_system_reset call. Signed-off-by: Avi Kivity --- kvm-all.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 9c8aa7d..eabb097 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -208,7 +208,6 @@ int kvm_init_

[Qemu-devel] [PATCH 03/10] kvm: handle internal error

2010-04-26 Thread Marcelo Tosatti
Port qemu-kvm's KVM_EXIT_INTERNAL_ERROR handling to upstream. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- kvm-all.c | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index d050115..9c8aa7d 100644 --- a/

[Qemu-devel] [PATCH 05/10] kvm_init_vcpu requires global lock held

2010-04-26 Thread Marcelo Tosatti
Since it accesses data protected by the lock. Signed-off-by: Avi Kivity --- cpus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index 8450ee4..2bf87d2 100644 --- a/cpus.c +++ b/cpus.c @@ -401,6 +401,7 @@ static void *kvm_cpu_thread_fn(void *arg) {

[Qemu-devel] [PATCH 08/10] introduce leul_to_cpu

2010-04-26 Thread Marcelo Tosatti
To be used by next patch. Signed-off-by: Marcelo Tosatti --- bswap.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/bswap.h b/bswap.h index aace9b7..956f3fa 100644 --- a/bswap.h +++ b/bswap.h @@ -205,8 +205,10 @@ static inline void cpu_to_be32wu(uint32_t *p, uint32_t v

[Qemu-devel] [PATCH 04/10] kvm: allow qemu to set EPT identity mapping address

2010-04-26 Thread Marcelo Tosatti
From: Sheng Yang If we use larger BIOS image than current 256KB, we would need move reserved TSS and EPT identity mapping pages. Currently TSS support this, but not EPT. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity --- target-i386/kvm.c | 26 +- 1 files c

[Qemu-devel] [PATCH 00/10] [PULL] qemu-kvm.git uq/master queue

2010-04-26 Thread Marcelo Tosatti
The following changes since commit a303f9e37b87ced34e966dc2c0b7f86bc5e74035: Blue Swirl (1): sh4: remove dead assignments, spotted by clang analyzer are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Jan Kiszka (1): KVM: x86: Ad

[Qemu-devel] [PATCH 10/10] introduce qemu_ram_map

2010-04-26 Thread Marcelo Tosatti
Which allows drivers to register an mmaped region into ram block mappings. To be used by device assignment driver. CC: Cam Macdonell Signed-off-by: Marcelo Tosatti --- cpu-common.h |1 + exec.c | 28 2 files changed, 29 insertions(+), 0 deletions(-) dif

[Qemu-devel] [PATCH 01/10] KVM: x86: Add debug register saving and restoring

2010-04-26 Thread Marcelo Tosatti
From: Jan Kiszka Make use of the new KVM_GET/SET_DEBUGREGS to save/restore the x86 debug registers. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c | 11 ++ kvm.h |1 + target-i386/kvm.c | 55 ++

[Qemu-devel] [PATCH 07/10] vga: fix typo in length passed to kvm_log_stop

2010-04-26 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti --- hw/vga.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index 845dbcc..db72115 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -1618,8 +1618,8 @@ void vga_dirty_log_stop(VGACommonState *s) kvm_log_stop(s->map_addr

[Qemu-devel] Possible race condition in VNC display resizing

2010-04-26 Thread Daniel P. Berrange
In tracking down a rare crash in GTK-VNC clients, I think I've discovered a race in the way QEMU processes resize events during initial connection handshake The symptom of the problem is that the client receives a framebuffer update which stretches outside the boundaries of the guest framebuffer,

[Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add() to QObject"

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 19:44:19 +0200 Markus Armbruster wrote: > We don't want pci_add in QMP. Use device_add instead. > > This reverts commit 7a344f7ac7bb651d0556a933ed8060d3a9e5d949. > > Conflicts: > > hw/pci-hotplug.c > sysemu.h > > Signed-off-by: Markus Armbruster The patch l

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 12:49:40 -0500 Anthony Liguori wrote: > On 04/26/2010 10:47 AM, Luiz Capitulino wrote: > > The 'quit' Monitor command (implemented by do_quit()) calls > > exit() directly, this is problematic under QMP because QEMU > > exits before having a chance to send the ok response. > >

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Anthony Liguori
On 04/26/2010 01:22 PM, Luiz Capitulino wrote: On Mon, 26 Apr 2010 12:49:40 -0500 Anthony Liguori wrote: On 04/26/2010 10:47 AM, Luiz Capitulino wrote: The 'quit' Monitor command (implemented by do_quit()) calls exit() directly, this is problematic under QMP because QEMU exits befor

[Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map

2010-04-26 Thread Anthony Liguori
On 04/26/2010 12:59 PM, Marcelo Tosatti wrote: Which allows drivers to register an mmaped region into ram block mappings. To be used by device assignment driver. This doesn't make much sense to me. Do you use this like: qemu_ram_map(64k, ptr); assert(qemu_ram_alloc(64k) == ptr); If so, I

[Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map

2010-04-26 Thread Anthony Liguori
On 04/26/2010 12:59 PM, Marcelo Tosatti wrote: Which allows drivers to register an mmaped region into ram block mappings. To be used by device assignment driver. This is not kvm specific and not required by this pull request so it shouldn't really be part of the pull. Something like this

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-26 Thread Anthony Liguori
On 04/23/2010 08:28 AM, Kevin Wolf wrote: Am 23.04.2010 14:52, schrieb Michael Tokarev: Kevin Wolf wrote: Am 22.04.2010 11:52, schrieb Markus Armbruster: Michael Tokarev writes: In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints (with fprintf)

[Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map

2010-04-26 Thread Marcelo Tosatti
On Mon, Apr 26, 2010 at 01:27:30PM -0500, Anthony Liguori wrote: > On 04/26/2010 12:59 PM, Marcelo Tosatti wrote: > >Which allows drivers to register an mmaped region into ram block mappings. > >To be used by device assignment driver. > > This doesn't make much sense to me. > > Do you use this li

[Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map

2010-04-26 Thread Marcelo Tosatti
On Mon, Apr 26, 2010 at 01:29:06PM -0500, Anthony Liguori wrote: > On 04/26/2010 12:59 PM, Marcelo Tosatti wrote: > >Which allows drivers to register an mmaped region into ram block mappings. > >To be used by device assignment driver. > > > > This is not kvm specific and not required by this pull

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 13:25:38 -0500 Anthony Liguori wrote: > On 04/26/2010 01:22 PM, Luiz Capitulino wrote: > > On Mon, 26 Apr 2010 12:49:40 -0500 > > Anthony Liguori wrote: > > > > > >> On 04/26/2010 10:47 AM, Luiz Capitulino wrote: > >> > >>> The 'quit' Monitor command (implemented by

[Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map

2010-04-26 Thread Anthony Liguori
On 04/26/2010 01:49 PM, Marcelo Tosatti wrote: On Mon, Apr 26, 2010 at 01:27:30PM -0500, Anthony Liguori wrote: On 04/26/2010 12:59 PM, Marcelo Tosatti wrote: Which allows drivers to register an mmaped region into ram block mappings. To be used by device assignment driver. Th

[Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map

2010-04-26 Thread Anthony Liguori
On 04/26/2010 01:50 PM, Marcelo Tosatti wrote: On Mon, Apr 26, 2010 at 01:29:06PM -0500, Anthony Liguori wrote: On 04/26/2010 12:59 PM, Marcelo Tosatti wrote: Which allows drivers to register an mmaped region into ram block mappings. To be used by device assignment driver. T

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Anthony Liguori
On 04/26/2010 01:53 PM, Luiz Capitulino wrote: On Mon, 26 Apr 2010 13:25:38 -0500 Anthony Liguori wrote: On 04/26/2010 01:22 PM, Luiz Capitulino wrote: On Mon, 26 Apr 2010 12:49:40 -0500 Anthony Liguori wrote: On 04/26/2010 10:47 AM, Luiz Capitulino wrote: T

[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Jan Kiszka
Anthony Liguori wrote: > On 04/26/2010 01:53 PM, Luiz Capitulino wrote: >> On Mon, 26 Apr 2010 13:25:38 -0500 >> Anthony Liguori wrote: >> >> >>> On 04/26/2010 01:22 PM, Luiz Capitulino wrote: >>> On Mon, 26 Apr 2010 12:49:40 -0500 Anthony Liguori wrote: >

[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Anthony Liguori
On 04/26/2010 02:10 PM, Jan Kiszka wrote: Just suspend the monitor before leaving for termination. That should have both the proper visual and functional effect. Very good idea. Regards, Anthony Liguori Jan

[Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map

2010-04-26 Thread Marcelo Tosatti
On Mon, Apr 26, 2010 at 01:57:37PM -0500, Anthony Liguori wrote: > On 04/26/2010 01:50 PM, Marcelo Tosatti wrote: > >On Mon, Apr 26, 2010 at 01:29:06PM -0500, Anthony Liguori wrote: > >>On 04/26/2010 12:59 PM, Marcelo Tosatti wrote: > >>>Which allows drivers to register an mmaped region into ram bl

Re: [Qemu-devel] Possible race condition in VNC display resizing

2010-04-26 Thread Anthony Liguori
On 04/26/2010 01:19 PM, Daniel P. Berrange wrote: In tracking down a rare crash in GTK-VNC clients, I think I've discovered a race in the way QEMU processes resize events during initial connection handshake The symptom of the problem is that the client receives a framebuffer update which stretch

Re: [Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map

2010-04-26 Thread Anthony Liguori
On 04/26/2010 02:14 PM, Marcelo Tosatti wrote: On Mon, Apr 26, 2010 at 01:57:37PM -0500, Anthony Liguori wrote: On 04/26/2010 01:50 PM, Marcelo Tosatti wrote: On Mon, Apr 26, 2010 at 01:29:06PM -0500, Anthony Liguori wrote: On 04/26/2010 12:59 PM, Marcelo Tosatti wrote:

[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 14:13:40 -0500 Anthony Liguori wrote: > On 04/26/2010 02:10 PM, Jan Kiszka wrote: > > > > Just suspend the monitor before leaving for termination. That should > > have both the proper visual and functional effect. > > > > Very good idea. Yeah, works great. Final versi

Re: [Qemu-devel] Re: [PATCH 10/10] introduce qemu_ram_map

2010-04-26 Thread Marcelo Tosatti
On Mon, Apr 26, 2010 at 02:20:42PM -0500, Anthony Liguori wrote: > On 04/26/2010 02:14 PM, Marcelo Tosatti wrote: > >On Mon, Apr 26, 2010 at 01:57:37PM -0500, Anthony Liguori wrote: > >>On 04/26/2010 01:50 PM, Marcelo Tosatti wrote: > >>>On Mon, Apr 26, 2010 at 01:29:06PM -0500, Anthony Liguori wro

Re: [Qemu-devel] [PATCH 0/9][PULL]: QMP/Monitor queue

2010-04-26 Thread Anthony Liguori
On 04/26/2010 10:47 AM, Luiz Capitulino wrote: Hi Anthony, The following QMP/Monitor patches have been sent to the list and look good to me. I have also tested most of them. Applied. Thanks. Regards, Anthony Liguori The changes (since a303f9e37b87ced34e966dc2c0b7f86bc5e74035) ar

[Qemu-devel] [PATCH] fix whitespace bogon in some versions of make

2010-04-26 Thread Nathan Froyd
With three different make binaries I have available, configuring a pristine QEMU tree and attempting to make gives the cryptic: Makefile:27: *** missing separator. Stop. This patch fixes it (presumably because it makes the output of `set-vpath' be an empty string, rather than a bit of whitespace

Re: [Qemu-devel] Re: [PATCH] Remove IO_MEM_SUBWIDTH.

2010-04-26 Thread Artyom Tarasenko
This patch introduces a regression. qemu crashes on lance test: 6.2.1 i/olancegetidPass 6.2.2 i/olancecsr Program received signal SIGSEGV, Segmentation fault. 0x in ?? () (gdb) bt #0 0x in ?? () #1 0x004aaa3c i

[Qemu-devel] Re: KVM call agenda for Apr 27

2010-04-26 Thread Chris Wright
* Anthony Liguori (anth...@codemonkey.ws) wrote: > On 04/26/2010 12:26 PM, Chris Wright wrote: > >Please send in any agenda items you are interested in covering. > > > >While I don't expect it to be the case this week, if we have a > >lack of agenda items I'll cancel the week's call. > > - qemu ma

  1   2   >