Re: [Qemu-devel] [PATCH 6/9] eepro100: Support compilation without EEPROM

2010-04-07 Thread Stefan Weil
Paul Brook schrieb: >> To emulate hardware without an EEPROM, >> EEPROM_SIZE may be set to 0. > > If might, but it isn't. > > This patch introduces a condition that will never be false. Please > don't do > that. I consider code that is never used to be actively harmful. Any > feature > that require

Re: [Qemu-devel] [PATCH 6/9] eepro100: Support compilation without EEPROM

2010-04-07 Thread Michael S. Tsirkin
On Wed, Apr 07, 2010 at 09:02:06AM +0200, Stefan Weil wrote: > Paul Brook schrieb: > >> To emulate hardware without an EEPROM, > >> EEPROM_SIZE may be set to 0. > > > > If might, but it isn't. > > > > This patch introduces a condition that will never be false. Please > > don't do > > that. I consid

Re: [Qemu-devel] AHCI emulation

2010-04-07 Thread Roland Elek
> Excuse me but I do not see any other applicant interested in the S3 emulation however there is one application already for AHCI. Could you guide me to that other applicant please? I was referring to jai from IRC, according to a post by Alexander Graf in a previous thread about the two projects i

[Qemu-devel] [PATCH 0/2] pci_add_capability_at_offset

2010-04-07 Thread Michael S. Tsirkin
eepro100 has to jump through hoops to add capability at a specific offset. It's cleaner to simply add an API for that. Michael S. Tsirkin (2): pci: add API to add capability at a known offset eepro100: convert to new capability API hw/eepro100.c | 22 +- hw/pci.c |

[Qemu-devel] [PATCH 1/2] pci: add API to add capability at a known offset

2010-04-07 Thread Michael S. Tsirkin
Unlike virtio, device emulations need to add pci capabilities at known offsets to match real hardware. Make this possible by adding an appropriate API. Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 16 hw/pci.h |2 ++ 2 files changed, 14 insertions(+), 4 deletions(-) d

[Qemu-devel] [PATCH 2/2] eepro100: convert to new capability API

2010-04-07 Thread Michael S. Tsirkin
Using new pci_add_capability_at_offset makes eepro100 code cleaner. Signed-off-by: Michael S. Tsirkin --- hw/eepro100.c | 22 +- 1 files changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 785a7da..a74d834 100644 --- a/hw/eepro100.c +

[Qemu-devel] Re: eepro100: New patches

2010-04-07 Thread Michael S. Tsirkin
On Tue, Apr 06, 2010 at 06:09:56PM +0200, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Tue, Apr 06, 2010 at 01:44:00PM +0200, Stefan Weil wrote: > > > >> These patches fix two regressions (1, 9) which made eepro100 rather > >> useless, > >> use a simple method to handle the different

[Qemu-devel] Re: [PATCH 1/2] pci: add API to add capability at a known offset

2010-04-07 Thread Stefan Weil
Michael S. Tsirkin schrieb: > Unlike virtio, device emulations need to add pci capabilities > at known offsets to match real hardware. Make this possible > by adding an appropriate API. > > Signed-off-by: Michael S. Tsirkin > --- > hw/pci.c | 16 > hw/pci.h |2 ++ > 2 files

Re: [Qemu-devel] [PATCH v2] cleanup block driver option handling in vl.c

2010-04-07 Thread Kevin Wolf
Am 06.04.2010 19:12, schrieb Christoph Hellwig: > Assign directly to the bdrv_flags variable instead of using > magic numbers before translating to the BDRV_O_* options. > > Signed-off-by: Christoph Hellwig Looks good now. Acked-by: Kevin Wolf

[Qemu-devel] Re: [PATCH 2/2] eepro100: convert to new capability API

2010-04-07 Thread Stefan Weil
Michael S. Tsirkin schrieb: > Using new pci_add_capability_at_offset makes > eepro100 code cleaner. > > Signed-off-by: Michael S. Tsirkin > --- > hw/eepro100.c | 22 +- > 1 files changed, 9 insertions(+), 13 deletions(-) > > diff --git a/hw/eepro100.c b/hw/eepro100.c > index 785

Re: [Qemu-devel] [PATCH v2] block: split raw_getlength

2010-04-07 Thread Kevin Wolf
Am 06.04.2010 19:13, schrieb Christoph Hellwig: > Split up the raw_getlength into separate generic, solaris and BSD > versions to reduce the ifdef maze a bit. The BSD variant still > is a complete maze, but to clean it up properly we'd need some > people using the BSD variants to figure out what c

[Qemu-devel] Latest Git fails to compile in cpus.c

2010-04-07 Thread Nigel Horne
./configure --enable-linux-aio --enable-io-thread --enable-kvm: /home/njh/src/qemu/cpus.c:360: error: ‘SIG_IPI’ undeclared (first use in this function) /home/njh/src/qemu/cpus.c:360: error: (Each undeclared identifier is reported only once -Nigel

Re: [Qemu-devel] AHCI emulation

2010-04-07 Thread Alexander Graf
Roland Elek wrote: > Seeing the controversy about the S3 Trio, and the fact that there > seems to be another applicant interested in it, I've decided to > prepare a proposal for the AHCI emulation project, the other project > of my interest. I have skimmed through the documentation and some Qemu >

Re: [Qemu-devel] Regarding Google summer of code

2010-04-07 Thread Alexander Graf
Vishnumurthy Prabhu wrote: > i want to know whether proposing idea for google summer of code is to > be of own or can it be something that is already there which is not > in the > Qemu is allowed but that is applicable to one of the suggested project > ideas in Qemu ideas list.? You can certainl

[Qemu-devel] Re: [PATCH 0/3] fix network booting when using "-device" instead of "-net nic"

2010-04-07 Thread Juan Quintela
Eduardo Habkost wrote: > This series fixes the following issue: > > $ qemu-system-x86_64 -device > rtl8139,vlan=0,id=net0,mac=52:54:00:82:41:fd,bus=pci.0,addr=0x4 -net > user,vlan=0,name=hostnet0 -vnc 0.0.0.0:0 -boot n > Cannot boot from non-existent NIC > $ > > Patches 1 and 3 are just c

[Qemu-devel] Re: [PATCH 2/2] eepro100: convert to new capability API

2010-04-07 Thread Michael S. Tsirkin
On Wed, Apr 07, 2010 at 10:42:07AM +0200, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > Using new pci_add_capability_at_offset makes > > eepro100 code cleaner. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > hw/eepro100.c | 22 +- > > 1 files changed, 9 insertions(+

[Qemu-devel] [GSoC 2010][RESEND] Shared memory transport between guest(s) and host

2010-04-07 Thread Mohammed Gamal
Hi, I am interested in the "Shared memory transport between guest(s) and host" project for GSoC 2010. The description of the project is pretty straightforward, but I am a little bit lost on some parts: 1- Is there any documentation available on KVM shared memory transport. This'd definitely help u

Re: [Qemu-devel] [PATCH 0/2] tcg-hppa finish, v3

2010-04-07 Thread Richard Henderson
Ping? On 03/23/2010 03:33 PM, Richard Henderson wrote: Changes from v2 to v3: * millicode division routines removed in favour of generic code. r~ Richard Henderson (2): tcg-hppa: Compute is_write in cpu_signal_handler. tcg-hppa: Finish the port. configure |5 +-

[Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_handle_rw_error

2010-04-07 Thread Jan Kiszka
virtio_blk_req_complete releases the request we dereference again for bdrv_mon_event. Reorder both calls to fix this. Signed-off-by: Jan Kiszka --- hw/virtio-blk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 9915840..d5e8c79 1

Re: [Qemu-devel] [PATCH 0/2] tcg-hppa finish, v3

2010-04-07 Thread Aurelien Jarno
Richard Henderson a écrit : > Ping? Pong ;-) Sorry, I haven't find time to review it in details. Would also be nice if someone can try it on an hppa machine, and ack it. > On 03/23/2010 03:33 PM, Richard Henderson wrote: >> Changes from v2 to v3: >>* millicode division routines removed in fa

Re: [Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_handle_rw_error

2010-04-07 Thread Christoph Hellwig
On Wed, Apr 07, 2010 at 01:47:47PM +0200, Jan Kiszka wrote: > virtio_blk_req_complete releases the request we dereference again for > bdrv_mon_event. Reorder both calls to fix this. I think Kevin alreday sent a patch to use the local state variable which is still around. Either way looks fine to

[Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-07 Thread Christoph Hellwig
Various obscure image format drivers do not allow write access. Instead of silently falling back to read-only access reject attempts to open these images for write access. Signed-off-by: Christoph Hellwig Index: qemu/block/bochs.c =

[Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only

2010-04-07 Thread Christoph Hellwig
bdrv_open already takes care of this for us. Signed-off-by: Christoph Hellwig Index: qemu/block/raw-posix.c === --- qemu.orig/block/raw-posix.c 2010-04-07 13:50:16.573261199 +0200 +++ qemu/block/raw-posix.c 2010-04-07 13:50:25.

Re: [Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_handle_rw_error

2010-04-07 Thread Kevin Wolf
Am 07.04.2010 13:57, schrieb Christoph Hellwig: > On Wed, Apr 07, 2010 at 01:47:47PM +0200, Jan Kiszka wrote: >> virtio_blk_req_complete releases the request we dereference again for >> bdrv_mon_event. Reorder both calls to fix this. > > I think Kevin alreday sent a patch to use the local state va

Re: [Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_handle_rw_error

2010-04-07 Thread Luiz Capitulino
On Wed, 07 Apr 2010 14:18:26 +0200 Kevin Wolf wrote: > Am 07.04.2010 13:57, schrieb Christoph Hellwig: > > On Wed, Apr 07, 2010 at 01:47:47PM +0200, Jan Kiszka wrote: > >> virtio_blk_req_complete releases the request we dereference again for > >> bdrv_mon_event. Reorder both calls to fix this. >

Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-07 Thread Kevin Wolf
Am 07.04.2010 13:57, schrieb Christoph Hellwig: > Various obscure image format drivers do not allow write access. > Instead of silently falling back to read-only access reject attempts > to open these images for write access. > > Signed-off-by: Christoph Hellwig I'm not sure about this patch. I

Re: [Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_handle_rw_error

2010-04-07 Thread Luiz Capitulino
On Wed, 7 Apr 2010 09:32:35 -0300 Luiz Capitulino wrote: > On Wed, 07 Apr 2010 14:18:26 +0200 > Kevin Wolf wrote: > > > Am 07.04.2010 13:57, schrieb Christoph Hellwig: > > > On Wed, Apr 07, 2010 at 01:47:47PM +0200, Jan Kiszka wrote: > > >> virtio_blk_req_complete releases the request we derefe

Re: [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only

2010-04-07 Thread Kevin Wolf
Am 07.04.2010 13:58, schrieb Christoph Hellwig: > bdrv_open already takes care of this for us. > > Signed-off-by: Christoph Hellwig > > Index: qemu/block/raw-posix.c > === > --- qemu.orig/block/raw-posix.c 2010-04-07 13:50:16.

Re: [Qemu-devel] AHCI emulation

2010-04-07 Thread Luiz Capitulino
On Tue, 6 Apr 2010 18:56:17 +0200 Roland Elek wrote: > Seeing the controversy about the S3 Trio, and the fact that there seems to > be another applicant interested in it, I've decided to prepare a proposal > for the AHCI emulation project, the other project of my interest. I have > skimmed throug

[Qemu-devel] Re: [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

2010-04-07 Thread Jeremy Kerr
Hi Grant, > This is an experimental set of patches for populating the flattened > device tree (fdt) data from the actual set of qdevs in the platform. Neat. I've pulled these into my qemu tree, and have updated it to the current qemu master branch too (only a minor change, as qemu_error has been

[Qemu-devel] Re: [PATCH 1/1] QMP test code - qmp.py

2010-04-07 Thread Luiz Capitulino
On Wed, 7 Apr 2010 03:40:32 +0300 Costas Drogos wrote: > Hello there, > > a very small patch to address two small issues: > > 1) The json state in python2.5 and python2.6. json module is included > by default on python2.6, whereas you have to import simplejson in > python2.5. I have this proble

Re: [Qemu-devel] Re: [PATCH 1/1] QMP test code - qmp.py

2010-04-07 Thread Avi Kivity
On 04/07/2010 04:36 PM, Luiz Capitulino wrote: diff --git a/QMP/qmp.py b/QMP/qmp.py index d9da603..f8581c4 100644 --- a/QMP/qmp.py +++ b/QMP/qmp.py @@ -8,7 +8,15 @@ # This work is licensed under the terms of the GNU GPL, version 2. See # the COPYING file in the top-level directory. -impo

Re: [Qemu-devel] AHCI emulation

2010-04-07 Thread Joerg Roedel
Hello Roland, Luiz, Sorry I missed this email. Here is my reply. On Wed, Apr 07, 2010 at 09:57:27AM -0300, Luiz Capitulino wrote: > On Tue, 6 Apr 2010 18:56:17 +0200 > Roland Elek wrote: > > > Seeing the controversy about the S3 Trio, and the fact that there seems to > > be another applicant in

Re: [Qemu-devel] [PATCH 3/6] Make char muxer more robust wrt small FIFOs

2010-04-07 Thread Alexander Graf
Amit Shah wrote: > On (Thu) Apr 01 2010 [18:42:38], Alexander Graf wrote: > >> Virtio-Console can only process one character at a time. >> > > The host can process as many as you give it, depending on the buffer > size exposed by the guest. > > On older guests (guest kernels w/o multiport s

Re: [Qemu-devel] Re: [PATCH 1/1] QMP test code - qmp.py

2010-04-07 Thread Costas Drogos
On Wed, Apr 7, 2010 at 16:51, Avi Kivity wrote: >>  This won't do what we want for 2.7 and newer, so a better if would be: Thats why i said it is just an ugly hack :) Anyway, I've just cloned the qmp-unstable tree to run some tests and report back >> if sys.version_info<  (2, 6): >>     import s

Re: [Qemu-devel] [PATCH 3/6] Make char muxer more robust wrt small FIFOs

2010-04-07 Thread Amit Shah
On (Wed) Apr 07 2010 [16:32:04], Alexander Graf wrote: > Amit Shah wrote: > > On (Thu) Apr 01 2010 [18:42:38], Alexander Graf wrote: > > > >> Virtio-Console can only process one character at a time. > >> > > > > The host can process as many as you give it, depending on the buffer > > size e

Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-07 Thread Stefan Hajnoczi
On Wed, Apr 7, 2010 at 12:57 PM, Christoph Hellwig wrote: > Various obscure image format drivers do not allow write access. > Instead of silently falling back to read-only access reject attempts > to open these images for write access. Does block/curl.c need this too? Stefan

Re: [Qemu-devel] [Applied PATCH] Split TLB addend and target_phys_addr_t

2010-04-07 Thread Alexander Graf
malc wrote: > On Mon, 5 Apr 2010, Alexander Graf wrote: > > >> On 05.04.2010, at 14:41, malc wrote: >> >> >>> On Mon, 5 Apr 2010, Paul Brook wrote: >>> >>> I think I got all the tcg backend bits right, but can't test most of them. Please test and report any problems.

Re: [Qemu-devel] [Applied PATCH] Split TLB addend and target_phys_addr_t

2010-04-07 Thread Alexander Graf
Alexander Graf wrote: > [2.148288] registered taskstats version 1 > [2.148288] Magic number: 6:65:32 > [2.148288] rtc_cmos 00:01: setting system clock to 2010-04-07 > 15:01:35 UTC (1270652495) > > *** sits here in hlt *** > > Almost looks like a timekeeping issue, no? And yes, I tried

Re: [Qemu-devel] [Applied PATCH] Split TLB addend and target_phys_addr_t

2010-04-07 Thread malc
On Wed, 7 Apr 2010, Alexander Graf wrote: > Alexander Graf wrote: > > [2.148288] registered taskstats version 1 > > [2.148288] Magic number: 6:65:32 > > [2.148288] rtc_cmos 00:01: setting system clock to 2010-04-07 > > 15:01:35 UTC (1270652495) > > > > *** sits here in hlt *** > > >

[Qemu-devel] Re: [GSoC 2010][RESEND] Shared memory transport between guest(s) and host

2010-04-07 Thread Cam Macdonell
On Wed, Apr 7, 2010 at 5:30 AM, Mohammed Gamal wrote: > Hi, > I am interested in the "Shared memory transport between guest(s) and > host" project for GSoC 2010. The description of the project is pretty > straightforward, but I am a little bit lost on some parts: > > 1- Is there any documentation

Re: [Qemu-devel] [Applied PATCH] Split TLB addend and target_phys_addr_t

2010-04-07 Thread Alexander Graf
malc wrote: > On Wed, 7 Apr 2010, Alexander Graf wrote: > > >> Alexander Graf wrote: >> >>> [2.148288] registered taskstats version 1 >>> [2.148288] Magic number: 6:65:32 >>> [2.148288] rtc_cmos 00:01: setting system clock to 2010-04-07 >>> 15:01:35 UTC (1270652495) >>> >>> **

Res: Res: [Qemu-devel] full dynamic instruction trace for MIPS target

2010-04-07 Thread Boris Cámara
>This is like a virtual instruction that lives in >the TB and calls my counting function. So each time the TB is re-executed >the calls happen again, as they are part of the TB instruction stream. It sounds good! Today a will apply the patches and run it to get a better understanding. > Did y

[Qemu-devel] Shared file help

2010-04-07 Thread Arpit Patel
Hi, Can anybody point me to good document, where I can share files between host system and Qemu system. i.e. I want to share files, between real system with Ubuntu running on it, and Qemu on same system with Ubuntu on it. Let me know if I didn't mentioned it clearly. Thanks, Arpit

Re: [Qemu-devel] Latest Git fails to compile in cpus.c

2010-04-07 Thread malc
On Wed, 7 Apr 2010, Nigel Horne wrote: > ./configure --enable-linux-aio --enable-io-thread --enable-kvm: > > > > /home/njh/src/qemu/cpus.c:360: error: ?SIG_IPI? undeclared (first use in this > function) > /home/njh/src/qemu/cpus.c:360: error: (Each undeclared identifier is reported > only

[Qemu-devel] binary injection

2010-04-07 Thread Aravind Prakash
Hello, I am trying to find if there is a way to inject a given binary into guest code. If there isn't a way to do it, I would like to write a module which would let us do it. Can somebody suggest what would be nice to have in such a module? Thanks, Aravind.

[Qemu-devel] [PATCH 02/18] tcg/arm: explicitely list clobbered/reserved regs

2010-04-07 Thread Aurelien Jarno
Instead of writing very compact code, declare all registers that are clobbered or reserved one by one. This makes the code easier to read. Also declare all the 16 registers to TCG, and mark pc as reserved. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 13 + tcg/arm/tcg-

[Qemu-devel] [PATCH 01/18] tcg/arm: remove SAVE_LR code

2010-04-07 Thread Aurelien Jarno
There is no need to save the LR register (r14) before a call to a subroutine. According to the "Procedure Call Standard for the ARM Architecture", it is the job of the callee to save this register. Moreover, this register is already saved in the prologue/epilogue. This patch removes the disabled S

[Qemu-devel] [PATCH 05/18] tcg/arm: align 64-bit arguments in function calls

2010-04-07 Thread Aurelien Jarno
As specified by the "Procedure Call Standard for the ARM Architecture". Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h index a0027b5..334edfa 100644 --- a/tcg/arm/tcg-targ

[Qemu-devel] [PATCH 0/18] tcg/arm: cleanup and improvements

2010-04-07 Thread Aurelien Jarno
This patch series clean-up and improves the tcg/arm code. The first patches are just a clean-up and should not change the resulting binaries, while the other ones use new ARM instructions, and fix 64-bit and/or big-endian targets. With this patch series I am able to successfully: - boot debian-i

[Qemu-devel] [PATCH 07/18] tcg/arm: sxtb and sxth are available starting with ARMv6

2010-04-07 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index cae6385..777c4ac 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -1454,7 +1454,7 @@ static inline vo

[Qemu-devel] [PATCH 09/18] tcg/arm: add rotation ops

2010-04-07 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 19 +++ tcg/arm/tcg-target.h |2 +- 2 files changed, 20 insertions(+), 1 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 3360c23..4290c4f 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg

[Qemu-devel] [PATCH 06/18] tcg/arm: add defines for the allowed instructions set

2010-04-07 Thread Aurelien Jarno
Use a set of #define to define the allowed ARM instructions, depending on the __ARM_ARCH_*__ GCC defines. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-

[Qemu-devel] [PATCH 11/18] tcg/arm: add bswap ops

2010-04-07 Thread Aurelien Jarno
Add an bswap16 and bswap32 ops, either using the rev and rev16 instructions on ARMv6+ or shifts and logical operations on previous ARM versions. In both cases the result use less instructions than the pure TCG version. These ops are also needed by the qemu_ld/st functions. Signed-off-by: Aurelien

[Qemu-devel] [PATCH 08/18] tcg/arm: use the blx instruction when possible

2010-04-07 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 777c4ac..3360c23 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -333,6 +333,11 @@ static inli

[Qemu-devel] [PATCH 04/18] tcg/arm: replace integer values by registers enum

2010-04-07 Thread Aurelien Jarno
The TCG ARM backends uses integer values to refer to both immediate values and register number. This makes the code difficult to read. The patch below replaces all (if I haven't miss any ;-) integer values representing register number by TCG_REG_* enum values. Signed-off-by: Aurelien Jarno ---

[Qemu-devel] [PATCH 03/18] tcg/arm: remove store signed functions

2010-04-07 Thread Aurelien Jarno
Store signed functions doesn't make sense, and are not used. Remove them. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 72 +++--- 1 files changed, 10 insertions(+), 62 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c

[Qemu-devel] [PATCH 18/18] tcg/arm: don't try to load constants using pc

2010-04-07 Thread Aurelien Jarno
This code is never used, neither in user mode nor in system mode. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 03fe11c..1d1e28a 100644 --- a/tcg/arm/tcg-targ

[Qemu-devel] [PATCH 13/18] tcg/arm: use ext* ops in qemu_ld

2010-04-07 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 30 -- 1 files changed, 12 insertions(+), 18 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index d24a245..33ca2ca 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -475,6

[Qemu-devel] [PATCH 16/18] tcg/arm: fix argument alignment in qemu_st64

2010-04-07 Thread Aurelien Jarno
64-bit arguments should be aligned on an even register as specified by the "Procedure Call Standard for the ARM Architecture". Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/tcg/arm/tcg-target.c b

[Qemu-devel] [PATCH 15/18] tcg/arm: remove useless register tests in qemu_ld/st

2010-04-07 Thread Aurelien Jarno
addr_reg, data_reg and data_reg2 can't be register r0 or r1 du to the constraints. Don't check if they equals these registers. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 30 ++ 1 files changed, 10 insertions(+), 20 deletions(-) diff --git a/tcg/arm/tc

[Qemu-devel] [PATCH 17/18] tcg/arm: optimize register allocation order

2010-04-07 Thread Aurelien Jarno
The beginning of the register allocation order list on the TCG arm target matches the list of clobbered registers. This means that when an helper is called, there is almost always clobbered registers that have to be spilled. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 10 +

[Qemu-devel] [PATCH 10/18] tcg/arm: add ext16u op

2010-04-07 Thread Aurelien Jarno
Add an ext16u op, either using the uxth instruction on ARMv6+ or two shifts on previous ARM versions. In both cases the result use the same number or less instructions than the pure TCG version. Also move all sign extension code to separate functions, so that it can be reused in other parts of the

[Qemu-devel] [PATCH 12/18] tcg/arm: remove conditional argument for qemu_ld/st

2010-04-07 Thread Aurelien Jarno
While it make sense to pass a conditional argument to tcg_out_*() functions as the ARM architecture allows that, it doesn't make sense for qemu_ld/st functions. These functions use comparison instructions and conditional execution already, so it is not possible to use a second level of conditional

[Qemu-devel] [PATCH 14/18] tcg/arm: bswap arguments in qemu_ld/st if needed

2010-04-07 Thread Aurelien Jarno
On big endian targets, data arguments of qemu_ld/st ops have to be byte swapped. Two temporary registers are needed for qemu_st to do the bswap. r0 and r1 are used in system mode, do the same in user mode, which implies reworking the constraints. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-tar

Re: [Qemu-devel] Latest Git fails to compile in cpus.c

2010-04-07 Thread Blue Swirl
On 4/7/10, malc wrote: > On Wed, 7 Apr 2010, Nigel Horne wrote: > > > ./configure --enable-linux-aio --enable-io-thread --enable-kvm: > > > > > > > > /home/njh/src/qemu/cpus.c:360: error: ?SIG_IPI? undeclared (first use in > this > > function) > > /home/njh/src/qemu/cpus.c:360: error

[Qemu-devel] [PATCH 0/4]: QMP: Fix segfault in bad input

2010-04-07 Thread Luiz Capitulino
First, we do some QError usage cleanup in handle_qmp_command() and then really fix the bug in the last patch.

[Qemu-devel] [PATCH 2/4] QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER

2010-04-07 Thread Luiz Capitulino
The QERR_QMP_BAD_INPUT_OBJECT error is going to be used only for two problems: the input is not an object or the "execute" key is missing. Signed-off-by: Luiz Capitulino --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 709b326..c

[Qemu-devel] [PATCH 1/4] QError: New QERR_QMP_BAD_INPUT_OBJECT_MEMBER

2010-04-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 8d885cd..b6aaec7 100644 --- a/qerror.c +++ b/qerror.c @@ -173,6 +173,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 4/4] QMP: Check "arguments" member's type

2010-04-07 Thread Luiz Capitulino
Otherwise the following input crashes QEMU: { "execute": "migrate", "arguments": "tcp:0:4446" } Signed-off-by: Luiz Capitulino --- monitor.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index cd350d6..91d7da5 100644 --- a/monitor.c +++ b/monit

[Qemu-devel] [PATCH 3/4] QError: Improve QERR_QMP_BAD_INPUT_OBJECT desc

2010-04-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qerror.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qerror.c b/qerror.c index b6aaec7..034c7de 100644 --- a/qerror.c +++ b/qerror.c @@ -170,7 +170,7 @@ static const QErrorStringTable qerror_table[] = { }, { .erro

[Qemu-devel] [PATCH] Monitor: Return before exiting with 'quit'

2010-04-07 Thread Luiz Capitulino
The 'quit' Monitor command (implemented by do_quit()) calls exit() directly, this is problematic under QMP because QEMU exits before having a chance to send the ok response. Clients don't know if QEMU exited because of a problem or because the 'quit' command has been executed. This commit fixes t

Re: [Qemu-devel] Shared file help

2010-04-07 Thread Avi Kivity
On 04/07/2010 08:09 PM, Arpit Patel wrote: Hi, Can anybody point me to good document, where I can share files between host system and Qemu system. i.e. I want to share files, between real system with Ubuntu running on it, and Qemu on same system with Ubuntu on it. Let me know if I didn't men

Re: [Qemu-devel] [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

2010-04-07 Thread Blue Swirl
On 4/7/10, Grant Likely wrote: > Hi everyone, > > This is an experimental set of patches for populating the flattened > device tree (fdt) data from the actual set of qdevs in the platform. > I'm not expecting this to get merged anytime soon, but I wanted to get > it out there to solicit commen

[Qemu-devel] [PATCH, RFC] block: separate raw images from the file protocol

2010-04-07 Thread Christoph Hellwig
We're running into various problems because the "raw" file access, which is used internally by the various image formats is entangled with the "raw" image format, which maps the VM view 1:1 to a file system. This patch renames the raw file backends to the file protocol which is treated like other

Re: [Qemu-devel] [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

2010-04-07 Thread Grant Likely
Thanks for the comments. Replies below... On Wed, Apr 7, 2010 at 1:10 PM, Blue Swirl wrote: > On 4/7/10, Grant Likely wrote: >> Hi everyone, >> >>  This is an experimental set of patches for populating the flattened >>  device tree (fdt) data from the actual set of qdevs in the platform. >>  I'

[Qemu-devel] Re: [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

2010-04-07 Thread Grant Likely
On Wed, Apr 7, 2010 at 1:01 AM, Jeremy Kerr wrote: > Hi Grant, > >> This is an experimental set of patches for populating the flattened >> device tree (fdt) data from the actual set of qdevs in the platform. > > Neat. I've pulled these into my qemu tree, and have updated it to the current > qemu m

[Qemu-devel] [PATCH 0/8] (v2) chardev, virtio-console: flow control, error handling, fixes

2010-04-07 Thread Amit Shah
Hello, This patchset introduces flow control to virtio-console and chardev-based virtio serial ports. This series is based on the previous series I sent on Mar 31st (00/17: v4: virtio-serial fixes, new abi for port discovery) The qemu chardevs can now return -EAGAIN when a non-blocking remote isn

[Qemu-devel] [PATCH 1/8] virtio-serial: throttling: check for throttled status before sending any data

2010-04-07 Thread Amit Shah
We were assuming that once unthrottled, ports could accept any amount of data without getting throttled again. Fix this assumption. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-se

[Qemu-devel] [PATCH 2/8] virtio-serial: Unthrottle ports once they're closed

2010-04-07 Thread Amit Shah
Disable throttling once a port is closed (and we discard all the unconsumed buffers in the vq). Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index 5df9b6b..8d77c94 10

[Qemu-devel] [PATCH 3/8] virtio-serial: Discard unconsumed data before sending port close event

2010-04-07 Thread Amit Shah
The guest kernel can reclaim the buffers when it receives the port close event or when a port is being removed. Ensure we free up the buffers before we send out any events to the guest. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 13 + 1 files changed, 9 insertions(+), 4

[Qemu-devel] [PATCH 4/8] virtio-serial: Bus info message for showing port's throttled status

2010-04-07 Thread Amit Shah
Show whether a port is throttled in 'info qtree'. Also reduce LOC by 1 by assigning 'throttled' status just once. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c inde

[Qemu-devel] [PATCH 5/8] char: Let writers know how much data was written in case of errors

2010-04-07 Thread Amit Shah
On writing errors, we just returned -1 even if some bytes were already written out. Ensure we return the number of bytes written before we return the error (on a subsequent call to qemu_chr_write()). Signed-off-by: Amit Shah --- qemu-char.c |9 +++-- 1 files changed, 7 insertions(+), 2 d

[Qemu-devel] [PATCH 6/8] char: unix: For files that are nonblocking, report -EAGAIN to calling functions

2010-04-07 Thread Amit Shah
If the chardev we're writing to is nonblocking, just report -EAGAIN to the caller so that the caller can take any further action if it so wishes. Signed-off-by: Amit Shah --- qemu-char.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.

[Qemu-devel] [PATCH 7/8] virtio-console: Factor out common init between console and generic ports

2010-04-07 Thread Amit Shah
The initialisation for generic ports and console ports is similar. Factor out the parts that are the same in a different function that can be called from each of the initfns. Signed-off-by: Amit Shah --- hw/virtio-console.c | 31 ++- 1 files changed, 14 insertions(+

[Qemu-devel] [PATCH 8/8] virtio-console: Throttle virtio-serial-bus if we can't consume any more guest data

2010-04-07 Thread Amit Shah
If the char device we're connected to is overwhelmed with data and it can't accept any more, signal to the virtio-serial-bus to stop sending us more data till we tell otherwise. If the current buffer being processed hasn't been completely written out to the char device, we have to keep it around a

Re: [Qemu-devel] Shared file help

2010-04-07 Thread Arpit Patel
I am still not able to figure out, how to use it. Can you please point me to some document or give little bit more details, how shall I use sshfs? I am using *qemu -kernel kernelimage -initrd initrd.img /dev/zero -append "cmdline"* to use qemu to boot from the kernel I build. But don't know how t

[Qemu-devel] [PATCH 00/13] target-alpha improvements, version 4

2010-04-07 Thread Richard Henderson
Changes from v3->v4: * Use the standard implementation of load-locked/store-conditional. I think it's pretty gross, but probably better to be consistent with the other ports. And at least the port continues to build when the host compiler doesn't support __sync_bool_compare_and_swap.

[Qemu-devel] [PATCH 04/13] target-alpha: Implement cvtql inline.

2010-04-07 Thread Richard Henderson
It's a simple mask and shift sequence. Also, fix a typo in the actual masks used. Signed-off-by: Richard Henderson --- target-alpha/helper.h|4 target-alpha/op_helper.c | 20 target-alpha/translate.c | 45 +++-- 3 file

[Qemu-devel] [PATCH 02/13] target-alpha: Implement cpys{, n, e} inline.

2010-04-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-alpha/helper.h|4 -- target-alpha/op_helper.c | 18 -- target-alpha/translate.c | 78 +++-- 3 files changed, 74 insertions(+), 26 deletions(-) diff --git a/target-alpha/helper.h b/target-alpha

[Qemu-devel] [PATCH 05/13] target-alpha: Implement cvtlq inline.

2010-04-07 Thread Richard Henderson
It's a simple shift and mask sequence. Signed-off-by: Richard Henderson --- target-alpha/helper.h|1 - target-alpha/op_helper.c |7 --- target-alpha/translate.c | 23 ++- 3 files changed, 22 insertions(+), 9 deletions(-) diff --git a/target-alpha/helper.h b

[Qemu-devel] [PATCH 06/13] target-alpha: Use setcond for int comparisons.

2010-04-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-alpha/translate.c | 43 ++- 1 files changed, 22 insertions(+), 21 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index dff03ef..adeff0a 100644 --- a/target-alpha/translate.c +++ b

[Qemu-devel] [PATCH 09/13] target-alpha: Update commentary for opcode 0x1A.

2010-04-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-alpha/translate.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index dfe55c3..2360a0e 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -2534

[Qemu-devel] [PATCH 01/13] target-alpha: Add flags markups to helpers.h.

2010-04-07 Thread Richard Henderson
Almost all alpha helpers are at least TCG_CALL_CONST and a fair few are also TCG_CALL_PURE. Signed-off-by: Richard Henderson --- target-alpha/helper.h | 184 1 files changed, 92 insertions(+), 92 deletions(-) diff --git a/target-alpha/helper.h b

[Qemu-devel] [PATCH 10/13] target-alpha: Enable NPTL.

2010-04-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- configure|1 + linux-user/syscall.c |2 +- target-alpha/cpu.h | 28 +--- 3 files changed, 19 insertions(+), 12 deletions(-) diff --git a/configure b/configure index 1d5fb17..37f2ba7 100755 --- a/configure +++ b/

[Qemu-devel] [PATCH 07/13] target-alpha: Use non-inverted arguments to gen_{f}cmov.

2010-04-07 Thread Richard Henderson
The inverted conditions as argument to the function looks wrong at a glance inside translate_one. Since we have an easy function to produce the inversion now, use it. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 37 +++-- 1 files changed, 19

[Qemu-devel] [PATCH 03/13] target-alpha: Implement rs/rc properly.

2010-04-07 Thread Richard Henderson
This is a per-cpu flag; there's no need for a spinlock of any kind. We were also failing to manipulate the flag with $31 as a target reg and failing to clear the flag on execution of a return-from-interrupt instruction. Signed-off-by: Richard Henderson --- linux-user/main.c|5 +

[Qemu-devel] [PATCH 11/13] target-alpha: Indicate NORETURN status when raising exception.

2010-04-07 Thread Richard Henderson
When (indirectly) calling raise_exception, don't emit cleanup code at the end of the TB, as it is unused. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 27 ++- 1 files changed, 14 insertions(+), 13 deletions(-) diff --git a/target-alpha/translate.c b/

[Qemu-devel] [PATCH 08/13] target-alpha: Emit goto_tb opcodes.

2010-04-07 Thread Richard Henderson
Use an ExitStatus enumeration instead of magic numbers as the return value from translate_one. Emit goto_tb opcodes when ending a TB via a direct branch. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 339 ++ 1 files changed, 193 ins

[Qemu-devel] [PATCH 13/13] target-alpha: Implement RPCC.

2010-04-07 Thread Richard Henderson
A minimal implementation that more or less corresponds to the user-level version used by target-i386. More hoops will want to be jumped through when alpha gets system-level emulation. Signed-off-by: Richard Henderson --- qemu-timer.h | 13 + target-alpha/cpu.h |

  1   2   >