Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Alexander Graf
On 24.03.2010, at 22:33, Luiz Capitulino wrote: > On Wed, 24 Mar 2010 21:54:09 +0100 > Alexander Graf wrote: > >> >> On 24.03.2010, at 21:32, Anthony Liguori wrote: >> >>> On 03/24/2010 03:12 PM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 21:49:45 +0200 Avi Kivity wrote:

Re: [Qemu-devel] QEMU state of ARM NEON support.

2010-03-25 Thread Juha.Riihimaki
Hi, Thanks for the testing. I fixed all of the issues found by your test programs except: - vmull.p8 is not implemented in QEMU. - vrecpe/vrsqrte returns exact reciprocal/root in QEMU instead of estimate. - Using subnormal floating point input values yields wrong results (this is visible in y

Re: [Qemu-devel] TBL register permissions for PPC

2010-03-25 Thread Alexander Graf
On 24.03.2010, at 22:56, Dmitry Ilyevsky wrote: > > Hello All, > > Please review patch for TBL SPR read access for generic PPC. > > Description: > > POWER specification docs define TBL/TBU SPRs as readable in user and > privileged modes. Therefore SPRs permissions were changed in gen_tbl fun

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Alexander Graf
On 25.03.2010, at 07:37, Avi Kivity wrote: > On 03/24/2010 10:32 PM, Anthony Liguori wrote: >> >> So far, a libqemu.so with a flexible transport that could be used directly >> by a libvirt user (ala cairo/gdk type interactions) seems like the best >> solution to me. > > > libqemu.so would be

[Qemu-devel] Re: [PATCH] update bochs vbe interface

2010-03-25 Thread Gerd Hoffmann
On 03/24/10 23:28, Juan Quintela wrote: Humm, I think it means. Can you migrate from a "new" vga to an old one, and maintain it working? Depends on the vgabios version. vgabios 0.6c will not support vesa gfx modes on older qemu, no matter whenever you started fresh or migrated to it. -

Re: [Qemu-devel] Re: Compile files only once: some planning

2010-03-25 Thread Michael S. Tsirkin
On Wed, Mar 24, 2010 at 06:07:35PM -0500, Anthony Liguori wrote: > On 03/24/2010 06:05 PM, Paul Brook wrote: >>> On 03/24/2010 05:33 PM, Paul Brook wrote: >>> > But now there is a bigger problem, how to pass the property to the > device. It's not fair to require the user to remember t

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Vincent Hanquez
On 24/03/10 21:40, Anthony Liguori wrote: If so, what C clients you expected beyond libvirt? Users want a C API. I don't agree that libvirt is the only C interface consumer out there. (I've seen this written too many times ...) How do you know that ? did you do a poll or something where *ac

[Qemu-devel] Re: [PATCH v2] update bochs vbe interface

2010-03-25 Thread Gerd Hoffmann
/mnt/kvm/qemu/qemu-negotiate/hw/vga.c:2219: error: invalid operands to binary - (have ‘uint16_t (*)[10]’ and ‘uint16_t (*)[11]’) Huh? I was pretty sure I've compiled it, but obviously I didn't ... /me goes look for a brown paperbag. cheers, Gerd

[Qemu-devel] Re: [PATCH] update bochs vbe interface

2010-03-25 Thread Juan Quintela
Gerd Hoffmann wrote: > On 03/24/10 23:28, Juan Quintela wrote: >> Humm, I think it means. Can you migrate from a "new" vga to an old one, >> and maintain it working? > > Depends on the vgabios version. > > vgabios 0.6c will not support vesa gfx modes on older qemu, no matter > whenever you starte

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Avi Kivity
On 03/25/2010 10:26 AM, Vincent Hanquez wrote: On 24/03/10 21:40, Anthony Liguori wrote: If so, what C clients you expected beyond libvirt? Users want a C API. I don't agree that libvirt is the only C interface consumer out there. (I've seen this written too many times ...) How do you know

[Qemu-devel] [PATCH] Fix 64-bit off_t syscall argument passing in linux-user

2010-03-25 Thread Tomasz Łukaszewski
Hello, I am evaluating the possibility to use linux-user emulation in qemu for automatic regression testing for some embedded linux projects in the company I work for. I've encountered some problems with syscall interface while testing mips(el), powerpc and arm code, and I am willing to fix them.

[Qemu-devel] Re: [PATCH v3 0/2] Inter-VM shared memory PCI device

2010-03-25 Thread Avi Kivity
On 03/25/2010 08:08 AM, Cam Macdonell wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository. Chan

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: > This patch adds a driver for my shared memory PCI device using the uio_pci > interface. The driver has three memory regions. The first memory region is > for > device registers for sending interrupts. The second BAR is for receivin

[Qemu-devel] Re: [PATCH] update bochs vbe interface

2010-03-25 Thread Gerd Hoffmann
Hi, Then our big problem is migration between read of the 1st register and of the 2nd register, no? "big"? The window is quite small, and I think we have a bunch of simliar issues elsewhere in qemu. They are hardly avoidable for new -> old migration when adding new features to emulated d

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: > This patch adds a driver for my shared memory PCI device using the uio_pci > interface. The driver has three memory regions. The first memory region is > for > device registers for sending interrupts. The second BAR is for receivin

Re: [Qemu-devel] Significant performance regression in qemu-system-mips.

2010-03-25 Thread Artyom Tarasenko
2010/3/24 Rob Landley : > I have a native build under qemu that gets killed if it doesn't produce a line > of output for 60 seconds (hang detection enforced by the host monitoring > qemu's stdout with --nographic, not from within qemu). > > In the most recent release version, it never came close to

[Qemu-devel] Re: [PATCH v3 0/2] Inter-VM shared memory PCI device

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 11:04:54AM +0200, Avi Kivity wrote: > Again, I recommend Rusty's virtio-pci for inspiration. Not just inspiration, how about building on virtio-pci? -- MST

[Qemu-devel] Re: [PATCH v3 0/2] Inter-VM shared memory PCI device

2010-03-25 Thread Markus Armbruster
Avi Kivity writes: > Please put the spec somewhere publicly accessible with a permanent > URL. I suggest a new qemu.git directory specs/. It's more important > than the code IMO. What about docs/? It already exists. [...]

[Qemu-devel] Re: [PATCH v3 0/2] Inter-VM shared memory PCI device

2010-03-25 Thread Avi Kivity
On 03/25/2010 11:26 AM, Markus Armbruster wrote: Avi Kivity writes: Please put the spec somewhere publicly accessible with a permanent URL. I suggest a new qemu.git directory specs/. It's more important than the code IMO. What about docs/? It already exists. docs/ would be

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 11:15 AM, Michael S. Tsirkin wrote: - Why are you using 32 bit long memory accesses for interrupts? 16 bit IO eould be enough and it's faster. This what virtio-pci does. Why is 16 bit io faster? -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] Re: KVM call agenda for Mar 23

2010-03-25 Thread Jes Sorensen
On 03/25/10 10:39, Jan Kiszka wrote: Zhang, Xiantao wrote: For ia64 part, maybe we can keep the current qemu-kvm.git for the users. And it is not a must to push it into Qemu upstream. Xiantao Does it still build& work? Does someone test it at least infrequently? Or are there users? There w

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 08:09 AM, Cam Macdonell wrote: This patch adds a driver for my shared memory PCI device using the uio_pci interface. The driver has three memory regions. The first memory region is for device registers for sending interrupts. The second BAR is for receiving MSI-X interrupts and th

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 11:05 AM, Michael S. Tsirkin wrote: coding style rule violation Plus it uses spaces instead of tabs for indents. -- error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 11:40:09AM +0200, Avi Kivity wrote: > On 03/25/2010 11:15 AM, Michael S. Tsirkin wrote: >> >> - Why are you using 32 bit long memory accesses for interrupts? >>16 bit IO eould be enough and it's faster. This what virtio-pci does. >> >> > > Why is 16 bit io faster? S

Re: [Qemu-devel] Re: KVM call agenda for Mar 23

2010-03-25 Thread Jan Kiszka
Zhang, Xiantao wrote: > Jes Sorensen wrote: >> On 03/23/10 13:45, Anthony Liguori wrote: >>> I don't think we can pull in: >>> >>> - extboot >>> - ia64 >>> - in-kernel pit[1] >>> - associated command line options >>> - device passthrough >>> >>> The question is, if we dropped those things, would pe

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 11:44 AM, Michael S. Tsirkin wrote: On Thu, Mar 25, 2010 at 11:40:09AM +0200, Avi Kivity wrote: On 03/25/2010 11:15 AM, Michael S. Tsirkin wrote: - Why are you using 32 bit long memory accesses for interrupts? 16 bit IO eould be enough and it's faster. This what virt

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 11:58:30AM +0200, Avi Kivity wrote: > On 03/25/2010 11:44 AM, Michael S. Tsirkin wrote: >> On Thu, Mar 25, 2010 at 11:40:09AM +0200, Avi Kivity wrote: >> >>> On 03/25/2010 11:15 AM, Michael S. Tsirkin wrote: >>> - Why are you using 32 bit long memory accesses

Re: [Qemu-devel] QEMU state of ARM NEON support.

2010-03-25 Thread Dmitry Zhurikhin
juha.riihim...@nokia.com wrote: Hi, Thanks for the testing. I fixed all of the issues found by your test programs except: Great! This is very good news. Please look at my comments below regarding specific issues. - vmull.p8 is not implemented in QEMU. So seems this is now the only NEON in

[Qemu-devel] [PATCH v3] update bochs vbe interface

2010-03-25 Thread Gerd Hoffmann
The bochs vbe interface got a new register a while back, which specifies the linear framebuffer size in 64k units. This patch adds support for the new register to qemu. With this patch applied vgabios 0.6c works with qemu. [ v2: Don't savevm the new register. Doing so breaks migration,

Re: [Qemu-devel] QEMU state of ARM NEON support.

2010-03-25 Thread Juha.Riihimaki
On Mar 25, 2010, at 12:27, ext Dmitry Zhurikhin wrote: > juha.riihim...@nokia.com wrote: >> - vqdmlsl yields different results for some specific input values, however I >> think QEMU is producing correct results. For example, >> 1431655765-(2*-32768*-32768)=-715827883 but your reference hardwar

Re: [Qemu-devel] Re: Compile files only once: some planning

2010-03-25 Thread Paul Brook
> I'd prefer a generic address type since this makes it easier to > share code: for example virtio devices can use different busses, This is exactly why virtio devices should not be accessing memory. They should be doing everything via a virtqueue, which can interface with the host bindings appr

[Qemu-devel] Re: [PATCH] qemu: jaso-parser: Output the content of invalid keyword

2010-03-25 Thread Richard Henderson
On 03/24/2010 08:12 AM, Amos Kong wrote: > > When input some invialid word 'unknowcmd' through QMP port, qemu outputs this > error message: > "parse error: invalid keyword `%s'" > This patch makes qemu output the content of invalid keyword, like: > "parse error: invalid keyword `unknowcmd'" > > S

[Qemu-devel] Re: [PATCH] update bochs vbe interface

2010-03-25 Thread Juan Quintela
Gerd Hoffmann wrote: > Hi, > >> Then our big problem is migration between read of the 1st register and >> of the 2nd register, no? > > "big"? That is why I asked. I have no clue about how many times that register is read. > The window is quite small, and I think we have a bunch of > simliar

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Anthony Liguori
On 03/25/2010 03:26 AM, Vincent Hanquez wrote: On 24/03/10 21:40, Anthony Liguori wrote: If so, what C clients you expected beyond libvirt? Users want a C API. I don't agree that libvirt is the only C interface consumer out there. (I've seen this written too many times ...) How do you know

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Avi Kivity
On 03/25/2010 02:33 PM, Anthony Liguori wrote: From my point of view, i wouldn't want to write a high level management toolstack in C, specially since the API is well defined JSON which is easily available in all high level language out there. There's a whole world of C based management tools

[Qemu-devel] [PATCH][RESEND] Serial: DOS Plus regression

2010-03-25 Thread Roy Tam
The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents booting Digital Research DOSPlus. Following patch partially reverts that commit and makes DOSPlus booting in QEMU again. Sign-off-by: Roy Tam -- diff --git a/hw/serial.c b/hw/serial.c index f3ec36a..2ae550e 100644 --- a/hw/serial.c

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Luiz Capitulino
On Wed, 24 Mar 2010 16:40:18 -0500 Anthony Liguori wrote: > >> We need to have a common management interface for third party tools. > >> > > QMP? :-) > > Only if QMP is compatible with libvirt. I don't want a user to have to > choose between QMP and libvirt. Why not? If all they want

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Gildas Le Nadan
Anthony Liguori wrote: On 03/25/2010 03:26 AM, Vincent Hanquez wrote: On 24/03/10 21:40, Anthony Liguori wrote: If so, what C clients you expected beyond libvirt? Users want a C API. I don't agree that libvirt is the only C interface consumer out there. (I've seen this written too many ti

Re: [Qemu-devel] [PATCH 09/10] target-alpha: Implement load-locked/store-conditional properly.

2010-03-25 Thread Nathan Froyd
On Wed, Mar 24, 2010 at 05:11:43PM -0700, Richard Henderson wrote: > Use __sync_bool_compare_and_swap to yield correctly atomic results. > As yet, this assumes running on an strict-memory-ordering host (i.e. x86), > since we're still "implementing" the memory-barrier instructions as nops. Did the

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Anthony Liguori
On 03/25/2010 07:37 AM, Avi Kivity wrote: On 03/25/2010 02:33 PM, Anthony Liguori wrote: From my point of view, i wouldn't want to write a high level management toolstack in C, specially since the API is well defined JSON which is easily available in all high level language out there. There'

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Avi Kivity
On 03/25/2010 03:44 PM, Anthony Liguori wrote: On 03/25/2010 07:37 AM, Avi Kivity wrote: On 03/25/2010 02:33 PM, Anthony Liguori wrote: From my point of view, i wouldn't want to write a high level management toolstack in C, specially since the API is well defined JSON which is easily available

[Qemu-devel] [patch 2/2] virtio-serial-bus: wake up iothread upon guest read notification

2010-03-25 Thread Marcelo Tosatti
Wake up iothread when buffers are consumed. Signed-off-by: Marcelo Tosatti Index: qemu-ioworker/hw/virtio-serial-bus.c === --- qemu-ioworker.orig/hw/virtio-serial-bus.c +++ qemu-ioworker/hw/virtio-serial-bus.c @@ -331,6 +331,7 @@ st

[Qemu-devel] [patch 0/2] introduce QEMUIOWorker and wake up iothread on virtio-serial-bus notification (v2)

2010-03-25 Thread Marcelo Tosatti
Rebased to latest qemu.git.

[Qemu-devel] [patch 1/2] Pass QEMUIOWorker to qemu_notify_event

2010-03-25 Thread Marcelo Tosatti
This can be used later to introduce generic iothread workers. Signed-off-by: Marcelo Tosatti Index: qemu-ioworker/async.c === --- qemu-ioworker.orig/async.c +++ qemu-ioworker/async.c @@ -180,7 +180,7 @@ void qemu_bh_schedule(QEMUBH

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Anthony Liguori
On 03/25/2010 08:23 AM, Luiz Capitulino wrote: On Wed, 24 Mar 2010 16:40:18 -0500 Anthony Liguori wrote: We need to have a common management interface for third party tools. QMP? :-) Only if QMP is compatible with libvirt. I don't want a user to have to choose betw

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Anthony Liguori
On 03/25/2010 08:48 AM, Avi Kivity wrote: But an awful lot of the providers for pegasus are written in C. But we're concerned with only one, the virt provider. None of the others will use libqemu? The point is, C is a lowest common denominator and it's important to support in a proper way

[Qemu-devel] [PATCH] balloon: Fix overflow when reporting actual memory size

2010-03-25 Thread Adam Litke
Beginning with its introduction, the virtio balloon has had an overflow error that causes 'info balloon' to misreport the actual memory size when the balloon itself becomes larger than 4G. Use a cast when converting dev->actual from pages to kB to prevent overflows. Before: (qemu) info balloon b

[Qemu-devel] [PATCH 2/3] S390: Tell user why VM creation failed

2010-03-25 Thread Alexander Graf
The KVM kernel module on S390 refuses to create a VM when the switch_amode kernel parameter is not used. Since that is not exactly obvious, let's give the user a nice warning. Signed-off-by: Alexander Graf --- kvm-all.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --gi

[Qemu-devel] [PATCH 3/3] S390: Don't compile in virtio-pci

2010-03-25 Thread Alexander Graf
As soon as virtio-pci.c gets compiled and used on S390 the internal qdev magic gets confused and tries to give us PCI devices instead of S390 virtio devices. Since we don't have PCI on S390, we can safely not compile virtio-pci at all. In order to do this I added a new config option "CONFIG_VIRTI

[Qemu-devel] [PATCH 1/3] S390: Add stub for cpu_get_phys_page_debug

2010-03-25 Thread Alexander Graf
We don't implement any virtual memory in the S390 target so far, so let's add a stub for this now mandatory function. Fixes building of S390 target. Signed-off-by: Alexander Graf --- target-s390x/helper.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-s390x/

[Qemu-devel] [PATCH 0/3] Fix S390x target v2

2010-03-25 Thread Alexander Graf
We're in a bad situation with the S390 qemu target. It only works with KVM, so people can't test it when they don't have access to a real S390 machine. While trying to build and use s390x-softmmu again I stumbled across a couple of issues, all addressed in this patch set. The patches should all no

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Daniel P. Berrange
On Thu, Mar 25, 2010 at 08:26:09AM +, Vincent Hanquez wrote: > On 24/03/10 21:40, Anthony Liguori wrote: > >>If so, what C clients you expected beyond libvirt? > > > >Users want a C API. I don't agree that libvirt is the only C > >interface consumer out there. > > (I've seen this written too

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Luiz Capitulino
On Thu, 25 Mar 2010 08:57:36 -0500 Anthony Liguori wrote: > On 03/25/2010 08:48 AM, Avi Kivity wrote: > >> > >> But an awful lot of the providers for pegasus are written in C. > > > > But we're concerned with only one, the virt provider. None of the > > others will use libqemu? > > > >> The poi

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Avi Kivity
On 03/25/2010 03:57 PM, Anthony Liguori wrote: On 03/25/2010 08:48 AM, Avi Kivity wrote: But an awful lot of the providers for pegasus are written in C. But we're concerned with only one, the virt provider. None of the others will use libqemu? The point is, C is a lowest common denominato

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Vincent Hanquez
On Thu, Mar 25, 2010 at 08:57:36AM -0500, Anthony Liguori wrote: > Why? > > We can provide a generic QMP dispatch interface that high level > languages can use. Then they can do fancy dispatch, treat QErrors as > exceptions, etc. Because more than likely it will be more efforts than doing the

[Qemu-devel] [PATCH] Add qerror message if the 'change' target filename can't be opened

2010-03-25 Thread Ryan Harper
Currently when using the change command to switch the file in the cd drive the command doesn't complain if the file doesn't exit or can't be opened and the drive keeps the existing image. This patch adds a qerror_report call to print a message out indicating the failure. This error message can be

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Vincent Hanquez
On Thu, Mar 25, 2010 at 01:59:22PM +, Daniel P. Berrange wrote: > > From my point of view, i wouldn't want to write a high level management > > toolstack in C, specially > > since the API is well defined JSON which is easily available in all high > > level language out there. > > It was pret

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Daniel P. Berrange
On Thu, Mar 25, 2010 at 02:56:52PM +, Vincent Hanquez wrote: > On Thu, Mar 25, 2010 at 01:59:22PM +, Daniel P. Berrange wrote: > > > From my point of view, i wouldn't want to write a high level management > > > toolstack in C, specially > > > since the API is well defined JSON which is eas

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Vincent Hanquez
On Thu, Mar 25, 2010 at 03:07:20PM +, Daniel P. Berrange wrote: > I agree apps shouldn't use it for RPC, but admins using the interactive user > monitor are just as deserving of stable commands & args. I think, once QMP is completely there, admins would be better using a qemu-cmd that's just

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Daniel P. Berrange
On Thu, Mar 25, 2010 at 03:14:24PM +, Vincent Hanquez wrote: > On Thu, Mar 25, 2010 at 03:07:20PM +, Daniel P. Berrange wrote: > > I agree apps shouldn't use it for RPC, but admins using the interactive > > user > > monitor are just as deserving of stable commands & args. > > I think, o

Re: [Qemu-devel] [PATCH 09/10] target-alpha: Implement load-locked/store-conditional properly.

2010-03-25 Thread Richard Henderson
On 03/25/2010 06:39 AM, Nathan Froyd wrote: > On Wed, Mar 24, 2010 at 05:11:43PM -0700, Richard Henderson wrote: >> Use __sync_bool_compare_and_swap to yield correctly atomic results. >> As yet, this assumes running on an strict-memory-ordering host (i.e. x86), >> since we're still "implementing" t

[Qemu-devel] Re: [PATCH] update bochs vbe interface

2010-03-25 Thread Gerd Hoffmann
On 03/25/10 13:14, Juan Quintela wrote: Gerd Hoffmann wrote: Hi, Then our big problem is migration between read of the 1st register and of the 2nd register, no? "big"? That is why I asked. I have no clue about how many times that register is read. Once at boot. If it is only read

[Qemu-devel] Re: [PATCH v2 11/11] monitor: New commands netdev_add, netdev_del

2010-03-25 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 22 Mar 2010 10:48:53 +0100 > Markus Armbruster wrote: > >> Monitor commands to go with -netdev. >> >> Signed-off-by: Markus Armbruster >> --- >> net.c | 57 >> ++- >> net.h |2 + >>

Re: [Qemu-devel] [PATCH] Fix 64-bit off_t syscall argument passing in linux-user

2010-03-25 Thread Richard Henderson
On 03/25/2010 02:04 AM, Tomasz Łukaszewski wrote: > +#if TARGET_ABI_BITS == 32 > +#ifdef TARGET_ARM > +if (((CPUARMState *)cpu_env)->eabi) > + { > +arg4 = arg5; > +arg5 = arg6; > + } > +#endif > +#if defined TARGET_PPC || defined TARGET_MIPS > +arg4 = arg5; > +

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Anthony Liguori
On 03/25/2010 09:09 AM, Luiz Capitulino wrote: We can provide a generic QMP dispatch interface that high level languages can use. Then they can do fancy dispatch, treat QErrors as exceptions, etc. They can do that by accessing QMP directly. Why would a Python developer get in the mess

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Anthony Liguori
On 03/25/2010 10:16 AM, Daniel P. Berrange wrote: On Thu, Mar 25, 2010 at 03:14:24PM +, Vincent Hanquez wrote: On Thu, Mar 25, 2010 at 03:07:20PM +, Daniel P. Berrange wrote: I agree apps shouldn't use it for RPC, but admins using the interactive user monitor are just as deser

Re: [Qemu-devel] [PATCH 09/10] target-alpha: Implement load-locked/store-conditional properly.

2010-03-25 Thread Nathan Froyd
On Thu, Mar 25, 2010 at 08:46:06AM -0700, Richard Henderson wrote: > On 03/25/2010 06:39 AM, Nathan Froyd wrote: > > On Wed, Mar 24, 2010 at 05:11:43PM -0700, Richard Henderson wrote: > >> Use __sync_bool_compare_and_swap to yield correctly atomic results. > >> As yet, this assumes running on an st

Re: WIP flush-to-zero patch [was: Re: [Qemu-devel] QEMU state of ARM NEON support.]

2010-03-25 Thread Richard Henderson
On 03/25/2010 07:00 AM, Nathan Froyd wrote: > FWIW, below is a WIP progress patch to implement flush-to-zero better. > The motivating observation is that many chips feature separate > flush-input and flush-output flags and QEMU's fpu/ library only > implements flush-output. So the bulk of the patc

[Qemu-devel] Re: [PATCH v3 0/2] Inter-VM shared memory PCI device

2010-03-25 Thread Cam Macdonell
On Thu, Mar 25, 2010 at 3:21 AM, Michael S. Tsirkin wrote: > On Thu, Mar 25, 2010 at 11:04:54AM +0200, Avi Kivity wrote: >> Again, I recommend Rusty's virtio-pci for inspiration. > > Not just inspiration, how about building on virtio-pci? Virtio was discussed at good length last year on a previou

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Cam Macdonell
On Thu, Mar 25, 2010 at 3:15 AM, Michael S. Tsirkin wrote: > On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: >> This patch adds a driver for my shared memory PCI device using the uio_pci >> interface.  The driver has three memory regions.  The first memory region is >> for >> devic

[Qemu-devel] [PATCH v3 04/11] error: New QERR_INVALID_PARAMETER_VALUE

2010-03-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 9fb817e..97e8d4a 100644 --- a/qerror.c +++ b/qerror.c @@ -121,6 +121,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH v3 00/11] monitor: New commands netdev_add, netdev_del

2010-03-25 Thread Markus Armbruster
v2: Avoid loss of help in parse_option_size(). Rebased. v3: Fix detection of duplicate netdev id. Markus Armbruster (11): error: Put error definitions back in alphabetical order error: New QERR_DUPLICATE_ID error: Convert qemu_opts_create() to QError error: New QERR_INVALID_PARAMETER_VAL

[Qemu-devel] [PATCH v3 02/11] error: New QERR_DUPLICATE_ID

2010-03-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 4520b0d..9fb817e 100644 --- a/qerror.c +++ b/qerror.c @@ -97,6 +97,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH v3 03/11] error: Convert qemu_opts_create() to QError

2010-03-25 Thread Markus Armbruster
Fixes device_add to report duplicate ID properly in QMP, as DuplicateId instead of UndefinedError. Signed-off-by: Markus Armbruster --- qemu-option.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index f83d07c..12ce322 100644 --- a/qemu

[Qemu-devel] [PATCH v3 01/11] error: Put error definitions back in alphabetical order

2010-03-25 Thread Markus Armbruster
Add suitable comments to help keerp them in order. Signed-off-by: Markus Armbruster --- qerror.c | 12 qerror.h |8 +--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/qerror.c b/qerror.c index eaa1deb..4520b0d 100644 --- a/qerror.c +++ b/qerror.c @@ -38,6

[Qemu-devel] [PATCH v3 07/11] error: Use QERR_INVALID_PARAMETER_VALUE instead of QERR_INVALID_PARAMETER

2010-03-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/qdev.c |2 +- monitor.c |6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 17a46a7..f45ed0f 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -207,7 +207,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)

[Qemu-devel] [PATCH v3 08/11] error: Convert qemu_opts_validate() to QError

2010-03-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-option.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 394c763..1ffc497 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -877,8 +877,7 @@ int qemu_opts_validate(QemuOpts *opts, const QemuO

[Qemu-devel] [PATCH v3 10/11] error: New QERR_DEVICE_IN_USE

2010-03-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 97e8d4a..8d885cd 100644 --- a/qerror.c +++ b/qerror.c @@ -69,6 +69,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH v3 05/11] error: Convert qemu_opts_set() to QError

2010-03-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-option.c | 17 +++-- 1 files changed, 7 insertions(+), 10 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 12ce322..394c763 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -176,7 +176,7 @@ static int parse_option_bool(const

[Qemu-devel] [PATCH v3 11/11] monitor: New commands netdev_add, netdev_del

2010-03-25 Thread Markus Armbruster
Monitor commands to go with -netdev. Signed-off-by: Markus Armbruster --- net.c | 55 +++ net.h |2 ++ qemu-monitor.hx | 30 ++ 3 files changed, 87 insertions(+), 0 deletions(-) diff --gi

[Qemu-devel] [PATCH v3 06/11] error: Drop extra messages after qemu_opts_set() and qemu_opts_parse()

2010-03-25 Thread Markus Armbruster
Both functions report errors nicely enough now, no need for additional messages. Signed-off-by: Markus Armbruster --- hw/pci-hotplug.c |2 -- net.c|2 -- qemu-config.c|1 - vl.c |5 - 4 files changed, 0 insertions(+), 10 deletions(-) diff --git a/

[Qemu-devel] [PATCH v3 09/11] error: Convert net_client_init() to QError

2010-03-25 Thread Markus Armbruster
The conversion is shallow: client type init() methods aren't converted. Converting them is a big job for relatively little practical benefit, so leave it for later. Signed-off-by: Markus Armbruster --- net.c | 38 ++ 1 files changed, 18 insertions(+), 20 de

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Anthony Liguori
On 03/25/2010 11:18 AM, Cam Macdonell wrote: On Thu, Mar 25, 2010 at 3:15 AM, Michael S. Tsirkin wrote: On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: This patch adds a driver for my shared memory PCI device using the uio_pci interface. The driver has three memory re

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Cam Macdonell
On Thu, Mar 25, 2010 at 3:46 AM, Avi Kivity wrote: > On 03/25/2010 08:09 AM, Cam Macdonell wrote: >> >> This patch adds a driver for my shared memory PCI device using the uio_pci >> interface.  The driver has three memory regions.  The first memory region >> is for >> device registers for sending

Re: [Qemu-devel] [PATCH 09/10] target-alpha: Implement load-locked/store-conditional properly.

2010-03-25 Thread Richard Henderson
On 03/25/2010 09:06 AM, Nathan Froyd wrote: >> Mips doesn't even pretend to be atomic. > > It pretends just as much as ppc and arm. See translate.c:OP_ST_ATOMIC. No it doesn't. Look at HELPER_ST_ATOMIC: tmp = do_##ld_insn(arg2, mem_idx);\ if

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Alexander Graf
Anthony Liguori wrote: > On 03/25/2010 10:16 AM, Daniel P. Berrange wrote: >> On Thu, Mar 25, 2010 at 03:14:24PM +, Vincent Hanquez wrote: >> >>> On Thu, Mar 25, 2010 at 03:07:20PM +, Daniel P. Berrange wrote: >>> I agree apps shouldn't use it for RPC, but admins using the

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Cam Macdonell
On Thu, Mar 25, 2010 at 3:05 AM, Michael S. Tsirkin wrote: > On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: >> This patch adds a driver for my shared memory PCI device using the uio_pci >> interface.  The driver has three memory regions.  The first memory region is >> for >> devic

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 06:23 PM, Anthony Liguori wrote: There has been previous discussion of virtio, however while virtio is good for exporting guest memory, it's not ideal for importing memory into a guest. virtio is a DMA-based API which means that it doesn't assume cache coherent shared memory. Th

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 06:24 PM, Cam Macdonell wrote: There is now a generic PCI 2.3 driver that can handle all PCI devices. It doesn't support MSI, but if we add MSI support then it can be used without the need for a specialized driver. Agreed, I'd be happy to use the generic driver if MSI is t

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 11:05 AM, Michael S. Tsirkin wrote: +static struct pci_device_id ivshmem_pci_ids[] __devinitdata = { +{ +.vendor =0x1af4, +.device =0x1110, vendor ids must be registered with PCI SIG. this one does not seem to be registered. That's the Qumr

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 11:23:05AM -0500, Anthony Liguori wrote: > On 03/25/2010 11:18 AM, Cam Macdonell wrote: >> On Thu, Mar 25, 2010 at 3:15 AM, Michael S. Tsirkin wrote: >> >>> On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: >>> This patch adds a driver for my sha

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 10:30:42AM -0600, Cam Macdonell wrote: > On Thu, Mar 25, 2010 at 3:05 AM, Michael S. Tsirkin wrote: > > On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: > >> This patch adds a driver for my shared memory PCI device using the uio_pci > >> interface.  The driver

Re: [Qemu-devel] [PATCH] Add qerror message if the 'change' target filename can't be opened

2010-03-25 Thread Markus Armbruster
Ryan Harper writes: > Currently when using the change command to switch the file in the cd drive > the command doesn't complain if the file doesn't exit or can't be opened > and the drive keeps the existing image. This patch adds a qerror_report > call to print a message out indicating the failu

[Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 06:36:02PM +0200, Avi Kivity wrote: > On 03/25/2010 11:05 AM, Michael S. Tsirkin wrote: >> >>> +static struct pci_device_id ivshmem_pci_ids[] __devinitdata = { >>> +{ >>> +.vendor =0x1af4, >>> +.device =0x1110, >>> >> vendor ids must be regi

Re: [Qemu-devel] [PATCH 09/10] target-alpha: Implement load-locked/store-conditional properly.

2010-03-25 Thread Nathan Froyd
On Thu, Mar 25, 2010 at 09:29:18AM -0700, Richard Henderson wrote: > On 03/25/2010 09:06 AM, Nathan Froyd wrote: > > It pretends just as much as ppc and arm. See translate.c:OP_ST_ATOMIC. > > No it doesn't. Look at HELPER_ST_ATOMIC: > > tmp = do_##ld_insn(arg2, mem_idx);

[Qemu-devel] [PATCH -V3 00/32] virtio-9p: paravirtual file system passthrough

2010-03-25 Thread Aneesh Kumar K.V
This patch series adds a paravirtual file system passthrough mechanism to QEMU based on the 9P protocol. With the current implementation, all I/O is implemented in the VCPU thread. We've modified the protocol handlers so that we can support dispatch I/O in a thread pool. The actual thread pool i

[Qemu-devel] [PATCH -V3 02/32] vrtio-9p: Implement P9_TVERSION for 9P

2010-03-25 Thread Aneesh Kumar K.V
From: Anthony Liguori [ki...@linux.vnet.ibm.com: malloc to qemu_malloc coversion] Signed-off-by: Anthony Liguori Signed-off-by: Aneesh Kumar K.V --- hw/virtio-9p.c | 263 +++- 1 files changed, 261 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PATCH -V3 01/32] vitio-9p: Add a virtio 9p device to qemu

2010-03-25 Thread Aneesh Kumar K.V
From: Anthony Liguori This patch doesn't implement the 9p protocol handling code. It add a simple device which dump the protocl data Signed-off-by: Anthony Liguori Signed-off-by: Aneesh Kumar K.V --- Makefile.target |1 + hw/virtio-9p-debug.c | 442 ++

[Qemu-devel] [PATCH -V3 03/32] virtio-9p: Implement P9_TATTACH

2010-03-25 Thread Aneesh Kumar K.V
From: Anthony Liguori [jv...@linux.vnet.ibm.com: Added qemu_vasprintf] Signed-off-by: Anthony Liguori Signed-off-by: Aneesh Kumar K.V --- Makefile.target |2 +- hw/virtio-9p-local.c | 84 +++ hw/virtio-9p.c | 155 ++

[Qemu-devel] [PATCH -V3 06/32] virtio-9p: Implement P9_TOPEN

2010-03-25 Thread Aneesh Kumar K.V
From: Anthony Liguori Signed-off-by: Anthony Liguori Signed-off-by: Gautham R Shenoy Signed-off-by: Aneesh Kumar K.V --- hw/virtio-9p-local.c | 12 hw/virtio-9p.c | 145 +++-- 2 files changed, 151 insertions(+), 6 deletions(-) diff --

  1   2   3   >