[Qemu-devel] Re: [PATCH] Fix compiler warning on parsing the -usbdevice parameter

2010-03-08 Thread Jan Kiszka
Niels de Vos wrote: > Ah, just noticed this warning is only in Jans git... For those who > were wondering :) Yes, and I forgot to push my fixup. Thanks nevertheless. Jan > > Cheers, > Niels > > On 3/7/10, Niels de Vos wrote: >> With the added checks on the parameter for -usbdevice, the follow

Re: [Qemu-devel] [PATCH 0/2] Fix block_passwd monitor command error

2010-03-08 Thread Kevin Wolf
Am 05.03.2010 23:24, schrieb Shahar Havivi: > The next two patches fix the wrong error message in block_passwd > monitor command: when trying to decrypt un-encrypted drive, user > get error wrong password. > > "1" add error message to qerror.h and qerror.c > "2" patch the monitor command error han

Re: [Qemu-devel] bs->enable_write_cache and the guest ABI

2010-03-08 Thread Christoph Hellwig
On Sun, Mar 07, 2010 at 04:42:18PM +0200, Avi Kivity wrote: > This means that if I start a guest with cache=writethrough and then > restart (or live migrate) it with cache=none, then the guest will see a > change, even though the user only changed the drive's backing, not > something guest visib

Re: [Qemu-devel] bs->enable_write_cache and the guest ABI

2010-03-08 Thread Avi Kivity
On 03/08/2010 11:39 AM, Christoph Hellwig wrote: On Sun, Mar 07, 2010 at 04:42:18PM +0200, Avi Kivity wrote: This means that if I start a guest with cache=writethrough and then restart (or live migrate) it with cache=none, then the guest will see a change, even though the user only changed t

Re: [Qemu-devel] bs->enable_write_cache and the guest ABI

2010-03-08 Thread Jamie Lokier
Christoph Hellwig wrote: > On Sun, Mar 07, 2010 at 04:42:18PM +0200, Avi Kivity wrote: > > This means that if I start a guest with cache=writethrough and then > > restart (or live migrate) it with cache=none, then the guest will see a > > change, even though the user only changed the drive's back

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-08 Thread Alexander Graf
Am 08.03.2010 um 02:45 schrieb Jamie Lokier : Paul Brook wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to th

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-08 Thread Avi Kivity
On 03/08/2010 12:53 AM, Paul Brook wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository.

[Qemu-devel] Re: [PATCH] Support adding a file to qemu's ram allocation

2010-03-08 Thread Avi Kivity
On 03/06/2010 01:52 AM, Cam Macdonell wrote: This avoids the need of using qemu_ram_alloc and mmap with MAP_FIXED to map a host file into guest RAM. This function mmaps the opened file anywhere and adds the memory to the ram blocks. Usage is qemu_add_file_to_ram(fd, size, MAP_SHARED);

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-08 Thread Jamie Lokier
Alexander Graf wrote: > Or we could put in some code that tells the guest the host shm > architecture and only accept x86 on x86 for now. If anyone cares for > other combinations, they're free to implement them. > > Seriously, we're looking at an interface designed for kvm here. Let's > plea

[Qemu-devel] Re: [PATCH] Inter-VM shared memory PCI device

2010-03-08 Thread Avi Kivity
On 03/06/2010 01:52 AM, Cam Macdonell wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository. This

Re: [Qemu-devel] Regression: more 0.12 regression (SeaBIOS related?)

2010-03-08 Thread Jamie Lokier
Roy Tam wrote: > - can't type correctly in GW-BASIC from DOS 2.0 - 3.31 > - keyboard input is ignored when booting Korean edition of MS-DOS 6.20 > - can't type correctly in FreeDOS/V (Ver 0138, > http://homepage1.nifty.com/bible/dos/fdos0138.lzh ), getting Illegal > Instruction error when you type

[Qemu-devel] extended vga modes?

2010-03-08 Thread Michael Tokarev
After updating qemu-kvm Debian package to 0.12 we've a bugreport about missing video modes which were present in previous versions. Big thanks to the original reporter, Bjørn Mork, who found what the issue is. See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=572991 for the bugreport in questi

[Qemu-devel] Re: bs->enable_write_cache and the guest ABI

2010-03-08 Thread Juan Quintela
Avi Kivity wrote: > block.c says: > >> /* >> * Yes, BDRV_O_NOCACHE aka O_DIRECT means we have to present a >> * write cache to the guest. We do need the fdatasync to flush >> * out transactions for block allocations, and we maybe have a >> * volatile write cache in our bac

[Qemu-devel] Re: bs->enable_write_cache and the guest ABI

2010-03-08 Thread Avi Kivity
On 03/08/2010 12:29 PM, Juan Quintela wrote: Avi Kivity wrote: block.c says: /* * Yes, BDRV_O_NOCACHE aka O_DIRECT means we have to present a * write cache to the guest. We do need the fdatasync to flush * out transactions for block allocations, and we maybe

[Qemu-devel] Re: extended vga modes?

2010-03-08 Thread Avi Kivity
On 03/08/2010 12:20 PM, Michael Tokarev wrote: After updating qemu-kvm Debian package to 0.12 we've a bugreport about missing video modes which were present in previous versions. Big thanks to the original reporter, Bjørn Mork, who found what the issue is. See http://bugs.debian.org/cgi-bin/bug

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-08 Thread Alexander Graf
Jamie Lokier wrote: > Alexander Graf wrote: > >> Or we could put in some code that tells the guest the host shm >> architecture and only accept x86 on x86 for now. If anyone cares for >> other combinations, they're free to implement them. >> >> Seriously, we're looking at an interface design

[Qemu-devel] Re: extended vga modes?

2010-03-08 Thread Michael Tokarev
Avi Kivity wrote: [] >> In short, when vgabios were dropped from qemu-kvm >> (for whatever yet unknown reason), > > What do you mean? qemu-kvm still carries a local vgabios (see > kvm/vgabios in qemu-kvm.git). Oh my. So we all overlooked it. I asked you several times about the bios sources, in

Re: [Qemu-devel] Regression: more 0.12 regression (SeaBIOS related?)

2010-03-08 Thread Roy Tam
2010/3/8 Jamie Lokier : > Roy Tam wrote: >> - can't type correctly in GW-BASIC from DOS 2.0 - 3.31 >> - keyboard input is ignored when booting Korean edition of MS-DOS 6.20 >> - can't type correctly in FreeDOS/V (Ver 0138, >> http://homepage1.nifty.com/bible/dos/fdos0138.lzh ), getting Illegal >> I

[Qemu-devel] Re: extended vga modes?

2010-03-08 Thread Avi Kivity
On 03/08/2010 01:07 PM, Michael Tokarev wrote: Avi Kivity wrote: [] In short, when vgabios were dropped from qemu-kvm (for whatever yet unknown reason), What do you mean? qemu-kvm still carries a local vgabios (see kvm/vgabios in qemu-kvm.git). Oh my. So we all overlooked i

[Qemu-devel] Re: request: please merge docs for -netdev in stable

2010-03-08 Thread Avi Kivity
Copying qemu-devel On 03/08/2010 01:11 PM, xming wrote: hi, with version 0.12.x there is a new -netdev option, but the docs cannot be found anywhere. It seems that this commit http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=96560cb34c3183a4fb1769e4eff4d860a24579a8 is only applied to t

Re: [Qemu-devel] Latest CVS build of qemu-system-ppc not boot debian_lenny_powerpc_small.qcow

2010-03-08 Thread Aurelien Jarno
On Sun, Mar 07, 2010 at 11:07:40AM +0800, tielian wrote: > qemu-system-ppc -hda debian_lenny_powerpc_small.qcow > qemu: fatal: Trying to execute code outside RAM or ROM at 0x > > NIP LR CTR XER > MSR HID0 0300 HF idx 0 > Segment

[Qemu-devel] [PATCH] sdl: improve error message on fatal error

2010-03-08 Thread Bjørn Mork
The SDL_SetVideoMode() error condition is easily triggered by a user by simply configure a guest with a host unsupported display resolution and attempting to enable fullscreen. Since the error is fatal, adding a bit of debugging help can't harm. Sample output with this change: (qemu) Could not

[Qemu-devel] Re: bs->enable_write_cache and the guest ABI

2010-03-08 Thread Juan Quintela
Avi Kivity wrote: > On 03/08/2010 12:29 PM, Juan Quintela wrote: >> Avi Kivity wrote: >> For RHEL I setted with adding enable_write_cache to the migration >> state. As you state, that value is guest visible. I can update that >> patches to qemu. When I migrated from an old version, I just set

[Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-08 Thread Paul Bolle
Signed-off-by: Paul Bolle --- usb-linux.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index a9c15c6..23155dd 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -846,9 +846,6 @@ static int usb_linux_update_endp_table(USBHostDevice *s)

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-08 Thread Paul Brook
> On 03/08/2010 12:53 AM, Paul Brook wrote: > >> Support an inter-vm shared memory device that maps a shared-memory > >> object as a PCI device in the guest. This patch also supports > >> interrupts between guest by communicating over a unix domain socket. > >> This patch applies to the qemu-kvm

[Qemu-devel] [PATCH] configure: fix --sysconfdir specification

2010-03-08 Thread Andre Przywara
--sysconfdir requires a parameter (the path), this should be reflected in the case pattern. Reported-by: Frank Arnold Signed-off-by: Andre Przywara --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index f55baf0..d3b4df9 100755 --- a/c

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-08 Thread Paul Brook
> However, coherence could be made host-type-independent by the host > mapping and unampping pages, so that each page is only mapped into one > guest (or guest CPU) at a time. Just like some clustering filesystems > do to maintain coherence. You're assuming that a TLB flush implies a write barrie

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-08 Thread Avi Kivity
On 03/08/2010 03:03 PM, Paul Brook wrote: On 03/08/2010 12:53 AM, Paul Brook wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This pa

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-08 Thread Paul Brook
> Signed-off-by: Paul Bolle > --- > usb-linux.c |3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/usb-linux.c b/usb-linux.c > index a9c15c6..23155dd 100644 > --- a/usb-linux.c > +++ b/usb-linux.c > @@ -846,9 +846,6 @@ static int usb_linux_update_endp_table(USBHostDe

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-08 Thread Luiz Capitulino
On Fri, 05 Mar 2010 17:43:40 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > > So, I won't nack it and the bigger mid-term discussion we should have > > is whether or not it's ok to mix qerror_report(), error_printf() & > > friends in handlers. > > I think mixing is both unavoid

Re: [Qemu-devel] Regression: more 0.12 regression (SeaBIOS related?)

2010-03-08 Thread Roy Tam
2010/3/8 Roy Tam : > the following hack reenables QEMU/Bochs BIOS booting with -vga std > (for both pc and isapc): a more complete hack, cirrus vga will work too: --- diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 9f61a01..3a12eaa 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -3131,6

[Qemu-devel] [PATCH] Fix SIGFPE for vnc display of width/height = 1

2010-03-08 Thread Chris Webb
During boot, the screen gets resized to height 1 and a mouse click at this point will cause a division by zero when calculating the absolute pointer position from the pixel (x, y). Return a click in the middle of the screen instead in this case. Signed-off-by: Chris Webb --- vnc.c |6 --

[Qemu-devel] [PATCH] install: honor DESTDIR on sysconfdir population

2010-03-08 Thread Andre Przywara
When creating and populating $sysconfdir, we should prepend $DESTDIR as we do with all other paths. Reported-by: Frank Arnold Signed-off-by: Andre Przywara --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index bf2cef2..2066c12 100644

[Qemu-devel] Re: [RESEND][PATCH][STABLE] Fix corner case in chardev udp: parameter

2010-03-08 Thread Anthony Liguori
On 03/07/2010 04:28 AM, Jan Kiszka wrote: The missing '@' broke 'udp::@:' parsing. Signed-off-by: Jan Kiszka Applied to stable, thanks. Regards, Anthony Liguori --- qemu-char.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] Re: [RESEND][PATCH][STABLE] Don't set default monitor when there is a mux'ed one

2010-03-08 Thread Anthony Liguori
On 03/07/2010 04:28 AM, Jan Kiszka wrote: This fixes eg. "-nographic -serial mon:stdio [-serial ...]". Signed-off-by: Jan Kiszka Applied to stable. Regards, Anthony Liguori --- vl.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 10

Re: [Qemu-devel] bs->enable_write_cache and the guest ABI

2010-03-08 Thread Christoph Hellwig
On Mon, Mar 08, 2010 at 09:47:32AM +, Jamie Lokier wrote: > Assuming the outcome is that it becomes a qdev property, and stays > preserved across migrations, even if the backing device access > changes, then I think the right thing is to dynamically decide to set > O_DSYNC and/or call fdatasync

Re: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command

2010-03-08 Thread Anthony Liguori
On 02/22/2010 10:51 AM, Adam Litke wrote: This patch application failed. My patch adds a cb() call in do_balloon(), but the change in git has added the cb() call to do_info_balloon(). That is causing qemu segfaults. Applying the following should correct the damage. Thanks. Fix for commit: 5c3

Re: [Qemu-devel] Re: QEMU license problem (was [PATCH v3] Drop --whole-archive and static libraries)

2010-03-08 Thread Anthony Liguori
On 03/07/2010 11:32 AM, Andreas Färber wrote: Am 07.03.2010 um 17:47 schrieb Juan Quintela: Stefan Weil wrote: Removing libqemu.a was technically ok, but throws a license problem: "In particular, the QEMU virtual CPU core library (libqemu.a) is released under the GNU Lesser General Public L

[Qemu-devel] Re: [PATCH] Inter-VM shared memory PCI device

2010-03-08 Thread Cam Macdonell
On Mon, Mar 8, 2010 at 2:56 AM, Avi Kivity wrote: > On 03/06/2010 01:52 AM, Cam Macdonell wrote: >> >> Support an inter-vm shared memory device that maps a shared-memory object >> as a PCI device in the guest.  This patch also supports interrupts between >> guest by communicating over a unix domai

Re: [Qemu-devel] [PATCH] Fix SIGFPE for vnc display of width/height = 1

2010-03-08 Thread Chris Webb
Chris Webb writes: > During boot, the screen gets resized to height 1 and a mouse click at this > point will cause a division by zero when calculating the absolute pointer > position from the pixel (x, y). Return a click in the middle of the screen > instead in this case. I think this probably o

[Qemu-devel] Re: [PATCHv4 05/12] virtio: add APIs for queue fields

2010-03-08 Thread Michael S. Tsirkin
On Mon, Mar 08, 2010 at 11:46:46AM +0530, Amit Shah wrote: > On (Sat) Mar 06 2010 [21:07:57], Michael S. Tsirkin wrote: > > On Fri, Mar 05, 2010 at 06:38:35PM +0530, Amit Shah wrote: > > > On (Wed) Mar 03 2010 [19:16:09], Michael S. Tsirkin wrote: > > > > + > > > > +EventNotifier *virtio_queue_gues

Re: [Qemu-devel] [PATCH] sdl: improve error message on fatal error

2010-03-08 Thread Stefan Weil
Bjørn Mork schrieb: > The SDL_SetVideoMode() error condition is easily triggered by a user by > simply configure a guest with a host unsupported display resolution > and attempting to enable fullscreen. Since the error is fatal, adding > a bit of debugging help can't harm. > > Sample output with th

[Qemu-devel] Summer of Code 2010

2010-03-08 Thread Luiz Capitulino
Hi there, Google has this wonderful program called Summer of Code, in which open source projects like ours, suggest possible projects and provide mentors to help selected students to do them. It's a great opportunity for students to get in touch with open source development, also good for us

Re: [Qemu-devel] [PATCH 0/2] Fix block_passwd monitor command error

2010-03-08 Thread Luiz Capitulino
On Sat, 6 Mar 2010 00:24:53 +0200 Shahar Havivi wrote: > The next two patches fix the wrong error message in block_passwd > monitor command: when trying to decrypt un-encrypted drive, user > get error wrong password. > > "1" add error message to qerror.h and qerror.c > "2" patch the monitor comm

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-08 Thread Marcelo Tosatti
On Fri, Mar 05, 2010 at 09:37:26PM -0500, Kevin O'Connor wrote: > On Thu, Mar 04, 2010 at 03:35:52PM -0300, Marcelo Tosatti wrote: > > On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote: > > > On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: > > > > The regression seems

Re: [Qemu-devel] Re: bs->enable_write_cache and the guest ABI

2010-03-08 Thread Jamie Lokier
Avi Kivity wrote: > I think we have to go with a qdev property as Christoph suggests. Then > it becomes the management's responsibility to set it right. How can the management be expected to know or follow dynamically changing guest state? There guests which disable a drive's write cache in som

Re: [Qemu-devel] Summer of Code 2010

2010-03-08 Thread Alexander Graf
On 08.03.2010, at 21:20, Luiz Capitulino wrote: > > Hi there, > > Google has this wonderful program called Summer of Code, in which open source > projects like ours, suggest possible projects and provide mentors to help > selected students to do them. > > It's a great opportunity for students

[Qemu-devel] Submitting a change...?

2010-03-08 Thread Rob Earhart
So, I have a patch I'd like to submit. It's pretty simple - when using a differencing disk and loading a snapshot, it includes the backing disks in the search. It seems to work fine on my machine. I'm not sure what the procedure for submitting changes is; it's been a long time since I've contrib

Re: [Qemu-devel] bs->enable_write_cache and the guest ABI

2010-03-08 Thread Jamie Lokier
Christoph Hellwig wrote: > On Mon, Mar 08, 2010 at 09:47:32AM +, Jamie Lokier wrote: > > Assuming the outcome is that it becomes a qdev property, and stays > > preserved across migrations, even if the backing device access > > changes, then I think the right thing is to dynamically decide to se

Re: [Qemu-devel] Submitting a change...?

2010-03-08 Thread Alexander Graf
On 08.03.2010, at 23:38, Rob Earhart wrote: > So, I have a patch I'd like to submit. It's pretty simple - when using a > differencing disk and loading a snapshot, it includes the backing disks in > the search. It seems to work fine on my machine. > > I'm not sure what the procedure for submi

[Qemu-devel] [PATCH] Use snapshots from backing disks

2010-03-08 Thread Rob Earhart
Modify the snapshot load path to find and load snapshots contained in backing disks, useful when the current disk is a differencing disk. Add the source of a snapshot when listing snapshots. This should only break backwards compatibility for scenarios depending on not being able to load snapshots

Re: [Qemu-devel] virtio block device and sysfs

2010-03-08 Thread jvrao
Marc Haber wrote: > Hi, > > I am looking to get in touch with somebody who knows more about the > connection between host configuration, qemu, kvm, and the virtio block > device driver guest side than I know. > Please check out this patch and follow the "mount_tag" ...it may be helpful in explain

[Qemu-devel] [patch 1/3] target-i386: print EFER in cpu_dump_state

2010-03-08 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti Index: qemu-kvm-uq/target-i386/helper.c === --- qemu-kvm-uq.orig/target-i386/helper.c +++ qemu-kvm-uq/target-i386/helper.c @@ -1176,6 +1176,7 @@ void cpu_dump_state(CPUState *env, FILE cpu_x86_dum

[Qemu-devel] [patch 2/3] kvm: handle internal error

2010-03-08 Thread Marcelo Tosatti
Port qemu-kvm's KVM_EXIT_INTERNAL_ERROR handling to upstream. Signed-off-by: Marcelo Tosatti Index: qemu-kvm/kvm-all.c === --- qemu-kvm.orig/kvm-all.c +++ qemu-kvm/kvm-all.c @@ -721,6 +721,28 @@ static int kvm_handle_io(uint16_t por

[Qemu-devel] [patch 0/3] misc uq/master updates

2010-03-08 Thread Marcelo Tosatti
See individual patches for details.

Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-08 Thread jvrao
Aneesh Kumar K. V wrote: > On Wed, 3 Mar 2010 23:35:36 +0300 (MSK), malc wrote: >> On Wed, 3 Mar 2010, Anthony Liguori wrote: >> >>> This get the mount to work on the guest >>> >>> [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] >>> >>> Signed-off-by: Anthony Liguori >>> Signed-off-b

[Qemu-devel] [patch 3/3] kvm: allow qemu to set EPT identity mapping address

2010-03-08 Thread Marcelo Tosatti
From: Sheng Yang If we use larger BIOS image than current 256KB, we would need move reserved TSS and EPT identity mapping pages. Currently TSS support this, but not EPT. Signed-off-by: Marcelo Tosatti Index: qemu-kvm/target-i386/kvm.c ===

Re: [Qemu-devel] Latest CVS build of qemu-system-ppc not boot debian_lenny_powerpc_small.qcow

2010-03-08 Thread Amit Shah
On (Mon) Mar 08 2010 [12:38:37], Aurelien Jarno wrote: > On Sun, Mar 07, 2010 at 11:07:40AM +0800, tielian wrote: > > qemu-system-ppc -hda debian_lenny_powerpc_small.qcow > > qemu: fatal: Trying to execute code outside RAM or ROM at 0x > > > > NIP LR CTR XER 0

[Qemu-devel] KVM call agenda for Mar 9

2010-03-08 Thread Chris Wright
- virtio-9p passthrough filesystem support - modular command line helpers Please send in any additional agenda items you are interested in covering. thanks, -chris