Gleb Natapov wrote:
> On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote:
>> Gleb Natapov wrote:
>>> On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote:
As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals
cpu_index, cpu_is_bsp can also be based on the latter d
On Thu, Mar 04, 2010 at 09:23:46AM +0100, Jan Kiszka wrote:
> Gleb Natapov wrote:
> > On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote:
> >> Gleb Natapov wrote:
> >>> On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote:
> As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_
On 03/03/10 19:53, Stefan Weil wrote:
This would indeed simplify the code.
Although I don't like tricky programming like DO_UPCAST
(because I saw too much code where tricky programming
was faulty programming),
Yea, when coding C++ in C you need little tricks now and then ;)
You need that in o
Hi
Series updated with yesterday comments
v2:
- drop un-needed slirp exit() patch (kevin)
- add qemu_write_full() documentation (danp)
- use strerror(-errno) (kevin, pbonzini)
Please review and apply.
Later, Juan.
v1:
This series make:
- all block *_create() functions return -errno i
Signed-off-by: Juan Quintela
---
block/qcow2.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index bf8170e..5b6dad9 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -851,7 +851,7 @@ static int qcow_create2(const char *file
we shouldn't call W*() macros until we check that fork worked.
Signed-off-by: Juan Quintela
---
net/slirp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/slirp.c b/net/slirp.c
index 317cca7..7f846ec 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -472,7 +472,7 @@ st
Remove not needed ret = 0 assignment.
Signed-off-by: Juan Quintela
---
block/cow.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/cow.c b/block/cow.c
index 3733385..97e9745 100644
--- a/block/cow.c
+++ b/block/cow.c
@@ -224,7 +224,7 @@ static int cow_create(co
Signed-off-by: Juan Quintela
---
block/qcow.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 003db1e..c619984 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -766,7 +766,7 @@ static int qcow_create(const char *filename,
QEMUOptio
Signed-off-by: Juan Quintela
---
block/vmdk.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 56c28a0..5b1d197 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -740,7 +740,7 @@ static int vmdk_create(const char *filename,
QEM
Signed-off-by: Juan Quintela
---
block/vmdk.c | 79 ++---
1 files changed, 58 insertions(+), 21 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 5b1d197..67a690e 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -187,6 +187,7 @@ stat
fail_gd error case would also free rgd_buf that was already freed
Signed-off-by: Juan Quintela
---
block/vmdk.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 67a690e..819c1c9 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -315,7 +315
cleanup code is identical for error/success cases. Only difference
are goto labels.
Signed-off-by: Juan Quintela
---
block/vmdk.c | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 819c1c9..007fca4 100644
--- a/block/vmdk.c
+++
Now that we changed all create calls to return errno, just print it.
Signed-off-by: Juan Quintela
---
qemu-img.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 0c9f2d4..e51b40c 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -374,7 +374,7 @@
Signed-off-by: Juan Quintela
---
osdep.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/osdep.c b/osdep.c
index 5bf3c00..abbc8a2 100644
--- a/osdep.c
+++ b/osdep.c
@@ -261,6 +261,11 @@ int qemu_open(const char *name, int flags, ...)
*
* Return the number of bytes
On Thu, Mar 04, 2010 at 10:00:31AM +0100, Juan Quintela wrote:
> we shouldn't call W*() macros until we check that fork worked.
>
> Signed-off-by: Juan Quintela
Acked-by: Michael S. Tsirkin
> ---
> net/slirp.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net
From c5dca54f67ec6aac16c6c5e09958417b2b3ee5a1 Mon Sep 17 00:00:00 2001
From: M. Mohan Kumar
Date: Thu, 4 Mar 2010 14:23:07 +0530
Subject: [PATCH] Check for invalid initrd file
When qemu is invoked with an invalid initrd file, it crashes. Following
patch prints a error message and exits if an inva
On Wed, Mar 03, 2010 at 01:00:59PM -0600, Anthony Liguori wrote:
> [ki...@linux.vnet.ibm.com: malloc to qemu_malloc coversion]
>
> Signed-off-by: Anthony Liguori
> Signed-off-by: Aneesh Kumar K.V
> ---
> hw/virtio-9p.c | 263
> +++-
> 1 file
Gleb Natapov wrote:
> On Thu, Mar 04, 2010 at 09:23:46AM +0100, Jan Kiszka wrote:
>> Gleb Natapov wrote:
>>> On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote:
Gleb Natapov wrote:
> On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote:
>> As we hard-wire the BSP to CPU 0
On Thu, Mar 04, 2010 at 12:35:45PM +0100, Jan Kiszka wrote:
> Gleb Natapov wrote:
> > On Thu, Mar 04, 2010 at 09:23:46AM +0100, Jan Kiszka wrote:
> >> Gleb Natapov wrote:
> >>> On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote:
> Gleb Natapov wrote:
> > On Mon, Mar 01, 2010 at 06:
Signed-off-by: malc
---
target-i386/translate.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index a597e80..68e6df9 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -4589,9 +4589,7 @@ static tar
On (Wed) Mar 03 2010 [19:16:13], Michael S. Tsirkin wrote:
> vhost net backend needs to be notified when
> frontend status changes. Add a callback,
> similar to set_features.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/s390-virtio-bus.c |2 +-
> hw/syborg_virtio.c |2 +-
> hw/virt
On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote:
> make it possible to use type without header include
Why?
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/virtio.h |1 -
> qemu-common.h |1 +
> 2 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virtio.h b/
On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote:
> On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote:
> > make it possible to use type without header include
>
> Why?
So that vhost.h does not need to include virtio.h
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > hw/virtio
On Thu, Mar 04, 2010 at 05:49:37PM +0530, Amit Shah wrote:
> On (Wed) Mar 03 2010 [19:16:13], Michael S. Tsirkin wrote:
> > vhost net backend needs to be notified when
> > frontend status changes. Add a callback,
> > similar to set_features.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> >
On (Thu) Mar 04 2010 [14:19:58], Michael S. Tsirkin wrote:
> On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote:
> > On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote:
> > > make it possible to use type without header include
> >
> > Why?
>
> So that vhost.h does not need to includ
On Thu, Mar 04, 2010 at 05:59:11PM +0530, Amit Shah wrote:
> On (Thu) Mar 04 2010 [14:19:58], Michael S. Tsirkin wrote:
> > On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote:
> > > On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote:
> > > > make it possible to use type without header
On Thu, 4 Mar 2010, malc wrote:
That's not enough, later on there's a bunch of operations assuming
32bit width...
--
mailto:av1...@comtv.ru
Add a logical block size attribute as various guest side tools only
increase the filesystem sector size based on it, not the advisory
physical block size.
For scsi we already have support for a different logical block size
in place for CDROMs that we can built upon. Only my recent block
device c
Signed-off-by: Christoph Hellwig
Index: qemu/hw/scsi-disk.c
===
--- qemu.orig/hw/scsi-disk.c2010-03-04 14:39:43.699022260 +0100
+++ qemu/hw/scsi-disk.c 2010-03-04 14:41:26.768255602 +0100
@@ -462,8 +462,12 @@ static int scsi_disk
From: Avi Kivity
Instead of allocating a separate chunk for the first 640KB and another
for 1MB+, allocate one large chunk. This plays well in terms of alignment
and size with large pages.
Signed-off-by: Avi Kivity
Signed-off-by: Marcelo Tosatti
---
hw/pc.c | 11 ++-
1 files change
The following changes since commit 55b1e61f640bb2cf3bed0b4cc6d4ba1326c625d9:
Samuel Thibault (1):
(curses) Use more descriptive values
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
Avi Kivity (1):
Allocate memory below 4GB
Port qemu-kvm's -mem-path and -mem-prealloc options. These are useful
for backing guest memory with huge pages via hugetlbfs.
Signed-off-by: Marcelo Tosatti
CC: john cooper
---
cpu-all.h |3 +
exec.c | 115 --
qemu-options.
From: Jan Kiszka
This grand cleanup drops all reset and vmsave/load related
synchronization points in favor of four(!) generic hooks:
- cpu_synchronize_all_states in qemu_savevm_state_complete
(initial sync from kernel before vmsave)
- cpu_synchronize_all_post_init in qemu_loadvm_state
(writ
From: Jan Kiszka
As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals
cpu_index, bsp_to_cpu can also be based on the latter directly. This
will help an early user of it: KVM while initializing mp_state.
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo Tosatti
---
hw/pc.c |3 ++
From: Jan Kiszka
Do not write nmi_pending, sipi_vector, and mpstate unless we at least go
through a reset. And TSC as well as KVM wallclocks should only be
written on full sync, otherwise we risk to drop some time on state
read-modify-write.
Signed-off-by: Jan Kiszka
Signed-off-by: Marcelo Tosa
From: Jan Kiszka
So far we synchronized any dirty VCPU state back into the kernel before
updating the guest debug state. This was a tribute to a deficite in x86
kernels before 2.6.33. But as this is an arch-dependent issue, it is
better handle in the x86 part of KVM and remove the writeback point
On 03/03/2010 06:08 AM, Michael S. Tsirkin wrote:
The following changes since commit 55b1e61f640bb2cf3bed0b4cc6d4ba1326c625d9:
Samuel Thibault (1):
(curses) Use more descriptive values
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.
On 03/04/2010 09:05 AM, Marcelo Tosatti wrote:
The following changes since commit 55b1e61f640bb2cf3bed0b4cc6d4ba1326c625d9:
Samuel Thibault (1):
(curses) Use more descriptive values
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/mast
On Wed, Mar 3, 2010 at 11:58 PM, David S. Ahern wrote:
> On 03/03/2010 04:47 PM, Jan Kiszka wrote:
>>
>> Thanks for your work, David and Niels! I assume that David based this on
>> Niels' patch, so there is nothing to be merged? David's version built
>> for me, so I pushed
>>
>> git://git.ki
The monitor_printf() reports failure. Printing is wrong, because the
caller tries various arguments, and expects the function to fail for
some or all.
Disabled since commit 26a9e82a. Remove it.
Signed-off-by: Markus Armbruster
---
usb-linux.c |8
1 files changed, 0 insertions(+),
Signed-off-by: Markus Armbruster
---
qemu-tool.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/qemu-tool.c b/qemu-tool.c
index 18b48af..bbce99f 100644
--- a/qemu-tool.c
+++ b/qemu-tool.c
@@ -33,8 +33,6 @@ void qemu_service_io(void)
{
}
-Monitor *cur_mon;
-
void m
A monitor may not even exist.
Change load_vmstate() to use qemu_error() instead of monitor_printf().
Parameter mon is now unused, remove it.
Signed-off-by: Markus Armbruster
---
monitor.c |2 +-
savevm.c | 24 +++-
sysemu.h |2 +-
vl.c |2 +-
4 files cha
Why this is such a big job? There are two issues with a naive
conversion:
* Error message degradation
The error messages are worded for -device. They aren't so hot to
begin with, because we typically have many -device, and to which one
a message applies is often not obvious.
Now, QMP w
Commit 0ecdffbb created pc_boot_set() for use from monitor command
"boot_set", via qemu_boot_set(). pc_boot_set() reports errors to
cur_mon, which works fine for monitor code.
Commit e0f084bf reused the function int reset handler
restore_boot_devices(). Use of cur_mon is problematic in that
cont
qemu_error_sink can either point to a monitor or a file. In practice,
it always points to the current monitor if we have one, else to
stderr. Simply route errors to the current monitor or else to stderr,
and remove qemu_error_sink along with the functions to control it.
Actually, the old code sw
Code duplicated in commit 0ecdffbb. The two versions are similar, but
not identical:
* cmos_init() reports errors to stderr, pc_boot_set() via
qemu_error(). The latter is fine for both, so pick that for the
common code.
* cmos_init() obeys fd_bootchk, pc_boot_set() ignores it. Make it a
They're about reporting errors, not about the monitor.
Signed-off-by: Markus Armbruster
---
Makefile.target |1 +
monitor.c | 89 -
qemu-error.c| 92 +++
3 files changed, 93
Signed-off-by: Markus Armbruster
---
qemu-error.c | 49 ++---
qemu-error.h | 14 ++
2 files changed, 56 insertions(+), 7 deletions(-)
diff --git a/qemu-error.c b/qemu-error.c
index 63bcdcf..d20fd0f 100644
--- a/qemu-error.c
+++ b/qemu-
Signed-off-by: Markus Armbruster
---
hw/scsi-bus.c |2 +-
hw/scsi-disk.c|3 +--
hw/scsi-generic.c |1 +
hw/usb-serial.c |1 +
hw/virtio-net.c |1 +
hw/virtio-pci.c |2 +-
monitor.h |1 +
net/dump.c|1 +
net/socket.c |2 +-
ne
Signed-off-by: Markus Armbruster
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index e7a485e..b79b4fa 100644
--- a/qerror.c
+++ b/qerror.c
@@ -57,6 +57,10 @@ static const QErrorStringTable qerror_table[] = {
"device_add isa-serial,bus=pci.0" kills QEMU. Not good.
Signed-off-by: Markus Armbruster
---
hw/qdev.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 25e1703..80e5c36 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -204,6 +204,11 @@ DeviceStat
qbus_find() adds an informational line to error messages, and prints
both lines with one qemu_error(). Use error_printf() for the
informational line instead.
While there, simplify: instead of printing buffers filled by
qbus_list_bus() and qbus_list_dev() in one go, make them print it.
Signed-off
Users can't set them, so qdev_device_help() shouldn't list them. Fix
that. Also make qdev_prop_parse() hide them instead of printing a
meaningless "has no parser" error message.
Their value means nothing to users, so qdev_print_props() shouldn't
print it. Fix by removing their print method.
Th
This separates the monitor part from the QError part.
Signed-off-by: Markus Armbruster
---
monitor.c | 21 +
monitor.h |3 +++
2 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/monitor.c b/monitor.c
index 8e2e5c3..da52cb4 100644
--- a/monitor.c
+++ b/monit
Signed-off-by: Markus Armbruster
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index b61cc33..107161c 100644
--- a/qerror.c
+++ b/qerror.c
@@ -61,6 +61,10 @@ static const QErrorStringTable qerror_table[] = {
Signed-off-by: Markus Armbruster
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index 4de1039..62bb00f 100644
--- a/qerror.c
+++ b/qerror.c
@@ -109,6 +109,10 @@ static const QErrorStringTable qerror_table[] = {
qdev_device_help() prints device information with qemu_error(). A
later commit will make qemu_error() print additional stuff that is
only appropriate for proper errors, and then this will break. Use
error_printf() instead.
While there, simplify: instead of printing a buffer filled by
qdev_print_
The old test assumes that "hotplugged" implies "we have a current
monitor for reading the key". This is in fact true, but it's not
obviously true.
Aside: if it were false, we could pass a null pointer to
monitor_read_bdrv_key_start(), which would then crash.
The previous commit permits us to che
Commits 376253ec..731b0364 introduced global variable cur_mon, which
points to the "default monitor" (if any), except during execution of
monitor_read() or monitor_control_read() it points to the monitor from
which we're reading instead (the "current monitor"). Monitor command
handlers run within
Signed-off-by: Markus Armbruster
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index 68ef78c..b61cc33 100644
--- a/qerror.c
+++ b/qerror.c
@@ -49,6 +49,10 @@ static const QErrorStringTable qerror_table[] = {
New struct Location holds a location. So far, the only location is
LOC_NONE, so this doesn't do anything useful yet.
Passing the current location all over the place would be too
cumbersome. Hide it away in static cur_loc instead, and provide
accessors. Print it in error_report().
Store it in Q
Commit 30d335d6 converted an informational message from
monitor_printf() to qemu_error(), probably because the latter doesn't
need a mon argument. A later commit will make qemu_error() print
additional stuff that is only appropriate for proper errors, and then
this will break. Clean it up.
Signe
Signed-off-by: Markus Armbruster
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index 733723e..68ef78c 100644
--- a/qerror.c
+++ b/qerror.c
@@ -41,6 +41,10 @@ static const QType qerror_type = {
*/
static const
Signed-off-by: Markus Armbruster
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index 62bb00f..e7a485e 100644
--- a/qerror.c
+++ b/qerror.c
@@ -41,6 +41,10 @@ static const QType qerror_type = {
*/
static const
Signed-off-by: Markus Armbruster
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index 107161c..ece51f8 100644
--- a/qerror.c
+++ b/qerror.c
@@ -125,6 +125,10 @@ static const QErrorStringTable qerror_table[] = {
The functions are somewhat restricted. Good enough for the job at
hand. We'll extend them when we need more.
Signed-off-by: Markus Armbruster
---
qemu-option.c | 79 +
qemu-option.h |3 ++
2 files changed, 82 insertions(+), 0 deleti
While there, improve the params help text.
Signed-off-by: Markus Armbruster
---
hw/qdev.c |3 +--
qemu-monitor.hx |4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 1edfce8..241f204 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -766,8 +7
Next commit wants to use it.
Signed-off-by: Markus Armbruster
---
qemu-config.c |8
qemu-config.h |1 +
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/qemu-config.c b/qemu-config.c
index a2e0193..150157c 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -309,7 +3
To make it obvious that -device and device_add can't die in
hw_error().
Signed-off-by: Markus Armbruster
---
hw/qdev.c | 37 ++---
1 files changed, 22 insertions(+), 15 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 80e5c36..7bc711b 100644
--- a/hw/qdev.
error_report() terminates the message with a newline. Strip it it
from its arguments.
This fixes a few error messages lacking a newline:
net_handle_fd_param()'s "No file descriptor named %s found", and
tap_open()'s "vnet_hdr=1 requested, but no kernel support for
IFF_VNET_HDR available" (all thre
Signed-off-by: Markus Armbruster
---
qemu-error.c | 20 +++-
qemu-error.h |1 +
vl.c |2 ++
3 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/qemu-error.c b/qemu-error.c
index 0d673c5..214e448 100644
--- a/qemu-error.c
+++ b/qemu-error.c
@@ -113,13
Signed-off-by: Markus Armbruster
---
qemu-error.c | 11 +++
qemu-error.h |2 ++
2 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/qemu-error.c b/qemu-error.c
index a8c178b..5d5fe37 100644
--- a/qemu-error.c
+++ b/qemu-error.c
@@ -41,6 +41,17 @@ void error_printf(const
New LOC_FILE. Use it for tracking file name and line number in
qemu_config_parse(). We now report errors like
qemu:foo.conf:42: Did not find I2C bus for smbus-eeprom
In particular, gems like this message:
-device: no driver specified
become almost nice now:
qemu:foo.conf:44: -dev
We sometimes permit omitting the first option name, for example
-device foo is short for -device driver=foo. The name to use
("driver" in the example) is passed as argument to qemu_opts_parse().
For each QemuOptsList, we use at most one such name.
Move the name into QemuOptsList, and pass whether
New LOC_CMDLINE. Use it for tracking option with argument in
lookup_opt(). We now report errors like this
qemu: -device smbus-eeprom: Did not find I2C bus for smbus-eeprom
Signed-off-by: Markus Armbruster
---
qemu-error.c | 20
qemu-error.h |3 ++-
vl.c
In the human monitor, it declares a single optional argument to be
parsed according to the QemuOptsList given by its name.
In QMP, it declares an optional argument for each member of the
QemuOptsList.
Restriction: only lists with empty desc are supported for now. Good
enough for the job at hand.
Also put error definitions in alphabetical order
Signed-off-by: Markus Armbruster
---
qerror.c | 28 ++--
qerror.h | 14 +++---
2 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/qerror.c b/qerror.c
index b400480..41ff946 100644
--- a/qerror.c
++
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c |6 ++
hw/qdev.c|2 --
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 11f7b76..780a9d8 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
Signed-off-by: Markus Armbruster
---
qemu-config.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/qemu-config.c b/qemu-config.c
index 2de97cd..ad130fb 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -475,6 +475,10 @@ int qemu_config_parse(FILE *fp, const char *fnam
While fully converted handlers are not supposed to print anything when
running in a QMP monitor, they are free to print in a human monitor.
For instance, device_add (not yet converted) prints help, and will
continue to do so after conversion.
Moreover, utility functions converted to QError should
Conversion to QObject is still missing.
Signed-off-by: Markus Armbruster
---
hw/qdev.c | 19 +--
1 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index d3204d4..e3fcc75 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -200,15 +200,15 @@ DeviceState
Signed-off-by: Markus Armbruster
---
hw/qdev.c | 25 ++---
1 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 40b07fb..bbb1e44 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -216,18 +216,21 @@ DeviceState *qdev_device_add(QemuOpts *opts)
Treat multiple successive slashes as a one slash. Ignore trailing
slashes. This is how POSIX pathnames work.
Signed-off-by: Markus Armbruster
---
hw/qdev.c | 26 +-
1 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 1de4ff6..40
This reverts commit 3ced9f7a36189aed94d8bf86f3f5087a53012455.
The next commit will convert all of qdev_device_add() to QError, and
it'll be clearer with this partial conversion reverted.
Signed-off-by: Markus Armbruster
---
hw/qdev.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Signed-off-by: Markus Armbruster
---
hw/qdev.c | 42 ++
hw/qdev.h |2 +-
qemu-monitor.hx |3 ++-
3 files changed, 37 insertions(+), 10 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 241f204..35e7a88 100644
--- a/hw/qdev.c
+++
Signed-off-by: Markus Armbruster
---
monitor.c |6 ++
monitor.h |2 ++
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/monitor.c b/monitor.c
index 55d78d5..3580d37 100644
--- a/monitor.c
+++ b/monitor.c
@@ -194,6 +194,12 @@ static inline int monitor_ctrl_mode(const Mon
Signed-off-by: Markus Armbruster
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index 41ff946..4de1039 100644
--- a/qerror.c
+++ b/qerror.c
@@ -105,6 +105,10 @@ static const QErrorStringTable qerror_table[] = {
Users can't create them, so qdev_device_help() shouldn't list them.
Fix that.
Also make qdev_device_add() pretend they don't exist. Before, it
rejected them with a "can't be added via command line" message, which
wasn't quite right for monitor command device_add.
Signed-off-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index b79b4fa..733723e 100644
--- a/qerror.c
+++ b/qerror.c
@@ -73,6 +73,10 @@ static const QErrorStringTable qerror_table[] = {
Signed-off-by: Markus Armbruster
---
hw/qdev.c|2 +-
monitor.c| 80 +-
qemu-error.c |6 ++--
qemu-error.h | 10 +++---
4 files changed, 49 insertions(+), 49 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index f170ea0.
M. Mohan Kumar wrote:
> From c5dca54f67ec6aac16c6c5e09958417b2b3ee5a1 Mon Sep 17 00:00:00 2001
> From: M. Mohan Kumar
> Date: Thu, 4 Mar 2010 14:23:07 +0530
> Subject: [PATCH] Check for invalid initrd file
>
> When qemu is invoked with an invalid initrd file, it crashes. Following
> patch prints
Hi folks, I found this problem trying to build qemu from the qemu.git
repo:
03/04 13:07:34 ERROR| kvm:0061| Test failed: Command
failed, rc=2, Command returned non-zero exit status
* Command:
make install
Exit status: 2
Duration: 0
stdout:
install -d -m0755 -p "/usr/local/autotest/te
On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote:
> On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote:
> > The regression seems to be caused by seabios commit d7e998f. Kevin, the
> > failure can be seen on the attached screenshot, which happens on the
> > first reboot of
It was broken by:
commit da51e79b7ff2126cc2448749d657a4f6e3b1270f
Author: Stefan Weil
Date: Tue Mar 2 22:37:44 2010 +0100
eepro100: Support gpxe boot for all eepro100 devices
Only two boot ROM files are needed for all devices.
* Add these GPXE ROM files using new naming conventi
Anthony Liguori schrieb:
> It was broken by:
>
> commit da51e79b7ff2126cc2448749d657a4f6e3b1270f
> Author: Stefan Weil
> Date: Tue Mar 2 22:37:44 2010 +0100
>
> eepro100: Support gpxe boot for all eepro100 devices
>
> Only two boot ROM files are needed for all devices.
>
> * Add thes
da51e79b7ff2126cc2448749d657a4f6e3b1270f added two new ROM files
and removed an old one for eepro100.c.
These changes were missing in Makefile (which resulted
in a broken "make install").
Reported by Lucas Meneghel Rodrigues, thanks.
Signed-off-by: Stefan Weil
---
Makefile |4 +++-
1 files
On Thu, 4 Mar 2010 16:56:49 +0100
Markus Armbruster wrote:
> While fully converted handlers are not supposed to print anything when
> running in a QMP monitor, they are free to print in a human monitor.
I disagree.
One of the key decisions behind the new Monitor design is that handlers
are p
On Thu, 4 Mar 2010 16:57:06 +0100
Markus Armbruster wrote:
> The functions are somewhat restricted. Good enough for the job at
> hand. We'll extend them when we need more.
>
> Signed-off-by: Markus Armbruster
> ---
> qemu-option.c | 79
> ++
Luiz Capitulino writes:
> On Thu, 4 Mar 2010 16:56:49 +0100
> Markus Armbruster wrote:
>
>> While fully converted handlers are not supposed to print anything when
>> running in a QMP monitor, they are free to print in a human monitor.
>
> I disagree.
>
> One of the key decisions behind the ne
Luiz Capitulino writes:
> On Thu, 4 Mar 2010 16:57:06 +0100
> Markus Armbruster wrote:
>
>> The functions are somewhat restricted. Good enough for the job at
>> hand. We'll extend them when we need more.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> qemu-option.c | 79
>>
1 - 100 of 118 matches
Mail list logo
