[Qemu-devel] [PATCH 04/21] Monitor: Convert do_eject() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c |6 +++--- qemu-monitor.hx |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index cede368..e960c38 100644 --- a/monitor.c +++ b/monitor.c @@ -989,7 +989,7 @@ static int eject_device(Monitor *mon,

[Qemu-devel] [PATCH 05/21] Monitor: Convert do_cpu_set() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c |7 +-- qemu-monitor.hx |2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index e960c38..598dbfe 100644 --- a/monitor.c +++ b/monitor.c @@ -921,11 +921,14 @@ static void do_info_cpus(Monitor *

[Qemu-devel] [PATCH 06/21] Monitor: Convert do_block_set_passwd() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c |7 +-- qemu-monitor.hx |2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 598dbfe..0ae408a 100644 --- a/monitor.c +++ b/monitor.c @@ -1006,7 +1006,7 @@ static int do_eject(Monitor *mon,

[Qemu-devel] [PATCH 07/21] Monitor: Convert do_getfd() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c | 11 ++- qemu-monitor.hx |2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 0ae408a..9466c63 100644 --- a/monitor.c +++ b/monitor.c @@ -2403,7 +2403,7 @@ static void do_inject_mce(Moni

[Qemu-devel] [PATCH 08/21] Monitor: Convert do_closefd() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c |5 +++-- qemu-monitor.hx |2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 9466c63..9338d13 100644 --- a/monitor.c +++ b/monitor.c @@ -2447,7 +2447,7 @@ static int do_getfd(Monitor *mon, co

[Qemu-devel] [PATCH 09/21] Monitor: Convert pci_device_hot_add() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- hw/pci-hotplug.c | 16 +++- qemu-monitor.hx |2 +- sysemu.h |2 +- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c index 0fb96f0..6cc70d5 100644 --- a/hw/pci-hotplug.c +++ b/hw/pc

[Qemu-devel] [PATCH 10/21] Monitor: Convert pci_device_hot_remove() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- hw/pci-hotplug.c | 14 +++--- qemu-monitor.hx |2 +- sysemu.h |6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c index 6cc70d5..bd82c6a 100644 --- a/hw/pci-hotplug.c +++ b/hw

[Qemu-devel] [PATCH 11/21] Monitor: Convert do_migrate() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
While there I'm also dropping a unneeded else clause (the last one in the function). Signed-off-by: Luiz Capitulino --- migration.c | 29 + migration.h |2 +- qemu-monitor.hx |2 +- 3 files changed, 19 insertions(+), 14 deletions(-) diff --git a/mig

[Qemu-devel] [PATCH 12/21] Monitor: Convert do_memory_save() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c |9 +++-- qemu-monitor.hx |2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 9338d13..7747449 100644 --- a/monitor.c +++ b/monitor.c @@ -1428,7 +1428,7 @@ static void do_print(Monitor *mo

[Qemu-devel] [PATCH 13/21] Monitor: Convert do_physical_memory_save() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c |9 +++-- qemu-monitor.hx |2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 7747449..3470b0b 100644 --- a/monitor.c +++ b/monitor.c @@ -1466,7 +1466,7 @@ exit: return ret; } -sta

[Qemu-devel] [PATCH 14/21] Monitor: Convert do_info() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Note that this function only fails in QMP, in the user Monitor it prints the help text instead. Signed-off-by: Luiz Capitulino --- monitor.c |8 +--- qemu-monitor.hx |2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 3470b0b..baedc

[Qemu-devel] [PATCH 15/21] Monitor: Convert do_change() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Not that trivial as the call chain also has to be modified. Signed-off-by: Luiz Capitulino --- monitor.c | 60 ++ monitor.h |6 ++-- qemu-monitor.hx |2 +- 3 files changed, 42 insertions(+), 26 deletions(-) diff --git a/m

[Qemu-devel] [PATCH 16/21] Monitor: Rename cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Now that all handlers are converted to cmd_new_ret(), we can rename it back to cmd_new(). But now it returns a value. Signed-off-by: Luiz Capitulino --- monitor.c |9 ++--- qemu-monitor.hx | 42 +- 2 files changed, 23 insertions(+), 28 dele

[Qemu-devel] [PATCH 17/21] Monitor: Debugging support

2010-02-10 Thread Luiz Capitulino
Add configure options (--enable-debug-mon and --disable-debug-mon) plus the MON_DEBUG() macro. Signed-off-by: Luiz Capitulino --- configure | 10 ++ monitor.c |8 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 0a84b0e..2c2e7ae 1

[Qemu-devel] [PATCH 18/21] Monitor: Drop the print disabling mechanism

2010-02-10 Thread Luiz Capitulino
We can ignore calls to monitor_vprintf() in QMP mode and use monitor_puts() directly in monitor_json_emitter(). This allows us to drop this ugly hack. Signed-off-by: Luiz Capitulino --- monitor.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/monitor.c

[Qemu-devel] [PATCH 19/21] Monitor: Audit handler return

2010-02-10 Thread Luiz Capitulino
This commit verifies the following two rules specified by Markus Armbruster: 1. If the handler returns failure, it must have passed an error. If it didn't, it's broken. Report an internal error to the client, and report the bug to the programmer. 2. If the handler returns success, it must

[Qemu-devel] [PATCH 20/21] Monitor: Debug stray prints the right way

2010-02-10 Thread Luiz Capitulino
QObject Monitor handlers should not call any Monitor print function: they should only build objects, printing is done by common code. Current QMP code will ignore such calls, as we can't send garbage to clients, additionally it will also emit an undefined error on the assumption that print calls u

[Qemu-devel] [PATCH 21/21] Monitor: Report more than one error in handlers

2010-02-10 Thread Luiz Capitulino
Handlers can generate only one error in a call, we let the programmer know if they brake this rule and clients will only get the first generated error. Signed-off-by: Luiz Capitulino --- monitor.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c in

Re: [Qemu-devel] [PATCH 0/3] move stuff out from vl.c to console.c

2010-02-10 Thread Anthony Liguori
On 02/10/2010 05:29 PM, Paolo Bonzini wrote: Moving stuff around to console.c; video does not belong in a target-dependent file. Excellent. I love series that move stuff out of vl.c :-) Regards, Anthony Liguori Paolo Bonzini (3): use lazy initialization for display_state remove k

[Qemu-devel] Re: [PATCH] Fix lost serial TX interrupts. Report receive overruns.

2010-02-10 Thread Justin T. Gibbs
Properly formatted patch now attached. -- Justin >From 7a941b3fcd298b60bb14744b8fae422d86298197 Mon Sep 17 00:00:00 2001 From: Justin T. Gibbs Date: Wed, 10 Feb 2010 14:35:54 -0700 Subject: [PATCH] Fix lost serial TX interrupts. Report receive overruns. o Implement receive overrun status. The

Re: [Qemu-devel] running qemu-system-mipsel with VGA graphic mode based malta board kernel

2010-02-10 Thread daniel tian
2010/2/7 Stefan Weil : > Aurelien Jarno schrieb: >> On Wed, Feb 03, 2010 at 04:23:01PM +0800, daniel tian wrote: >> >>> Hi, Aurelien Jarno: >>> >>> I just encounter a problem in running kernel on qemu mips malta board, >>> I don't know how to bring up the graphic mode. >>> with the option --nograph

Re: [Qemu-devel] Audio latency

2010-02-10 Thread Alberich de megres
I'm using the alsa driver. Even I tried to change some values using the export and some flags that -audio-help shows, but nothing significant. On Thu, Feb 11, 2010 at 1:03 AM, malc wrote: > On Thu, 11 Feb 2010, Alberich de megres wrote: > >> Hi! >> >> I'm running qemu on suse, and i got a very

Re: [Qemu-devel] Audio latency

2010-02-10 Thread malc
On Thu, 11 Feb 2010, Alberich de megres wrote: > I'm using the alsa driver. > Even I tried to change some values using the export and some flags > that -audio-help shows, but nothing significant. Please do not top post. > > > On Thu, Feb 11, 2010 at 1:03 AM, malc wrote: > > On Thu, 11 Feb 20

Re: [Qemu-devel] Audio latency

2010-02-10 Thread Alberich de megres
On Thu, Feb 11, 2010 at 7:53 AM, malc wrote: > On Thu, 11 Feb 2010, Alberich de megres wrote: > >> I'm using the alsa driver. >> Even I tried to change some values using the export and some flags >> that -audio-help shows, but nothing significant. > > Please do not top post. Sorrry!! > >> >> >>

<    1   2