Gerd Hoffmann writes:
>> diff --git a/hw/usb-msd.c b/hw/usb-msd.c
>> index bb39b62..dec35bc 100644
>> --- a/hw/usb-msd.c
>> +++ b/hw/usb-msd.c
>> @@ -591,7 +591,7 @@ static USBDevice *usb_msd_init(const char *filename)
>> }
>>
>> /* create guest device */
>> -dev = usb_create(NULL
Markus Armbruster wrote:
> The place for verbose device names is DeviceInfo member desc. The
> name should be short & sweet.
Agreed, however...
Why do these (maybe others) get caps in their names? they dont look
right to me, compared to the others with nice names like usb-serial,
piix-ide, or c
Ian Molton writes:
> Markus Armbruster wrote:
>
>> The place for verbose device names is DeviceInfo member desc. The
>> name should be short & sweet.
>
> Agreed, however...
>
> Why do these (maybe others) get caps in their names? they dont look
> right to me, compared to the others with nice nam
On Tue, Dec 08, 2009 at 02:07:29PM +0100, Gerd Hoffmann wrote:
> On 12/08/09 13:52, Gerd Hoffmann wrote:
> >>The latter. The guest does not see it, but it at least does not abort.
> >>It is the 'does not abort' behaviour I'm interested in - quite OK with
> >>this returning an error to the monitor c
Anthony Liguori wrote:
> The QEMU team is pleased to announce the availability of the 0.12.0-rc1
> release. This is the first release candidate for the 0.12.0 release.
> This release is not intended for production use.
What git tree should I rebase my patches onto (for the next release) ?
Thanks
On Tue, 2009-12-08 at 18:41 +0100, Arnd Bergmann wrote:
> In order to support macvtap, we need a way to select the actual
> tap endpoint. While it would be nice to pass it by network interface
> name, passing the character device is more flexible, and we can
> easily do both in the long run.
>
> S
The mouse_button monitor command currently results in a call like this:
kbd_mouse_event(0, 0, 0, mouse_button_status);
For a pointer in relative mode, this means a button gets pressed (or
or released) and nothing else. However, if the pointer currently being
controlled is in absolute mode (s
On Tue, Dec 08, 2009 at 06:41:44PM +0100, Arnd Bergmann wrote:
> In order to support macvtap, we need a way to select the actual
> tap endpoint. While it would be nice to pass it by network interface
> name, passing the character device is more flexible, and we can
> easily do both in the long run.
2009/12/7 Blue Swirl :
> On Mon, Dec 7, 2009 at 3:30 PM, Artyom Tarasenko
> wrote:
>> Can it be that qemu (-system-sparc in my case, but I guess it's more
>> or less similar on all platforms) reacts to irqs slower than a real
>> hardware due to tcg optimizations?
>>
>> I see one test pattern which
On Wednesday 09 December 2009, Michael S. Tsirkin wrote:
> On Tue, Dec 08, 2009 at 06:41:44PM +0100, Arnd Bergmann wrote:
> > --- a/net/tap-bsd.c
> > +++ b/net/tap-bsd.c
> > @@ -40,7 +40,8 @@
> > #include
> > #endif
> >
> > -int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int
> > v
On Wednesday 09 December 2009 13:33:36 Arnd Bergmann wrote:
> On Wednesday 09 December 2009, Michael S. Tsirkin wrote:
> > On Tue, Dec 08, 2009 at 06:41:44PM +0100, Arnd Bergmann wrote:
> > > --- a/net/tap-bsd.c
> > > +++ b/net/tap-bsd.c
> > > @@ -40,7 +40,8 @@
> > > #include
> > > #endif
> > >
On Wed, Dec 09, 2009 at 01:33:36PM +0100, Arnd Bergmann wrote:
> On Wednesday 09 December 2009, Michael S. Tsirkin wrote:
> > On Tue, Dec 08, 2009 at 06:41:44PM +0100, Arnd Bergmann wrote:
> > > --- a/net/tap-bsd.c
> > > +++ b/net/tap-bsd.c
> > > @@ -40,7 +40,8 @@
> > > #include
> > > #endif
> >
In order to support macvtap, we need a way to select the actual
tap endpoint. While it would be nice to pass it by network interface
name, passing the character device is more flexible, and we can
easily do both in the long run.
This version makes it possible to use macvtap without introducing
any
On Wed, Dec 09, 2009 at 03:49:04PM +0100, Arnd Bergmann wrote:
> In order to support macvtap, we need a way to select the actual
> tap endpoint. While it would be nice to pass it by network interface
> name, passing the character device is more flexible, and we can
> easily do both in the long run.
On Wednesday 09 December 2009, Michael S. Tsirkin wrote:
> On Wed, Dec 09, 2009 at 03:49:04PM +0100, Arnd Bergmann wrote:
> >
> > -TFR(fd = open("/dev/net/tun", O_RDWR));
> > +if (!*dev)
> > +dev = "/dev/net/tun";
> > +
>
> Did you test without dev parameter? I think dev will be
Device names with whitespace require quoting in the shell and in the
monitor. Some of the offenders are also overly long. Some have a
more convenient alias, some don't.
The place for verbose device names is DeviceInfo member desc. The
name should be short & sweet.
Signed-off-by: Markus Armbrus
Using the qdev name for the product description makes for inconvenient
qdev names.
Put the product description in new USBDeviceInfo member product_desc.
Make usb_qdev_init() use it. No user or guest visible change, since
the value is still the same.
Signed-off-by: Markus Armbruster
---
hw/usb-
It's not a device name, it's the USB product description string.
Signed-off-by: Markus Armbruster
---
hw/bt-hid.c |2 +-
hw/usb-bus.c | 11 ++-
hw/usb-hid.c |2 +-
hw/usb.h |2 +-
usb-bsd.c|4 ++--
usb-linux.c |4 ++--
6 files changed, 13 insertions(+), 12
Device names with whitespace require quoting in the shell and in the
monitor. Some of the offenders are also overly long. Some have a
more convenient alias, some don't.
The place for verbose device names is DeviceInfo member desc. The
name should be short & sweet.
This patch gets rid of the sp
On Tue, Dec 08, 2009 at 01:11:35PM +0100, Gerd Hoffmann wrote:
> i.e. -global PCI.= will set a default property for all
> PCI devices. Also works for the compat properties used by machine
> types.
>
> Signed-off-by: Gerd Hoffmann
Looks like an earlier version of the patches was applied
on stagi
Hi,
* usb_qdev_init() copies the qdev name to USBDevice devname. Gets
overwritten for usb-host devices, but not for the others. This is
what Gerd pointed out. I fixed it just like Gerd recommended.
Looks good now. Ack to the whole series.
cheers,
Gerd
Hi,
This series covers almost half of the info handlers conversions to the
QObject style.
The biggest change in this version is that now info handlers always
return a QDict.
changelog
-
v2 -> v3
- Change all info handlers to return a dict
- Fix bad do_info_migrate() rebase
- do_info
An easy way to include all QEMU objects.
Signed-off-by: Luiz Capitulino
---
qemu-objects.h | 24
1 files changed, 24 insertions(+), 0 deletions(-)
create mode 100644 qemu-objects.h
diff --git a/qemu-objects.h b/qemu-objects.h
new file mode 100644
index 000..e1d1e
Other subsystems will need to link against them.
Signed-off-by: Luiz Capitulino
---
Makefile |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 85ad688..ea90c23 100644
--- a/Makefile
+++ b/Makefile
@@ -82,6 +82,12 @@ ALL_SUBDIRS=$(TARGET_DI
This is a helper function that does type checking before retrieving
a QBool from the dictionary.
Signed-off-by: Luiz Capitulino
---
Makefile |2 +-
qdict.c | 15 +++
qdict.h |1 +
3 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index ea
A helper function to get a QList from a QDict.
Signed-off-by: Luiz Capitulino
---
Makefile |2 +-
qdict.c | 13 +
qdict.h |2 ++
3 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index b4356ae..f1b0131 100644
--- a/Makefile
+++ b/Makefile
Monitor commands should always return values in bytes and info
commands should always return a QDict.
Signed-off-by: Luiz Capitulino
---
monitor.c | 19 ---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index a38a103..aa56ec7 100644
--- a
While there update the documentation as well.
Signed-off-by: Luiz Capitulino
---
monitor.c | 39 ++-
1 files changed, 26 insertions(+), 13 deletions(-)
diff --git a/monitor.c b/monitor.c
index aa56ec7..8729535 100644
--- a/monitor.c
+++ b/monitor.c
@@ -611,
All 'info' commands should use QDict, this commit also kills
monitor_print_qobject() as do_info_version() doesn't use it
anymore (and no handler will).
Signed-off-by: Luiz Capitulino
---
monitor.c | 42 ++
1 files changed, 22 insertions(+), 20 deletions(
Signed-off-by: Luiz Capitulino
---
monitor.c | 44 +++-
1 files changed, 35 insertions(+), 9 deletions(-)
diff --git a/monitor.c b/monitor.c
index 775e687..e7a6294 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1910,16 +1910,41 @@ static void do_inject_nmi(M
Signed-off-by: Luiz Capitulino
---
monitor.c | 41 +
1 files changed, 33 insertions(+), 8 deletions(-)
diff --git a/monitor.c b/monitor.c
index e7a6294..47f794d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1783,16 +1783,40 @@ static void tlb_info(Monitor *
Signed-off-by: Luiz Capitulino
---
monitor.c | 29 +
1 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index 47f794d..3d33bd8 100644
--- a/monitor.c
+++ b/monitor.c
@@ -514,10 +514,30 @@ static void do_info_version(Monitor *mon, QO
Signed-off-by: Luiz Capitulino
---
monitor.c | 24 +---
1 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 3d33bd8..72fd573 100644
--- a/monitor.c
+++ b/monitor.c
@@ -570,10 +570,27 @@ static void do_info_commands(Monitor *mon, QObjec
snprintf() is used because the UUID_FMT is too complex for
qobject_from_jsonf().
Signed-off-by: Luiz Capitulino
---
monitor.c | 26 +++---
1 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 72fd573..f0cb759 100644
--- a/monitor.c
+++
Each mouse is represented by a QDict, the returned QObject is a QList of
all mice.
This commit should not change user output.
Signed-off-by: Luiz Capitulino
---
console.h |3 +-
monitor.c |3 +-
vl.c | 62 ++--
3 files chang
Return a QDict, which may contain more two QDicts, depending on
the type of migration we're performing.
IMPORTANT: as a QInt stores a int64_t integer, RAM values are going
to be stored as int64_t and not as uint64_t as they are today. If
this is a problem QInt will have to be changed.
This commit
Each block device information is stored in a QDict and the
returned QObject is a QList of all devices.
This commit should not change user output.
Signed-off-by: Luiz Capitulino
---
Makefile |6 +-
block.c | 123 +++--
block.h |
Each device statistic information is stored in a QDict and
the returned QObject is a QList of all devices.
This commit should not change user output.
Signed-off-by: Luiz Capitulino
---
block.c | 82
block.h |3 +-
monitor.c
Each device is represented by a QDict. The returned QObject is a QList
of all devices.
This commit should not change user output.
Signed-off-by: Luiz Capitulino
---
monitor.c |3 ++-
qemu-char.c | 43 +--
qemu-char.h |4 +++-
3 files changed,
Return a QDict with information about the just added device.
This commit should not change user output.
Please, note that this patch does not do error handling
conversion. In error conditions the handler still calls
monitor_printf().
Signed-off-by: Luiz Capitulino
---
hw/pci-hotplug.c | 40 +
Return a QDict with server information. Connected clients are returned
as a QList of QDicts.
The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and
put_addr_qdict()) are used to insert 'host' and 'service' information
in the returned QDict.
This patch is big, but I don't see how t
On Sun, Dec 06, 2009 at 04:43:03PM -0600, Anthony Liguori wrote:
> The QEMU team is pleased to announce the availability of the 0.12.0-rc1
> release. This is the first release candidate for the 0.12.0 release.
> This release is not intended for production use.
>
> Testing release candidates is a
Marcelo correctly remarked that there are usage conflicts between QEMU
core code and KVM /wrt exception_index. So spend a separate field and
also save/restore it properly.
Signed-off-by: Jan Kiszka
---
NOTE: This obsoletes "kvm: x86: Save/restore exception_index".
target-i386/cpu.h |1
Reverted the vmstate changes since that has not made it into stable-0.12 yet.
This iteration addresses all of the comments from the last round. Thanks to
everyone for their careful reviews and helpful comments. The most significant
change in this version is my use of the QObject API, so a concen
qemu_malloc() does not allow size=0 to be passed in and aborts on this behavior.
Unfortunately, there is good reason to believe that within qemu, there are a
number of, so far, undetected places that assume size=0 can be safely passed.
Since we do not want to abort unnecessarily in production buil
Anthony Liguori writes:
> qemu_malloc() does not allow size=0 to be passed in and aborts on this
> behavior.
>
> Unfortunately, there is good reason to believe that within qemu, there are a
> number of, so far, undetected places that assume size=0 can be safely passed.
> Since we do not want to
Arnd Bergmann wrote:
As promised, here is my small writeup on which setups I feel
are important in the long run for server-type guests. This
does not cover -net user, which is really for desktop kinds
of applications where you do not want to connect into the
guest from another IP address.
I can
Arnd Bergmann wrote:
In order to support macvtap, we need a way to select the actual
tap endpoint. While it would be nice to pass it by network interface
name, passing the character device is more flexible, and we can
easily do both in the long run.
Signed-off-by: Arnd Bergmann
This isn't
Command register for e1000 was initialized to
values out of spec: all of bus master,
io, memory and interrupt disable bits were set.
This breaks the device now that we actually respect
the interrupt disable bit, unless the guest
happens to clear it. Fix, and make the device
more spec compliant, by
Markus Armbruster wrote:
Anthony Liguori writes:
qemu_malloc() does not allow size=0 to be passed in and aborts on this behavior.
Unfortunately, there is good reason to believe that within qemu, there are a
number of, so far, undetected places that assume size=0 can be safely passed.
Since
Right now, if an incoming migrate through exec fails, the qemu process will end
up chewing CPU indefinitely - it looks like it closes the migration FD but
doesn't remove its IO handler properly. An easy way to reproduce this is to try
launching with -incoming exec:/bin/false. This is obviously u
Anthony Liguori writes:
> Markus Armbruster wrote:
>> This still aborts on qemu_realloc(NULL, 0), even with
>> CONFIG_ZERO_MALLOC. Intentional?
>>
> I guess not. Should it? Seems like a very strange case..
It is a strange case, but I think the point of this commit is not to
abort on condit
Signed-off-by: Richard Henderson
---
hw/alpha_palcode.c | 29 +++--
1 files changed, 27 insertions(+), 2 deletions(-)
diff --git a/hw/alpha_palcode.c b/hw/alpha_palcode.c
index c48a297..44b2ca4 100644
--- a/hw/alpha_palcode.c
+++ b/hw/alpha_palcode.c
@@ -1062,6 +1062,1
1. Add correct definitions of error numbers.
2. Implement SYS_osf_sigprocmask
3. Implement SYS_osf_get/setsysinfo for IEEE_FP_CONTROL.
This last requires exposing the FPCR value to do_syscall.
Since this value is actually split up into the float_status,
expose routines from helper.c to access it.
The following patch series results in an emulator that's good enough
to run a good bit of the GCC testsuite, dynamic linking and all.
There are more failures than native hardware. At first glance they
appear to be fpu related, but I havn't investigated properly yet.
r~
--
Richard Henderson (7
Signed-off-by: Richard Henderson
---
target-alpha/helper.h|2 --
target-alpha/op_helper.c |5 -
target-alpha/translate.c |8 +---
3 files changed, 1 insertions(+), 14 deletions(-)
diff --git a/target-alpha/helper.h b/target-alpha/helper.h
index a4faca2..9c60be1 100644
--
Also change the default cpu to ev67.
Signed-off-by: Richard Henderson
---
target-alpha/translate.c | 44 ++--
1 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/target-alpha/translate.c b/target-alpha/translate.c
index ae1f5a8..3f8d1b2 100
Signed-off-by: Richard Henderson
---
qemu-binfmt-conf.sh |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/qemu-binfmt-conf.sh b/qemu-binfmt-conf.sh
index 941f0cf..ba916ac 100644
--- a/qemu-binfmt-conf.sh
+++ b/qemu-binfmt-conf.sh
@@ -34,6 +34,9 @@ if [ $cpu != "i386" ]
Signed-off-by: Richard Henderson
---
linux-user/elfload.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 682a813..f47ec1e 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -677,9 +677,6 @@ static inline v
Signed-off-by: Richard Henderson
---
configure |2 +-
fpu/softfloat-specialize.h |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index a29839e..2d46abb 100755
--- a/configure
+++ b/configure
@@ -2432,7 +2432,7 @@ if test ! -z
On Thu, Dec 10, 2009 at 1:05 AM, Richard Henderson wrote:
>
> The following patch series results in an emulator that's good enough
> to run a good bit of the GCC testsuite, dynamic linking and all.
> There are more failures than native hardware. At first glance they
> appear to be fpu related, bu
Gerd Hoffmann writes:
> This reverts commit adcb181afe5a951c521411c7a8e9d9b791aa6742.
Would be nice to state why it's reverted, and that it'll be back in a
few commits.
>
> Conflicts:
>
> monitor.h
>
> Signed-off-by: Gerd Hoffmann
[...]
62 matches
Mail list logo
