Re: [Qemu-devel] [PATCH 06/11] Add support for S390x system emulation

On Mon, Nov 30, 2009 at 11:19:06PM +0100, Alexander Graf wrote: > > On 30.11.2009, at 19:18, Aurelien Jarno wrote: > > > On Thu, Nov 26, 2009 at 02:23:15PM +0100, Alexander Graf wrote: > >> Let's enable the basics for system emulation so we can run virtual machines > >> with KVM! > > > > I don't

Re: [Qemu-devel] [PATCH 04/11] Add KVM support for S390x

On Mon, Nov 30, 2009 at 11:25:03PM +0100, Alexander Graf wrote: > > On 30.11.2009, at 19:18, Aurelien Jarno wrote: > > > On Thu, Nov 26, 2009 at 02:23:13PM +0100, Alexander Graf wrote: > >> S390x was one of the first platforms that received support for KVM back in > >> the > >> day. Unfortunatel

Re: [Qemu-devel] [PATCH 03/11] S/390 fake TCG implementation

On Mon, Nov 30, 2009 at 11:27:53PM +0100, Alexander Graf wrote: > > On 30.11.2009, at 19:18, Aurelien Jarno wrote: > > > On Thu, Nov 26, 2009 at 02:23:12PM +0100, Alexander Graf wrote: > >> Qemu won't let us run a KVM target without having host TCG support. Well, > >> for > >> now we don't have

Re: [Qemu-devel] [PATCH 01/11] S/390 CPU fake emulation

On Mon, Nov 30, 2009 at 11:30:04PM +0100, Alexander Graf wrote: > > On 30.11.2009, at 19:18, Aurelien Jarno wrote: > > > On Thu, Nov 26, 2009 at 02:23:10PM +0100, Alexander Graf wrote: > >> Because Qemu currently requires a TCG target to exist and there are quite > >> some > >> useful helpers he

Re: [Qemu-devel] Unclear committer situation

On Tue, Dec 01, 2009 at 12:47:36PM +0100, Alexander Graf wrote: > Hi, > > Could someone with commit rights please stand up to feel responsible for > PPC? > > Usually, when I send a patch to qemu-devel, I know who to address to > increase chances of it getting committed. For kvm/vnc/block I just

Re: [Qemu-devel] [PATCH 06/11] Add support for S390x system emulation

On 02.12.2009, at 09:09, Aurelien Jarno wrote: > On Mon, Nov 30, 2009 at 11:19:06PM +0100, Alexander Graf wrote: >> >> On 30.11.2009, at 19:18, Aurelien Jarno wrote: >> >>> On Thu, Nov 26, 2009 at 02:23:15PM +0100, Alexander Graf wrote: Let's enable the basics for system emulation so we ca

Re: [Qemu-devel] [PATCH 04/11] Add KVM support for S390x

On 02.12.2009, at 09:12, Aurelien Jarno wrote: > On Mon, Nov 30, 2009 at 11:25:03PM +0100, Alexander Graf wrote: >> >> On 30.11.2009, at 19:18, Aurelien Jarno wrote: >> >>> On Thu, Nov 26, 2009 at 02:23:13PM +0100, Alexander Graf wrote: S390x was one of the first platforms that received su

Re: [Qemu-devel] [PATCH 03/11] S/390 fake TCG implementation

On 02.12.2009, at 09:16, Aurelien Jarno wrote: > On Mon, Nov 30, 2009 at 11:27:53PM +0100, Alexander Graf wrote: >> >> On 30.11.2009, at 19:18, Aurelien Jarno wrote: >> >>> On Thu, Nov 26, 2009 at 02:23:12PM +0100, Alexander Graf wrote: Qemu won't let us run a KVM target without having hos

Re: [Qemu-devel] [PATCH 01/11] S/390 CPU fake emulation

On 02.12.2009, at 09:17, Aurelien Jarno wrote: > On Mon, Nov 30, 2009 at 11:30:04PM +0100, Alexander Graf wrote: >> >> On 30.11.2009, at 19:18, Aurelien Jarno wrote: >> >>> On Thu, Nov 26, 2009 at 02:23:10PM +0100, Alexander Graf wrote: Because Qemu currently requires a TCG target to exist

Re: [Qemu-devel] [PATCH] experimental sh4 host support V2

On Sun, Nov 15, 2009 at 08:53:55PM +0900, Magnus Damm wrote: > From: Magnus Damm > > This is V2 of the QEMU sh4 host support patch. > > The code is of a somewhat experimental nature, which means that > only the bare essentials are in place. The sh4 host support has > been tested with the sh4 tar

Re: [Qemu-devel] Unclear committer situation

On 02.12.2009, at 09:26, Aurelien Jarno wrote: > On Tue, Dec 01, 2009 at 12:47:36PM +0100, Alexander Graf wrote: >> Hi, >> >> Could someone with commit rights please stand up to feel responsible for >> PPC? >> >> Usually, when I send a patch to qemu-devel, I know who to address to >> increas

Re: [Qemu-devel] [PATCH 06/11] Add support for S390x system emulation

On Wed, Dec 02, 2009 at 09:27:21AM +0100, Alexander Graf wrote: > > On 02.12.2009, at 09:09, Aurelien Jarno wrote: > > > On Mon, Nov 30, 2009 at 11:19:06PM +0100, Alexander Graf wrote: > >> > >> On 30.11.2009, at 19:18, Aurelien Jarno wrote: > >> > >>> On Thu, Nov 26, 2009 at 02:23:15PM +0100,

Re: [Qemu-devel] [PATCH 06/11] Add support for S390x system emulation

On 02.12.2009, at 09:37, Aurelien Jarno wrote: > On Wed, Dec 02, 2009 at 09:27:21AM +0100, Alexander Graf wrote: >> >> On 02.12.2009, at 09:09, Aurelien Jarno wrote: >> >>> On Mon, Nov 30, 2009 at 11:19:06PM +0100, Alexander Graf wrote: On 30.11.2009, at 19:18, Aurelien Jarno wrote:

Re: [Qemu-devel] [PATCH 03/11] S/390 fake TCG implementation

On Wed, Dec 02, 2009 at 09:29:59AM +0100, Alexander Graf wrote: > > On 02.12.2009, at 09:16, Aurelien Jarno wrote: > > > On Mon, Nov 30, 2009 at 11:27:53PM +0100, Alexander Graf wrote: > >> > >> On 30.11.2009, at 19:18, Aurelien Jarno wrote: > >> > >>> On Thu, Nov 26, 2009 at 02:23:12PM +0100,

Re: [Qemu-devel] [PATCH 04/11] Add KVM support for S390x

On Wed, 2 Dec 2009, Alexander Graf wrote: > > On 02.12.2009, at 09:12, Aurelien Jarno wrote: > > > On Mon, Nov 30, 2009 at 11:25:03PM +0100, Alexander Graf wrote: > >> > >> On 30.11.2009, at 19:18, Aurelien Jarno wrote: > >> > >>> On Thu, Nov 26, 2009 at 02:23:13PM +0100, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH 03/11] S/390 fake TCG implementation

On 02.12.2009, at 09:41, Aurelien Jarno wrote: > On Wed, Dec 02, 2009 at 09:29:59AM +0100, Alexander Graf wrote: >> >> On 02.12.2009, at 09:16, Aurelien Jarno wrote: >> >>> On Mon, Nov 30, 2009 at 11:27:53PM +0100, Alexander Graf wrote: On 30.11.2009, at 19:18, Aurelien Jarno wrote:

Re: [Qemu-devel] Unclear committer situation

On Wed, 2 Dec 2009, Aurelien Jarno wrote: > On Tue, Dec 01, 2009 at 12:47:36PM +0100, Alexander Graf wrote: > > Hi, > > > > Could someone with commit rights please stand up to feel responsible for > > PPC? > > > > Usually, when I send a patch to qemu-devel, I know who to address to > > increase

Re: [Qemu-devel] Unclear committer situation

On Wed, Dec 02, 2009 at 09:37:16AM +0100, Alexander Graf wrote: > > On 02.12.2009, at 09:26, Aurelien Jarno wrote: > > > On Tue, Dec 01, 2009 at 12:47:36PM +0100, Alexander Graf wrote: > >> Hi, > >> > >> Could someone with commit rights please stand up to feel responsible for > >> PPC? > >> >

Re: [Qemu-devel] [PATCH 04/11] Add KVM support for S390x

On 02.12.2009, at 09:42, malc wrote: > On Wed, 2 Dec 2009, Alexander Graf wrote: > >> >> On 02.12.2009, at 09:12, Aurelien Jarno wrote: >> >>> On Mon, Nov 30, 2009 at 11:25:03PM +0100, Alexander Graf wrote: On 30.11.2009, at 19:18, Aurelien Jarno wrote: > On Thu, Nov 26, 2

Re: [Qemu-devel] Unclear committer situation

On 02.12.2009, at 09:46, Aurelien Jarno wrote: > On Wed, Dec 02, 2009 at 09:37:16AM +0100, Alexander Graf wrote: >> >> On 02.12.2009, at 09:26, Aurelien Jarno wrote: >> >>> On Tue, Dec 01, 2009 at 12:47:36PM +0100, Alexander Graf wrote: Hi, Could someone with commit rights pleas

Re: [Qemu-devel] [PATCH 04/11] Add KVM support for S390x

On Wed, 2 Dec 2009, Alexander Graf wrote: > > On 02.12.2009, at 09:42, malc wrote: > > > On Wed, 2 Dec 2009, Alexander Graf wrote: [..snip..] > > > > Why such a name starting with an underscore? > > Because that's the internal function that gets used by the exported, > >>>

Re: [Qemu-devel] Unclear committer situation

On 12/02/2009 10:37 AM, Alexander Graf wrote: On 02.12.2009, at 09:26, Aurelien Jarno wrote: On Tue, Dec 01, 2009 at 12:47:36PM +0100, Alexander Graf wrote: Hi, Could someone with commit rights please stand up to feel responsible for PPC? Usually, when I send a patch to qemu-devel,

Re: [Qemu-devel] [PATCH 04/11] Add KVM support for S390x

malc writes: > On Wed, 2 Dec 2009, Alexander Graf wrote: > >> >> On 02.12.2009, at 09:12, Aurelien Jarno wrote: >> >> > On Mon, Nov 30, 2009 at 11:25:03PM +0100, Alexander Graf wrote: >> >> >> >> On 30.11.2009, at 19:18, Aurelien Jarno wrote: >> >> >> >>> On Thu, Nov 26, 2009 at 02:23:13PM +0

Re: [Qemu-devel] [PATCH 04/11] Add KVM support for S390x

On Wed, 2 Dec 2009, Markus Armbruster wrote: > malc writes: > > > On Wed, 2 Dec 2009, Alexander Graf wrote: > > > >> > >> On 02.12.2009, at 09:12, Aurelien Jarno wrote: > >> > >> > On Mon, Nov 30, 2009 at 11:25:03PM +0100, Alexander Graf wrote: > >> >> > >> >> On 30.11.2009, at 19:18, Aurelie

[Qemu-devel] Re: [PATCH] vmstate: Avoid seeking

Jan Kiszka wrote: > Seeking on vmstate save/load does not work if the underlying file is a > stream. We could try to make all QEMUFile* forward-seek-aware, but first > attempts in this direction indicated that it's saner to convert the few > qemu_fseek-on-vmstates users to plain reads/writes. > >

[Qemu-devel] [PATCH] ram migration: Properly reset statistics

As we may do more than one migration (cancellation, live backup), reset bytes_transferred on stage 1. Signed-off-by: Jan Kiszka --- vl.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index dbf1180..dc62c68 100644 --- a/vl.c +++ b/vl.c @@ -2896,7 +2896,7

Re: [Qemu-devel] [PATCH v2] Don't leak file descriptors

Am 01.12.2009 16:55, schrieb Alexander Graf: > Kevin Wolf wrote: >> We're leaking file descriptors to child processes. Set FD_CLOEXEC on file >> descriptors that don't need to be passed to children to stop this >> misbehaviour. >> >> Signed-off-by: Kevin Wolf > > On Anthony's staging tree: > > c

Re: [Qemu-devel] Socket reconnection.

Anthony Liguori wrote: > sleep() in qemu is very, very wrong. It will pause the guest's > execution and all sorts of badness can ensue. Quite... > The right thing to do is set a timer and not generate data while > disconnected. New patch attached, now with less crack... > I still am not conf

Re: [Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state

On Tue, Dec 01, 2009 at 10:51:31AM -0200, Glauber Costa wrote: > This fix a bug with -smp in kvm. Since we have updated apic_base, > we also have to tell kernel about it. So instead of just updating > mp_state, update every regs. > > It is mandatory that this happens synchronously, without waiting

[Qemu-devel] [PATCH v3 00/10] *** SUBJECT HERE ***

[v3] - Fix UNUSED size to 3 for ac97. - use %zd for sizeof() values insead of %lu. [v2] - rebased to top of qemu/master - removed IO_READ/WRITE_PROTO cleanups. - rest is the same that previous round. malc agreed to let them it. Later, Juan. [v1] THis patch series port audio to vmstate. - fix c

[Qemu-devel] [PATCH 01/10] audio: fix compilation of DEBUG_PLIVE

Signed-off-by: Juan Quintela --- audio/audio_template.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/audio/audio_template.h b/audio/audio_template.h index 1a4707b..6b19848 100644 --- a/audio/audio_template.h +++ b/audio/audio_template.h @@ -445,9 +445,9 @@ SW *gl

[Qemu-devel] [PATCH 02/10] audio: port to vmstate

Signed-off-by: Juan Quintela --- audio/audio.c | 26 +- 1 files changed, 9 insertions(+), 17 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 80a717b..a5305c4 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1784,23 +1784,15 @@ static void audio_atexit (

[Qemu-devel] [PATCH 03/10] sb16: port to vmstate

Signed-off-by: Juan Quintela --- hw/sb16.c | 168 ++--- 1 files changed, 61 insertions(+), 107 deletions(-) diff --git a/hw/sb16.c b/hw/sb16.c index 12ddad4..4c0d682 100644 --- a/hw/sb16.c +++ b/hw/sb16.c @@ -1244,115 +1244,10 @@ static v

[Qemu-devel] [PATCH 04/10] es1370: port to vmstate

Signed-off-by: Juan Quintela --- hw/es1370.c | 77 +++--- 1 files changed, 36 insertions(+), 41 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 10da250..4e646dc 100644 --- a/hw/es1370.c +++ b/hw/es1370.c @@ -924,48 +924,28 @@ stati

[Qemu-devel] [PATCH 05/10] c4231a: port to vmstate

Signed-off-by: Juan Quintela --- hw/cs4231a.c | 58 ++ 1 files changed, 30 insertions(+), 28 deletions(-) diff --git a/hw/cs4231a.c b/hw/cs4231a.c index e03c5d2..7c29aa8 100644 --- a/hw/cs4231a.c +++ b/hw/cs4231a.c @@ -596,45 +596,47 @@

[Qemu-devel] [PATCH 07/10] ac97: sizeof needs %zd

This change makes DEBUG_AC97 to compile again Signed-off-by: Juan Quintela --- hw/ac97.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index f72c46d..36aab8a 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -323,7 +323,7 @@ static void reset_bm_regs (

[Qemu-devel] [PATCH 08/10] ac97: recalculate active after loadvm

Signed-off-by: Juan Quintela --- hw/ac97.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index 36aab8a..e89a56a 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1242,6 +1242,9 @@ static int ac97_load (QEMUFile *f, void *opaque, int version_id) V

[Qemu-devel] [PATCH 06/10] gus: port to vmstate

Signed-off-by: Juan Quintela --- hw/gus.c | 47 +-- 1 files changed, 17 insertions(+), 30 deletions(-) diff --git a/hw/gus.c b/hw/gus.c index c6b98b3..d35da0a 100644 --- a/hw/gus.c +++ b/hw/gus.c @@ -215,35 +215,22 @@ static int GUS_read_DMA (void *

[Qemu-devel] [PATCH 09/10] ac97: up savevm version and remove active from state

Signed-off-by: Juan Quintela --- hw/ac97.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index e89a56a..cc5ec30 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1170,7 +1170,6 @@ static void po_callback (void *opaque, int free) static void

[Qemu-devel] [PATCH 10/10] ac97: port to vmstate

Signed-off-by: Juan Quintela --- hw/ac97.c | 101 ++-- 1 files changed, 44 insertions(+), 57 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index cc5ec30..f2d2823 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1167,68 +1167,31 @@ static void

Re: [Qemu-devel] [PATCH v2 0/11]

On Tue, Dec 01, 2009 at 10:51:26AM -0200, Glauber Costa wrote: > This is a repost of the -smp series. Note that it depends on > irqchip-in-kernel, > that is already in staging. Also, you'll have to enable the io-thread, for > the time > being. > > >From the last version, main change is that I am

[Qemu-devel] Re: [PATCH] vmstate: Avoid seeking

Juan Quintela wrote: > Jan Kiszka wrote: >> Seeking on vmstate save/load does not work if the underlying file is a >> stream. We could try to make all QEMUFile* forward-seek-aware, but first >> attempts in this direction indicated that it's saner to convert the few >> qemu_fseek-on-vmstates users

[Qemu-devel] Re: [PATCH v3 00/10] mean audio: port to vmstate

Juan Quintela wrote: > [v3] Sorry to forget to put the subject in the 1st email. Later, Juan.

Re: [Qemu-devel] Unclear committer situation

2009/12/1 Alexander Graf : > Maintainership for a subsystem is completely different from "feeling > responsible for patches". You can be the person checking stuff in without > knowing anything about the subsystem. If it breaks, have the community fix > it. If it stays broken and nobody cares, re

Re: [Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state

>> +{ >> +    if (kvm_enabled()) { > Is this ever called or intended to be called when kvm is disabled? > >> +        kvm_cpu_flush_state(env); >> +    } I don't think so. But this is here for consistency with its synchronize brother. -- Glauber Costa. "Free as in Freedom" http://glommer.net

Re: [Qemu-devel] Unclear committer situation

andrzej zaborowski wrote: > 2009/12/1 Alexander Graf : > >> Maintainership for a subsystem is completely different from "feeling >> responsible for patches". You can be the person checking stuff in without >> knowing anything about the subsystem. If it breaks, have the community fix >> it. If

[Qemu-devel] Re: [PATCH] vmstate: Avoid seeking

Jan Kiszka wrote: > Juan Quintela wrote: >> Jan Kiszka wrote: >>> Seeking on vmstate save/load does not work if the underlying file is a >>> stream. We could try to make all QEMUFile* forward-seek-aware, but first >>> attempts in this direction indicated that it's saner to convert the few >>> qem

[Qemu-devel] [PATCH v2] Don't leak file descriptors

We're leaking file descriptors to child processes. Set FD_CLOEXEC on file descriptors that don't need to be passed to children to stop this misbehaviour. Signed-off-by: Kevin Wolf --- v2: - The existence of SOCK_CLOEXEC doesn't mean that accept4 exists. Added a check for it in configure. blo

[Qemu-devel] Re: [PATCH v2] Don't leak file descriptors

Am 02.12.2009 12:24, schrieb Kevin Wolf: > We're leaking file descriptors to child processes. Set FD_CLOEXEC on file > descriptors that don't need to be passed to children to stop this > misbehaviour. > > Signed-off-by: Kevin Wolf > --- > > v2: > - The existence of SOCK_CLOEXEC doesn't mean tha

Re: [Qemu-devel] Unclear committer situation

On Tue, Dec 01, 2009 at 12:51:25PM -0600, Anthony Liguori wrote: >> There are some subsystems where nobody feels responsible though, >> apparently hoping 'someone else' will tske on it. Well, turns out it >> doesn't work that way. > The general problem is that someone has to step up to maintai

[Qemu-devel] [PATCH 00/12] vmstate cleanups and fixes

The new features are going to be used in next series (virtio port to vmstate). I just sent it because the cleanups were needed for other people. This patch is on top of my audio vmstate changes series (but it should be independent). - fseek + migration has stopped working, just read to a local buf

[Qemu-devel] [PATCH 01/12] vmstate: Avoid seeking

From: Jan Kiszka Seeking on vmstate save/load does not work if the underlying file is a stream. We could try to make all QEMUFile* forward-seek-aware, but first attempts in this direction indicated that it's saner to convert the few qemu_fseek-on-vmstates users to plain reads/writes. This fixes

[Qemu-devel] [PATCH 02/12] vmstate: Fix info field of VMSTATE_MACADDR

From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Juan Quintela --- hw/hw.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 7889aa3..c3c0c9f 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -545,7 +545,7 @@ extern const VMStateDescription vmstate_

[Qemu-devel] [PATCH 03/12] vmstate: fix missing ARRAY_OF_POINTERS support on save state

Signed-off-by: Juan Quintela --- savevm.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 833bf3c..8fac502 100644 --- a/savevm.c +++ b/savevm.c @@ -1206,6 +1206,9 @@ void vmstate_save_state(QEMUFile *f, const VMStateDescription *vmsd,

[Qemu-devel] [PATCH 04/12] vmstate: Add support for VBUFFERS

Support for buffer that are pointed by a pointer (i.e. not embedded) where the size that we want to use is a field in the state. We also need a new place to store where to start in the middle of the buffer, as now it is a pointer, not the offset of the 1st field. Signed-off-by: Juan Quintela ---

[Qemu-devel] [PATCH 05/12] vmstate: Introduce VMSTATE_STRUCT_TEST

Signed-off-by: Juan Quintela --- hw/hw.h | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 47fb12b..0f4442a 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -436,13 +436,14 @@ extern const VMStateInfo vmstate_info_unused_buffer; .offset

[Qemu-devel] [PATCH 06/12] vmstate: Introduce VMSTATE_STRUCT_POINTER_TEST

Signed-off-by: Juan Quintela --- hw/hw.h | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 0f4442a..0a5acd4 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -446,12 +446,13 @@ extern const VMStateInfo vmstate_info_unused_buffer; .offset

[Qemu-devel] [PATCH 07/12] vmstate: Introduce UINT16_TEST support

Signed-off-by: Juan Quintela --- hw/hw.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 0a5acd4..5994d86 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -633,6 +633,9 @@ extern const VMStateDescription vmstate_i2c_slave; #define VMSTATE_INT32_LE(_f, _s)

[Qemu-devel] [PATCH 08/12] vmstate: remove usused VMSTATE_STRUCT_ARRAY_SIZE_UINT8

Signed-off-by: Juan Quintela --- hw/hw.h | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 5994d86..41e13cc 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -475,16 +475,6 @@ extern const VMStateInfo vmstate_info_unused_buffer; .offset = vms

[Qemu-devel] [PATCH 11/12] qdev: enable vmstate_unregister() support

Now vmstate_unregister have the right type Signed-off-by: Juan Quintela --- hw/qdev.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d19d531..e9d76d4 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -296,10 +296,8 @@ void qdev_free(DeviceState *dev

[Qemu-devel] [PATCH 09/12] vmstate: Add support for multiplying size for a constant

When the size that we want to transmit is in another field, but in an unit different that bytes Signed-off-by: Juan Quintela --- hw/hw.h | 13 + savevm.c |6 ++ 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 41e13cc..5f34991 100644

[Qemu-devel] [PATCH 10/12] pci: vmstate_register() already assign consecutive numbers starting at 0

Signed-off-by: Juan Quintela --- hw/pci.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 8cf008d..3f855b3 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -161,8 +161,6 @@ PCIBus *pci_find_root_bus(int domain) void pci_bus_new_inplace(PCIBus *bus, D

[Qemu-devel] [PATCH 12/12] savevm: Port to qdev.vmsd all devices that have qdev

Signed-off-by: Juan Quintela --- hw/ac97.c |2 +- hw/cirrus_vga.c |2 +- hw/cs4231a.c |2 +- hw/e1000.c|4 +--- hw/es1370.c |2 +- hw/gus.c |2 +- hw/lance.c| 14 -- hw/lm832x.c |2 +- hw/lsi53c895a.c

Re: [Qemu-devel] [PATCH v2 0/11]

On Wed, Dec 2, 2009 at 8:59 AM, Gleb Natapov wrote: > On Tue, Dec 01, 2009 at 10:51:26AM -0200, Glauber Costa wrote: >> This is a repost of the -smp series. Note that it depends on >> irqchip-in-kernel, >> that is already in staging. Also, you'll have to enable the io-thread, for >> the time >>

Re: [Qemu-devel] Re: [PATCH v2] Don't leak file descriptors

On Wed, Dec 2, 2009 at 7:26 PM, Kevin Wolf wrote: > v3 even. Anthony, I hope this doesn't confuse your scripts? Kevin, I see use of fopen, fdopen, popen, eventfd in qemu without the equivalent of CLOEXEC set. Do you want to handle those in this patch series as well?

[Qemu-devel] Re: [PATCH v2 0/11]

Gleb Natapov wrote: > On Tue, Dec 01, 2009 at 10:51:26AM -0200, Glauber Costa wrote: >> This is a repost of the -smp series. Note that it depends on >> irqchip-in-kernel, >> that is already in staging. Also, you'll have to enable the io-thread, for >> the time >> being. >> >> >From the last versi

[Qemu-devel] Re: Socket reconnection.

Ian Molton wrote: > btw. Does anyone know how to get t-bird to inline patches? I'm using Thunderbird for single patches. For a fairly efficient workflow, I've installed Toggle Word Wrap [1] and defined a short-cut for it (here: Alt-W). After copy&pasting a patch into the editor window, I simply sw

[Qemu-devel] [PATCH 00/41] virtio: port to vmstate

Hi this patch series run on top of my previous vmstate cleanups and fixes. It ports virtio* and msix at the same time (msix and virtio-pci are too entangled to do it separately). It contains: - Use DO_UPCAST instead of local function for doing the casts - virtio: add a type field (pci and sybor

[Qemu-devel] [PATCH 01/41] virtio: Teach virtio-balloon about DO_UPCAST

Signed-off-by: Juan Quintela --- hw/virtio-balloon.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index cfd3b41..2310ab0 100644 --- a/hw/virtio-balloon.c +++ b/hw/virtio-balloon.c @@ -32,11 +32,6 @@ typedef struct Vi

[Qemu-devel] [PATCH 02/41] virtio: Teach virtio-blk about DO_UPCAST

Signed-off-by: Juan Quintela --- hw/virtio-blk.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 42b766f..39ebc37 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -30,11 +30,6 @@ typedef struct VirtIOBlock size_

[Qemu-devel] [PATCH 03/41] virtio: Teach virtio-console about DO_UPCAST

Signed-off-by: Juan Quintela --- hw/virtio-console.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 57f8f89..e0afe61 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -24,14 +24,9 @@ typedef struct VirtIO

[Qemu-devel] [PATCH 04/41] virtio: Teach virtio-net about DO_UPCAST

Signed-off-by: Juan Quintela --- hw/virtio-net.c | 21 - 1 files changed, 8 insertions(+), 13 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 2f147e5..f518d78 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -61,14 +61,9 @@ typedef struct VirtIONet

[Qemu-devel] [PATCH 05/41] virtio-console: Remove useless casts

Signed-off-by: Juan Quintela --- hw/virtio-console.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index e0afe61..9f1a602 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -53,7 +53,7 @@ static uint32_t virtio_co

[Qemu-devel] [PATCH 07/41] virtio-pci: Remove duplicate test

We already do the test for msix on the caller, just use that test Signed-off-by: Juan Quintela --- hw/msix.c |8 hw/virtio-pci.c |7 --- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 4bc6147..8dca9fd 100644 --- a/hw/msix.c

[Qemu-devel] [PATCH 06/41] virtio: Use DO_UPCAST instead of a cast

virtio_common_init() creates a struct with the right size, DO_UPCAST is the appropiate thing here Signed-off-by: Juan Quintela --- hw/virtio-balloon.c |4 ++-- hw/virtio-blk.c |8 hw/virtio-console.c |3 ++- hw/virtio-net.c |8 4 files changed, 12 insert

[Qemu-devel] [PATCH 08/41] msix: Store sizes that we send/receive

VMstate send buffers in bytes ammonts, not bits or MSIX_ENTRY_SIZE multiples Signed-off-by: Juan Quintela --- hw/msix.c | 13 + hw/pci.h |2 ++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 8dca9fd..62865d0 100644 --- a/hw/msix.c +

[Qemu-devel] [PATCH 09/41] msix: port to vmstate

Signed-off-by: Juan Quintela --- hw/msix.c | 39 --- hw/msix.h |1 + 2 files changed, 33 insertions(+), 7 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 62865d0..f00256a 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -291,29 +291,54 @@ int msix_uninit

[Qemu-devel] [PATCH 10/41] qemu/pci: document msix_entries_nr field

From: Michael S. Tsirkin Document the fact that msix_entries_nr field caches a value from config space. Signed-off-by: Michael S. Tsirkin Signed-off-by: Juan Quintela --- hw/pci.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index c67cc70..20

[Qemu-devel] [PATCH 11/41] virtio: Introduce type field to distingish between PCI and Syborg

Signed-off-by: Juan Quintela --- hw/syborg_virtio.c |1 + hw/virtio-pci.c|2 +- hw/virtio.h|6 ++ 3 files changed, 8 insertions(+), 1 deletions(-) diff --git a/hw/syborg_virtio.c b/hw/syborg_virtio.c index 6cf5a15..46ac192 100644 --- a/hw/syborg_virtio.c +++ b/hw/syb

[Qemu-devel] [PATCH 13/41] msix: msix_load/save are not needed anymore

Signed-off-by: Juan Quintela --- hw/msix.c | 11 --- hw/msix.h |2 -- 2 files changed, 0 insertions(+), 13 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index f00256a..8bbae99 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -328,17 +328,6 @@ const VMStateDescription vmstate_msix = {

[Qemu-devel] [PATCH 12/41] virtio-pci: port pci config to vmstate

Signed-off-by: Juan Quintela --- hw/virtio-pci.c | 72 ++ 1 files changed, 50 insertions(+), 22 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index a2179de..4fe55aa 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -105,35

[Qemu-devel] [PATCH 14/41] virtio: remove save/load_config for virtio

It was used only for PCI virtio devices, state that Signed-off-by: Juan Quintela --- hw/virtio-pci.c | 13 - hw/virtio.c |9 + hw/virtio.h |5 +++-- 3 files changed, 8 insertions(+), 19 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 4fe55

[Qemu-devel] [PATCH 15/41] virtio: remove save/load_queue for virtio

It was used only for PCI virtio devices, state that explicitely Signed-off-by: Juan Quintela --- hw/virtio-pci.c | 24 ++-- hw/virtio.c | 22 -- hw/virtio.h |4 ++-- 3 files changed, 24 insertions(+), 26 deletions(-) diff --git a/hw/virtio

[Qemu-devel] [PATCH 16/41] virtio: Add num_pci_queues field

Signed-off-by: Juan Quintela --- hw/virtio.c | 32 +++- hw/virtio.h |2 ++ 2 files changed, 21 insertions(+), 13 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index b565bf9..f549543 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -615,10 +615,24 @@ void vir

[Qemu-devel] [PATCH 17/41] virtio: split virtio_post_load() from virtio_load()

Signed-off-by: Juan Quintela --- hw/virtio.c | 45 + 1 files changed, 29 insertions(+), 16 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index f549543..bb93e8c 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -656,6 +656,32 @@ void virtio_save(Vi

[Qemu-devel] [PATCH 18/41] virtio: change config_len type to int32_t

size_t changes between 32 and 64 bits, making it bad for a field that needs to be on the 'wire'. This value will never be near int32_t limit. Stored values are very small ints, it is backwards compatible Signed-off-by: Juan Quintela --- hw/virtio.c |4 ++-- hw/virtio.h |2 +- 2 files c

[Qemu-devel] [PATCH 21/41] virtio: port to vmstate

We need to do the virt queue msix and not msix version because we know if there is msix at virtio level, not at queue element level Signed-off-by: Juan Quintela --- hw/hw.h | 10 + hw/virtio.c | 121 --- hw/virtio.h |5 ++ 3

[Qemu-devel] [PATCH 19/41] virtio: use the right types for VirtQueue elements

Signed-off-by: Juan Quintela --- hw/virtio.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index fd617ff..2b36cad 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -646,8 +646,8 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f) qemu

[Qemu-devel] [PATCH 20/41] virtio: abstract test for save/load values

Signed-off-by: Juan Quintela --- hw/virtio.c | 27 --- 1 files changed, 20 insertions(+), 7 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 2b36cad..5497716 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -615,6 +615,20 @@ void virtio_notify_config(VirtIODevice

[Qemu-devel] [PATCH 22/41] virtio-net: change tx_timer_active to uint32_t

It is only used with values 0 and 1 Signed-off-by: Juan Quintela --- hw/virtio-net.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 1b8ce14..fda6a76 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -33,7 +33,7 @@ typedef

[Qemu-devel] [PATCH 23/41] virtio-net: change mergeable_rx_bufs to uint32_t

It only has values 1 and 0 Signed-off-by: Juan Quintela --- hw/virtio-net.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index fda6a76..4ad5edd 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -40,7 +40,7 @@ typedef struct V

[Qemu-devel] [PATCH 24/41] virtio-net: use type checking version of qemu_put/get-*

Signed-off-by: Juan Quintela --- hw/virtio-net.c | 41 + 1 files changed, 21 insertions(+), 20 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 4ad5edd..57ad20b 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -695,20 +695,20 @@ st

[Qemu-devel] [PATCH 25/41] virtio-net: MAC_TABLE_ENTRIES has never been bigger

Signed-off-by: Juan Quintela --- hw/virtio-net.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 57ad20b..e5c6ea0 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -20,6 +20,8 @@ #define VIRTIO_NET_VM_VERSION1

[Qemu-devel] [PATCH 26/41] virtio-net: we know vlans size at compile time, make it static

Signed-off-by: Juan Quintela --- hw/virtio-net.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index e5c6ea0..97db0d0 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -56,7 +56,7 @@ typedef struct VirtIONet uint8_t un

[Qemu-devel] [PATCH 27/41] virtio-net: abstract vlans operations

Signed-off-by: Juan Quintela --- hw/virtio-net.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 97db0d0..cf13e94 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -63,6 +63,21 @@ typedef struct VirtIONet

[Qemu-devel] [PATCH 28/41] virtio-net: make vlan operations on uint8_t, not uint32_t

This fixes endianess problems. Using ints and saving the state as bytes break cross-endian migration. Signed-off-by: Juan Quintela --- hw/virtio-net.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index cf13e94..05cc67f 100

[Qemu-devel] [PATCH 29/41] virtio-net: in_use and first_multi only handle unsigned values

And they were saved/loaded as unsigned already Signed-off-by: Juan Quintela --- hw/virtio-net.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 05cc67f..589ea80 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -50,8 +50

[Qemu-devel] [PATCH 30/41] virtio-net: use save/load type chek functions for has_vent_hdr

Signed-off-by: Juan Quintela --- hw/virtio-net.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 589ea80..c515e0e 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -718,7 +718,7 @@ static void virtio_net_save(QEMUFile *f, v

[Qemu-devel] [PATCH 31/41] virtio-net: we know macs size at compile time, make it static

Signed-off-by: Juan Quintela --- hw/virtio-net.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index c515e0e..550a814 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -54,7 +54,7 @@ typedef struct VirtIONet uint32_t

[Qemu-devel] [PATCH 32/41] virtio-net: split virtio_net_post_load

Signed-off-by: Juan Quintela --- hw/virtio-net.c | 79 --- 1 files changed, 46 insertions(+), 33 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 550a814..4434827 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -703,6

  1   2   3   >