On Thu, Nov 26, 2009 at 09:56:42AM +0200, Gleb Natapov wrote:
> On Thu, Nov 26, 2009 at 02:48:46AM -0500, Kevin O'Connor wrote:
> > That would significantly complicate the code, and it wouldn't truly
> > solve the issue as some data needs to be stored in the f-segment (eg,
> > smbios anchor).
> And
On Thu, Nov 26, 2009 at 03:12:53AM -0500, Kevin O'Connor wrote:
> > > IMO, migrating to a new bios doesn't make sense - the bios is an
> > > application with state - one can't just replace the code.
> > >
> > You don't migrate to a new BIOS. You migrate to a new QEMU that happens
> > to have a new
Hi,
Answering large requests with "Illegal request, Invalid field in CDB"
doesn't makes linux try smaller requests, instead it reports I/O errors
to the syslog.
Hmm.
Can't we just put residuals to good use here?
Ie finish up the request up to the size we can handle, and return the
original
Hi,
Would a patch adding (optional) auto-reconnect (with a back-off delay)
to the socket chardev be acceptable ?
Sounds sensible to me. And, yes, it should be an option (defaulting to
off to maintain current behavior when not specified).
cheers,
Gerd
On Thu, Nov 26, 2009 at 12:21:46PM +0900, Isaku Yamahata wrote:
> On Wed, Nov 25, 2009 at 06:58:34PM +0200, Michael S. Tsirkin wrote:
> > This patchset adds support for mandatory interupt
> > status and interrupt disable bits to all
> > PCI devices. This is required for PCI compliancy.
> >
> > Th
On Thu, Nov 26, 2009 at 12:04:51PM +0900, Isaku Yamahata wrote:
> On Wed, Nov 25, 2009 at 06:59:06PM +0200, Michael S. Tsirkin wrote:
> > interrupt disable bit is mandatory in PCI spec,
> > so we must implement it to be spec compliant.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > hw/pci
Gerd Hoffmann writes:
> On 11/25/09 23:31, H. Peter Anvin wrote:
>> On 11/25/2009 02:26 PM, H. Peter Anvin wrote:
>>>
>>> As such, I think there is still a place for the simple command line
>>> options like "-hda", "-serial" and my proposed "-debugcon", in addition
>>> to the full-featured connec
Juan Quintela schrieb:
> Stefan Weil wrote:
>> All files config-devices.mak are copies from files in
>> directory default-configs.
>>
>> Creating these copies during configuration ignores these
>> dependencies and may result in unresolved externals
>> from incremental builds when files in default-
On Thu, Nov 26, 2009 at 12:21:46PM +0900, Isaku Yamahata wrote:
> At least I think irq_disable can be removed
The following patch on top of mine removes irq_disabled field in
PCIDevice. I am of two minds whether this makes the code better.
What is your opinion?
diff --git a/hw/pci.c b/hw/pci.c
i
Gerd Hoffmann wrote:
> Hi,
>
>>> Answering large requests with "Illegal request, Invalid field in CDB"
>>> doesn't makes linux try smaller requests, instead it reports I/O errors
>>> to the syslog.
>>>
>>> Hmm.
>>>
>> Can't we just put residuals to good use here?
>> Ie finish up the request up t
On 11/26/09 11:57, Hannes Reinecke wrote:
Then the guest would see a partial request and retry the
remainder of the request, which (possibly after some iterations)
would result in all data transferred, albeit at a lower speed.
Except they don't.
/me looks at drivers/scsi/sd.c:sd_done()
I can'
Gerd Hoffmann wrote:
> On 11/26/09 11:57, Hannes Reinecke wrote:
>> Then the guest would see a partial request and retry the
>> remainder of the request, which (possibly after some iterations)
>> would result in all data transferred, albeit at a lower speed.
>
> Except they don't.
>
> /me looks a
On Wed, Nov 25, 2009 at 10:58:45AM +0100, Alexander Graf wrote:
> Ok I just tried to reproduce this using my netbook (32 bits only) and
> your kernel:
Still seeing it using latests qemu.git. Any idea about other information that
might help sorting it out?
I'm running Linux 2.6.31 on the host, bt
Christoph Hellwig wrote:
> On Wed, Nov 25, 2009 at 10:58:45AM +0100, Alexander Graf wrote:
>
>> Ok I just tried to reproduce this using my netbook (32 bits only) and
>> your kernel:
>>
>
> Still seeing it using latests qemu.git. Any idea about other information that
> might help sorting it
On Thu, Nov 26, 2009 at 01:00:25PM +0100, Alexander Graf wrote:
> Hm - are you using -L pc-bios?
No. I use an installed qemu (./configure --prefix=/opt/qemu) and
there's no pc-bios directorie in my kernel source tree where I start it
from.
> Also, maybe there's something in dmesg
> telling you a
Christoph Hellwig wrote:
> On Thu, Nov 26, 2009 at 01:00:25PM +0100, Alexander Graf wrote:
>
>> Hm - are you using -L pc-bios?
>>
>
> No. I use an installed qemu (./configure --prefix=/opt/qemu) and
> there's no pc-bios directorie in my kernel source tree where I start it
> from.
>
Hm
On Thu, Nov 26, 2009 at 11:53:16AM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 26, 2009 at 12:04:51PM +0900, Isaku Yamahata wrote:
> > On Wed, Nov 25, 2009 at 06:59:06PM +0200, Michael S. Tsirkin wrote:
> > > interrupt disable bit is mandatory in PCI spec,
> > > so we must implement it to be spe
> No, this would slow us down because these are per-pin.
> We need a sum of interrupts so that config space
> can be updated by a single command.
> Interrupts are a fastpath, extra loops there should be avoided.
It's really not that much of a fast path. Unless you're doing something
particularly
On Thu, Nov 26, 2009 at 12:41:03PM +, Paul Brook wrote:
> > No, this would slow us down because these are per-pin.
> > We need a sum of interrupts so that config space
> > can be updated by a single command.
> > Interrupts are a fastpath, extra loops there should be avoided.
>
> It's really no
Currently qcow2 unnecessarily rounds up the length of the backing format string
to the next multiple of 8. At the same time, the array in BlockDriverState can
only hold 15 characters, so in effect backing formats with 9 characters or more
don't work (e.g. host_device).
Save the real string length
When guest un-eject a cdrom, re-insert the cdrom image (re-open the drive's
file).
Also, related changes for the un-eject:
o enter UNIT ATTENTION state only on change/insert media, not upon removal
o minor change in packet command abort when in UNIT ATTENTION state (as per
spec)
o enter UNIT
On Thu, Nov 26, 2009 at 12:38:20PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 26, 2009 at 12:21:46PM +0900, Isaku Yamahata wrote:
> > At least I think irq_disable can be removed
>
> The following patch on top of mine removes irq_disabled field in
> PCIDevice. I am of two minds whether this ma
What about overwriting it automatically when it was not modified
by the user? This would only need a backup copy of the original
default configuration. I assume that most users don't change
config-devices.mak, so they would be happy with this solution.
Calling "make defconfig" is only the second
On 11/25/2009 11:54 PM, Gerd Hoffmann wrote:
Wouldn't be that hard I think.
Cool. I had thought of a similar exercise to wet my feet with
qdev/qemuopts, I may actually do it when I have some time...
Paolo
>> It's really not that much of a fast path. Unless you're doing something
>> particularly obscure then even under heavy load you're unlikely to exceed
>> a few kHz.
>
>I think with kvm, heavy disk stressing benchmark can get higher.
I'd still expect this to be the least of your problems.
If not
While S390x was one of the first targets that were supported by KVM it always
lacked qemu system emulation support.
In order to change that sad fact, I figured I'd just take on the task myself,
taking kuli (http://www.ibm.com/developerworks/linux/linux390/kuli.html),
Documentation/s390/kvm.txt and
S390x was one of the first platforms that received support for KVM back in the
day. Unfortunately until now there hasn't been a qemu implementation that would
enable users to actually run guests.
So let's include support for KVM S390x in qemu!
Signed-off-by: Alexander Graf
---
configure
This patch adds information about who handles what when it comes to S390.
I'll gladly support anything that's related to the device emulation model and
S390 KVM parts.
Since this patchset doesn't implement S390 CPU emulation, I left that part
with a question mark. As soon as Uli's patchset gets co
Because Qemu currently requires a TCG target to exist and there are quite some
useful helpers here to lay the groundwork for out KVM target, let's create a
stub TCG emulation target for S390X CPUs.
This is required to make tcg happy. The emulation target itself won't work
though.
Signed-off-by: A
On S390x we don't want to go through the hassle of emulating real existing
hardware, because we don't need to for running Linux.
So let's instead implement a machine that is 100% based on VirtIO which we
fortunately implement already.
This patch implements the bus that is the groundwork for such
Let's enable the basics for system emulation so we can run virtual machines
with KVM!
Signed-off-by: Alexander Graf
---
target-s390x/cpu.h| 153 -
target-s390x/exec.h |5 +
target-s390x/helper.c | 22 +
targ
In order to debug funny kernel breakages it's always good to have a working
gdb stub around.
While Uli's patches don't include one one, I needed one that's at least good
enough for 'bt' and some variable examinations during early bootup.
So here it is - the absolute basics to get the qemu gdb stu
Qemu won't let us run a KVM target without having host TCG support. Well, for
now we don't have any so let's implement a fake target that only stubs out
everything.
I tried to keep the patch as close to Uli's source as possible, so whenever
he feels like it he can easily diff his version against t
In order to use the new S390x virtio bus we just introduced, we also
need a machine description that sets up the machine according to our
PV specification.
Let's add that machine description and be happy!
Signed-off-by: Alexander Graf
---
v4 -> v5
- disable early console
---
Makefile.target
All "normal" system emulation targets in qemu I'm aware of display output
on either VGA or serial output.
Our S390x virtio machine doesn't have such kind of legacy hardware. So
instead we need to default to a virtio console.
I'm not particularly proud of this patch. It would be a lot better to
ha
KVM on S390x requires the virtual address space of the guest's RAM to be
within the first 256GB.
The general direction I'd like to see KVM on S390 move is that this requirement
is losened, but for now that's what we're stuck with.
So let's just hack up qemu_ram_alloc until KVM behaves nicely :-).
This patch makes configure aware of S390 hosts and guests. When not explicitly
defined using --target-list= no S390 targets will be built though.
Signed-off-by: Alexander Graf
---
configure | 20 ++--
1 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/configure b/c
On Thu, Nov 26, 2009 at 12:04:51PM +0900, Isaku Yamahata wrote:
> On Wed, Nov 25, 2009 at 06:59:06PM +0200, Michael S. Tsirkin wrote:
> > interrupt disable bit is mandatory in PCI spec,
> > so we must implement it to be spec compliant.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > hw/pci
On Thu, Nov 26, 2009 at 01:21:39PM +, Paul Brook wrote:
> >> It's really not that much of a fast path. Unless you're doing something
> >> particularly obscure then even under heavy load you're unlikely to exceed
> >> a few kHz.
> >
> >I think with kvm, heavy disk stressing benchmark can get hig
On 11/21/2009 12:34 AM, Kevin O'Connor wrote:
On Thu, Nov 19, 2009 at 04:02:06PM +0200, Avi Kivity wrote:
On 11/19/2009 03:39 PM, Kevin O'Connor wrote:
Long story short - this is the result of gcc's "-combine" being
fragile. It's possible to avoid by compiling seabios with "make
COMP
lir...@il.ibm.com wrote:
> +static int block_load(QEMUFile *f, void *opaque, int version_id)
> +{
> +int len, flags;
> +char device_name[256];
> +int64_t addr;
> +BlockDriverState *bs;
> +uint8_t *buf;
> +
> +block_mig_state->sectors_per_block = bdrv_get_sectors_per_chun
On 11/26/09 12:20, Hannes Reinecke wrote:
Gerd Hoffmann wrote:
/me looks at drivers/scsi/sd.c:sd_done()
I can't see any sane way to tell linux that the request was too big.
residuals is the key:
drivers/scsi/scsi.c:scsi_finish_command()
good_bytes = scsi_bufflen(cmd);
if (
Gerd Hoffmann wrote:
> On 11/26/09 12:20, Hannes Reinecke wrote:
>> Gerd Hoffmann wrote:
>>> /me looks at drivers/scsi/sd.c:sd_done()
>>>
>>> I can't see any sane way to tell linux that the request was too big.
>>>
>> residuals is the key:
>>
>> drivers/scsi/scsi.c:scsi_finish_command()
>>
>>
>>
Hi,
First batch of scsi patches. They bring some data structure unification
and a bunch of fixes and cleanups. In preparation for the other scsi
patches, but also useful on its own IMHO, so I'm hoping for a quick and
painless merge.
The major interface rewrite which needs more discussion and
Create generic functions to allocate, find and release SCSIRequest
structs. Make scsi-disk and scsi-generic use them.
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c | 31 +++
hw/scsi-disk.c| 27 ---
hw/scsi-generic.c | 29 +++
Changes:
* Move from open-coded lists to QTAILQ macros.
* Move the struct elements to the common data structures
(SCSIDevice + SCSIRequest).
* Drop free request pools.
* Fix request cleanup in the destroy callback.
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c |1 +
hw/scsi-disk.
Also delete the leftover and unused scsi-disk.h file.
Signed-off-by: Gerd Hoffmann
---
hw/esp.h |5
hw/scsi-disk.h | 67
hw/scsi.h |4 +-
3 files changed, 7 insertions(+), 69 deletions(-)
delete mode 100644 hw/sc
Rename the SCSIRequest structs in scsi-disk.c and scsi-generic.c to
SCSIDiskReq and SCSIGenericReq. Create a SCSIRequest struct and move
the common elements over.
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c| 109 ++---
hw/scsi-generic.c |
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c|1 +
hw/scsi-generic.c | 13 ++---
hw/scsi.h |1 +
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index b0eceaf..6b5674b 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
Signed-off-by: Gerd Hoffmann
---
hw/scsi-generic.c | 15 ++-
hw/scsi.h |6 ++
2 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index f63d83d..ac0b3ec 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -42,7
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c | 10 ++
hw/scsi-disk.c |8
hw/scsi.h |9 +
3 files changed, 23 insertions(+), 4 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index e250e4f..666ca3c 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c | 46 ++
hw/scsi-generic.c | 40 +---
hw/scsi.h |7 +++
3 files changed, 54 insertions(+), 39 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-
Also add and use the scsi_req_complete() helper function for calling the
completion callback.
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c |9 +
hw/scsi-disk.c| 13 -
hw/scsi-generic.c | 18 --
hw/scsi.h |2 ++
4 files changed, 27
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c | 40
1 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 6b5674b..4e92910 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -379,16 +379,16 @@ static i
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c|1 +
hw/scsi-generic.c | 23 +++
hw/scsi.h |1 +
3 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index c18b7f0..0a8b8bb 100644
--- a/hw/scsi-disk.c
+++ b/hw/
Add helper functions for scsi request parsing to common code. Getting
command length, transfer size, and linear block address is handled.
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c | 164 +
hw/scsi-generic.c | 156 ---
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c| 63 ++---
hw/scsi-generic.c | 23 +--
hw/scsi.h |1 +
3 files changed, 43 insertions(+), 44 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 2eac40
Move REQUEST_SENSE emulation from scsi_send_command() to
scsi_disk_emulate_command().
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c | 38 +++---
1 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index f851694..759
Largely based on from linux. Added into the tree so we
can use the defines everywhere, not just in scsi-generic.c (which is
linux-specific).
Signed-off-by: Gerd Hoffmann
---
hw/scsi-defs.h| 156 +
hw/scsi-disk.c| 41 ++
Handy for debugging.
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c | 114 +
hw/scsi.h |1 +
2 files changed, 115 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index 2e4fd38..e362671 100644
--- a/hw/scsi
Move RESERVE+RELEASE emulation from scsi_send_command() to
scsi_disk_emulate_command().
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c | 40
1 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index f94d513.
Move SERVICE_ACTION_IN emulation from scsi_send_command() to
scsi_disk_emulate_command().
Also add SERVICE_ACTION_IN to scsi-defs.h and scsi_command_name().
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c |1 +
hw/scsi-defs.h |1 +
hw/scsi-disk.c | 67 ++---
Move INQUIRY emulation from scsi_send_command() to
scsi_disk_emulate_command(). Also split the longish INQUITY emulation
code into the new scsi_disk_emulate_inquiry() function. Serial number
handling is slightly changed, we don't copy it any more but look it up
directly in DriveInfo which we have
Move START_STOP emulation from scsi_send_command() to
scsi_disk_emulate_command().
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 06289c3..11e85f2 100644
--- a/hw/scsi-dis
Move VERIFY emulation from scsi_send_command() to
scsi_disk_emulate_command().
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 1507bcd..2910782 100644
--- a/hw/scsi-disk.c
+++ b/hw
Move GET_CONFIGURATION emulation from scsi_send_command() to
scsi_disk_emulate_command().
Also add GET_CONFIGURATION to scsi-defs.h and scsi_command_name().
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c |1 +
hw/scsi-defs.h |1 +
hw/scsi-disk.c | 16
3 files changed
Add READ_16 + friends to scsi-defs.h, scsi_command_name() and the
request parsing helper functions.
Use them in scsi-disk.c too.
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c |8
hw/scsi-defs.h |3 +++
hw/scsi-disk.c |6 --
3 files changed, 15 insertions(+), 2 deletio
Add new scsi_disk_emulate_command() function, which will -- when
finished -- handle all scsi disk command emulation except actual I/O
(READ+WRITE commands) which goes to the block layer. The function
builds on top of the new SCSIRequest struct.
SCSI command emulation code is moved over from scsi_
Move ALLOW_MEDIUM_REMOVAL emulation from scsi_send_command() to
scsi_disk_emulate_command().
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 11e85f2..7d59998 100644
--- a/hw/scsi
Move REPORT_LUNS emulation from scsi_send_command() to
scsi_disk_emulate_command().
Also add REPORT_LUNS to scsi-defs.h and scsi_command_name().
Signed-off-by: Gerd Hoffmann
---
hw/scsi-bus.c |1 +
hw/scsi-defs.h |1 +
hw/scsi-disk.c | 16
3 files changed, 10 inserti
Move SYNCHRONIZE_CACHE emulation from scsi_send_command() to
scsi_disk_emulate_command().
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 4f56a22..865c5db 100644
--- a/hw/scsi-di
Move READ_CAPACITY emulation from scsi_send_command() to
scsi_disk_emulate_command().
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c | 55 +++
1 files changed, 27 insertions(+), 28 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
i
Move READ_TOC emulation from scsi_send_command() to
scsi_disk_emulate_command(). Add scsi_disk_emulate_read_toc() function
which holds the longisch READ_TOC emulation code.
Signed-off-by: Gerd Hoffmann
---
hw/scsi-disk.c | 80 +--
1 files ch
Move MODE_SENSE emulation from scsi_send_command() to
scsi_disk_emulate_command(). Create two helper functions:
mode_sense_page() which writes the actual mode pages and
scsi_disk_emulate_mode_sense() which holds the longish MODE_SENSE
emulation code, calling into mode_sense_page() as needed.
Sign
On 11/26/09 15:27, Hannes Reinecke wrote:
Gerd Hoffmann wrote:
sd_done() tries to figure how many sectors it actually got for serious
errors. I don't feel signaling "medium error" for the first sector
behind our limit just because we'd like to have smaller requests.
scsi_end_request is being
On 11/21/2009 12:36 AM, Kevin O'Connor wrote:
It looks like I spoke too soon. It appears the SeaBIOS init can leave
the ATA controller in an interrupts disabled state. This appears to
confuse Vista. So, this is a SeaBIOS bug - I'll implement a fix.
I've committed a fix to SeaBIOS - co
Gerd Hoffmann wrote:
> On 11/26/09 15:27, Hannes Reinecke wrote:
>> Gerd Hoffmann wrote:
>>> sd_done() tries to figure how many sectors it actually got for serious
>>> errors. I don't feel signaling "medium error" for the first sector
>>> behind our limit just because we'd like to have smaller req
This patchset adds support for mandatory interupt
status and interrupt disable bits to all
PCI devices. This is required for PCI compliancy.
These patches are on top of my pci tree,
including Isaku Yamahata's fixes.
If this is a problem, let me know and
I will rebase.
This works fine for me, but
This rearranges code in preparation for interrupt state
implementation.
Changes:
- split up but walk away from interrupt handling
into a subroutine
- change irq_state from an array to bitmask
- verify that irq_state values are 0 or 1 on load
There are no functiona
Interrupt disable bit is mandatory in PCI spec.
Implement it to make devices spec compliant.
Signed-off-by: Michael S. Tsirkin
---
hw/pci.c | 29 +++--
hw/pci.h |1 +
2 files changed, 28 insertions(+), 2 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index f83ea93..
Jan Kiszka wrote on 26/11/2009 15:53:49:
> > +qemu_get_buffer(f, buf,
> > +BLOCK_SIZE);
> > +if(bs != NULL) {
> > +
> > +bdrv_write(bs, (addr >> SECTOR_BITS),
> > + buf, block_mig_state->sectors_per_bl
Hi!
qemu build on fedora 10 fails with:
/root/scm/qemu/fpu/softfloat-native.c:132:5: error: "HOST_LONG_BITS" is not
defined
make[1]: *** [fpu/softfloat-native.o] Error 1
make: *** [subdir-x86_64-softmmu] Error 2
just sticking
#define HOST_LONG_BITS 64
in fpu/softfloat-native.c helps, but what
interrupt status is a mandatory feature in PCI spec,
so devices must implement it to be spec compliant.
Signed-off-by: Michael S. Tsirkin
---
hw/pci.c | 26 +-
hw/pci.h |1 +
2 files changed, 26 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 1
On Thu, Nov 26, 2009 at 10:19:57AM +0200, Gleb Natapov wrote:
> On Thu, Nov 26, 2009 at 03:12:53AM -0500, Kevin O'Connor wrote:
> > IMO, the ram at 0xf needs to get migrated just like the rest of
> > the ram.
> And it is! The old BIOS is running after migration. But on the first reset
> after m
On Sun, Nov 22, 2009 at 09:40:52AM -0600, Anthony Liguori wrote:
> Michael S. Tsirkin wrote:
>> Here's the list of patches on my pci fixes tree:
>> git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git pci
>>
>> Here are the pci fixes I know of that haven't been applied already.
>> They mostly
Liran Schour wrote:
> Jan Kiszka wrote on 26/11/2009 15:53:49:
>
>
>>> +qemu_get_buffer(f, buf,
>>> +BLOCK_SIZE);
>>> +if(bs != NULL) {
>>> +
>>> +bdrv_write(bs, (addr >> SECTOR_BITS),
>>> + buf, block_
Jan Kiszka wrote:
> Liran Schour wrote:
>> Jan Kiszka wrote on 26/11/2009 15:53:49:
>>
>>
+qemu_get_buffer(f, buf,
+BLOCK_SIZE);
+if(bs != NULL) {
+
+bdrv_write(bs, (addr >> SECTOR_BITS),
+
When we have irqchip in kernel, halted state is kernel
business. So don't initialize it in our code.
Signed-off-by: Glauber Costa
---
hw/apic-kvm.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/apic-kvm.c b/hw/apic-kvm.c
index 089fa45..e5a0bfc 100644
--- a/hw/apic
Hi guys,
This is an early version of smp support in kvm that kinda works.
It has some known problems that I am still tracking. For example,
it does not reset very well. Also, initialization is a bit slow,
probably because of the number of remote ioctl calls involved.
But I believe Jan's patch to d
Since we'll have multiple cpu threads, at least for kvm, we need a way to store
and retrieve the CPUState associated with the current execution thread.
For the I/O thread, this will be NULL.
I am using pthread functions for that, for portability, but we could as well
use __thread keyword.
Signed-
If we are using in-kernel irqchip, halted state belongs in the kernel.
So everytime we grab kernel's idea of mpstate, we also need to propagate
halted state to userspace.
Signed-off-by: Glauber Costa
---
target-i386/kvm.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git
This function is similar to qemu-kvm's on_vcpu mechanism. Totally synchronous,
and guarantees that a given function will be executed at the specified vcpu.
The approach I am taking is to put it under the hood, in kvm_vcpu_ioctl.
This way, the kvm_vcpu_ioctl can be used anywhere, and we guarantee i
This fix a bug with -smp in kvm. Since we have updated apic_base,
we also have to tell kernel about it. So instead of just updating
mp_state, update every regs.
Signed-off-by: Glauber Costa
---
hw/apic-kvm.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/apic-kvm
We don't support smp without irqchip in kernel, so only abort in
that situation
Signed-off-by: Glauber Costa
---
kvm-all.c | 18 +++---
1 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index dbd69f3..4134be3 100644
--- a/kvm-all.c
+++ b/kvm-all.
All reset functions are called from the same place, and this was a leftover
Signed-off-by: Glauber Costa
---
kvm-all.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 28f7ab7..dbd69f3 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -204,8 +204,6 @@
Very lengthy discussion, apologies if I repeat something in one of the
various threads but I read lots of these discussions and I'm somewhat
confused still of what this is all about...
On Wed, Nov 25, 2009 at 04:09:55PM +0200, Michael S. Tsirkin wrote:
> We were discussing features that are (mostl
On 26 nov. 2009, at 16:50, Liran Schour wrote:
>
> Jan Kiszka wrote on 26/11/2009 15:53:49:
>
>
>>> +qemu_get_buffer(f, buf,
>>> +BLOCK_SIZE);
>>> +if(bs != NULL) {
>>> +
>>> +bdrv_write(bs, (addr >> SECTOR_BITS),
>>> +
On Wed, 2009-11-25 at 20:36 +, Blue Swirl wrote:
> On Wed, Nov 25, 2009 at 6:49 PM, Mark McLoughlin wrote:
> > A replacement for qemu_new_vlan_client(), using NetClientInfo to
> > replace most arguments.
>
> > +VLANClientState *qemu_new_net_client(NetClientInfo *info,
> > +
Hi,
While reading the block migration code I couldn't resist cleaning it up.
Among other things I replaced the lists by simple queues from NetBSD
(it can probably be useful for other subsystems).
block-migration.c | 486 ++---
block-migration.h |
Signed-off-by: Pierre Riteau
---
qemu-queue.h | 109 +++--
1 files changed, 105 insertions(+), 4 deletions(-)
diff --git a/qemu-queue.h b/qemu-queue.h
index 8877efd..1d07745 100644
--- a/qemu-queue.h
+++ b/qemu-queue.h
@@ -1,8 +1,9 @@
-/*
1 - 100 of 138 matches
Mail list logo
