[Qemu-devel] Re: [PATCH V6 18/32] pci: remove bus_num member from struct PCIBus.

On Tue, Nov 10, 2009 at 05:46:40PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 10, 2009 at 05:33:22PM +0200, Michael S. Tsirkin wrote: > > On Fri, Oct 30, 2009 at 09:21:12PM +0900, Isaku Yamahata wrote: > > > Since It can be retrieved from pci configuration space, > > > the member is unnecessary

[Qemu-devel] Re: [PATCH V6 19/32] pci: make pci configuration transaction more accurate.

On Tue, Nov 10, 2009 at 05:49:55PM +0200, Michael S. Tsirkin wrote: > On Fri, Oct 30, 2009 at 09:21:13PM +0900, Isaku Yamahata wrote: > > This patch sorts out/enhances pci code to track pci bus topology > > more accurately. > > - Track host bus bridge with pci domain number. Although the > > curr

[Qemu-devel] Problems with bridge Networking

Well Maybe I know for some of you its a very commented and boring subject, :( But Im very desesperate. I use ubuntu 9.04 and i emulate a winxp I have the next problem I configure the tun/tap and all great any error, I have an IP from my dhcp, I can see my virtual machine (winxp) from my other

[Qemu-devel] Re: [PATCH V6 28/32] pci: initialize pci config headers depending it pci header type.

On Tue, Nov 03, 2009 at 04:27:18PM +0200, Michael S. Tsirkin wrote: > On Fri, Oct 30, 2009 at 09:21:22PM +0900, Isaku Yamahata wrote: > > - Only sets default subsystem id for header type 00.(normal header type) > > because header type 01 doesn't have subsystem id, and uses the register > > for

Re: [Qemu-devel] load-store experiment...

On Wed, Nov 11, 2009 at 7:41 AM, Laurent Desnogues < laurent.desnog...@gmail.com> wrote: > > > This version of tcg_out_mov for i386's tcg-target.c filters out the > > > > mov %ebx, %edx > > mov %ebx, [some index] > > mov %edx, %ebx > > The question is: what TCG sequence produces this kind of code

[Qemu-devel] [PATCH 06/20] pci: shorten pci_host_{conf, data}_register_xxx function a bit.

pci_host_data_register_io_memory and its variants are too long a bit. So shorten them. Now they are pci_host_{conf, data}_register_{mmio, mmio_noswap, ioport}() Signed-off-by: Isaku Yamahata --- hw/apb_pci.c |4 ++-- hw/grackle_pci.c |8 hw/pci_host.c|8 hw/

[Qemu-devel] [PATCH 09/20] pci_host: remove unnecessary & 0xff.

This patch removes unnecessary & 0xff in pci_dev_find_by_addr(). Signed-off-by: Isaku Yamahata --- hw/pci_host.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/pci_host.c b/hw/pci_host.c index cd2ceb7..672d173 100644 --- a/hw/pci_host.c +++ b/hw/pci_host.c @@ -42

[Qemu-devel] [PATCH 02/20] pci: move pci_data_{read, write}() declaration from pci.h to pci_host.h

Now pci host stuff has been moved from pci.[hc] to pci_host.[hc] so the declaration of pci_data_{read, write}() should be in pci_host.h This patch moves them from pci.h to pci_host.h for consistency. Signed-off-by: Isaku Yamahata --- hw/pci.h |2 -- hw/pci_host.h |3 +++ 2 files cha

[Qemu-devel] [PATCH 01/20] pci: fix pci_info_device().

It printed wrong limit value of bridge. This patch fixes it. Signed-off-by: Isaku Yamahata --- hw/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 2ab1117..4169d4f 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -985,7 +985,7 @@ static void pci_in

[Qemu-devel] [PATCH 15/20] pci: clean up of pci_update_mappings()

This patch converts r->size == 0 to !r_size. Signed-off-by: Isaku Yamahata --- hw/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 9698efb..cae3d53 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -732,7 +732,7 @@ static void pci_update_mappings(PC

[Qemu-devel] [PATCH 12/20] pci: remove some unnecessary comment in pci.h

This patch removes some comment which should go into commit log in pci.h. Signed-off-by: Isaku Yamahata --- hw/pci.h | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index cd04189..988d2c0 100644 --- a/hw/pci.h +++ b/hw/pci.h @@ -382,17 +382,

[Qemu-devel] [PATCH 00/20] PCI express clean up patches.

Here is the patch series to clean up PCI express patches. Although there remained some issues to address, the PCI express patches was commited while I wasn't responsive last week. (Sorry for that) This patch series addresses the remained issues. They are mostly trivial fixes or cosmetics suggested

[Qemu-devel] [PATCH 08/20] pci: s/pci_find_host_bus/pci_find_root_bus/g

This patch renames pci_find_host_bus() to pci_find_root_bus() as suggested by "Michael S. Tsirkin" . Signed-off-by: Isaku Yamahata --- hw/pci-hotplug.c |4 ++-- hw/pci.c |8 hw/pci.h |2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/pci

[Qemu-devel] [PATCH 03/20] pci: simplify pci_data_read(), pcie_mmcfg_data_read().

simplify ugly switch by memcpy trick. And add one assert(). Signed-off-by: Isaku Yamahata --- hw/pci_host.c | 16 hw/pcie_host.c | 16 2 files changed, 8 insertions(+), 24 deletions(-) diff --git a/hw/pci_host.c b/hw/pci_host.c index f4518dc..4196ebc 10064

[Qemu-devel] [PATCH 11/20] pci: clean up of pci_init_wmask().

This patch replaces for loop by memset in pci_init_wmask(). Signed-off-by: Isaku Yamahata --- hw/pci.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 67818b7..9698efb 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -426,15 +426,15 @@ static void p

[Qemu-devel] [PATCH 05/20] pci: rename pci_addr_to_dev(), pcie_mmcfg_addr_to_dev().

This patch renames pci_addr_to_dev(), pcie_mmcfg_addr_to_dev() to pci_dev_find_by_addr(), pcie_dev_find_by_mmcfg_addr() as "Michael S. Tsirkin" suggested. Signed-off-by: Isaku Yamahata --- hw/pci_host.c |6 +++--- hw/pcie_host.c |7 --- 2 files changed, 7 insertions(+), 6 deletions

[Qemu-devel] [PATCH 07/20] pci: remove pci_sub_bus() by open coding.

Because pci_sub_bus() is used only once so eliminate it by open coding as suggested by "Michael S. Tsirkin" . Signed-off-by: Isaku Yamahata --- hw/pci.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 4169d4f..bdd4063 100644 --- a/hw/

[Qemu-devel] [PATCH 18/20] pci: fix pci_config_get_io_base().

fix typo in pci_config_get_io_base(). Signed-off-by: Isaku Yamahata --- hw/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index dce445a..d1b884a 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -629,7 +629,7 @@ static uint32_t pci_config_get_io_base(PC

[Qemu-devel] [PATCH 16/20] pci: kill goto in pci_update_mappings()

This patch kills nasty goto in pci_update_mappings(). Signed-off-by: Isaku Yamahata --- hw/pci.c | 54 -- 1 files changed, 28 insertions(+), 26 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index cae3d53..2eff7fe 100644 --- a/hw/pci.c +++ b/

[Qemu-devel] [PATCH 14/20] pci: remove unused constants.

This patch removes unused constants committed by fb23162885f7fd8cf7334bed22c25ac32c7d8b9d. Signed-off-by: Isaku Yamahata --- hw/pci.h |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index 988d2c0..72a476e 100644 --- a/hw/pci.h +++ b/hw/pci.h @

[Qemu-devel] [PATCH 19/20] pci: pci bridge related clean up.

- fix bridge prefetchable memory accesser to check 64bit or not. - use pcibus_t consistently instead mixing pcibus_t and uint64_t. Signed-off-by: Isaku Yamahata --- hw/pci.c | 18 +++--- hw/pci.h |1 + 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/pci.c b/h

[Qemu-devel] [PATCH 17/20] pci: remove magic number, 256 in pci.c

This patch replaces magic number, 256, with ARRAY_SIZE(). Signed-off-by: Isaku Yamahata --- hw/pci.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 2eff7fe..dce445a 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -487,7 +487,8 @@ static PCIDevice *

[Qemu-devel] [PATCH 13/20] pci: move typedef, PCIHostState, PCIExpressHost to qemu-common.h.

This patch moves two typedefs, PCIHostState and PCIExpressHost to qemu-common.h for consistency as PCIBus and PCIDevice are typedefed in qemu-common.h. Signed-off-by: Isaku Yamahata --- hw/pci_host.h |4 ++-- hw/pcie_host.h |4 ++-- qemu-common.h |2 ++ 3 files changed, 6 insertion

[Qemu-devel] [PATCH 20/20] pci: remove goto in pci_bridge_filter().

This patch removes ugly goto in pci_bridge_filter() by introducing subfunction, pci_bridge_filter_nomap(). Signed-off-by: Isaku Yamahata --- hw/pci.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index add919b..90bdf5e 100644 --- a/h

[Qemu-devel] Posting to qemu-devel list

Please add my email id to post to the qemu-devel list. Best, Aditya

[Qemu-devel] Handling Bios Interrupts

How or which section of the QEMU source is actually handling BIOS interrupt call, I have written a new user interrupt 0x79 in BIOS.BIN, but I need to ask QEMU to purposely invoke INT 0x79 call, where this ISR will write some byte info into BDA/BIOS DATA AREA.

[Qemu-devel] [PATCH 10/20] pci: kill unnecessary included in pci.c

including pci_host.h isn't needed by pci.c. This patch kills it. Signed-off-by: Isaku Yamahata --- hw/pci.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index e73f07c..67818b7 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -23,7 +23,6 @@ */ #include "h

[Qemu-devel] [PATCH 04/20] pci: remove pci_addr_to_config() by open code

This patch removes pci_addr_to_config() and open code it as suggested by Michael S. Tsirkin . Signed-off-by: Isaku Yamahata --- hw/pci_host.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/pci_host.c b/hw/pci_host.c index 4196ebc..93c94e8 100644 --- a/hw/pci_

Re: [Qemu-devel] Problems with bridge Networking

On Thu, 2009-11-12 at 03:31 +, Armin Garcia wrote: > I have the next problem I configure the tun/tap and all great any error, > I have an IP from my dhcp, I can see my virtual machine (winxp) from my > other computers, but In my virtual machine I cant connect to internet, > I mean, whe

<    1   2