[Qemu-devel] [PATCH] restore rw support for vvfat

2008-03-11 Thread Carlo Marcelo Arenas Belon
The attached patch, restores support for writable block devices using Virtual FAT disk images. RW support using a generated qcow base image was modified after qemu 0.8.2 was released; while adding AIO support to block-qcow.c in release 1.8; and resulting in a broken qcow image based in an inexiste

Re: [Qemu-devel] [PATCH] restore rw support for vvfat

2008-03-11 Thread Johannes Schindelin
Hi, On Tue, 11 Mar 2008, Carlo Marcelo Arenas Belon wrote: > The attached patch, restores support for writable block devices using > Virtual FAT disk images. > > RW support using a generated qcow base image was modified after qemu > 0.8.2 was released; while adding AIO support to block-qcow.c

[Qemu-devel] Re: [PATCH] Slowdown SDL while minimized

2008-03-11 Thread Samuel Thibault
BTW, it would be good for power consumption to provide a virtual HPET to the guest, and reprogram the host timer as appropriate. 10ms sleeps kill kitten ;) Samuel

[Qemu-devel] [PATCH] Slowdown SDL while minimized

2008-03-11 Thread Samuel Thibault
When SDL is invisible/minimized, there is no need to keep calling the VGA refresh 33 times per second. This patch reduces in that case the rate to 2 times per second, which should be responsive enough for the un-minimizing event. Index: console.h ==

[Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...

2008-03-11 Thread Aurelien Jarno
CVSROOT:/sources/qemu Module name:qemu Changes by: Aurelien Jarno 08/03/11 17:17:59 Modified files: . : block-qcow.c block-qcow2.c block-vmdk.c block.c block.h block_int.h Log message: Fix CVE-2008-0928 - insufficient

Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...

2008-03-11 Thread Fabrice Bellard
IMHO it would be much simpler to do all the tests in the block format handlers. Fabrice. Aurelien Jarno wrote: CVSROOT:/sources/qemu Module name:qemu Changes by: Aurelien Jarno 08/03/11 17:17:59 Modified files: . : block-qcow.c block-qcow2.c block-vmdk.c block.

[Qemu-devel] qemu/target-sparc translate.c

2008-03-11 Thread Blue Swirl
CVSROOT:/cvsroot/qemu Module name:qemu Changes by: Blue Swirl 08/03/11 20:59:03 Modified files: target-sparc : translate.c Log message: Use a TCG global for regwptr CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/target-sparc/translate.c?cvsroot=qemu&r

[Qemu-devel] qemu osdep.h tcg/tcg.c tcg/i386/tcg-target.c tc...

2008-03-11 Thread Blue Swirl
CVSROOT:/cvsroot/qemu Module name:qemu Changes by: Blue Swirl 08/03/11 21:01:03 Modified files: . : osdep.h tcg: tcg.c tcg/i386 : tcg-target.c tcg/sparc : tcg-target.c tcg/x86_64 : tcg-target.c

Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...

2008-03-11 Thread Aurelien Jarno
Fabrice Bellard a écrit : > IMHO it would be much simpler to do all the tests in the block format > handlers. > Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ? > Aurelien Jarno wrote: >> CVSROOT:/sources/qemu >> Module name:qemu >> Changes by:Aurelien Jarno 08/03

Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...

2008-03-11 Thread Fabrice Bellard
Aurelien Jarno wrote: > Fabrice Bellard a écrit : >> IMHO it would be much simpler to do all the tests in the block format >> handlers. >> > > Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ? I suggest reverting the patch and writing correct tests in block-{qcow,qcow2,vmdk}.c. BTW,

Re: [Qemu-devel] [PATCH] Modify qemu-img to mount locally disk image using NBD (v2)

2008-03-11 Thread Fabrice Bellard
Laurent Vivier wrote: > This patch is a new version of qemu-img using NBD device to mount Qemu > disk image. > > To not hang on UP system, it needs following patch: > http://article.gmane.org/gmane.linux.drivers.nbd.general/42 > If you want to use loop to see partitions, you need this patch: > htt

Re: [Qemu-devel] Re: [PATCH] e1000: fix endianness issues

2008-03-11 Thread Aurelien Jarno
On Sat, Mar 08, 2008 at 11:08:48AM -0600, Hollis Blanchard wrote: > On Sat, 2008-03-08 at 14:59 +0100, Aurelien Jarno wrote: > > On Fri, Mar 07, 2008 at 11:23:51AM -0600, Hollis Blanchard wrote: > > > Below is a patch I'm using to fix rtl8139.c for PowerPC/PowerPC > > > target/host combination. It

Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...

2008-03-11 Thread Aurelien Jarno
On Tue, Mar 11, 2008 at 11:43:47PM +0100, Fabrice Bellard wrote: > Aurelien Jarno wrote: > > Fabrice Bellard a écrit : > >> IMHO it would be much simpler to do all the tests in the block format > >> handlers. > >> > > > > Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ? > > I sugge

Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

2008-03-11 Thread Jason Wessel
Marius Groeger wrote: > On Wed, 9 Jan 2008, Marius Groeger wrote: > > >> On Wed, 9 Jan 2008, Marius Groeger wrote: >> >> >>> I'm having problems with qemu's (-M prep, -cpu 604) handling of the >>> MSR_SE bit. My gdbstub can successfully step along regular code, but >>> qemu chokes when st

[Qemu-devel] qemu/target-sh4 op.c translate.c

2008-03-11 Thread Aurelien Jarno
CVSROOT:/sources/qemu Module name:qemu Changes by: Aurelien Jarno 08/03/11 23:22:37 Modified files: target-sh4 : op.c translate.c Log message: SH4, fix several instructions fix instruction code for frchg, fschg, ocbp. fix addre

[Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...

2008-03-11 Thread Aurelien Jarno
CVSROOT:/sources/qemu Module name:qemu Changes by: Aurelien Jarno 08/03/11 23:30:22 Modified files: . : block-qcow.c block-qcow2.c block-vmdk.c block.c block.h block_int.h linux-user : syscall.c Log message:

Re: [Qemu-devel] [PATCH] x86 Multiboot support (extended)

2008-03-11 Thread Aurelien Jarno
On Thu, Jan 31, 2008 at 06:31:09PM +0100, Alexander Graf wrote: > > On Jan 31, 2008, at 10:58 AM, Kevin Wolf wrote: > >> Hi, >> >> I like this idea. When I just tried to load my multiboot kernel it >> failed, though, because of the following piece of code: >> >>> +// XXX: multiboot header may b

Re: [Qemu-devel] Re: 2.6.24 says "serial8250: too much work for irq4" a lot.

2008-03-11 Thread Aurelien Jarno
On Sun, Feb 10, 2008 at 11:26:06AM +, Paul Brook wrote: > On Sunday 10 February 2008, Blue Swirl wrote: > > On 2/9/08, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > > > Blue Swirl wrote: > > > >> If you look at the patch, there are no timing dependencies; the only > > > >> parameter is the depth

Re: [Qemu-devel] [PATCH] Slowdown SDL while minimized

2008-03-11 Thread Anders
Samuel Thibault wrote: When SDL is invisible/minimized, there is no need to keep calling the VGA refresh 33 times per second. This patch reduces in that case the rate to 2 times per second, which should be responsive enough for the un-minimizing event. Is there any need to update at all, if

Re: [Qemu-devel] [PATCH] fix ncurses output

2008-03-11 Thread Aurelien Jarno
On Mon, Feb 25, 2008 at 06:48:06PM +0100, Bernhard Kauer wrote: > The ncurses console uses mvwaddchnstr() to print a line of output > to a ncurses pad. Unfortunately this routine stops to print further > chars if a zero-char is seen in the line. This has the effect that > parts of a line are never

Re: [Qemu-devel] [PATCH] Slowdown SDL while minimized

2008-03-11 Thread Samuel Thibault
Anders, le Wed 12 Mar 2008 00:56:42 +0100, a écrit : > Samuel Thibault wrote: > >When SDL is invisible/minimized, there is no need to keep calling the > >VGA refresh 33 times per second. This patch reduces in that case the > >rate to 2 times per second, which should be responsive enough for the >

[Qemu-devel] [patch 02/24] QEMU/KVM: add OperationRegion and GPE handler for add/removal notification

2008-03-11 Thread Marcelo Tosatti
Use GPE _L01 to notify OSPM. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/bios/acpi-dsdt.dsl === --- kvm-userspace.hotplug2.orig/bios/acpi-dsdt.dsl +++ kvm-userspace.hotplug2/bios/acpi-dsdt.dsl @@

[Qemu-devel] [patch 01/24] QEMU/KVM: add devices to represent PCI slots with _EJ0 method

2008-03-11 Thread Marcelo Tosatti
Presence of _EJ0 method indicates that slots are hot-pluggable. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/bios/acpi-dsdt.dsl === --- kvm-userspace.hotplug2.orig/bios/acpi-dsdt.dsl +++ kvm-usersp

[Qemu-devel] [patch 00/24] QEMU ACPI PCI hotplug support

2008-03-11 Thread Marcelo Tosatti
The following patchset allows PCI hot add/remove through ACPI (handled by the acpiphp driver on Linux guests). Comments are welcome. --

[Qemu-devel] [patch 03/24] QEMU/KVM: add pci_find_bus

2008-03-11 Thread Marcelo Tosatti
Return PCIBus pointer from bus number integer. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/hw/pci.c === --- kvm-userspace.hotplug2.orig/qemu/hw/pci.c +++ kvm-userspace.hotplug2/qemu/hw/pci.c

[Qemu-devel] [patch 05/24] QEMU/KVM: pci hotplug GPE support

2008-03-11 Thread Marcelo Tosatti
Enable the corresponding bit on the PCIST region and trigger the SCI. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/hw/acpi.c === --- kvm-userspace.hotplug2.orig/qemu/hw/acpi.c +++ kvm-userspac

[Qemu-devel] [patch 06/24] QEMU/KVM: dynamic drive/drive_opt index allocation

2008-03-11 Thread Marcelo Tosatti
Dynamically allocate drive options and drive table index, so to reused indexes when devices are removed. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/sysemu.h === --- kvm-userspace.hotplug2.o

[Qemu-devel] [patch 07/24] QEMU/KVM: dynamic nic info index allocation

2008-03-11 Thread Marcelo Tosatti
The same, but for nics. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/net.h === --- kvm-userspace.hotplug2.orig/qemu/net.h +++ kvm-userspace.hotplug2/qemu/net.h @@ -46,6 +46,7 @@ struct NICInfo

[Qemu-devel] [patch 04/24] QEMU/KVM: return PCIDevice on net device init and record devfn

2008-03-11 Thread Marcelo Tosatti
Change the PCI network drivers init functions to return the PCIDev, to inform which slot has been hot-plugged. Also record devfn on the NICInfo structure to locate for release on hot-removal. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/hw/e1000.c ===

[Qemu-devel] [patch 09/24] QEMU/KVM: record devfn on block driver instance

2008-03-11 Thread Marcelo Tosatti
Record devfn on the BlockDriverState structure to locate for release on hot-removal. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/block_int.h === --- kvm-userspace.hotplug2.orig/qemu/block_in

[Qemu-devel] [patch 13/24] QEMU/KVM: export get_param_value/check_params

2008-03-11 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/sysemu.h === --- kvm-userspace.hotplug2.orig/qemu/sysemu.h +++ kvm-userspace.hotplug2/qemu/sysemu.h @@ -57,6 +57,10 @@ int qemu_live_loadvm_state(QE

[Qemu-devel] [patch 10/24] QEMU/KVM: move drives_opt for external use

2008-03-11 Thread Marcelo Tosatti
Device hotplug will use that structure from a separate file. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/sysemu.h === --- kvm-userspace.hotplug2.orig/qemu/sysemu.h +++ kvm-userspace.hotplug2/

[Qemu-devel] [patch 12/24] QEMU/KVM: add net_client_uninit

2008-03-11 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/net.h === --- kvm-userspace.hotplug2.orig/qemu/net.h +++ kvm-userspace.hotplug2/qemu/net.h @@ -38,6 +38,7 @@ void do_info_network(void); int hack_a

[Qemu-devel] [patch 14/24] QEMU/KVM: add pci_find_device

2008-03-11 Thread Marcelo Tosatti
Return PCIDevice from bus number and slot. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug/qemu/hw/pci.c === --- kvm-userspace.hotplug.orig/qemu/hw/pci.c +++ kvm-userspace.hotplug/qemu/hw/pci.c @@ -689

[Qemu-devel] [patch 11/24] QEMU/KVM: net/drive add/remove tweaks

2008-03-11 Thread Marcelo Tosatti
Export net/drive add/remove functions for device hotplug usage. Return the table index on add. Return failure instead of exiting if limit has been reached on drive_add. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/vl.c ==

[Qemu-devel] [patch 15/24] QEMU/KVM: virtio_blk_init return PCIDevice pointer

2008-03-11 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/hw/virtio-blk.c === --- kvm-userspace.hotplug2.orig/qemu/hw/virtio-blk.c +++ kvm-userspace.hotplug2/qemu/hw/virtio-blk.c @@ -161,5 +161,5 @@ void *v

[Qemu-devel] [patch 17/24] QEMU/KVM: add cpu_unregister_io_memory and make io mem table index dynamic

2008-03-11 Thread Marcelo Tosatti
So drivers can clear their mem io table entries on exit back to unassigned state. Also make the io mem index allocation dynamic. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/cpu-all.h === -

[Qemu-devel] [patch 19/24] QEMU/KVM: handle SEJ notifications

2008-03-11 Thread Marcelo Tosatti
Handle the _EJ0 notifications. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/hw/acpi.c === --- kvm-userspace.hotplug2.orig/qemu/hw/acpi.c +++ kvm-userspace.hotplug2/qemu/hw/acpi.c @@ -26,6 +26,

[Qemu-devel] [patch 20/24] QEMU/KVM: add qemu_free_irqs

2008-03-11 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/hw/irq.c === --- kvm-userspace.hotplug2.orig/qemu/hw/irq.c +++ kvm-userspace.hotplug2/qemu/hw/irq.c @@ -56,6 +56,12 @@ qemu_irq *qemu_allocate_irqs(

[Qemu-devel] [patch 22/24] QEMU/KVM: LSI SCSI and e1000 unregister callbacks

2008-03-11 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/hw/lsi53c895a.c === --- kvm-userspace.hotplug2.orig/qemu/hw/lsi53c895a.c +++ kvm-userspace.hotplug2/qemu/hw/lsi53c895a.c @@ -1849,6 +1849,18 @@ void

[Qemu-devel] [patch 23/24] QEMU/KVM: zero ioport_opaque on isa_unassign_ioport

2008-03-11 Thread Marcelo Tosatti
If the io port is unassigned, the previous private pointer is meaningless. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/vl.c === --- kvm-userspace.hotplug2.orig/qemu/vl.c +++ kvm-userspace.ho

[Qemu-devel] [patch 24/24] QEMU/KVM: device hot-remove

2008-03-11 Thread Marcelo Tosatti
Add monitor command to hot-remove devices. Remove device data on _EJ0 notification. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/monitor.c === --- kvm-userspace.hotplug2.orig/qemu/monitor.c +

[Qemu-devel] [patch 08/24] QEMU/KVM: drive removal support

2008-03-11 Thread Marcelo Tosatti
To be used by hot-remove. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/vl.c === --- kvm-userspace.hotplug2.orig/qemu/vl.c +++ kvm-userspace.hotplug2/qemu/vl.c @@ -5010,6 +5010,12 @@ static int

[Qemu-devel] [patch 16/24] QEMU/KVM: device and disk hot-add

2008-03-11 Thread Marcelo Tosatti
Add monitor command to hot-add PCI devices (nic and storage). Syntax is: pci_add pcibus nic|storage params It returns the bus slot and function for the newly added device on success. It is possible to attach a disk to a device after PCI initialization via the drive_add command. If so, a manual

[Qemu-devel] [patch 21/24] QEMU/KVM: add pci_unregister_device

2008-03-11 Thread Marcelo Tosatti
Unregister the pci device, unassign its IO and memory regions, and free associated data. Add a callback so drivers can free device state. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/qemu/hw/pci.c ===

[Qemu-devel] [patch 18/24] QEMU/KVM: notify _EJ0 through _SEJ OperationRegion

2008-03-11 Thread Marcelo Tosatti
The _EJ0 method is executed by the OS once it has successfully finished device removal. Inform that event through IO port space so QEMU can free the associated data. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug2/bios/acpi-dsdt.dsl ==

Re: [Qemu-devel] [PATCH] Modify qemu-img to mount locally disk image using NBD (v2)

2008-03-11 Thread Anthony Liguori
Fabrice Bellard wrote: Laurent Vivier wrote: This patch is a new version of qemu-img using NBD device to mount Qemu disk image. To not hang on UP system, it needs following patch: http://article.gmane.org/gmane.linux.drivers.nbd.general/42 If you want to use loop to see partitions, you need

Re: [Qemu-devel] [PATCH] x86 Multiboot support (extended)

2008-03-11 Thread Anthony Liguori
Aurelien Jarno wrote: On Thu, Jan 31, 2008 at 06:31:09PM +0100, Alexander Graf wrote: Is it really necessary to have *that much* assembly code within hw/pc.c? I would rather see multiboot support as a small image generated from C and/or assembly code, loaded either with -hda or with a new op