Re: xen bits broke x32 build

2023-04-12 Thread Philippe Mathieu-Daudé
On 11/4/23 19:30, Michael Tokarev wrote: 11.04.2023 15:09, Peter Maydell wrote: .. Frankly I would prefer to just say "we don't support x32". It's a weird non-standard configuration that as far as I'm aware is very little used. Its stats in the debian popularity-contest graphs peaked at 18 users

Re: xen bits broke x32 build

2023-04-11 Thread Michael Tokarev
11.04.2023 15:09, Peter Maydell wrote: .. Frankly I would prefer to just say "we don't support x32". It's a weird non-standard configuration that as far as I'm aware is very little used. Its stats in the debian popularity-contest graphs peaked at 18 users in 2017, and have mostly been fluctuating

Re: xen bits broke x32 build

2023-04-11 Thread Peter Maydell
On Tue, 11 Apr 2023 at 12:57, Michael Tokarev wrote: > > 01.04.2023 11:40, Michael Tokarev wrote: > > After bringing in xen guest support, qemu fails to build on x32: > > > > target/i386/kvm/xen-emu.c:876:5: note: in expansion of macro > > ‘qemu_build_assert’ > >876 | qemu_build_assert(si

Re: xen bits broke x32 build

2023-04-11 Thread Michael Tokarev
01.04.2023 11:40, Michael Tokarev wrote: After bringing in xen guest support, qemu fails to build on x32: target/i386/kvm/xen-emu.c:876:5: note: in expansion of macro ‘qemu_build_assert’   876 | qemu_build_assert(sizeof(struct vcpu_info) == 64);   | ^ This one shou

Re: xen bits broke x32 build

2023-04-03 Thread David Woodhouse
On Mon, 2023-04-03 at 08:46 +0200, Philippe Mathieu-Daudé wrote: > > > Well. Maybe xen support should be disabled entirely on x32. > > > Or maybe x32 should be declared as unsupported entirely. > > > I dunno. > > > > We rely heavily on the struct layouts being precisely the same, > > since these a

Re: xen bits broke x32 build

2023-04-02 Thread Philippe Mathieu-Daudé
On 1/4/23 14:10, David Woodhouse wrote: On 1 April 2023 12:57:33 BST, Michael Tokarev wrote: 01.04.2023 14:45, Joao Martins пишет: On 01/04/2023 09:40, Michael Tokarev wrote: After bringing in xen guest support, qemu fails to build on x32: Adding the folks who added the feature too target/

Re: xen bits broke x32 build

2023-04-01 Thread David Woodhouse
On 1 April 2023 12:57:33 BST, Michael Tokarev wrote: >01.04.2023 14:45, Joao Martins пишет: >> On 01/04/2023 09:40, Michael Tokarev wrote: >>> After bringing in xen guest support, qemu fails to build on x32: >>> Adding the folks who added the feature too >> >>> target/i386/kvm/xen-emu.c:876:5:

Re: xen bits broke x32 build

2023-04-01 Thread Michael Tokarev
To clarify: I don't think this needs fixing for 8.0. Yes, it's a regression on x32. Xen has never worked on x32, this just looks like forgotten case when it needs to be disabled in qemu for x86. It's trivial to work around by adding a --disable argument to configure. And generally I don't know

Re: xen bits broke x32 build

2023-04-01 Thread Michael Tokarev
01.04.2023 14:45, Joao Martins пишет: On 01/04/2023 09:40, Michael Tokarev wrote: After bringing in xen guest support, qemu fails to build on x32: Adding the folks who added the feature too target/i386/kvm/xen-emu.c:876:5: note: in expansion of macro ‘qemu_build_assert’   876 | qemu_buil

Re: xen bits broke x32 build

2023-04-01 Thread Joao Martins
On 01/04/2023 09:40, Michael Tokarev wrote: > After bringing in xen guest support, qemu fails to build on x32: > Adding the folks who added the feature too > target/i386/kvm/xen-emu.c:876:5: note: in expansion of macro > ‘qemu_build_assert’ >   876 | qemu_build_assert(sizeof(struct vcpu_info)

xen bits broke x32 build

2023-04-01 Thread Michael Tokarev
After bringing in xen guest support, qemu fails to build on x32: target/i386/kvm/xen-emu.c:876:5: note: in expansion of macro ‘qemu_build_assert’ 876 | qemu_build_assert(sizeof(struct vcpu_info) == 64); | ^ This one should be easy to fix, but I wonder if there are