Re: absolute firmware path made relocatable in qemu 5.2.0

2021-01-13 Thread Paolo Bonzini
On 13/01/21 08:51, Dave wrote: [,br=bridge][,helper=helper][,sndbuf=nbytes][,vnet_hdr=on|off][,vhost=on|off]     use network helper 'helper' (default=/nonexistent/libexec/qemu-bridge-helper) to -netdev bridge,id=str[,br=bridge][,helper=helper]     using the program

Re: absolute firmware path made relocatable in qemu 5.2.0

2021-01-12 Thread Dave
This is my qemu binary compiled with --prefix=/nonexistent bash-5.1# ./qemu-system-x86_64 -L help /usr/share/qemu /usr/share/qemu-firmware /usr/src/sources/qemu-5.2.0/build/pc-bios bash-5.1# ./qemu-system-x86_64 --help|grep helper [,br=bridge][,helper=helper][,sndbuf=nbytes][,vnet_hdr=on|off][

Re: absolute firmware path made relocatable in qemu 5.2.0

2021-01-12 Thread Paolo Bonzini
On 12/01/21 18:04, Dave wrote: Thanks Paola, We are still in testing and that's the only thing we've uncovered so far with the new 5.2.0. I will post if the ops guys find anything else. Hmm, that's weird though. The path to the default bridge helper is relocated: net/tap.c:helper

Re: absolute firmware path made relocatable in qemu 5.2.0

2021-01-12 Thread Dave
Thanks Paola, We are still in testing and that's the only thing we've uncovered so far with the new 5.2.0. I will post if the ops guys find anything else. Dave On 12/01/2021 20:53, Paolo Bonzini wrote: Il mar 12 gen 2021, 17:48 Dave mailto:d...@0bits.com>> ha scritto: Hi Paolo,

Re: absolute firmware path made relocatable in qemu 5.2.0

2021-01-12 Thread Paolo Bonzini
Il mar 12 gen 2021, 17:48 Dave ha scritto: > Hi Paolo, > > While this (option 2) partially works, it will still search for > /nonexistent/libexec/qemu-bridge-helper for example so seems that some > paths are still absolute and some relative. > Ok, that's a bug that can be fixed in 5.2.1. Are the

Re: absolute firmware path made relocatable in qemu 5.2.0

2021-01-12 Thread Dave
Hi Paolo, While this (option 2) partially works, it will still search for /nonexistent/libexec/qemu-bridge-helper for example so seems that some paths are still absolute and some relative. To explain, what we are expecting that we compile one binary with the relevant options, test that and t

Re: absolute firmware path made relocatable in qemu 5.2.0

2021-01-12 Thread Paolo Bonzini
On 12/01/21 15:05, Dave wrote: Is seem that absolute firmwarepath compilation option is converted  to relocatable in 5.2.0 qemu. # QEMU configure log Tue 12 Jan 14:46:41 GST 2021 # Configured with: '../configure' '--prefix=/usr' '--sysconfdir=/etc/qemu' '--disable-bochs' '*--firmwarepath=/us

absolute firmware path made relocatable in qemu 5.2.0

2021-01-12 Thread Dave
Hi, Is seem that absolute firmwarepath compilation option is converted  to relocatable in 5.2.0 qemu. # QEMU configure log Tue 12 Jan 14:46:41 GST 2021 # Configured with: '../configure' '--prefix=/usr' '--sysconfdir=/etc/qemu' '--disable-bochs'  '*--firmwarepath=/usr/share/qemu:/usr/share/qe