Re: Using json: in common.rc's TEST_IMG

2023-06-01 Thread Stefan Hajnoczi
Thanks, Hanna and Kevin! I didn't implement bdrv_parse_filename() because I didn't want to invent more legacy syntax. But maybe that legacy syntax does have a use and I just didn't realize it :). It's easy for io_uring, we can just take the filename and not worry about other parameters (they can

Re: Using json: in common.rc's TEST_IMG

2023-06-01 Thread Kevin Wolf
Am 31.05.2023 um 21:00 hat Stefan Hajnoczi geschrieben: > Hi Hanna, > I'm adding the io_uring block driver (block/blkio.c) to qemu-iotests > and hit a syntax issue with json:. > > In tests/qemu-iotests/common.rc where TEST_IMG_FILE and TEST_IMG are > defined for each IMGPROTO, I'm unable to come u

Re: Using json: in common.rc's TEST_IMG

2023-06-01 Thread Hanna Czenczek
On 31.05.23 21:09, Stefan Hajnoczi wrote: Another issue is that 145 uses $TEST_IMG as follows: SYSEMU_DRIVE_ARG=if=none,file="$TEST_IMG",driver=$IMGFMT That doesn't work when json: contains a comma, since commas need to be doubled up to escape them. This fails: $ qemu-system-x86_64 -driv

Re: Using json: in common.rc's TEST_IMG

2023-05-31 Thread Stefan Hajnoczi
Another issue is that 145 uses $TEST_IMG as follows: SYSEMU_DRIVE_ARG=if=none,file="$TEST_IMG",driver=$IMGFMT That doesn't work when json: contains a comma, since commas need to be doubled up to escape them. This fails: $ qemu-system-x86_64 -drive 'if=none,file=json:{"driver":"io_uring","fil

Using json: in common.rc's TEST_IMG

2023-05-31 Thread Stefan Hajnoczi
Hi Hanna, I'm adding the io_uring block driver (block/blkio.c) to qemu-iotests and hit a syntax issue with json:. In tests/qemu-iotests/common.rc where TEST_IMG_FILE and TEST_IMG are defined for each IMGPROTO, I'm unable to come up with a TEST_IMG that works with all test cases. Some test cases wa