Re: discard and v2 qcow2 images

2020-03-23 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 02:35:44PM -0500, Eric Blake wrote: > On 3/20/20 1:58 PM, Alberto Garcia wrote: > > Hi, > > > > when full_discard is false in discard_in_l2_slice() then the selected > > cluster should be deallocated and it should read back as zeroes. This > > is done by clearing the cluste

Re: discard and v2 qcow2 images

2020-03-20 Thread Alberto Garcia
On Fri 20 Mar 2020 08:35:44 PM CET, Eric Blake wrote: >> This flag is however only supported when qcow_version >= 3. In older >> images the cluster is simply deallocated, exposing any possible >> previous data from the backing file. > > Discard is advisory, and has no requirements that discarded d

Re: discard and v2 qcow2 images

2020-03-20 Thread Eric Blake
On 3/20/20 1:58 PM, Alberto Garcia wrote: Hi, when full_discard is false in discard_in_l2_slice() then the selected cluster should be deallocated and it should read back as zeroes. This is done by clearing the cluster offset field and setting OFLAG_ZERO in the L2 entry. This flag is however onl